Re: fib_rules w. RCU lock [PATCH]

2006-02-02 Thread David S. Miller
From: Robert Olsson <[EMAIL PROTECTED]> Date: Fri, 27 Jan 2006 14:20:39 +0100 > The preempts are removed and an updated version of the patch is enclosed. Applied to net-2.6.17, thanks Robert. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL P

Re: fib_rules w. RCU lock [PATCH]

2006-01-27 Thread Robert Olsson
David S. Miller writes: > > + r = (struct fib_rule *) fib_rules.first; > I don't think this is right. > fib_rules.first is a pointer to the hlist_node (within the fib_rule) > not the fib_rule itself. It works because the hlist_node is the first member of the struct fib_rule but I agree i

Re: fib_rules w. RCU lock [PATCH]

2006-01-26 Thread David S. Miller
From: Robert Olsson <[EMAIL PROTECTED]> Date: Thu, 22 Dec 2005 10:51:46 +0100 > @@ -219,28 +230,27 @@ > if (rta[RTA_FLOW-1]) > memcpy(&new_r->r_tclassid, RTA_DATA(rta[RTA_FLOW-1]), 4); > #endif > - > - rp = &fib_rules; > + r = (struct fib_rule *) fib_rules.first; >