Re: kernel BUG in ipmr_queue_xmit()

2015-10-30 Thread Florian Westphal
Eric Dumazet wrote: > > Signed-off-by: Ani Sinha > > --- > > net/ipv4/ipmr.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c > > index 866ee89..48df3cc 100644 > > --- a/net/ipv4/ipmr.c > > +++

Re: kernel BUG in ipmr_queue_xmit()

2015-10-30 Thread Florian Westphal
Hannes Frederic Sowa wrote: > > > > @@ -936,7 +936,9 @@ static void ipmr_cache_resolve(struct net *net, > > > > struct mr_table *mrt, > > > > > > > > rtnl_unicast(skb, net, NETLINK_CB(skb).portid); > > > > } else { > > > > +

Re: kernel BUG in ipmr_queue_xmit()

2015-10-30 Thread Hannes Frederic Sowa
On Fri, Oct 30, 2015, at 11:36, Florian Westphal wrote: > Eric Dumazet wrote: > > > Signed-off-by: Ani Sinha > > > --- > > > net/ipv4/ipmr.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c > > >

Re: kernel BUG in ipmr_queue_xmit()

2015-10-30 Thread Eric Dumazet
On Fri, 2015-10-30 at 11:48 +0100, Florian Westphal wrote: > Hannes Frederic Sowa wrote: > > > > > @@ -936,7 +936,9 @@ static void ipmr_cache_resolve(struct net *net, > > > > > struct mr_table *mrt, > > > > > > > > > > rtnl_unicast(skb, net,

Re: kernel BUG in ipmr_queue_xmit()

2015-10-30 Thread Eric Dumazet
On Fri, 2015-10-30 at 10:47 -0700, Ani Sinha wrote: > for 32 bit archs, it does in SNMP_ADD_STATS64_USER() Sure. But x86 these days is 64bit, at 99 % maybe. We do not make changes that looks 'maybe better' for i486 or i586 Just do the same that multiple similar patches did. Example :

Re: kernel BUG in ipmr_queue_xmit()

2015-10-30 Thread Ani Sinha
On Fri, Oct 30, 2015 at 4:00 AM, Eric Dumazet wrote: > On Fri, 2015-10-30 at 11:48 +0100, Florian Westphal wrote: >> Hannes Frederic Sowa wrote: >> > > > > @@ -936,7 +936,9 @@ static void ipmr_cache_resolve(struct net *net, >> > > > > struct

Re: kernel BUG in ipmr_queue_xmit()

2015-10-30 Thread Ani Sinha
On Fri, Oct 30, 2015 at 12:12 PM, Eric Dumazet wrote: > On Fri, 2015-10-30 at 10:47 -0700, Ani Sinha wrote: > >> for 32 bit archs, it does in SNMP_ADD_STATS64_USER() > > Sure. But x86 these days is 64bit, at 99 % maybe. > > We do not make changes that looks 'maybe better'

Re: kernel BUG in ipmr_queue_xmit()

2015-10-29 Thread Eric Dumazet
On Thu, 2015-10-29 at 18:41 -0700, Ani Sinha wrote: > > Signed-off-by: Ani Sinha > --- > net/ipv4/ipmr.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c > index 866ee89..48df3cc 100644 > --- a/net/ipv4/ipmr.c > +++