Re: linux-4.2-rc2/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1993: possible bad error checking ?

2015-07-14 Thread Giuseppe CAVALLARO
Hello David thx to have looked at this. I'll check the code and eventually fix it, unless you already have a patch to propose. Kind Regards Peppe On 7/13/2015 11:48 AM, David Binderman wrote: Hello there, [linux-4.2-rc2/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1993]: (style)

linux-4.2-rc2/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1993: possible bad error checking ?

2015-07-13 Thread David Binderman
Hello there, [linux-4.2-rc2/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1993]: (style) Checking if unsigned variable 'entry' is less than zero. Source code is     entry = priv-hw-mode-jumbo_frm(priv, skb, csum_insertion);     if (unlikely(entry 0))     goto dma_map_err;