Re: mpls's find_outdev()

2016-04-07 Thread roopa
On 4/7/16, 6:41 PM, David Miller wrote: > While auditing something unrelated, I noticed that this function seems > to potentially dev_put() on an error pointer. > > I guess the problem comes from the fact that there are two methods > by which the device pointer is obtained. > > First,

mpls's find_outdev()

2016-04-07 Thread David Miller
While auditing something unrelated, I noticed that this function seems to potentially dev_put() on an error pointer. I guess the problem comes from the fact that there are two methods by which the device pointer is obtained. First, inet{,6}_fib_lookup_dev() which uses error pointers. Second,