Re: netif_poll_enable() barrier

2006-12-28 Thread David Miller
From: Benjamin Herrenschmidt [EMAIL PROTECTED] Date: Wed, 20 Dec 2006 14:44:12 +1100 I stumbled accross what might be a bug on out of order architecture: netif_poll_enable() only does a clear_bit(). However, netif_poll_disable/enable pairs are often used as simili-spinlocks.

Re: netif_poll_enable() barrier

2006-12-28 Thread Benjamin Herrenschmidt
On Thu, 2006-12-28 at 21:09 -0800, David Miller wrote: From: Benjamin Herrenschmidt [EMAIL PROTECTED] Date: Wed, 20 Dec 2006 14:44:12 +1100 I stumbled accross what might be a bug on out of order architecture: netif_poll_enable() only does a clear_bit(). However,

netif_poll_enable() barrier

2006-12-19 Thread Benjamin Herrenschmidt
Hi ! I stumbled accross what might be a bug on out of order architecture: netif_poll_enable() only does a clear_bit(). However, netif_poll_disable/enable pairs are often used as simili-spinlocks. (netif_poll_enable() has pretty much spin_lock semantics except that it schedules instead of