Re: nfp bpf offload add/replace

2017-09-07 Thread Jakub Kicinski
On Thu, 7 Sep 2017 16:05:03 +0200, Jiri Pirko wrote: > Thu, Sep 07, 2017 at 03:44:12PM CEST, kubak...@wp.pl wrote: > >On Thu, 7 Sep 2017 11:10:33 +0200, Jiri Pirko wrote: > >> Hi Kuba. > >> > >> I'm looking into cls_bpf code and nfp_net_bpf_offload function in your > >> driver. Why do you need T

Re: nfp bpf offload add/replace

2017-09-07 Thread Jiri Pirko
Thu, Sep 07, 2017 at 03:44:12PM CEST, kubak...@wp.pl wrote: >On Thu, 7 Sep 2017 11:10:33 +0200, Jiri Pirko wrote: >> Hi Kuba. >> >> I'm looking into cls_bpf code and nfp_net_bpf_offload function in your >> driver. Why do you need TC_CLSBPF_ADD? Seems like TC_CLSBPF_REPLACE >> should be enough. It

Re: nfp bpf offload add/replace

2017-09-07 Thread Jakub Kicinski
On Thu, 7 Sep 2017 11:10:33 +0200, Jiri Pirko wrote: > Hi Kuba. > > I'm looking into cls_bpf code and nfp_net_bpf_offload function in your > driver. Why do you need TC_CLSBPF_ADD? Seems like TC_CLSBPF_REPLACE > should be enough. It would make the cls_bpf code easier. > > Note that other cls just h

nfp bpf offload add/replace

2017-09-07 Thread Jiri Pirko
Hi Kuba. I'm looking into cls_bpf code and nfp_net_bpf_offload function in your driver. Why do you need TC_CLSBPF_ADD? Seems like TC_CLSBPF_REPLACE should be enough. It would make the cls_bpf code easier. Note that other cls just have replace/destroy (u32 too, as drivers handle NEW/REPLACE in one