Re: question about checksumming and tcp_sendpage

2015-11-06 Thread Tom Herbert
On Fri, Nov 6, 2015 at 6:34 AM, ronny.hegew...@online.de wrote: > While reading through net-code i came across some code in tcp_sendpage which > i think > it is not working in the intended way all tie time. But as this code is at > that a > central place and pretty

Re: Aw: Re: question about checksumming and tcp_sendpage

2015-11-06 Thread Eric Dumazet
On Fri, 2015-11-06 at 20:14 +0100, ronny.hegew...@online.de wrote: > I think the checksum-building is not broken because of this on itself. The > problem i see is for example in case pages are sent from a block-device > over the net. > > Depending on the block-device this pages might be

Aw: Re: question about checksumming and tcp_sendpage

2015-11-06 Thread ronny . hegewald
> Well, looking at the code I don't readily see how this works either, > but note that tcp_sendmsg has the same check also. If your analysis is > correct then checksum for IPv6 would commonly be broken (i.e. several > devices support IPv4 checksum but not IPv6)-- so I find that hard to > believe

question about checksumming and tcp_sendpage

2015-11-05 Thread ronny.hegew...@online.de
While reading through net-code i came across some code in tcp_sendpage which i think it is not working in the intended way all tie time. But as this code is at that a central place and pretty old, im suspicious if my analysis is really right. The code in question is this (from