Re: rhashtable: Kill harmless RCU warning in rhashtable_walk_init

2015-12-18 Thread Eric Dumazet
On Fri, 2015-12-18 at 14:24 +0800, Herbert Xu wrote: > On Fri, Dec 18, 2015 at 01:34:16PM +0800, Herbert Xu wrote: > > On Fri, Dec 18, 2015 at 09:39:22AM +0800, kernel test robot wrote: > > > FYI, we noticed the below changes on > > > > > > https://github.com/0day-ci/linux > > >

Re: rhashtable: Kill harmless RCU warning in rhashtable_walk_init

2015-12-18 Thread Herbert Xu
On Fri, Dec 18, 2015 at 04:54:14AM -0800, Eric Dumazet wrote: > > You can avoid the comment by using the self documented and lockdep > enabled primitive > > iter->walker->tbl = rcu_dereference_protected(ht->tbl, > lockdep_is_held(>lock)); That is just

Re: rhashtable: Kill harmless RCU warning in rhashtable_walk_init

2015-12-18 Thread David Miller
From: Herbert Xu Date: Fri, 18 Dec 2015 21:14:08 +0800 > On Fri, Dec 18, 2015 at 04:54:14AM -0800, Eric Dumazet wrote: >> >> You can avoid the comment by using the self documented and lockdep >> enabled primitive >> >> iter->walker->tbl =

Re: [PATCH v2] rhashtable: Kill harmless RCU warning in rhashtable_walk_init

2015-12-18 Thread David Miller
From: Herbert Xu Date: Sat, 19 Dec 2015 10:45:28 +0800 > On Fri, Dec 18, 2015 at 04:27:31PM -0500, David Miller wrote: >> From: Herbert Xu >> Date: Fri, 18 Dec 2015 21:14:08 +0800 >> >> > On Fri, Dec 18, 2015 at 04:54:14AM -0800, Eric

[PATCH v2] rhashtable: Kill harmless RCU warning in rhashtable_walk_init

2015-12-18 Thread Herbert Xu
On Fri, Dec 18, 2015 at 04:27:31PM -0500, David Miller wrote: > From: Herbert Xu > Date: Fri, 18 Dec 2015 21:14:08 +0800 > > > On Fri, Dec 18, 2015 at 04:54:14AM -0800, Eric Dumazet wrote: > >> > >> You can avoid the comment by using the self documented and lockdep >

Re: [LKP] [PATCH v2] rhashtable: Kill harmless RCU warning in rhashtable_walk_init

2015-12-18 Thread Fengguang Wu
On Fri, Dec 18, 2015 at 11:42:59PM -0500, David Miller wrote: > From: Herbert Xu > Date: Sat, 19 Dec 2015 10:45:28 +0800 > > > On Fri, Dec 18, 2015 at 04:27:31PM -0500, David Miller wrote: > >> From: Herbert Xu > >> Date: Fri, 18 Dec

rhashtable: Kill harmless RCU warning in rhashtable_walk_init

2015-12-17 Thread Herbert Xu
On Fri, Dec 18, 2015 at 01:34:16PM +0800, Herbert Xu wrote: > On Fri, Dec 18, 2015 at 09:39:22AM +0800, kernel test robot wrote: > > FYI, we noticed the below changes on > > > > https://github.com/0day-ci/linux > > Herbert-Xu/rhashtable-Fix-walker-list-corruption/20151216-164833 > > commit