Re: sctp use-uninitialized warning in net-2.6.25

2008-01-20 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Sun, 20 Jan 2008 05:47:13 -0500 > Anyway, here is a patch that sets the correct value. Applied, but I had to fix up the trailing whitespace on line 29 of your patch. :-/ Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: sctp use-uninitialized warning in net-2.6.25

2008-01-20 Thread Vlad Yasevich
David Miller wrote: From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Fri, 18 Jan 2008 21:17:56 -0500 Hmm... in the code I am looking at, it's set in both zero and non-zero cases so it does solve the issue. So does initializing it to NO_ERROR like you did. Here is the code block in question in n

Re: sctp use-uninitialized warning in net-2.6.25

2008-01-18 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Fri, 18 Jan 2008 21:17:56 -0500 > Hmm... in the code I am looking at, it's set in both zero and > non-zero cases so it does solve the issue. > > So does initializing it to NO_ERROR like you did. Here is the code block in question in net-2.6.25:

Re: sctp use-uninitialized warning in net-2.6.25

2008-01-18 Thread Vlad Yasevich
David Miller wrote: From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Fri, 18 Jan 2008 11:03:20 -0500 We can do that, or move the declaration to the only block that uses it. Like this: ... @@ -466,6 +465,7 @@ sctp_disposition_t sctp_sf_do_5_1C_ack(const struct sctp_endpoint *ep, if (!sc

Re: sctp use-uninitialized warning in net-2.6.25

2008-01-18 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Fri, 18 Jan 2008 11:03:20 -0500 > We can do that, or move the declaration to the only block that uses it. > Like this: ... > @@ -466,6 +465,7 @@ sctp_disposition_t sctp_sf_do_5_1C_ack(const struct > sctp_endpoint *ep, > if (!sctp_verify_init(as

Re: sctp use-uninitialized warning in net-2.6.25

2008-01-18 Thread Vlad Yasevich
David Miller wrote: From: Andrew Morton <[EMAIL PROTECTED]> Date: Wed, 16 Jan 2008 13:59:57 -0800 net/sctp/sm_statefuns.c: In function 'sctp_sf_do_5_1C_ack': net/sctp/sm_statefuns.c:484: warning: 'error' may be used uninitialized in this function It is not obvious that this is a false positiv

Re: sctp use-uninitialized warning in net-2.6.25

2008-01-18 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Wed, 16 Jan 2008 13:59:57 -0800 > net/sctp/sm_statefuns.c: In function 'sctp_sf_do_5_1C_ack': > net/sctp/sm_statefuns.c:484: warning: 'error' may be used uninitialized in > this function > > It is not obvious that this is a false positive. I'll chec

sctp use-uninitialized warning in net-2.6.25

2008-01-16 Thread Andrew Morton
net/sctp/sm_statefuns.c: In function 'sctp_sf_do_5_1C_ack': net/sctp/sm_statefuns.c:484: warning: 'error' may be used uninitialized in this function It is not obvious that this is a false positive. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [E