Re: stack smashing in iproute/ip

2015-05-27 Thread Stephen Hemminger
Yes, this is a long standing problem in rtnl_talk() api has no max length given for the answer. I changed rtnl_talk API as well. It probably will break some people who extract libnetlink as a user available library, but compatibility with internal API's was never guaranteed by iproute2. From:

Re: stack smashing in iproute/ip

2015-05-27 Thread Stephen Hemminger
On Tue, 19 May 2015 10:41:32 +0200 Jetchko Jekov jetchko.je...@nokia.com wrote: Hello, I hope this is the right way to report a bug regarding iproute. While playing with gre[tap] tunnels I run in the following: I integrated your patch into upcoming release. -- To unsubscribe from this

Re: stack smashing in iproute/ip

2015-05-21 Thread Jetchko Jekov
On 05/19/2015 03:25 PM, ext Eric Dumazet wrote: On Tue, 2015-05-19 at 10:41 +0200, Jetchko Jekov wrote: Hello, I hope this is the right way to report a bug regarding iproute. While playing with gre[tap] tunnels I run in the following: # modprobe ip-gre # ip l add gre1 type gre remote

Re: stack smashing in iproute/ip

2015-05-21 Thread Eric Dumazet
On Thu, 2015-05-21 at 09:47 +0200, Jetchko Jekov wrote: I am confused by this reply, sorry. What does it mean? Is my fix correct one or its just workaround which doesn't fix root cause of the problem? And if is not, what would be the correct way? Because the current state ip command for