Re: xfrm: UFO + ESP = double fragmentation

2016-01-29 Thread Herbert Xu
On Sat, Jan 30, 2016 at 12:44:24AM +0100, Jiri Bohac wrote: > > Is there a situation when xfrm_output_gso() does the right thing? Yes because you've just broken TSO over IPsec. In fact you're remarkably close to the right solution which is to avoid xfrm_output_gso for SKB_GSO_UDP packets. You sh

xfrm: UFO + ESP = double fragmentation

2016-01-29 Thread Jiri Bohac
Hi, I'm seeing wrong fragmentation on locally generated UDPv6 packets going out over ESP (transport mode): UFO is turned on on the outgoing interface and MTU is 1500. When 8 kB is written to a UDP socket, udpv6_sendmsg() calls ip_append_data() which generates a single 8 kB GSO skb. Through ip6_s