Re: ip_finish_output2: No header cache and no neighbour! in 2.6.15-git7

2006-01-17 Thread Patrick McHardy
Herbert Xu wrote: On Mon, Jan 16, 2006 at 08:08:19AM +0100, Patrick McHardy wrote: I can't figure out how this can happen. If a local outgoing multicast packet would have been SNATed to a non-local IP, ip_route_input would have been used by ip_route_me_harder. In that case we should see

Re: PATCH: iproute2 - prio qdisc, fix priomap

2006-01-17 Thread Patrick McHardy
jamal wrote: On Mon, 2006-16-01 at 06:51 +0100, Patrick McHardy wrote: jamal wrote: On Mon, 2006-16-01 at 05:56 +0100, Patrick McHardy wrote: This is a dead horse since I ACKed the patch, but that patch is _wrong_ without the user space fix. What's wrong with this: tc qdisc add dev

[PATCH] [IPV4] : rt_cache_stat can be statically defined

2006-01-17 Thread Eric Dumazet
Using __get_cpu_var(obj) is slightly faster than per_cpu_ptr(obj, raw_smp_processor_id()). 1) Smaller code and memory use For static and small objects, DEFINE_PER_CPU(type, object) is preferred over a alloc_percpu() : Better and smaller code to access them, and no extra memory (storing the

Re: Resubmit: [PATCH] net: fix PRIO qdisc bands init

2006-01-17 Thread David S. Miller
From: Amnon Aaronsohn [EMAIL PROTECTED] Date: Sat, 14 Jan 2006 16:24:59 +0200 (IST) Currently when PRIO is configured to use N bands, it lets the packets be directed to any of the bands 0..N-1. However, PRIO attaches a fifo qdisc only to the bands that appear in the priomap; the rest of the N

Re: [PATCH] Fix whitespace issues in net/core/filter.c

2006-01-17 Thread David S. Miller
From: Kris Katterjohn [EMAIL PROTECTED] Date: Sat, 14 Jan 2006 08:37:48 -0800 This fixes some whitespace issues in net/core/filter.c Signed-off-by: Kris Katterjohn [EMAIL PROTECTED] Applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH] fix ip[6]t_policy compiler warnings after x_tables merge

2006-01-17 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Sat, 14 Jan 2006 21:40:53 +0100 [NETFILTER] ip[6]t_policy: Fix compilation warnings ip[6]t_policy argument conversion slipped when merging with x_tables Signed-off-by: Benoit Boissinot [EMAIL PROTECTED] Signed-off-by: Harald Welte [EMAIL

Re: [PATCH 3/3] [NETFILTER] ip6tables: whitespace and indent cosmetic cleanup

2006-01-17 Thread David S. Miller
All 3 applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tg3: Refine nvram locking

2006-01-17 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 16 Jan 2006 14:36:34 -0800 Add nvram lock count so that calls to tg3_nvram_lock()/unlock() can be nested. Add error checking to all callers of tg3_nvram_lock() where appropriate. To prevent nvram lock failures after halting the firmware, it is

Re: [PATCH] [IPV4] : rt_cache_stat can be statically defined

2006-01-17 Thread David S. Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 10:56:13 +0100 x86_64 code before patch mov1237577(%rip),%rax# 803e5990 rt_cache_stat not%rax # part of per_cpu machinery mov%gs:0x3c,%edx # get cpu number movslq %edx,%rdx # extend 32 bits cpu number

Re: linux networking kernel layer and STREAMS

2006-01-17 Thread Willem de Bruijn
But you haven't even studied how the Linux networking works, so how would you know? I guess time is better spent reinventing the wheel. Since you don't know, by definition you're spewing. You don't know the Linux networking, and therefore you don't know whether existing mechanisms can solve

Re: [PATCH 1/1] LSM-IPsec SELinux Authorize

2006-01-17 Thread David S. Miller
From: Trent Jaeger [EMAIL PROTECTED] Date: Mon, 16 Jan 2006 21:54:13 -0500 We want to limit the modification of security contexts only to the minimal set of programs (e.g., setkey and racoon). SELinux generally restricts root programs to least privilege rights, such that a root program

Re: [patch] 3c59x: improve usage of netif_carrier_{on,off}

2006-01-17 Thread Andrew Morton
Steffen Klassert [EMAIL PROTECTED] wrote: The patch _should_ do the following: 1. Set the polling intervall for media changes to 5 seconds if link is down and 60 seconds if link is up. 2. Handle netif_carrier_{on,of} and check for media changes in proper way by using

Re: [PATCH] signed long - long

2006-01-17 Thread Ingo Oeser
Kris Katterjohn wrote: I learned C with KR (ANSI) and it says: C99 seems to be the standard used in kernel. It clarifies much and aligns with real machines in many cases. Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: linux networking kernel layer and STREAMS

2006-01-17 Thread David S. Miller
From: Willem de Bruijn [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 11:55:44 +0100 About your remark: I have studied linux networking so far as it has crossed my path. IPSEC, the only place for which XFRM is being used it seems, was scheduled for later. You don't expect to see a different

Re: State of the Union: Wireless

2006-01-17 Thread Jiri Benc
On Mon, 16 Jan 2006 19:07:51 -0800, Jouni Malinen wrote: Actually, there is a use for the master device. It can be used to monitor what is going on over the radio from all virtual APs/STAs, e.g., by running Ethereal on it. You can add a new soft monitor interface and use it instead. There is

Re: Pull request for wireless-2.6

2006-01-17 Thread Jeff Garzik
pulled, thanks - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Patch 01/13] mv643xx_eth: Add Dale Farnsworth as a maintainer

2006-01-17 Thread Jeff Garzik
applied 1-13 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 1/5] spidernet: check if firmware was loaded correctly

2006-01-17 Thread Jeff Garzik
applied 1-5 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: linux networking kernel layer and STREAMS

2006-01-17 Thread Willem de Bruijn
I'm talking about stackable routes, which is in the destination cache and is at the core of how all routing works in the Linux kernel. I misunderstood you there. Stackable routes are interesting, and indeed simple. They are miles apart from my work, and certainly not innovative. They are

Re: [PATCH RESEND netdev-2.6 1/3] e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue)

2006-01-17 Thread Jeff Garzik
Jesse Brandeburg wrote: e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue) The large number of lines changed for this patch are due to several fuctions moving in order to be called from a new function. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Jeff

Re: [PATCH netdev-2.6 01/39] Fix jumbo frame performance

2006-01-17 Thread Jeff Garzik
Jeff Kirsher wrote: Partition PBA for Jumbo frames based on MTU size. Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: John Ronciak [EMAIL PROTECTED] yay! applied patches 1-10, finally worked this time. one flaw, that required me

Re: [PATCH netdev-2.6 11/39] Fix loopback logic

2006-01-17 Thread Jeff Garzik
Jeff Kirsher wrote: Fixed the loopback logic to work for the PCI express adapters. Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: John Ronciak [EMAIL PROTECTED] applied 11-20, after hand-editing e1000: prefix into subject lines.

Re: [PATCH netdev-2.6 32/39] Added disable packet split capability

2006-01-17 Thread Jeff Garzik
Jeff Kirsher wrote: Adds the ability to disability packet split at compile time and use the legacy receive path on PCI express hardware. Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: John Ronciak [EMAIL PROTECTED] NAK, use

Re: [PATCH netdev-2.6 21/39] Fix __pskb_pull_tail

2006-01-17 Thread Jeff Garzik
Jeff Kirsher wrote: Fixed by moving code to correct location (for 82572 and 82571 controllers). Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: John Ronciak [EMAIL PROTECTED] applied 21-30, after hand-editing e1000: prefix into

Re: [PATCH netdev-2.6 31/39] Added copy break code

2006-01-17 Thread Jeff Garzik
Jeff Kirsher wrote: Improves small packet performance with large amounts of reassembly being done in the stack. Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: John Ronciak [EMAIL PROTECTED] Applied 31, 33, 34, and dropped the

Re: [PATCH ] ethtool: Remove duplex info from CTRL register dump

2006-01-17 Thread Jeff Garzik
Jeff Kirsher wrote: The duplex control register is used for setting the driver and is not necessary for debug purposes. The value of the duplex control register is what the register's current value is and may not reflect the correct status of te current connection. That is what the duplex

Re: [PATCH RESEND netdev-2.6 1/3] e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue)

2006-01-17 Thread Jeff Garzik
Jesse Brandeburg wrote: e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue) The large number of lines changed for this patch are due to several fuctions moving in order to be called from a new function. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Jeff

Re: [2.6 patch] drivers/net/arcnet/: possible cleanups

2006-01-17 Thread Jeff Garzik
Adrian Bunk wrote: This patch contains the following possible cleanups: - make needlessly global code static - arcnet.c: remove the unneeded EXPORT_SYMBOL(arc_proto_null) - arcnet.c: remove the unneeded EXPORT_SYMBOL(arcnet_dump_packet) To make Jeff happy, arcnet.c still prints arcnet: v3.93

[PATCH] Remove MANY unneeded header files in net/core/filter.c

2006-01-17 Thread Kris Katterjohn
This removes many unneeded header files in net/core/filter.c Signed-off-by: Kris Katterjohn [EMAIL PROTECTED] This is a diff against -rc1. This compiles fine with no warnings and seems to run perfectly fine. Are there any headers I'm deleting that _should_ be there, but not necessarily

Re: PATCH: iproute2 - prio qdisc, fix priomap

2006-01-17 Thread Patrick McHardy
Stephen Hemminger wrote: Here is another useful example without priomap that is on the netem info. # tc qdisc add dev eth0 root handle 1: prio # tc qdisc add dev eth0 parent 1:3 handle 30: netem \ delay 200ms 10ms distribution normal # tc qdisc add dev eth0 parent 30:1 tbf rate 20kbit

TIPC needs some cleanup

2006-01-17 Thread Stephen Hemminger
TIPC got added to 2.6.16-rc1, but needs some work. Look at some of the global symbols, from tipc.ko Standard practice is to restrict the namespace of modules to a small set of prefixes (like tipc_). How about some cleanup here. 000c T addr_domain_valid 0088 T

Re: wireless: recap of current issues (stack)

2006-01-17 Thread Jean Tourrilhes
On Sat, Jan 14, 2006 at 02:51:14PM +0100, Michael Buesch wrote: On Saturday 14 January 2006 00:03, you wrote: As an aside to this whole thing, I know we're talking about *kernel* wireless but it's worthless to most people without good userland support as well. Anyone have any thoughts

Re: TIPC needs some cleanup

2006-01-17 Thread Per Liden
On Tue, 17 Jan 2006, Stephen Hemminger wrote: TIPC got added to 2.6.16-rc1, but needs some work. Look at some of the global symbols, from tipc.ko Standard practice is to restrict the namespace of modules to a small set of prefixes (like tipc_). Yep, we are aware of the problem as Jamal

Re: [PATCH] [TRIVIAL] prism54/islpci_eth.c: dev_kfree_skb in irq context

2006-01-17 Thread Roger While
I am going to NACK this. Two reasons : 1) Unless we are patching different trees, it appears the dev_kfree_skb at label drop_free got missed. 2) I still do not understand this. Quote from the definition of dev_kfree_skb_irq - /* Use this variant when it is known for sure that it * is executing

Re: [PATCH RESEND netdev-2.6 1/3] e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue)

2006-01-17 Thread Jesse Brandeburg
On Tue, 17 Jan 2006, Jeff Garzik wrote: [EMAIL PROTECTED] netdev-2.6]$ patch -sp1 /g/tmp/mbox 1 out of 6 hunks FAILED -- saving rejects to file drivers/net/e100.c.rej Is this patch even against upstream??? it failed because upstream changed out from underneath us when the mdio lock fixes

Re: wireless: recap of current issues (stack)

2006-01-17 Thread Jirka Bohac
Hi, On Fri, Jan 13, 2006 at 05:03:28PM -0600, Chase Venters wrote: On Friday 13 January 2006 15:32, John W. Linville wrote: What about the suggestion of having both stacks in the kernel at once? I'm not very excited about two in-kernel stacks. Still, consolidating wireless drivers down to

Re: wireless: recap of current issues (configuration)

2006-01-17 Thread Stuffed Crust
On Mon, Jan 16, 2006 at 10:24:41PM +, Alan Cox wrote: If I have told my equipment to obey UK law I expect it to do so. If I hop on the train to France and forget to revise my configuration I'd prefer it also believed the APs It's not that you might forget to revise your configuration, but

Re: [RFC: 2.6 patch] remove drivers/net/eepro100.c

2006-01-17 Thread Adrian Bunk
On Sun, Jan 15, 2006 at 04:03:40PM -0800, Stephen Hemminger wrote: On Sun, 15 Jan 2006 16:19:58 +0300 Vitaly Bordug [EMAIL PROTECTED] wrote: On Thu, 5 Jan 2006 19:18:26 +0100 Adrian Bunk [EMAIL PROTECTED] wrote: This patch removes the obsolete drivers/net/eepro100.c driver. Is

Re: wireless: recap of current issues (configuration)

2006-01-17 Thread Kyle Moffett
On Jan 17, 2006, at 13:41, Stuffed Crust wrote: On Mon, Jan 16, 2006 at 10:24:41PM +, Alan Cox wrote: If I have told my equipment to obey UK law I expect it to do so. If I hop on the train to France and forget to revise my configuration I'd prefer it also believed the APs It's not that

Re: PATCH: iproute2 - prio qdisc, fix priomap

2006-01-17 Thread jamal
The example you provide is not affected since it will be given the default 3 band and 1:3 is valid. Where it matters is when you say something like: tc qdisc add dev eth0 root handle 1: prio bands X where X is not 3. In such a case the map for the priority will be the default priomap to 3

Re: TIPC needs some cleanup

2006-01-17 Thread jamal
On Tue, 2006-17-01 at 19:35 +0100, Andi Kleen wrote: On Tuesday 17 January 2006 18:41, Stephen Hemminger wrote: TIPC got added to 2.6.16-rc1, but needs some work. Look at some of the global symbols, from tipc.ko Standard practice is to restrict the namespace of modules to a small set

Re: TIPC needs some cleanup

2006-01-17 Thread Andi Kleen
On Tuesday 17 January 2006 19:58, jamal wrote: On Tue, 2006-17-01 at 19:35 +0100, Andi Kleen wrote: On Tuesday 17 January 2006 18:41, Stephen Hemminger wrote: TIPC got added to 2.6.16-rc1, but needs some work. Look at some of the global symbols, from tipc.ko Standard practice is to

Re: State of the Union: Wireless / 802.11 master device

2006-01-17 Thread Jouni Malinen
On Tue, Jan 17, 2006 at 01:05:16PM +0100, Jiri Benc wrote: On Mon, 16 Jan 2006 19:07:51 -0800, Jouni Malinen wrote: Actually, there is a use for the master device. It can be used to monitor what is going on over the radio from all virtual APs/STAs, e.g., by running Ethereal on it. You

Re: wireless: recap of current issues (stack)

2006-01-17 Thread Jean Tourrilhes
On Tue, Jan 17, 2006 at 08:23:50PM +0100, Olivier Blin wrote: And most of the time, userland has to poll for scan results or association status, netlink notifications would help. For example, it would be a lot easier for ifplugd to listen on a netlink, instead of polling for current AP and

Re: wireless: recap of current issues (stack)

2006-01-17 Thread Olivier Blin
Jean Tourrilhes [EMAIL PROTECTED] writes: Please consider this page about drakroam and net_applet as well: http://qa.mandriva.com/twiki/bin/view/Main/EasyWifi NetApplet was already on my page, but thanks to you I've checked it and it's now 404. Well, assuming your netapplet is the

Re: TIPC needs some cleanup

2006-01-17 Thread Jon Maloy
There are two good reasons (exuses?) for this: First, the dbg.c code was written well before relayfs, so for natural reasons we could not consider it back then. Second, at least I wasn't aware of relayfs until recently, and I am still not sure if and how much the functionalities overlap. Now

RE: State of the Union: Wireless

2006-01-17 Thread Simon Barber
To do qos properly there needs to be a single net_device that a single qdisc can be installed on - this alone is a good reason for a master net_device. (there must be a single 802.11 qdisc for a single physical piece of hardware). Here is another reason (for hardware devices that do not include a

[PATCH 1/1] LSM-IPsec SELinux Authorize (with fixes)

2006-01-17 Thread cxzhang
Minor fixes, per James' comment. thanks, Catherine This patch contains a fix for the previous patch that adds security contexts to IPsec policies and security associations. In the previous patch, no authorization (besides the check for write permissions to SAD and SPD) is required to

Re: TIPC needs some cleanup

2006-01-17 Thread jamal
On Tue, 2006-17-01 at 21:18 +0100, Andi Kleen wrote: That is what we have code reviews for - to tell you about such things - but somehow you seem to have sneaked your code around that. That sounds a little harsh Andi and i know you are a much bigger boy than you sound above. The decision

Re: TIPC needs some cleanup

2006-01-17 Thread Andi Kleen
On Tuesday 17 January 2006 21:31, jamal wrote: The decision was made at netconf and announcements were made in the kernel summit That's the famous smoke filled backrooms where Linux development shouldn't happen. the TIPC tree has been open for months now for review. That is not how Linux

Re: State of the Union: Wireless / 802.11 master device

2006-01-17 Thread Jouni Malinen
On Tue, Jan 17, 2006 at 02:55:31PM -0500, jamal wrote: On Tue, 2006-17-01 at 11:42 -0800, Jouni Malinen wrote: so if i understood correctly: You have a master netdevice which underneath it has child netdevices? I'm not sure what exactly child netdev means, but it sounds like something that

Re: [PKT_SCHED]: Handle SCTP/DCCP in sfq_hash

2006-01-17 Thread David S. Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 12 Jan 2006 06:53:01 +0100 Handle SCTP/DCCP in sfq_hash to make it recognize seperate connections. Applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [EBTABLES]: Handle SCTP/DCCP in ebt_{ip,log}

2006-01-17 Thread David S. Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 12 Jan 2006 06:53:57 +0100 This patch adds SCTP/DCCP support to ebt_ip.c and ebt_log.c. The ebt_ipt.c change needs a userspace change as well, this is the second attached patch. Kernel side applied, thanks Patrick. - To unsubscribe from this

Re: [PATCH] Replacing with (compare|is_zero)_ether_addr() and ETH_ALEN in pktgen.c

2006-01-17 Thread David S. Miller
From: Kris Katterjohn [EMAIL PROTECTED] Date: Sun, 15 Jan 2006 19:50:47 -0800 This replaces some tests with is_zero_ether_addr(), memcmp(one, two, 6) with compare_ether_addr(one, two), and 6 with ETH_ALEN where appropriate. Signed-off-by: Kris Katterjohn [EMAIL PROTECTED] Applied, thanks. -

Re: IPSEC Offload

2006-01-17 Thread David S. Miller
From: Dave Dillow [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 11:45:04 -0500 Would this still be interesting to anyone? If I can get a good framework in place, maybe we can get Intel to open up their cards to work with it as well. I feel like support for this is inevitable, personally. It's not

Re: IPSEC Offload

2006-01-17 Thread Dave Dillow
On Tue, 2006-01-17 at 13:16 -0800, David S. Miller wrote: From: Dave Dillow [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 11:45:04 -0500 Would this still be interesting to anyone? If I can get a good framework in place, maybe we can get Intel to open up their cards to work with it as well.

[PATCH] Use is_zero_ether_addr() in net/core/netpoll.c

2006-01-17 Thread Kris Katterjohn
This replaces a memcmp() with is_zero_ether_addr(). Signed-off-by: Kris Katterjohn [EMAIL PROTECTED] Thanks! --- x/net/core/netpoll.c2006-01-17 08:25:32.0 -0600 +++ y/net/core/netpoll.c2006-01-17 15:45:01.0 -0600 @@ -703,7 +703,7 @@ int netpoll_setup(struct

[Patch 2.6.15] starfire: Implement suspend/resume

2006-01-17 Thread Stefan Rompf
This patch implements suspend and resume methods for the starfire driver. It allows me to put my desktop PC with a starfire dual board into S4. Signed-Off-By: Stefan Rompf [EMAIL PROTECTED] --- linux-2.6.15/drivers/net/starfire.c.orig2006-01-04 01:01:18.0 +0100 +++

[PATCH 00/12] sky2:

2006-01-17 Thread Stephen Hemminger
Updates to sky2 driver (based on 2.6.16-rc1). Includes previously posted 0.12 patches, which Jeff hasn't merged yet... The most important fixes are: * ram buffer initialization for Yukon FE revision A3 (88E8053) * race in transmit locking -- Stephen Hemminger [EMAIL PROTECTED] OSDL

[PATCH 08/12] sky2: ratelimit error messages

2006-01-17 Thread Stephen Hemminger
Make sure and rate limit all the error messages that might occur. If a problem occurs then a few messages are enough. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.orig/drivers/net/sky2.c +++ sky2-2.6/drivers/net/sky2.c @@ -92,7 +92,7 @@ static const u32 default_msg =

[PATCH 09/12] sky2: use kzalloc

2006-01-17 Thread Stephen Hemminger
Can use kzalloc here. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.orig/drivers/net/sky2.c +++ sky2-2.6/drivers/net/sky2.c @@ -3099,14 +3099,13 @@ static int __devinit sky2_probe(struct p #endif err = -ENOMEM; - hw = kmalloc(sizeof(*hw), GFP_KERNEL); +

[PATCH 04/12] sky2: fix ram buffer for Yukon FE rev 2

2006-01-17 Thread Stephen Hemminger
Fix problems with Yukon FE rev 2 chipset. Don't cut and paste bugs in from sk98lin driver. Change how the ram buffer is divided up, and make the math clearer. Also, set the thresholds where rx takes precedence. The threshold values are just guesses at this point, it might be worth tuning them

[PATCH 11/12] sky2: more conservative transmit locking

2006-01-17 Thread Stephen Hemminger
Be more careful about transmit locking, this solves a possible race between tx_complete and transmit, that would cause a tx timeout. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-git.orig/drivers/net/sky2.c +++ sky2-git/drivers/net/sky2.c @@ -889,13 +889,13 @@ static void

[PATCH 06/12] sky2: don't bother clearing status ring elements

2006-01-17 Thread Stephen Hemminger
Don't need to zero out the status ring entries after processing. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.orig/drivers/net/sky2.c +++ sky2-2.6/drivers/net/sky2.c @@ -1825,7 +1825,6 @@ static int sky2_poll(struct net_device * struct sk_buff *skb;

[PATCH 01/12] sky2: receive buffer alignment

2006-01-17 Thread Stephen Hemminger
Need to make sure that sky2 receive buffers are 64 bit aligned. Also, don't need to start off with GFP_ATOMIC on initial setup. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- netdev-2.6.orig/drivers/net/sky2.c +++ netdev-2.6/drivers/net/sky2.c @@ -75,6 +75,7 @@ #define RX_LE_BYTES

[PATCH 12/12] sky2: 0.13 version

2006-01-17 Thread Stephen Hemminger
--- sky2-git.orig/drivers/net/sky2.c +++ sky2-git/drivers/net/sky2.c @@ -57,7 +57,7 @@ #include sky2.h #define DRV_NAME sky2 -#define DRV_VERSION0.12 +#define DRV_VERSION0.13 #define PFXDRV_NAME /* -- Stephen Hemminger [EMAIL

[PATCH 07/12] sky2: optimize for 32 bit dma

2006-01-17 Thread Stephen Hemminger
Small optimization, if dma addresses are 32 bits, then high bits are always zero. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.orig/drivers/net/sky2.c +++ sky2-2.6/drivers/net/sky2.c @@ -745,7 +745,7 @@ static inline struct sky2_rx_le *sky2_ne /* Return high part of DMA

[PATCH 10/12] sky2: don't inline so much

2006-01-17 Thread Stephen Hemminger
Don't need to inline quite so many routines, let the compiler decide Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.orig/drivers/net/sky2.c +++ sky2-2.6/drivers/net/sky2.c @@ -704,7 +704,7 @@ static inline struct sky2_tx_le *get_tx_ * This is a workaround code taken from

[PATCH 02/12] sky2: call pci_set_consistent_dma_mask

2006-01-17 Thread Stephen Hemminger
Need to call pci_set_consistent_dma_mask in the case of 64 bit DMA. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- netdev-2.6.orig/drivers/net/sky2.c +++ netdev-2.6/drivers/net/sky2.c @@ -3054,13 +3054,17 @@ static int __devinit sky2_probe(struct p goto

[PATCH 05/12] sky2: write barrier's

2006-01-17 Thread Stephen Hemminger
Be more careful about memory barriers. The only place we really need them is before and after updating the chip's ring interface. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.orig/drivers/net/sky2.c +++ sky2-2.6/drivers/net/sky2.c @@ -707,6 +707,7 @@ static inline struct

Re: State of the Union: Wireless / 802.11 master device

2006-01-17 Thread Stefan Rompf
Am Dienstag 17 Januar 2006 20:42 schrieb Jouni Malinen: Sure, you can do it that way, too. However, this is not the only use. I just remembered another one: QoS. Devicescape 802.11 code uses a qdisc on the master interface to take care of determining which hardware TX queue to use with WMM

Re: State of the Union: Wireless / 802.11 master device

2006-01-17 Thread Stephen Hemminger
On Tue, 17 Jan 2006 23:16:43 +0100 Stefan Rompf [EMAIL PROTECTED] wrote: Am Dienstag 17 Januar 2006 20:42 schrieb Jouni Malinen: Sure, you can do it that way, too. However, this is not the only use. I just remembered another one: QoS. Devicescape 802.11 code uses a qdisc on the master

Re: wireless: recap of current issues (configuration)

2006-01-17 Thread Stefan Rompf
Am Sonntag 15 Januar 2006 21:11 schrieb Johannes Berg: [iwconfig mode ...] Yeah, I agree with this, it is much cleaner to handle in the kernel. Think about the issues if you have a struct net_device that has 250 bytes of payload for the struct virtual_sta_device in it and you want to switch

Re: [RFC: 2.6 patch] remove drivers/net/eepro100.c

2006-01-17 Thread John Ronciak
We don't of any problems reported against e100 that have not been talked about in this thread (in old ARCH types). I think the eepro100 driver should be removed from the config just in case but we are in full support of the e100 driver and if somebody says that it's not working on one of the

NIP6_FMT breaks ifconfig

2006-01-17 Thread Kumar Gala
The use of NIP6_FMT from kernel.h in net/ipv6/addrconf.c changes how / proc/net/if_inet6 format's IPv6 addresses and thus breaks ifconfig's ability to display IPv6 addresses. I'm not sure if this is acceptable breakage of a userspace app or not. - kumar - To unsubscribe from this list:

RE: [PATCH ] ethtool: Remove duplex info from CTRL register dump

2006-01-17 Thread cramerj
applied, after replacing ethtool: with e1000: in the subject line. Even if it's modifying the ethtool app? As long as it doesn't confuse your scripts, I suppose. -Jeb - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: wireless: recap of current issues (stack)

2006-01-17 Thread Stefan Rompf
Am Dienstag 17 Januar 2006 19:37 schrieb Jirka Bohac: - DeviceScape can be there so it can be polished and new drivers can start using it. - ieee80211 could be there with a big fat warning that it will go away soon, just to allow ipw2x00 to work while DeviceScape and the ipw2x00 port

Re: TIPC needs some cleanup

2006-01-17 Thread David S. Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 21:42:38 +0100 On Tuesday 17 January 2006 21:31, jamal wrote: the TIPC tree has been open for months now for review. That is not how Linux code review works - the code is supposed to get posted to the appropiate mailing lists so

[PATCH RESEND netdev-2.6 3/3] e100: e100 whitespace fixes

2006-01-17 Thread Jesse Brandeburg
e100: e100 whitespace fixes These are whitespace only fixes. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: John Ronciak [EMAIL PROTECTED] --- drivers/net/e100.c | 74 ++-- 1

[PATCH RESEND netdev-2.6 1/3] e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue)

2006-01-17 Thread Jesse Brandeburg
e100: Fix TX hang and RMCP Ping issue (due to a microcode loading issue) Set the end of list bit to cause the hardware's transmit state machine to work correctly and not prevent management (BMC) traffic. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Jeff Kirsher [EMAIL

[PATCH RESEND netdev-2.6 2/3] e100: Handle the return values from pci_* functions

2006-01-17 Thread Jesse Brandeburg
e100: Handle the return values from pci_* functions This is to resolve warnings during compile time. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: John Ronciak [EMAIL PROTECTED] --- drivers/net/e100.c | 30

[PATCH RESEND netdev-2.6 0/3] e100: driver updates

2006-01-17 Thread Jesse Brandeburg
I'm actually getting better at this, really, no, really... This patch set is against linus-2.6 repository updated today e100 driver update 1. Fix TX hang and RMCP Ping issue (due to a microcode loading issue) 2. Handle the return values from pci_* functions 3. e100 whitespace fixes - To

Re: NIP6_FMT breaks ifconfig

2006-01-17 Thread David S. Miller
From: Kumar Gala [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 16:35:01 -0600 The use of NIP6_FMT from kernel.h in net/ipv6/addrconf.c changes how / proc/net/if_inet6 format's IPv6 addresses and thus breaks ifconfig's ability to display IPv6 addresses. I'm not sure if this is acceptable

Re: TIPC needs some cleanup

2006-01-17 Thread Stephen Hemminger
On Tue, 17 Jan 2006 14:55:10 -0800 (PST) David S. Miller [EMAIL PROTECTED] wrote: From: Andi Kleen [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 21:42:38 +0100 On Tuesday 17 January 2006 21:31, jamal wrote: the TIPC tree has been open for months now for review. That is not how Linux

Re: TIPC needs some cleanup

2006-01-17 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 15:04:34 -0800 Also, let's work with the current code. It is a lot easier to let others clean it up, if the changes are against the mainline (or -mm) rather than having to send it off to get put into yet another git repo. I

Re: [PATCH] Use is_zero_ether_addr() in net/core/netpoll.c

2006-01-17 Thread David S. Miller
From: Kris Katterjohn [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 13:51:11 -0800 This replaces a memcmp() with is_zero_ether_addr(). Signed-off-by: Kris Katterjohn [EMAIL PROTECTED] Applied, thanks Kris. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [PATCH] Remove MANY unneeded header files in net/core/filter.c

2006-01-17 Thread David S. Miller
From: Kris Katterjohn [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 09:03:22 -0800 Are there any headers I'm deleting that _should_ be there, but not necessarily required for a clean compilation? If so, let me know and I'll redo the patch. If the build still works, that doesn't mean much :-)

[GIT PATCHES] SCTP bugfixes for 2.6.16

2006-01-17 Thread Sridhar Samudrala
Dave, Please pull the following SCTP bugfixes from master.kernel.org:/pub/scm/linux/kernel/git/sridhar/lksctp-2.6.git Thanks Sridhar include/net/sctp/sctp.h|2 + include/net/sctp/structs.h | 89 +--- net/sctp/input.c | 73

Re: NIP6_FMT breaks ifconfig

2006-01-17 Thread Kumar Gala
On Jan 17, 2006, at 5:05 PM, David S. Miller wrote: From: Kumar Gala [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 16:35:01 -0600 The use of NIP6_FMT from kernel.h in net/ipv6/addrconf.c changes how / proc/net/if_inet6 format's IPv6 addresses and thus breaks ifconfig's ability to display IPv6

Re: wireless: recap of current issues (other issues / fake ethernet)

2006-01-17 Thread Stefan Rompf
Am Sonntag 15 Januar 2006 16:39 schrieb Stuffed Crust: Internally, we're pure 802.11. One thing to keep in mind that we're not going to be bridging/translating non-data traffic to other networks, and with that in mind, 802.3-802.11 translation is trivial, and won't lose anything except for a

Re: [GIT PATCHES] SCTP bugfixes for 2.6.16

2006-01-17 Thread David S. Miller
From: Sridhar Samudrala [EMAIL PROTECTED] Date: Tue, 17 Jan 2006 15:20:50 -0800 Please pull the following SCTP bugfixes from master.kernel.org:/pub/scm/linux/kernel/git/sridhar/lksctp-2.6.git Looks good. Pulled, thanks Sridhar. - To unsubscribe from this list: send the line unsubscribe

[PATCH 0/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Sean Hefty
The following set of patches defines a connection abstraction for Infiniband and other RDMA devices, and serves several purposes: * It implements a connection protocol over Infiniband based on IP addressing. This greatly simplifies clients wishing to establish connections over Infiniband. * It

[PATCH 1/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Sean Hefty
The following patch provides common handling for marshalling data between userspace clients and kernel mode Infiniband drivers. Signed-off-by: Sean Hefty [EMAIL PROTECTED] --- diff -uprN -X linux-2.6.git/Documentation/dontdiff linux-2.6.git/drivers/infiniband/core/Makefile

RE: [PATCH 2/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Sean Hefty
The following patch extends matching connection requests to listens in the Infiniband CM to include private data. Signed-off-by: Sean Hefty [EMAIL PROTECTED] --- diff -uprN -X linux-2.6.git/Documentation/dontdiff linux-2.6.git/drivers/infiniband/core/cm.c

[PATCH 3/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Sean Hefty
The following provides an address translation service that maps IP addresses to Infiniband addresses (GIDs) using IPoIB. Signed-off-by: Sean Hefty [EMAIL PROTECTED] --- diff -uprN -X linux-2.6.git/Documentation/dontdiff linux-2.6.git/drivers/infiniband/core/addr.c

[PATCH 4/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Sean Hefty
The following patch implements a kernel mode connection management agent over Infiniband that connects based on IP addresses. The agent defines a generic RDMA connection abstraction to support clients wanting to connect over different RDMA devices. It also handles RDMA device hotplug events on

Re: [PATCH 2/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Stephen Hemminger
Minor nits. On Tue, 17 Jan 2006 15:24:37 -0800 Sean Hefty [EMAIL PROTECTED] wrote: The following patch extends matching connection requests to listens in the Infiniband CM to include private data. Signed-off-by: Sean Hefty [EMAIL PROTECTED] --- +static void cm_mask_compare_data(u8

[PATCH 5/5] [RFC] Infiniband: connection abstraction

2006-01-17 Thread Sean Hefty
This patch adds the kernel component to support the userspace Infiniband/RDMA connection agent library. Signed-off-by: Sean Hefty [EMAIL PROTECTED] --- diff -uprN -X linux-2.6.git/Documentation/dontdiff linux-2.6.git/drivers/infiniband/core/Makefile

Re: R8169 driver Netgear GA511 NIC - soft lockup/hang in rtl8169_phy_timer

2006-01-17 Thread Francois Romieu
Russell Steinthal [EMAIL PROTECTED] : [...] Thanks again for the help --- if you have any other ideas or things you'd like me to test, let me know. I am probably not searching in the right direction. :o/ CONFIG_LOG_BUF_SHIFT=14 - Please make it 17, your dmesg are trimmed. #

Re: wireless: recap of current issues (stack)

2006-01-17 Thread Chase Venters
On Tuesday 17 January 2006 12:37, Jirka Bohac wrote: At the present time, the ieee80211 stack is used by ipw2x00 (heavily) and hostap (a little bit). Other mainline drivers only use headers (mainly constants). If it shows that the DeviceScape stack is more mature and appropriate (which I

  1   2   >