G'day people,
Coverity CID 1161
This is probably fixed in some external tree, but in case it isn't, here is a
patch
Compile tested with allyesconfig
Remove some dead code from bcm43xx_sysfs.c in 2.6.18-rc6
Signed-off-by: Darren Jenkins <[EMAIL PROTECTED]>
--- drivers/net/wireless/bcm43xx/bc
Sorry people I have done it again!
Both Coverity CID 1160 and 1161 are for the same file.
I will whip up a combined patch
Darren J.
On Thu, 2006-09-07 at 17:27 +1000, Darren Jenkins\ wrote:
> G'day people,
>
> Coverity CID 1161
>
> This is probably fixed in some external tree, but in case it
Caitlin Bestler wrote:
[EMAIL PROTECTED] wrote:
Finally, as I understand both network isolation and network
virtualization (both level2 and level3) can happily co-exist. We do
have several filesystems in kernel. Let's have several network
virtualization approaches, and let a user choose. Is t
G'day people
Coverity CID 1160 & 1161
These are probably fixed in some external tree, but in case they are
not, here is a patch
Compile tested with allyesconfig
Remove some dead cose from bcm43xx_sysfs.c in 2.6.18-rc6
Signed-off-by: Darren Jenkins <[EMAIL PROTECTED]>
--- drivers/net/wireless/b
In bond_alb_monitor the bond->curr_slave_lock write lock is taken
and then dev_set_promiscuity maybe called which can take some time,
depending on the network HW. If a network IRQ for this card come in
the softirq handler maybe try to deliver more packets which end up in
a request to the read lock
On Tue, Sep 05, 2006 at 05:42:16PM -0700, Mohamed Abbas wrote:
> Are there any one working on roaming support for d80211 stack?
I'm not actively working on this at the moment, but I do have plans on
doing something on this area. The current implementation uses
wpa_supplicant to take care of the
crypt.alg is a string, use the correct type.
Signed-off-by: David Kimdon <[EMAIL PROTECTED]>
Index: wireless-dev/net/d80211/hostapd_ioctl.h
===
--- wireless-dev.orig/net/d80211/hostapd_ioctl.h
+++ wireless-dev/net/d80211/hostapd_ioct
Herbert Poetzl wrote:
my point (until we have an implementation which clearly
shows that performance is equal/better to isolation)
is simply this:
of course, you can 'simulate' or 'construct' all the
isolation scenarios with kernel bridging and routing
and tricky injection/marking of packets, b
Note to self: Do not use Pine EVER AGAIN.
Sorry for the badness. Evolution is my new best friend.
-Mitch
On Wed, 2006-09-06 at 12:22 -0700, Jay Vosburgh wrote:
>
> [Trying again; /usr/bin/patch didn't complain about Mitch's
> original; here's a cg-diff generated from where I checked his
On Thu, Sep 07, 2006 at 08:23:53PM +0400, Kirill Korotaev wrote:
> >>Herbert Poetzl wrote:
> >>
> >>>my point (until we have an implementation which clearly
> >>>shows that performance is equal/better to isolation)
> >>>is simply this:
> >>>
> >>> of course, you can 'simulate' or 'construct' all th
Daniel Lezcano <[EMAIL PROTECTED]> writes:
>
> IHMO, I think there is one reason. The unsharing mechanism is not only for
> containers, its aim other kind of isolation like a "bsdjail" for example. The
> unshare syscall is flexible, shall the network unsharing be one-block
> solution ?
> For examp
On Wed 06-09-06 15:58:12, Greg KH wrote:
> -stable review patch. If anyone has any objections, please let us know.
>
> --
> From: Stephen Hemminger <[EMAIL PROTECTED]>
>
> Since this code incorporates some of the fixes from 2.6.18, change
> the version number.
>
> Signed-off-by:
Herbert Poetzl <[EMAIL PROTECTED]> writes:
> On Thu, Sep 07, 2006 at 08:23:53PM +0400, Kirill Korotaev wrote:
>
> well, who said that you need to have things like RAW sockets
> or other protocols except IP, not to speak of iptable and
> routing entries ...
>
> folks who _want_ full network virtua
please consider for 2.6.18 -- thanks!
[ATM]: [he] when transmit fails, unmap the dma regions
Signed-off-by: Chas Williams <[EMAIL PROTECTED]>
---
commit e2c84ae30cb2dca23afb5e811c108e235f941c3d
tree a4acb86e2e10baa5ac651e566a550e0af0c55507
parent 0d60b74cf4354672e4586ca2bedde6695db43165
author c
please consider for 2.6.19 -- thanks!
[ATM]: Move linux/device.h include in linux/atmdev.h to #ifdef __KERNEL__
section
linux/device.h header is not included in the David Woodhouse's
kernel-headers git tree which is used for userspace kernel headers. Which
results in compile errors when building
please consider for 2.6.19 -- thanks!
[ATM]: proper prototypes in net/atm/mpc.h (and reduce ifdef clutter)
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Chas Williams <[EMAIL PROTECTED]>
---
commit 0d60b74cf4354672e4586ca2bedde6695db43165
tree 6d87bc63ee248fee449133cb62614f963fc9
Thomas Graf wrote:
What about adding blackhole device to be used for such routes.
I believe it would be good architecture to always use devices
to state directions packets are being received from and sent to.
The dummy device can be used for that.
-hpa
-
To unsubscribe from this list:
On Thu, 2006-09-07 at 10:55 +0100, David Howells wrote:
> Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
>
> > Well, genirq gives you more flexibility than the current mecanism so ...
>
> No, it doesn't because the FRV arch contains its own mechanism and I can do
> what ever I like in it.
But
On Thursday 07 September 2006 03:34, Larry Finger wrote:
> John,
>
> Please apply this patch by Martin Langer to wireless-2.6. It must follow the
> patch to "Add firmware
> version printout to wireless-2.6 (bcm43xx-softmac)". As originally submitted,
> the patch was
> appropriate for an obsole
Michael Buesch wrote:
On Thursday 07 September 2006 03:34, Larry Finger wrote:
+ return -EPERM;
+
you want to take the spinlock lock here, too.
Obviously, I copied the wrong model. Is it correct that one should take both locks if your code will
touch the hardware, but the mute
Ingo Molnar <[EMAIL PROTECTED]> wrote:
> > So, again, why _should_ I use the generic IRQ stuff? [...]
>
> To have shared code between architectures?
That's reasonable as far as it goes, the algorithms are similar per-arch, but
the PICs are quite ofter quite different. My FRV board here has thre
--- drivers/net/dl2k.c.orig 2006-09-07 10:33:00.0 +0300
+++ drivers/net/dl2k.c 2006-09-07 10:33:16.0 +0300
@@ -1,7 +1,8 @@
/* D-Link DL2000-based Gigabit Ethernet Adapter Linux driver */
/*
Copyright (c) 2001, 2002 by D-Link Corporation
-Written by Edward Peng.<[EMA
Description:
For DLink Fiber NIC, Linux 2.4.22 ships with driver version 1.19,
whereas, Linux 2.6.x ship with driver version 1.17.
The following patch upgrades the 2.6.x driver to include changes (and
bug fixes done until 1.19b).
These fixes are (copied from the driver):
1.182002/11/07 N
--- drivers/net/dl2k.h.orig 2006-09-07 10:33:05.0 +0300
+++ drivers/net/dl2k.h 2006-09-07 10:33:17.0 +0300
@@ -36,7 +36,7 @@
#include
#include
#define TX_RING_SIZE 256
-#define TX_QUEUE_LEN (TX_RING_SIZE - 1) /* Limit ring entries actually
used.*/
+#define TX_QUEUE_LE
Description:
For DLink Fiber NIC, Linux 2.4.22 ships with driver version 1.19,
whereas, Linux 2.6.x ship with driver version 1.17.
The following patch upgrades the 2.6.x driver to include changes (and
bug fixes done until 1.19b).
These fixes are (copied from the driver):
1.182002/11/07 N
> @@ -335,8 +374,9 @@
> #endif
> /* Read eeprom */
> for (i = 0; i < 128; i++) {
> - ((u16 *) sromdata)[i] = le16_to_cpu (read_eeprom (ioaddr, i));
> + ((u16 *) sromdata)[i] = cpu_to_le16 (read_eeprom (ioaddr, i));
> }
> + psrom->crc = le32_to_cpu(psro
Generic event handling mechanism.
Since number of comments has come mostly to zero, I freeze for some time kevent
development (since resending practically the same patches into /dev/null
is not that interesting task) and switch to imeplementation of special tree,
which probably will be used wit
Core files.
This patch includes core kevent files:
- userspace controlling
- kernelspace interfaces
- initialization
- notification state machines
Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]>
diff --git a/arch/i386/kernel/syscall_table.S b/arch/i386/kernel/syscall_table.S
index dd63d
Timer notifications.
Timer notifications can be used for fine grained per-process time
management, since interval timers are very inconvenient to use,
and they are limited.
Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]>
diff --git a/kernel/kevent/kevent_timer.c b/kernel/kevent/kevent_tim
Socket notifications.
This patch include socket send/recv/accept notifications.
Using trivial web server based on kevent and this features
instead of epoll it's performance increased more than noticebly.
More details about benchmark and server itself (evserver_kevent.c)
can be found on project's
poll/select() notifications.
This patch includes generic poll/select and timer notifications.
kevent_poll works simialr to epoll and has the same issues (callback
is invoked not from internal state machine of the caller, but through
process awake).
Signed-off-by: Evgeniy Polyakov <[EMAIL PROTEC
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
> Well, genirq gives you more flexibility than the current mecanism so ...
No, it doesn't because the FRV arch contains its own mechanism and I can do
what ever I like in it.
genirq's flexibility comes at a price. Count the number of hooks in st
* David Howells <[EMAIL PROTECTED]> wrote:
> The genirq subdir all wraps up into this:
>
> 109083272 12 141923770 kernel/irq/built-in.o
> 1548 64 41616 650 arch/frv/kernel/irq.o
> ---
Arjan van de Ven <[EMAIL PROTECTED]> :
[...]
> > dev->trans_start = jiffies;
> > + tasklet_enable(&np->tx_tasklet);
> > + writew(DEFAULT_INTR, ioaddr + IntEnable);
> > + return;
>
> this looks like a PCI posting bug
Btw tx_tasklet is introduced in the relevant struct in patch #2.
Patch
On Wed, Sep 06, 2006 at 09:23:56AM -0500, Chase Venters ([EMAIL PROTECTED])
wrote:
> On Wed, 6 Sep 2006, Evgeniy Polyakov wrote:
> >>>+struct kevent_user
> >>>+{
> >>
> >>These structure names get a little dicey (kevent, kevent_user, ukevent,
> >>mukevent)... might there be slightly different name
The tulip driver is really great, but after suspending the device, the driver
does not restore the promisc bit when resuming from S1/S3/S4.
To work around this, an ifconfig eth0 up, on the already up device, restores
it.
Is there an easy way to fix this?
Thanks!
--
Al
-
To unsubscribe from
> +static int __devinit kevent_user_init(void)
> +{
> + int err = 0;
> +
> + kevent_cache = kmem_cache_create("kevent_cache",
> + sizeof(struct kevent), 0, SLAB_PANIC, NULL, NULL);
> +
> + err = misc_register(&kevent_miscdev);
> + if (err) {
> + print
On Thu, Sep 07, 2006 at 12:29:21PM -0600, Eric W. Biederman wrote:
> Daniel Lezcano <[EMAIL PROTECTED]> writes:
> >
> > IHMO, I think there is one reason. The unsharing mechanism is
> > not only for containers, its aim other kind of isolation like a
> > "bsdjail" for example. The unshare syscall is
On Thu, Sep 07, 2006 at 07:25:28PM +, Pavel Machek wrote:
> On Wed 06-09-06 15:58:12, Greg KH wrote:
> > -stable review patch. If anyone has any objections, please let us know.
> >
> > --
> > From: Stephen Hemminger <[EMAIL PROTECTED]>
> >
> > Since this code incorporates som
Hi!
> > > -stable review patch. If anyone has any objections, please let us know.
> > >
> > > --
> > > From: Stephen Hemminger <[EMAIL PROTECTED]>
> > >
> > > Since this code incorporates some of the fixes from 2.6.18, change
> > > the version number.
> > >
> > > Signed-off-by:
On Thu, 7 Sep 2006 23:03:46 +0200
Pavel Machek <[EMAIL PROTECTED]> wrote:
> Hi!
>
> > > > -stable review patch. If anyone has any objections, please let us know.
> > > >
> > > > --
> > > > From: Stephen Hemminger <[EMAIL PROTECTED]>
> > > >
> > > > Since this code incorporates
On Thursday 07 September 2006 20:17, Larry Finger wrote:
> Hi all,
>
> I think I have a fix for the bcm43xx bug that leads to NETDEV WATCHDOG tx
> timeouts and would like it
> to get as much testing as possible as this bug affects V2.6.18-rcX. If the
> problem is truly
> fixed, I hope to get the
On Thursday 07 September 2006 15:21, Larry Finger wrote:
> Michael Buesch wrote:
> > On Thursday 07 September 2006 03:34, Larry Finger wrote:
> >> + return -EPERM;
> >> +
> >
> > you want to take the spinlock lock here, too.
>
> Obviously, I copied the wrong model. Is it correct that one
Michael Buesch wrote:
In general, no.
But, for some sysfs attrs it is sufficient to only take
the mutex, because:
* We don't access hardware.
* We don't modify this data in a spinlock-only critical section.
Yes, I know that having two locks does not really fit the
"lock data, not code" model. B
Michael Buesch wrote:
The real question is: Why does this patch help?
Let's explain it. We don't stop networking just for fun there.
While executing long preemptible periodic work, we must ensure
that the TX path into the driver is not entered. It's the same
reason why we disable IRQs in the fi
John,
Please apply this patch by Martin Langer to wireless-2.6. It must follow the patch
to "Add firmware
version printout to wireless-2.6 (bcm43xx-softmac)". Martins's original version was appropriate for
an obsolete version of bcm43xx-softmac, but I have updated and tested. This version incor
John,
Please queue this patch to remove dead code from bcm43xx-softmac in
wireless-2.6. It was submitted
by Darren Jenkins based on a Coverity code checker report. I had to revise the patch for the 2.6.18
locking model, and have tested it.
Thanks,
Larry
===
Coverity CID 1160 &
Hi all,
I think I have a fix for the bcm43xx bug that leads to NETDEV WATCHDOG tx
timeouts and would like it
to get as much testing as possible as this bug affects V2.6.18-rcX. If the
problem is truly
fixed, I hope to get the fix into mainline before release of the bug into the
stable series.
On Thu, Sep 07, 2006 at 09:05:16PM -0700, [EMAIL PROTECTED] ([EMAIL PROTECTED])
wrote:
> > +static int __devinit kevent_user_init(void)
> > +{
> > + int err = 0;
> > +
> > + kevent_cache = kmem_cache_create("kevent_cache",
> > + sizeof(struct kevent), 0, SLAB_PANIC, NULL, NUL
On Wed, 2006-09-06 at 15:46 +0200, Jens Axboe wrote:
> On Wed, Sep 06 2006, Peter Zijlstra wrote:
> > Provide an block queue init function that allows to set an elevator. And a
> > function to pin the current elevator.
> >
> > Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]>
> > Signed-off-by: D
On Thu, Sep 07 2006, Peter Zijlstra wrote:
> On Wed, 2006-09-06 at 15:46 +0200, Jens Axboe wrote:
> > On Wed, Sep 06 2006, Peter Zijlstra wrote:
> > > Provide an block queue init function that allows to set an elevator. And
> > > a
> > > function to pin the current elevator.
> > >
> > > Signed-o
51 matches
Mail list logo
