Re: Network performance degradation from 2.6.11.12 to 2.6.16.20

2006-09-19 Thread Andi Kleen
On Monday 18 September 2006 23:22, David Miller wrote: Ok, ok, but don't we have queueing disciplines that need the timestamp even on ingress? I grepped and I can't find any. The only non SIOCGTSTAMP users of the time stamp seem to be sunrpc and conntrack and I bet both can be converted over

Re: [PATCH] EtherIP tunnel driver (RFC 3378)

2006-09-19 Thread Joerg Roedel
On Mon, Sep 18, 2006 at 10:52:52PM +0200, Lennert Buytenhek wrote: Check out the thread [PATCH][RFC] etherip: Ethernet-in-IPv4 tunneling that was on netdev in January of 2005 -- a number of arguments against etherip (and for tunneling ethernet in GRE) were raised back then. I read this thread

[PATCHv3 1/4][RFC] net/ipv4: consolidated UDP / UDP-Lite code

2006-09-19 Thread Gerrit Renker
Hi David, please find enclosed for review the proposed changes to integrate UDP-Lite code with UDP. Please disregard all earlier patches, I have been putting in more hard work to consolidate the code further, also with regard to expanding to UDP(-Lite) v6. (Reductions are drastic: udplite.c is

[PATCHv3 4/4][RFC] net: misc. files to support UDP-Lite

2006-09-19 Thread Gerrit Renker
Miscellaneous files which complete the support for UDP-Litev4. -- Documentation/networking/udplite.txt | 291 +++ include/linux/in.h |1 include/linux/socket.h |1 include/net/snmp.h |2

[PATCHv3 3/4][RFC] net: basic xfrm/netfilter support for UDP-Lite

2006-09-19 Thread Gerrit Renker
Basic xfrm and netfilter support for UDP-Lite: * matching of UDP-Lite packets * LOG support * header file support -- include/net/xfrm.h|2 ++ net/ipv4/netfilter/ipt_LOG.c | 11 --- net/ipv4/xfrm4_policy.c |1 + net/ipv6/netfilter/ip6t_LOG.c | 10

[PATCHv3 2/4][RFC] net/ipv4: self-contained UDP-Lite module

2006-09-19 Thread Gerrit Renker
The self-contained UDP-Litev4 module for v4; logically completely separate from ipv4/udp.c. -- include/net/udplite.h | 86 +++ net/ipv4/udplite.c| 186 ++ 2 files changed, 272 insertions(+) diff --git

Re: [PATCHv3 3/4][RFC] net: basic xfrm/netfilter support for UDP-Lite

2006-09-19 Thread Patrick McHardy
Gerrit Renker wrote: Basic xfrm and netfilter support for UDP-Lite: * matching of UDP-Lite packets * LOG support * header file support -- --- a/net/netfilter/xt_multiport.c +++ b/net/netfilter/xt_multiport.c @@ -161,8 +161,9 @@ check(u_int16_t proto, u_int8_t count) {

Re: [PATCH] xt_policy: remove dups in .family

2006-09-19 Thread Patrick McHardy
Alexey Dobriyan wrote: sparse defined twice warning Thanks, applied with some manual fixup. Please base netfilter patches on the net-2.6.19 tree. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

RE: [patch 3/3] Add tsi108 On Chip Ethernet device driver support

2006-09-19 Thread Zang Roy-r61911
I have some review comments about your driver; please consider them for fixing Thanks. + spin_unlock_irq(phy_lock); + msleep(10); + spin_lock_irq(phy_lock); + } hmm some places take phy_lock with disabling interrupts, while others don't. I

patch blocked

2006-09-19 Thread Zang Roy-r61911
Hi, Does anyone can tell me why some of my patches were blocked in the mailing list. I do not use attachment. The body of the mail is not exceed 40KB in size. Roy - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: patch blocked

2006-09-19 Thread Matti Aarnio
On Tue, Sep 19, 2006 at 04:33:17PM +0800, Zang Roy-r61911 wrote: Hi, Does anyone can tell me why some of my patches were blocked in the mailing list. I do not use attachment. The body of the mail is not exceed 40KB in size. Roy We are filtering by means of bogofilter, and we are

Re: patch blocked

2006-09-19 Thread Mike Galbraith
On Tue, 2006-09-19 at 16:33 +0800, Zang Roy-r61911 wrote: Hi, Does anyone can tell me why some of my patches were blocked in the mailing list. I do not use attachment. The body of the mail is not exceed 40KB in size. Roy A snippet from the 'Bogofilter at VGER' announcment: ...

Re: patch blocked

2006-09-19 Thread Zang Roy-r61911
On Tue, 2006-09-19 at 16:50, Matti Aarnio wrote: On Tue, Sep 19, 2006 at 04:33:17PM +0800, Zang Roy-r61911 wrote: Hi, Does anyone can tell me why some of my patches were blocked in the mailing list. I do not use attachment. The body of the mail is not exceed 40KB in size.

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread Andi Kleen
On Tuesday 19 September 2006 06:41, Stephen Hemminger wrote: Bert's attempt was noble It showed your desire for the truth A simple path exists I guess most people won't have a clue on what to configure here (especially with such sparse help text, but even with more it would be hard). And

Re: TCP Pacing

2006-09-19 Thread Daniele Lacamera
On Saturday 16 September 2006 02:41, Xiaoliang (David) Wei wrote: Hi Daniel, Thank you very much for the patch and the reference summary. For the implementation and performance of pacing, I just have a few suggestion/clarification/support data: First, in the implementation in the

Re: [PATCH]:[XFRM] BEET mode

2006-09-19 Thread Miika Komu
Ok, I will resend the patch in a moment. I tested it with cg-* tools and it did not create any conflicts with davem branch. The email programs with automatic line wrapping are really tricky, seems like mail or mailx really the only options. -- Miika Komu

Re: [PATCH]:[XFRM] BEET mode

2006-09-19 Thread Miika Komu
This patch introduces the BEET mode (Bound End-to-End Tunnel) with as specified by the ietf draft at the following link: http://www.ietf.org/internet-drafts/draft-nikander-esp-beet-mode-06.txt The patch provides only single family support (i.e. inner family = outer family). Signed-off-by: Diego

Re: [PATCH]:[XFRM] BEET mode

2006-09-19 Thread Miika Komu
Ah, forgot to add new files to version control, sorry. My bad... -- Miika Komu http://www.iki.fi/miika/ - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread Hagen Paul Pfeifer
* Andi Kleen | 2006-09-19 12:03:51 [+0200]: How about a single auto selection heuristic: e.g. check the handshake latencies and if they are too long switch from reno to the newer one deemed most stable? Thats absolute no practicable solution to discover the 'right' algorithm. The latenzy is

Re: [PATCH]:[XFRM] BEET mode

2006-09-19 Thread Miika Komu
This patch introduces the BEET mode (Bound End-to-End Tunnel) with as specified by the ietf draft at the following link: http://www.ietf.org/internet-drafts/draft-nikander-esp-beet-mode-06.txt The patch provides only single family support (i.e. inner family = outer family). Signed-off-by: Diego

Re: [PATCH]:[XFRM] BEET mode

2006-09-19 Thread Miika Komu
On Tue, 19 Sep 2006, Miika Komu wrote: Ah, forgot to add new files to version control, sorry. My bad... The last patch I sent should be fine. -- Miika Komu http://www.iki.fi/miika/ - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [PATCH]:[XFRM] BEET mode

2006-09-19 Thread Diego Beltrami
Quoting Miika Komu [EMAIL PROTECTED]: On Tue, 19 Sep 2006, Miika Komu wrote: Ah, forgot to add new files to version control, sorry. My bad... The last patch I sent should be fine. Yes, this patch taken from the mail works just fine. - To unsubscribe from this list: send the line

Re: [PATCH,RESEND] rtl8150: use default MTU of 1500

2006-09-19 Thread Petko Manolov
If this fixes the issue then what else can i say?.. ;-) However, isn't it better to just change RTL8150_MTU to 1500 instead of removing that line? Petko On Sun, 17 Sep 2006, Lennert Buytenhek wrote: The rtl8150 (ethernet) driver uses a default MTU of 1540, which causes

[RFC] indenting/whitespace/comment clean for lane client

2006-09-19 Thread chas williams - CONTRACTOR
its rather big (4000+ lines) so i am posting a url here instead. this reduces net/atm/lec.c by about 17k. ftp://ftp.cmf.nrl.navy.mil/pub/chas/netdev/lec-cleanup-diff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 2.6.18-rc7 3/9] NetXen: hw initilization routines

2006-09-19 Thread Pradeep Dalvi
diff -u linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_init.c linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_init.c --- linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_init.c 2006-09-15 10:51:59.0 -0700 +++ linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_init.c 2006-09-19

Re: [PATCH 2.6.18-rc7 2/9] NetXen: Hardware access routines

2006-09-19 Thread Pradeep Dalvi
diff -u linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_hw.c linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_hw.c --- linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_hw.c 2006-09-15 10:51:59.0 -0700 +++ linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_hw.c 2006-09-19 07:51:20.0

Re: [PATCH 2.6.18-rc7 1/9] NetXen: Makefile and driver main file

2006-09-19 Thread Pradeep Dalvi
Randy, Thanks for feedback. We have incorporated all of the suggestions. -- pradeep diff -u linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_main.c linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_main.c --- linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_main.c 2006-09-15

Re: [PATCH 2.6.18-rc7 5/9] NetXen: ethtool interface

2006-09-19 Thread Pradeep Dalvi
diff -u linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_ethtool.c linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_ethtool.c --- linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_ethtool.c2006-09-15 10:51:59.0 -0700 +++ linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_ethtool.c

Re: [PATCH 2.6.18-rc7 4/9] NetXen: intr routines and niu handling

2006-09-19 Thread Pradeep Dalvi
diff -u linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_niu.c linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_niu.c --- linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_niu.c2006-09-15 10:51:59.0 -0700 +++ linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_niu.c2006-09-19

Re: [PATCH 2.6.18-rc7 6/9] NetXen: Main header file

2006-09-19 Thread Pradeep Dalvi
diff -u linux-2.6.18-rc7/drivers/net/netxen/netxen_nic.h linux-2.6.18-rc7/drivers/net/netxen/netxen_nic.h --- linux-2.6.18-rc7/drivers/net/netxen/netxen_nic.h2006-09-15 10:51:59.0 -0700 +++ linux-2.6.18-rc7/drivers/net/netxen/netxen_nic.h2006-09-19 07:51:20.0 -0700 @@

Re: [PATCH 2.6.18-rc7 7/9] NetXen: hw access routines header file

2006-09-19 Thread Pradeep Dalvi
diff -u linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_hw.h linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_hw.h --- linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_hw.h 2006-09-15 10:51:59.0 -0700 +++ linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_hw.h 2006-09-19 07:51:20.0

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread Stephen Hemminger
On Tue, 19 Sep 2006 12:03:51 +0200 Andi Kleen [EMAIL PROTECTED] wrote: On Tuesday 19 September 2006 06:41, Stephen Hemminger wrote: Bert's attempt was noble It showed your desire for the truth A simple path exists I guess most people won't have a clue on what to configure here

Re: [PATCH 2.6.18-rc7 9/9] NetXen: CRB reg definitions

2006-09-19 Thread Pradeep Dalvi
diff -u linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_phan_reg.h linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_phan_reg.h --- linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_phan_reg.h 2006-09-15 10:51:59.0 -0700 +++ linux-2.6.18-rc7/drivers/net/netxen/netxen_nic_phan_reg.h

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread David Miller
From: Hagen Paul Pfeifer [EMAIL PROTECTED] Date: Tue, 19 Sep 2006 14:35:35 +0200 BTW: BIC is sometimes to aggressive in comparison to standard tcp behaviour (e.g. in short RTT environments) - this is an known issue. Why not cubic as the default one? We may change over to CUBIC as the default

[PATCH 22/23] ixgb: convert to netdev_priv(netdev)

2006-09-19 Thread Kok, Auke
PCI error recovery code recently merged needs to use netdev_priv Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/ixgb/ixgb_main.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c index

[PATCH 05/23] e1000: rename flow control symbols

2006-09-19 Thread Kok, Auke
Sogned-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_ethtool.c | 14 +++--- drivers/net/e1000/e1000_hw.c | 84 +++-- drivers/net/e1000/e1000_hw.h | 18

[PATCH 02/23] e100, e1000, ixgb: Fix an impossible memory overwrite bug

2006-09-19 Thread Kok, Auke
We keep getting requests from people that think that this might be an exploitable hole where we would overwrite 4 bytes in the netdev struct if the pci name would exceed 15 characters. In reality this will never happen but we fix it anyway. Signed-off-by: Auke Kok [EMAIL PROTECTED] ---

[PATCH 09/23] e1000: allow ethtool to pass arbitrary speed advertisment

2006-09-19 Thread Kok, Auke
With a patch, ethtool can now signify the driver to advertise more than just a single speed/duplex setting. This allows you to tell the card to advertise in 10/100 in any speed if you don't have a gigabit switch for instance. Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Auke Kok

[PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

2006-09-19 Thread Kok, Auke
Refine cb cleaning debug printout and print out all cleaned cbs' status. Add debug flag for EEPROM csum failures that were overridden by the user. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e100.c |9 ++--- 1 files

[PATCH 12/23] e1000: Maybe stop TX if not enough free descriptors

2006-09-19 Thread Kok, Auke
Cc: Herbert Xu [EMAIL PROTECTED] Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c | 52 1 files changed, 42 insertions(+), 10 deletions(-) diff --git

[PATCH 21/23] ixgb: combine more rx descriptors to improve performance

2006-09-19 Thread Kok, Auke
We experimented with more descriptor buffer writebacks and found that values larger than 8 give HW problems, but 8 is safe and gives us some improved performance. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/ixgb/ixgb.h |2 +-

[PATCH 13/23] e1000: gather hardware bit tweaks.

2006-09-19 Thread Kok, Auke
Several hardware bits were set all over the driver and have been consolidated into a single function. Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_hw.c | 142 +---

[PATCH 10/23] e1000: Fix MANC detection for PCIE adapters

2006-09-19 Thread Kok, Auke
Several manageability capability detection parts hinted towards our code being incomplete for PCI-E. According to spec, we do not want to poke any MANC bits at all. Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c | 15

[PATCH 19/23] e1000: rework polarity, NVM, eeprom code and fixes.

2006-09-19 Thread Kok, Auke
Several minor issues exist in the low-level device handling code of e1000. The NVM and EEPROM writing/reading code was updated which fixes unneeded delays, adds proper eeprom aqcuiring steps and handle shadow ram and flash access. Minor cosmetic adjustments to the polarity code adding symbols.

[PATCH 11/23] e1000: Jumbo frames fixes for 82573

2006-09-19 Thread Kok, Auke
Disable jumbo frames for 82573L alltogether and when ASPM is enabled since the hardware has problems with it. For the NICs that do support this in the 82573 series we set ERT_2048 to attempt to receive as much traffic as early as we can. Signed-off-by: Bruce Allan [EMAIL PROTECTED]

[PATCH 06/23] e1000: add enums for several link properties

2006-09-19 Thread Kok, Auke
Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_hw.c | 89 +- 1 files changed, 53 insertions(+), 36 deletions(-) diff --git a/drivers/net/e1000/e1000_hw.c

[PATCH 15/23] e1000: add PCI-E capability detection code

2006-09-19 Thread Kok, Auke
Add code to display the detected PCI-E bus width. Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_hw.c | 17 + drivers/net/e1000/e1000_hw.h |6 ++ drivers/net/e1000/e1000_main.c | 16

[PATCH 17/23] e1000: driver state fixes (race fix)

2006-09-19 Thread Kok, Auke
We were plagued by our interrupt handler posting a watchdog event which could occur when our adapter was going down in case a late packet arrived just before e1000_down() finished. This caused the watchdog timer to start after the NIC was down and keep rescheduling it every N seconds. Once the

[PATCH 00/23] e100, e1000, ixgb updates

2006-09-19 Thread Kok, Auke
Hi, The following updates are available through git: git pull git://lost.foo-projects.org/~ahkok/git/netdev-2.6 upstream And apply against c233289c29369dba7177ca873e9b8ed457af2a78 (Jeff Garzik: drivers/net/phy/fixed: #if 0 some incomplete code) Cheers, Auke --- Auke Kok [EMAIL PROTECTED]:

[PATCH 16/23] e1000: reduce RAR entries available for ICH8

2006-09-19 Thread Kok, Auke
Manageability is using one more RAR entry than we anticipated earlier for ICH8. Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_hw.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 23/23] e100, e1000, ixgb: increment version numbers

2006-09-19 Thread Kok, Auke
e100-3.5.17-k2 e1000-7.2.9-k2 ixgb-1.0.117-k2 Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e100.c |2 +- drivers/net/e1000/e1000_main.c |2 +- drivers/net/ixgb/ixgb_main.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 07/23] e1000: remove unused code and make symbols static

2006-09-19 Thread Kok, Auke
Signed-off-by: Nicholas Nunley [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000.h | 21 -- drivers/net/e1000/e1000_ethtool.c | 15 + drivers/net/e1000/e1000_hw.c | 406 +++-- drivers/net/e1000/e1000_hw.h

[PATCH 20/23] e1000: don't strip vlan ID if 8021q claims it

2006-09-19 Thread Kok, Auke
Signed-off-by: Bruce Allan [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index 7a991a4..dc14b98 100644

[PATCH 08/23] e1000: add multicast stats counters

2006-09-19 Thread Kok, Auke
Signed-off-by: Mitch Williams [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_ethtool.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e1000_ethtool.c index

[PATCH 04/23] e100: rework WoL and shutdown handling

2006-09-19 Thread Kok, Auke
Unify our shutdown/suspend/resume code and make it similar to e1000: e1000_shutdown now calls suspend which does the exact same thing on shutdown except saving PCI config state on suspend. WoL setup code is now also more simple and works even when CONFIG_PM is not set, which was previously

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread Stephen Hemminger
On Tue, 19 Sep 2006 09:10:37 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Hagen Paul Pfeifer [EMAIL PROTECTED] Date: Tue, 19 Sep 2006 14:35:35 +0200 BTW: BIC is sometimes to aggressive in comparison to standard tcp behaviour (e.g. in short RTT environments) - this is an known

[PATCH] ethtool: e1000: fix a typo

2006-09-19 Thread Auke Kok
From: Auke Kok [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- e1000.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/e1000.c b/e1000.c index 6de27ca..6741323 100644 --- a/e1000.c +++ b/e1000.c @@ -372,7 +372,7 @@ e1000_dump_regs(struct ethtool_drvinfo

Re: [Bugme-new] [Bug 7159] New: No networking on a machine with Ethernet Pro 100 and Realtek 8139

2006-09-19 Thread Adam C Powell IV
Hello again, It seems nobody received the message below; likely because the SMTP server at work refused to forward a message from [EMAIL PROTECTED] . Sorry about the delay. On Sun, 2006-09-17 at 15:12 -0400, Adam C Powell IV wrote: Hello, and apologies for the reply delay. (This is a

[PATCH] [PATCH] ethtool: add ixgb register dump support

2006-09-19 Thread Auke Kok
From: Nicholas Nunley [EMAIL PROTECTED] This adds support for dumping ixgb registers in readable format. Signed-off-by: Nicholas Nunley [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- Makefile.am|4 +- ethtool-util.h |3 + ethtool.c |2 + ixgb.c |

Re: Fw: [PATCH] Remove powerpc specific parts of 3c509 driver

2006-09-19 Thread Linas Vepstas
On Tue, Sep 19, 2006 at 02:54:33PM +1000, Stephen Rothwell wrote: On powerpc and ppc, insl_ns and insl are identical as are outsl_ns and outsl, so remove the conditional use of insl_ns and outsl_ns. The rest of this patch might indeed be correct, but the above comment bothers me. The ns

Re: [PATCH] ethtool: e1000: fix a typo

2006-09-19 Thread Jeff Garzik
Auke Kok wrote: From: Auke Kok [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- e1000.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/e1000.c b/e1000.c index 6de27ca..6741323 100644 --- a/e1000.c +++ b/e1000.c @@ -372,7 +372,7 @@

Re: [REVISED] [PATCH] ethtool v4: add autoneg advertise feature

2006-09-19 Thread Jeff Garzik
Jeff Kirsher wrote: On 9/5/06, Jeff Kirsher [EMAIL PROTECTED] wrote: adds the ability to change the advertised speed and duplex for a network interface. Previously, a network interface was only able to advertise all supported speed's and duplex's, or one individual speed and duplex. The

Re: [PATCH] [PATCH] ethtool: add ixgb register dump support

2006-09-19 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/23] e1000: rename flow control symbols

2006-09-19 Thread Jeff Garzik
Kok, Auke wrote: --- a/drivers/net/e1000/e1000_hw.h +++ b/drivers/net/e1000/e1000_hw.h @@ -90,15 +90,6 @@ typedef enum { e1000_100_full = 3 } e1000_speed_duplex_type; -/* Flow Control Settings */ -typedef enum { -e1000_fc_none = 0, -e1000_fc_rx_pause = 1, -e1000_fc_tx_pause

Re: [PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

2006-09-19 Thread Jeff Garzik
Kok, Auke wrote: Refine cb cleaning debug printout and print out all cleaned cbs' status. Add debug flag for EEPROM csum failures that were overridden by the user. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] ACK patch, NAK description: tainting

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread David Miller
Actually, I take that back: net/ipv4/sysctl_net_ipv4.c: In function $,1rx(Btcp_congestion_default$,1ry(B: net/ipv4/sysctl_net_ipv4.c:134: error: syntax error before $,1rx(B}$,1ry(B token net/ipv4/sysctl_net_ipv4.c: At top level: net/ipv4/sysctl_net_ipv4.c:136: warning: initialization

Re: [PATCH 08/23] e1000: add multicast stats counters

2006-09-19 Thread Jeff Garzik
Kok, Auke wrote: Signed-off-by: Mitch Williams [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_ethtool.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e1000_ethtool.c

Re: [PATCH 07/23] e1000: remove unused code and make symbols static

2006-09-19 Thread Jeff Garzik
ACK patches 6-7 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 18 Sep 2006 21:41:04 -0700 Bert's attempt was noble It showed your desire for the truth A simple path exists Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Looks good, applied. - To unsubscribe from this list: send the line

Re: [PATCH 13/23] e1000: gather hardware bit tweaks.

2006-09-19 Thread Jeff Garzik
Kok, Auke wrote: Several hardware bits were set all over the driver and have been consolidated into a single function. diff --git a/drivers/net/e1000/e1000_hw.c b/drivers/net/e1000/e1000_hw.c index 9422864..a143b49 100644 --- a/drivers/net/e1000/e1000_hw.c +++ b/drivers/net/e1000/e1000_hw.c

Re: [PATCH 11/23] e1000: Jumbo frames fixes for 82573

2006-09-19 Thread Jeff Garzik
Kok, Auke wrote: Disable jumbo frames for 82573L alltogether and when ASPM is enabled since the hardware has problems with it. For the NICs that do support this in the 82573 series we set ERT_2048 to attempt to receive as much traffic as early as we can. Signed-off-by: Bruce Allan [EMAIL

Re: [PATCH] tcp: set congestion default through Kconfig

2006-09-19 Thread David Miller
Ok, I really give up, after adding the missing semicolon I now get this: net/ipv4/sysctl_net_ipv4.c:136: warning: initialization from incompatible pointer type This is getting rediculious. Folks, don't post patches which are not request for comments explicitly in the subject line without

[PATCH] make some netfilter globals __read_mostly

2006-09-19 Thread Brian Haley
Make some netfilter globals __read_mostly at the request of Patrick McHardy. Signed-off-by: Brian Haley [EMAIL PROTECTED] diff --git a/net/ipv4/netfilter/ip_conntrack_core.c b/net/ipv4/netfilter/ip_conntrack_core.c index aa45917..2370245 100644 --- a/net/ipv4/netfilter/ip_conntrack_core.c +++

Re: [PATCH 18/23] e1000: revert 'e1000: Remove 0x1000 as supported device'

2006-09-19 Thread Jeff Garzik
Kok, Auke wrote: The commit 'e1000: Remove 0x1000 as supported device' (Jeff Kirsher, 673a052fde79ab5e9dce569b0336358812ddba2d) Removes PIC device ID 8086:1000 from the list of supported devices. A fix was submitted for the original issue (commit 6a9516989f94df10d9a27ba543c6b53b3e69c84a). This

Re: [PATCH 17/23] e1000: driver state fixes (race fix)

2006-09-19 Thread Jeff Garzik
ACK - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 14/23] e1000: handle manageability for pci-e adapters at PHY powerdown

2006-09-19 Thread Jeff Garzik
Kok, Auke wrote: When powering down the PHY (if WoL is disabled) we should only check copper PHY's and handle PCI-E adapters differently. Signed-off-by: Bruce Allan [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c | 41

Re: [PATCH 16/23] e1000: reduce RAR entries available for ICH8

2006-09-19 Thread Jeff Garzik
ACK patches 15-16 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Fw: [PATCH] Remove powerpc specific parts of 3c509 driver

2006-09-19 Thread Linas Vepstas
On Tue, Sep 19, 2006 at 08:52:18PM +0200, Matt Sealey wrote: [...] Linas Vepstas wrote: On Tue, Sep 19, 2006 at 02:54:33PM +1000, Stephen Rothwell wrote: On powerpc and ppc, insl_ns and insl are identical as are outsl_ns and outsl, so remove the conditional use of insl_ns and outsl_ns.

Re: [PATCH 23/23] e100, e1000, ixgb: increment version numbers

2006-09-19 Thread Jeff Garzik
ACK patches 21-23 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/23] e1000: Maybe stop TX if not enough free descriptors

2006-09-19 Thread Stephen Hemminger
My preference would be for drivers not to use LLTX (except loopback) and just use the dev-xmit_lock via netif_tx_lock if possible. Something like this for e1000. Subject: [PATCH] e1000 no lltx Get rid of lockless transmit for e1000. Use netif_tx_lock instead of having to do locking in device.

Re: [PATCH 2/3][ATM]: [he] don't hold the device lock when upcalling

2006-09-19 Thread David Miller
From: chas williams - CONTRACTOR [EMAIL PROTECTED] Date: Sat, 16 Sep 2006 20:19:02 -0400 please consider for 2.6.18 -- thanks! [ATM]: [he] don't hold the device lock when upcalling This can create a deadlock/lock ordering problem with other layers that want to use the transmit (or other)

Re: [XFRM]: Fix wildcard as tunnel source

2006-09-19 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 18 Sep 2006 11:43:49 +0200 D'oh. Fixed patch attached. Looks good Patrick, applied. Thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 3/3][ATM]: potential NULL pointer dereference in clip_mkip()

2006-09-19 Thread David Miller
From: chas williams - CONTRACTOR [EMAIL PROTECTED] Date: Sat, 16 Sep 2006 20:19:21 -0400 please consider for 2.6.18 -- thanks! [ATM]: potential NULL pointer dereference in clip_mkip() http://article.gmane.org/gmane.linux.kernel/445717 When re-processing received data, a struct sk_buff

Re: [PATCH 04/23] e100: rework WoL and shutdown handling

2006-09-19 Thread Auke Kok
Jeff Garzik wrote: Kok, Auke wrote: Unify our shutdown/suspend/resume code and make it similar to e1000: e1000_shutdown now calls suspend which does the exact same thing on shutdown except saving PCI config state on suspend. WoL setup code is now also more simple and works even when CONFIG_PM

Re: [PATCH 1/3] sky2: tx pause bug fix

2006-09-19 Thread Stephen Hemminger
On Mon, 11 Sep 2006 11:35:11 +1000 Andrew Hall [EMAIL PROTECTED] wrote: Stephen, After some serious testing, this patch seems to fix the lockup issue completely. I manually applied these changes against the 2.6.17.13 release. Any more problems? - To unsubscribe from this list: send the

Re: [PATCH 04/23] e100: rework WoL and shutdown handling

2006-09-19 Thread Jeff Garzik
Auke Kok wrote: Jeff Garzik wrote: Kok, Auke wrote: Unify our shutdown/suspend/resume code and make it similar to e1000: e1000_shutdown now calls suspend which does the exact same thing on shutdown except saving PCI config state on suspend. WoL setup code is now also more simple and works even

[PATCH] tcp: set congestion default through Kconfig (v2)

2006-09-19 Thread Stephen Hemminger
Bert's attempt was noble It showed your desire for the truth A simple path existed Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/ipv4/Kconfig | 39 +-- net/ipv4/sysctl_net_ipv4.c |6 ++ net/ipv4/tcp_cong.c|2 +- 3

Re: [PATCH 18/23] e1000: revert 'e1000: Remove 0x1000 as supported device'

2006-09-19 Thread Auke Kok
Jeff Garzik wrote: Kok, Auke wrote: The commit 'e1000: Remove 0x1000 as supported device' (Jeff Kirsher, 673a052fde79ab5e9dce569b0336358812ddba2d) Removes PIC device ID 8086:1000 from the list of supported devices. A fix was submitted for the original issue (commit

Re: [PATCH 18/23] e1000: revert 'e1000: Remove 0x1000 as supported device'

2006-09-19 Thread Jeff Garzik
Auke Kok wrote: Jeff Garzik wrote: Kok, Auke wrote: The commit 'e1000: Remove 0x1000 as supported device' (Jeff Kirsher, 673a052fde79ab5e9dce569b0336358812ddba2d) Removes PIC device ID 8086:1000 from the list of supported devices. A fix was submitted for the original issue (commit

Re: [PATCH 12/23] e1000: Maybe stop TX if not enough free descriptors

2006-09-19 Thread Jeff Garzik
looks OK except for the tasklet, which may starve if the lock is being held upon entry - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/23] e1000: Maybe stop TX if not enough free descriptors

2006-09-19 Thread Stephen Hemminger
On Tue, 19 Sep 2006 16:45:06 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: looks OK except for the tasklet, which may starve if the lock is being held upon entry Why would the tasklet starve anymore than NAPI? Worst case, the transmitters fill the ring completely and have to wait for the

Re: [PATCH 00/23] e100, e1000, ixgb updates

2006-09-19 Thread Auke Kok
Jeff Garzik wrote: FYI, note that I killed some OS wrappers from osdep.h in e1000 and ixgb excellent, I am ashamed I didn't get to that myself yet :) Thanks! Auke - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

[PATCH] sky2: process tx pause frames.

2006-09-19 Thread Stephen Hemminger
This patch already is in 2.6.17 stable, but the bigger version was pushed off till 2.6.19. Here is a less intrusive version that needs to go into 2.6.18 (or I'll end up sending it for 2.6.18.1). The driver was telling the GMAC to flush (not process) pause frames. Manually disabling pause wasn't

Re: [PATCH] tcp: set congestion default through Kconfig (v2)

2006-09-19 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Tue, 19 Sep 2006 13:41:32 -0700 Bert's attempt was noble It showed your desire for the truth A simple path existed Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied, but... net/ipv4/Kconfig:607:warning: defaults for choice values

[PATCH] tcp: simpler bic default

2006-09-19 Thread Stephen Hemminger
New tcp default config means we can eliminate the hack that was used previous Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net-2.6.19.orig/net/ipv4/Kconfig2006-09-19 14:27:58.0 -0700 +++ net-2.6.19/net/ipv4/Kconfig 2006-09-19 14:28:17.0 -0700 @@ -602,10 +602,6 @@

Re: [PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

2006-09-19 Thread Dave Jones
On Tue, Sep 19, 2006 at 10:28:38AM -0700, Kok, Auke wrote: Refine cb cleaning debug printout and print out all cleaned cbs' status. Add debug flag for EEPROM csum failures that were overridden by the user. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok

Re: [PATCH] tcp: set congestion default through Kconfig (v2)

2006-09-19 Thread bert hubert
On Tue, Sep 19, 2006 at 02:20:07PM -0700, David Miller wrote: Bert's attempt was noble It showed your desire for the truth It was also crap :-) Applied, but... net/ipv4/Kconfig:607:warning: defaults for choice values not supported It does appear to do the right thing in all cases I throw

Re: [PATCH 03/23] e100: Add debugging code for cb cleaning and csum failures.

2006-09-19 Thread Jeff Garzik
Dave Jones wrote: On Tue, Sep 19, 2006 at 10:28:38AM -0700, Kok, Auke wrote: Refine cb cleaning debug printout and print out all cleaned cbs' status. Add debug flag for EEPROM csum failures that were overridden by the user. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]

Re: [PATCH 04/23] e100: rework WoL and shutdown handling

2006-09-19 Thread Auke Kok
Jeff Garzik wrote: Kok, Auke wrote: Unify our shutdown/suspend/resume code and make it similar to e1000: e1000_shutdown now calls suspend which does the exact same thing on shutdown except saving PCI config state on suspend. WoL setup code is now also more simple and works even when CONFIG_PM

Re: [PATCH] tcp: simpler bic default

2006-09-19 Thread bert hubert
On Tue, Sep 19, 2006 at 02:32:09PM -0700, Stephen Hemminger wrote: Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] # CONFIG_TCP_CONG_ADVANCED is not set # CONFIG_DEFAULT_BIC is not set # CONFIG_DEFAULT_CUBIC is not set # CONFIG_DEFAULT_HTCP is not set # CONFIG_DEFAULT_VEGAS is not set #

  1   2   >