Re: rare bad TCP checksum with 2.6.19?

2007-01-16 Thread Michael Tokarev
Herbert Xu wrote: On Tue, Jan 16, 2007 at 02:27:39PM +1100, Herbert Xu wrote: I'm sorry but this dump does NOT look like it was taken from an intermediate box. I verified two bad checksums (chosen randomly) and they were both correct but partial checksums. This means that this dump was most

Re: watchdog timeout panic in e1000 driver

2007-01-16 Thread Kenzo Iwami
Hi, Thank you for your comment. thanks for staying patient while most of us were out or busy. Apart from acknowledging that you might have fixed a problem with your patch, we're very reluctant to merge such a huge change in our driver that touches much more cases then the one that

Re: [IPROUTE 01/05]: Use tc_calc_xmittime where appropriate

2007-01-16 Thread Jarek Poplawski
On 10-01-2007 11:01, Patrick McHardy wrote: [IPROUTE]: Use tc_calc_xmittime where appropriate Replace expressions of the form 100 * size/rate by tc_calc_xmittime(). The CBQ case deserves an extra comment: when called with bnwd=rate tc_cbq_calc_maxidle behaves identical to

Re: [PATCH -mm 0/10][RFC] aio: make struct kiocb private

2007-01-16 Thread David Brownell
On Monday 15 January 2007 8:25 pm, Nate Diller wrote: I don't think we should be waiting on sync I/O at the *top* of the call stack, like with wait_on_sync_kiocb(), I'd say the best place to wait is at the *bottom*, down in the I/O scheduler. Erm ... *what* I/O scheduler? These I/O

Re: [PATCH -mm 9/10][RFC] aio: usb gadget remove aio file ops

2007-01-16 Thread Nate Diller
On 1/15/07, David Brownell [EMAIL PROTECTED] wrote: On Monday 15 January 2007 5:54 pm, Nate Diller wrote: This removes the aio implementation from the usb gadget file system. NAK. I see a deep mis-understanding here. Aside from making very creative (!) use of the aio retry path, it can't

Re: [PATCH -mm 4/10][RFC] aio: convert aio_complete to file_endio_t

2007-01-16 Thread Nate Diller
On 1/15/07, David Brownell [EMAIL PROTECTED] wrote: On Monday 15 January 2007 5:54 pm, Nate Diller wrote: --- a/drivers/usb/gadget/inode.c 2007-01-12 14:42:29.0 -0800 +++ b/drivers/usb/gadget/inode.c 2007-01-12 14:25:34.0 -0800 @@ -559,35 +559,32 @@ static int

Re: [IPROUTE 01/05]: Use tc_calc_xmittime where appropriate

2007-01-16 Thread Patrick McHardy
Jarek Poplawski wrote: On 10-01-2007 11:01, Patrick McHardy wrote: [IPROUTE]: Use tc_calc_xmittime where appropriate diff --git a/tc/tc_red.c b/tc/tc_red.c index 385e7af..8f9bde0 100644 --- a/tc/tc_red.c +++ b/tc/tc_red.c @@ -71,7 +71,7 @@ int tc_red_eval_ewma(unsigned qmin, unsi int

[PATCH] nl80211: Allocate array of pointers for nla_parse

2007-01-16 Thread Marcus Better
The code allocates an array of struct nlattr, but it seems to me that it should allocate an array of pointers. Signed-off-by: Marcus Better [EMAIL PROTECTED] --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -843,7 +843,7 @@ static int nl80211_initiate_scan(struct sk_buff *skb,

Re: [PATCH] nl80211: Allocate array of pointers for nla_parse

2007-01-16 Thread Johannes Berg
On Tue, 2007-01-16 at 11:13 +0100, Marcus Better wrote: The code allocates an array of struct nlattr, but it seems to me that it should allocate an array of pointers. Signed-off-by: Marcus Better [EMAIL PROTECTED] Yup. Acked-by: Johannes Berg [EMAIL PROTECTED] --- a/net/wireless/nl80211.c

Re: [IPROUTE 01/05]: Use tc_calc_xmittime where appropriate

2007-01-16 Thread Jarek Poplawski
On Tue, Jan 16, 2007 at 11:19:34AM +0100, Patrick McHardy wrote: ... Right, this changes it from long (tc_core_usec2tick) to unsigned int. It doesn't make any difference though, ... ... if we count out reading_time_2tick, of course. Jarek P. - To unsubscribe from this list: send the line

Re: rare bad TCP checksum with 2.6.19?

2007-01-16 Thread Herbert Xu
On Tue, Jan 16, 2007 at 11:08:51AM +0300, Michael Tokarev wrote: Ok. Here's another trace, from that remote network that triggers this thing more-or-less reliable (every 2nd transfer at least) -- http://www.corpit.ru/mjt/bh-bad-cksum-dmp.bin . It's a full session between 216.168.29.244 -

Re: rare bad TCP checksum with 2.6.19?

2007-01-16 Thread Patrick McHardy
Herbert Xu wrote: On Tue, Jan 16, 2007 at 11:08:51AM +0300, Michael Tokarev wrote: Ok. Here's another trace, from that remote network that triggers this thing more-or-less reliable (every 2nd transfer at least) -- http://www.corpit.ru/mjt/bh-bad-cksum-dmp.bin . It's a full session between

Re: [IPROUTE 01/05]: Use tc_calc_xmittime where appropriate

2007-01-16 Thread Patrick McHardy
Jarek Poplawski wrote: On Tue, Jan 16, 2007 at 11:19:34AM +0100, Patrick McHardy wrote: ... Right, this changes it from long (tc_core_usec2tick) to unsigned int. It doesn't make any difference though, ... ... if we count out reading_time_2tick, of course. And this is a problem why? In

Re: [IPROUTE 01/05]: Use tc_calc_xmittime where appropriate

2007-01-16 Thread Jarek Poplawski
On Tue, Jan 16, 2007 at 01:28:52PM +0100, Patrick McHardy wrote: Jarek Poplawski wrote: On Tue, Jan 16, 2007 at 11:19:34AM +0100, Patrick McHardy wrote: ... Right, this changes it from long (tc_core_usec2tick) to unsigned int. It doesn't make any difference though, ... ... if we

Re: [PATCH/RFC 01/10] Implement local diversion of IPv4 skbs

2007-01-16 Thread KOVACS Krisztian
Hi, On Wednesday 10 January 2007 13:19, Patrick McHardy wrote: Of course it's true that doing early lookups and storing that reference in the skb widens the window considerably, but I think this race is already handled. Or is there anything I don't see? You're right, it seems to be

Re: [PATCH/RFC 01/10] Implement local diversion of IPv4 skbs

2007-01-16 Thread Patrick McHardy
KOVACS Krisztian wrote: On Wednesday 10 January 2007 13:19, Patrick McHardy wrote: Of course it's true that doing early lookups and storing that reference in the skb widens the window considerably, but I think this race is already handled. Or is there anything I don't see? You're right, it

Re: [IPROUTE 04/05]: Replace usec by time in function names

2007-01-16 Thread Patrick McHardy
Jarek Poplawski wrote: On 10-01-2007 11:01, Patrick McHardy wrote: [IPROUTE]: Replace usec by time in function names Rename functions containing usec since they don't necessarily return usec units anymore. diff --git a/tc/q_cbq.c b/tc/q_cbq.c index a56..913b26a 100644 --- a/tc/q_cbq.c +++

Re: rare bad TCP checksum with 2.6.19?

2007-01-16 Thread Michael Tokarev
Patrick McHardy wrote: Herbert Xu wrote: [] Since you're certain that this is being seen on the wire, one possibility is that we've got a bug somewhere that's zeroing skb-ip_summed on a packet with a partial checksum. One potential spot where this could happen is netfilter. Patrick, do you

Re: [PATCH]: 8139cp: Don't blindly enable interrupts in cp_start_xmit

2007-01-16 Thread Chris Lalancette
Francois Romieu wrote: Chris Lalancette [EMAIL PROTECTED] : [...] Similar to this commit: http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d15e9c4d9a75702b30e00cdf95c71c88e3f3f51e It's not safe in cp_start_xmit to blindly call spin_lock_irq and then

passthrough openswan connection not working with 2.6.19.2

2007-01-16 Thread Marco Berizzi
Hi. Yesterday I have updated to linux 2.6.19.2 (from 2.6.19.1) and passthrough openswan connection aren't working anymore. This is the 'ip -s x s' output: src 10.180.0.0/16 dst 172.16.0.0/23 uid 0 dir in action allow index 208 priority 2384 ptype main share any flag 0x lifetime config:

Re: Two Dual Core processors and NICS (not handling interrupts on one CPU/assigning a Two Dual Core processors and NICS (not handling interrupts on one CPU / assigning a CPU to a NIC)

2007-01-16 Thread Rick Jones
Mark Ryden wrote: Hello, I have a machine with 2 dual core CPUs. This machine runs Fedora Core 6. I have two Intel e1000 GigaBit network cards on this machine; I use bonding so that the machine assigns the same IP address to both NICs ; It seems to me that bonding is configured OK, bacuse

[PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-16 Thread Marcelo Tosatti
Announcing an updated patch of the Marvell Libertas 8388 802.11 USB driver. Diff can be found at http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch _Please_ review, this driver is targeted for mainline inclusion. There have been almost no comments resulting from the first submission.

Re: [PATCH]: 8139cp: Don't blindly enable interrupts in cp_start_xmit

2007-01-16 Thread Francois Romieu
Chris Lalancette [EMAIL PROTECTED] : [...] Thanks for the comments. While the patch you sent will help, there are still other places that will have problems. For example, in netpoll_send_skb, we call local_irq_save(flags), then call dev-hard_start_xmit(), and then call

Re: passthrough openswan connection not working with 2.6.19.2

2007-01-16 Thread Herbert Xu
Marco Berizzi [EMAIL PROTECTED] wrote: Yesterday I have updated to linux 2.6.19.2 (from 2.6.19.1) and passthrough openswan connection aren't working anymore. This is the 'ip -s x s' output: I presume you mean ip -s x p :) src 10.180.0.0/16 dst 172.16.0.0/23 uid 0 dir in action allow index

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-16 Thread Arkadiusz Miskiewicz
On Tuesday 16 January 2007 19:55, you wrote: Announcing an updated patch of the Marvell Libertas 8388 802.11 USB driver. Diff can be found at http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch Is core chip somehow close to pci/pci-e: 00:07.0 Ethernet controller: Marvell Technology

Re: [Bugme-new] [Bug 7832] New: if i use iproute2 for network balancing

2007-01-16 Thread Andrew Morton
On Tue, 16 Jan 2007 03:13:35 -0800 [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=7832 Summary: if i use iproute2 for network balancing Kernel Version: 2.6.19.1 Status: NEW Severity: normal Owner: [EMAIL PROTECTED]

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-16 Thread Dan Williams
On Tue, 2007-01-16 at 20:32 +0100, Arkadiusz Miskiewicz wrote: On Tuesday 16 January 2007 19:55, you wrote: Announcing an updated patch of the Marvell Libertas 8388 802.11 USB driver. Diff can be found at http://dev.laptop.org/~marcelo/libertas-8388-16012007.patch Is core chip

Re: [Bugme-new] [Bug 7832] New: if i use iproute2 for network balancing

2007-01-16 Thread Ben Greear
Andrew Morton wrote: On Tue, 16 Jan 2007 03:13:35 -0800 [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=7832 Summary: if i use iproute2 for network balancing Kernel Version: 2.6.19.1 Status: NEW Severity: normal Owner: [EMAIL

Re: [Bugme-new] [Bug 7832] New: if i use iproute2 for network balancing

2007-01-16 Thread Herbert Xu
Andrew Morton [EMAIL PROTECTED] wrote: /sbin/ip route change default equalize nexthop dev ppp0 nexthop dev ppp1 /sbin/ip route flush cache Is CONFIG_IP_ROUTE_MULTICACHE turned on? If so does this still happen if you disable it? Cheers, -- Visit Openswan at http://www.openswan.org/ Email:

Re: passthrough openswan connection not working with 2.6.19.2

2007-01-16 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 17 Jan 2007 07:59:05 +1100 [IPSEC]: Policy list disorder The recent hashing introduced an off-by-one bug in policy list insertion. Instead of adding after the last entry with a lesser or equal priority, we're adding after the successor of that

Re: passthrough openswan connection not working with 2.6.19.2

2007-01-16 Thread Herbert Xu
On Tue, Jan 16, 2007 at 05:07:19PM -0800, David Miller wrote: Good catch Herbert, patch applied, thanks. Thanks Dave. I think we need this for 2.6.19 too. [IPSEC]: Policy list disorder The recent hashing introduced an off-by-one bug in policy list insertion. Instead of adding after the last

TKIP encryption should allocate enough tailroom

2007-01-16 Thread Brandon Craig Rhodes
After frustrating days of hung TCP connections, I have determined that the encryption routines in net/iee80211/ieee80211_crypt_tkip.c should be more aggressive in providing themselves with enough packet tailroom to perform their encryption. They presently will only perform encryption if the

Re: passthrough openswan connection not working with 2.6.19.2

2007-01-16 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 17 Jan 2007 13:35:01 +1100 On Tue, Jan 16, 2007 at 05:07:19PM -0800, David Miller wrote: Good catch Herbert, patch applied, thanks. Thanks Dave. I think we need this for 2.6.19 too. [IPSEC]: Policy list disorder The recent hashing

Can someone please try...

2007-01-16 Thread Michael Buesch
...the bcm43xx driver in my tree with a 4318 chip? The code there works excellent with my 4306 now, but I can't get it to work with my 4318. It's strange, it doesn't seem to work at all. I don't seem to be able to TX and RX any packet. Not sure why. To get it, please try to avoid cloning the

Re: Can someone please try...

2007-01-16 Thread Pavel Roskin
On Tue, 2007-01-16 at 18:06 +0100, Michael Buesch wrote: ...the bcm43xx driver in my tree with a 4318 chip? Things are progressing for me a bit because I observed an association to an AP with no security. I still had to use wpa_supplicant. Unfortunately, there is a bigger issue with the new

Re: Can someone please try...

2007-01-16 Thread Andreas Schwab
Michael Buesch [EMAIL PROTECTED] writes: ...the bcm43xx driver in my tree with a 4318 chip? The code there works excellent with my 4306 now, but I can't get it to work with my 4318. Doesn't work for me either. I cannot get it to associate to the AP. Andreas. -- Andreas Schwab, SuSE Labs,

Re: Can someone please try...

2007-01-16 Thread Michael Buesch
On Tuesday 16 January 2007 19:29, Pavel Roskin wrote: On Tue, 2007-01-16 at 18:06 +0100, Michael Buesch wrote: ...the bcm43xx driver in my tree with a 4318 chip? Things are progressing for me a bit because I observed an association to an AP with no security. I still had to use

Re: Can someone please try...

2007-01-16 Thread Michael Buesch
On Tuesday 16 January 2007 20:00, Andreas Schwab wrote: Michael Buesch [EMAIL PROTECTED] writes: ...the bcm43xx driver in my tree with a 4318 chip? The code there works excellent with my 4306 now, but I can't get it to work with my 4318. Doesn't work for me either. I cannot get it to

Re: Can someone please try...

2007-01-16 Thread Pavel Roskin
On Tue, 2007-01-16 at 20:23 +0100, Michael Buesch wrote: A patch for that is already upstream. I don't see it. It's not in your tree yet. It's surprising that it doesn't happen for me, though. Neiter on PPC, nor on i386. It did happen for me on i386, as well as on x86_64. The dump was for

Re: Can someone please try...

2007-01-16 Thread Michael Buesch
On Tuesday 16 January 2007 22:50, Pavel Roskin wrote: On Tue, 2007-01-16 at 20:23 +0100, Michael Buesch wrote: A patch for that is already upstream. I don't see it. It's not in your tree yet. It is on its way upstream to linville. It's surprising that it doesn't happen for me, though.

Re: Can someone please try...

2007-01-16 Thread Pavel Roskin
On Tue, 2007-01-16 at 23:07 +0100, Michael Buesch wrote: On Tuesday 16 January 2007 22:50, Pavel Roskin wrote: On Tue, 2007-01-16 at 20:23 +0100, Michael Buesch wrote: A patch for that is already upstream. I don't see it. It's not in your tree yet. It is on its way upstream to

Re: TKIP encryption should allocate enough tailroom

2007-01-16 Thread Brandon Craig Rhodes
Mitchell Blank Jr [EMAIL PROTECTED] writes: Brandon Craig Rhodes wrote: +if (unlikely(err || skb_tailroom(skb) 4)) { +printk(KERN_DEBUG Failed to increase tailroom +for TKIP encrypt); +return err || -1; The

Re: TKIP encryption should allocate enough tailroom

2007-01-16 Thread Michael Wu
On Tuesday 16 January 2007 21:31, Brandon Craig Rhodes wrote: The attached patch, if applied to kernel 2.6.18, solves both problems. I am not very familiar with the conventions of kernel networking code, so there may be better ways of fixing this; but the patch should illustrate the general

Re: TKIP encryption should allocate enough tailroom

2007-01-16 Thread Mitchell Blank Jr
Brandon Craig Rhodes wrote: + if (skb_tailroom(skb) 4) { + int err; + err = skb_padto(skb, skb-len + 4); + if (unlikely(err || skb_tailroom(skb) 4)) { + printk(KERN_DEBUG Failed to increase tailroom +

Re: TKIP encryption should allocate enough tailroom

2007-01-16 Thread Herbert Xu
Brandon Craig Rhodes [EMAIL PROTECTED] wrote: Egads! You are correct. My intention was to preserve the value of err if an unsuccessful value was returned by skb_padto(), and otherwise to return -1 which seemed the popular value used for errors elsewhere in the code. - Would the

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-16 Thread Johannes Berg
On Tue, 2007-01-16 at 16:55 -0200, Marcelo Tosatti wrote: _Please_ review, this driver is targeted for mainline inclusion. There have been almost no comments resulting from the first submission. We had looked over the previous version a few days ago and noticed that the biggest part of the

[PATCH 5/9] mm: emergency pool

2007-01-16 Thread Peter Zijlstra
Provide means to reserve a specific amount pages. The emergency pool is separated from the min watermark because ALLOC_HARDER and ALLOC_HIGH modify the watermark in a relative way and thus do not ensure a strict minimum. Signed-off-by: Peter Zijlstra [EMAIL PROTECTED] --- include/linux/mmzone.h

[PATCH 3/9] mm: allow PF_MEMALLOC from softirq context

2007-01-16 Thread Peter Zijlstra
Allow PF_MEMALLOC to be set in softirq context. When running softirqs from a borrowed context save current-flags, ksoftirqd will have its own task_struct. Signed-off-by: Peter Zijlstra [EMAIL PROTECTED] --- kernel/softirq.c |3 +++ mm/internal.h| 14 -- 2 files changed, 11

[PATCH 9/9] net: vm deadlock avoidance core

2007-01-16 Thread Peter Zijlstra
In order to provide robust networked storage there must be a guarantee of progress. That is, the storage device must never stall because of (physical) OOM, because the device itself might be needed to get out of it (reclaim). This means that the device must always find enough memory to build/send

[PATCH 7/9] mm: allow mempool to fall back to memalloc reserves

2007-01-16 Thread Peter Zijlstra
Allow the mempool to use the memalloc reserves when all else fails and the allocation context would otherwise allow it. Signed-off-by: Peter Zijlstra [EMAIL PROTECTED] --- mm/mempool.c | 10 ++ 1 file changed, 10 insertions(+) Index: linux-2.6-git/mm/mempool.c

[PATCH 2/9] mm: slab allocation fairness

2007-01-16 Thread Peter Zijlstra
The slab allocator has some unfairness wrt gfp flags; when the slab cache is grown the gfp flags are used to allocate more memory, however when there is slab cache available (in partial or free slabs, per cpu caches or otherwise) gfp flags are ignored. Thus it is possible for less critical slab

[PATCH 8/9] slab: kmem_cache_objs_to_pages()

2007-01-16 Thread Peter Zijlstra
Provide a method to calculate the number of pages needed to store a given number of slab objects (upper bound when considering possible partial and free slabs). Signed-off-by: Peter Zijlstra [EMAIL PROTECTED] --- include/linux/slab.h |1 + mm/slab.c|6 ++ 2 files changed,

[PATCH 1/9] mm: page allocation rank

2007-01-16 Thread Peter Zijlstra
Introduce page allocation rank. This allocation rank is an measure of the 'hardness' of the page allocation. Where hardness refers to how deep we have to reach (and thereby if reclaim was activated) to obtain the page. It basically is a mapping from the ALLOC_/gfp flags into a scalar quantity,

[PATCH 0/9] VM deadlock avoidance -v10

2007-01-16 Thread Peter Zijlstra
These patches implement the basic infrastructure to allow swap over networked storage. The basic idea is to reserve some memory up front to use when regular memory runs out. To bound network behaviour we accept only a limited number of concurrent packets and drop those packets that are not

[PATCH 4/9] mm: serialize access to min_free_kbytes

2007-01-16 Thread Peter Zijlstra
There is a small race between the procfs caller and the memory hotplug caller of setup_per_zone_pages_min(). Not a big deal, but the next patch will add yet another caller. Time to close the gap. Signed-off-by: Peter Zijlstra [EMAIL PROTECTED] --- mm/page_alloc.c | 16 +--- 1 file

[PATCH 6/9] mm: __GFP_EMERGENCY

2007-01-16 Thread Peter Zijlstra
__GFP_EMERGENCY will allow the allocation to disregard the watermarks, much like PF_MEMALLOC. Signed-off-by: Peter Zijlstra [EMAIL PROTECTED] --- include/linux/gfp.h |7 ++- mm/internal.h | 10 +++--- 2 files changed, 13 insertions(+), 4 deletions(-) Index:

Re: [PATCH 9/9] net: vm deadlock avoidance core

2007-01-16 Thread Evgeniy Polyakov
On Tue, Jan 16, 2007 at 10:46:06AM +0100, Peter Zijlstra ([EMAIL PROTECTED]) wrote: In order to provide robust networked storage there must be a guarantee of progress. That is, the storage device must never stall because of (physical) OOM, because the device itself might be needed to get out

Re: [PATCH 9/9] net: vm deadlock avoidance core

2007-01-16 Thread Peter Zijlstra
On Tue, 2007-01-16 at 16:25 +0300, Evgeniy Polyakov wrote: On Tue, Jan 16, 2007 at 10:46:06AM +0100, Peter Zijlstra ([EMAIL PROTECTED]) wrote: @@ -1767,10 +1767,23 @@ int netif_receive_skb(struct sk_buff *sk struct net_device *orig_dev; int ret = NET_RX_DROP; __be16 type;

Re: [PATCH 9/9] net: vm deadlock avoidance core

2007-01-16 Thread Evgeniy Polyakov
On Tue, Jan 16, 2007 at 02:47:54PM +0100, Peter Zijlstra ([EMAIL PROTECTED]) wrote: + if (unlikely(skb-emergency)) + current-flags |= PF_MEMALLOC; Access to 'current' in netif_receive_skb()??? Why do you want to work with, for example keventd? Can this run in keventd?

Re: [PATCH 9/9] net: vm deadlock avoidance core

2007-01-16 Thread Peter Zijlstra
On Tue, 2007-01-16 at 18:33 +0300, Evgeniy Polyakov wrote: On Tue, Jan 16, 2007 at 02:47:54PM +0100, Peter Zijlstra ([EMAIL PROTECTED]) wrote: + if (unlikely(skb-emergency)) + current-flags |= PF_MEMALLOC; Access to 'current' in netif_receive_skb()??? Why

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-16 Thread Allen Parker
Allen Parker wrote: I have a PCI-E pro/1000 MT Quad Port adapter, which works quite well under 2.6.19.2 but fails to see link under 2.6.20-rc5. Earlier today I reported this to [EMAIL PROTECTED], but thought I should get the word out in case someone else is testing this kernel on this nic

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-16 Thread Auke Kok
Allen Parker wrote: Allen Parker wrote: I have a PCI-E pro/1000 MT Quad Port adapter, which works quite well under 2.6.19.2 but fails to see link under 2.6.20-rc5. Earlier today I reported this to [EMAIL PROTECTED], but thought I should get the word out in case someone else is testing this

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread Eric W. Biederman
CC list trimmed. H. Peter Anvin [EMAIL PROTECTED] writes: Eric W. Biederman wrote: - Removal of sys_sysctl support where people had used conflicting sysctl numbers. Trying to break glibc or other applications by changing the ABI is not cool. 9 instances of this in the kernel seems a

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread H. Peter Anvin
Eric W. Biederman wrote: I think it would be fair to say that if they're not in linux/sysctl.h they're not architectural, but that doesn't resolve the counterpositive (are there sysctls in linux/sysctl.h which aren't architectural? From the looks of it, I would say yes.) Non-architectural

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread Eric W. Biederman
H. Peter Anvin [EMAIL PROTECTED] writes: Eric W. Biederman wrote: I think it would be fair to say that if they're not in linux/sysctl.h they're not architectural, but that doesn't resolve the counterpositive (are there sysctls in linux/sysctl.h which aren't architectural? From the looks of

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread H. Peter Anvin
Eric W. Biederman wrote: With architectural I mean guaranteed to be stable (as opposed to incidental). Sorry for the confusion. Ok. Then largely we are in agreement. To implement that the rule is simple. If it isn't CTL_UNNUMBERED and the number is in Linus's tree, it is our

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread Eric W. Biederman
H. Peter Anvin [EMAIL PROTECTED] writes: Eric W. Biederman wrote: With architectural I mean guaranteed to be stable (as opposed to incidental). Sorry for the confusion. Ok. Then largely we are in agreement. To implement that the rule is simple. If it isn't CTL_UNNUMBERED and the number

Re: [PATCH 0/59] Cleanup sysctl

2007-01-16 Thread H. Peter Anvin
Eric W. Biederman wrote: Agreed. *Furthermore*, if the number isn't in linux/sysctl.h it shouldn't exist anywhere else, either. That would be a good habit. Feel free to send the patches to ensure that is so. I'm a practical fix it when it is in my way kind of guy ;) That's fine.

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-16 Thread Jesse Brandeburg
On 1/16/07, Allen Parker [EMAIL PROTECTED] wrote: Allen Parker wrote: I have a PCI-E pro/1000 MT Quad Port adapter, which works quite well under 2.6.19.2 but fails to see link under 2.6.20-rc5. Earlier today I reported this to [EMAIL PROTECTED], but thought I should get the word out in case

[PATCH -MM] e1000: update new hardware init layer code with bugfixes

2007-01-16 Thread Auke Kok
e1000: update new hardware init layer code with bugfixes From: Jeb Cramer [EMAIL PROTECTED] Replace hard coded RAR numbers with constant. Add several function description and fix some small copy+paste errors in others. Fix link speed detection on PCI adapters showing wrong PCI bus speed. Fix laa

RE: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-16 Thread Brandeburg, Jesse
added Linux-pci Jesse Brandeburg wrote: On 1/16/07, Allen Parker [EMAIL PROTECTED] wrote: Allen Parker wrote: I have a PCI-E pro/1000 MT Quad Port adapter, which works quite well under 2.6.19.2 but fails to see link under 2.6.20-rc5. Earlier today I reported this to [EMAIL PROTECTED], but

[PATCH 2.6.20-rc3]: 8139cp: Don't blindly enable interrupts

2007-01-16 Thread Chris Lalancette
Francois Romieu wrote: Chris Lalancette [EMAIL PROTECTED] : [...] Thanks for the comments. While the patch you sent will help, there are still other places that will have problems. For example, in netpoll_send_skb, we call local_irq_save(flags), then call dev-hard_start_xmit(), and

Re: [PATCH 9/9] net: vm deadlock avoidance core

2007-01-16 Thread Evgeniy Polyakov
On Tue, Jan 16, 2007 at 05:08:15PM +0100, Peter Zijlstra ([EMAIL PROTECTED]) wrote: On Tue, 2007-01-16 at 18:33 +0300, Evgeniy Polyakov wrote: On Tue, Jan 16, 2007 at 02:47:54PM +0100, Peter Zijlstra ([EMAIL PROTECTED]) wrote: + if (unlikely(skb-emergency)) +

[take33 6/10] kevent: Pipe notifications.

2007-01-16 Thread Evgeniy Polyakov
Pipe notifications. diff --git a/fs/pipe.c b/fs/pipe.c index 68090e8..0c75bf1 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -16,6 +16,7 @@ #include linux/uio.h #include linux/highmem.h #include linux/pagemap.h +#include linux/kevent.h #include asm/uaccess.h #include asm/ioctls.h @@ -313,6

[take33 3/10] kevent: poll/select() notifications.

2007-01-16 Thread Evgeniy Polyakov
poll/select() notifications. This patch includes generic poll/select notifications. kevent_poll works simialr to epoll and has the same issues (callback is invoked not from internal state machine of the caller, but through process awake, a lot of allocations and so on). Signed-off-by: Evgeniy

[take33 4/10] kevent: Socket notifications.

2007-01-16 Thread Evgeniy Polyakov
Socket notifications. This patch includes socket send/recv/accept notifications. Using trivial web server based on kevent and this features instead of epoll it's performance increased more than noticebly. More details about various benchmarks and server itself (evserver_kevent.c) can be found

[take33 9/10] kevent: Private userspace notifications.

2007-01-16 Thread Evgeniy Polyakov
Private userspace notifications. Allows to register notifications of any private userspace events over kevent. Events can be marked as readt using kevent_ctl(KEVENT_READY) command. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/kernel/kevent/kevent_unotify.c

[take33 8/10] kevent: Kevent posix timer notifications.

2007-01-16 Thread Evgeniy Polyakov
Kevent posix timer notifications. Simple extensions to POSIX timers which allows to deliver notification of the timer expiration through kevent queue. Example application posix_timer.c can be found in archive on project homepage. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git

[take33 7/10] kevent: Signal notifications.

2007-01-16 Thread Evgeniy Polyakov
Signal notifications. This type of notifications allows to deliver signals through kevent queue. One can find example application signal.c on project homepage. If KEVENT_SIGNAL_NOMASK bit is set in raw_u64 id then signal will be delivered only through queue, otherwise both delivery types are

[take33 5/10] kevent: Timer notifications.

2007-01-16 Thread Evgeniy Polyakov
Timer notifications. Timer notifications can be used for fine grained per-process time management, since interval timers are very inconvenient to use, and they are limited. This subsystem uses high-resolution timers. id.raw[0] is used as number of seconds id.raw[1] is used as number of

Re: [PATCH -mm 2/10][RFC] aio: net use struct socket for io

2007-01-16 Thread Evgeniy Polyakov
On Mon, Jan 15, 2007 at 09:44:27PM -0800, Stephen Hemminger ([EMAIL PROTECTED]) wrote: The sendmsg and recvmsg socket operations take a kiocb pointer, but none of the functions actually use it. There's really no need even theoretically, it's really quite ugly having it there at all. Also,

Re: [PATCH -mm 9/10][RFC] aio: usb gadget remove aio file ops

2007-01-16 Thread David Brownell
On Tuesday 16 January 2007 1:13 am, Nate Diller wrote: On 1/15/07, David Brownell [EMAIL PROTECTED] wrote: What's needed is an async, non-sleeeping, interface ... with I/O overlap. That's antithetical to using read()/write() calls, so your proposed approach couldn't possibly work. haha,

Re: [PATCH -mm 3/10][RFC] aio: use iov_length instead of ki_left

2007-01-16 Thread Ingo Oeser
On Tuesday, 16. January 2007 06:37, Nate Diller wrote: On 1/15/07, Christoph Hellwig [EMAIL PROTECTED] wrote: On Mon, Jan 15, 2007 at 05:54:50PM -0800, Nate Diller wrote: Convert code using iocb-ki_left to use the more generic iov_length() call. No way. We need to reduce the numer

[take33 1/10] kevent: Description.

2007-01-16 Thread Evgeniy Polyakov
Description. diff --git a/Documentation/kevent.txt b/Documentation/kevent.txt new file mode 100644 index 000..87a1ba9 --- /dev/null +++ b/Documentation/kevent.txt @@ -0,0 +1,268 @@ +Description. + +int kevent_init(struct kevent_ring *ring, unsigned int ring_size, + unsigned int

[take33 0/10] kevent: Generic event handling mechanism.

2007-01-16 Thread Evgeniy Polyakov
Generic event handling mechanism. Kevent is a generic subsytem which allows to handle event notifications. It supports both level and edge triggered events. It is similar to poll/epoll in some cases, but it is more scalable, it is faster and allows to work with essentially eny kind of events.

[take33 10/10] kevent: Kevent based AIO (aio_sendfile()/aio_sendfile_path()).

2007-01-16 Thread Evgeniy Polyakov
Kevent based AIO (aio_sendfile()/aio_sendfile_path()). aio_sendfile()/aio_sendfile_path() contains of two major parts: AIO state machine and page processing code. The former is just a small subsystem, which allows to queue callback for theirs invocation in process' context on behalf of pool

[PATCH 24/59] sysctl: frv remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted Since the binary sysctl numbers are unique putting the registered sysctls at the head of the sysctl list where they can override existing sysctls serves no useful purpose. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] ---

[PATCH 0/59] Cleanup sysctl

2007-01-16 Thread Eric W. Biederman
There has not been much maintenance on sysctl in years, and as a result is there is a lot to do to allow future interesting work to happen, and being ambitious I'm trying to do it all at once :) The patches in this series fall into several general categories. - Removal of useless attempts to

[PATCH 44/59] sysctl: Register the sysctl number used by the arlan driver.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- drivers/net/wireless/arlan-proc.c |2 +- include/linux/sysctl.h|1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/arlan-proc.c

[PATCH 33/59] sysctl: s390 move sysctl definitions to sysctl.h

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted We need to have the the definition of all top level sysctl directories registers in sysctl.h so we don't conflict by accident and cause abi problems. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- arch/s390/appldata/appldata.h |3

[PATCH 7/59] sysctl: llc remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted The sysctl numbers used are unique so setting the insert_at_head flag serves no semantis purpose, and is just confusing. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- net/llc/sysctl_net_llc.c |2 +- 1 files changed, 1

[PATCH 15/59] sysctl: scsi remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- drivers/scsi/scsi_sysctl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/scsi_sysctl.c b/drivers/scsi/scsi_sysctl.c index 04d06c2..b16b775 100644

[PATCH 57/59] sysctl: allow sysctl_perm to be called from outside of sysctl.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- include/linux/sysctl.h |2 ++ kernel/sysctl.c| 10 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h

[PATCH 6/59] sysctl: netrom remove unnecessary insert_at_head flag

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted The sysctl numbers used are unique so setting the insert_at_head flag serves no semantic purpose, so it is just confusing. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- net/netrom/sysctl_net_netrom.c |2 +- 1 files changed, 1

[PATCH 51/59] sysctl: Move SYSV IPC sysctls to their own file

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted This is just a simple cleanup to keep kernel/sysctl.c from getting to crowded with special cases, and by keeping all of the ipc logic to together it makes the code a little more readable. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] ---

[PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- drivers/parport/procfs.c | 264 +- 1 files changed, 189 insertions(+), 75 deletions(-) diff --git a/drivers/parport/procfs.c

[PATCH 50/59] sysctl: Move utsname sysctls to their own file

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted This is just a simple cleanup to keep kernel/sysctl.c from getting to crowded with special cases, and by keeping all of the utsname logic to together it makes the code a little more readable. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]

[PATCH 47/59] sysctl: C99 convert ctl_tables in NTFS and remove sys_sysctl support

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted Putting ntfs-debug under FS_NRINODE was not a kosher thing to do so don't give it any binary number. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- fs/ntfs/sysctl.c | 24 1 files changed, 16 insertions(+), 8

[PATCH 41/59] sysctl: C99 convert ctl_tables in arch/x86_64/mm/init.c

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- arch/x86_64/mm/init.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/arch/x86_64/mm/init.c b/arch/x86_64/mm/init.c index 65aa66c..a04535d

[PATCH 54/59] sysctl: Remove support for directory strategy routines.

2007-01-16 Thread Eric W. Biederman
From: Eric W. Biederman [EMAIL PROTECTED] - unquoted parse_table has support for calling a strategy routine when descending into a directory. To date no one has used this functionality and the /proc/sys interface has no analog to it. So no one is using this functionality kill it and make the

  1   2   >