Re: [PATCH] NET : change layout of ehash table

2007-02-09 Thread Andi Kleen
David Miller [EMAIL PROTECTED] writes: I've applied this, but I _REALLY_ don't like the new multiply instructions that are used now in the hash indexing paths when CONFIG_SMP is set. I think that's a higher cost than the memory waste. You're serious? multiply on a modern CPU is _much_

Re: [PATCH][IPSEC][4/6] changing ipip tunnel and xfrm4_tunnel to the API change

2007-02-09 Thread Patrick McHardy
Kazunori MIYAZAWA wrote: Thank you Patrick for your review. I'll fix and send again. Thanks. BTW, I'm going to use separete xfrm_tunnel_handler to solve the issue which you pointed at the moment. But why does register twice corrupt the list even if I use separate lists for the address

Re: [PATCH] NET : change layout of ehash table

2007-02-09 Thread David Miller
From: Andi Kleen [EMAIL PROTECTED] Date: 09 Feb 2007 10:18:03 +0100 David Miller [EMAIL PROTECTED] writes: I've applied this, but I _REALLY_ don't like the new multiply instructions that are used now in the hash indexing paths when CONFIG_SMP is set. I think that's a higher cost

Re: [PATCH] NET : change layout of ehash table

2007-02-09 Thread Andi Kleen
On Friday 09 February 2007 09:40, David Miller wrote: From: Andi Kleen [EMAIL PROTECTED] Date: 09 Feb 2007 10:18:03 +0100 David Miller [EMAIL PROTECTED] writes: I've applied this, but I _REALLY_ don't like the new multiply instructions that are used now in the hash indexing paths

Re: [PATCH] NET : change layout of ehash table

2007-02-09 Thread Eric Dumazet
On Friday 09 February 2007 09:40, David Miller wrote: From: Andi Kleen [EMAIL PROTECTED] Date: 09 Feb 2007 10:18:03 +0100 David Miller [EMAIL PROTECTED] writes: I've applied this, but I _REALLY_ don't like the new multiply instructions that are used now in the hash indexing paths when

Re: [PATCH] NET : change layout of ehash table

2007-02-09 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 9 Feb 2007 10:06:24 +0100 Yes, but a decent C compiler for such targets should not use a multiply instruction to perform a (idx * 12) operation... :) Good point. Actually, I could never get GCC to avoid a divide on sparc64 for certain kinds of

Re: [PATCH] NET : change layout of ehash table

2007-02-09 Thread Eric Dumazet
On Friday 09 February 2007 10:15, David Miller wrote: From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 9 Feb 2007 10:06:24 +0100 Yes, but a decent C compiler for such targets should not use a multiply instruction to perform a (idx * 12) operation... :) Good point. Actually, I could never

Re: [PATCH] NET : change layout of ehash table

2007-02-09 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 9 Feb 2007 10:36:58 +0100 Thats strange, because pointer arithmetic is unsigned... I dont know when gcc started to use reciprocal division, maybe your gcc was very old ? Yep, it was only on older gcc's. And as the sparc gcc backend

Re: [PATCH] NET : change layout of ehash table

2007-02-09 Thread Andi Kleen
On Friday 09 February 2007 10:43, David Miller wrote: Current gcc does the right thing, even for weird sizes like 56 and 52 which expands to many IALU operations. ... except if you use -Os, which at least on x86* is default and is what distros ship with. -Andi - To unsubscribe from this

Re: [PATCH 0/5] [RFC] AF_RXRPC socket family implementation

2007-02-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Fri, 09 Feb 2007 10:31:34 +), David Howells [EMAIL PROTECTED] says: YOSHIFUJI Hideaki [EMAIL PROTECTED] wrote: This sockaddr_rxrpc{} should NOT include sockaddr_in{} directly. Please use sockaddr_storage{} (or sockaddr{}, maybe), and make it sure to

Re: [PATCH 1/5] Add PCBC crypto template support

2007-02-09 Thread David Howells
Herbert Xu [EMAIL PROTECTED] wrote: This is already in the crypto-2.6 tree that I pushed yesterday. Thanks. However, I'll continue to include the patches in my set until they reach Linus's tree. David - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [PATCH 0/5] [RFC] AF_RXRPC socket family implementation

2007-02-09 Thread David Howells
YOSHIFUJI Hideaki [EMAIL PROTECTED] wrote: and make it sure to align on 64-bit word. The first part of sockaddr_rxrpc is exactly 64 bits; then comes the transport address, so that's okay. This sockaddr_rxrpc{} should NOT include sockaddr_in{} directly. Please use sockaddr_storage{} (or

Re: [PATCH 0/5] [RFC] AF_RXRPC socket family implementation

2007-02-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Fri, 09 Feb 2007 12:31:23 +), David Howells [EMAIL PROTECTED] says: YOSHIFUJI Hideaki [EMAIL PROTECTED] wrote: and make it sure to align on 64-bit word. The first part of sockaddr_rxrpc is exactly 64 bits; then comes the transport address, so that's

Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

2007-02-09 Thread Timur Tabi
Li Yang-r58472 wrote: No, we don't know if the BD ring is in MURAM or main memory as it is configurable. iopa() is best choice to handle both case, IMHO. The above code would only be used if the BD is in MURAM. The if bd_mem_part == MEM_PART_MURAM would stay. If the BD ring can be in

[PATCH 0/2] NetXen: 1G/10G Ethernet Driver updates

2007-02-09 Thread Amit S. Kale
Hi All, I will be sending NetXen: 1G/10G Ethernet Driver updates with respect to netdev #upstream in the subsequent emails. Thanks, --Amit ~ - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 1/2] NetXen: Fixes for ppc architecture.

2007-02-09 Thread Amit S. Kale
NetXen: Fixes for ppc architecture. Signed-off-by: Amit S. Kale [EMAIL PROTECTED] --- netxen_nic_hw.c |2 ++ netxen_nic_init.c |4 ++-- netxen_nic_main.c |3 ++- netxen_nic_niu.c |2 +- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 0/5] [RFC] AF_RXRPC socket family implementation

2007-02-09 Thread David Howells
YOSHIFUJI Hideaki [EMAIL PROTECTED] wrote: Because it is protocol (such as ipv4 or ipv6) dependent. Hmmm... I had thought of RxRPC being very transport dependent, being rather tied to UDPv4, though probably simply extensible to UDPv6. However, as long as the transport-layer header is removed

[PATCH 2/2] NetXen: Updates for ethtool support

2007-02-09 Thread Amit S. Kale
NetXen: Updates for ethtool support. Signed-off-by: Amit S. Kale [EMAIL PROTECTED] --- netxen_nic.h |1 + netxen_nic_ethtool.c |9 + netxen_nic_init.c|8 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/net/netxen/netxen_nic.h

[NET]: Fix whitespace errors

2007-02-09 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. Please pull 2.6.20-net-2.6-20070209-whitespace branch at git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git to fix trivial whitespace errors: - convert leading sequences of whitespace with tab(s). - remove whitespace at the end of line. under net. Tree is on top of current net

Re: [NET]: Fix whitespace errors

2007-02-09 Thread Kumar Gala
On Feb 9, 2007, at 8:41 AM, YOSHIFUJI Hideaki / 吉藤英明 wrote: Hello. Please pull 2.6.20-net-2.6-20070209-whitespace branch at git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git to fix trivial whitespace errors: - convert leading sequences of whitespace with tab(s). - remove

Re: [NET]: Fix whitespace errors

2007-02-09 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article [EMAIL PROTECTED] (at Fri, 9 Feb 2007 09:47:27 -0600), Kumar Gala [EMAIL PROTECTED] says: to fix trivial whitespace errors: - convert leading sequences of whitespace with tab(s). - remove whitespace at the end of line. under net. Tree is on top of current net-2.6

Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

2007-02-09 Thread Timur Tabi
Dan Malek wrote: On Feb 8, 2007, at 8:35 AM, Timur Tabi wrote: That's what the original code did, kinda. It called virt_to_phys() if it is main memory, and it called immrbar_virt_to_phys() if it is MURAM. immrbar_virt_to_phys() did pointer math to extract the physical address. You've

Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa

2007-02-09 Thread Dan Malek
On Feb 8, 2007, at 8:35 AM, Timur Tabi wrote: That's what the original code did, kinda. It called virt_to_phys() if it is main memory, and it called immrbar_virt_to_phys() if it is MURAM. immrbar_virt_to_phys() did pointer math to extract the physical address. You've got to be

[PATCH] NET : UDP can use sk_hash to speedup lookups

2007-02-09 Thread Eric Dumazet
In a prior patch, I introduced a sk_hash field (__sk_common.skc_hash) to let tcp lookups use one cache line per unmatched entry instead of two. We can also use sk_hash to speedup UDP part as well. We store in sk_hash the hnum value, and use sk-sk_hash (same cache line than 'next' pointer),

Re: [Bugme-new] [Bug 7962] New: oops in port_carrier_check

2007-02-09 Thread Stephen Hemminger
On Fri, 9 Feb 2007 08:42:11 +0100 Jarek Poplawski [EMAIL PROTECTED] wrote: On 07-02-2007 23:09, Stephen Hemminger wrote: On Wed, 7 Feb 2007 12:52:16 -0800 Andrew Morton [EMAIL PROTECTED] wrote: ... Feb 7 21:20:18 plop kernel: BUG: unable to handle kernel paging request at virtual

Re: [PATCH] phy devices: use same arg types

2007-02-09 Thread Andy Fleming
On Feb 5, 2007, at 12:44, Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] sparse complains about differing types from prototype to definition, so change the u32 to phy_interface_t: drivers/net/phy/phy_device.c:140:19: error: symbol 'phy_connect' redeclared with different type

Re: [Bugme-new] [Bug 7962] New: oops in port_carrier_check

2007-02-09 Thread Pascal Terjan
2007/2/9, Stephen Hemminger [EMAIL PROTECTED]: The carrier_check is canceled by removal of port from bridge. Perhaps there is something broken in rcu assumptions under Qemu If that can help: I started /stopped qemu several times. Maybe I started /stopped qemu several times as I was testing new

Re: [PATCH 0/7] [S390]: Introduction of AF_IUCV sockets support

2007-02-09 Thread Frank Pavlic
On Thu, Feb 08, 2007 at 02:00:22PM -0800, David Miller wrote: From: Frank Pavlic [EMAIL PROTECTED] Date: Fri, 2 Feb 2007 13:05:28 +0100 The patch set consists of following patches: [1/7] [S390]: Rewrite of the IUCV base code, part 1 [2/7] [S390]: Rewrite of the IUCV base code, part 2

Re: 2.6.20 crash in tcp_tso_segment()

2007-02-09 Thread Herbert Xu
Mike Accetta [EMAIL PROTECTED] wrote: Obviously the code believes it can assume that there are always multiple sk_buff's in the chain. The stack trace seems to implicate iptables in the scenario (twice) if that means anything. Any ideas about what may be going wrong here? There is indeed

Please pull upstream branch of wireless-2.6

2007-02-09 Thread John W. Linville
On Wed, Feb 07, 2007 at 04:11:17PM -0500, John W. Linville wrote: On Tue, Feb 06, 2007 at 07:06:07PM -0500, Jeff Garzik wrote: Would you mind rebasing resending, kind sir? By your command! :-) And once more, now with feeling! :-) --- The following changes since commit

Re: [PATCH 1/2] NetXen: Fixes for ppc architecture.

2007-02-09 Thread Jeff Garzik
Amit S. Kale wrote: NetXen: Fixes for ppc architecture. Signed-off-by: Amit S. Kale [EMAIL PROTECTED] applied 1-2 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Please pull upstream branch of wireless-2.6

2007-02-09 Thread Jeff Garzik
John W. Linville wrote: On Wed, Feb 07, 2007 at 04:11:17PM -0500, John W. Linville wrote: On Tue, Feb 06, 2007 at 07:06:07PM -0500, Jeff Garzik wrote: Would you mind rebasing resending, kind sir? By your command! :-) And once more, now with feeling! :-) --- The following changes since

Re: [PATCH 2/3] ethtool: flie option to register dump

2007-02-09 Thread Jeff Garzik
Stephen Hemminger wrote: Add ability to take old raw dumps from a file and decode them. It is kind of limited because you still need to have same device as the raw file, but useful for maintainers to decode raw dumps. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- ethtool.8 | 13

Re: [PATCH] ethtool: fix long statistics name

2007-02-09 Thread Jeff Garzik
Stephen Hemminger wrote: Fix handling of statistics where the label is exactly 32 (ETH_GSTRING_LEN) characters long (observed with chelsio 10G driver). Before it would print garbage because of going by end of string. Don't need to copy string, just use formats properly. Signed-off-by: Stephen

Re: e1000: update device ID table for register dumps

2007-02-09 Thread Jeff Garzik
Auke Kok wrote: e1000: update device ID table for register dumps with new devices From: Auke Kok [EMAIL PROTECTED] The register dump routine of e1000 was missing several newer chipsets. I reimported the mac detection code from the linux e1000 driver. This fixes newer NIC's reporting that their

Re: [PATCH ethtool] marvell chip decode formatting

2007-02-09 Thread Jeff Garzik
Stephen Hemminger wrote: Fix some typo's and formatting on Marvell ethtool output. If sync transmit queue is not used, don't print settings. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- marvell.c | 37 - 1 files changed, 24 insertions(+), 13

Re: [PATCH] phy layer: add kernel-doc + DocBook

2007-02-09 Thread Jeff Garzik
Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Convert function documentation in drivers/net/phy/ to kernel-doc and add it to DocBook. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- Documentation/DocBook/kernel-api.tmpl |6 + drivers/net/phy/mdio_bus.c| 19 ++-

Re: [PATCH] phy devices: use same arg types

2007-02-09 Thread Jeff Garzik
Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] sparse complains about differing types from prototype to definition, so change the u32 to phy_interface_t: drivers/net/phy/phy_device.c:140:19: error: symbol 'phy_connect' redeclared with different type (originally declared at

[PATCH][RESPIN] gianfar: Convert network devices to use struct device instead of class_device

2007-02-09 Thread Kumar Gala
Convert network devices to use struct device instead of class_device. Greg missed this one in his cleanup path. Signed-off-by: Kumar Gala [EMAIL PROTECTED] --- Here's a respin of the patch against a recent linus.git tree. If this doesnt apply I'm at a loss. - k commit

Re: [Bugme-new] [Bug 7974] New: BUG: scheduling while atomic: swapper/0x10000100/0

2007-02-09 Thread Andrew Morton
cond_resched() called from softirq, amongst other problems. On Fri, 9 Feb 2007 08:23:44 -0800 [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=7974 Summary: BUG: scheduling while atomic: swapper/0x1100/0 Kernel Version: 2.6.20 Status: NEW

Re: [PATCH 1/5] Add PCBC crypto template support

2007-02-09 Thread David Miller
From: David Howells [EMAIL PROTECTED] Date: Fri, 09 Feb 2007 11:18:01 + Herbert Xu [EMAIL PROTECTED] wrote: This is already in the crypto-2.6 tree that I pushed yesterday. Thanks. However, I'll continue to include the patches in my set until they reach Linus's tree. They are in

[PATCH] MAINTAINERS: no DMFE maintainer

2007-02-09 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Tobias wrote that he no longer maintains this driver and requested to be removed from MAINTAINERS. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- MAINTAINERS |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) ---

Re: [Bugme-new] [Bug 7974] New: BUG: scheduling while atomic: swapper/0x10000100/0

2007-02-09 Thread Francois Romieu
Andrew Morton [EMAIL PROTECTED] : cond_resched() called from softirq, amongst other problems. Seems too simple to be right. Btw calling dev_set_mac_address may hurt some tg3: - tg3_set_mac_addr - tg3_netif_stop (depending on the content of their sram): - netif_poll_disable

Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-09 Thread Pavel Roskin
Hello, James! On Fri, 2007-02-09 at 13:12 -0800, James Ketrenos wrote: You can find the new driver, and additional information about it, here: http://intellinuxwireless.org/iwlwifi. I cannot get it through git: $ git-clone http://intellinuxwireless.org/repos/iwlwifi.git Initialized

Re: [PATCH] MAINTAINERS: no DMFE maintainer

2007-02-09 Thread Jeff Garzik
Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Tobias wrote that he no longer maintains this driver and requested to be removed from MAINTAINERS. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- MAINTAINERS |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Levitsky

Re: [Bugme-new] [Bug 7974] New: BUG: scheduling while atomic: swapper/0x10000100/0

2007-02-09 Thread Michael Chan
On Fri, 2007-02-09 at 23:35 +0100, Francois Romieu wrote: Andrew Morton [EMAIL PROTECTED] : cond_resched() called from softirq, amongst other problems. Seems too simple to be right. Btw calling dev_set_mac_address may hurt some tg3: - tg3_set_mac_addr - tg3_netif_stop (depending

Re: [PATCH] MAINTAINERS: no DMFE maintainer

2007-02-09 Thread Randy Dunlap
On Fri, 09 Feb 2007 17:45:12 -0500 Jeff Garzik wrote: Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Tobias wrote that he no longer maintains this driver and requested to be removed from MAINTAINERS. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- MAINTAINERS |

Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-09 Thread James Ketrenos
Pavel Roskin wrote: Hello, James! On Fri, 2007-02-09 at 13:12 -0800, James Ketrenos wrote: You can find the new driver, and additional information about it, here: http://intellinuxwireless.org/iwlwifi. I cannot get it through git: $ git-clone

Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-09 Thread Pavel Roskin
On Fri, 2007-02-09 at 14:18 -0800, James Ketrenos wrote: Updated and tested 'git clone' and its working now (I use cg-clone) Thanks. It's working for me too. grep: /lib/modules/2.6.20/build//include/linux/netdevice.h: No such file or directory Apparently it should be looking into

Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-09 Thread James Ketrenos
Pavel Roskin wrote: On Fri, 2007-02-09 at 14:18 -0800, James Ketrenos wrote: grep: /lib/modules/2.6.20/build//include/linux/netdevice.h: No such file or directory ... I'll look into it. Does it work if you explicitly set KSRC to point to your kernel sources? $ make

[PATCH] bcm43xx: Fix loss of association after resume

2007-02-09 Thread Larry Finger
After a suspend/resume cycle, bcm43xx-softmac has lost its association with the AP and requires manual intervention. This situation is fixed by making one of softmac's internal routines public and calling it. Signed-off-by: Larry Finger [EMAIL PROTECTED] --- Index:

[PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Larry Finger
The specifications for the bcm43xx driver have been modified. This patch incorporates these changes in the code, which results in the BCM4311 and BCM4312 working. The name of one of the PHY parameters, previously known as version, has been changed to analog core version . Signed-off-by: Larry

Re: [PATCH] bcm43xx: Fix loss of association after resume

2007-02-09 Thread Michael Buesch
On Friday 09 February 2007 17:18, Larry Finger wrote: After a suspend/resume cycle, bcm43xx-softmac has lost its association with the AP and requires manual intervention. This situation is fixed by making one of softmac's internal routines public and calling it. Signed-off-by: Larry Finger

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Michael Buesch
On Friday 09 February 2007 17:32, Larry Finger wrote: The specifications for the bcm43xx driver have been modified. This patch incorporates these changes in the code, which results in the BCM4311 and BCM4312 working. The name of one of the PHY parameters, previously known as version, has been

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Joseph Jezak
Well, I don't review the rest until you say to which specs you did the changes. ;) http://bcm-specs.sipsolutions.net/B5PHY Larry was working from the old specs, so when I updated it, I only updated the old specs. I'll fix the v4 specs soon. -Joe - To unsubscribe from this list: send the

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Joseph Jezak
dprintk(KERN_INFO PFX Detected PHY: Version: %x, Type %x, Revision %x\n, You should change this too, the Version text should read Analog instead. -Joe - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Michael Buesch
On Friday 09 February 2007 23:22, Joseph Jezak wrote: Well, I don't review the rest until you say to which specs you did the changes. ;) http://bcm-specs.sipsolutions.net/B5PHY Larry was working from the old specs, so when I updated it, I only updated the old specs. I'll fix the v4

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Larry Finger
Michael, Michael Buesch wrote: On Friday 09 February 2007 17:32, Larry Finger wrote: The specifications for the bcm43xx driver have been modified. This patch incorporates these changes in the code, which results in the BCM4311 and BCM4312 working. The name of one of the PHY parameters,

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Larry Finger
Michael Buesch wrote: On Friday 09 February 2007 23:22, Joseph Jezak wrote: Well, I don't review the rest until you say to which specs you did the changes. ;) http://bcm-specs.sipsolutions.net/B5PHY Larry was working from the old specs, so when I updated it, I only updated the old specs.

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Michael Buesch
On Friday 09 February 2007 17:32, Larry Finger wrote: The specifications for the bcm43xx driver have been modified. This patch incorporates these changes in the code, which results in the BCM4311 and BCM4312 working. The name of one of the PHY parameters, previously known as version, has been

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Michael Buesch
On Friday 09 February 2007 19:21, Larry Finger wrote: Michael Buesch wrote: On Friday 09 February 2007 23:22, Joseph Jezak wrote: Well, I don't review the rest until you say to which specs you did the changes. ;) http://bcm-specs.sipsolutions.net/B5PHY Larry was working from the old

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Joseph Jezak
I'll agree to that as long as there is a clear indication of any differences between V3 and V4 firmware. That's also part of the problem. With the v4 driver, Broadcom dropped support for a number of older BPHY devices (4301/4303 and some 4306 revisions). Do we still want to support those?

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Joseph Jezak
The specs are unclear at this point: Write the value to the offset Offset in which register type? PHY Register. I've clarified it in the specs, I think this was said before, I made it worse when I cleaned it up. // Initialization - if (phy-version == 0) { + if

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Michael Buesch
On Friday 09 February 2007 20:05, Joseph Jezak wrote: I'll agree to that as long as there is a clear indication of any differences between V3 and V4 firmware. That's also part of the problem. With the v4 driver, Broadcom dropped support for a number of older BPHY devices (4301/4303 and

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Larry Finger
Joe, Joseph Jezak wrote: That's also part of the problem. With the v4 driver, Broadcom dropped support for a number of older BPHY devices (4301/4303 and some 4306 revisions). Do we still want to support those? Should I continue writing the specs for the uCode revision it's based on or

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Michael Buesch
On Friday 09 February 2007 20:17, Joseph Jezak wrote: The specs are unclear at this point: Write the value to the offset Offset in which register type? PHY Register. I've clarified it in the specs, I think this was said before, I made it worse when I cleaned it up. //

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Joseph Jezak
Michael Buesch wrote: On Friday 09 February 2007 20:05, Joseph Jezak wrote: I'll agree to that as long as there is a clear indication of any differences between V3 and V4 firmware. That's also part of the problem. With the v4 driver, Broadcom dropped support for a number of older BPHY

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Joseph Jezak
This is correct. Why do you think it's a specs bug? Because a) The old one made more sense to me. b) Write MMIO register 0x3? I mean. What is that? Could this be PHY or radio register 0x3? Apologies. You are correct that this should be PHY Register 0x3, not MMIO offset 0x3. I've

Re: [PATCH] NET : UDP can use sk_hash to speedup lookups

2007-02-09 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 9 Feb 2007 18:44:16 +0100 In a prior patch, I introduced a sk_hash field (__sk_common.skc_hash) to let tcp lookups use one cache line per unmatched entry instead of two. We can also use sk_hash to speedup UDP part as well. We store in sk_hash

[PATCH 0/5]: spidernet: misc fixes

2007-02-09 Thread Linas Vepstas
Jeff, A series of five patches against the spidernet ethernet device driver. The first fixes a compile break in the current kernel.rg tree. The second restructures the descriptor ring, per an old suggestion. The third fourth fix a race condition seen under heavy load. The fifth is a trite

[PATCH 2.6.21] phylib: Add support for Marvell 88e1111S and 88e1145

2007-02-09 Thread Andy Fleming
From Andy Fleming [EMAIL PROTECTED] Changes include: * New support for 88e1145 * New support for 88e111s * Fixing 88e1101 driver to not match non-88e1101 PHYs * Increases in feature support across Marvell PHY product line * Fixes a bunch of whitespace issues found by Lindent Signed-off-by:

[PATCH 1/5]: spidernet: compile break.

2007-02-09 Thread Linas Vepstas
As of 2.6.20-git4, the spider_net driver does not compile. This appears to be due to some archaic usage involving kobjects. It also fixes a nasty double-free during ifdown of interface. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Cc: James K Lewis [EMAIL PROTECTED] Cc: Jens Osterkamp

[PATCH 2/5] spidernet: separate hardware state from driver state.

2007-02-09 Thread Linas Vepstas
This patch separates the hardware descriptor state from the driver descriptor state, per (old) suggestion from Ben Herrenschmidt. This compiles and boots and seems to work. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Cc: James K Lewis [EMAIL PROTECTED] Cc: Jens Osterkamp [EMAIL PROTECTED]

[PATCH 4/5]: spidernet: transmit race

2007-02-09 Thread Linas Vepstas
Multiple threads performing a transmit can race into the spidernet tx ring cleanup code. This puts the relevant check under a lock. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Cc: James K Lewis [EMAIL PROTECTED] Cc: Jens Osterkamp [EMAIL PROTECTED] Cc: Kou Ishizaki [EMAIL PROTECTED]

Re: [PATCH 0/5]: spidernet: misc fixes

2007-02-09 Thread Linas Vepstas
Janitorial patch. Undo long lines, fix typo in err msg. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Cc: James K Lewis [EMAIL PROTECTED] Cc: Jens Osterkamp [EMAIL PROTECTED] Cc: Kou Ishizaki [EMAIL PROTECTED] drivers/net/spider_net.c | 13 +++-- 1 file changed, 7

[PATCH 5/5]: spidernet janitorial: typos

2007-02-09 Thread Linas Vepstas
Resend, The subject line was wrong on the last one. End-of-day tiredness. --linas Janitorial patch. Undo long lines, fix typo in err msg. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Cc: James K Lewis [EMAIL PROTECTED] Cc: Jens Osterkamp [EMAIL PROTECTED] Cc: Kou Ishizaki [EMAIL PROTECTED]

[PATCH] zd1211rw: Readd zd_addr_t cast

2007-02-09 Thread Daniel Drake
Robert P.J. Day's recent commit (getting rid of all casts of k[cmz]alloc() calls) introduced a sparse warning for zd1211rw, related to our type-checking of addresses. zd_chip.c:116:15: warning: implicit cast to nocast type This patch readds the type cast, it is correct. Signed-off-by:

Re: [PATCH 0/5] NET Improve layering of structs dst_entry/rtable/rt6_info/dn_route to get less dcache footprint

2007-02-09 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Thu, 08 Feb 2007 22:32:10 +0100 I prepared the following five patches : [PATCH 1/5] : Introduce union in struct dst_entry, to prepare patches 2,3,4 [PATCH 2/5] : Convert ipv4 route to use the new dst_entry 'next' pointer [PATCH 3/5] : Convert ipv6

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Michael Buesch
On Friday 09 February 2007 20:55, Joseph Jezak wrote: Michael Buesch wrote: On Friday 09 February 2007 20:05, Joseph Jezak wrote: I'll agree to that as long as there is a clear indication of any differences between V3 and V4 firmware. That's also part of the problem. With the v4 driver,

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Matthew Garrett
On Fri, Feb 09, 2007 at 01:26:25PM -0600, Larry Finger wrote: My plan is to continue to maintain bcm43xx-SoftMAC for at least the BPHY and 4306 revisions even after d80211 becomes the in-kernel driver. Of course, I hope that we will have found the killer bugs by that time, and that

Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007

2007-02-09 Thread Martin Langer
On Fri, Feb 09, 2007 at 09:32:39PM +, Matthew Garrett wrote: On Fri, Feb 09, 2007 at 01:26:25PM -0600, Larry Finger wrote: My plan is to continue to maintain bcm43xx-SoftMAC for at least the BPHY and 4306 revisions even after d80211 becomes the in-kernel driver. Of course, I hope

Re: [RFC][PATCH][IPSEC][2/3] IPv6 over IPv4 IPsec tunnel

2007-02-09 Thread Masahide NAKAMURA
Hello, Kazunori MIYAZAWA wrote: This is the patch to support IPv6 over IPv4 IPsec Signed-off-by: Miika Komu [EMAIL PROTECTED] Signed-off-by: Diego Beltrami [EMAIL PROTECTED] Signed-off-by: Kazunori Miyazawa [EMAIL PROTECTED] This seems to break Mobile IPv6 route optimization (RO). (This

Re: [RFC][PATCH][IPSEC][2/3] IPv6 over IPv4 IPsec tunnel

2007-02-09 Thread David Miller
From: Masahide NAKAMURA [EMAIL PROTECTED] Date: Sat, 10 Feb 2007 12:25:33 +0900 Please give me comments for the attached patch. I hope it will be applied (or replaced the original patch with including mine). Thank you Mashide, I've applied your patch for now. If anyone wants to provide some

Re: [PATCH] zd1211rw: Readd zd_addr_t cast

2007-02-09 Thread Michael Buesch
On Saturday 10 February 2007 02:27, Daniel Drake wrote: Robert P.J. Day's recent commit (getting rid of all casts of k[cmz]alloc() calls) introduced a sparse warning for zd1211rw, related to our type-checking of addresses. zd_chip.c:116:15: warning: implicit cast to nocast type This

[PATCH 2.6.21-rc1] ehea: Fixed error recovery

2007-02-09 Thread Jan-Bernd Themann
Error recovery for QP errors: Reset QPs and dump error information Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c |8 +++- drivers/net/ehea/ehea_phyp.c | 10 ++ drivers/net/ehea/ehea_phyp.h |3

Re: Network: convert network devices to use struct device instead of class_device

2007-02-09 Thread Kay Sievers
On Thu, 2007-02-08 at 22:59 -0500, Dmitry Torokhov wrote: On Thursday 08 February 2007 19:56, Greg KH wrote: On Thu, Feb 08, 2007 at 12:29:12PM -0500, Dmitry Torokhov wrote: On 2/8/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Thu, 08 Feb 2007 07:43:18 -0500 Network: convert

[PATCH] [ipv6]: adjust inet6_exit() cleanup sequence against inet6_init()

2007-02-09 Thread Joe Jin
Hi, This patch for adjust inet6_exit() to inverse sequence to inet6_init(). At ipv6_init, it first create proc_root/net/dev_snmp6 entry by call ipv6_misc_proc_init(), then call addrconf_init() to create the corresponding device entry at this directory, but at inet6_exit, ipv6_misc_proc_exit()

Re: forcedeth problems on 2.6.20-rc6-mm3

2007-02-09 Thread Tobias Diedrich
Tobias Diedrich wrote: Ayaz Abdulla wrote: For all those who are having issues, please try out the attached patch. Will try. Does not apply cleanly against 2.6.20, is this one fixed up right? --- linux-2.6.20/drivers/net/forcedeth.c.orig 2007-02-09 13:02:02.0 +0100 +++

Re: forcedeth problems on 2.6.20-rc6-mm3

2007-02-09 Thread Tobias Diedrich
Ayaz Abdulla wrote: For all those who are having issues, please try out the attached patch. Will try. I reverted to 2.6.19 w/o suspend/resume patch last weekend to make sure on 2.6.19 forcedeth is stable and noticed something odd: Because I didn't include the suspend/resume patch I obviously

Re: forcedeth problems on 2.6.20-rc6-mm3

2007-02-09 Thread Jeff Garzik
Tobias Diedrich wrote: Tobias Diedrich wrote: Ayaz Abdulla wrote: For all those who are having issues, please try out the attached patch. Will try. Does not apply cleanly against 2.6.20, is this one fixed up right? It probably needs to be top of 2.6.20-git-latest or 2.6.20-rc6-mm3. IOW,

Re: Network: convert network devices to use struct device instead of class_device

2007-02-09 Thread Dmitry Torokhov
On 2/9/07, Kay Sievers [EMAIL PROTECTED] wrote: On Thu, 2007-02-08 at 22:59 -0500, Dmitry Torokhov wrote: On Thursday 08 February 2007 19:56, Greg KH wrote: On Thu, Feb 08, 2007 at 12:29:12PM -0500, Dmitry Torokhov wrote: On 2/8/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Thu, 08

[PATCH] kill eth_io_copy_and_sum()

2007-02-09 Thread Al Viro
On all targets that sucker boils down to memcpy_fromio(sbk-data, from, len). The function name is highly misguiding (it _never_ does any checksums), the last argument is just a noise and simply expanding the call to memcpy_fromio() gives shorter and more readable source. For a lot of reasons it

Re: Network: convert network devices to use struct device instead of class_device

2007-02-09 Thread Greg KH
On Thu, Feb 08, 2007 at 10:59:46PM -0500, Dmitry Torokhov wrote: On Thursday 08 February 2007 19:56, Greg KH wrote: On Thu, Feb 08, 2007 at 12:29:12PM -0500, Dmitry Torokhov wrote: On 2/8/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Thu, 08 Feb 2007 07:43:18 -0500 Jeff Garzik

Re: [PATCH][RESEND] gianfar: Convert network devices to use struct device instead of class_device

2007-02-09 Thread Jeff Garzik
Kumar Gala wrote: Convert network devices to use struct device instead of class_device. Greg missed this one in his cleanup path. Signed-off-by: Kumar Gala [EMAIL PROTECTED] OK, but doesn't apply to torvalds/linux-2.6.git ... Jeff - To unsubscribe from this list: send the line

Re: [PATCH 2.6.21-rc1] ehea: Fixed error recovery

2007-02-09 Thread Jeff Garzik
Jan-Bernd Themann wrote: Error recovery for QP errors: Reset QPs and dump error information Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

[ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-09 Thread James Ketrenos
Please hold all questions until I am done with this email. Thank you. We are pleased to announce the availability of a new driver for the Intel PRO/Wireless 3945ABG Network Connection adapter. This new driver uses the new d80211 subsystem previously only available as part of the

Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-09 Thread Alon Bar-Lev
On 2/9/07, James Ketrenos [EMAIL PROTECTED] wrote: Ok. Now... any questions? No... Just that it is great news! Best Regards, Alon Bar-Lev. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-09 Thread Neil Brown
On Friday February 9, [EMAIL PROTECTED] wrote: Ok. Now... any questions? Yes. Does this require a closed user-space helper like the other 3945ABG driver, or is it completely open (maybe excepting firmware)? Thanks, NeilBrown - To unsubscribe from this list: send the line unsubscribe

Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-09 Thread James Ketrenos
Neil Brown wrote: On Friday February 9, [EMAIL PROTECTED] wrote: Ok. Now... any questions? Yes. Does this require a closed user-space helper like the other 3945ABG driver, or is it completely open (maybe excepting firmware)? The iwlwifi driver for the 3945 does not require the user space

Re: [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-09 Thread Stefan Schmidt
Hello. On Sat, 2007-02-10 at 09:26, Neil Brown wrote: On Friday February 9, [EMAIL PROTECTED] wrote: Ok. Now... any questions? Yes. Does this require a closed user-space helper like the other 3945ABG driver, or is it completely open (maybe excepting firmware)? Quote from the

  1   2   >