[Patch 0/3] ucc_geth updates for 2.6.21-rc2

2007-03-06 Thread Li Yang
Jeff, Please apply. Thanks - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[Patch 1/3] ucc_geth: Fix BD processing

2007-03-06 Thread Li Yang
Fix broken BD processing code. Signed-off-by: Michael Barkowski [EMAIL PROTECTED] Signed-off-by: Li Yang [EMAIL PROTECTED] --- drivers/net/ucc_geth.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index

[Patch 2/3] ucc_geth: returns NETDEV_TX_BUSY when BD ring is full

2007-03-06 Thread Li Yang
Returns NETDEV_TX_BUSY when BD ring is full. Signed-off-by: Li Yang [EMAIL PROTECTED] --- drivers/net/ucc_geth.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index 639e1e6..dab88b9 100644 --- a/drivers/net/ucc_geth.c

[Patch 3/3] ucc_geth: suppress compile warnings

2007-03-06 Thread Li Yang
Add casts to suppress warnings introduced by kmalloc cast cleanup patch. Signed-off-by: Li Yang [EMAIL PROTECTED] --- drivers/net/ucc_geth.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index dab88b9..c2db49b 100644

Re: [RFC PATCH]: Dynamically sized routing cache hash table.

2007-03-06 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Tue, 06 Mar 2007 08:58:45 +0100 Yes, but on bootup you have an appropriate NUMA active policy. (Well... we hope so, but it broke several time in the past) I am not sure what kind of mm policy is active for scheduled works. Good point, that

Re: [RFC PATCH]: Dynamically sized routing cache hash table.

2007-03-06 Thread Nick Piggin
On Mon, Mar 05, 2007 at 08:26:32PM -0800, David Miller wrote: This is essentially a port of Nick Piggin's dcache hash table patches to the routing cache. It solves the locking issues during table grow/shrink that I couldn't handle properly last time I tried to code up a patch like this.

Re: [RFC PATCH]: Dynamically sized routing cache hash table.

2007-03-06 Thread David Miller
From: Nick Piggin [EMAIL PROTECTED] Date: Tue, 6 Mar 2007 10:11:12 +0100 @@ -1449,6 +1472,12 @@ static struct dst_entry *ipv4_negative_a %u.%u.%u.%u/%02x dropped\n, NIPQUAD(rt-rt_dst), rt-fl.fl4_tos); #endif +

Re: [RFC PATCH]: Dynamically sized routing cache hash table.

2007-03-06 Thread Nick Piggin
On Tue, Mar 06, 2007 at 01:17:06AM -0800, David Miller wrote: From: Nick Piggin [EMAIL PROTECTED] Date: Tue, 6 Mar 2007 10:11:12 +0100 @@ -1449,6 +1472,12 @@ static struct dst_entry *ipv4_negative_a %u.%u.%u.%u/%02x dropped\n,

Re: [RFC PATCH]: Dynamically sized routing cache hash table.

2007-03-06 Thread Eric Dumazet
On Tuesday 06 March 2007 10:11, Nick Piggin wrote: Cool! I have some fixes for the rcu barrier issues, with some C-style comments and questions :) I was going to send you a fix first for the rcu barriers, then a second to convert the read-side to a barrier-less one that I described, however

Re: [RFC PATCH]: Dynamically sized routing cache hash table.

2007-03-06 Thread Nick Piggin
On Tue, Mar 06, 2007 at 10:23:44AM +0100, Eric Dumazet wrote: On Tuesday 06 March 2007 10:11, Nick Piggin wrote: Cool! I have some fixes for the rcu barrier issues, with some C-style comments and questions :) I was going to send you a fix first for the rcu barriers, then a second to

Re: TCP 2MSL on loopback

2007-03-06 Thread Howard Chu
Eric Dumazet wrote: On Monday 05 March 2007 12:20, Howard Chu wrote: Why is the Maximum Segment Lifetime a global parameter? Surely the maximum possible lifetime of a particular TCP segment depends on the actual connection. At the very least, it would be useful to be able to set it on a

[PATCH] NET : Optimizes inet_getpeer()

2007-03-06 Thread Eric Dumazet
Hi David Please find this patch against net-2.6.22 Thank you [PATCH] NET : Optimizes inet_getpeer() 1) Some sysctl vars are declared __read_mostly 2) We can avoid updating stack[] when doing an AVL lookup only. lookup() macro is extended to receive a second parameter, that may be NULL

[patch 01/19] git-netdev-all: ipw2200 fix

2007-03-06 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] drivers/net/wireless/ipw2200.c: In function 'show_channels': drivers/net/wireless/ipw2200.c:1855: warning: implicit declaration of function 'ipw_get_geo' drivers/net/wireless/ipw2200.c:1855: warning: initialization makes pointer from integer without a cast

[patch 07/19] dmfe: fix two bugs

2007-03-06 Thread akpm
From: Maxim Levitsky [EMAIL PROTECTED] Fix a oops on module removal due to deallocating memory before unregistring driver Fix a NULL pointer dereference when dev_alloc_skb fails Signed-off-by: Maxim Levitsky [EMAIL PROTECTED] Cc: Valerie Henson [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED]

Re: TCP 2MSL on loopback

2007-03-06 Thread Eric Dumazet
On Tuesday 06 March 2007 10:22, Howard Chu wrote: It's a combination of 2MSL and /proc/sys/net/ipv4/ip_local_port_range - on my system the default port range is 32768-61000. That means if I use up 28232 ports in less than 2MSL then everything stops. netstat will show that all the available

[patch 03/19] user of the jiffies rounding code: e1000

2007-03-06 Thread akpm
From: Arjan van de Ven [EMAIL PROTECTED] Use the round_jiffies() function in e1000. These timers all were of the about once a second or about once every X seconds variety and several showed up in the what wakes the cpu up profiles that the tickless patches provide. Some timers are highly

[patch 11/19] sis900 warning fixes

2007-03-06 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] drivers/net/sis900.c: In function 'sis900_reset_phy': drivers/net/sis900.c:972: warning: 'status' may be used uninitialized in this function drivers/net/sis900.c: In function 'sis900_check_mode': drivers/net/sis900.c:1431: warning: 'status' may be used

[patch 08/19] dmfe: Fix link detection

2007-03-06 Thread akpm
From: Maxim Levitsky [EMAIL PROTECTED] Add link detection Signed-off-by: Maxim Levitsky [EMAIL PROTECTED] Cc: Valerie Henson [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/tulip/dmfe.c | 58

[patch 10/19] dmfe: add support for Wake on lan

2007-03-06 Thread akpm
From: Maxim Levitsky [EMAIL PROTECTED] Add support for WOL on Magic Packet and on link change Signed-off-by: Maxim Levitsky [EMAIL PROTECTED] Cc: Valerie Henson [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/tulip/dmfe.c |

[patch 04/19] phy layer: add kernel-doc + DocBook

2007-03-06 Thread akpm
From: Randy Dunlap [EMAIL PROTECTED] Convert function documentation in drivers/net/phy/ to kernel-doc and add it to DocBook. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- Documentation/DocBook/kernel-api.tmpl |6

[patch 06/19] dmfe: trivial/spelling fixes

2007-03-06 Thread akpm
From: Maxim Levitsky [EMAIL PROTECTED] Fix a typo, wrap lines on 80-th column, change KERN_ERR to KERN_INFO for link status message Signed-off-by: Maxim Levitsky [EMAIL PROTECTED] Cc: Valerie Henson [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL

[patch 09/19] dmfe: add support for suspend/resume

2007-03-06 Thread akpm
From: Maxim Levitsky [EMAIL PROTECTED] This adds support for suspend resume [EMAIL PROTECTED]: fix CONFIG_PM=n, coding style] Signed-off-by: Maxim Levitsky [EMAIL PROTECTED] Cc: Valerie Henson [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] ---

[patch 17/19] sk98lin: handle pci_enable_device() return value in skge_resume()

2007-03-06 Thread akpm
From: Dmitriy Monakhov [EMAIL PROTECTED] Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/sk98lin/skge.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff -puN

[patch 14/19] drivers/net/vioc/vioc_driver.c: replace pci_module_init with pci_register_driver

2007-03-06 Thread akpm
From: Richard Knutsson [EMAIL PROTECTED] Replace pci_module_init with pci_register_driver Signed-off-by: Richard Knutson [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/vioc/vioc_driver.c |4 ++-- 1 file changed,

[patch 19/19] network: add the missing phy_device speed information to phy_mii_ioctl

2007-03-06 Thread akpm
From: Shan Lu [EMAIL PROTECTED] Function `phy_mii_ioctl' returns physical device's information based on user requests. When requested to return the basic mode control register information (BMCR), the original implementation only returns the physical device's duplex information and forgets to

[patch 12/19] fix irq problem with NAPI + NETPOLL

2007-03-06 Thread akpm
From: Atsushi Nemoto [EMAIL PROTECTED] It seems netif_receive_skb() was designed not to call from irq context, but NAPI + NETPOLL break this rule. If netif_receive_skb() was called from irq context, redirect to netif_rx() instead of processing the skb in that context. Signed-off-by: Atsushi

[patch 16/19] __devinit __devexit cleanups for de2104x driver

2007-03-06 Thread akpm
From: Prarit Bhargava [EMAIL PROTECTED] Fixes MODPOST warnings similar to: WARNING: drivers/net/tulip/de2104x.o - Section mismatch: reference to .init.text:de_init_one from .data.rel.local after 'de_driver' (at offset 0x20) WARNING: drivers/net/tulip/de2104x.o - Section mismatch: reference to

[patch 1/2] 8139too: force media setting cleanup

2007-03-06 Thread akpm
From: Bernard Lee [EMAIL PROTECTED] Setting bit 4 5 alone in 8139too module media option does not really force 100Mbps full-duplex mode. When media option bit 0-3 is cleared, 8139too module does not force media setting. Therefore, bit 0-3 requires to be set for bit 4 5 to take effect. The

[patch 13/19] cxgb3: add SW LRO support

2007-03-06 Thread akpm
From: Divy Le Ray [EMAIL PROTECTED] Add all-in-sw lro support. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/cxgb3/adapter.h | 21 + drivers/net/cxgb3/common.h |1 drivers/net/cxgb3/cxgb3_ioctl.h |1

[patch 15/19] 3c59x: Handle pci_enable_device() failure while resuming

2007-03-06 Thread akpm
From: Dmitriy Monakhov [EMAIL PROTECTED] Handle pci_enable_device() failure while resuming, we can safely exit here. Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/3c59x.c |8 +++- 1 file changed, 7 insertions(+), 1

[patch 05/19] revert drivers/net/tulip/dmfe: support basic carrier detection

2007-03-06 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] Revert 7628b0a8c01a02966d2228bdf741ddedb128e8f8. Thomas Bachler reports: Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe: support basic carrier detection) breaks networking on my Davicom DM9009. ethtool always reports there is

[patch 18/19] mv643xx ethernet driver IRQ registration fix

2007-03-06 Thread akpm
From: Giridhar Pemmasani [EMAIL PROTECTED] During initialization, mv643xx driver registers IRQ before setting up tx/rx rings. This causes kernel oops because mv643xx_poll, which gets called right after registering IRQ, calls netif_rx_complete, which accesses the rx ring (I don't have the oops

[patch 2/2] div64_64: common code

2007-03-06 Thread akpm
From: Stephen Hemminger [EMAIL PROTECTED] Implement div64_64(): 64-bit by 64-bit division. Needed by networking (at least). Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Cc: Russell King [EMAIL PROTECTED] Cc: Geert Uytterhoeven [EMAIL PROTECTED] Cc: Roman Zippel [EMAIL PROTECTED] Cc: Ralf

linux 2.6 Ipv4 routing enhancement (fwd)

2007-03-06 Thread Robert Olsson
Richard Kojedzinszky writes: traffic, and also update the routing table (from BGP), the route cache seemed to be the bottleneck, as upon every fib update the whole route cache is flushed, and sometimes it took as many cpu cycles to let some packets being dropped. Meanwhile i knew that

Re: [patch 12/19] fix irq problem with NAPI + NETPOLL

2007-03-06 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Atsushi Nemoto [EMAIL PROTECTED] It seems netif_receive_skb() was designed not to call from irq context, but NAPI + NETPOLL break this rule. If netif_receive_skb() was called from irq context, redirect to netif_rx() instead of processing the skb in that context.

Re: [PATCH 1/3] bonding: fix double dev_add_pack

2007-03-06 Thread Jeff Garzik
Jay Vosburgh wrote: Bonding can erroneously register the same packet_type to receive ARPs (for use by ARP validation): once at device open time, and once via sysfs. Since sysfs can change the validate setting (and thus register or unregister) at any time, a flag is needed to synchronize

Re: [PATCH] natsemi: netpoll fixes

2007-03-06 Thread Jeff Garzik
Sergei Shtylyov wrote: Fix two issues in this driver's netpoll path: one usual, with spin_unlock_irq() enabling interrupts which nobody asks it to do (that has been fixed recently in a number of drivers) and one unusual, with poll_controller() method possibly causing loss of interrupts due to

Re: [Patch 1/3] ucc_geth: Fix BD processing

2007-03-06 Thread Jeff Garzik
Li Yang wrote: Fix broken BD processing code. Signed-off-by: Michael Barkowski [EMAIL PROTECTED] Signed-off-by: Li Yang [EMAIL PROTECTED] --- drivers/net/ucc_geth.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) applied 1-2 of 3 - To unsubscribe from this list: send

Re: [patch 05/19] revert drivers/net/tulip/dmfe: support basic carrier detection

2007-03-06 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Revert 7628b0a8c01a02966d2228bdf741ddedb128e8f8. Thomas Bachler reports: Commit 7628b0a8c01a02966d2228bdf741ddedb128e8f8 (drivers/net/tulip/dmfe: support basic carrier detection) breaks networking on my Davicom DM9009.

Re: [patch 15/19] 3c59x: Handle pci_enable_device() failure while resuming

2007-03-06 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Dmitriy Monakhov [EMAIL PROTECTED] Handle pci_enable_device() failure while resuming, we can safely exit here. Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/3c59x.c |8 +++- 1 file

Re: [PATCH] pcnet32: only allocate init_block dma consistent

2007-03-06 Thread Jeff Garzik
Don Fry wrote: The patch below moves the init_block out of the private struct and only allocates init block with pci_alloc_consistent. This has two effects: 1. Performance increase for non cache coherent machines, because the CPU only data in the private struct are now cached 2. locks are

RE: [Patch 1/3] ucc_geth: Fix BD processing

2007-03-06 Thread Li Yang-r58472
-Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Tuesday, March 06, 2007 7:11 PM To: Li Yang-r58472 Cc: netdev@vger.kernel.org Subject: Re: [Patch 1/3] ucc_geth: Fix BD processing Li Yang wrote: Fix broken BD processing code. Signed-off-by: Michael

Re: [patch 12/19] fix irq problem with NAPI + NETPOLL

2007-03-06 Thread Andrew Morton
On Tue, 06 Mar 2007 06:06:11 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: From: Atsushi Nemoto [EMAIL PROTECTED] It seems netif_receive_skb() was designed not to call from irq context, but NAPI + NETPOLL break this rule. If netif_receive_skb() was called from irq

Re: [PATCH ] pcnet32: Fix PCnet32 performance bug on non-coherent architecutres

2007-03-06 Thread Jeff Garzik
Don Fry wrote: The PCnet32 driver always passed the the size of the largest possible packet to the pci_dma_sync_single_for_cpu and pci_dma_sync_single_for_device. This results in a fairly large colateral damage in the caches and makes the flush operation itself much slower. On a system with a

Re: [patch 11/19] sis900 warning fixes

2007-03-06 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: diff -puN drivers/net/sis900.c~sis900-warning-fixes drivers/net/sis900.c --- a/drivers/net/sis900.c~sis900-warning-fixes +++ a/drivers/net/sis900.c @@ -1430,7 +1430,7 @@ static void sis900_auto_negotiate(struct int i = 0; u32 status; - while (i++ 2) +

Re: [patch 18/19] mv643xx ethernet driver IRQ registration fix

2007-03-06 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Giridhar Pemmasani [EMAIL PROTECTED] During initialization, mv643xx driver registers IRQ before setting up tx/rx rings. This causes kernel oops because mv643xx_poll, which gets called right after registering IRQ, calls netif_rx_complete, which accesses the rx

Re: [PATCH] tc35815 driver update (take 2)

2007-03-06 Thread Jeff Garzik
Atsushi Nemoto wrote: Current tc35815 driver is very obsolete and less maintained for a long time. Replace it with a new driver based on one from CELF patch archive. Major advantages of CELF version (version 1.23, for kernel 2.6.10) are: * Independent of JMR3927. (Actually independent of

Re: [PATCH 1/3] NetXen: Make driver use multiple PCI functions

2007-03-06 Thread Jeff Garzik
Linsys Contractor Mithlesh Thukral wrote: NetXen: Make driver use multiple PCI functions. This patch will make NetXen driver work with multiple PCI functions. This will make the usage of memory resources as well as interrupts more independent among different functions which results in better

Re: [patch 03/19] user of the jiffies rounding code: e1000

2007-03-06 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Arjan van de Ven [EMAIL PROTECTED] Use the round_jiffies() function in e1000. These timers all were of the about once a second or about once every X seconds variety and several showed up in the what wakes the cpu up profiles that the tickless patches provide.

Re: [patch 09/19] dmfe: add support for suspend/resume

2007-03-06 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Maxim Levitsky [EMAIL PROTECTED] This adds support for suspend resume [EMAIL PROTECTED]: fix CONFIG_PM=n, coding style] Signed-off-by: Maxim Levitsky [EMAIL PROTECTED] Cc: Valerie Henson [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew

Re: [patch 17/19] sk98lin: handle pci_enable_device() return value in skge_resume()

2007-03-06 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Dmitriy Monakhov [EMAIL PROTECTED] Signed-off-by: Monakhov Dmitriy [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/sk98lin/skge.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) applied - To

Re: [patch 19/19] network: add the missing phy_device speed information to phy_mii_ioctl

2007-03-06 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Shan Lu [EMAIL PROTECTED] Function `phy_mii_ioctl' returns physical device's information based on user requests. When requested to return the basic mode control register information (BMCR), the original implementation only returns the physical device's duplex

Re: [patch 14/19] drivers/net/vioc/vioc_driver.c: replace pci_module_init with pci_register_driver

2007-03-06 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Richard Knutsson [EMAIL PROTECTED] Replace pci_module_init with pci_register_driver Signed-off-by: Richard Knutson [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/vioc/vioc_driver.c |

[RFC PATCH] [TCP]: Reworked recovery's TCPCB_LOST marking functions

2007-03-06 Thread Ilpo Järvinen
Complete rewrite for update_scoreboard and mark_head_lost. Couple of hints became unnecessary because of this change. Changes !TCPCB_TAGBITS check from the original to !(S|L) but it shouldn't make a difference, and if there ever is an R only skb TCP will mark it as LOST too. The algorithm uses

Re: [RFC PATCH] [TCP]: Reworked recovery's TCPCB_LOST marking functions

2007-03-06 Thread Ilpo Järvinen
On Tue, 6 Mar 2007, Ilpo Järvinen wrote: because I tested this one (at least the non-timedout part worked) ...meant that timedout wasn't that throughoutly tested with such a simple testcase I used (only FACK was tested). -- i.

compat_sock_common_getsockopt typo?

2007-03-06 Thread Johannes Berg
The function reads as follows: int compat_sock_common_getsockopt(struct socket *sock, int level, int optname, char __user *optval, int __user *optlen) { struct sock *sk = sock-sk; if (sk-sk_prot-compat_setsockopt != NULL)

wireless extensions vs. 64-bit architectures

2007-03-06 Thread Johannes Berg
Hi, Wtf! After struggling with some strange problems with zd1211rw (see some other mail) I decided to think again about what could possibly cause all the other problems I'm having with it. The kernel seems fine, but iw* userspace continually segfaults! And it also seems to be not reproducible for

[RFC PATCH]: Dynamically sized routing cache hash table.

2007-03-06 Thread Robert Olsson
David Miller writes: Interesting. Actually, more accurately, the conflict exists in how this GC logic is implemented. The core issue is that hash table size guides the GC processing, and hash table growth therefore modifies those GC goals. So with the patch below we'll just keep

Re: [RFC PATCH]: Dynamically sized routing cache hash table.

2007-03-06 Thread Robert Olsson
Eric Dumazet writes: Well, maybe... but after looking robert's trash, I discovered its model is essentially a big (2^18 slots) root node (our hash table), and very few order:1,2,3 nodes. It's getting hashlike yes. I guess all effective algorithms today is doing some sort of index

[NET]: Please revert disallowing zero listen queues

2007-03-06 Thread Gerrit Renker
Please can you reconsider the patch regarding the accept_queue http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.22.git;a=commit;h=8488df894d05d6fa41c2bd298c335f944bb0e401 It disallows to set a `backlog' argument to listen(2) of zero. Using a zero backlog is often done (e.g. ttcp), and

GMRP support ?

2007-03-06 Thread xerces8
(reposted from linux-net) Hi! Is there any work on IEEE 802.1D GARP/GMRP support in linux? (GMRP tells switches about multicast group membership, read : no more broadcasting of multicast traffic, but sending only to interested parties.) I have no idea of support level in switches, I guess it

Re: [RFC PATCH]: Dynamically sized routing cache hash table.

2007-03-06 Thread Eric Dumazet
On Tuesday 06 March 2007 14:42, Robert Olsson wrote: Eric Dumazet writes: Well, maybe... but after looking robert's trash, I discovered its model is essentially a big (2^18 slots) root node (our hash table), and very few order:1,2,3 nodes. It's getting hashlike yes. I guess all

Re: wireless extensions vs. 64-bit architectures

2007-03-06 Thread Johannes Berg
On Tue, 2007-03-06 at 02:27 +0100, Johannes Berg wrote: Actually, I think it may have the same bug, it seems to be operating with iw_point (or at least its size) too I'm told that the code that uses it is only internal and the size isn't part of the userspace interface which makes this wrong.

Re: linux 2.6 Ipv4 routing enhancement (fwd)

2007-03-06 Thread Richard Kojedzinszky
Dear Robert, Sorry for sending the tgz with .svn included. And i did not send instructions. To do a test with fib_trie, issue $ make clean all ROUTE_ALG=TRIE ./try a with fib_radix: $ make clean all ROUTE_ALG=RADIX ./try a with fib_lef: $ make clean all ROUTE_ALG=LEF SBBITS=4 ./try a This

Re: compat_sock_common_getsockopt typo?

2007-03-06 Thread James Morris
On Tue, 6 Mar 2007, Johannes Berg wrote: The function reads as follows: int compat_sock_common_getsockopt(struct socket *sock, int level, int optname, char __user *optval, int __user *optlen) { struct sock *sk = sock-sk; if

[PATCH] fix compat_sock_common_getsockopt typo

2007-03-06 Thread Johannes Berg
This patch fixes a typo in compat_sock_common_getsockopt. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- wireless-dev.orig/net/core/sock.c 2007-03-06 15:44:15.618565674 +0100 +++ wireless-dev/net/core/sock.c2007-03-06 15:44:25.948565674 +0100 @@ -1597,7 +1597,7 @@ int

Re: [PATCH] tc35815 driver update (take 2)

2007-03-06 Thread Atsushi Nemoto
On Tue, 06 Mar 2007 06:20:04 -0500, Jeff Garzik [EMAIL PROTECTED] wrote: applied to #upstream, let's give it a good review while it hangs out in libata-dev.git#ALL and -mm Thank you. I believe you mean netdev-2.6.git :) --- Atsushi Nemoto - To unsubscribe from this list: send the line

Re: [PATCH] fix compat_sock_common_getsockopt typo

2007-03-06 Thread James Morris
On Tue, 6 Mar 2007, Johannes Berg wrote: This patch fixes a typo in compat_sock_common_getsockopt. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- wireless-dev.orig/net/core/sock.c 2007-03-06 15:44:15.618565674 +0100 +++ wireless-dev/net/core/sock.c 2007-03-06 15:44:25.948565674

Re: [patch 18/19] mv643xx ethernet driver IRQ registration fix

2007-03-06 Thread Dale Farnsworth
On Tue, Mar 06, 2007 at 02:42:02AM -0800, [EMAIL PROTECTED] wrote: From: Giridhar Pemmasani [EMAIL PROTECTED] During initialization, mv643xx driver registers IRQ before setting up tx/rx rings. This causes kernel oops because mv643xx_poll, which gets called right after registering IRQ, calls

[PATCH 3/3] e1000: list e1000-devel mailing list in MAINTAINERS

2007-03-06 Thread Auke Kok
From: Auke Kok [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- MAINTAINERS |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1dfba85..51efc71 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1797,6 +1797,7 @@ P:Jeff

[PATCH 1/3] e1000: Use ARRAY_SIZE macro when appropriate

2007-03-06 Thread Auke Kok
From: Ahmed S. Darwish [EMAIL PROTECTED] A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_ethtool.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH 2/3] e1000: Use kcalloc()

2007-03-06 Thread Auke Kok
From: Yan Burman [EMAIL PROTECTED] Replace kmalloc+memsetout the driver. Slightly modified by Auke Kok. Signed-off-by: Yan Burman [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_ethtool.c | 26 -- drivers/net/e1000/e1000_main.c

Re: [RFC PATCH]: Dynamically sized routing cache hash table.

2007-03-06 Thread Robert Olsson
Eric Dumazet writes: Indeed. It would be nice to see how it performs with say 2^20 elements... Because with your data, I wonder if the extra complexity of the trash is worth it (since most lookups are going to only hit the hash and give the answer without intermediate nodes) I

Re: wireless extensions vs. 64-bit architectures

2007-03-06 Thread Jean Tourrilhes
On Tue, Mar 06, 2007 at 02:27:26AM +0100, Johannes Berg wrote: Hi, Wtf! After struggling with some strange problems with zd1211rw (see some other mail) I decided to think again about what could possibly cause all the other problems I'm having with it. The kernel seems fine, but iw*

Re: [RFC PATCH]: Dynamically sized routing cache hash table.

2007-03-06 Thread Eric Dumazet
On Tuesday 06 March 2007 18:05, Robert Olsson wrote: Eric Dumazet writes: Indeed. It would be nice to see how it performs with say 2^20 elements... Because with your data, I wonder if the extra complexity of the trash is worth it (since most lookups are going to only hit the hash and

Re: when having to acquire an SA, ipsec drops the packet

2007-03-06 Thread Joy Latten
On Mon, 2007-03-05 at 22:21 -0500, James Morris wrote: On Mon, 5 Mar 2007, Joy Latten wrote: 5. Around the time the set of SAs for OUT direction are to be inserted into SAD, I see another ACQUIRE happening. I have not yet figured out where this second ACQUIRE comes from

Re: [patch 18/19] mv643xx ethernet driver IRQ registration fix

2007-03-06 Thread Giridhar Pemmasani
--- Dale Farnsworth [EMAIL PROTECTED] wrote: On Tue, Mar 06, 2007 at 02:42:02AM -0800, [EMAIL PROTECTED] wrote: From: Giridhar Pemmasani [EMAIL PROTECTED] During initialization, mv643xx driver registers IRQ before setting up tx/rx rings. This causes kernel oops because mv643xx_poll,

Re: TCP 2MSL on loopback

2007-03-06 Thread David Miller
From: Howard Chu [EMAIL PROTECTED] Date: Tue, 06 Mar 2007 01:22:18 -0800 OK, I just subscribed to netdev... Unlike other mailing lists you don't have to subscribe to netdev in order to post to it and ask questions :-) - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [patch 2/2] div64_64: common code

2007-03-06 Thread David Miller
From: [EMAIL PROTECTED] Date: Tue, 06 Mar 2007 02:42:28 -0800 From: Stephen Hemminger [EMAIL PROTECTED] Implement div64_64(): 64-bit by 64-bit division. Needed by networking (at least). This patch, with the types.h fixes of your's, is already in my net-2.6.22 GIT tree if you'd like to

Re: many sockets, slow sendto

2007-03-06 Thread Baruch Even
* Zaccomer Lajos [EMAIL PROTECTED] [070306 17:39]: Hi, I'm playing around with a simulation, in which many thousands of IP addresses (on interface aliases) are used to send/receive TCP/UDP packets. I noticed that the time of send/sendto increased linearly with the number of file

Re: many sockets, slow sendto

2007-03-06 Thread Andi Kleen
Zaccomer Lajos [EMAIL PROTECTED] writes: I'm playing around with a simulation, in which many thousands of IP addresses (on interface aliases) are used to send/receive TCP/UDP Something seems to be wrong with your emailer. It adds a empty line between each real line. packets. I noticed

Re: [PATCH] pcnet32: only allocate init_block dma consistent

2007-03-06 Thread Don Fry
The change to use netdev_priv can only be done After moving the init block out of the private structure. It will break the driver if done first, which is why they were sent together. I will separate the changes and resend them. On Tue, Mar 06, 2007 at 06:13:14AM -0500, Jeff Garzik wrote: Don

Re: [NET]: Please revert disallowing zero listen queues

2007-03-06 Thread David Miller
From: Gerrit Renker [EMAIL PROTECTED] Date: Tue, 6 Mar 2007 13:32:09 + Please can you reconsider the patch regarding the accept_queue http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.22.git;a=commit;h=8488df894d05d6fa41c2bd298c335f944bb0e401 It disallows to set a `backlog'

[PATCH 1/2] pcnet32: only allocate init_block dma consistent

2007-03-06 Thread Don Fry
The patch below moves the init_block out of the private struct and only allocates init block with pci_alloc_consistent. This has two effects: 1. Performance increase for non cache coherent machines, because the CPU only data in the private struct are now cached 2. locks are working now for

Re: TCP 2MSL on loopback

2007-03-06 Thread Howard Chu
Eric Dumazet wrote: On Tuesday 06 March 2007 10:22, Howard Chu wrote: It's a combination of 2MSL and /proc/sys/net/ipv4/ip_local_port_range - on my system the default port range is 32768-61000. That means if I use up 28232 ports in less than 2MSL then everything stops. netstat will show that

Re: [NET]: Please revert disallowing zero listen queues

2007-03-06 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Tue, 06 Mar 2007 10:37:06 -0800 (PST) Everything I've ever seen clearly states that a backlog of zero means that zero connections are allowed. So we're not disallowing a backlog argument of zero to listen(). We'll accept that just fine, the only

Re: wireless extensions vs. 64-bit architectures

2007-03-06 Thread Michael Buesch
On Tuesday 06 March 2007 18:13, Jean Tourrilhes wrote: On Tue, Mar 06, 2007 at 02:27:26AM +0100, Johannes Berg wrote: Hi, Wtf! After struggling with some strange problems with zd1211rw (see some other mail) I decided to think again about what could possibly cause all the other problems

Re: linux 2.6 Ipv4 routing enhancement (fwd)

2007-03-06 Thread Robert Olsson
Richard Kojedzinszky writes: Sorry for sending the tgz with .svn included. And i did not send instructions. To do a test with fib_trie, issue $ make clean all ROUTE_ALG=TRIE ./try a with fib_radix: $ make clean all ROUTE_ALG=RADIX ./try a with fib_lef: $ make clean all

Re: TCP 2MSL on loopback

2007-03-06 Thread Rick Jones
This is probably not something that happens in real world deployments. I But it's not 60,000 concurrent connections, it's 60,000 within a 2 minute span. Sounds like a case of Doctor! Doctor! It hurts when I do this. I'm not saying this is a high priority problem, I only encountered it in a

Re: [NET]: Please revert disallowing zero listen queues

2007-03-06 Thread Rick Jones
So we're not disallowing a backlog argument of zero to listen(). We'll accept that just fine, the only thing that happens is that you'll get what you ask for, that being no connections :-) I'm not sure where HP-UX inherited the 0 = 1 bit - perhaps from BSD, nor am I sure there is official

[PATCH 2/2] pcnet32: change to use netdev_priv

2007-03-06 Thread Don Fry
use netdev_priv() instead of dev-priv Signed-off-by: Thomas Bogendoerfer [EMAIL PROTECTED] Signed-off-by: Don Fry [EMAIL PROTECTED] --- --- linux-2.6.21-rc2/drivers/net/one.pcnet32.c 2007-03-06 10:48:37.0 -0800 +++ linux-2.6.21-rc2/drivers/net/pcnet32.c 2007-03-05

Re: [RFC PATCH]: Dynamically sized routing cache hash table.

2007-03-06 Thread Robert Olsson
Eric Dumazet writes: With 2^20 entries, your actual limit of 2^19 entries in root node will probably show us quite different numbers for order-1,2,3,4... tnodes Yeep trie will get deeper and lookup more costly as insert and delete. The 2^19 was that was getting memory alloction problem

[PATCH] ixgb: Use ARRAY_SIZE macro when appropriate.

2007-03-06 Thread Auke Kok
From: Ahmed S. Darwish [EMAIL PROTECTED] Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/ixgb/ixgb_param.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgb/ixgb_param.c

Re: [NET]: Please revert disallowing zero listen queues

2007-03-06 Thread David Miller
From: Rick Jones [EMAIL PROTECTED] Date: Tue, 06 Mar 2007 10:54:00 -0800 So we're not disallowing a backlog argument of zero to listen(). We'll accept that just fine, the only thing that happens is that you'll get what you ask for, that being no connections :-) I'm not sure where

[PATCH]: Revert accept queue backlog change.

2007-03-06 Thread David Miller
Wei, I have to revert your change, it is incorrect as pointed out by other people here on netdev. BSD sockets basically define the 'backlog' parameter to listen() to mean allow backlog + 1 connections to be queued to the socket. This allows a backlog parameter of 0 to allow 1 connection, and

Re: TCP 2MSL on loopback

2007-03-06 Thread Howard Chu
Rick Jones wrote: This is probably not something that happens in real world deployments. I But it's not 60,000 concurrent connections, it's 60,000 within a 2 minute span. Sounds like a case of Doctor! Doctor! It hurts when I do this. I guess. In the cases where it matters, we use LDAP over

Re: when having to acquire an SA, ipsec drops the packet

2007-03-06 Thread James Morris
On Tue, 6 Mar 2007, Joy Latten wrote: I saw something similar to this some time ago when testing various failure modes, and discused it with Herbert. IIRC, there's a larval SA which is not torn down properly by Racoon once the full SA is established, and the larval SA keeps resending

Re: [RFC PATCH] [TCP]: Reworked recovery's TCPCB_LOST marking functions

2007-03-06 Thread Baruch Even
* Ilpo J?rvinen [EMAIL PROTECTED] [070306 14:52]: Complete rewrite for update_scoreboard and mark_head_lost. Couple of hints became unnecessary because of this change. Changes !TCPCB_TAGBITS check from the original to !(S|L) but it shouldn't make a difference, and if there ever is an R only

Re: [patch 2/2] div64_64: common code

2007-03-06 Thread Ralf Baechle
On Tue, Mar 06, 2007 at 02:42:28AM -0800, [EMAIL PROTECTED] wrote: Implement div64_64(): 64-bit by 64-bit division. Needed by networking (at least). Your patch only implements div64_64() for 32-bit MIPS. Below patch adds the trivial 64-bit bits. Ralf Signed-off-by: Ralf Baechle [EMAIL

Re: TCP 2MSL on loopback

2007-03-06 Thread Eric Dumazet
Howard Chu a écrit : Eric Dumazet wrote: On Tuesday 06 March 2007 10:22, Howard Chu wrote: It's a combination of 2MSL and /proc/sys/net/ipv4/ip_local_port_range - on my system the default port range is 32768-61000. That means if I use up 28232 ports in less than 2MSL then everything stops.

  1   2   3   >