Re: Oops in filter add

On Tue, 2007-20-03 at 07:58 +0100, Patrick McHardy wrote: jamal wrote: The main idea is to avoid one BigLock for both ingress and egress; Which was/is still useful in the compat mode where netfilter is used instead. In that case is isn't even used. Ok. It certainly used to matter

[PATCH RFC] Clean up sk_buff walkers

Hi all, I noticed recently that, in skb_checksum(), offset and start are essentially the same thing and have the same value throughout the function, despite being computed differently. Using a single variable allows some cleanups and makes the skb_checksum() function smaller, more readable, and

Re: Oops in filter add

jamal wrote: On Tue, 2007-20-03 at 07:58 +0100, Patrick McHardy wrote: Ok. It certainly used to matter in the old days. Actually it has never been used anywhere else but in ing_filter, it was introduced together with the TC actions. You would need to make qdisc_lock_tree() aware of the

Re: 2.6.20.3-rc1 / iproute2 hoplimit 2^32-1 vs 2^8-1

On Mon, 19 Mar 2007, David Miller wrote: From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 19 Mar 2007 16:27:29 +0100 Mhh actually this looks intentional: icmpv6_send and some other output functions do: int hlimit; ... if (hlimit 0) hlimit = dst_metric(dst,

Re: 2.6.20.3-rc1 / iproute2 hoplimit 2^32-1 vs 2^8-1

In article [EMAIL PROTECTED] (at Tue, 20 Mar 2007 10:27:51 +0200 (EET)), Pekka Savola [EMAIL PROTECTED] says: On Mon, 19 Mar 2007, David Miller wrote: From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 19 Mar 2007 16:27:29 +0100 Mhh actually this looks intentional: icmpv6_send and

ping6 to own link-local address

Hello. Recent 2.6.21-git kernels do not respond to ping6 queries to our own (local) link-local address. Now bisecting... --yoshfuji - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Oops in filter add

On Tue, 2007-20-03 at 08:29 +0100, Patrick McHardy wrote: jamal wrote: On Tue, 2007-20-03 at 07:58 +0100, Patrick McHardy wrote: Ok. It certainly used to matter in the old days. Actually it has never been used anywhere else but in ing_filter, it was introduced together with the TC

Re: Oops in filter add

Thanks for all your replies! One thing I did notice in examining tc_ctl_tfilter was that there is something like: qdisc_lock_tree(dev); tp-next = *back; *back = tp; qdisc_unlock_tree(dev); And then proceed to the data structure down below with: err =

Re: Oops in filter add

jamal wrote: On Tue, 2007-20-03 at 08:29 +0100, Patrick McHardy wrote: Actually it has never been used anywhere else but in ing_filter, it was introduced together with the TC actions. You are correct. I looked at old 2.4 and all i saw was: -- /* revisit later: Use a private

Re: Oops in filter add

Chris Madden wrote: Thanks for all your replies! One thing I did notice in examining tc_ctl_tfilter was that there is something like: qdisc_lock_tree(dev); tp-next = *back; *back = tp; qdisc_unlock_tree(dev); And then proceed to the data structure down

RE: [PATCH] NAT and requests to unrouted targets

On Monday, March 19, 2007 5:02 PM, Patrick McHardy wrote: Martin Schiller wrote: To be more exactly, it's the examination of ct-tuplehash[dir].tuple.dst.u.all != ct-tuplehash[!dir].tuple.src.u.all which is only be done if XFRM is configured. Since I don't need this anyway, I deactivated XFRM

Re: [PATCH] NAT and requests to unrouted targets

Martin Schiller wrote: On Monday, March 19, 2007 5:02 PM, Patrick McHardy wrote: Could you try this patch (against current -git) with CONFIG_XFRM enabled please? I've tried it and the ping is still working now with enabled CONFIG_XFRM. Thanks for the patch. Thanks for testing, I'll

Re: Oops in filter add

jamal wrote: On Mon, 2007-19-03 at 19:22 -0700, David Miller wrote: Can you just replace the above with dev-queue_lock and see if that makes your problem go away? THanks. It should; i will stare at the code later and see if i can send a better patch, maybe a

Re: [PATCH] Netpoll support for Sibyte MAC

Hello. Deepak Saxena wrote: NETPOLL support for Sibyte MAC Index: linux-2.6.18/drivers/net/sb1250-mac.c === --- linux-2.6.18.orig/drivers/net/sb1250-mac.c +++ linux-2.6.18/drivers/net/sb1250-mac.c @@ -1128,6 +1128,26 @@ static

Re: Oops in filter add

Chris Madden wrote: Ok, I replaced ingress_lock with queue_lock in ing_filter and it died in the same place. Trace below (looks to be substantively the same)... If I am reading tc_ctl_tfilter correctly, we are adding our new tcf_proto to the end of the list, and it is getting used before

Re: Oops in filter add

Patrick McHardy wrote: Chris Madden wrote: Ok, I replaced ingress_lock with queue_lock in ing_filter and it died in the same place. Trace below (looks to be substantively the same)... If I am reading tc_ctl_tfilter correctly, we are adding our new tcf_proto to the end of the list, and it is

Re: Oops in filter add

* Patrick McHardy [EMAIL PROTECTED] 2007-03-20 15:57 Actually its only cls_basic thats broken, in case of route and fw its intentional for backwards-compatibility. Absolutely right, thanks Patrick. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: Oops in filter add

Thomas Graf wrote: * Patrick McHardy [EMAIL PROTECTED] 2007-03-20 15:57 Actually its only cls_basic thats broken, in case of route and fw its intentional for backwards-compatibility. Absolutely right, thanks Patrick. There was a small bug in my patch (broken return value on memory

example of tcp dsack undo

Hi, While designing some testing examples for the undo mechanisms, I found that undo_dsack is only used when the state is Disorder. However, I assume that dsack happens when there are retransmissions, which means Recovery or Loss. I can think of an example of receiving dsack following a

Re: Oops in filter add

Patrick McHardy wrote: There was a small bug in my patch (broken return value on memory allocation failure, not relevant for testing though). I'll push the fixed patch to Dave once Chris confirms that it fixes the problem he's seeing. Looks like that may have done it. I ramped up the

Re: Oops in filter add

Chris Madden wrote: Patrick McHardy wrote: There was a small bug in my patch (broken return value on memory allocation failure, not relevant for testing though). I'll push the fixed patch to Dave once Chris confirms that it fixes the problem he's seeing. Looks like that may have done it.

[NET_SCHED]: cls_basic: fix NULL pointer dereference

These two patches fix the cls_basic crash reported by Chris Madden and the ingress locking problem. Please apply, thanks. [NET_SCHED]: cls_basic: fix NULL pointer dereference cls_basic doesn't allocate tp-root before it is linked into the active classifier list, resulting in a NULL pointer

[NET_SCHED]: Fix ingress locking

[NET_SCHED]: Fix ingress locking Ingress queueing uses a seperate lock for serializing enqueue operations, but fails to properly protect itself against concurrent changes to the qdisc tree. Use queue_lock for now since the real fix it quite intrusive. Signed-off-by: Patrick McHardy [EMAIL

Re: [PATCH] Netpoll support for Sibyte MAC

Hello. Atsushi Nemoto wrote: NETPOLL support for Sibyte MAC Signed-off-by: Manish Lachwani [EMAIL PROTECTED] Signed-off-by: Deepak Saxena [EMAIL PROTECTED] If you added NETPOLL support, do not forget to ensure hard_start_xmit routine callable from interrupt context (or irq disabled). See

[PATCH] PPC440EPx/440GRx EMAC support.

Add PPC440EPx/440GRx EMAC along with Marvell 88E and ET1011C PHY support. The M88E chip can be found on Sequoia board. Signed-off-by: Valentine Barshak [EMAIL PROTECTED] diff -ruN linux.orig/drivers/net/ibm_emac/ibm_emac_core.c linux/drivers/net/ibm_emac/ibm_emac_core.c ---

[PATCH -rt] Fix initialization of spinlock in irttp_dup()

This was found around the 2.6.10 timeframe when testing with the -rt patch and I believe is still is an issue. irttp_dup() does a memcpy() of the tsap_cb structure causing the spinlock protecting various fields in the structure to be duped. This works OK in the non-RT case but in the RT case we

[PATCH 2/3] bridge: don't route packets while learning

While in the STP learning state, don't route packets; wait until forwarding delay has expired. The purpose of the forwarding delay is to detect loops in the network, and if a brouter started up and started forwarding, it could cause a flood. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] ---

[PATCH 1/3] bridge: eliminate call by reference

Change the bridging hook to be simple function with return value rather than modifying the skb argument. This could generate better code and is cleaner. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- include/linux/if_bridge.h |3 ++- net/bridge/br_input.c | 20

[PATCH 3/3] bridge: simpler hash with salt

Instead of hashing the whole Ethernet address, it should be faster to just use the last 4 bytes. Add a random salt value to the hash to make it more difficult to construct worst case DoS hash chains. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/bridge/br_fdb.c | 17

[NET] SAA9730: Fix large pile of warnings

The SAA9730 driver doesn't quite grok what the difference between an ioport and memory mapped I/O is. It just happened to work on the one Linux system the SAA9730 happens to spend it's misserable existence on. drivers/net/saa9730.c: In function 'evm_saa9730_enable_lan_int':

Re: [PATCH] Netpoll support for Sibyte MAC

On Mon, Mar 19, 2007 at 03:43:11PM -0700, Deepak Saxena wrote: +#ifdef CONFIG_SBMAC_COALESCE Not your patch's fault but ... CONFIG_SBMAC_COALESCE is being defined in sb1250-mac.c but the CONFIG_* namespace is reserved for kconfig. Ralf - To unsubscribe from this list: send the line

Re: many sockets, slow sendto

Hi, David Miller wrote: From: Zacco [EMAIL PROTECTED] Date: Tue, 20 Mar 2007 00:10:19 +0100 As you recommended, I used oprofile and it turned out that the __udp4_lib_lookup function spent most of the time. There is a udp hash table and the sockets are sought based on the 7 LSBs of the

[PKT_SCHED] atm: Fix missing net/netlink.h include after nlmsg_trim() cleanup

sch_atm.c:(.text+0x380ed): undefined reference to `nlmsg_trim' Signed-off-by: Thomas Graf [EMAIL PROTECTED] diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c index 53060e6..daa1644 100644 --- a/net/sched/sch_atm.c +++ b/net/sched/sch_atm.c @@ -12,8 +12,8 @@ #include linux/atmdev.h

Re: ping6 to own link-local address

On Tue, 2007-03-20 at 10:19 +0100, YOSHIFUJI Hideaki / 吉藤英明 wrote: Hello. Recent 2.6.21-git kernels do not respond to ping6 queries to our own (local) link-local address. Now bisecting... The following patch seems to be the cause for this regression. [IPV6] ROUTE: Do not route packets to

Re: [PKT_SCHED] atm: Fix missing net/netlink.h include after nlmsg_trim() cleanup

On 3/20/07, Thomas Graf [EMAIL PROTECTED] wrote: sch_atm.c:(.text+0x380ed): undefined reference to `nlmsg_trim' Signed-off-by: Thomas Graf [EMAIL PROTECTED] diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c index 53060e6..daa1644 100644 --- a/net/sched/sch_atm.c +++ b/net/sched/sch_atm.c

Re: many sockets, slow sendto

Zacco a écrit : Hi, David Miller wrote: From: Zacco [EMAIL PROTECTED] Date: Tue, 20 Mar 2007 00:10:19 +0100 As you recommended, I used oprofile and it turned out that the __udp4_lib_lookup function spent most of the time. There is a udp hash table and the sockets are sought based on the 7

[0/31] DCCP and skb offset stuff

Hi David, Sorry to disturb you in your spam mining journey, Zelda is nice at times, but real life is better another times, spam aside, take some ham: please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22 As soon as the new AC-adapter comes

[PATCH 02/31] [SK_BUFF]: Remove skb_add_mtu() leftovers

Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- include/linux/skbuff.h |1 - net/core/skbuff.c | 14 -- 2 files changed, 0 insertions(+), 15 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 4803e4d..155f0e6 100644 ---

[PATCH 02/31] [SK_BUFF]: Remove skb_add_mtu() leftovers

Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- include/linux/skbuff.h |1 - net/core/skbuff.c | 14 -- 2 files changed, 0 insertions(+), 15 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 4803e4d..155f0e6 100644 ---

[PATCH 03/31] [NETLINK]: Remove NLMSG_{NEW_ANSWER,CANCEL,END}

Not used anywhere and defined inside __KERNEL__, Thomas acked this on irc. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- include/linux/netlink.h | 12 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/include/linux/netlink.h b/include/linux/netlink.h

[PATCH 04/31] [NETLINK]: Use nlmsg_trim() where appropriate

Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- include/net/netlink.h|2 +- net/core/wireless.c |2 +- net/decnet/dn_route.c|3 ++- net/decnet/dn_table.c|3 ++- net/ipv4/inet_diag.c |

[PATCH 05/31] [SK_BUFF] ipv6: Use skb_network_offset in some more places

So that we reduce the number of direct accesses to skb-data. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/ipv6/netfilter/ip6_tables.c |2 +- net/ipv6/netfilter/nf_conntrack_reasm.c |5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH 06/31] [NETLINK]: Add missing include net/netlink.h to sch_atm.c

Leftover from the nlmsg_trim cset. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/sched/sch_atm.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c index 53060e6..0cc3c9b 100644 --- a/net/sched/sch_atm.c +++

[PATCH 07/31] [ATM] idt77252: Fix double kfree_skb on failure in push_rx_skb

Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- drivers/atm/idt77252.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c index 20f2a3a..057efbc 100644 --- a/drivers/atm/idt77252.c +++ b/drivers/atm/idt77252.c @@

[PATCH 08/31] [LMC]: lmc_main wants to use skb_tailroom

At that point it is equivalent to what was being used, skb-end - skb-data, and the need is clearly the one skb_tailroom satisfies. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- drivers/net/wan/lmc/lmc_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 1/1] [SK_BUFF]: Adjust the zeroing up to tail in __alloc_skb too

I did it just in alloc_skb_from_cache, forgot __alloc_skb, fixed now. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/core/skbuff.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index c274ea3..d7d2dc3 100644

[PATCH 09/31] [FORCEDETH]: Use skb_tailroom where appropriate

Reducing the number of skb-data direct accesses. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- drivers/net/forcedeth.c | 18 +++--- 1 files changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c index

[PATCH 10/31] [DCCP]: 48-bit sequence number arithmetic

This patch * organizes the sequence arithmetic functions into one corner of dccp.h * performs a small modification of dccp_set_seqno to make it more widely reusable (now it is safe to use any number, since it performs modulo-2^48 assignment) * adds functions and generic macros for 48-bit

[PATCH 10/31] [DCCP]: 48-bit sequence number arithmetic

This patch * organizes the sequence arithmetic functions into one corner of dccp.h * performs a small modification of dccp_set_seqno to make it more widely reusable (now it is safe to use any number, since it performs modulo-2^48 assignment) * adds functions and generic macros for 48-bit

[PATCH 12/31] [DCCP]: Make `before' relation unambiguous

Problem: before48(a, b) returns the same as before48(b, a) for all a, b which are 2^47 apart (modulo-2^48). The reason is that the difference a-b is used and `true' is returned whenever 2^47 = a-b = 2^48-1. This has the disadvantage that a positive difference a-b = 2^47 can not be

[PATCH 13/31] [DCCP]: Fix for follows48

The follows48 relation identifies whether 48-bit sequence number x is the direct successor of y. Currently, it does not handle cases of the following type correctly: follows48(0x(prefix)1LL, 0x(prefix)0LL) where prefix is an arbitrary hex sequence of up to 7 digits. This is

[PATCH 15/31] [CCID3]: Remove redundant `len' test

Since CCID3 avoids sending 0-byte data packets (cf. ccid3_hc_tx_send_packet), testing for zero-payload length, as performed by ccid3_hc_tx_update_s, is redundant - hence removed by this patch. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by:

[PATCH 16/31] [CCID3]: Re-order CCID 3 source file

No code change at all. This splits ccid3.c into a RX and a TX section, so that the file has an organisation similar to the other ones (e.g. packet_history.{h,c}). Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL

[PATCH 17/31] [CCID3]: Use MSS for larger initial windows

This improves the slow-start phase by using the MSS (as suggested in RFC 4342, sec. 5) instead of the packet size s. Also figured out that __u32 is ample resource enough. After applying, I got the following in the logs: ccid3_hc_tx_packet_recv: client(f7421700), s=6, MSS=1424, w_init=4380,

[PATCH 18/31] [CCID3]: Fix use of invalid loss intervals

This fixes a bug which uses an invalid comparison. The bug resulted in the use of invalid loss intervals. Signed-off-by: Ian McDonald [EMAIL PROTECTED] Acked-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/lib/loss_interval.c |

[PATCH 19/31] [CCID3]: More verbose debugging

This adds a few debugging statements to ccid3.c Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid3.c | 13 - 1 files changed, 12 insertions(+), 1

[PATCH 20/31] [CCID3]: Remove race condition and update t_ipi when `s' changes

This: 1. removes a race condition in the access to the scheduled send time t_nom which results from allowing asynchronous r/w access to t_nom without locks; 2. updates the inter-packet interval t_ipi = s/X when `s' changes, following a suggestion by Ian McDonald. Signed-off-by:

[PATCH 21/31] [DCCP]: Always use debug-toggle parameters

Currently debugging output (when configured) is automatically enabled when DCCP modules are compiled into the kernel rather than built as loadable modules. This is not necessary, since the module parameters in this case become kernel commandline parameters, e.g. DCCP or CCID3 debug output can be

[PATCH 22/31] [DCCP]: More debug information for dccp_wait_for_ccid

This adds more detail in the wait_for_ccid packet scheduling loop. In particular, it informs about (i) when delay is used and (ii) why a packet is discarded. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL

[PATCH 23/31] [CCID3]: Add documentation for socket options

This updates the documentation on CCID3-specific options. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Acked-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- Documentation/networking/dccp.txt | 10 ++ 1 files changed, 10 insertions(+),

[PATCH 24/31] [CCID3]: More to see in dccp_probe

This adds a few more fields of interest to /proc/net/dccpprobe, the following output ensues: 1 2 3 4 5 6 7 8910 11 sec.usec src:sport dst:dport size s rtt p X_calc X_recv X t_ipi Also made the formatting consistent.

[PATCH 25/31] [CCID3]: Remove build warnings for 64bit

This clears the following sparc64 build warnings: 1) warning: format %ld expects type long int, but argument 3 has type suseconds_t 2) warning: format %llu expects type long long unsigned int, but argument 3 has type __u64 Fixed by using typecast to unsigned. This is argued to be safe, since

[PATCH 26/31] [CCID3]: Wrap computation of RFC3390-initial rate into separate function

The CCID 3 and TFRC specs (RFC 4342, RFC 3448, draft-3448bis) make frequent reference to the computation of the RFC-3390 initial sending rate: 1. Initial sending rate when RTT is known (RFC 4342, p. 6) 2. Response to Idle/Application-Limited periods (RFC 4342, 5.1) This warrants putting the

[PATCH 27/31] [CCID3]: Handle Idle and Application-Limited periods

This updates the code with regard to handling idle and application-limited periods as specified in [RFC 4342, 5.1]. Background: -- The current code does not conform with this, it implements TFRC as per RFC 3448, 4.4: If the sender has been idle since this nofeedback timer has been

[PATCH 28/31] [DCCP]: Provide function for RTT sampling

A recurring problem, in particular in the CCID code, is that RTT samples from packets with timestamp echo and elapsed time options need to be taken. This service is provided via a new function dccp_sample_rtt in this patch. Furthermore, to protect against `insane' RTT samples, the sampled value

[PATCH 29/31] [CCID3]: Use function for RTT sampling

This replaces the existing occurrences of RTT sampling with the use of the new function dccp_sample_rtt. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid3.c | 42

[PATCH 30/31] [DCCP]: Sample RTT from SYN exchange

Function: - This patch acquires the RTT of the initial SYN (Request/Response) exchange and stores it in an unused field of dccp_sock. Purpose: The purpose is primarily to provide an initial RTT sample for CCIDs. CCID 3 in particular benefits from such a sample; using the RTT

[PATCH 31/31] [CCID3]: Use initial RTT sample from SYN exchange

The patch follows the following recommendation made in an erratum to RFC 4342: Senders MAY additionally make use of other available RTT measurements, including those from the initial Request-Response packet exchange. It implements larger initial windows with regard to this inital RTT

[PATCH 01/31] [NETLINK]: Introduce nlmsg_hdr() helper

For the common (struct nlmsghdr *)skb-data sequence, so that we reduce the number of direct accesses to skb-data and for consistency with all the other cast skb member helpers. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- drivers/connector/connector.c |2 +-

[PATCH 01/31] [NETLINK]: Introduce nlmsg_hdr() helper

For the common (struct nlmsghdr *)skb-data sequence, so that we reduce the number of direct accesses to skb-data and for consistency with all the other cast skb member helpers. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- drivers/connector/connector.c |2 +-

Re: ping6 to own link-local address

In article [EMAIL PROTECTED] (at Tue, 20 Mar 2007 15:16:40 -0700), Sridhar Samudrala [EMAIL PROTECTED] says: On Tue, 2007-03-20 at 10:19 +0100, YOSHIFUJI Hideaki / 吉藤英明 wrote: Hello. Recent 2.6.21-git kernels do not respond to ping6 queries to our own (local) link-local address. Now

Possible solution to those doubly created SAs in ipsec

A while back I reported that I sometimes saw double and triple SAs being created. The patch to check for protocol when deleting larval SA removed one obstacle in that I no longer see triple SAs. Now, once in a while double SAs. I think I have figured out the second obstacle. The initiator

[NET] rules: Unified rules dumping

Implements a unified, protocol independant rules dumping function which is capable of both, dumping a specific protocol family or all of them. This speeds up dumping as less lookups are required. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/net/core/fib_rules.c

[PATCH 0/5] [PATCHSET] Netlink Patches

Converts westwood and vegas netlink code to use the typesafe interface, removes an unused varaible, and move some netlink queue management code into the generic layer. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

[PATCH 1/5] [TCP] vegas: Use type safe netlink interface

Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/net/ipv4/tcp_vegas.c === --- net-2.6.22.orig/net/ipv4/tcp_vegas.c2007-03-20 23:53:19.0 +0100 +++ net-2.6.22/net/ipv4/tcp_vegas.c 2007-03-21

[PATCH 2/5] [TCP] westwood: Use type safe netlink interface

Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/net/ipv4/tcp_westwood.c === --- net-2.6.22.orig/net/ipv4/tcp_westwood.c 2007-03-20 23:53:19.0 +0100 +++ net-2.6.22/net/ipv4/tcp_westwood.c 2007-03-21

[PATCH 3/5] [NETLINK]: Remove unused groups variable

Leftover from dynamic multicast groups allocation work. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6/net/netlink/af_netlink.c === --- net-2.6.orig/net/netlink/af_netlink.c 2007-01-23 14:09:34.0 +0100

[PATCH 4/5] [NETLINK]: Ignore !NLM_F_REQUEST messages directly in netlink_run_queue()

netlink_rcv_skb() is changed to skip messages which don't have the NLM_F_REQUEST bit to avoid every netlink family having to perform this check on their own. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/net/netlink/af_netlink.c

[PATCH 5/5] [NETLINK]: Ignore control messages directly in netlink_run_queue()

Changes netlink_rcv_skb() to skip netlink controll messages and don't pass them on to the message handler. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/net/netlink/af_netlink.c === ---

[PATCH 12/12] [RTNL]: Use rtnl registration interface for dump-all aliases

Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/net/core/rtnetlink.c === --- net-2.6.22.orig/net/core/rtnetlink.c2007-03-21 00:52:30.0 +0100 +++ net-2.6.22/net/core/rtnetlink.c 2007-03-21

[PATCH 05/12] [IPv4]: Use rtnl registration interface

Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/include/net/ip_fib.h === --- net-2.6.22.orig/include/net/ip_fib.h2007-03-20 23:53:20.0 +0100 +++ net-2.6.22/include/net/ip_fib.h 2007-03-21

[PATCH 06/12] [PKT_SCHED] qdisc: Use rtnl registration interface

Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/include/net/sch_generic.h === --- net-2.6.22.orig/include/net/sch_generic.h 2007-03-20 23:53:20.0 +0100 +++ net-2.6.22/include/net/sch_generic.h

[PATCH 00/12] [PATCHSET] RTNetlink message handler registration interface

Introduces an interface to register rtnetlink message handlers and converts all users of rtnl_links[]. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 07/12] [PKT_SCHED] cls: Use rtnl registration interface

Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/net/sched/cls_api.c === --- net-2.6.22.orig/net/sched/cls_api.c 2007-03-20 23:53:20.0 +0100 +++ net-2.6.22/net/sched/cls_api.c 2007-03-21 00:52:36.0

[PATCH 08/12] [PKT_SCHED] act: Use rtnl registration interface

Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/net/sched/act_api.c === --- net-2.6.22.orig/net/sched/act_api.c 2007-03-20 23:53:20.0 +0100 +++ net-2.6.22/net/sched/act_api.c 2007-03-21 00:52:37.0

[PATCH 09/12] [DECNet]: Use rtnl registration interface

Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/include/net/dn_fib.h === --- net-2.6.22.orig/include/net/dn_fib.h2007-03-20 23:53:20.0 +0100 +++ net-2.6.22/include/net/dn_fib.h 2007-03-21

[PATCH 02/12] [NET] link: Use rtnl registration interface

Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/net/core/rtnetlink.c === --- net-2.6.22.orig/net/core/rtnetlink.c2007-03-21 00:52:26.0 +0100 +++ net-2.6.22/net/core/rtnetlink.c 2007-03-21

[PATCH 01/12] [RTNL]: Message handler registration interface

This patch adds a new interface to register rtnetlink message handlers replacing the exported rtnl_links[] array which required many message handlers to be exported unnecessarly. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/include/net/rtnetlink.h

[PATCH 11/12] [BRIDGE]: Use rtnl registration interface

Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/net/bridge/br.c === --- net-2.6.22.orig/net/bridge/br.c 2007-03-20 23:53:20.0 +0100 +++ net-2.6.22/net/bridge/br.c 2007-03-21 00:52:42.0 +0100 @@

[PATCH 03/12] [NEIGH]: Use rtnl registration interface

Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/include/net/neighbour.h === --- net-2.6.22.orig/include/net/neighbour.h 2007-03-20 23:53:20.0 +0100 +++ net-2.6.22/include/net/neighbour.h 2007-03-21

Re: [PATCH 10/12] [IPv6]: Use rtnl registration interface

In article [EMAIL PROTECTED] (at Wed, 21 Mar 2007 01:06:03 +0100), Thomas Graf [EMAIL PROTECTED] says: -static int -inet6_rtm_deladdr(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg) +static int nl_addr_del(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg) { struct ifaddrmsg

[NET]: Fix fib_rules compatibility breakage

* Patrick McHardy [EMAIL PROTECTED] 2007-03-20 17:59 The presence of the attributes when src_len/dst_len is non-zero is only verified in fib_newrule, so this looks like it might crash when something broken sets src_len/dst_len to a non-zero value without actually adding the attributes. You're

Re: [NET]: Fix fib_rules compatibility breakage

Thomas Graf wrote: * Patrick McHardy [EMAIL PROTECTED] 2007-03-20 17:59 The presence of the attributes when src_len/dst_len is non-zero is only verified in fib_newrule, so this looks like it might crash when something broken sets src_len/dst_len to a non-zero value without actually adding the

Re: [PATCH 5/5] [NETLINK]: Ignore control messages directly in netlink_run_queue()

Thomas Graf wrote: Changes netlink_rcv_skb() to skip netlink controll messages and don't pass them on to the message handler. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.22/net/netlink/af_netlink.c === ---

[RFC][PATCH -mm take3 0/6][resend] proposal for dynamic configurable netconsole

From: Keiichi KII [EMAIL PROTECTED] The netconsole is a very useful module for collecting kernel message under certain circumstances(e.g. disk logging fails, serial port is unavailable). But current netconsole is not flexible. For example, if you want to change ip address for logging agent, in

[RFC][PATCH -mm take3 2/6][resend] support multiple logging

From: Keiichi KII [EMAIL PROTECTED] This patch contains the following changes for supporting multiple logging agents. 1. extend netconsole to multiple netpolls To send kernel messages to multiple logging agents, extend netcosnole to be able to use multiple netpolls. Each netpoll sends

[RFC][PATCH -mm take3 4/6][resend] using symlink for the net_device

From: Keiichi KII [EMAIL PROTECTED] We use symbolic link for net_device. The link in sysfs represents the corresponding network etherdevice. -+- /sys/class/misc/ |-+- netconsole/ |-+- port1/ | |--- id [r--r--r--] id | |--- net:net_dev [rw-r--r--] net_dev: eth0,eth1,... | ...

[RFC][PATCH -mm take3 6/6][resend] add ioctls for adding/removing target

From: Keiichi KII [EMAIL PROTECTED] We add ioctls for adding/removing target. If we use NETCONSOLE_ADD_TARGET ioctl, we can dynamically add netconsole target. If we use NETCONSOLE_REMOVE_TARGET ioctl, we can dynamically remoe netconsole target. We attach a sample program for ioctl.

Re: [RFC][PATCH -mm take3 2/6][resend] support multiple logging

On 3/20/07, Keiichi KII [EMAIL PROTECTED] wrote: This patch contains the following changes for supporting multiple logging agents. +#define CONFIG_SEPARATOR ; CONFIG_* is reserved for configuration options. Since you use it in only one place just use semicolon directly. - To unsubscribe

Re: [RFC][PATCH -mm take3 6/6][resend] add ioctls for adding/removing target

On 3/20/07, Keiichi KII [EMAIL PROTECTED] wrote: We add ioctls for adding/removing target. If we use NETCONSOLE_ADD_TARGET ioctl, we can dynamically add netconsole target. If we use NETCONSOLE_REMOVE_TARGET ioctl, we can dynamically remoe netconsole target. We attach a sample program for ioctl.

  1   2   >