Re: strange sky disable/enable in the kernel log

2007-06-25 Thread Stephen Hemminger
On Fri, 22 Jun 2007 07:53:42 +0200 Tino Keitel [EMAIL PROTECTED] wrote: Hi, I just found this in the kernel log: 2007-06-22_05:47:50.69894 kern.info: sky2 eth0: disabling interface 2007-06-22_05:47:50.72039 kern.info: sky2 eth0: enabling interface 2007-06-22_05:47:50.72240 kern.info:

Re: [PATCH] Age Entry For IPv4 Route Table

2007-06-25 Thread Varun Chandramohan
David Miller wrote: From: Varun Chandramohan [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 10:51:39 +0530 YOSHIFUJI Hideaki / wrote: In article [EMAIL PROTECTED] (at Mon, 25 Jun 2007 10:28:38 +0530), Varun Chandramohan [EMAIL PROTECTED] says: According to the

Re: strange sky disable/enable in the kernel log

2007-06-25 Thread Tino Keitel
On Sun, Jun 24, 2007 at 23:11:20 -0700, Stephen Hemminger wrote: On Fri, 22 Jun 2007 07:53:42 +0200 Tino Keitel [EMAIL PROTECTED] wrote: Hi, I just found this in the kernel log: 2007-06-22_05:47:50.69894 kern.info: sky2 eth0: disabling interface 2007-06-22_05:47:50.72039

Re: [RFC SKBUFF]: Keep track of writable header len of headerless clones

2007-06-25 Thread Patrick McHardy
David Miller wrote: Patrick please give me a suitable signed-off-by line, I'd like to apply this to net-2.6.23 Signed-off-by: Patrick McHardy [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH] Age Entry For IPv4 Route Table

2007-06-25 Thread David Miller
From: Varun Chandramohan [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 13:28:37 +0530 Ok i understand. But can you suggest anyother way to do the above? Just because I found a fault in your patch doesn't mean that it becomes my job isn't to implement the feature for you. - To unsubscribe from this

Re: [Bugme-new] [Bug 8668] New: HTB Deadlock

2007-06-25 Thread Patrick McHardy
Andrew Morton wrote: On Sun, 24 Jun 2007 21:57:19 -0700 (PDT) [EMAIL PROTECTED] wrote: I've been experiencing problems with HTB where the whole machine locks up. This usually happens when the whole qdisc is being removed and occasionally when a leaf is being removed. It shouldn't happen when

Re: Scaling Max IP address limitation

2007-06-25 Thread Robert Iakobashvili
David, On 6/25/07, David Jones [EMAIL PROTECTED] wrote: I am trying to add multiple IP addresses ( v6 ) to my FC7 box on eth0. But I am hitting a max limit of 4000 IP address . Seems like there is a limiting variable in linux kernel (which one? ) that prevents from adding more IP

Re: [Bugme-new] [Bug 8668] New: HTB Deadlock

2007-06-25 Thread Patrick McHardy
Patrick McHardy wrote: It is. This patch I had originally planned for 2.6.23 switches HTB to the generic estimator, which shouldn't suffer from this. Ranko, can you try if it fixes your timer problem? Forgot the patch .. [NET_SCHED]: sch_htb: use generic estimator Use the generic estimator

Re: Scaling Max IP address limitation

2007-06-25 Thread Jan Engelhardt
On Jun 25 2007 11:47, Robert Iakobashvili wrote: I am getting after initial successes some errors: rtnl_talk(): RTNETLINK answers: Cannot allocate memory and #ip addr | wc-l is 8194. I'd be surprised if it was 4096 on x86 and 8192 on x86_64... Jan -- - To unsubscribe from this

Re: [2/2] 2.6.22-rc6: known regressions with patches

2007-06-25 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.22-rc6 with patches available. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions *STATISTICS* (a.k.a. list of aces) NameRegressions fixed since 21-Jun-2007 Andi Kleen

Re: Scaling Max IP address limitation

2007-06-25 Thread Patrick McHardy
Jan Engelhardt wrote: On Jun 24 2007 15:08, Kyle Moffett wrote: Do you really need that many IP addresses? When somebody finally gets around to implementing REDIRECT support for ip6tables then you could just redirect them all to the same port on the local system. The way I see it, it's:

Re: Scaling Max IP address limitation

2007-06-25 Thread Robert Iakobashvili
Hi On 6/25/07, Jan Engelhardt [EMAIL PROTECTED] wrote: On Jun 25 2007 11:47, Robert Iakobashvili wrote: I am getting after initial successes some errors: rtnl_talk(): RTNETLINK answers: Cannot allocate memory and #ip addr | wc-l is 8194. I'd be surprised if it was 4096 on x86 and 8192 on

Re: [CAN] [RFC] skb-iif usage and vcan driver background

2007-06-25 Thread Patrick McHardy
Oliver Hartkopp wrote: Hello Patrick and Jamal, as i felt a bit misunderstood in the discussion about the usage of skb-iif and the idea behind the virtual CAN driver i created four PDF-slides to clarify some issues. The slides may give you the appropriate background why the incoming

Re: [RFC SKBUFF]: Keep track of writable header len of headerless clones

2007-06-25 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 10:51:59 +0200 David Miller wrote: Patrick please give me a suitable signed-off-by line, I'd like to apply this to net-2.6.23 Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Applied and pushed out, thanks Patrick! - To

Re: [Bugme-new] [Bug 8668] New: HTB Deadlock

2007-06-25 Thread Ranko Zivojnovic
On Mon, 2007-06-25 at 11:30 +0200, Patrick McHardy wrote: Patrick McHardy wrote: It is. This patch I had originally planned for 2.6.23 switches HTB to the generic estimator, which shouldn't suffer from this. Ranko, can you try if it fixes your timer problem? Forgot the patch ..

Re: Scaling Max IP address limitation

2007-06-25 Thread Robert Iakobashvili
On 6/25/07, Jan Engelhardt [EMAIL PROTECTED] wrote: On Jun 25 2007 12:41, Robert Iakobashvili wrote: I am getting after initial successes some errors: rtnl_talk(): RTNETLINK answers: Cannot allocate memory and #ip addr | wc-l is 8194. I'd be surprised if it was 4096 on x86 and 8192 on

Re: Scaling Max IP address limitation

2007-06-25 Thread Jan Engelhardt
On Jun 25 2007 12:41, Robert Iakobashvili wrote: I am getting after initial successes some errors: rtnl_talk(): RTNETLINK answers: Cannot allocate memory and #ip addr | wc-l is 8194. I'd be surprised if it was 4096 on x86 and 8192 on x86_64... Missed to mention: the CPU is Pentium-4.

Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-06-25 Thread Patrick McHardy
OBATA Noboru wrote: From: OBATA Noboru [EMAIL PROTECTED] Make TCP_RTO_MAX a variable, and allow a user to change it via a new sysctl entry /proc/sys/net/ipv4/tcp_rto_max. A user can then guarantee TCP retransmission to be more controllable, say, at least once per 10 seconds, by setting it

[PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-06-25 Thread OBATA Noboru
From: OBATA Noboru [EMAIL PROTECTED] Make TCP_RTO_MAX a variable, and allow a user to change it via a new sysctl entry /proc/sys/net/ipv4/tcp_rto_max. A user can then guarantee TCP retransmission to be more controllable, say, at least once per 10 seconds, by setting it to 10. This is quite

Re: [PATCH] Age Entry For IPv4 Route Table

2007-06-25 Thread Eric Dumazet
On Mon, 25 Jun 2007 10:28:38 +0530 Varun Chandramohan [EMAIL PROTECTED] wrote: According to the RFC 4292 (IP Forwarding Table MIB) there is a need for an age entry for all the routes in the routing table. The entry in the RFC is inetCidrRouteAge and oid is inetCidrRouteAge.1.10. Many snmp

Re: [CAN] [RFC] skb-iif usage and vcan driver background

2007-06-25 Thread Oliver Hartkopp
Patrick McHardy wrote: I normally wouldn't have gone reading some PDF to explain a patch, but this one was really worth it .. a couple of pictures of cars with four applications using can0-can3 :) This is a really cool insight for car manufacturers employees. If you miss them out you'll

Re: [RFD] L2 Network namespace infrastructure

2007-06-25 Thread Serge E. Hallyn
Quoting David Miller ([EMAIL PROTECTED]): From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 23 Jun 2007 11:19:34 -0600 Further and fundamentally all a global achieves is removing the need for the noise patches where you pass the pointer into the various functions. For long term

Re: [RFD] L2 Network namespace infrastructure

2007-06-25 Thread Serge E. Hallyn
Quoting Jeff Garzik ([EMAIL PROTECTED]): Eric W. Biederman wrote: Jeff Garzik [EMAIL PROTECTED] writes: David Miller wrote: I don't accept that we have to add another function argument to a bunch of core routines just to support this crap, especially since you give no way to turn it off

Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-06-25 Thread Stephen Hemminger
On Mon, 25 Jun 2007 22:09:39 +0900 (JST) OBATA Noboru [EMAIL PROTECTED] wrote: From: OBATA Noboru [EMAIL PROTECTED] Make TCP_RTO_MAX a variable, and allow a user to change it via a new sysctl entry /proc/sys/net/ipv4/tcp_rto_max. A user can then guarantee TCP retransmission to be more

Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-06-25 Thread Stephen Hemminger
On Mon, 25 Jun 2007 15:15:14 +0200 Patrick McHardy [EMAIL PROTECTED] wrote: OBATA Noboru wrote: From: OBATA Noboru [EMAIL PROTECTED] Make TCP_RTO_MAX a variable, and allow a user to change it via a new sysctl entry /proc/sys/net/ipv4/tcp_rto_max. A user can then guarantee TCP

RE: [PATCH 2/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-25 Thread Waskiewicz Jr, Peter P
/* ensure 32-byte alignment of both the device and private area */ - alloc_size = (sizeof(*dev) + NETDEV_ALIGN_CONST) ~NETDEV_ALIGN_CONST; + alloc_size = (sizeof(*dev) + NETDEV_ALIGN_CONST + +(sizeof(struct net_device_subqueue) * (queue_count - 1))) Why

Re: [PATCH] NET: Multiqueue network device support.

2007-06-25 Thread jamal
On Fri, 2007-22-06 at 09:26 +0800, Zhu Yi wrote: On Thu, 2007-06-21 at 11:39 -0400, jamal wrote: It sounds stupid I'm still trying to convince you why we need multiqueue support in Qdisc when everybody else are already working on the code, If you go back historically (maybe 2 years ago on

Re: FSCKED clock sources WAS(Re: [WIP][PATCHES] Network xmit batching

2007-06-25 Thread jamal
On Thu, 2007-21-06 at 20:45 +0400, Evgeniy Polyakov wrote: On Thu, Jun 21, 2007 at 11:54:17AM -0400, jamal ([EMAIL PROTECTED]) wrote: Evgeniy, did you sync on the batching case with the git tree? My tree contains following commits: Latest mainline commit:

Re: FSCKED clock sources WAS(Re: [WIP][PATCHES] Network xmit batching

2007-06-25 Thread jamal
On Thu, 2007-21-06 at 12:55 -0400, Benjamin LaHaise wrote: You should qualify that as 'Old P4 Xeon', as the Core 2 Xeons are leagues better. The Xeon hardware is not that old - about a year or so (and so is the opteron). BTW, how could you tell this was old Xeon? cheers, jamal - To

Re: Linksys Gigabit USB2.0 adapter (asix) regression

2007-06-25 Thread Erik Slagter
David Hollis wrote: You wouldn't happen to know what PHY that device is using? The AX88178 (Gigabit USB Ethernet) support in the driver currently only supports the Marvell PHY, which is the only one I've actually encountered to-date. I'll quote a few of strings that are spewed that I assume

Re: FSCKED clock sources WAS(Re: [WIP][PATCHES] Network xmit batching

2007-06-25 Thread Benjamin LaHaise
On Mon, Jun 25, 2007 at 12:59:54PM -0400, jamal wrote: On Thu, 2007-21-06 at 12:55 -0400, Benjamin LaHaise wrote: You should qualify that as 'Old P4 Xeon', as the Core 2 Xeons are leagues better. The Xeon hardware is not that old - about a year or so (and so is the opteron). BTW, how

Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

2007-06-25 Thread jamal
On Fri, 2007-22-06 at 12:09 +0200, Johannes Berg wrote: Why do you think that would be hard? It'd basically just mean replacing the netlink_capable(sock, NL_NONROOT_RECV) calls with a call that actually tests depending on the group(s) it wants. I think it could be done. You will need to have

RE: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread Waskiewicz Jr, Peter P
This patch adds a new attribute type that can be used to replace non-nested attributes that contain structures by nested ones in a compatible way. This can be used in cases like Peter's who is trying to extend sch_prio, which currently uses a fixed structure without any holes.

RE: [PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue

2007-06-25 Thread Waskiewicz Jr, Peter P
enum { - TCA_PRIO_UNPSEC, - TCA_PRIO_TEST, You misunderstood me. You can work on top of my compat attribute patches, but the example code should not have to go in to apply your patch. Ok. I'll fix my patches. diff --git a/net/sched/Kconfig b/net/sched/Kconfig index

Re: [WIP][PATCHES] Network xmit batching

2007-06-25 Thread Rick Jones
Evgeniy Polyakov wrote: On Thu, Jun 21, 2007 at 02:00:07PM -0700, Rick Jones ([EMAIL PROTECTED]) wrote: Simple test included test - desktop and vice versa traffic with 128 and 4096 block size in netperf-2.4.3 setup. Is that in conjunction with setting the test-specific -D to set TCP_NODELAY,

Re: [2/2] 2.6.22-rc6: known regressions with patches

2007-06-25 Thread Linus Torvalds
On Mon, 25 Jun 2007, Michal Piotrowski wrote: Memory management Subject: bug in i386 MTRR initialization References : http://lkml.org/lkml/2007/5/19/93 Submitter : Andrea Righi [EMAIL PROTECTED] Status : patch available This one wasn't a bug in the first place, it was just the

Re: [E1000 05/05]: Secondary unicast address support

2007-06-25 Thread Kok, Auke
Patrick McHardy wrote: [E1000]: Secondary unicast address support Add support for configuring secondary unicast addresses. Unicast addresses take precendece over multicast addresses when filling the exact address filters to avoid going to promiscous mode. When more unicast addresses are present

Re: [E1000 05/05]: Secondary unicast address support

2007-06-25 Thread Patrick McHardy
Kok, Auke wrote: Patrick McHardy wrote: @@ -2449,9 +2450,16 @@ e1000_set_multi(struct net_device *netdev) rctl |= (E1000_RCTL_UPE | E1000_RCTL_MPE); } else if (netdev-flags IFF_ALLMULTI) { rctl |= E1000_RCTL_MPE; -rctl = ~E1000_RCTL_UPE; } else { -

Re: [PATCH] RFC: have tcp_recvmsg() check kthread_should_stop() and treat it as if it were signalled

2007-06-25 Thread Satyam Sharma
Hi, On 6/9/07, Jeff Layton [EMAIL PROTECTED] wrote: On Sat, 09 Jun 2007 11:30:04 +1000 Herbert Xu [EMAIL PROTECTED] wrote: Please cc networking patches to [EMAIL PROTECTED] Jeff Layton [EMAIL PROTECTED] wrote: The following patch is a first stab at removing this need. It makes it so

Re: [PATCH] RFC: have tcp_recvmsg() check kthread_should_stop() and treat it as if it were signalled

2007-06-25 Thread Jeff Layton
On Tue, 26 Jun 2007 01:11:20 +0530 Satyam Sharma [EMAIL PROTECTED] wrote: Hi, On 6/9/07, Jeff Layton [EMAIL PROTECTED] wrote: On Sat, 09 Jun 2007 11:30:04 +1000 Herbert Xu [EMAIL PROTECTED] wrote: Please cc networking patches to [EMAIL PROTECTED] Jeff Layton [EMAIL PROTECTED]

Re: [PATCH] sctp: lock_sock_nested in sctp_sock_migrate

2007-06-25 Thread Vlad Yasevich
Zach Brown wrote: I'm not sure that I've gotten either the sctp or lockdep details right, but with this patch I don't get lockdep yelling at me any more :) -- sctp: lock_sock_nested in sctp_sock_migrate sctp_sock_migrate() grabs the socket lock on a newly allocated socket while

Re: [PATCH] sctp: lock_sock_nested in sctp_sock_migrate

2007-06-25 Thread Arjan van de Ven
Vlad Yasevich wrote: Hm... This is another case of of two different sockets taking the same lock... Arjan, did this every get fixed, or is the nested locking the right solution to this? for this specific case it's ok and the nested solution is right. In the general case it's obviously not

Re: [PATCH] sctp: lock_sock_nested in sctp_sock_migrate

2007-06-25 Thread Vlad Yasevich
Arjan van de Ven wrote: Vlad Yasevich wrote: Hm... This is another case of of two different sockets taking the same lock... Arjan, did this every get fixed, or is the nested locking the right solution to this? for this specific case it's ok and the nested solution is right. In the

Re: [PATCH] NET: Multiqueue network device support.

2007-06-25 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 12:47:31 -0400 On Fri, 2007-22-06 at 09:26 +0800, Zhu Yi wrote: We don't have THL and THH in our driver. They are what you suggested. The queue wakeup number is 1/4 of the ring size. So how did you pick 1/4? Experimentation? If you look

RE: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread Waskiewicz Jr, Peter P
From: Waskiewicz Jr, Peter P [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 10:14:37 -0700 This patch adds a new attribute type that can be used to replace non-nested attributes that contain structures by nested ones in a compatible way. This can be used in cases like Peter's who

Re: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread Patrick McHardy
David Miller wrote: I've been using this patch and the IPROUTE2 patches Patrick has proposed with no issues. Can someone else look at these patches when they have time? I'd be interested in seeing them make it into 2.6.23. I've just put Patrick's patch into the net-2.6.23 tree.

[PATCH] atl1: disable 64bit DMA

2007-06-25 Thread Luca Tettamanti
Il Mon, Jun 25, 2007 at 07:42:44AM -0500, Jay Cliburn ha scritto: Jay L. T. Cornwall wrote: Jay Cliburn wrote: For reasons not yet clear to me, it appears the L1 driver has a bug or the device itself has trouble with DMA in high memory. This patch, drafted by Luca Tettamanti, is being

Re: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread David Miller
From: Waskiewicz Jr, Peter P [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 14:01:31 -0700 Awesome Dave!! Thank you very much. :) Please get your next round of patches ready, Patrick and I can review them and barring any serious issues we can finally put this stuff in to net-2.6.23. - To unsubscribe

Re: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 23:08:09 +0200 David Miller wrote: I've been using this patch and the IPROUTE2 patches Patrick has proposed with no issues. Can someone else look at these patches when they have time? I'd be interested in seeing them make

RE: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread Waskiewicz Jr, Peter P
-Original Message- From: David Miller [mailto:[EMAIL PROTECTED] Sent: Monday, June 25, 2007 2:30 PM To: Waskiewicz Jr, Peter P Cc: [EMAIL PROTECTED]; netdev@vger.kernel.org; [EMAIL PROTECTED] Subject: Re: [RTNETLINK]: Add nested compat attribute From: Waskiewicz Jr, Peter P

Re: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread David Miller
From: Waskiewicz Jr, Peter P [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 14:33:12 -0700 I'm putting them into the latest 2.6.23 tree right now - I'll have them tested and sent upstream later today. Please repull as I just put Patrick's RTNETLINK patch in for real this time :-) - To unsubscribe

Re: [PATCH] atl1: disable 64bit DMA

2007-06-25 Thread Chris Snook
Luca Tettamanti wrote: Il Mon, Jun 25, 2007 at 07:42:44AM -0500, Jay Cliburn ha scritto: Jay L. T. Cornwall wrote: Jay Cliburn wrote: For reasons not yet clear to me, it appears the L1 driver has a bug or the device itself has trouble with DMA in high memory. This patch, drafted by Luca

RE: [PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue

2007-06-25 Thread Waskiewicz Jr, Peter P
@@ -70,14 +72,28 @@ prio_classify(struct sk_buff *skb, struct Qdisc *sch, int *qerr) #endif if (TC_H_MAJ(band)) band = 0; + if (q-mq) + skb-queue_mapping = +

Re: [PATCH] atl1: disable 64bit DMA

2007-06-25 Thread Chris Snook
Jay L. T. Cornwall wrote: Chris Snook wrote: What boards have we seen this on? It's quite possible this is: I can reproduce on an Asus P5K with a Core 2 Duo E6600. lspci identifies the controller as: 02:00.0 Ethernet controller: Attansic Technology Corp. L1 Gigabit Ethernet Adapter

Re: [PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue

2007-06-25 Thread Patrick McHardy
Waskiewicz Jr, Peter P wrote: @@ -70,14 +72,28 @@ prio_classify(struct sk_buff *skb, struct Qdisc *sch, int *qerr) #endif if (TC_H_MAJ(band)) band = 0; + if (q-mq) +skb-queue_mapping = +

RE: [PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue

2007-06-25 Thread Waskiewicz Jr, Peter P
Thats not necessary. I just though you could add one exit point: ... out: skb-queue_mapping = q-mq ? band : 0; return q-queues[band]; } But if that doesn't work don't bother .. Unfortunately it won't, given how band might be used like this to select the queue: return

Re: [PATCH] atl1: disable 64bit DMA

2007-06-25 Thread Jay L. T. Cornwall
Chris Snook wrote: What boards have we seen this on? It's quite possible this is: I can reproduce on an Asus P5K with a Core 2 Duo E6600. lspci identifies the controller as: 02:00.0 Ethernet controller: Attansic Technology Corp. L1 Gigabit Ethernet Adapter (rev b0) dmesg notes the

Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-06-25 Thread Rick Jones
Ian McDonald wrote: On 6/26/07, OBATA Noboru [EMAIL PROTECTED] wrote: From: OBATA Noboru [EMAIL PROTECTED] Make TCP_RTO_MAX a variable, and allow a user to change it via a new sysctl entry /proc/sys/net/ipv4/tcp_rto_max. A user can then guarantee TCP retransmission to be more controllable,

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-25 Thread Andrew Morton
On Thu, 21 Jun 2007 18:48:30 +0530 pradeep singh [EMAIL PROTECTED] wrote: diff --git a/drivers/net/chelsio/cxgb2.c b/drivers/net/chelsio/cxgb2.c index 231ce43..006c634 100644 --- a/drivers/net/chelsio/cxgb2.c +++ b/drivers/net/chelsio/cxgb2.c @@ -1022,6 +1022,11 @@ static int __devinit

Re: [NET] au1000_eth: Fix warnings.

2007-06-25 Thread Andrew Morton
On Sun, 24 Jun 2007 15:59:54 +0200 Ralf Baechle [EMAIL PROTECTED] wrote: Fixed by including linux/dma-mapping.h: CC drivers/net/au1000_eth.o drivers/net/au1000_eth.c: In function 'au1000_probe': drivers/net/au1000_eth.c:661: warning: implicit declaration of function

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-25 Thread Jeff Garzik
Andrew Morton wrote: The chelsio driver is assuming that pci_device_id.driver_data has been initialised to the board index, but I am unable to locate anywhere where that initialisation actually happens. It's hidden inside the CH_DEVICE() initializer-helper macro. Jeff - To

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-25 Thread Jeff Garzik
Andrew Morton wrote: (Who maintains this driver now?) It was abandonware from the beginning of its life. Stephen H and Francois R did a bunch of cleanups most recently. Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH] atl1: disable 64bit DMA

2007-06-25 Thread Jeff Garzik
Jay Cliburn wrote: On Mon, 25 Jun 2007 17:57:20 -0400 Chris Snook [EMAIL PROTECTED] wrote: Jay L. T. Cornwall wrote: Chris Snook wrote: What boards have we seen this on? It's quite possible this is: I can reproduce on an Asus P5K with a Core 2 Duo E6600. lspci identifies the controller

RE: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread Waskiewicz Jr, Peter P
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 23:08:09 +0200 David Miller wrote: I've been using this patch and the IPROUTE2 patches Patrick has proposed with no issues. Can someone else look at these patches when they have time? I'd be interested in seeing

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-25 Thread Andrew Morton
On Mon, 25 Jun 2007 19:14:05 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Andrew Morton wrote: The chelsio driver is assuming that pci_device_id.driver_data has been initialised to the board index, but I am unable to locate anywhere where that initialisation actually happens. It's hidden

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-25 Thread Jeff Garzik
Andrew Morton wrote: On Mon, 25 Jun 2007 19:14:05 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Andrew Morton wrote: The chelsio driver is assuming that pci_device_id.driver_data has been initialised to the board index, but I am unable to locate anywhere where that initialisation actually

Re: [RTNETLINK]: Add nested compat attribute

2007-06-25 Thread David Miller
From: Waskiewicz Jr, Peter P [EMAIL PROTECTED] Date: Mon, 25 Jun 2007 16:23:02 -0700 It looks like the one Patrick resent was the older version that requires a typecast. This is the function prototype currently in the kernel: +extern int rtattr_parse_nested_compat(struct rtattr *tb[], int

Re: [PATCH] ps3: gigabit ethernet driver for PS3, take2

2007-06-25 Thread Masakazu Mokuno
On Sat, 23 Jun 2007 11:09:04 -0700 Geoff Levand [EMAIL PROTECTED] wrote: MOKUNO Masakazu wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2920,6 +2920,12 @@ M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] S: Maintained +PS3 NETWORK SUPPORT +P: Masakazu Mokuno +M: [EMAIL

Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-06-25 Thread Siim Põder
Yo! Patrick McHardy wrote: OBATA Noboru wrote: Make TCP_RTO_MAX a variable, and allow a user to change it via a new sysctl entry /proc/sys/net/ipv4/tcp_rto_max. A user can then guarantee TCP retransmission to be more controllable, say, at least once per 10 seconds, by setting it to 10.