pradeep singh wrote:
Hi,
This is second submission for a possible NULL dereference handling in
the Chelsio's 10G driver.
Thanks to Jens Axboe for pointing out my mistake of ignoring
subsequent dereferences in init_one routine.
Thanks
Signed-off-by: Pradeep Singh [EMAIL PROTECTED]
---
Ralf Baechle wrote:
Fixed by including linux/dma-mapping.h:
CC drivers/net/au1000_eth.o
drivers/net/au1000_eth.c: In function 'au1000_probe':
drivers/net/au1000_eth.c:661: warning: implicit declaration of function
'dma_alloc_noncoherent'
drivers/net/au1000_eth.c:802: warning: implicit
Divy Le Ray wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Use the right register to stop broadcast/multicast traffic.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
applied to #upstream-fixes
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
Olaf Hering wrote:
On Tue, Jun 19, Stephen Hemminger wrote:
On Tue, 19 Jun 2007 21:02:53 +0200
Olaf Hering [EMAIL PROTECTED] wrote:
What happend to __ucmpdi2 from David Woodhouse?
google has a few hits about stuff like this on 32bit powerpc with gcc 4.1.2:
ERROR: __ucmpdi2
The dm9601 driver was including the 2 byte hardware header in the
packet length, causing the HW to send 2 extra bytes of garbage on tx.
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
---
drivers/net/usb/dm9601.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Index:
Usbnet adds a padding byte if a 0 byte USB packet would be sent. Zero
padding byte if there is tail room in skb.
Signed-of-by: Peter Korsgaard [EMAIL PROTECTED]
Acked-by: David Brownell [EMAIL PROTECTED]
---
drivers/net/usb/usbnet.c |9 ++---
1 file changed, 6 insertions(+), 3
From: Sean Kormilo [EMAIL PROTECTED]
Date: Thu, 17 May 2007 15:16:12 -0400
Update ipconfig to enable users to specify multiple devices on the kernel
commandline
ip= option. This allows for up-to 4 devices to be specified, with devices
separated by
a '/' character. For example, to limit
From: [EMAIL PROTECTED]
Date: Wed, 23 May 2007 16:50:18 +0900
From: Masahide NAKAMURA [EMAIL PROTECTED]
Kill unnecessary CONFIG_IPV6_MIP6.
o It is redundant for RAW socket to keep MH out with the config then
it can handle any protocol.
o Clean-up at AH.
Signed-off-by: Masahide
From: [EMAIL PROTECTED]
Date: Wed, 23 May 2007 16:50:19 +0900
From: Masahide NAKAMURA [EMAIL PROTECTED]
This patch makes MIPv6 loadable module named mip6.
Here is a modprobe.conf(5) example to load it automatically
when user application uses XFRM state for MIPv6:
alias xfrm-type-10-43
From: [EMAIL PROTECTED]
Date: Fri, 25 May 2007 13:23:23 +0900
Hi Ingo and all,
This is the third one of MIPv6 module patch. It can be applied
after two patches which are already sent to the list.
Could you review it?
It is clean-up for XFRM type modules and adds aliases with its
From: James Chapman [EMAIL PROTECTED]
Date: Sat, 26 May 2007 18:47:24 +0100
This patch adds a new UDP_ENCAP_L2TPINUDP encapsulation type for UDP
sockets. When a UDP socket's encap_type is UDP_ENCAP_L2TPINUDP, the
skb is delivered to a function pointed to by udp_encap_l2tp_rcv. If
the skb
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Wed, 30 May 2007 14:00:34 -0700
This is better.
There is still a possiblity when a device allows IPV6 and not IPV4
checksumming, that the checksum will be done in the fixup code in
dev_queue_xmit.
The existing model for checksum offload does
From: Dan Williams [EMAIL PROTECTED]
Date: Fri, 01 Jun 2007 17:17:49 -0700
Hello David,
The following two patches are part of the raid acceleration series I
would like to push for 2.6.23 consideration. I am sending these two
separately for your review for the following reasons: the
From: David Miller [EMAIL PROTECTED]
Date: Wed, 27 Jun 2007 00:18:24 -0700 (PDT)
From: James Chapman [EMAIL PROTECTED]
Date: Sat, 26 May 2007 18:47:24 +0100
Add struct sockaddr_pppol2tp to carry L2TP-specific address
information for the PPPoX (PPPoL2TP) socket. Unfortunately we can't
Questions regarding the USB network drivers should now go to netdev.
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
---
MAINTAINERS | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
Index: linux-2.6.22-rc6/MAINTAINERS
Peter Korsgaard wrote:
Questions regarding the USB network drivers should now go to netdev.
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
---
MAINTAINERS | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
Index: linux-2.6.22-rc6/MAINTAINERS
From: Patrick McHardy [EMAIL PROTECTED]
Date: Fri, 22 Jun 2007 14:24:07 +0200 (MEST)
[NET]: dev_mcast: unexport dev_mc_upload
dev_mc_add/dev_mc_delete take care of uploading the list when
necessary and thats the only interface other code should use.
Also remove two incorrect calls in
From: Patrick McHardy [EMAIL PROTECTED]
Date: Fri, 22 Jun 2007 14:24:09 +0200 (MEST)
[NET]: dev: introduce generic net_device address lists
Introduce struct dev_addr_list and list maintenance functions
based on dev_mc_list and the related functions. This will be
used by follow-up patches
From: Patrick McHardy [EMAIL PROTECTED]
Date: Fri, 22 Jun 2007 14:24:10 +0200 (MEST)
[NET]: dev_mcast: switch to generic net_device address lists
Use generic net_device address lists for multicast list handling.
Some defines are used to keep drivers working.
Signed-off-by: Patrick McHardy
From: Patrick McHardy [EMAIL PROTECTED]
Date: Fri, 22 Jun 2007 14:24:12 +0200 (MEST)
[NET]: dev: secondary unicast address support
Add support for configuring secondary unicast addresses on network
devices. To support this devices capable of filtering multiple
unicast addresses need to
David Miller wrote:
From: Patrick McHardy [EMAIL PROTECTED]
Date: Fri, 22 Jun 2007 14:24:12 +0200 (MEST)
[NET]: dev: secondary unicast address support
Add support for configuring secondary unicast addresses on network
devices. To support this devices capable of filtering multiple
unicast
Hello All,
We have been experimenting a couple of interface hangs with the 8139cp
driver. It appears that the tx buffer stops transmitting and never starts
up again in some yet unknown conditions. To be able to circumvent this we
implemented the missing dev-tx_timeout function which should reset
[EMAIL PROTECTED] wrote:
Hello All,
We have been experimenting a couple of interface hangs with the 8139cp
driver. It appears that the tx buffer stops transmitting and never starts
up again in some yet unknown conditions. To be able to circumvent this we
implemented the missing dev-tx_timeout
On 6/27/07, Jeff Garzik [EMAIL PROTECTED] wrote:
Quite true, but for courtesy's sake you should keep the relevant
maintainers in the loop, and get their ACKs, when you start changing
their MAINTAINERS entries.
Sorry, I forgot the CCs.
David already agreed with the change:
From: Patrick McHardy [EMAIL PROTECTED]
Date: Wed, 27 Jun 2007 10:30:09 +0200
David Miller wrote:
From: Patrick McHardy [EMAIL PROTECTED]
Date: Fri, 22 Jun 2007 14:24:12 +0200 (MEST)
[NET]: dev: secondary unicast address support
Add support for configuring secondary unicast
This patch implements the missing dev-tx_timeout for 8139cp driver
Signed-off-by: Mika Lansirinne [EMAIL PROTECTED]
---
diff -ru linux-2.6.21.5/drivers/net/8139cp.c
linux-2.6.21.5_8139cp-tx_timeout/drivers/net/8139cp.c
--- linux-2.6.21.5/drivers/net/8139cp.c 2007-06-11 21:37:06.0
Jean-Baptiste Vignaud [EMAIL PROTECTED],
marcin.slusarz [EMAIL PROTECTED],
shemminger [EMAIL PROTECTED]
Subject: Re: [PATCH] 8139cp dev-tx_timeout
References: [EMAIL PROTECTED] [EMAIL PROTECTED]
In-Reply-To: [EMAIL PROTECTED]
On 27-06-2007 10:36, Jeff Garzik wrote:
[EMAIL PROTECTED] wrote:
(second try! sorry)
On 27-06-2007 10:36, Jeff Garzik wrote:
[EMAIL PROTECTED] wrote:
Hello All,
We have been experimenting a couple of interface hangs with the 8139cp
driver. It appears that the tx buffer stops transmitting and never starts
up again in some yet unknown conditions. To be
On Wed, 27 Jun 2007, Jeff Garzik wrote:
Peter Korsgaard wrote:
Questions regarding the USB network drivers should now go to netdev.
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
---
MAINTAINERS | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
Index:
On 25-06-2007 11:28, Patrick McHardy wrote:
...
It is. This patch I had originally planned for 2.6.23 switches HTB
to the generic estimator, which shouldn't suffer from this.
BTW, maybe I look at this too short, but is this del_timer()
in gen_kill_estimator() enough? I cannot see nothing
Jarek Poplawski wrote:
On 25-06-2007 11:28, Patrick McHardy wrote:
...
It is. This patch I had originally planned for 2.6.23 switches HTB
to the generic estimator, which shouldn't suffer from this.
BTW, maybe I look at this too short, but is this del_timer()
in gen_kill_estimator()
On Wed, Jun 27, 2007 at 01:44:08PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
On 25-06-2007 11:28, Patrick McHardy wrote:
...
It is. This patch I had originally planned for 2.6.23 switches HTB
to the generic estimator, which shouldn't suffer from this.
BTW, maybe I look
On Wed, Jun 27, 2007 at 02:10:13PM +0200, Jarek Poplawski wrote:
...
- So if it's not only about kindness, feel free to do it
+ So if it's only about kindness, feel free to do it
Sorry!
Jarek P.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
On 06/27, Satyam Sharma wrote:
Thanks for your comments, I'm still not convinced, however.
An perhaps you are right. I don't have a very strong opinion on that.
Still I can't understand why it is better if kthread_stop() sends a
signal as well. Contrary, I believe we should avoid signals when
Patrick McHardy wrote:
Eric W. Biederman wrote:
-- The basic design
There will be a network namespace structure that holds the global
variables for a network namespace, making those global variables
per network namespace.
One of those per network namespace global variables will be the
Jarek Poplawski wrote:
On Wed, Jun 27, 2007 at 01:44:08PM +0200, Patrick McHardy wrote:
BTW, maybe I look at this too short, but is this del_timer()
in gen_kill_estimator() enough? I cannot see nothing against
a timer just running and doing mod_timer() again...
Yes, but nothing bad
Kirill Korotaev wrote:
Patrick McHardy wrote:
I believe OpenVZ stores the current namespace somewhere global,
which avoids passing the namespace around. Couldn't you do this
as well?
yes, we store a global namespace context on current
(can be stored in per-cpu as well).
do you prefer
On Wed, Jun 27, 2007 at 01:54:15AM -0700, David Brownell wrote:
On Wednesday 27 June 2007, Jeff Garzik wrote:
Peter Korsgaard wrote:
Questions regarding the USB network drivers should now go to netdev.
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
---
MAINTAINERS | 13
Patrick McHardy wrote:
Jarek Poplawski wrote:
I look at this just now, and maybe it's enough for asking,
but definitely not enough for patch. I'll try to check this
more in the evening, so I could send something tomorrow.
So if it's not only about kindness, feel free to do it
sooner and I've
@@ -3610,15 +3610,14 @@
USB CDC ETHERNET DRIVER
P: Greg Kroah-Hartman
I think that may refer to the old cdc ethernet driver
though ... Greg? The new one, in the usbnet framework,
is a very different beast...
Yeah, this is the cdc_acm driver that is still in the USB
Patrick McHardy wrote:
[NET]: gen_estimator: fix locking and timer related bugs
That one still left a race, we could be reinitalizing the timer
while it is still running. This patch additionally makes sure
each timer is only initialized once.
[NET]: gen_estimator: fix locking and timer
Jeff Garzik wrote:
Eric W. Biederman wrote:
Jeff Garzik [EMAIL PROTECTED] writes:
David Miller wrote:
I don't accept that we have to add another function argument
to a bunch of core routines just to support this crap,
especially since you give no way to turn it off and get
that function
Hey Roland,
Here are some bug fixes to the iw_cxgb3 driver that I'd like included
for 2.6.23. NOTE: Patch 1 requires a firmware interface change, so
there is a version bump to 4.3 included in that patch that hits cxgb3.
This will likely conflict with a previous version change that is in
Jeff's
iw_cxgb3: Streaming - RDMA mode transition fixes.
Due to a HW issue, our current scheme to transition the connection from
streaming to rdma mode is broken on the passive side. The firmware
and driver now support a new transition scheme for the passive side:
- driver posts rdma_init_wr (now
iw_cxgb3: TERMINATE WRs can hang the tx ofld queue.
Don't set the gen bits nor length bits in the terminate wr. This is
done by the LLD driver.
Signed-off-by: Steve Wise [EMAIL PROTECTED]
---
drivers/infiniband/hw/cxgb3/iwch_qp.c |6 +++---
1 files changed, 3 insertions(+), 3
iw_cxgb3: Don't count neg_adv abort_req_rss messages as real aborts.
negative advice messages should _not_ count toward the 2 abort requests
needed to indicate an abort request.
Signed-off-by: Steve Wise [EMAIL PROTECTED]
---
drivers/infiniband/hw/cxgb3/iwch_cm.c | 14 +++---
1
iw_cxgb3: ctrl-qp init/clear shouldn't set the gen bit.
Signed-off-by: Steve Wise [EMAIL PROTECTED]
---
drivers/infiniband/hw/cxgb3/cxio_hal.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c
iw_cxgb3: Don't post TID_RELEASE message.
The LLD does this for us in cxgb3_remove_tid().
Also fixed active open failure cases where we shouldn't
be releasing the TID as well.
Signed-off-by: Steve Wise [EMAIL PROTECTED]
---
drivers/infiniband/hw/cxgb3/iwch_cm.c | 13 ++---
1 files
iw_cxgb3: Don't abort after failures sending the mpa reply.
This bug results in an abort request being sent down _after_ the tid
has been released. If the tid happens to have been reused, then the
subsequent generation of the tid gets incorrectly aborted.
The thread running iwch_accecpt_cr()
It seems that every driver, when providing support for ethtool -S
functionality, has considerable lattitude when it comes to the stats
provided. Clearly this is very nice for the driver writer(s) as it
allows them to provide whatever stats they feel are most natural for
their NIC(s) and name
On Wed, 23 May 2007 09:54:31 +0200
Tino Keitel [EMAIL PROTECTED] wrote:
Hi folks,
in the last 2 days, I had 2 outages of the NIC of my Mac mini Core Duo.
I checked the kernel log but I found nothing sky2 related. After
reloading the module, the interface worked again.
Both freezes were
Update ipconfig to enable users to specify multiple devices on the kernel
commandline
ip= option. This allows for an arbitrary number of devices to be specified
up-to a
255 character limit. Devices are separated by a '/' character.
For example, to limit autoconfig requests to eth0 and eth2:
Update ipconfig to enable users to specify multiple devices on the kernel
commandline
ip= option. This allows for an arbitrary number of devices to be specified
up-to a
255 character limit. Devices are separated by a '/' character.
For example, to limit autoconfig requests to eth0 and eth2:
Greg == Greg KH [EMAIL PROTECTED] writes:
Greg Yeah, this is the cdc_acm driver that is still in the USB drivers/
Greg directory tree as it is a USB class driver that shows up as a tty device
Greg to userspace. It should not be moved to the networking list unless no
Greg one minds that I
Here are some bug fixes to the iw_cxgb3 driver that I'd like included
for 2.6.23. NOTE: Patch 1 requires a firmware interface change, so
there is a version bump to 4.3 included in that patch that hits cxgb3.
This will likely conflict with a previous version change that is in
Jeff's
Roland Dreier wrote:
Here are some bug fixes to the iw_cxgb3 driver that I'd like included
for 2.6.23. NOTE: Patch 1 requires a firmware interface change, so
there is a version bump to 4.3 included in that patch that hits cxgb3.
This will likely conflict with a previous version change
The following changes since commit 189548642c5962e60c3667bdb3a703fe0bed12a6:
Linus Torvalds (1):
Linus 2.6.22-rc6
are found in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git
libertas-fixes
Dan Williams (4):
libertas: style fixes
Patrick McHardy wrote:
OBATA Noboru wrote:
From: OBATA Noboru [EMAIL PROTECTED]
Make TCP_RTO_MAX a variable, and allow a user to change it via a
new sysctl entry /proc/sys/net/ipv4/tcp_rto_max. A user can
then guarantee TCP retransmission to be more controllable, say,
at least once
This patch set adds a driver for PPP over L2TP. Patches to follow.
The following changes have been made since the previous version
submitted 26-MAY-07.
- Add new encap_rcv field to struct udp_sock in udp.h for use by
encapsulated sockets. This is set to a protocol specific receive
handler
This patch adds a new UDP_ENCAP_L2TPINUDP encapsulation type for UDP
sockets. When a UDP socket's encap_type is UDP_ENCAP_L2TPINUDP, the
skb is delivered to a function pointed to by the udp_sock's
encap_rcv funcptr. If the skb isn't wanted by L2TP, it returns 0, which
causes it to be passed
Add struct sockaddr_pppol2tp to carry L2TP-specific address
information for the PPPoX (PPPoL2TP) socket. Unfortunately we can't
use the union inside struct sockaddr_pppox because the L2TP-specific
data is larger than the current size of the union and we must preserve
the size of struct
Signed-off-by: James Chapman [EMAIL PROTECTED]
Index: linux-2.6.22-rc6/MAINTAINERS
===
--- linux-2.6.22-rc6.orig/MAINTAINERS
+++ linux-2.6.22-rc6/MAINTAINERS
@@ -2903,6 +2903,11 @@ P: Michal Ostrowski
M: [EMAIL PROTECTED]
Signed-off-by: James Chapman [EMAIL PROTECTED]
Index: linux-2.6.22-rc6/Documentation/networking/l2tp.txt
===
--- /dev/null
+++ linux-2.6.22-rc6/Documentation/networking/l2tp.txt
@@ -0,0 +1,169 @@
+This brief document describes how to
On Tue, 2007-26-06 at 13:57 -0700, David Miller wrote:
From: jamal [EMAIL PROTECTED]
Date: Tue, 26 Jun 2007 09:27:28 -0400
Back to the question: Do you recall how this number was arrived at?
128 packets will be sent out at GiGe in about 80 microsecs, so from a
feel-the-wind-direction
From: James Chapman [EMAIL PROTECTED]
Date: Wed, 27 Jun 2007 23:20:38 +0100
This patch adds a new UDP_ENCAP_L2TPINUDP encapsulation type for UDP
sockets. When a UDP socket's encap_type is UDP_ENCAP_L2TPINUDP, the
skb is delivered to a function pointed to by the udp_sock's
encap_rcv funcptr.
From: James Chapman [EMAIL PROTECTED]
Date: Wed, 27 Jun 2007 23:20:38 +0100
Add struct sockaddr_pppol2tp to carry L2TP-specific address
information for the PPPoX (PPPoL2TP) socket. Unfortunately we can't
use the union inside struct sockaddr_pppox because the L2TP-specific
data is larger than
Changes to last version:
- spelling fix
- cleaned up probe code
Thomas.
Ethernet driver for EISA only SNI RM200/RM400 machines
Signed-off-by: Thomas Bogendoerfer [EMAIL PROTECTED]
---
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index b0d0d73..af5c90f 100644
---
From: James Chapman [EMAIL PROTECTED]
Date: Wed, 27 Jun 2007 23:20:38 +0100
This driver handles only L2TP data frames; control frames are handled
by a userspace application. It implements L2TP using the PPPoX socket
family. There is a PPPoX socket for each L2TP session in an L2TP tunnel.
PPP
From: James Chapman [EMAIL PROTECTED]
Date: Wed, 27 Jun 2007 23:20:38 +0100
Signed-off-by: James Chapman [EMAIL PROTECTED]
Patch applied.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: James Chapman [EMAIL PROTECTED]
Date: Wed, 27 Jun 2007 23:20:38 +0100
Signed-off-by: James Chapman [EMAIL PROTECTED]
Also applied, thanks a lot.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: jamal [EMAIL PROTECTED]
Date: Wed, 27 Jun 2007 18:32:45 -0400
On Tue, 2007-26-06 at 13:57 -0700, David Miller wrote:
From: jamal [EMAIL PROTECTED]
Date: Tue, 26 Jun 2007 09:27:28 -0400
Back to the question: Do you recall how this number was arrived at?
128 packets will be
On Tue, 2007-26-06 at 00:40 +0200, Johannes Berg wrote:
I wonder if we should hold off on this API until we've worked out the
multicast issue.
Even if the ACPI thing goes in first, you will have to change a few
others that are existing in-kernel that need to be changed sooner or
later. So
peoplez,
I have added support for tg3 on batching. I see equivalent performance
improvement for pktgen as i did with e1000 when using gige.
I have only tested on two machines (one being a laptop which does
10/100Mbps). Unfortunately in both cases these are considered to be in
the class of buggy
On Wed, 2007-27-06 at 15:54 -0700, David Miller wrote:
The thing that's really important is that the value is not so
large such that the TX ring can become empty.
In the case of batching, varying the values makes a difference.
The logic is that if you can tune it so that the driver takes
From: jamal [EMAIL PROTECTED]
Date: Wed, 27 Jun 2007 20:15:47 -0400
On Wed, 2007-27-06 at 15:54 -0700, David Miller wrote:
The thing that's really important is that the value is not so
large such that the TX ring can become empty.
In the case of batching, varying the values makes a
Hi Oleg,
On 6/27/07, Oleg Nesterov [EMAIL PROTECTED] wrote:
On 06/27, Satyam Sharma wrote:
Thanks for your comments, I'm still not convinced, however.
An perhaps you are right. I don't have a very strong opinion on that.
Still I can't understand why it is better if kthread_stop() sends a
In article [EMAIL PROTECTED] (at Mon, 25 Jun 2007 22:09:39 +0900 (JST)),
OBATA Noboru [EMAIL PROTECTED] says:
Please note that this is effective in IPv6 as well.
Of course, I'm happy with this.
--yoshfuji
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a
77 matches
Mail list logo