On Wed, Jul 18, 2007 at 05:18:20PM -0400, Robert P. J. Day wrote:
On Wed, 18 Jul 2007, Adrian Bunk wrote:
On Wed, Jul 18, 2007 at 04:51:33PM -0400, Robert P. J. Day wrote:
On Wed, 18 Jul 2007, Jeff Garzik wrote:
Randy Dunlap wrote:
On Wed, 18 Jul 2007 16:23:09 -0400 (EDT)
On Thursday 19 of July 2007, Patrick McHardy wrote:
Arkadiusz Miskiewicz wrote:
I'm having problems with networking on recent git kernel.
kernel logs tons of Virtual device lo asks to queue packet!
and networking stops working correctly:
CONFIG_NETDEVICES_MULTIQUEUE=y
Does it go
How about the following approach:
I allocate an skb of 0 bytes and replace data element
of skb struct (i.e. skb.data = addr_given_by_hw) when
the h/w interrupts me with a packet. I register for a
destructor for this skb and when the kernel is ready
to free the skb, I make sure that my free is
On 7/19/07, vinay ravuri [EMAIL PROTECTED] wrote:
How about the following approach:
I allocate an skb of 0 bytes and replace data element
of skb struct (i.e. skb.data = addr_given_by_hw) when
the h/w interrupts me with a packet. I register for a
destructor for this skb and when the kernel is
On Thu, 19 Jul 2007, Adrian Bunk wrote:
...
I would consider it more ugly to special case this and that in the
kconfig code when plain dependencies already offer exactly the same
functionality...
well, this is the *third* time i've proposed adding this kind of
feature so, at this point, i've
These patches deal with issues brought up by Gavin McCullagh
about reactions of Cubic and HTCP to hostile receivers that return
bogus timestamp options. In a couple of places the timestamp value
is used in ways that could cause unfairness.
The solution in these patches is to only use local values
Change HTCP to use measured RTT rather than smooth RTT.
Srtt is computed using the TCP receive timestamp
options, so it is vulnerable to hostile receivers. To avoid any problems
this might cause use the measured RTT instead.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
This patch changes the API for the callback that is done after an ACK is
received. It solves a couple of issues:
* Some congestion controls want higher resolution value of RTT
(controlled by TCP_CONG_RTT_SAMPLE flag). These don't really want a ktime,
but
all compute a RTT in
Remove use of received timestamp option value from RTT calculation in Cubic.
A hostile receiver may be returning a larger timestamp option than the original
value. This would cause the sender to believe the malevolent receiver had
a larger RTT and because Cubic tries to provide some RTT
I've had a handful of random mystery oopses associated with no particular
activity. A typical trace is at:
http://userweb.kernel.org/~akpm/dsc03659.jpg
the trace is messy and it doesn't seem to want to happen now I've turned on
frame pointers, but it looks networky to me.
So if anyone
On Wed, 18 Jul 2007 23:51:03 -0700 (PDT)
vinay ravuri [EMAIL PROTECTED] wrote:
How about the following approach:
I allocate an skb of 0 bytes and replace data element
of skb struct (i.e. skb.data = addr_given_by_hw) when
the h/w interrupts me with a packet. I register for a
destructor for
On Wed, Jul 18, 2007 at 11:47:54PM -0500, Steven J. Hill wrote:
This first patch 642xx #defines to the 'include/linux/mv643xx.h' file.
I don't think register names should change based on ifefs. Please make
sure both variants can be supported at runtime. While mips might not
support different
On Wed, Jul 18, 2007 at 11:54:45PM -0500, Steven J. Hill wrote:
Fix 'mv643xx_eth_tx_timeout_task' function prototype.
Patches 5-7 look like valid fixes independent of the merge. Please send
them out inlined in the mail and with proper subjects so they can be
merged independent of the GT/MV642xx
Hi.
On Fri, Jul 13, 2007 at 02:21:00PM +0200, Jens Axboe ([EMAIL PROTECTED]) wrote:
It really looks like the last tree we tested, so if you think additional
one will not hurt, feel free to ping, so I will completely rebase
testing tree.
It would be great if you could retest! There are
Robert P. J. Day wrote:
On Thu, 19 Jul 2007, Adrian Bunk wrote:
...
I would consider it more ugly to special case this and that in the
kconfig code when plain dependencies already offer exactly the same
functionality...
well, this is the *third* time i've proposed adding this kind of
Hello.
In article [EMAIL PROTECTED] (at Wed, 11 Jul 2007 11:19:27 +0200), Jens Axboe
[EMAIL PROTECTED] says:
@@ -835,6 +835,7 @@ const struct proto_ops inet_stream_ops = {
.recvmsg = sock_common_recvmsg,
.mmap = sock_no_mmap,
.sendpage =
On Thu, Jul 19 2007, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
Hello.
In article [EMAIL PROTECTED] (at Wed, 11 Jul 2007 11:19:27 +0200), Jens
Axboe [EMAIL PROTECTED] says:
@@ -835,6 +835,7 @@ const struct proto_ops inet_stream_ops = {
.recvmsg = sock_common_recvmsg,
Hi.
On Wed, Jul 18, 2007 at 11:51:03PM -0700, vinay ravuri ([EMAIL PROTECTED])
wrote:
How about the following approach:
I allocate an skb of 0 bytes and replace data element
of skb struct (i.e. skb.data = addr_given_by_hw) when
the h/w interrupts me with a packet. I register for a
Couple of bug fixes for netxen IMEZ adapter on powerpc blades. The firmware
must be loaded during probe and free PCI resources during module unload.
Please apply against #upstream-fixes.
drivers/net/netxen/netxen_nic.h |3 +-
drivers/net/netxen/netxen_nic_main.c | 48
Veth stands for Virtual ETHernet. It is a simple tunnel driver
that works at the link layer and looks like a pair of ethernet
devices interconnected with each other.
Mainly it allows to communicate between network namespaces but
it can be used as is as well. E.g. one may join to bridged
Arkadiusz Miskiewicz wrote:
On Thursday 19 of July 2007, Patrick McHardy wrote:
Arkadiusz Miskiewicz wrote:
I'm having problems with networking on recent git kernel.
kernel logs tons of Virtual device lo asks to queue packet!
and networking stops working correctly:
This routine gets the parsed rtnl attributes and creates a new
link with generic info (IFLA_LINKINFO policy). Its intention
is to help the drivers, that need to create several links at
once (like VETH).
This is nothing but a copy-paste-ed part of rtnl_newlink() function
that is responsible for
Couple of bug fixes for netxen IMEZ adapter on powerpc blades. The firmware
must be loaded during probe and free PCI resources during module unload.
Please apply against #upstream-fixes.
drivers/net/netxen/netxen_nic.h |3 +-
drivers/net/netxen/netxen_nic_main.c | 48
The firmware should be loaded after resetting hardware during PCI probe,
besides module unload. This fixes issue with 2nd port of multiport adapter
on powerpc blades. This patch also fixes a bug that PCI resources are not
freed if dma watchdog shutdown failed. The dma watchdog poll messages
during
On Thu, 19 Jul 2007, Stefan Richter wrote:
Robert P. J. Day wrote:
On Thu, 19 Jul 2007, Adrian Bunk wrote:
...
I would consider it more ugly to special case this and that in the
kconfig code when plain dependencies already offer exactly the same
functionality...
well, this is the
Veth stands for Virtual ETHernet. It is a simple tunnel driver
that works at the link layer and looks like a pair of ethernet
devices interconnected with each other.
Mainly it allows to communicate between network namespaces but
it can be used as is as well.
The newlink callback is organized
Hi.
On Thu, Jul 19, 2007 at 01:33:04AM -0700, Andrew Morton ([EMAIL PROTECTED])
wrote:
I don't think the 2-year-old Vaio has offload engine support ;) Dan, this:
+ if (flags ASYNC_TX_KMAP_DST)
+ dest_buf = kmap_atomic(dest, KM_USER0) + dest_offset;
+
The usage is
# ip link add [name] type veth [device parameters] peer [name name other device
params]
This consists of two parts:
1/2 makes some copy-paste changes in ip/iplink.c for generic CLI
attributes parsing,
2/2 the module itself.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
This routine parses CLI attributes, describing generic link
parameters such as name, address, etc.
This is mostly copy-pasted from iplink_modify().
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Acked-by: Patrick McHardy [EMAIL PROTECTED]
---
include/utils.h |3 +
ip/iplink.c | 127
The link_veth.so itself.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
Acked-by: Patrick McHardy [EMAIL PROTECTED]
---
Makefile|6 -
link_veth.c | 63
veth.h | 12 +++
3 files changed, 80 insertions(+), 1
Thus the traverse of the loop may delete nodes, use the safe version.
Signed-off-by: Denis Cheng [EMAIL PROTECTED]
---
drivers/block/nbd.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index c129510..86639c0 100644
---
this memcpy looks so strange, in fact it's merely a pointer dereference,
so I change the parameter's type to refer it more directly,
this could make the memcpy not needed anymore.
in the function nbd_read_stat where nbd_find_request is only once called,
the parameter served should be transformed
On Thu, 19 Jul 2007 13:28:56 +0400 Evgeniy Polyakov [EMAIL PROTECTED] wrote:
Hi.
On Thu, Jul 19, 2007 at 01:33:04AM -0700, Andrew Morton ([EMAIL PROTECTED])
wrote:
I don't think the 2-year-old Vaio has offload engine support ;) Dan, this:
+ if (flags ASYNC_TX_KMAP_DST)
+
On Thu, Jul 19, 2007 at 02:38:31AM -0700, Andrew Morton ([EMAIL PROTECTED])
wrote:
is very wrong if both ASYNC_TX_KMAP_DST and ASYNC_TX_KMAP_SRC can ever be
set. We'll end up using the same kmap slot for both src add dest and we
get either corrupted data or a BUG.
So far it can not
On Wed, 2007-07-18 at 12:58 +0200, Johannes Berg wrote:
Yeah, I only need to try to remember when I last *didn't* see the
problem, and hope that my analysis about it being on the receiver side
is correct :)
Hm. I went back to 2.6.20 on the receiver side and still saw it. Maybe I
need to go
This patch changes genlmsg_multicast() to take a struct
genl_multicast_group * instead of the ID, that way users are forced to
register a group before being able to use genlmsg_multicast().
Signed-off-by: Johannes Berg [EMAIL PROTECTED]
---
Just seemed like a good idea to enforce using this API
Update the included version of the genetlink.h header to the multicast
group API and make the generic netlink controller part show multicast
groups where applicable. Also fix two typos.
Signed-off-by: Johannes Berg [EMAIL PROTECTED]
diff --git a/genl/ctrl.c b/genl/ctrl.c
index fe010f3..72d39a0
On Wed, 2007-07-18 at 15:34 -0700, David Miller wrote:
All three patches look good to me.
Acked-by: Patrick McHardy [EMAIL PROTECTED]
and for Jamal again ..
Acked-by: Jamal Hadi Salim [EMAIL PROTECTED]
Aha, Johannes did resubmit all 3 patches, they arrived out
of order here
Patrick McHardy wrote:
Arkadiusz Miskiewicz wrote:
CONFIG_NETDEVICES_MULTIQUEUE=y
Does it go away if you disable this option?
Yes, it goes away after disabling this.
I don't see a bug in the code itself, maybe the queue_mapping points
to an invalid subqueue. Could you please try this
Oh, this patchset triggers a current bug in slub, see:
http://article.gmane.org/gmane.linux.kernel/556887
I forgot mentioning that yesterday, I hope it's not causing any trouble.
Also, I had expected it to be fixed soonish, but can't see that it is.
johannes
signature.asc
Description: This is
Hi all,
It's definately better to do rtt measurements in the proper callback
like you're suggesting since the call to cong_avoid depends on too many
factors (ECN, FRTO) that shouldn't inhibit rtt sampling though they,
for a period, determine how cwnd must be set...
--
i.
On Thu, 19 Jul 2007,
On Thu, Jul 19, 2007 at 04:49:13PM +0530, pradeep singh wrote:
CCing: netdev
On 7/19/07, patric [EMAIL PROTECTED] wrote:
Hi,
To start with, i'm not sure if this should go to the dev or user list,
but i'll start here..
I'm currently running a nfsroot via a Broadcom NetXtreme 1000-SX
On Thursday 19 of July 2007, Patrick McHardy wrote:
Patrick McHardy wrote:
Arkadiusz Miskiewicz wrote:
CONFIG_NETDEVICES_MULTIQUEUE=y
Does it go away if you disable this option?
Yes, it goes away after disabling this.
I don't see a bug in the code itself, maybe the queue_mapping
Hello ,
I noticed on current git this warning in net/ipv4/inetpeer.c
...
CC net/ipv4/inetpeer.o
net/ipv4/inetpeer.c: In function 'unlink_from_pool':
net/ipv4/inetpeer.c:297: warning: the address of 'stack' will always
evaluate as 'true'
net/ipv4/inetpeer.c:297: warning: the address of
On Thu, Jul 19, 2007 at 00:58:44 +0200, Patrick McHardy wrote:
Sami Farin wrote:
I had used tcatm patch with 2.6.16 kernel and I was
happy with it.
Now I patched Linux kernel 2.6.22 and iproute-2.6.22
for tcatm. Seems to work (TM). Only HTB tested.
Let me repeat again before we get
Gabriel C wrote:
Hello ,
I noticed on current git this warning in net/ipv4/inetpeer.c
Yeah, I have no idea why the gcc people thought that this was
something worth warning about. Especially since explicitly
checking for != NULL silences the warning again.
[IPV4]: Fix inetpeer gcc-4.2
Patrick McHardy wrote:
Gabriel C wrote:
Hello ,
I noticed on current git this warning in net/ipv4/inetpeer.c
Yeah, I have no idea why the gcc people thought that this was
something worth warning about. Especially since explicitly
checking for != NULL silences the warning again.
Arkadiusz Miskiewicz wrote:
On Thursday 19 of July 2007, Patrick McHardy wrote:
OK I see what the problem is. The loopback device is statically
allocated, so it doesn't have any room for the subqueues reserved.
The easiest fix would be to use egress_subqueue[1] in struct
net_device, but I
Sami Farin wrote:
On Thu, Jul 19, 2007 at 00:58:44 +0200, Patrick McHardy wrote:
Let me repeat again before we get in an endless discussion
again - I will NACK these patches until we have a solution
that works for all qdiscs.
I googled for
Accurate packet scheduling for ATM mchardy
Jeff Garzik wrote:
Brian King wrote:
This patchset enables TCP checksum offload support for IPV4
on ibmveth. This completely eliminates the generation and checking of
the checksum for packets that are completely virtual and never
touch a physical network. A simple TCP_STREAM netperf run on
a
On Thu, 19 Jul 2007 15:28:46 +0200
Krzysztof Halasa [EMAIL PROTECTED] wrote:
Patrick McHardy [EMAIL PROTECTED] writes:
Your suggestion of disabling VLAN acceleration in promiscous
mode sounds like a reasonable solution until then ..
From a user perspective:
I'm not sure promiscous
Robert P. J. Day wrote:
i *did* submit a preliminary patch once upon a time, and it
(predictably) went nowhere.
A patch which pulls the word experimental into prompts or adds a
dedicated directive for tagging of options? Can't find it in archives.
--
Stefan Richter
-=-=-=== -=== =--==
Stephen Hemminger wrote:
On Thu, 19 Jul 2007 15:28:46 +0200
Krzysztof Halasa [EMAIL PROTECTED] wrote:
Your suggestion of disabling VLAN acceleration in promiscous
mode sounds like a reasonable solution until then ..
From a user perspective:
I'm not sure promiscous mode is related to the
Hi all,
Here's once again a corrected version of the patch adding support for
ipv4/ipv6 interfamily addressing for the ipsec BEET (Bound End-to-End
Tunnel) mode, as specified by the ietf draft found at:
http://www.ietf.org/internet-drafts/draft-nikander-esp-beet-mode-07.txt
The previous
Hi,
I already sent this two days ago, but I have the feeling it was
overlooked or filtered because of a large attachment.
If I try to boot 2.6.21.6, 2.6.22.1 or 2.6.22-git8 the system completely
hangs when init tries to bring up my r8169-based NIC. Not even the
keyboard lights are working
On Thu, Jul 19, 2007 at 04:54:45AM +, Steven J. Hill wrote:
Fix 'mv643xx_eth_tx_timeout_task' function prototype.
Signed-off-by: Steven J. Hill [EMAIL PROTECTED]
---
--- linux-2.6.22.1/drivers/net/mv643xx_eth.c 2007-07-18 21:45:13.0
-0500
+++
On Thu, Jul 19, 2007 at 04:53:31AM +, Steven J. Hill wrote:
Add main 642xx support to 'drivers/net/mv643xx_eth.c' file.
As Christoph said, this quantity of ifdefs really hurt the
maintainability. Refactoring is needed. Also, since in arch/powerpc
we want to have a single kernel support
On Thu, Jul 19, 2007 at 04:55:36AM +, Steven J. Hill wrote:
Fix the TX bytes statistics counter to, um, actually count.
Signed-off-by: Steven J. Hill [EMAIL PROTECTED]
---
--- linux-2.6.22.1/drivers/net/mv643xx_eth.c 2007-07-18 21:51:49.0
-0500
+++
On Thu, Jul 19, 2007 at 04:56:51AM +, Steven J. Hill wrote:
Get rid of global PHY spinlock.
You have replaced the use of the global PHY spinlock with a per-port spinlock.
However, the SMI register is shared by all ports. The global lock is
needed to prevent simultaneous updates of the
Stephen Hemminger [EMAIL PROTECTED] writes:
1) non-accelerated device
* all frames show in promiscious mode
* tag is part of the frame that shows up
in tcpdump, and then gets stripped by the 8021q module.
Sure. It's IMHO good and working, modulo the tag being removed
on the
On Thu, Jul 19, 2007 at 05:02:04AM +, Steven J. Hill wrote:
Fix long standing panic with regards to descriptors and locking.
Signed-off-by: Steven J. Hill [EMAIL PROTECTED]
---
diff -ur linux-2.6.22.1/drivers/net/mv643xx_eth.c
linux-2.6.22.1-rci/drivers/net/mv643xx_eth.c
---
Joakim Koskela wrote:
static int xfrm4_beet_output(struct xfrm_state *x, struct sk_buff *skb)
{
[... ipv4 handling, looks fine ...]
+#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE)
+ int delta = sizeof(struct ipv6hdr) - sizeof(struct iphdr);
+ u8 protocol;
On Thu, 19 Jul 2007 16:23:48 +0200
Krzysztof Halasa [EMAIL PROTECTED] wrote:
Stephen Hemminger [EMAIL PROTECTED] writes:
1) non-accelerated device
* all frames show in promiscious mode
* tag is part of the frame that shows up
in tcpdump, and then gets stripped by the
Denis Cheng wrote:
Thus the traverse of the loop may delete nodes, use the safe version.
Signed-off-by: Denis Cheng [EMAIL PROTECTED]
---
drivers/block/nbd.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index
On Thursday 12 July 2007 04:33, David Miller wrote:
I'll add merge your patch with a target of 2.6.23
If you really want, after this patch has sat in 2.6.23 for a while
and got some good testing, we can consider a submission for -stable.
Okay, those of you who followed the discussion on lkml
On Thu, 19 Jul 2007 16:23:48 +0200
Krzysztof Halasa [EMAIL PROTECTED] wrote:
Stephen Hemminger [EMAIL PROTECTED] writes:
1) non-accelerated device
* all frames show in promiscious mode
* tag is part of the frame that shows up
in tcpdump, and then gets stripped by the
On 7/19/07, Evgeniy Polyakov [EMAIL PROTECTED] wrote:
On Thu, Jul 19, 2007 at 02:38:31AM -0700, Andrew Morton ([EMAIL PROTECTED])
wrote:
is very wrong if both ASYNC_TX_KMAP_DST and ASYNC_TX_KMAP_SRC can ever be
set. We'll end up using the same kmap slot for both src add dest and we
On Thu, 19 Jul 2007 05:25:30 -0400 (EDT) Robert P. J. Day wrote:
On Thu, 19 Jul 2007, Stefan Richter wrote:
Robert P. J. Day wrote:
On Thu, 19 Jul 2007, Adrian Bunk wrote:
...
I would consider it more ugly to special case this and that in the
kconfig code when plain
Stephen Hemminger [EMAIL PROTECTED] writes:
Not at runtime, acceleration is always on if you compile kernel with vlan
support. That is a design mistake as far as I can tell.
I think so.
However seeing unknown tags on master device (with tcpdump etc)
would certainly be useful.
Only in
This patchset enables TCP checksum offload support for IPV4
on ibmveth. This completely eliminates the generation and checking of
the checksum for packets that are completely virtual and never
touch a physical network. A simple TCP_STREAM netperf run on
a virtual network with maximum mtu set
This patch adds the appropriate ethtool hooks to allow for enabling/disabling
of hypervisor assisted checksum offload for TCP.
Signed-off-by: Brian King [EMAIL PROTECTED]
---
linux-2.6-bjking1/drivers/net/ibmveth.c | 120 +++-
Add ethtool hooks to ibmveth to retrieve driver statistics.
Signed-off-by: Brian King [EMAIL PROTECTED]
---
linux-2.6-bjking1/drivers/net/ibmveth.c | 53 +++-
1 file changed, 52 insertions(+), 1 deletion(-)
diff -puN
Add handlers for get_tso and get_ufo to prevent errors being printed
by ethtool.
Signed-off-by: Brian King [EMAIL PROTECTED]
---
linux-2.6-bjking1/drivers/net/ibmveth.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_get_tso
Just to make it clear: Is this message an error, or a
warning or just
for information?
Could you explain a bit please.
Its a debugging message nowadays (NETDEBUG). I was mostly interested
in this since I changed the IPsec MTU calculation in 2.6.22 and it
might have been a bug.
I
The consensus seems to be that skb's need to carry vlan accelerated tags in
their cb's, on rx as well as tx. VLAN_TX_SKB_CB() is perfect for that.
[Patrick] On the TX path, it could simply use the CB, but this is actually
also wrong (for both macvlan and real devices) since qdiscs have
On 7/19/07, Paul Clements [EMAIL PROTECTED] wrote:
Could you name n as tmp (as in the previous code) so that it's clear
that's only a temporary variable. Other than that, this looks good.
Sure. I just use the name n as in the declaration of
list_for_each_entry_safe in the header file
On Thu, 19 Jul 2007, Bill Fink wrote:
Hi John,
On Wed, 18 Jul 2007, [EMAIL PROTECTED] wrote:
On Wed, 18 Jul 2007, Francois Romieu wrote:
[EMAIL PROTECTED] [EMAIL PROTECTED] :
[...]
Anyone have any suggestions for solving this problem?
Try 2.6.23-rc1 when it is published or apply
One additional thought: with the proposed changes in my prev message, the
driver can be set to hw vlan accelerated mode, even if no vlan interfaces are
configured. We would not have to switch hw vlan accelerated mode anymore, when
vlan interfaces are created or destroyed.
On Thu, 19 Jul 2007 08:47:01 -0700 (PDT)
andrei radulescu-banu [EMAIL PROTECTED] wrote:
The consensus seems to be that skb's need to carry vlan accelerated tags in
their cb's, on rx as well as tx. VLAN_TX_SKB_CB() is perfect for that.
[Patrick] On the TX path, it could simply use the CB,
On Thu, 19 Jul 2007, Randy Dunlap wrote:
On Thu, 19 Jul 2007 05:25:30 -0400 (EDT) Robert P. J. Day wrote:
On Thu, 19 Jul 2007, Stefan Richter wrote:
Robert P. J. Day wrote:
On Thu, 19 Jul 2007, Adrian Bunk wrote:
...
I would consider it more ugly to special case this and
On Thu, 19 Jul 2007 17:19:19 +0200
Olaf Kirch [EMAIL PROTECTED] wrote:
On Thursday 12 July 2007 04:33, David Miller wrote:
I'll add merge your patch with a target of 2.6.23
If you really want, after this patch has sat in 2.6.23 for a while
and got some good testing, we can consider a
andrei radulescu-banu wrote:
The consensus seems to be that skb's need to carry vlan accelerated tags in
their cb's, on rx as well as tx. VLAN_TX_SKB_CB() is perfect for that.
No its not. Its only legal to use while something has ownership
of the skb. Between VLAN devices and real devices
Hi all,
Here is a list of some known regressions in 2.6.22-git
with patches available.
Feel free to add new regressions/remove fixed etc.
http://kernelnewbies.org/known_regressions
List of Aces
NameRegressions fixed since 21-Jun-2007
Adrian Bunk3
On Thu, 2007-07-19 at 15:24 +0200, patric wrote:
Just a hypothetical question. If the 2 network cards starts the
autonegotiation would it be possible that they get into a loop where
they are chasing each others state? Maybe a fix could be to add a sleep
of a random length that would
andrei radulescu-banu wrote:
[Ben] I think a better method would be to allow disabling VLAN HW accel for a
NIC with ethtool.
This requires changes to ethtool and e1000 driver, +other drivers. It is a
handy thing to have. I don't view it as a solution to tcpdump - or to the vlan
On 7/19/07, rae l [EMAIL PROTECTED] wrote:
On 7/19/07, Paul Clements [EMAIL PROTECTED] wrote:
Could you name n as tmp (as in the previous code) so that it's clear
that's only a temporary variable. Other than that, this looks good.
Sure. I just use the name n as in the declaration of
On Wed, 2007-07-18 at 01:35, Andy Fleming wrote:
phy_read() returns a negative number if there's an error, but the
error-checking code in the Vitesse driver's config_intr function
triggers if phy_read() returns non-zero. Correct that.
Signed-off-by: Andy Fleming [EMAIL PROTECTED]
---
I
ext Brian King wrote:
+
+static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
+{
+ struct ibmveth_adapter *adapter = dev-priv;
+
Why do not to do
if ((data adapter-rx_csum) || (!data !adapter-rx_csum))
return 0;
less two lines.
+ if (data
Hi Michal;
19 Tem 2007 Per tarihinde, Michal Piotrowski şunları yazmıştı:
Block layer
Subject : bsg.c:(.init.text+0x43d): undefined reference to
`scsi_register_interface' References :
http://lkml.org/lkml/2007/7/16/343
Last known good : ?
Submitter : Larry Finger [EMAIL
Denis Cheng wrote:
this memcpy looks so strange, in fact it's merely a pointer dereference,
so I change the parameter's type to refer it more directly,
this could make the memcpy not needed anymore.
in the function nbd_read_stat where nbd_find_request is only once called,
the parameter served
[Andrei] VLAN_TX_SKB_CB() is perfect for that.
[Patrick, Stephen] No its not. Its only legal to use while something has
ownership
of the skb. Between VLAN devices and real devices qdiscs are
free to use it.
All right, using VLAN_TX_SKB_CB() is a bad idea. In that case, we need to amend
the
Ragner Magalhaes wrote:
ext Brian King wrote:
+
+static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
+{
+struct ibmveth_adapter *adapter = dev-priv;
+
Why do not to do
if ((data adapter-rx_csum) || (!data !adapter-rx_csum))
return 0;
less two
Hey Francois,
I've CC'd the netdev list as requested, however, I'm not signed up to
this list so please include my email address directly in any replies. Thanks
Francois Romieu wrote:
I'm in a particularly sticky situation in relation to the latest
kernels and multicast. And I need some help
ext Brian King wrote:
Ragner Magalhaes wrote:
ext Brian King wrote:
+
+static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
+{
+ struct ibmveth_adapter *adapter = dev-priv;
+
Why do not to do
if ((data adapter-rx_csum) || (!data !adapter-rx_csum))
[Ben] If tcpdump and/or bridging needs to disable the hw-accel, then it can
explicitly do so by some API. That is better than overloading
the promisc flag in my opinion.
I guess I could be persuaded in the end. But let me still play devil advocate.
The semantics of 'promiscuous', in my
Ragner Magalhaes wrote:
ext Brian King wrote:
Ragner Magalhaes wrote:
here also, as above ...
+ if (data (dev-features NETIF_F_IP_CSUM))
+ return 0;
+ if (!data !(dev-features NETIF_F_IP_CSUM))
+ return 0;
This change would make the line 80 columns, which I prefer
On 16/07/07 14:01, Patrick McHardy wrote:
Simon Arlott wrote:
Changing an existing route:
# ip -6 r show 2002::/16
2002::/16 dev sit0 metric 1024 expires 4482618sec mtu 1480 advmss 7140
hoplimit 4294967295
# ip -6 r change 2002::/16 dev sit0 mtu 1280
RTNETLINK answers: File exists
The code
On Thursday 19 July 2007 17:46:42 Patrick McHardy wrote:
-
+ if (xfrm[i]-props.mode != XFRM_MODE_TRANSPORT) {
+ encap_family = xfrm[i]-props.family;
+ if (encap_family == AF_INET) {
+ remote.in = (struct in_addr *)
Hi,
On Thursday 19 July 2007, Michal Piotrowski wrote:
Unclassified
Subject : disk error loop (panic?) ide_do_rw_disk-bad
References : http://lkml.org/lkml/2007/7/17/467
Last known good : ?
Submitter : Giacomo Catenazzi [EMAIL PROTECTED]
Caused-By : ?
On Thu, 19 Jul 2007 11:20:43 -0700 (PDT)
andrei radulescu-banu [EMAIL PROTECTED] wrote:
[Ben] If tcpdump and/or bridging needs to disable the hw-accel, then it can
explicitly do so by some API. That is better than overloading
the promisc flag in my opinion.
I guess I could be persuaded
1 - 100 of 126 matches
Mail list logo
