Kok, Auke napsal(a):
Jiri Slaby wrote:
I still have problems with the driver. When I do `ip link set eth0
up', ksoftirq
runs with 100 % cpu time, so I think you endlessly re-schedule some
timer (or
the new napi layer?)
something changed in the logic and e1000e apparently does something
Jiri Slaby wrote:
Kok, Auke napsal(a):
Jiri Slaby wrote:
I still have problems with the driver. When I do `ip link set eth0
up', ksoftirq
runs with 100 % cpu time, so I think you endlessly re-schedule some
timer (or
the new napi layer?)
something changed in the logic and e1000e apparently
Paul E. McKenney [EMAIL PROTECTED] writes:
I know I cannot use get_net for the reference in in /proc because
otherwise I could not release the network namespace unless I was to
unmount the filesystem, which is not a desirable property.
I think I can change the idiom to:
struct net
sh: add support for ax88796 and 93cx6 to highlander boards
This patch adds eeprom support to the ax88796 driver together with a platform
device for highlander boards. The 93cx6 driver is hooked up to the ax88796
driver and is used to read out the mac address from the on board eeprom. The
pin
Krishna Kumar2 [EMAIL PROTECTED] writes:
Eric W. Biederman wrote on 09/09/2007 02:45:34 AM:
Hi Eric,
+static int register_pernet_operations(struct list_head *list,
+ struct pernet_operations *ops)
+{
snip
+out:
+ return error;
+
+out_undo:
+ /* If I have an error
On Mon, Sep 10, 2007 at 03:36:26PM +0900, Magnus Damm wrote:
--- 0004/arch/sh/boards/renesas/r7780rp/setup.c
+++ work/arch/sh/boards/renesas/r7780rp/setup.c 2007-09-06
15:35:49.0 +0900
@@ -21,6 +21,7 @@
#include asm/clock.h
#include asm/heartbeat.h
#include asm/io.h
Fix the oidentd oops reported by Athanasius [EMAIL PROTECTED] in
http://bugzilla.kernel.org/show_bug.cgi?id=8961
The oops is a 2.6.22 regression and triggerable by normal users.
The patch applies cleanly to current -git and stable-2.6.22.
[INET_DIAG]: Fix oops in netlink_rcv_skb
YOSHIFUJI Hideaki / 吉藤英明:
Hi,
BUG: unable to handle kernel NULL pointer dereference at virtual address
008c
:
EIP is at ip6_flush_pending_frames+0x97/0x121
I think I've found a bug.
[...]
Anyway, please try this.
FTR, I tried 2.6.22.6 without the patch and it failed as well. The
Hans-J??rgen Koch [EMAIL PROTECTED] wrote:
The following patch fixes it. Tested on an AT91SAM9263-EK board, kernel
2.6.23-rc4 and -rc3-mm1.
Could you please audit all instances of physdev-lock and add
_bh where necessary? I can see that at least phys_stop also
needs the _bh.
We should also
jamal wrote:
If the problem i am trying to solve is reduce cpu use at lower rate,
then this is not the right answer because your cpu use has gone up.
The problem I'm trying to solve is reduce the max interrupt rate from
NAPI drivers while minimizing latency. In modern systems, the interrupt
Jason Lunz wrote:
I'd be particularly interested to see what happens to your latency when
other apps are hogging the cpu. I assume from your description that your
cpu is mostly free to schedule the niced softirqd for the device polling
duration, but this won't always be the case. If other tasks
Andi Kleen wrote:
James Chapman [EMAIL PROTECTED] writes:
On some platforms the precise timers (like ktime_get()) can be slow,
but often they are fast. It might make sense to use a shorter
constant time wait on those with fast timers at least. Right now this
cannot be known by portable code,
Mandeep Singh Baines wrote:
Why would using a timer to hold off the napi_complete() rather than
jiffy count limit the polls per packet to 2?
I was thinking a timer could be used in the way suggested in Jamal's
paper. The driver would do nothing (park) until the timer expires. So
there would
Remove typedefs, volatiles and convert kmalloc()/memset() pairs to
kcalloc(). Also reformat the surrounding clutter.
Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED]
---
Per your request, Andrew, a while ago. It builds, runs, passes
checkpatch.pl and sparse. No semantic changes.
Please
On Mon, 2007-10-09 at 10:20 +0100, James Chapman wrote:
jamal wrote:
If the problem i am trying to solve is reduce cpu use at lower rate,
then this is not the right answer because your cpu use has gone up.
The problem I'm trying to solve is reduce the max interrupt rate from
NAPI
On Sat, Sep 08, 2007 at 09:00:08PM +0100, Jiri Slaby wrote:
remove asm/bitops.h includes
including asm/bitops directly may cause compile errors. don't include it
and include linux/bitops instead. next patch will deny including asm header
directly.
Cc: Adrian Bunk [EMAIL PROTECTED]
On Sep 10, 2007, at 06:56:29, Denys Vlasenko wrote:
On Sunday 09 September 2007 19:18, Arjan van de Ven wrote:
On Sun, 9 Sep 2007 19:02:54 +0100
Denys Vlasenko [EMAIL PROTECTED] wrote:
Why is all this fixation on volatile? I don't think people want
volatile keyword per se, they want
On Sun, Sep 02, 2007 at 01:11:29PM +, Christian Kujau wrote:
after upgrading to 2.6.23-rc5 (and applying davem's fix [0]), lockdep
was quite noisy when I tried to shape my external (wireless) interface:
[ 6400.534545] FahCore_78.exe/3552 just changed the state of lock:
[ 6400.534713]
On Monday 10 September 2007 13:22, Kyle Moffett wrote:
On Sep 10, 2007, at 06:56:29, Denys Vlasenko wrote:
On Sunday 09 September 2007 19:18, Arjan van de Ven wrote:
On Sun, 9 Sep 2007 19:02:54 +0100
Denys Vlasenko [EMAIL PROTECTED] wrote:
Why is all this fixation on volatile? I don't
Adrian Bunk wrote:
sctp_addto_param() can become static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Ack
-vlad
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Sep 09, 2007 at 10:25:50PM +0200, Adrian Bunk wrote:
sctp_addto_param() can become static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
ACK, seems reasonable to me.
Neil
--
/***
*Neil Horman
[EMAIL PROTECTED]
*gpg keyid: 1024D /
Eric W. Biederman wrote:
Each netlink socket will live in exactly one network namespace,
this includes the controlling kernel sockets.
This patch updates all of the existing netlink protocols
to only support the initial network namespace. Request
by clients in other namespaces will get
On Mon, 10 Sep 2007 11:56:29 +0100
Denys Vlasenko [EMAIL PROTECTED] wrote:
Well, if you insist on having it again:
Waiting for atomic value to be zero:
while (atomic_read(x))
continue;
and this I would say is buggy code all the way.
Not from a pure C level
Eric W. Biederman wrote:
Until we support multiple network namespaces with netfilter only allow
netfilter configuration in the initial network namespace.
PATCH 17/16? :)
Sorry,
Pavel
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
On Sun, Sep 09, 2007 at 10:25:54PM +0200, Adrian Bunk wrote:
On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote:
...
Changes since 2.6.23-rc3-mm1:
...
git-net.patch
...
git trees
...
This patch makes the following needlessly globalvariables static:
-
Eric W. Biederman wrote:
[snip]
--- /dev/null
+++ b/include/net/net_namespace.h
@@ -0,0 +1,68 @@
+/*
+ * Operations on the network namespace
+ */
+#ifndef __NET_NET_NAMESPACE_H
+#define __NET_NET_NAMESPACE_H
+
+#include asm/atomic.h
+#include linux/workqueue.h
+#include linux/list.h
On Monday 10 September 2007 14:38, Denys Vlasenko wrote:
You are basically trying to educate me how to use atomic properly.
You don't need to do it, as I am (currently) not a driver author.
I am saying that people who are already using atomic_read()
(and who unfortunately did not read your
Hi all,
This patch series is a bit neglected.
Since our goal is to have bonding support for IPoIB in kernel 2.6.24 it is
very important for us to get comments soon.
We would appreciate if you take some time to look at this and help us push this
code upstream.
thanks
MoniS
-
To
On Monday 10 September 2007 15:51, Arjan van de Ven wrote:
On Mon, 10 Sep 2007 11:56:29 +0100
Denys Vlasenko [EMAIL PROTECTED] wrote:
Well, if you insist on having it again:
Waiting for atomic value to be zero:
while (atomic_read(x))
continue;
and
Hi list,
I have been running recent linux kernel on nexcom NSA 1086's equipped
with sysconnect NICs.
Like some people previously have on this list I am running into
problems with these NICs and seeing frequent errors in my dmesg:
sky2 eth4: rx error, status 0x402300 length 60
printk: 17
On Mon, 10 Sep 2007, Denys Vlasenko wrote:
static inline int
qla2x00_wait_for_loop_ready(scsi_qla_host_t *ha)
{
int return_status = QLA_SUCCESS;
unsigned long loop_timeout ;
scsi_qla_host_t *pha = to_qla_parent(ha);
/* wait for 5 min at the max for
Pavel Emelyanov [EMAIL PROTECTED] writes:
Rr. This is the 5th or even the 6th patch that changes tens of files
but (!) most of these changes are just propagating some core thing into
protocols, drivers, etc. E.g. you add an argument to some function and
then make all the rest use it, but
Pavel Emelyanov [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
Until we support multiple network namespaces with netfilter only allow
netfilter configuration in the initial network namespace.
PATCH 17/16? :)
Exactly!
If my target was the core of the networking stack I figured I better
Pavel Emelyanov [EMAIL PROTECTED] writes:
Eric W. Biederman wrote:
[snip]
--- /dev/null
+++ b/include/net/net_namespace.h
@@ -0,0 +1,68 @@
+/*
+ * Operations on the network namespace
+ */
+#ifndef __NET_NET_NAMESPACE_H
+#define __NET_NET_NAMESPACE_H
+
+#include asm/atomic.h
On Mon, 10 Sep 2007 15:38:23 +0100
Denys Vlasenko [EMAIL PROTECTED] wrote:
On Monday 10 September 2007 15:51, Arjan van de Ven wrote:
On Mon, 10 Sep 2007 11:56:29 +0100
Denys Vlasenko [EMAIL PROTECTED] wrote:
Well, if you insist on having it again:
Waiting for atomic value
On Monday 10 September 2007 16:09, Linus Torvalds wrote:
On Mon, 10 Sep 2007, Denys Vlasenko wrote:
static inline int
qla2x00_wait_for_loop_ready(scsi_qla_host_t *ha)
{
int return_status = QLA_SUCCESS;
unsigned long loop_timeout ;
scsi_qla_host_t *pha =
Pádraig Brady wrote:
Rick Jones wrote:
This was an issue over a decade ago with SPECweb96 benchmarking. The
initial solution was to make the explicit bind() calls and not rely on
the anonymous/ephemeral port space. After that, one starts adding
additional IP's into the mix (at least where
As Dmitry pointed out earlier, rfkill-input.c
doesn't support irda because there are no users
and we shouldn't add unrequired KEY_ defines.
However, RFKILL_TYPE_IRDA was defined in the
rfkill.h header file and would confuse people
about whether it is implemented or not.
This patch removes IRDA
This patch will add support for UWB keys to rfkill,
support for this has been requested by Inaky.
Signed-off-by: Ivo van Doorn [EMAIL PROTECTED]
Acked-by: Dmitry Torokhov [EMAIL PROTECTED]
---
include/linux/input.h |1 +
include/linux/rfkill.h|2 ++
net/rfkill/rfkill-input.c |
Add a documentation file which contains
a short description about rfkill with some
notes about drivers and the userspace interface.
Signed-off-by: Ivo van Doorn [EMAIL PROTECTED]
Acked-by: Dmitry Torokhov [EMAIL PROTECTED]
---
Documentation/rfkill.txt | 88
On Mon, Sep 10, 2007 at 01:20:38PM +0100, Maciej W. Rozycki wrote:
Remove typedefs, volatiles and convert kmalloc()/memset() pairs to
kcalloc(). Also reformat the surrounding clutter.
Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED]
---
Per your request, Andrew, a while ago. It
I've been digging around to see about inducing /proc/net/tcp to show
some interesting things for listen sockets (eg backlog depth, its max,
and dropped connection requests). While there I've noticed that both
tcp_v[46]_syn_recv_sock and tcp_v[46]conn_request both check that the
listen queue
Am Montag 10 September 2007 schrieb Herbert Xu:
Hans-J??rgen Koch [EMAIL PROTECTED] wrote:
The following patch fixes it. Tested on an AT91SAM9263-EK board, kernel
2.6.23-rc4 and -rc3-mm1.
Could you please audit all instances of physdev-lock and add
_bh where necessary? I can see that at
On Fri, 17 Aug 2007, Segher Boessenkool wrote:
volatile has nothing to do with reordering. atomic_dec() writes
to memory, so it _does_ have volatile semantics, implicitly, as
long as the compiler cannot optimise the atomic variable away
completely -- any store counts as a side effect.
On Mon, 10 Sep 2007, Linus Torvalds wrote:
The fact is, volatile *only* makes things worse. It generates worse
code, and never fixes any real bugs. This is a *fact*.
Yes, lets just drop the volatiles now! We need a patch that gets rid of
them Volunteers?
-
To unsubscribe from this
Quoting Eric W. Biederman ([EMAIL PROTECTED]):
The simplest thing to implement is moving network devices between
namespaces. However with the same attribute IFLA_NET_NS_PID we can
easily implement creating devices in the destination network
namespace as well. However that is a little bit
Serge E. Hallyn [EMAIL PROTECTED] writes:
+static struct net *get_net_ns_by_pid(pid_t pid)
+{
+struct task_struct *tsk;
+struct net *net;
+
+/* Lookup the network namespace */
+net = ERR_PTR(-ESRCH);
+rcu_read_lock();
+tsk = find_task_by_pid(pid);
+if (tsk)
Since the sctp_sockaddr_entry is now RCU enabled as part of
the patch to synchronize sctp_localaddr_list, it makes sense to
change all handling of these entries to RCU. This includes the
sctp_bind_addrs structure and it's list of bound addresses.
This list is currently protected by an external
Hi All
This is my first attempt to add RCU synchronization to pieces of SCTP
and I want to make sure I do this right.
The RCU docs a somewhat outdated, and the calling conventions differ
between subsystems, so I am using what I've been able to find.
A bit of a background...
The whole problem
sctp_localaddr_list is modified dynamically via NETDEV_UP
and NETDEV_DOWN events, but there is not synchronization
between writer (even handler) and readers. As a result,
the readers can access an entry that has been freed and
crash the sytem.
Signed-off-by: Vlad Yasevich [EMAIL PROTECTED]
---
On Sep 10, 2007, at 12:46:33, Denys Vlasenko wrote:
My point is that people are confused as to what atomic_read()
exactly means, and this is bad. Same for cpu_relax(). First one
says read, and second one doesn't say barrier.
QA:
Q: When is it OK to use atomic_read()?
A: You are asking
On Mon, Sep 10, 2007 at 11:59:29AM -0700, Christoph Lameter wrote:
On Fri, 17 Aug 2007, Segher Boessenkool wrote:
volatile has nothing to do with reordering. atomic_dec() writes
to memory, so it _does_ have volatile semantics, implicitly, as
long as the compiler cannot optimise the
On Sun, 2007-09-09 at 23:12 +0100, Chris Rankin wrote:
--- Dan Williams [EMAIL PROTECTED] wrote:
Offhand question, does your ne2000 card support carrier detection?
Err... there is a /sys/class/net/eth0/carrier entry (I think - not in front
of that machine right
now). IIRC it said 1 when I
On Mon, 10 Sep 2007, Paul E. McKenney wrote:
The one exception to this being the case where process-level code is
communicating to an interrupt handler running on that same CPU -- on
all CPUs that I am aware of, a given CPU always sees its own writes
in order.
Yes but that is due to the code
On Mon, Sep 10, 2007 at 03:46:29PM -0400, Vlad Yasevich wrote:
sctp_localaddr_list is modified dynamically via NETDEV_UP
and NETDEV_DOWN events, but there is not synchronization
between writer (even handler) and readers. As a result,
the readers can access an entry that has been freed and
On Mon, Sep 10, 2007 at 02:36:26PM -0700, Christoph Lameter wrote:
On Mon, 10 Sep 2007, Paul E. McKenney wrote:
The one exception to this being the case where process-level code is
communicating to an interrupt handler running on that same CPU -- on
all CPUs that I am aware of, a given
On Mon, 2007-09-10 at 11:42 -0700, Rick Jones wrote:
I've been digging around to see about inducing /proc/net/tcp to show
some interesting things for listen sockets (eg backlog depth, its max,
and dropped connection requests).
backlog depth(acceptq length) for a listening socket should be
On Sep 10 2007 13:09, Maciej W. Rozycki wrote:
The new code builds fine; no semantic changes.
Please apply,
Maciej
patch-mips-2.6.23-rc5-20070904-ipconfig-printk-2
diff -up --recursive --new-file
linux-mips-2.6.23-rc5-20070904.macro/net/ipv4/ipconfig.c
On Mon, Sep 10, 2007 at 03:46:30PM -0400, Vlad Yasevich wrote:
Since the sctp_sockaddr_entry is now RCU enabled as part of
the patch to synchronize sctp_localaddr_list, it makes sense to
change all handling of these entries to RCU. This includes the
sctp_bind_addrs structure and it's list of
Sridhar Samudrala wrote:
On Mon, 2007-09-10 at 11:42 -0700, Rick Jones wrote:
I've been digging around to see about inducing /proc/net/tcp to show
some interesting things for listen sockets (eg backlog depth, its max,
and dropped connection requests).
backlog depth(acceptq length) for a
Return some useful information such as the maximum listen backlog and
the current listen backlog in the tcp_info structure and have that
match what one can see in /proc/net/tcp and /proc/net/tcp6.
Signed-off-by: Rick Jones [EMAIL PROTECTED]
---
diff -r bdcdd0e1ee9d
On Mon, 10 Sep 2007 19:56:03 +0200 Ivo van Doorn wrote:
Add a documentation file which contains
a short description about rfkill with some
notes about drivers and the userspace interface.
Thanks. I have noted a few typo/editorial changes below.
Signed-off-by: Ivo van Doorn [EMAIL
From: Chris Snook [EMAIL PROTECTED]
Unambiguously document the fact that atomic_read() and atomic_set()
do not imply any ordering or memory access, and that callers are
obligated to explicitly invoke barriers as needed to ensure that
changes to atomic variables are visible in all contexts that
This incorporates the new napi_struct changes into e1000e. Included
bugfix for ifdown hang from Krishna Kumar for e1000.
Disabling polling is no longer needed at init time, so remove
napi_disable() call from _probe().
This also fixes an endless polling loop where the driver signalled
polling
On Mon, Sep 10, 2007 at 07:19:44PM -0400, Chris Snook wrote:
From: Chris Snook [EMAIL PROTECTED]
Unambiguously document the fact that atomic_read() and atomic_set()
do not imply any ordering or memory access, and that callers are
obligated to explicitly invoke barriers as needed to ensure
On Mon, 2007-10-09 at 21:00 +0800, Herbert Xu wrote:
The minimal fix would be to make sure that we disable BH on
the first CPU.
disabling BH would make it more symmetric to the way we handle
egress. I couldnt reproduce the issue, but this should hopefully resolve
it.
Christian, can you test
I'm new to the list and new to just about everything involving kernel
development. I'm working on a project where I have successfully written a LKM
to handle IP packets for protocol type 253 (an experimental protocol number).
Now, I'm working on sending my reply and I hit a road block. I'm
David,
From an old thread:
5) Since, in the NETPOLL case, netif_napi_init() adds the NAPI struct
to the per-device list I renamed it to netif_napi_add(). Currently
no teardown is really necessary, anything that would need to be done
would be driver internal, so I didn't create the
Kok, Auke wrote:
David,
From an old thread:
5) Since, in the NETPOLL case, netif_napi_init() adds the NAPI struct
to the per-device list I renamed it to netif_napi_add(). Currently
no teardown is really necessary, anything that would need to be done
would be driver internal, so
On Mon, 2007-09-10 at 16:13 -0700, Rick Jones wrote:
Return some useful information such as the maximum listen backlog and
the current listen backlog in the tcp_info structure and have that
match what one can see in /proc/net/tcp and /proc/net/tcp6.
If we are also exporting max listen
Quoting Eric W. Biederman ([EMAIL PROTECTED]):
Serge E. Hallyn [EMAIL PROTECTED] writes:
+static struct net *get_net_ns_by_pid(pid_t pid)
+{
+ struct task_struct *tsk;
+ struct net *net;
+
+ /* Lookup the network namespace */
+ net = ERR_PTR(-ESRCH);
+ rcu_read_lock();
+
On 9/10/07, Johannes Berg [EMAIL PROTECTED] wrote:
When cfg80211 is built into the kernel it needs to init earlier
so that device registrations are run after it has initialised.
Signed-off-by: Johannes Berg [EMAIL PROTECTED]
Yep, I need this fix as well. Without it the ath5k driver built in
On 9/10/07, Magnus Damm [EMAIL PROTECTED] wrote:
-module_init(rate_control_simple_init);
+//module_init(rate_control_simple_init);
+postcore_initcall(rate_control_simple_init);
module_exit(rate_control_simple_exit);
MODULE_DESCRIPTION(Simple rate control algorithm for ieee80211);
Same
On Mon, Sep 10, 2007 at 08:04:41PM -0400, jamal wrote:
disabling BH would make it more symmetric to the way we handle
egress. I couldnt reproduce the issue, but this should hopefully resolve
it.
Christian, can you test with this patch?
Jamal, it's the police_lock that we need to make _bh.
On Mon, Sep 10, 2007 at 08:45:50PM +0200, Hans-Jürgen Koch wrote:
Could you please audit all instances of physdev-lock and add
_bh where necessary? I can see that at least phys_stop also
needs the _bh.
I think the patch does all that's necessary. At least, there're no error
messages in
Background: RFC 4293 deprecates existing individual, named ICMP
type counters to be replaced with the ICMPMsgStatsTable. This table
includes entries for both IPv4 and IPv6, and requires counting of all
ICMP types, whether or not the machine implements the type.
These patches remove (but not
Background: RFC 4293 deprecates existing individual, named ICMP
type counters to be replaced with the ICMPMsgStatsTable. This table
includes entries for both IPv4 and IPv6, and requires counting of all
ICMP types, whether or not the machine implements the type.
These patches remove (but not
77 matches
Mail list logo
