Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-20 Thread Eric Dumazet
Nagendra Tomar a écrit : --- Davide Libenzi [EMAIL PROTECTED] wrote: On Wed, 19 Sep 2007, David Miller wrote: From: Nagendra Tomar [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 15:37:09 -0700 (PDT) With the SOCK_NOSPACE check in tcp_check_space(), this epoll_wait call will not return, even when

Re: [PATCH] ethtool: marvell register update

2007-09-20 Thread Jeff Garzik
Stephen Hemminger wrote: Update the decode of sky2 registers. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] phy: export phy_mii_ioctl

2007-09-20 Thread Jeff Garzik
Domen Puncer wrote: Export phy_mii_ioctl, so network drivers can use it when built as modules too. Signed-off-by: Domen Puncer [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] pci: Fix e100 interrupt quirk

2007-09-20 Thread Andrew Morton
On Tue, 18 Sep 2007 15:17:37 +0400 Valentine Barshak [EMAIL PROTECTED] wrote: PCI memory space may have a 64-bit offset on some architectures (for example, PowerPC 440) and the actual PCI memory address has to fixed up (an offset to PCI mem space shuld be added) before remapping. So,

[PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-20 Thread Joe Perches
In the same vein as print_mac, the implementations introduce declaration macros: DECLARE_IP_BUF(var) DECLARE_IPV6_BUF(var) and functions: print_ip print_ipv6 print_ipv6_nofmt IPV4 Use: DECLARE_IP_BUF(ipbuf); __be32 addr;

[PATCH - net-2.6.24 1/2] Introduce and use print_ip

2007-09-20 Thread Joe Perches
This removes the uses of NIPQUAD and HIPQUAD in drivers/net and net IPV4 Use: DECLARE_IP_BUF(ipbuf); __be32 addr; print_ip(ipbuf, addr) Signed-off-by: Joe Perches [EMAIL PROTECTED] please pull from: git pull http://repo.or.cz/r/linux-2.6/trivial-mods.git print_ipv4

[git patches] net driver updates

2007-09-20 Thread Jeff Garzik
[this, sans patch which was too big for netdev, was just sent upstream. the patch can be recreated via 'git diff net-2.6.24..upstream'] NOTE that sky2 will also be going upstream for 2.6.23-rc, as just posted on netdev. Please pull from the 'upstream' branch of

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-20 Thread Nagendra Tomar
--- Eric Dumazet [EMAIL PROTECTED] wrote: Nagendra Tomar a écrit : --- Davide Libenzi [EMAIL PROTECTED] wrote: On Wed, 19 Sep 2007, David Miller wrote: From: Nagendra Tomar [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 15:37:09 -0700 (PDT) With the SOCK_NOSPACE check in

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-20 Thread Urs Thuermann
Hi Patrick, I have done allmost all changes to the code as you suggested. The changes to use the return value of can_rx_register() also fixed a minor flax with failing bind() and setsockopt() on raw sockets. But there are two things left I would like to ask/understand: Patrick McHardy [EMAIL

Re: [2.6.23-rc4-mm1][Bug] kernel BUG at include/linux/netdevice.h:339!

2007-09-20 Thread Kamalesh Babulal
Andrew Morton wrote: On Mon, 17 Sep 2007 17:46:38 +0530 Kamalesh Babulal [EMAIL PROTECTED] wrote: Kernel Bug is hit with 2.6.23-rc4-mm1 kernel on ppc64 machine. kernel BUG at include/linux/netdevice.h:339! (please cc netdev@vger.kernel.org on networking-related matters) You

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-20 Thread Patrick McHardy
Urs Thuermann wrote: Patrick McHardy [EMAIL PROTECTED] writes: When the module is unloaded it calls can_proto_unregister() which clears the pointer. Do you see a race condition here? Yes, you do request_module, load the module, get the cp pointer from proto_tab, the module is unloaded again.

Re: [PATCH] pci: Fix e100 interrupt quirk

2007-09-20 Thread Valentine Barshak
Andrew Morton wrote: On Tue, 18 Sep 2007 15:17:37 +0400 Valentine Barshak [EMAIL PROTECTED] wrote: PCI memory space may have a 64-bit offset on some architectures (for example, PowerPC 440) and the actual PCI memory address has to fixed up (an offset to PCI mem space shuld be added) before

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-20 Thread Urs Thuermann
Patrick McHardy [EMAIL PROTECTED] writes: No, you need to add your own locking to prevent this, something list this: registration/unregistration: take lock change proto_tab[] release lock lookup: take lock cp = proto_tab[] if (cp !try_module_get(cp-owner)) cp = NULL

Re: [LARTC] ifb and ppp

2007-09-20 Thread Patrick McHardy
Please keep netdev and myself CCed. Frithjof Hammer wrote: Does this patch help? A further examiniation: [...] printk (fri: mein type %x\n,dev-type); switch (dev-type) { [...] shows this: [EMAIL PROTECTED]:/usr/src/linux-source-2.6.21# dmesg | grep fri fri: mein

[PATCH net-2.6.24 0/9]: TCP improvements cleanups

2007-09-20 Thread Ilpo Järvinen
Hi Dave, Just in case you're short on what to do ;-) here are some TCP related cleanups improvements to net-2.6.24. Including FRTO undo fix which finally should allow FRTO to be turned on, and some simple fastpath tweaks simple enough to the 2.6.24 schedule. ...I've a larger fastpath_hint

[PATCH 1/9] [TCP]: Maintain highest_sack accurately to the highest skb

2007-09-20 Thread Ilpo Järvinen
In general, it should not be necessary to call tcp_fragment for already SACKed skbs, but it's better to be safe than sorry. And indeed, it can be called from sacktag when a DSACK arrives or some ACK (with SACK) reordering occurs (sacktag could be made to avoid the call in the latter case though

[PATCH 2/9] [TCP]: Make fackets_out accurate

2007-09-20 Thread Ilpo Järvinen
Substraction for fackets_out is unconditional when snd_una advances, thus there's no need to do it inside the loop. Just make sure correct bounds are honored. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] --- net/ipv4/tcp_input.c | 10 +++--- net/ipv4/tcp_output.c | 44

[PATCH 3/9] [TCP]: clear_all_retrans_hints prefixed by tcp_

2007-09-20 Thread Ilpo Järvinen
In addition, fix its function comment spacing. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] --- include/net/tcp.h |4 ++-- net/ipv4/tcp_input.c | 10 +- net/ipv4/tcp_output.c |6 +++--- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/include/net/tcp.h

[PATCH 4/9] [TCP]: Move accounting from tso_acked to clean_rtx_queue

2007-09-20 Thread Ilpo Järvinen
The accounting code is pretty much the same, so it's a shame we do it in two places. I'm not too sure if added fully_acked check in MTU probing is really what we want perhaps the added end_seq could be used in the after() comparison. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] ---

[PATCH 6/9] [TCP] FRTO: Improve interoperability with other undo_marker users

2007-09-20 Thread Ilpo Järvinen
Basically this change enables it, previously other undo_marker users were left with nothing. Reverse undo_marker logic completely to get it set right in CA_Loss. On the other hand, when spurious RTO is detected, clear it. Clearing might be too heavy for some scenarios but seems safe enough

[PATCH 7/9] [TCP] FRTO: Update sysctl documentation

2007-09-20 Thread Ilpo Järvinen
Since the SACK enhanced FRTO was added, the code has been under test numerous times so remove experimental claim from the documentation. Also be a bit more verbose about the usage. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] --- Documentation/networking/ip-sysctl.txt | 17 -

[PATCH 5/9] [TCP]: Cleanup tcp_tso_acked and tcp_clean_rtx_queue

2007-09-20 Thread Ilpo Järvinen
Implements following cleanups: - Comment re-placement (CodingStyle) - tcp_tso_acked() local (wrapper-like) variable removal (readability) - __-types removed (IMHO they make local variables jumpy looking and just was space) - acked - flag (naming conventions elsewhere in TCP code) - linebreak

[PATCH 8/9] [TCP]: Enable SACK enhanced FRTO (RFC4138) by default

2007-09-20 Thread Ilpo Järvinen
Most of the description that follows comes from my mail to netdev (some editing done): Main obstacle to FRTO use is its deployment as it has to be on the sender side where as wireless link is often the receiver's access link. Take initiative on behalf of unlucky receivers and enable it by default

[PATCH 9/9] [TCP]: Avoid clearing sacktag hint in trivial situations

2007-09-20 Thread Ilpo Järvinen
There's no reason to clear the sacktag skb hint when small part of the rexmit queue changes. Account changes (if any) instead when fragmenting/collapsing. RTO/FRTO do not touch SACKED_ACKED bits so no need to discard SACK tag hint at all. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] ---

Re: netif_rx will not free skb when I use ftp in kernel 2.6.22/2.6.21

2007-09-20 Thread Jay Cliburn
Chris Snook wrote: wrote: in function at_alloc_rx_buffers(), pci_unmap_page() and netif_rx() in function at_clean_rx_irq(), Okay, I didn't know you were talking about the atl1 driver. Are you using the in-tree driver in 2.6.22, or the pre-merge driver on sourceforge, or the vendor

[PATCH: 2.6.13-15-SMP 3/3] network: concurrently run softirq network code on SMP

2007-09-20 Thread john ye
Bottom Softirq Implementation. John Ye, 2007.08.27 Why this patch: Make kernel be able to concurrently execute softirq's net code on SMP system. Takes full advantages of SMP to handle more packets and greatly raises NIC throughput. The current kernel's net packet processing logic is: 1) The CPU

Re: [LARTC] ifb and ppp

2007-09-20 Thread jamal
On Thu, 2007-20-09 at 13:55 +0200, Patrick McHardy wrote: Please keep netdev and myself CCed. and me too (I am way behind on netdev) Frithjof Hammer wrote: Any further help/ideas? Sorry, I didnt follow the thread - what is the goal to be achieved with the setup? I misread the code, the

[PATCH V5 1/11] net/core: add a netdev notification for slave detach

2007-09-20 Thread Moni Shoua
A slave of a bonding master that wants to send a notification before going down should call netdev_slave_detach(). The handling of this notification will be done outside the context of unregister_netdevice() which is sometimes necessary, as with IPoIB slave for example. Signed-off-by: Moni Shoua

[PATCH V5 2/11] IB/ipoib: Notify the world before doing unregister

2007-09-20 Thread Moni Shoua
When the bonding device enslaves IPoIB devices it takes pointers to functions in the ib_ipoib module. This is fine as long as the ib_ipoib nodule remains loaded while the references to its functions exist. So, to help bonding do a cleanup on time, when the IPoIB net device is a slave of a bonding

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-20 Thread John W. Linville
On Wed, Sep 19, 2007 at 11:12:50PM +0100, Daniel Drake wrote: John W. Linville wrote: BTW: I fairly regularly get email from F7 users complaining about connection intermittancy and other bugs that we don't seem to have for the softmac driver (maybe stack related issues, of which I've fixed

[PATCH V5 3/11] IB/ipoib: Bound the net device to the ipoib_neigh structue

2007-09-20 Thread Moni Shoua
IPoIB uses a two layer neighboring scheme, such that for each struct neighbour whose device is an ipoib one, there is a struct ipoib_neigh buddy which is created on demand at the tx flow by an ipoib_neigh_alloc(skb-dst-neighbour) call. When using the bonding driver, neighbours are created by the

Re: Please pull 'ssb-drivers' branch of wireless-2.6

2007-09-20 Thread John W. Linville
On Wed, Sep 19, 2007 at 02:33:56PM -0700, Greg KH wrote: On Wed, Sep 19, 2007 at 04:44:28PM -0400, John W. Linville wrote: These patches build upon the SSB bus support added to net-2.6.24 to support the b43 wireless driver. Since Dave has that support in his tree, I'm asking him to merge

[PATCH V5 4/11] IB/ipoib: Verify address handle validity on send

2007-09-20 Thread Moni Shoua
When the bonding device senses a carrier loss of its active slave it replaces that slave with a new one. In between the times when the carrier of an IPoIB device goes down and ipoib_neigh is destroyed, it is possible that the bonding driver will send a packet on a new slave that uses an old

[PATCH V5 5/11] net/bonding: Enable bonding to enslave non ARPHRD_ETHER

2007-09-20 Thread Moni Shoua
This patch changes some of the bond netdevice attributes and functions to be that of the active slave for the case of the enslaved device not being of ARPHRD_ETHER type. Basically it overrides those setting done by ether_setup(), which are netdevice **type** dependent and hence might be not

[PATCH V5 6/11] net/bonding: Enable bonding to enslave netdevices not supporting set_mac_address()

2007-09-20 Thread Moni Shoua
This patch allows for enslaving netdevices which do not support the set_mac_address() function. In that case the bond mac address is the one of the active slave, where remote peers are notified on the mac address (neighbour) change by Gratuitous ARP sent by bonding when fail-over occurs (this is

[PATCH V5 7/11] net/bonding: Enable IP multicast for bonding IPoIB devices

2007-09-20 Thread Moni Shoua
Allow to enslave devices when the bonding device is not up. Over the discussion held at the previous post this seemed to be the most clean way to go, where it is not expected to cause instabilities. Normally, the bonding driver is UP before any enslavement takes place. Once a netdevice is UP, the

[PATCH V5 0/11] net/bonding: ADD IPoIB support for the bonding driver

2007-09-20 Thread Moni Shoua
This patch series is the fifth version (see below link to V4) of the suggested changes to the bonding driver so it would be able to support non ARPHRD_ETHER netdevices for its High-Availability (active-backup) mode. Patches 1-10 were originally submitted in V4 and patch 11 is an addition by

[PATCH V5 8/11] net/bonding: Handlle wrong assumptions that slave is always an Ethernet device

2007-09-20 Thread Moni Shoua
bonding sometimes uses Ethernet constants (such as MTU and address length) which are not good when it enslaves non Ethernet devices (such as InfiniBand). Signed-off-by: Moni Shoua monis at voltaire.com --- drivers/net/bonding/bond_main.c |3 ++- drivers/net/bonding/bond_sysfs.c | 19

PATCH V5 9/11] net/bonding: Delay sending of gratuitous ARP to avoid failure

2007-09-20 Thread Moni Shoua
Delay sending a gratuitous_arp when LINK_STATE_LINKWATCH_PENDING bit in dev-state field is on. This improves the chances for the arp packet to be transmitted. Signed-off-by: Moni Shoua monis at voltaire.com --- drivers/net/bonding/bond_main.c | 24 +---

[PATCH V5 10/11] net/bonding: Destroy bonding master when last slave is gone

2007-09-20 Thread Moni Shoua
When bonding enslaves non Ethernet devices it takes pointers to functions in the module that owns the slaves. In this case it becomes unsafe to keep the bonding master registered after last slave was unenslaved because we don't know if the pointers are still valid. Destroying the bond when

[PATCH V5 5/11] net/bonding: Enable bonding to enslave non ARPHRD_ETHER

2007-09-20 Thread Moni Shoua
This patch changes some of the bond netdevice attributes and functions to be that of the active slave for the case of the enslaved device not being of ARPHRD_ETHER type. Basically it overrides those setting done by ether_setup(), which are netdevice **type** dependent and hence might be not

[PATCH 11/11] bonding: Optionally allow ethernet slaves to keep own MAC

2007-09-20 Thread Moni Shoua
Update the don't change MAC of slaves functionality added in previous changes to be a generic option, rather than something tied to IB devices, as it's occasionally useful for regular ethernet devices as well. Adds fail_over_mac option (which is automatically enabled for IB slaves),

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-20 Thread John W. Linville
On Wed, Sep 19, 2007 at 11:08:16PM +0100, Daniel Drake wrote: I would like to this until 2.6.25 until I have had time to clear up some final issues and do more testing myself of zd1211rw-mac80211. I also think we need to discuss the rename... Renames being what they are, I was hoping to

Re: [PATCH - net-2.6.24 1/2] Introduce and use print_ip

2007-09-20 Thread Thomas Graf
* Joe Perches [EMAIL PROTECTED] 2007-09-19 23:53 This removes the uses of NIPQUAD and HIPQUAD in drivers/net and net IPV4 Use: DECLARE_IP_BUF(ipbuf); __be32 addr; print_ip(ipbuf, addr) Signed-off-by: Joe Perches [EMAIL PROTECTED] please pull from: git pull

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-20 Thread Daniel Drake
John W. Linville wrote: I know that you will argue that a rename is unnecessary if we simply port the existing driver to mac80211, which is certainly true. I just wonder if that is the least bumpy solution for users. At least with a new driver, if something doesn't work then the old driver is

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-20 Thread Maciej W. Rozycki
On Thu, 20 Sep 2007, Jeff Garzik wrote: You may be pleased (or less so) to hear that the version of sb1250-mac.c in your tree does not even build (because of 42d53d6be113f974d8152979c88e1061b953bd12) and the patch below does not address it. I ran out of time in the evening, but I will

Re: [LARTC] ifb and ppp

2007-09-20 Thread Frithjof Hammer
Sorry, I didnt follow the thread - what is the goal to be achieved with the setup? A simple ingress shaping on ppp0 (PPPOE DSL line). I want to replace my old imq ingress shaper in favor of ifb. My former script used iptables marks to classify the packets. My iptables marks are getting set,

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-20 Thread Randy Dunlap
On Wed, 19 Sep 2007 23:53:31 -0700 Joe Perches wrote: In the same vein as print_mac, the implementations introduce declaration macros: DECLARE_IP_BUF(var) DECLARE_IPV6_BUF(var) and functions: print_ip print_ipv6 print_ipv6_nofmt IPV4 Use:

Re: net-2.6.24 plans

2007-09-20 Thread Johannes Berg
On Thu, 2007-09-20 at 10:17 -0400, John W. Linville wrote: 2) ATMEL USB driver These are both really new. I think I'll transfer them to my wireless-2.6 tree, but still hold them back at least until 2.6.25. Also, atmel isn't even ported to mac80211 yet, is it? 3) NL80211 I need to

Re: net-2.6.24 plans

2007-09-20 Thread John W. Linville
On Wed, Sep 19, 2007 at 03:19:28PM -0700, David Miller wrote: So it looks like what's left is: 1) ATH5K driver 2) ATMEL USB driver These are both really new. I think I'll transfer them to my wireless-2.6 tree, but still hold them back at least until 2.6.25. 3) NL80211 I need to check w/

Re: bnx2 dirver's firmware images

2007-09-20 Thread Denys Vlasenko
On Wednesday 19 September 2007 22:43, Michael Chan wrote: On Wed, 2007-09-19 at 21:29 +0100, Denys Vlasenko wrote: Are you saying that you successfully run-tested it? I've only reviewed the code. Let's resolve these issues first before testing the code. Please test these two patches. I

[PATCH 0/3 Rev-4] Age Entry For IPv4 IPv6 Route Table

2007-09-20 Thread Varun Chandramohan
Hi Dave, Thanks for the comment. I have created another patch set as you have suggested. Your Comments: In avoiding the age initialization at routing cache insertion time, you make the value provided totally inaccurate and essentially useless especially the very first time the value is

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-20 Thread Joe Perches
On Thu, 2007-09-20 at 07:55 -0700, Randy Dunlap wrote: How large are the patches if you posted them for review instead of just referencing gits for them? (which cuts down on review possibilities) The v4 is ~130kb, the v6 ~35kb. There is a gitweb available at: print_ip:

[PATCH 1/3 Rev4] New attribute RTA_AGE

2007-09-20 Thread Varun Chandramohan
A new attribute RTA_AGE is added for the age value to be exported to userlevel using netlink Signed-off-by: Varun Chandramohan [EMAIL PROTECTED] --- include/linux/rtnetlink.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/rtnetlink.h

[PATCH 2/3 Rev4] Initilize and populate age field

2007-09-20 Thread Varun Chandramohan
The age field is filled with the current time at the time of creation of the route. When the routes are dumped then the age value stored in the route structure is subtracted from the current time value and the difference is the age expressed in secs. Signed-off-by: Varun Chandramohan [EMAIL

[PATCH 3/3 Rev4] Initialize and fill IPv6 route age

2007-09-20 Thread Varun Chandramohan
The age field of the ipv6 route structures are initilized with the current timeval at the time of route creation. When the route dump is called the route age value stored in the structure is subtracted from the present timeval and the difference is passed on as the route age. Signed-off-by:

Re: wrong arp query with policy routing

2007-09-20 Thread Chuck Ebbert
Is there a way to force linux to make an arp probe with the source ip belonging to the same subnet requesting ip? Umm, arp_filter? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [LARTC] ifb and ppp

2007-09-20 Thread Patrick McHardy
Frithjof Hammer wrote: Sorry, I didnt follow the thread - what is the goal to be achieved with the setup? A simple ingress shaping on ppp0 (PPPOE DSL line). I want to replace my old imq ingress shaper in favor of ifb. My former script used iptables marks to classify the packets. My

[PATCH][MIPS][7/7] AR7: ethernet

2007-09-20 Thread Matteo Croce
Driver for the cpmac 100M ethernet driver. Jeff, here is the meat ;) Signed-off-by: Matteo Croce [EMAIL PROTECTED] Signed-off-by: Eugene Konev [EMAIL PROTECTED] diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 6a0863e..28ba0dc 100644 --- a/drivers/net/Kconfig +++

Re: [PATCH V5 2/11] IB/ipoib: Notify the world before doing unregister

2007-09-20 Thread Roland Dreier
+ipoib_slave_detach(cpriv-dev); unregister_netdev(cpriv-dev); Maybe you already answered this before, but I'm still not clear why this notifier call can't just be added to the start of unregister_netdevice(), so we can avoid having driver needing to know anything

Re: [PATCH] RDMA/CMA: Use neigh_event_send() to initiate neighbour discovery.

2007-09-20 Thread Roland Dreier
Roland - can you please queue this up for 2.6.24? Done, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH]: Preliminary release of Sun Neptune driver

2007-09-20 Thread Ariel Hendel
Thanks Dave for your preliminary posting of the driver. I am copying Matheos Worku. Matheos is intimately familiar with the Neptune/NIU family of devices and their respective drivers. Not only he can be a good reviewer, he can also clarify issues around naming and so on. I agree that Neptune

Re: [PATCH 1/2] net/: all net/ cleanup with ARRAY_SIZE

2007-09-20 Thread rae l
On 9/17/07, David Miller [EMAIL PROTECTED] wrote: From: Denis Cheng [EMAIL PROTECTED] Date: Sun, 2 Sep 2007 18:30:17 +0800 Signed-off-by: Denis Cheng [EMAIL PROTECTED] You already submitted the net/ipv4/af_inet.c case seperately, so I had to remove it from this patch for it to apply

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-20 Thread Larry Finger
Daniel Drake wrote: John W. Linville wrote: If you are determined not to have it in 2.6.24 then I will relent. I will also suggest that Larry start sending any softmac bugs to you... :-) That's fine. You're on. BTW, I will let you be the primary tester of [PATCH] fix softmac lockdep

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-20 Thread Johannes Berg
On Thu, 2007-09-20 at 11:37 -0500, Larry Finger wrote: You're on. BTW, I will let you be the primary tester of [PATCH] fix softmac lockdep reports that Johannes posted earlier today. I see you were CC'd. I plan on testing it with bcm43xx, but I won't get to it for a couple of days. The

Re: [PATCH 2/3] netlink: the temp variable name max is ambiguous

2007-09-20 Thread rae l
On 9/17/07, David Miller [EMAIL PROTECTED] wrote: From: Denis Cheng [EMAIL PROTECTED] Date: Sun, 2 Sep 2007 03:45:58 +0800 with the macro max provided by linux/kernel.h, so changed its name to a more proper one: limit Signed-off-by: Denis Cheng [EMAIL PROTECTED] Not strictly

Re: net-2.6.24 plans

2007-09-20 Thread John W. Linville
On Thu, Sep 20, 2007 at 04:50:52PM +0200, Johannes Berg wrote: On Thu, 2007-09-20 at 10:17 -0400, John W. Linville wrote: 2) ATMEL USB driver These are both really new. I think I'll transfer them to my wireless-2.6 tree, but still hold them back at least until 2.6.25. Also, atmel

[PATCH 2.6.23][BNX2]: Add PHY workaround for 5709 A1.

2007-09-20 Thread Michael Chan
[BNX2]: Add PHY workaround for 5709 A1. Add the DIS_EARLY_DAC PHY workaround for 5709 A1. Without it, link sometimes does not come up. Update version to 1.6.5. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 854d80c..66eed22 100644 ---

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-20 Thread Jeff Garzik
Maciej W. Rozycki wrote: On Thu, 20 Sep 2007, Jeff Garzik wrote: You may be pleased (or less so) to hear that the version of sb1250-mac.c in your tree does not even build (because of 42d53d6be113f974d8152979c88e1061b953bd12) and the patch below does not address it. I ran out of time in the

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-20 Thread Davide Libenzi
On Wed, 19 Sep 2007, Nagendra Tomar wrote: The tcp_check_space() function calls tcp_new_space() only if the SOCK_NOSPACE bit is set in the socket flags. This is causing Edge Triggered EPOLLOUT events to be missed for TCP sockets, as the ep_poll_callback() is not called from the wakeup

Re: [PATCH: 2.6.13-15-SMP 3/3] network: concurrently run softirq network code on SMP

2007-09-20 Thread David Miller
The whole reason the queues are per-cpu is so that we do not have to touch remote processor state nor use locks of any kind whatsoever. With multi-queue networking cards becoming more and more available, which will split up the packet workload in hardware across all available cpus, there is less

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-20 Thread Ilpo Järvinen
On Thu, 20 Sep 2007, Joe Perches wrote: On Thu, 2007-09-20 at 07:55 -0700, Randy Dunlap wrote: How large are the patches if you posted them for review instead of just referencing gits for them? (which cuts down on review possibilities) The v4 is ~130kb, the v6 ~35kb. There is a

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-20 Thread Davide Libenzi
On Thu, 20 Sep 2007, Eric Dumazet wrote: Does it means that with your patch each ACK on a ET managed socket will trigger an epoll event ? Maybe your very sensitive high throuput appication needs to set a flag or something at socket level to ask for such a behavior. The default should

Re: [PATCH 2.6.23][BNX2]: Add PHY workaround for 5709 A1.

2007-09-20 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Thu, 20 Sep 2007 11:07:13 -0700 [BNX2]: Add PHY workaround for 5709 A1. Add the DIS_EARLY_DAC PHY workaround for 5709 A1. Without it, link sometimes does not come up. Update version to 1.6.5. Signed-off-by: Michael Chan [EMAIL PROTECTED]

Re: [Bug, PATCH and another Bug] Was: Fix refcounting problem with netif_rx_reschedule()

2007-09-20 Thread David Miller
From: Krishna Kumar2 [EMAIL PROTECTED] Date: Thu, 20 Sep 2007 11:24:01 +0530 Ran 4/16/64 thread iperf on latest bits with this patch and no issues after 30 mins. I used to consistently get the bug within 1-2 mins with just 4 threads prior to this patch. Tested-by: Krishna Kumar [EMAIL

Re: [PATCH: 2.6.13-15-SMP 3/3] network: concurrently run softirq network code on SMP

2007-09-20 Thread Stephen Hemminger
On Thu, 20 Sep 2007 21:04:16 +0800 john ye [EMAIL PROTECTED] wrote: Bottom Softirq Implementation. John Ye, 2007.08.27 Why this patch: Make kernel be able to concurrently execute softirq's net code on SMP system. Takes full advantages of SMP to handle more packets and greatly raises NIC

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-20 Thread Maciej W. Rozycki
' by myself. Sorry for the noise. Maciej patch-netdev-2.6.23-rc6-20070920-sb1250-mac-typedef-9 diff -up --recursive --new-file linux-netdev-2.6.23-rc6-20070920.macro/drivers/net/sb1250-mac.c linux-netdev-2.6.23-rc6-20070920/drivers/net/sb1250-mac.c --- linux-netdev-2.6.23-rc6-20070920.macro/drivers

Re: [PATCH 1/9] [TCP]: Maintain highest_sack accurately to the highest skb

2007-09-20 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 20 Sep 2007 15:17:44 +0300 In general, it should not be necessary to call tcp_fragment for already SACKed skbs, but it's better to be safe than sorry. And indeed, it can be called from sacktag when a DSACK arrives or some ACK (with SACK)

Re: [PATCH 2/9] [TCP]: Make fackets_out accurate

2007-09-20 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 20 Sep 2007 15:17:45 +0300 Substraction for fackets_out is unconditional when snd_una advances, thus there's no need to do it inside the loop. Just make sure correct bounds are honored. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Applied.

Re: [PATCH 3/9] [TCP]: clear_all_retrans_hints prefixed by tcp_

2007-09-20 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 20 Sep 2007 15:17:46 +0300 In addition, fix its function comment spacing. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Applied. -/*from STCP */ -static inline void clear_all_retrans_hints(struct tcp_sock *tp){ +/* from STCP */ +static

Re: [PATCH 4/9] [TCP]: Move accounting from tso_acked to clean_rtx_queue

2007-09-20 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 20 Sep 2007 15:17:47 +0300 The accounting code is pretty much the same, so it's a shame we do it in two places. I'm not too sure if added fully_acked check in MTU probing is really what we want perhaps the added end_seq could be used in the

Re: [PATCH 5/9] [TCP]: Cleanup tcp_tso_acked and tcp_clean_rtx_queue

2007-09-20 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 20 Sep 2007 15:17:48 +0300 Implements following cleanups: - Comment re-placement (CodingStyle) - tcp_tso_acked() local (wrapper-like) variable removal (readability) - __-types removed (IMHO they make local variables jumpy looking and just

Re: [PATCH 6/9] [TCP] FRTO: Improve interoperability with other undo_marker users

2007-09-20 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 20 Sep 2007 15:17:49 +0300 Basically this change enables it, previously other undo_marker users were left with nothing. Reverse undo_marker logic completely to get it set right in CA_Loss. On the other hand, when spurious RTO is detected, clear

Re: [PATCH 7/9] [TCP] FRTO: Update sysctl documentation

2007-09-20 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 20 Sep 2007 15:17:50 +0300 Since the SACK enhanced FRTO was added, the code has been under test numerous times so remove experimental claim from the documentation. Also be a bit more verbose about the usage. Signed-off-by: Ilpo Järvinen

Re: [PATCH 8/9] [TCP]: Enable SACK enhanced FRTO (RFC4138) by default

2007-09-20 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 20 Sep 2007 15:17:51 +0300 Most of the description that follows comes from my mail to netdev (some editing done): ... Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Applied, thanks Ilpo! - To unsubscribe from this list: send the line

Re: [PATCH 9/9] [TCP]: Avoid clearing sacktag hint in trivial situations

2007-09-20 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 20 Sep 2007 15:17:52 +0300 There's no reason to clear the sacktag skb hint when small part of the rexmit queue changes. Account changes (if any) instead when fragmenting/collapsing. RTO/FRTO do not touch SACKED_ACKED bits so no need to discard

Re: [git patches] net driver updates

2007-09-20 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Thu, 20 Sep 2007 03:26:10 -0400 Please pull from the 'upstream' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream to receive the following changes: Pulled into net-2.6.24 and pushed out, thanks Jeff! - To

[PATCH 3/7] CAN: Add raw protocol

2007-09-20 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED] Signed-off-by: Urs Thuermann [EMAIL PROTECTED] --- include/linux/can/raw.h | 31 + net/can/Kconfig | 26 + net/can/Makefile|3 net/can/raw.c | 828

[PATCH 1/7] CAN: Allocate protocol numbers for PF_CAN

2007-09-20 Thread Urs Thuermann
This patch adds a protocol/address family number, ARP hardware type, ethernet packet type, and a line discipline number for the SocketCAN implementation. Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED] Signed-off-by: Urs Thuermann [EMAIL PROTECTED] --- include/linux/if_arp.h |1 +

[PATCH 7/7] CAN: Add documentation

2007-09-20 Thread Urs Thuermann
This patch adds documentation for the PF_CAN protocol family. Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED] Signed-off-by: Urs Thuermann [EMAIL PROTECTED] --- Documentation/networking/00-INDEX |2 Documentation/networking/can.txt | 635 ++ 2 files

[PATCH 0/7] CAN: Add new PF_CAN protocol family, try #7

2007-09-20 Thread Urs Thuermann
Hello Dave, hello Patrick, this is the seventh post of the patch series that adds the PF_CAN protocol family for the Controller Area Network. Since our last post we have changed the following: * Changes suggested by Patrick: - protect proto_tab[] by a lock. - add _rcu to some hlist

[PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-20 Thread Urs Thuermann
This patch adds the virtual CAN bus (vcan) network driver. The vcan device is just a loopback device for CAN frames, no real CAN hardware is involved. Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED] Signed-off-by: Urs Thuermann [EMAIL PROTECTED] --- drivers/net/Makefile |1

[PATCH 4/7] CAN: Add broadcast manager (bcm) protocol

2007-09-20 Thread Urs Thuermann
This patch adds the CAN broadcast manager (bcm) protocol. Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED] Signed-off-by: Urs Thuermann [EMAIL PROTECTED] --- include/linux/can/bcm.h | 65 + net/can/Kconfig | 28 net/can/Makefile|3 net/can/bcm.c | 1784

[PATCH 6/7] CAN: Add maintainer entries

2007-09-20 Thread Urs Thuermann
This patch adds entries in the CREDITS and MAINTAINERS file for CAN. Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED] Signed-off-by: Urs Thuermann [EMAIL PROTECTED] --- CREDITS | 16 MAINTAINERS |9 + 2 files changed, 25 insertions(+) Index:

Re: [PATCH 9/9] [TCP]: Avoid clearing sacktag hint in trivial situations

2007-09-20 Thread Ilpo Järvinen
On Thu, 20 Sep 2007, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 20 Sep 2007 15:17:52 +0300 There's no reason to clear the sacktag skb hint when small part of the rexmit queue changes. Account changes (if any) instead when fragmenting/collapsing. RTO/FRTO do not

[git patches] net driver fixes

2007-09-20 Thread Jeff Garzik
This includes the sky2 update that you and sch discussed. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/myri10ge/myri10ge.c |3 + drivers/net/phy/phy.c

Please pull 'nl80211' branch of wireless-2.6

2007-09-20 Thread John W. Linville
Dave, This patch adds the basic nl80211 infrastructure. Thanks! John --- Patch is available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/nl80211/0001-nl80211-add-netlink-interface-to-cfg80211.patch --- The following changes since commit

Re: 2.6.23-rc6-mm1

2007-09-20 Thread Andrew Morton
On Thu, 20 Sep 2007 21:42:44 +0530 Kamalesh Babulal [EMAIL PROTECTED] wrote: ... i have tested the change with cross compiler for power405 with the same .config with which the build problem is solved, but the build fails with another error CC [M] drivers/net/mace.o

[PATCH] sky2: be more selective about FIFO watchdog

2007-09-20 Thread Stephen Hemminger
Be more selective about when to enable the ram buffer watchdog code. It is unnecessary on XL A3 or later revs, and with Yukon FE the buffer is so small (4K) that the watchdog detects false positives. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/drivers/net/sky2.c2007-09-19

Re: Pull request for 'r8169-for-jeff-20070919' branch

2007-09-20 Thread Chuck Ebbert
On 09/19/2007 03:56 PM, Francois Romieu wrote: Please pull from branch 'r8169-for-jeff-20070919' in repository People are still reporting hangs with this card in 2.6.22.6, are there any fixes appropriate for that? - To unsubscribe from this list: send the line unsubscribe netdev in the body

  1   2   >