Re: [PATCH 2.6.25] add bnx2x driver for BCM57710 - bnx2x.c

2007-11-16 Thread Eliezer Tamir
Stephen, Thank you for taking the time to go over this. Stephen Hemminger wrote: 1. Please use dev_err() to help user figure out which board has problem: OK 2. Use new MAC_ADDR() rather than OK 3. The reset task logic needs more cleanup/protection. OK 4. Rather than hard coding mac

[PATCH 1/2] [IPV4] SNMP: Decrement of UDP InDatagrams for bad checksum

2007-11-16 Thread Wang Chen
Dave If there is no socket filter, a bad checksum udp packet will be queued and ready for user to read. At the same time the InDatagrams is increased. So we need to decrement InDatagrams when recvmsg() or poll() notice the bad checksum. Seems Gerrit had fix it a year

Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0

2007-11-16 Thread Jonas Danielsson
2007/11/16, David Miller [EMAIL PROTECTED]: From: Jonas Danielsson [EMAIL PROTECTED] Date: Thu, 15 Nov 2007 22:40:13 +0100 Is there a reason that the target hardware address isn't the target hardware address? Because of this, in cases where a choice can be made Linux will advertise

Re: [Bugme-new] [Bug 9391] New: Netgear GA320T(tg3) strange errors and non-workingness

2007-11-16 Thread Jarek Poplawski
On 16-11-2007 03:18, Andrew Morton wrote: On Thu, 15 Nov 2007 18:04:19 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9391 Summary: Netgear GA320T(tg3) strange errors and non-workingness Product: Drivers Version: 2.5

Re : Bug in using inet_lookup ()

2007-11-16 Thread Nj A
Hello, Please show at least one bug trace when inet_lookup(tcp_hashinfo, 0, 0, 0, 0, 0) fails :) Trying this the system hangs :-( (setting panic* doesn't change more). However, using (tcp_hashinfo, ip_src, p_src, ip_dst, p_dst, 0) gives the following oops: BUG: unable to handle kernel NULL

Re: [PATCH] NET : convert ip_rt_acct to per_cpu variables

2007-11-16 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 16 Nov 2007 09:59:03 +0100 [PATCH] NET : NET_CLS_ROUTE : convert ip_rt_acct to per_cpu variables ip_rt_acct needs 4096 bytes per cpu to perform some accounting. It is actually allocated as a single huge array [4096*NR_CPUS] (rounded up to a

Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0

2007-11-16 Thread David Miller
From: Jonas Danielsson [EMAIL PROTECTED] Date: Fri, 16 Nov 2007 09:30:11 +0100 2007/11/16, David Miller [EMAIL PROTECTED]: From: Jonas Danielsson [EMAIL PROTECTED] Date: Thu, 15 Nov 2007 22:40:13 +0100 Is there a reason that the target hardware address isn't the target hardware

Re: [PATCH] NET : convert ip_rt_acct to per_cpu variables

2007-11-16 Thread Eric Dumazet
On Fri, 16 Nov 2007 10:35:46 +0100 Eric Dumazet [EMAIL PROTECTED] wrote: On Fri, 16 Nov 2007 01:12:43 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 16 Nov 2007 09:59:03 +0100 [PATCH] NET : NET_CLS_ROUTE : convert ip_rt_acct to

Re: [PATCH 1/2] [IPV4] SNMP: Decrement of UDP InDatagrams for bad checksum

2007-11-16 Thread Gerrit Renker
| If there is no socket filter, a bad checksum udp packet will be queued and | ready for user to read. At the same time the InDatagrams is increased. | So we need to decrement InDatagrams when recvmsg() or poll() notice the | bad checksum. | | Seems Gerrit had fix it a year

[PATCH] NET : Corrects a bug in ip_rt_acct_read()

2007-11-16 Thread Eric Dumazet
Hi David Before the patch to convert ip_rt_acct to percpu storage, I believe this bug should be corrected. (against net-2.6.25 but might apply on previous kernels as well) Thank you [PATCH] NET : Corrects a bug in ip_rt_acct_read() It seems that stats of cpu 0 are counted twice, since

Re: [PATCH] NET : Corrects a bug in ip_rt_acct_read()

2007-11-16 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 16 Nov 2007 11:25:19 +0100 [PATCH] NET : Corrects a bug in ip_rt_acct_read() It seems that stats of cpu 0 are counted twice, since for_each_possible_cpu() is looping on all possible cpus, including 0 Before percpu conversion of ip_rt_acct,

FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-16 Thread Joonwoo Park
2007/11/11, Joonwoo Park [EMAIL PROTECTED]: IMHO even though netdevice is in the promiscuous mode, we should receive all of ingress packets. This disable the vlan filtering feature when a vlan hw accel configured e1000 device goes into promiscuous mode. This make packets visible to sniffers

Re: Mcast packet loss 2.6.8.1 kernel

2007-11-16 Thread Eric Dumazet
On Fri, 16 Nov 2007 09:22:13 +0100 Bernd Eckenfels [EMAIL PROTECTED] wrote: In article [EMAIL PROTECTED] you wrote: output of netstat after startup and before tx of packets /flash/sbin/netstat -s ... error parsing /proc/net/snmp: Success Could you sent me (net-tools maintainer) the

[PATCH net-2.6.25] [TCP]: Correct DSACK check placing

2007-11-16 Thread Ilpo Järvinen
Previously one of the in-block skip branches was missing it. Also, drop it from tail-fully-processed case because the next iteration will do exactly the same thing, i.e., process the SACK block that contains the DSACK information. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] ---

[PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-11-16 Thread Urs Thuermann
This patch adds the virtual CAN bus (vcan) network driver. The vcan device is just a loopback device for CAN frames, no real CAN hardware is involved. Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED] Signed-off-by: Urs Thuermann [EMAIL PROTECTED] --- drivers/net/Makefile |1

[PATCH 0/7] CAN: New PF_CAN protocol family for 2.6.25, update

2007-11-16 Thread Urs Thuermann
Hello Dave, hello Patrick, this patch series adds the PF_CAN protocol family for the Controller Area Network. Since our last post we have changed: * Remove vcan_open() and vcan_stop(). * return NETDEV_TX_OK instead of 0. * Add can_ prefix to some global vars. * Remove all debug code completely.

[PATCH 7/7] CAN: Add documentation

2007-11-16 Thread Urs Thuermann
This patch adds documentation for the PF_CAN protocol family. Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED] Signed-off-by: Urs Thuermann [EMAIL PROTECTED] --- Documentation/networking/00-INDEX |2 Documentation/networking/can.txt | 629 ++ 2 files

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-16 Thread Jon Nelson
I get a segmentation fault. Should this patch be in addition to the one from bug 9382? http://bugzilla.kernel.org/attachment.cgi?id=13555action=view -- Jon - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 4/7] CAN: Add broadcast manager (bcm) protocol

2007-11-16 Thread Urs Thuermann
This patch adds the CAN broadcast manager (bcm) protocol. Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED] Signed-off-by: Urs Thuermann [EMAIL PROTECTED] --- include/linux/can/bcm.h | 65 + net/can/Kconfig | 13 net/can/Makefile|3 net/can/bcm.c | 1561

Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0

2007-11-16 Thread Benny Amorsen
DM == David Miller [EMAIL PROTECTED] writes: Reply: Opcode: reply (0x0002) Sender HW: 00:AA.00:AA:00:AA Sender IP: 192.168.0.1 Target HW: 00:AA:00:AA:00:AA Target IP:192.168.0.1 DM And this is exactly a sensible response in my opinion. Why send the reply at all? Sending a unicast

[PATCH 3/6 net-2.6.25][RAW] Introduce raw_hashinfo structure

2007-11-16 Thread Pavel Emelyanov
The ipv4/raw.c and ipv6/raw.c contain many common code (most of which is proc interface) which can be consolidated. Most of the places to consolidate deal with the raw sockets hashtable, so introduce a struct raw_hashinfo which describes the raw sockets hash. Signed-off-by: Pavel Emelyanov

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-16 Thread Stephen Hemminger
On Fri, 16 Nov 2007 10:21:25 -0600 Jon Nelson [EMAIL PROTECTED] wrote: I get a segmentation fault. Should this patch be in addition to the one from bug 9382? http://bugzilla.kernel.org/attachment.cgi?id=13555action=view Yes. The new patch adds just recomputes the rx buf size in one place,

Re: [Bugme-new] [Bug 9391] New: Netgear GA320T(tg3) strange errors and non-workingness

2007-11-16 Thread Michael Chan
Jon Nelson wrote: The lspci is exactly as it was output. The dmesg is shortened only slightly. The kernel is the latest available for openSUSE 10.3. No MSI because this is an Athlon XP (read: 32bit, single core, regular old 33MHz, 32bit PCI). The lspci doesn't look correct to me either.

Re: Re : Bug in using inet_lookup ()

2007-11-16 Thread Evgeniy Polyakov
On Fri, Nov 16, 2007 at 09:47:08AM +, Nj A ([EMAIL PROTECTED]) wrote: Hello, Please show at least one bug trace when inet_lookup(tcp_hashinfo, 0, 0, 0, 0, 0) fails :) Trying this the system hangs :-( (setting panic* doesn't change more). Your code below can not work - you _never_

Re: [PATCH] NET : convert ip_rt_acct to per_cpu variables

2007-11-16 Thread Eric Dumazet
On Fri, 16 Nov 2007 01:12:43 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 16 Nov 2007 09:59:03 +0100 [PATCH] NET : NET_CLS_ROUTE : convert ip_rt_acct to per_cpu variables ip_rt_acct needs 4096 bytes per cpu to perform some

[PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-16 Thread Eric Dumazet
Hello David This patch against net-2.6.25 is another step to get a more resistant ip route cache. Thank you [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue Every 600 seconds (ip_rt_secret_interval), a softirq flush of the whole ip route cache is triggered.

[PATCH 2/7] CAN: Add PF_CAN core module

2007-11-16 Thread Urs Thuermann
Group Electronic Research + * All rights reserved. + * + * Send feedback to [EMAIL PROTECTED] + * + */ + +#ifndef CAN_CORE_H +#define CAN_CORE_H + +#include linux/can.h +#include linux/skbuff.h +#include linux/netdevice.h + +#define CAN_VERSION 20071116 + +/* increment this number each time you change

[PATCH 6/7] CAN: Add maintainer entries

2007-11-16 Thread Urs Thuermann
This patch adds entries in the CREDITS and MAINTAINERS file for CAN. Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED] Signed-off-by: Urs Thuermann [EMAIL PROTECTED] --- CREDITS | 16 MAINTAINERS |9 + 2 files changed, 25 insertions(+) Index:

[PATCH 1/7] CAN: Allocate protocol numbers for PF_CAN

2007-11-16 Thread Urs Thuermann
This patch adds a protocol/address family number, ARP hardware type, ethernet packet type, and a line discipline number for the SocketCAN implementation. Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED] Signed-off-by: Urs Thuermann [EMAIL PROTECTED] --- include/linux/if.h |4 +++-

[PATCH 4/6 net-2.6.25][RAW] Consolidate proto-hash callback

2007-11-16 Thread Pavel Emelyanov
Having the raw_hashinfo it's easy to consolidate the raw[46]_hash functions. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/include/net/raw.h b/include/net/raw.h index 70b27c7..43f1e3c 100644 --- a/include/net/raw.h +++ b/include/net/raw.h @@ -39,4 +39,6 @@ extern int

Re: [Bugme-new] [Bug 9391] New: Netgear GA320T(tg3) strange errors and non-workingness

2007-11-16 Thread Jon Nelson
On 11/16/07, Jarek Poplawski [EMAIL PROTECTED] wrote: On 16-11-2007 03:18, Andrew Morton wrote: On Thu, 15 Nov 2007 18:04:19 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9391 Summary: Netgear GA320T(tg3) strange errors and non-workingness

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-11-16 Thread Urs Thuermann
David Miller [EMAIL PROTECTED] writes: I really frown upon these local debugging macros people tend to want to submit with their changes. It really craps up the tree, even though it might be useful to you. We have now removed the debug code completely. The code is quite stable and we won't

Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-16 Thread Herbert Xu
On Fri, Nov 16, 2007 at 08:49:02PM +0900, Joonwoo Park wrote: Not anymore about just e1000 :) I made an another patch with different approach which doesn't fix nic driver. In addition, this patch does disable all hw vlan acceleration features (rx, tx, filter) for promiscuous netdevice. (It

Re: [PATCH 6/6 net-2.6.25][RAW] Consolidate proc interface

2007-11-16 Thread YOSHIFUJI Hideaki / 吉藤英明
NAK. In article [EMAIL PROTECTED] (at Fri, 16 Nov 2007 17:19:27 +0300), Pavel Emelyanov [EMAIL PROTECTED] says: @@ -858,7 +852,7 @@ static struct sock *raw_get_first(struct seq_file *seq) ++state-bucket) { struct hlist_node *node; -

[PATCH 6/6 net-2.6.25][RAW] Consolidate proc interface

2007-11-16 Thread Pavel Emelyanov
Both ipv6/raw.c and ipv4/raw.c use the seq files to walk through the raw sockets hash and show them. The walking code is rather huge, but is identical in both cases. The difference is the hash table to walk over. Make the -open store the needed hash table on the allocated raw_iter_state and

[PATCH 5/6 net-2.6.25][RAW] Consolidate proto-unhash callback

2007-11-16 Thread Pavel Emelyanov
Same as the -hash one, this is easily consolidated. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/include/net/raw.h b/include/net/raw.h index 43f1e3c..81a1773 100644 --- a/include/net/raw.h +++ b/include/net/raw.h @@ -40,5 +40,6 @@ extern void raw_proc_exit(void); #endif

Re: [RFC PATCH 09/10] [TCP]: Rewrite SACK block processing sack_recv_cache use

2007-11-16 Thread Ilpo Järvinen
On Thu, 15 Nov 2007, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 15 Nov 2007 15:37:33 +0200 Key points of this patch are: - In case new SACK information is advance only type, no skb processing below previously discovered highest point is done -

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-16 Thread Benny Amorsen
DM == David Miller [EMAIL PROTECTED] writes: DM When the user does a recvmsg() or a poll() on the socket, we will DM notice the bad checksum then and increment InErrors. We could in DM this case correct the InDatagrams counter by decrementing it in DM this case. Does that mean that InDatagrams

Re: [Bugme-new] [Bug 9384] New: Appletalk packets are delivered to the last interface FD_SET

2007-11-16 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 15, 2007 at 03:49:35PM -0800, David Miller escreveu: From: Andrew Morton [EMAIL PROTECTED] Date: Thu, 15 Nov 2007 02:12:19 -0800 Most recent kernel where this bug did not occur: 2.6.10. Maybe 2.6.15? It was in 2.6.18 along with bug 7421 which caused me to disable netatalk

[PATCH] NET : convert ip_rt_acct to per_cpu variables

2007-11-16 Thread Eric Dumazet
Hi David I am chasing NR_CPUS syndrom for your NR_CPUS=4096 machines :) (Feel free to give me an account on one of them just for fun) I made this patch but have no idea if it actually works (only compile tested) because I dont know how to use this CONFIG_NET_CLS_ROUTE stuff Thank you [PATCH]

[PATCH,RFC] ep93xx_eth: conversion to phylib framework

2007-11-16 Thread Herbert Valerio Riedel
Currently, the ep93xx_eth driver doesn't care about the PHY state, but it should, in order to tell the MAC when full duplex operation is required; failure to do so causes degraded performance on full duplex links. This patch implements proper PHY handling via the phylib framework: - clean up

Re: [PATCH] NET : convert ip_rt_acct to per_cpu variables

2007-11-16 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 16 Nov 2007 11:58:52 +0100 [PATCH] NET : NET_CLS_ROUTE : convert ip_rt_acct to per_cpu variables ip_rt_acct needs 4096 bytes per cpu to perform some accounting. It is actually allocated as a single huge array [4096*NR_CPUS] (rounded up to a

Re: [PATCH 6/6 net-2.6.25][RAW] Consolidate proc interface

2007-11-16 Thread Pavel Emelyanov
YOSHIFUJI Hideaki wrote: NAK. In article [EMAIL PROTECTED] (at Fri, 16 Nov 2007 17:19:27 +0300), Pavel Emelyanov [EMAIL PROTECTED] says: @@ -858,7 +852,7 @@ static struct sock *raw_get_first(struct seq_file *seq) ++state-bucket) { struct hlist_node

Re: FW: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-16 Thread Patrick McHardy
Herbert Xu wrote: BTW, how does the VLAN TX acceleration work at all? It's using skb-cb to carry the tags but then calls dev_queue_xmit. Once you do that packet schedulers can scribble all over skb-cb. Also vlan_skb_recv should be moved out-of-line. It's absolutely humongous. It'll generate

[PATCH 1/6 net-2.6.25] IPv4 RAW: Compact the API for the kernel

2007-11-16 Thread Pavel Emelyanov
The raw sockets functions are explicitly used from inside the kernel in two places: 1. in ip_local_deliver_finish to intercept skb-s 2. in icmp_error For this purposes many functions and even data structures, that are naturally internal for raw protocol, are exported. Compact the API to two

[PATCH 1/9] cxgb3 - fix MSI-X failure path

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Return error code when msi-x settings fail. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/cxgb3/cxgb3_main.c

[PATCH 2/9] cxgb3 - Use wild card for PCI vendor ID match

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Vendor ID is not necessarily set to 1. Use Vendor Id wild card for PCI device matching Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_main.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff

[PATCH 3/9] cxgb3 - Fix resources release.

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Remove sysfs entries before unregistering the net devices. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_main.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/cxgb3/cxgb3_main.c

[PATCH 4/9] cxgb3 - Add EEH support

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Add PCI recovery support Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_main.c | 107 1 files changed, 107 insertions(+), 0 deletions(-) diff --git a/drivers/net/cxgb3/cxgb3_main.c

[PATCH 5/9] cxgb3 - FW upgrade

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Bump up FW version to 5.0. Do not downgrade FW within the same major version range. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/t3_hw.c | 10 +++--- drivers/net/cxgb3/version.h |4 ++-- 2 files changed, 9 insertions(+), 5

[PATCH 0/9] cxgb3 - driver update

2007-11-16 Thread Divy Le Ray
Jeff, Dave, I'm submitting a patch series for inclusion in 2.6.25. The patches are built against netdev#upstream. Here is a brief description: - Fix error path when requesting MSI-X resources - Use wild card for PCI Vendor ID - Fix sysfs resource release - Add PCI error recovery support - FW

[PATCH 6/9] cxgb3 - fix interaction with pktgen

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Do not use skb-cb to stash unmap info, save the info to the descriptor state. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/sge.c | 82 +++ 1 files changed, 40 insertions(+), 42 deletions(-)

[PATCH 7/9] cxgb3 - sysfs methods clean up

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Remove unused argument in sysfs methods Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_main.c | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/cxgb3/cxgb3_main.c

[PATCH 9/9] cxgb3 - Fix I/O synchronization

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Synchronize memory access before ringing the Tx door bell. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/sge.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/cxgb3/sge.c

[PATCH 8/9] cxgb3 - HW set up updates

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Disable PEX errors. The HW generates false positives. Update RSS hash function to a symmetric algorithm. Update T3C HW support Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_main.c |2 +- drivers/net/cxgb3/regs.h | 22

Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0

2007-11-16 Thread Bill Fink
On Fri, 16 Nov 2007, David Miller wrote: From: Jonas Danielsson [EMAIL PROTECTED] Date: Fri, 16 Nov 2007 09:30:11 +0100 2007/11/16, David Miller [EMAIL PROTECTED]: From: Jonas Danielsson [EMAIL PROTECTED] Date: Thu, 15 Nov 2007 22:40:13 +0100 Is there a reason that the target

[PATCH 3/7] CAN: Add raw protocol

2007-11-16 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-off-by: Oliver Hartkopp [EMAIL PROTECTED] Signed-off-by: Urs Thuermann [EMAIL PROTECTED] --- include/linux/can/raw.h | 31 + net/can/Kconfig | 11 net/can/Makefile|3 net/can/raw.c | 763

[PATCH 2/6 net-2.6.25] IPv6 RAW: Compact the API for the kernel

2007-11-16 Thread Pavel Emelyanov
Same as in the previous patch for ipv4, compact the API and hide hash table and rwlock inside the raw.c file. Plus fix some bad places from checkpatch.pl point of view (assignments inside if()). Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/include/net/rawv6.h

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-16 Thread Simon Horman
On Fri, Nov 16, 2007 at 05:40:27PM +0100, Eric Dumazet wrote: Hello David This patch against net-2.6.25 is another step to get a more resistant ip route cache. Thank you [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue Every 600 seconds

Re: [Bugme-new] [Bug 9391] New: Netgear GA320T(tg3) strange errors and non-workingness

2007-11-16 Thread Jarek Poplawski
Jon Nelson wrote, On 11/16/2007 03:08 PM: ... The lspci is exactly as it was output. The dmesg is shortened only slightly. The kernel is the latest available for openSUSE 10.3. No MSI because this is an Athlon XP (read: 32bit, single core, regular old 33MHz, 32bit PCI). The interrupts look

Re: Netconsole and logging everything from /dev/console

2007-11-16 Thread Matt Mackall
On Fri, Nov 16, 2007 at 06:43:15PM +0100, Martin Michlmayr wrote: I'm supporting a number of consumer devices (e.g. small NAS devices) in Debian. They typically don't export the serial console and don't have any other output devices. We perform the installation via SSH on such devices and

Netconsole and logging everything from /dev/console

2007-11-16 Thread Martin Michlmayr
I'm supporting a number of consumer devices (e.g. small NAS devices) in Debian. They typically don't export the serial console and don't have any other output devices. We perform the installation via SSH on such devices and start SSH automatically when the system boots so people can login. This

ping6 sets IPV6_PMTUDISC_DO option on multicast packets

2007-11-16 Thread Tushar Gohad
Yoshifuji-san, I noticed that ping6 forces the IPV6_PMTUDISC_DO option on packets sent to multicast destinations. Is this a requirement? Due to the following check recently introduced in the ip6_fragment() code, multicast packets that are over PMTU in size are never sent out, since ping6

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-16 Thread Eric Dumazet
Simon Horman a écrit : Is it ever neccessary to call cond_resched() if rt_hash_table[i].chain is NULL? If not, the following looks cleaner to my eyes: for (i = 0; i = rt_hash_mask; i++) { rth = rt_hash_table[i].chain; if (!rth)

Re: [PATCH 2/9] cxgb3 - Use wild card for PCI vendor ID match

2007-11-16 Thread Divy Le Ray
Divy Le Ray wrote: From: Divy Le Ray [EMAIL PROTECTED] Vendor ID is not necessarily set to 1. This patch modifies the sub-device id, not the vendor id ... Use Vendor Id wild card for PCI device matching Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_main.c |

[PATCH 2/9 RESEND] cxgb3 - Use wild card for PCI subdevice ID match

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Subdevice ID is not necessarily set to 1. Use wild card for PCI device matching Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_main.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-11-16 Thread David Miller
From: Urs Thuermann [EMAIL PROTECTED] Date: 16 Nov 2007 15:33:08 +0100 I am not aware of any useful kernel facilities to replace our debug macros, i.e. printing of debug messages, controlled by a bit mask passed in as a module parameter, hexdumping of fames, etc. Of course, there are other

Re: [PATCH 0/7] CAN: New PF_CAN protocol family for 2.6.25, update

2007-11-16 Thread David Miller
From: Urs Thuermann [EMAIL PROTECTED] Date: Fri, 16 Nov 2007 16:02:45 +0100 this patch series adds the PF_CAN protocol family for the Controller Area Network. Since our last post we have changed: * Remove vcan_open() and vcan_stop(). * return NETDEV_TX_OK instead of 0. * Add can_ prefix

Re: [PATCH net-2.6.25] [TCP]: Correct DSACK check placing

2007-11-16 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Fri, 16 Nov 2007 17:29:46 +0200 (EET) Previously one of the in-block skip branches was missing it. Also, drop it from tail-fully-processed case because the next iteration will do exactly the same thing, i.e., process the SACK block that contains

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-16 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 16 Nov 2007 08:47:06 -0800 On Fri, 16 Nov 2007 10:21:25 -0600 Jon Nelson [EMAIL PROTECTED] wrote: I get a segmentation fault. Should this patch be in addition to the one from bug 9382?

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-16 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 16 Nov 2007 17:40:27 +0100 + unsigned long fake = 0, *flag_ptr; ... + /* + * This is a fast version of : + * if (process_context need_resched()) + */ + if

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-16 Thread Jon Nelson
On 11/16/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Fri, 16 Nov 2007 10:21:25 -0600 Jon Nelson [EMAIL PROTECTED] wrote: I get a segmentation fault. Should this patch be in addition to the one from bug 9382? http://bugzilla.kernel.org/attachment.cgi?id=13555action=view Yes. The

Re: [PATCH 4/5] udp: memory limitation by using udp_mem

2007-11-16 Thread Hideo AOKI
Herbert Xu wrote: On Thu, Nov 15, 2007 at 03:23:53PM -0800, David Miller wrote: We don't have tests all over the place to see if a socket is TCP or DCCP or SCTP in order to implement memory accounting there, because we did it for connection oriented protocols cleanly, seperating things via

Re: [PATCH 4/5] udp: memory limitation by using udp_mem

2007-11-16 Thread David Miller
From: Hideo AOKI [EMAIL PROTECTED] Date: Fri, 16 Nov 2007 21:52:16 -0500 I understood that memory accounting code should avoid special protocols checks. Then, I'll improve this part in next patch set. Thank you for continuing this work, it is very much appreciated. - To unsubscribe from this

Re: 2.6.24-rc2-mm1 -- strange apparent network failures

2007-11-16 Thread Andrew Morgan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, This warning is just saying that you might want to reconsider recompiling your dhclient with a newer libcap - which has native support for 64-bit capabilities. This is supposed to be informative, and not be associated with any particular error.

Re: SFQ: backport some features from ESFQ (try 5)

2007-11-16 Thread Denys Fedoryshchenko
On Thu, 15 Nov 2007 18:59:05 -0800, Corey Hickey wrote Corey Hickey wrote: Patchset try 2 addresses the review by Michael Buesch. Patchset try 3 addresses the review by Patrick McHardy. Patchset try 4 has a few cosmetic improvements. Patchset try 5 addresses further review by Patrick

r8169 crash

2007-11-16 Thread Denys
Hi Recently i start to use r8169 cards and faced some issues. How to reproduce (kind of difficult, and i cannot that on my live server anymore): 1)Badly crimped cable. 2)PCI-Express R8169 card Kernel 2.6.23.1 05:01.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8169 Gigabit