Re: [patch for 2.6.24? 1/1] bonding: locking fix

2008-01-18 Thread Krzysztof Oledzki
On Thu, 17 Jan 2008, Jay Vosburgh wrote: Krzysztof Oledzki [EMAIL PROTECTED] wrote: Andrew Morton [EMAIL PROTECTED] wrote: [...] Can we get this bug fixed please? Today? It has been known about for more than two months. I just reposted the complete fix; it's #1 of the series of

[PATCH] net: sh_eth: Add support for Renesas SuperH Ethernet

2008-01-18 Thread Yoshihiro Shimoda
Add support for Renesas SuperH Ethernet controller. This driver supported SH7710 and SH7712. Signed-off-by: Yoshihiro Shimoda [EMAIL PROTECTED] --- Kconfig | 12 Makefile |1 sh_eth.c | 1175 +++ sh_eth.h | 468

Re: [PATCH 4/4] bonding: Fix some RTNL taking

2008-01-18 Thread Makito SHIOKAWA
Probably the difference is not much, but since this all double locking, unlocking and something between could take a while, and such a check looks cheaper than re-queueing... But I don't persist in this. Looks like this one is settled, thank you for your advice! -- Makito SHIOKAWA MIRACLE LINUX

[PATCH] Fix module names in net/sched/Kconfig

2008-01-18 Thread Masato Miyagi
Hi, This patch fixes the module names in net/sched/Kconfig ;) Signed-Off-By: Masato Miyagi [EMAIL PROTECTED] --- linux-2.6.24-rc8-mm1/net/sched/Kconfig.orig 2008-01-18 16:55:33.0 +0900 +++ linux-2.6.24-rc8-mm1/net/sched/Kconfig 2008-01-18 17:04:57.0 +0900 @@ -404,7 +404,7

Re: [PATCH 1/2] [IPV4] fib_hash: fix duplicated route issue

2008-01-18 Thread David Miller
From: Joonwoo Park [EMAIL PROTECTED] Date: Wed, 16 Jan 2008 20:13:25 +0900 http://bugzilla.kernel.org/show_bug.cgi?id=9493 The fib allows making identical routes with 'ip route replace'. This patch makes the fib return -EEXIST if replacement would cause duplication. Signed-off-by:

Re: [patch 1/2][NETNS][DST] dst: pass the dst_ops as parameter to the gc functions

2008-01-18 Thread David Miller
From: Daniel Lezcano [EMAIL PROTECTED] Date: Wed, 16 Jan 2008 15:54:17 +0100 The garbage collection function receive the dst_ops structure as parameter. This is useful for the next incoming patchset because it will need the dst_ops (there will be several instances) and the network namespace

Re: [patch 2/2][NETNS][DST] add the network namespace pointer in dst_ops

2008-01-18 Thread David Miller
From: Daniel Lezcano [EMAIL PROTECTED] Date: Wed, 16 Jan 2008 15:54:18 +0100 The network namespace pointer can be stored into the dst_ops structure. This is usefull when there are multiple instances of the dst_ops for a protocol. When there are no several instances, this field will be never

Re: [PATCH 2/2] [IPV4] fib_trie: fix duplicated route issue

2008-01-18 Thread David Miller
From: Joonwoo Park [EMAIL PROTECTED] Date: Wed, 16 Jan 2008 20:13:49 +0900 http://bugzilla.kernel.org/show_bug.cgi?id=9493 The fib allows making identical routes with 'ip route replace'. This patch makes the fib return -EEXIST if replacement would cause duplication. Signed-off-by:

Re: [IPV4] FIB_HASH: Reduce memory needs and speedup lookups

2008-01-18 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Wed, 16 Jan 2008 07:58:24 +0100 [IPV4] FIB_HASH: Reduce memory needs and speedup lookups ... Signed-off-by: Eric Dumazet [EMAIL PROTECTED] Applied to net-2.6.25, thanks Eric. -- To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [FIB]: Fix rcu_dereference() abuses in fib_trie.c

2008-01-18 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Tue, 15 Jan 2008 09:29:40 +0100 node_parent() and tnode_get_child() currently use rcu_dereference(). These functions are called from both - readers only paths (where rcu_dereference() is needed), and - writer path (where rcu_dereference() is not

RE: [PATCH 0/3] UCC TDM driver for MPC83xx platforms

2008-01-18 Thread Aggrwal Poonam
Hello All The TDM driver just now does not have a proper framework. Probably the interface cannot be generalised as such. Hence we could not decide whether it would be right to think of a TDM framework. Infact the interface this TDM driver(for MPC8323ERDB) supplies may not be usable for some

[PATCH] Add LRO control to ethtool

2008-01-18 Thread Ben Hutchings
The kernel-side ethtool code supports ETHTOOL_{G,S}FLAGS commands which can control various features; currently the only feature is LRO. I didn't see any code to use these in the ethtool git repository git://git.kernel.org/pub/scm/network/ethtool/ethtool.git. So here's a patch that adds that. I

[PATCH] add modalias info to mv643xx_eth.ko

2008-01-18 Thread Olaf Hering
mv643xx_eth has an platform modalias file in sysfs. But the module itself has no alias: line. Autoloading fails without the alias info in the module. Signed-off-by: Olaf Hering [EMAIL PROTECTED] --- drivers/net/mv643xx_eth.c |1 + 1 file changed, 1 insertion(+) ---

Re: [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang

2008-01-18 Thread David Miller
From: Robert Olsson [EMAIL PROTECTED] Date: Wed, 16 Jan 2008 18:07:38 +0100 eth0 e1000_irq_enable sem = 1- High netload eth0 e1000_irq_enable sem = 1 eth0 e1000_irq_enable sem = 1 eth0 e1000_irq_enable sem = 1 eth0 e1000_irq_enable sem = 1 eth0 e1000_irq_enable sem = 1 eth0

RE: [PATCH 0/3] UCC TDM driver for MPC83xx platforms

2008-01-18 Thread Joakim Tjernlund
On Fri, 2008-01-18 at 17:28 +0530, Aggrwal Poonam wrote: Hello All The TDM driver just now does not have a proper framework. Probably the interface cannot be generalised as such. Hence we could not decide whether it would be right to think of a TDM framework. Infact the interface this TDM

Re: [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang

2008-01-18 Thread David Miller
From: Robert Olsson [EMAIL PROTECTED] Date: Fri, 18 Jan 2008 14:00:57 +0100 I don't understand the idea with semaphore for enabling/disabling irq's either the overall logic must safer/better without it. They must have had code paths where they didn't know if IRQs were enabled or not

[PATCH 3/4] [IrDA] Irport removal - part 1

2008-01-18 Thread samuel
From: Adrian Bunk [EMAIL PROTECTED] This patch removes IrPORT and the old dongle drivers (all off them have replacement drivers). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/Kconfig | 141 - drivers/net/irda/Makefile

[PATCH 2/4] [IrDA] Frame length validation

2008-01-18 Thread samuel
From: Robie Basak [EMAIL PROTECTED] When using a stir4200-based USB adaptor to talk to a device that uses an mcp2150, the stir4200 sometimes drops an incoming frame causing the mcp2150 to try and retransmit the lost frame. In this combination, the next frame received from the mcp2150 is often

[PATCH 1/4] [IrDA] Resend frames on timeout

2008-01-18 Thread samuel
From: Robie Basak [EMAIL PROTECTED] When final timer expires, it might also mean that the i:cmd wasn't received properly. If we have rejected frames, we can try to resend them. Signed-off-by: Robie Basak [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- net/irda/irlap_event.c

Re: sctp use-uninitialized warning in net-2.6.25

2008-01-18 Thread Vlad Yasevich
David Miller wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Wed, 16 Jan 2008 13:59:57 -0800 net/sctp/sm_statefuns.c: In function 'sctp_sf_do_5_1C_ack': net/sctp/sm_statefuns.c:484: warning: 'error' may be used uninitialized in this function It is not obvious that this is a false

Performance issue : GRE tunneling

2008-01-18 Thread Jeba Anandhan
Hi All, When i send the traffic outside of GRE tunnel, The speed is in 3-4Mbps. When i use the tunnel for traffic, the speed get reduced huge. It is around 100-300Kbps. What are the factors affects the performance when we use tunneling [ ex:GRE tunneling ]? Thanks Jeba -- To unsubscribe from this

[PATCH net-2.6.25] [BRIDGE] Remove unused include of a header file in ebtables.c

2008-01-18 Thread Rami Rosen
Hi, In net/bridge/netfilter/ebtables.c, - remove unused include of a header file (linux/tty.h) and remove the corresponding comment above it. Regards, Rami Rosen Signed-off-by: Rami Rosen [EMAIL PROTECTED] diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c

[PATCH ] [NETNS 3/4 net-2.6.25] Consolidate kernel netlink socket destruction.

2008-01-18 Thread Denis V. Lunev
Create a specific helper for netlink kernel socket disposal. This just let the code look better and provides a ground for proper disposal inside a namespace. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] Tested-by: Alexey Dobriyan [EMAIL PROTECTED] --- drivers/connector/connector.c |

[PATCH] [NETNS 4/4 net-2.6.25] Namespace stop vs 'ip r l' race.

2008-01-18 Thread Denis V. Lunev
During network namespace stop process kernel side netlink sockets belonging to a namespace should be closed. They should not prevent namespace to stop, so they do not increment namespace usage counter. Though this counter will be put during last sock_put. The raplacement of the correct netns for

[PATCH] [NETNS 2/4 net-2.6.25] Memory leak on network namespace stop.

2008-01-18 Thread Denis V. Lunev
Network namespace allocates 2 kernel netlink sockets, fibnl rtnl. These sockets should be disposed properly, i.e. by sock_release. Plain sock_put is not enough. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] Tested-by: Alexey Dobriyan [EMAIL PROTECTED] --- net/core/rtnetlink.c|2 +-

[PATCH 0/4 net-2.6.25] Proper netlink kernel sockets disposal.

2008-01-18 Thread Denis V. Lunev
Alexey Dobriyan found, that virtualized netlink kernel sockets (fibl rtnl) are leaked during namespace start/stop loop. Leaking fix (simple and obvious) reveals that netlink kernel socket disposal leads to OOPSes: - nl_table[protocol]-listeners is double freed - sometimes during namespace stop

Re: Please pull 'fixes-davem' branch of wireless-2.6

2008-01-18 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Wed, 16 Jan 2008 16:26:45 -0500 One more fix for rfkill in 2.6.24...note that this branch is based on 2.6.24-rc8. Pulled, thanks John. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: [IPV4] FIB_HASH : Avoid unecessary loop in fn_hash_dump_zone()

2008-01-18 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Wed, 16 Jan 2008 18:19:25 +0100 I noticed ip route list was slower than cat /proc/net/route on a machine with a full Internet routing table (214392 entries : Special thanks to Robert ;) ) This is similar to problem reported in commit

[PATCH] [IPV6] ROUTE: Make sending algorithm more friendly with RFC 4861.

2008-01-18 Thread YOSHIFUJI Hideaki / 吉藤英明
We omit (or delay) sending NSes for known-to-unreachable routers (in NUD_FAILED state) according to RFC 4191 (Default Router Preferences and More-Specific Routes). But this is not fully compatible with RFC 4861 (Neighbor Discovery Protocol for IPv6), which does not remember unreachability of

[PATCH 0/4] [IrDA] IrDA fixes for net-2.6.25

2008-01-18 Thread samuel
Hi Dave, Here goes a batch of 4 IrDA patches against your latest net-2.6.25 tree. Cheers, Samuel. -- -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Performance issue : GRE tunneling

2008-01-18 Thread Badalian Vyacheslav
Jeba Anandhan пишет: Hi All, When i send the traffic outside of GRE tunnel, The speed is in 3-4Mbps. When i use the tunnel for traffic, the speed get reduced huge. It is around 100-300Kbps. What are the factors affects the performance when we use tunneling [ ex:GRE tunneling ]? Hello. You may

Re: [PATCH 3/4] bonding: Fix work rearming

2008-01-18 Thread Makito SHIOKAWA
Hmm... I'm not sure I understand your point, but it seems both bonding_store_arp_interval() and bonding_store_miimon() where this field could be changed, currently use cancel_delayed_work() with flush_workqueue(), so I presume, there is no rtnl_lock() nor write_lock(bond-lock) held, so

Re: [PATCH net-2.6.25] [BRIDGE] Remove unused include of a header file in ebtables.c

2008-01-18 Thread David Miller
From: Rami Rosen [EMAIL PROTECTED] Date: Fri, 18 Jan 2008 15:08:02 +0200 In net/bridge/netfilter/ebtables.c, - remove unused include of a header file (linux/tty.h) and remove the corresponding comment above it. Signed-off-by: Rami Rosen [EMAIL PROTECTED] Applied, thanks. -- To

Re: Broken Make ip6_frags per namespace patch

2008-01-18 Thread Daniel Lezcano
Alexey Dobriyan wrote: On Thu, Jan 17, 2008 at 01:01:11PM +0100, Daniel Lezcano wrote: Alexey Dobriyan wrote: On Thu, Jan 17, 2008 at 11:40:42AM +0100, Daniel Lezcano wrote: Alexey Dobriyan wrote: commit c064c4811b3e87ff8202f5a966ff4eea0bc54575 Author: Daniel Lezcano [EMAIL PROTECTED] Date:

Re: Broken Make ip6_frags per namespace patch

2008-01-18 Thread Alexey Dobriyan
On Thu, Jan 17, 2008 at 01:01:11PM +0100, Daniel Lezcano wrote: Alexey Dobriyan wrote: On Thu, Jan 17, 2008 at 11:40:42AM +0100, Daniel Lezcano wrote: Alexey Dobriyan wrote: commit c064c4811b3e87ff8202f5a966ff4eea0bc54575 Author: Daniel Lezcano [EMAIL PROTECTED] Date: Thu Jan 10 02:56:03

Re: [PATCH net-2.6.25] New driver sfc for Solarstorm SFC4000 controller - 5th attempt

2008-01-18 Thread Ben Hutchings
Robert Stonehouse wrote: snip - Improved reliability of I2C operations. snip This reminds me that Randy Dunlap raised the question of whether we could integrate with the kernel I2C and SPI systems. I did some investigatory work on this but it looked like it would add complexity and increase

Re: [PATCH] IPv6 support for NFS server

2008-01-18 Thread J. Bruce Fields
On Fri, Jan 18, 2008 at 03:50:56PM +0100, Aurélien Charbon wrote: OK Bruce I have added this comment before the patch. I have also done the changes pointed by Brian. Please let me know if there is still something to change. Thanks. For the future, if you could just make the comment part of

Re: [PATCH 3/4] bonding: Fix work rearming

2008-01-18 Thread Jarek Poplawski
Jarek Poplawski wrote, On 01/18/2008 11:27 PM: Makito SHIOKAWA wrote, On 01/18/2008 02:43 PM: ... @@ -1026,7 +1028,7 @@ static ssize_t bonding_store_miimon(stru cancel_delayed_work_sync(bond-lb_arp_work); } -if (bond-dev-flags IFF_UP)

[PATCH 3/3] sfq: whitespace cleanup

2008-01-18 Thread Stephen Hemminger
Add whitespace around operators, and add a few blank lines to improve readability. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/sched/sch_sfq.c 2008-01-17 08:33:04.0 -0800 +++ b/net/sched/sch_sfq.c 2008-01-17 08:43:51.0 -0800 @@ -122,7 +122,7 @@

[PATCH 2/3] sfq: use net_random

2008-01-18 Thread Stephen Hemminger
SFQ doesn't need true random numbers, it is only using them to salt a hash. Therefore it is better to use net_random() and avoid any possible problems with depleting the entropy pool. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/sched/sch_sfq.c 2008-01-17

[PATCH 1/3] sfq: timer is deferrable

2008-01-18 Thread Stephen Hemminger
The perturbation timer used for re-keying can be deferred, it doesn't need to be deterministic. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/sched/sch_sfq.c 2008-01-17 08:29:24.0 -0800 +++ b/net/sched/sch_sfq.c 2008-01-17 09:00:58.0 -0800 @@ -426,7

Re: sctp use-uninitialized warning in net-2.6.25

2008-01-18 Thread David Miller
From: Vlad Yasevich [EMAIL PROTECTED] Date: Fri, 18 Jan 2008 11:03:20 -0500 We can do that, or move the declaration to the only block that uses it. Like this: ... @@ -466,6 +465,7 @@ sctp_disposition_t sctp_sf_do_5_1C_ack(const struct sctp_endpoint *ep, if (!sctp_verify_init(asoc,

Memory leak in security_netlbl_sid_to_secattr(), kernel 2.6.23.12

2008-01-18 Thread Chuck Ebbert
We have two reports of this now. https://bugzilla.redhat.com/show_bug.cgi?id=352281 The user enabled SLUB user tracing and reports that the entries created by security_netlbl_sid_to_secattr() were increasing the most. Disabling selinux makes the problem go away completely. -- To unsubscribe

Re: sctp use-uninitialized warning in net-2.6.25

2008-01-18 Thread Vlad Yasevich
David Miller wrote: From: Vlad Yasevich [EMAIL PROTECTED] Date: Fri, 18 Jan 2008 11:03:20 -0500 We can do that, or move the declaration to the only block that uses it. Like this: ... @@ -466,6 +465,7 @@ sctp_disposition_t sctp_sf_do_5_1C_ack(const struct sctp_endpoint *ep, if

[git patches] net driver updates for 2.6.25

2008-01-18 Thread Jeff Garzik
Please pull from the 'upstream' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream to receive my 2.6.25 net driver queue into davem/net-2.6.25.git: Adam Baker (2): rt2x00: Unconstify rt2x00dev rt2x00: Place mutex around USB register access

Re: [PATCH] ne2k: add minimal ethtool setting support

2008-01-18 Thread Jeff Garzik
Stephen Hemminger wrote: Add minimal ethtool settings support for ne2k driver. This is needed for KVM/QEMU environment where ne2k seems to be the simplest stupid hardware used. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/drivers/net/ne2k-pci.c2008-01-15 11:21:02.0

Re: [BUG] 2.6.24-rc8 broke warm reboots on ASUS P5B-E Plus

2008-01-18 Thread Mikael Pettersson
On Thu, 17 Jan 2008 23:13:50 +0100, Mikael Pettersson wrote: The problematic machine has an Intel P965/ICH8R based ASUS P5B-E Plus mainboard with a Core2Duo 6600 processor. Kernels up to and including 2.6.24-rc7 work fine on it. Kernel 2.6.24-rc8 boots Ok, but if I try to do a warm

Re: [PATCH] atl1: fix frame length bug

2008-01-18 Thread Jeff Garzik
Jay Cliburn wrote: The driver sets up the hardware to accept a frame with max length equal to MTU + Ethernet header + FCS + VLAN tag, but we neglect to add the VLAN tag size to the ingress buffer. When a VLAN-tagged frame arrives, the hardware passes it, but bad things happen because the buffer

Re: Pull request for 'ipg-fixes' branch (try #2)

2008-01-18 Thread Jeff Garzik
Francois Romieu wrote: Please pull from branch 'ipg-fixes' in repository git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git ipg-fixes to get the changes below. Distance from 'master' (d8c89eb3a12f0da96d049bd515c7fa3702e511c5)

Re: [PATCH 1/7] bonding: fix locking in sysfs primary/active selection

2008-01-18 Thread Jeff Garzik
Jay Vosburgh wrote: Fix the functions that store the primary and active slave options via sysfs to hold the correct locks in the correct order. The bond_change_active_slave and bond_select_active_slave functions both require rtnl, bond-lock for read and curr_slave_lock for

[PATCH net-2.6.25] New driver sfc for Solarstorm SFC4000 controller - 5th attempt

2008-01-18 Thread Robert Stonehouse
This is a resubmission of a new driver for Solarflare network controllers. The driver supports several types of PHY (10Gbase-T, XFP, CX4) on six different 10G and 1G boards. There is a driver for the network controller and an MTD driver that allows access to the flash/EEPROM. NICs based on this

[PATCH net-2.6.25][NET_NS][IPV6] fix ip6_frags.ctl oops

2008-01-18 Thread Daniel Lezcano
Subject: fix ip6_frag ctl From: Daniel Lezcano [EMAIL PROTECTED] Alexey Dobriyan reported an oops when unsharing the network indefinitely inside a loop. This is because the ip6_frag is not per namespace while the ctls are. That happens at the fragment timer expiration: inet_frag_secret_rebuild

Re: [git patches] net driver updates for 2.6.25

2008-01-18 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Fri, 18 Jan 2008 15:17:21 -0500 Please pull from the 'upstream' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream to receive my 2.6.25 net driver queue into davem/net-2.6.25.git: Pulled and pushed back out,

Re: [PATCH 3/4] bonding: Fix work rearming

2008-01-18 Thread Jarek Poplawski
Makito SHIOKAWA wrote, On 01/18/2008 02:43 PM: Hmm... I'm not sure I understand your point, but it seems both bonding_store_arp_interval() and bonding_store_miimon() where this field could be changed, currently use cancel_delayed_work() with flush_workqueue(), so I presume, there is no

Re: [patch] add net_device_stats support to ethtool

2008-01-18 Thread Dan Nicolaescu
Jeff Garzik [EMAIL PROTECTED] writes: Dan Nicolaescu wrote: Hi, I have posted this patch in the past with absolutely no reply. I would appreciate some sort of feedback of the form interested/not interested. Should I just drop it? ethtool -S only supports devices

Re: [patch] add net_device_stats support to ethtool

2008-01-18 Thread Jeff Garzik
Dan Nicolaescu wrote: Hi, I have posted this patch in the past with absolutely no reply. I would appreciate some sort of feedback of the form interested/not interested. Should I just drop it? ethtool -S only supports devices that have custom code written to print the stats. No -- more

Re: [PATCH][resend] add driver for enc28j60 ethernet chip

2008-01-18 Thread Jeff Garzik
Claudio Lanconelli wrote: This patch add support for Microchip enc28j60 10Mbps Ethernet chip used in embedded systems due to its cheap SPI interface. This 2nd version include changes from previous comments by Jeff and Stephen, all but NAPI, see comments below at this regard. I resend the

Re: [Patch 2.6.24 1/1]S2io: Fixed synchronization between scheduling of napi with card reset and close

2008-01-18 Thread Jeff Garzik
Sreenivasa Honnur wrote: - Fixed synchronization between scheduling of napi with card reset and close by moving the enabling and disabling of napi to card up and card down functions respectively instead of open and close. Signed-off-by: Surjit Reang [EMAIL PROTECTED] Signed-off-by:

Re: [PATCH] IPv6 support for NFS server

2008-01-18 Thread Aurélien Charbon
OK Bruce I have added this comment before the patch. I have also done the changes pointed by Brian. Please let me know if there is still something to change. Regards, Aurélien J. Bruce Fields wrote: On Thu, Jan 17, 2008 at 06:04:35PM +0100, Aurélien Charbon wrote: Hi Bruce. Thanks for

Re: Memory leak in security_netlbl_sid_to_secattr(), kernel 2.6.23.12

2008-01-18 Thread Paul Moore
On Friday 18 January 2008 6:19:51 pm Chuck Ebbert wrote: We have two reports of this now. https://bugzilla.redhat.com/show_bug.cgi?id=352281 The user enabled SLUB user tracing and reports that the entries created by security_netlbl_sid_to_secattr() were increasing the most. Disabling

[RFC PATCH] NetLabel: Fix memory leak in SELinux glue code

2008-01-18 Thread Paul Moore
Fix a memory leak in security_netlbl_sid_to_secattr() as reported here: * https://bugzilla.redhat.com/show_bug.cgi?id=352281 Signed-off-by: Paul Moore [EMAIL PROTECTED] --- security/selinux/netlabel.c|7 +-- security/selinux/ss/services.c |2 -- 2 files changed, 5

Re: [patch for 2.6.24? 1/1] bonding: locking fix

2008-01-18 Thread Jay Vosburgh
Krzysztof Oledzki [EMAIL PROTECTED] wrote: [...] which makes the warning go away, but Herbert Xu pointed out that there is a potential problem with bond_enslave accessing the mc_lists without sufficient locking. It's not the only offender, either, and the bond-mc_list references really

Re: [RFC][PATCH] Fixing SA/SP dumps on netlink/af_key

2008-01-18 Thread jamal
On Fri, 2008-18-01 at 08:45 +0200, Timo Teräs wrote: I'll run my patched kernel and try to get ipsec-tools fixed to use netlink... eventually. If you are going to mod racoon to use netlink then thats without a doubt the _best_ solution (linux distros dilema i had essentially disappears). I

Re: [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang

2008-01-18 Thread Robert Olsson
David Miller writes: eth0 e1000_irq_enable sem = 1- ifconfig eth0 down eth0 e1000_irq_disable sem = 2 **e1000_open - ifconfig eth0 up eth0 e1000_irq_disable sem = 3 Dead. irq's can't be enabled e1000_irq_enable miss eth0 e1000_irq_enable sem = 2

[PATCH] [NETNS 1/4 net-2.6.25] Double free in netlink_release.

2008-01-18 Thread Denis V. Lunev
Netlink protocol table is global for all namespaces. Some netlink protocols have been virtualized, i.e. they have per/namespace netlink socket. This difference can easily lead to double free if more than 1 namespace is started. Count the number of kernel netlink sockets to track that this table is

Re: [PATCH] add modalias info to mv643xx_eth.ko

2008-01-18 Thread Dale Farnsworth
On Fri, Jan 18, 2008 at 10:38:05AM +0100, Olaf Hering wrote: mv643xx_eth has an platform modalias file in sysfs. But the module itself has no alias: line. Autoloading fails without the alias info in the module. Signed-off-by: Olaf Hering [EMAIL PROTECTED] Acked-by: Dale Farnsworth [EMAIL

Re: sctp use-uninitialized warning in net-2.6.25

2008-01-18 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Wed, 16 Jan 2008 13:59:57 -0800 net/sctp/sm_statefuns.c: In function 'sctp_sf_do_5_1C_ack': net/sctp/sm_statefuns.c:484: warning: 'error' may be used uninitialized in this function It is not obvious that this is a false positive. I'll check in

Re: [PATCH] atl1: fix frame length bug

2008-01-18 Thread Jay Cliburn
On Mon, 14 Jan 2008 20:04:28 -0600 Jay Cliburn [EMAIL PROTECTED] wrote: On Mon, 14 Jan 2008 19:56:41 -0600 Jay Cliburn [EMAIL PROTECTED] wrote: The driver sets up the hardware to accept a frame with max length equal to MTU + Ethernet header + FCS + VLAN tag, but we neglect to add the

sky2: call sky2_set_multicast from sky2_restart?

2008-01-18 Thread Tom Burns
Hi List, Throughout the sky2.c file any call to sky2_up(dev) is followed (soon enough) by a call to sky2_set_multicast(dev). Should this not also be the case when it is called in sky2_restart()? Cheers, Tom Burns -- To unsubscribe from this list: send the line unsubscribe netdev in the body of

Re: [PATCH] e1000e Kconfig: remove ref to nonexistant docs

2008-01-18 Thread Jeff Garzik
Jason Uhlenkott wrote: There is no Documentation/networking/e1000e.txt. Signed-off-by: Jason Uhlenkott [EMAIL PROTECTED] Cc: Auke Kok [EMAIL PROTECTED] --- Index: linux/drivers/net/Kconfig === --- linux.orig/drivers/net/Kconfig

Re: Please pull 'fixes-jgarzik' branch of wireless-2.6

2008-01-18 Thread Jeff Garzik
John W. Linville wrote: Jeff, A few more fixes for 2.6.24...note that this branch is based on 2.6.24-rc8. Thanks, John --- Individual patches available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/fixes-jgarzik/ --- The following changes since commit

Re: [patch v3] Documentation: add a guideline for hard_start_xmit method

2008-01-18 Thread Jeff Garzik
Matti Linnanvuori wrote: From: Matti Linnanvuori [EMAIL PROTECTED] Add a guideline not to modify SKBs. Signed-off-by: Matti Linnanvuori [EMAIL PROTECTED] --- --- a/Documentation/networking/driver.txt 2008-01-13 07:14:01.608291500 +0200 +++ b/Documentation/networking/driver.txt 2008-01-15

Re: [PATCH] SGISEEQ: fix oops when doing ifconfig down; ifconfig up

2008-01-18 Thread Jeff Garzik
Thomas Bogendoerfer wrote: When doing init_ring checking whether a new skb needs to be allocated was wrong. Signed-off-by: Thomas Bogendoerfer [EMAIL PROTECTED] --- This is a bug fix for the 2.6.25 driver. drivers/net/sgiseeq.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [PATCH 3/4] sky2: support for Yukon Supreme

2008-01-18 Thread Jeff Garzik
applied 3-4 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-2.6.25] New driver sfc for Solarstorm SFC4000 controller - 5th attempt

2008-01-18 Thread Jeff Garzik
Robert Stonehouse wrote: This is a resubmission of a new driver for Solarflare network controllers. The driver supports several types of PHY (10Gbase-T, XFP, CX4) on six different 10G and 1G boards. There is a driver for the network controller and an MTD driver that allows access to the

Re: [PATCH 2/2] SFQ: use net_random

2008-01-18 Thread Paul E. McKenney
On Fri, Jan 18, 2008 at 02:47:30PM -0800, Stephen Hemminger wrote: SFQ doesn't need true random numbers, it is only using them to salt a hash. Therefore it is better to use net_random() and avoid any possible problems with depleting the entropy pool. The random-number algorithm used by

Re: [PATCH 1/3] sfq: timer is deferrable

2008-01-18 Thread Paul E. McKenney
On Fri, Jan 18, 2008 at 02:49:00PM -0800, Stephen Hemminger wrote: The perturbation timer used for re-keying can be deferred, it doesn't need to be deterministic. The only concern that I can come up with is that the sfq_perturbation timer might be on one CPU, and all the operations using the

Re: sctp use-uninitialized warning in net-2.6.25

2008-01-18 Thread David Miller
From: Vlad Yasevich [EMAIL PROTECTED] Date: Fri, 18 Jan 2008 21:17:56 -0500 Hmm... in the code I am looking at, it's set in both zero and non-zero cases so it does solve the issue. So does initializing it to NO_ERROR like you did. Here is the code block in question in net-2.6.25:

Re: [PATCH 1/3] sfq: timer is deferrable

2008-01-18 Thread Stephen Hemminger
On Fri, 18 Jan 2008 20:34:46 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Fri, Jan 18, 2008 at 02:49:00PM -0800, Stephen Hemminger wrote: The perturbation timer used for re-keying can be deferred, it doesn't need to be deterministic. The only concern that I can come up with is that

Re: [PATCH 1/3] sfq: timer is deferrable

2008-01-18 Thread Paul E. McKenney
On Fri, Jan 18, 2008 at 08:36:55PM -0800, Stephen Hemminger wrote: On Fri, 18 Jan 2008 20:34:46 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Fri, Jan 18, 2008 at 02:49:00PM -0800, Stephen Hemminger wrote: The perturbation timer used for re-keying can be deferred, it doesn't need

Re: [PATCH 0/4 net-2.6.25] Proper netlink kernel sockets disposal.

2008-01-18 Thread David Miller
From: Denis V. Lunev [EMAIL PROTECTED] Date: Fri, 18 Jan 2008 15:51:47 +0300 Alexey Dobriyan found, that virtualized netlink kernel sockets (fibl rtnl) are leaked during namespace start/stop loop. Leaking fix (simple and obvious) reveals that netlink kernel socket disposal leads to OOPSes:

Re: [PATCH net-2.6.25][NET_NS][IPV6] fix ip6_frags.ctl oops

2008-01-18 Thread David Miller
Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html