Re: [NET_SCHED 00/09]: sch_ingress cleanups

2008-01-21 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Sun, 20 Jan 2008 10:31:36 -0500 For all patches: Acked-by: Jamal Hadi Salim [EMAIL PROTECTED] All 9 patches applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [NET_SCHED]: kill obsolete NET_CLS_POLICE option

2008-01-21 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Sun, 20 Jan 2008 15:48:16 +0100 [NET_SCHED]: kill obsolete NET_CLS_POLICE option The code is already gone for about half a year, the config option has been kept around to select the replacement options for easier upgrades. This seems long

[PATCH]: Fix IWLWIFI mis-merge.

2008-01-21 Thread David Miller
I just corrected the iwlwifi driver build in the net-2.6.25 tree. The cause is very simple, the patches applied after Christoph Hellwig's namespace pollution cleanup to these drivers were not even build tested. [IWLWIFI]: Fix up merge errors. Christoph Hellwig did a driver-wide namespace

Re: [VLAN 00/18]: Vlan update

2008-01-21 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Sun, 20 Jan 2008 18:11:17 +0100 (MET) the following patches contain a VLAN update for 2.6.25, consisting mainly of minor cleanups removing duplicate code, avoiding forward declarations, makeing functions static etc. Next I'll look into the skb-cb

Re: [PATCH 2/4] dsmark: get rid of trivial function

2008-01-21 Thread Ilpo Järvinen
On Mon, 21 Jan 2008, Patrick McHardy wrote: Stephen Hemminger wrote: Replace loop in dsmark_valid_indices with equivalent bit math. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/sched/sch_dsmark.c2008-01-20 13:07:58.0 -0800 +++

Re: [MACVLAN]: Fix thinko in macvlan_transfer_operstate()

2008-01-21 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Sun, 20 Jan 2008 15:47:08 +0100 [MACVLAN]: Fix thinko in macvlan_transfer_operstate() When the lower device's carrier is off, the macvlan devices's carrier state should be checked to decide whether it needs to be turned off. Currently the lower

Re: [PATCH] ipv6: addrconf sparse warnings

2008-01-21 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Sun, 20 Jan 2008 10:01:40 -0800 Get rid of a couple of sparse warnings in IPV6 addrconf code. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied, thanks Stephen. -- To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [PATCH 1/4] dsmark: get rid of wrappers

2008-01-21 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Sun, 20 Jan 2008 13:10:08 -0800 Remove extraneous macro wrappers for printk and qdisc_priv. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] APplied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

[PATCH 2/2] IPV6: RFC 2011 compatibility broken

2008-01-21 Thread Wang Chen
[IPV6]: RFC 2011 compatibility broken The snmp6 entry name was changed, and it broke compatibility to RFC 2011. Signed-off-by: Wang Chen [EMAIL PROTECTED] --- linux-2.6.24.rc8.org/net/ipv6/proc.c2008-01-16 17:45:03.0 +0800 +++ linux-2.6.24.rc8/net/ipv6/proc.c2008-01-21

[PATCH 1/2] IPV6: ICMP6_MIB_OUTMSGS increment duplicated

2008-01-21 Thread Wang Chen
[IPV6]: ICMP6_MIB_OUTMSGS increment duplicated icmpv6_send() calls ip6_push_pending_frames() indirectly. Both ip6_push_pending_frames() and icmpv6_send() increment counter ICMP6_MIB_OUTMSGS. This patch remove the increment from icmpv6_send. Signed-off-by: Wang Chen [EMAIL PROTECTED] ---

Re: [PATCH 1/2] IPV6: ICMP6_MIB_OUTMSGS increment duplicated

2008-01-21 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Mon, 21 Jan 2008 17:46:32 +0800), Wang Chen [EMAIL PROTECTED] says: [IPV6]: ICMP6_MIB_OUTMSGS increment duplicated icmpv6_send() calls ip6_push_pending_frames() indirectly. Both ip6_push_pending_frames() and icmpv6_send() increment counter

Re: [PATCH 2/2] IPV6: RFC 2011 compatibility broken

2008-01-21 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Mon, 21 Jan 2008 17:46:44 +0800), Wang Chen [EMAIL PROTECTED] says: The snmp6 entry name was changed, and it broke compatibility to RFC 2011. Signed-off-by: Wang Chen [EMAIL PROTECTED] Acked-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --yoshfuji -- To

Re: [PATCH 2/4] dsmark: get rid of trivial function

2008-01-21 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 01:16:32 +0100 Stephen Hemminger wrote: Replace loop in dsmark_valid_indices with equivalent bit math. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/sched/sch_dsmark.c2008-01-20 13:07:58.0

Re: [PATCH 3/4] dsmark: handle cloned and non-linear skb's

2008-01-21 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Sun, 20 Jan 2008 13:23:54 -0800 Make dsmark work properly with non-linear and cloned skb's Before modifying the header, it needs to check that skb header is writeable. Note: this makes the assumption, that if it queues a good skb then a good

Re: [PATCH 4/4] dsmark: checkpatch warning cleanup

2008-01-21 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Sun, 20 Jan 2008 13:25:36 -0800 Get rid of all style things checkpatch warns about, indentation and whitespace. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] sch_atm: style cleanup

2008-01-21 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Sun, 20 Jan 2008 14:03:42 -0800 ATM scheduler clean house: * get rid of printk and qdisc_priv() wrapper * split some assignment in if() statements * whitespace and line breaks. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]

Re: [PATCH] net classifier: style cleanup's

2008-01-21 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Sun, 20 Jan 2008 14:06:13 -0800 Classifier code cleanup. Get rid of printk wrapper, and fix whitespace and other style stuff reported by checkpatch Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of

Re: [PATCH] net: add sparse annotation to ptype_seq_start/stop

2008-01-21 Thread David Miller
From: Josh Triplett [EMAIL PROTECTED] Date: Sun, 20 Jan 2008 23:29:32 -0800 At the moment, Sparse doesn't actually use the context expression. In the ideal case when it does, all references to the same lock should use a context expression which resolves to that lock (whatever that may mean;

Re: [PATCH 1/3][NET] gen_estimator: faster gen_kill_estimator

2008-01-21 Thread David Miller
From: Jarek Poplawski [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 00:46:59 +0100 I like the technique you used to fix this bug, but: diff -Nurp 2.6.24-rc8-mm1-/include/linux/gen_stats.h 2.6.24-rc8-mm1+/include/linux/gen_stats.h --- 2.6.24-rc8-mm1-/include/linux/gen_stats.h 2007-10-09

Re: [PATCH 2/3][NET] gen_estimator: list_empty() check in est_timer() fixed

2008-01-21 Thread David Miller
From: Jarek Poplawski [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 07:42:40 +0100 On Mon, Jan 21, 2008 at 07:34:55AM +0100, Jarek Poplawski wrote: ... BTW, I've forgotten to mention with patch 1/3 that this checking with warning on gen_new_estimator() double call should be only temporary, and

Re: [PATCH 3/3][NET] gen_estimator: gen_replace_estimator() cosmetic changes

2008-01-21 Thread David Miller
From: Jarek Poplawski [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 00:51:15 +0100 White spaces etc. are changed in gen_replace_estimator() to make it similar to others in a file. Signed-off-by: Jarek Poplawski [EMAIL PROTECTED] Applied to net-2.6.25, thanks. -- To unsubscribe from this list:

Re: [PATCH] [IPV4] route: fix locking in rt_run_flush()

2008-01-21 Thread David Miller
From: Joonwoo Park [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 00:08:57 +0900 The rt_run_flush() can be stucked if it was called while netdev is on the high load. It's possible when pushing rtable to rt_hash is faster than pulling from it. The commands 'ifconfig up or ifconfig mtu' and

Re: [PATCH 1/3][NET] gen_estimator: faster gen_kill_estimator

2008-01-21 Thread Jarek Poplawski
On Mon, Jan 21, 2008 at 02:35:15AM -0800, David Miller wrote: ... Sorry, this structure is exported to userspace so we can't change it like that. It is an attribute passed over netlink sockets. Thanks for finding this! I'll try to rethink this (especially why my tests seemed to show

Re: [PATCH 1/2] IPV6: ICMP6_MIB_OUTMSGS increment duplicated

2008-01-21 Thread David Miller
From: Wang Chen [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 17:46:32 +0800 [IPV6]: ICMP6_MIB_OUTMSGS increment duplicated icmpv6_send() calls ip6_push_pending_frames() indirectly. Both ip6_push_pending_frames() and icmpv6_send() increment counter ICMP6_MIB_OUTMSGS. This patch remove the

Re: [PATCH 1/2] IPV6: ICMP6_MIB_OUTMSGS increment duplicated

2008-01-21 Thread Wang Chen
David Miller said the following on 2008-1-21 18:57: [IPV6]: ICMP6_MIB_OUTMSGS increment duplicated icmpv6_send() calls ip6_push_pending_frames() indirectly. Both ip6_push_pending_frames() and icmpv6_send() increment counter ICMP6_MIB_OUTMSGS. This patch remove the increment from

IPv6 problems (mtu is less than advmss?)

2008-01-21 Thread Jim Paris
Hi, When the IPv6 default route is first autoconfigured, it seems the advertised MSS doesn't get set properly. I have computer A connected to an external interface with IPv4 and tunneling IPv6 using 6to4. It runs radvd on an internal interface to provide connectivity to my LAN. radvd.conf

Re: [PATCH 1/2] IPV6: ICMP6_MIB_OUTMSGS increment duplicated

2008-01-21 Thread David Miller
From: Wang Chen [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 18:59:43 +0800 Dave, because the network of my working place can't clone git tree, I used 2.6.24-rc8 to make the patches. Does someone know how to setup GIT to update the HTTP fetch information as a post-push hook? Can you apply them

Re: [PATCH 2/3][NET] gen_estimator: list_empty() check in est_timer() fixed

2008-01-21 Thread Jarek Poplawski
On Mon, Jan 21, 2008 at 02:36:32AM -0800, David Miller wrote: ... FWIW I agree that double-negatives are confusing and we should avoid them. Right! No more: CHECKSUM_NONE, SOCK_NOSPACE, IFF_NOARP or KERN_NOTICE! Jarek P. -- To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [PATCH 1/2] IPV6: ICMP6_MIB_OUTMSGS increment duplicated

2008-01-21 Thread Wang Chen
David Miller said the following on 2008-1-21 19:06: Does someone know how to setup GIT to update the HTTP fetch information as a post-push hook? Seems Herbert knows how to do it. Maybe run git-update-server-info every time when you rebase your tree. Can you apply them to net-2.6 tree?

Re: [PATCH] bluetooth : move children of connection device to NULL before connection down

2008-01-21 Thread David Miller
From: Dave Young [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 12:54:01 +0800 Add people missed in cc-list. Thanks Dave for your continued efforts on Bluetooth bugs like this. Marcel, are you going to review/ACK/integrate/push-upstream/whatever any of these Bluetooth patches? It hasn't been

Re: [PATCH 2/3][NET] gen_estimator: list_empty() check in est_timer() fixed

2008-01-21 Thread David Miller
From: Jarek Poplawski [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 12:19:40 +0100 On Mon, Jan 21, 2008 at 02:36:32AM -0800, David Miller wrote: ... FWIW I agree that double-negatives are confusing and we should avoid them. Right! No more: CHECKSUM_NONE, SOCK_NOSPACE, IFF_NOARP or

Re: [WEXT 8/12]: Pull top-level ioctl dispatch logic into helper function.

2008-01-21 Thread Masakazu Mokuno
Hi Dave, On Fri, 21 Dec 2007 20:56:23 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: [WEXT]: Pull top-level ioctl dispatch logic into helper function. Signed-off-by: David S. Miller [EMAIL PROTECTED] snip +int wext_handle_ioctl(struct net *net, struct ifreq *ifr, unsigned int

Re: [PATCH] ICMP: ICMP_MIB_OUTMSGS increment duplicated

2008-01-21 Thread Wang Chen
Dave, how about this one. It's like that one of IPV6. Wang Chen said the following on 2008-1-16 17:59: In tree net-2.6.25, commit 96793b482540f3a26e2188eaf75cb56b7829d3e3 made a mistake. In that patch, David L added a icmp_out_count() in ip_push_pending_frames(), remove icmp_out_count()

Re: [PATCH] IPv4: Enable use of 240/4 address space

2008-01-21 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] Date: Sun, 20 Jan 2008 00:30:19 +0900 (JST) In article [EMAIL PROTECTED] (at Sat, 19 Jan 2008 14:44:13 +0100 (CET)), Jan Engelhardt [EMAIL PROTECTED] says: From 84bccef295aa9754ee662191e32ba1d64edce2ba Mon Sep 17 00:00:00 2001 From: Jan

Re: [PATCH 2/3][NET] gen_estimator: list_empty() check in est_timer() fixed

2008-01-21 Thread Jarek Poplawski
On Mon, Jan 21, 2008 at 03:15:53AM -0800, David Miller wrote: ... Life is difficult sometimes, but that is no excuse to further the pain :-) YES! I've read somewhere about it too! Jarek P. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: : Emit event stream compat iw_point objects correctly.

2008-01-21 Thread Masakazu Mokuno
Hi Sorry for my intermittent posts. On Thu, 10 Jan 2008 01:16:02 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: From: Masakazu Mokuno [EMAIL PROTECTED] Date: Thu, 27 Dec 2007 18:24:40 +0900 On ppc64 (PS3), IW_EV_LCP_LEN is 8, not 4. include/linux/wireless.h: #define

Re: [PATCH] ICMP: ICMP_MIB_OUTMSGS increment duplicated

2008-01-21 Thread David Miller
From: Wang Chen [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 19:15:07 +0800 Dave, how about this one. It's like that one of IPV6. I am confused, this changelog for this patch mentions changes made only in the net-2.6.25 tree. Yet you just told me the two other patches should be applied to net-2.6

Re: [PATCH] ICMP: ICMP_MIB_OUTMSGS increment duplicated

2008-01-21 Thread Wang Chen
David Miller said the following on 2008-1-21 19:25: I am confused, this changelog for this patch mentions changes made only in the net-2.6.25 tree. Although I wrote that I find David.S's patch in net-2.6.25 was wrong, the guilty patch also in net-2.6 tree. Here is the web link.

Re: : Emit event stream compat iw_point objects correctly.

2008-01-21 Thread David Miller
From: Masakazu Mokuno [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 20:23:15 +0900 Sorry for my intermittent posts. No problem. I am sorry for being to busy to get back to active work on this patch set. -prism54_translate_bss(struct net_device *ndev, char *current_ev, - char

Re: [PATCH] ICMP: ICMP_MIB_OUTMSGS increment duplicated

2008-01-21 Thread David Miller
From: Wang Chen [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 19:34:56 +0800 David Miller said the following on 2008-1-21 19:25: I am confused, this changelog for this patch mentions changes made only in the net-2.6.25 tree. Although I wrote that I find David.S's patch in net-2.6.25 was

RE: [PATCH][v2] phylib: add module owner to the mii_bus structure

2008-01-21 Thread Nicu Ioan Petru
-Original Message- From: Fleming Andy Sent: Monday, January 14, 2008 8:56 PM To: Nicu Ioan Petru Cc: netdev@vger.kernel.org; [EMAIL PROTECTED] Subject: Re: [PATCH][v2] phylib: add module owner to the mii_bus structure Any reason you didn't update the other drivers? git

Re: [Bugme-new] [Bug 9778] New: unregister_netdevice: waiting for [device] to become free

2008-01-21 Thread Evgeniy Polyakov
On Sun, Jan 20, 2008 at 02:30:27AM -0800, David Miller ([EMAIL PROTECTED]) wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Sat, 19 Jan 2008 16:58:02 -0800 ouch. Yep, several people are hitting this it seems. If Pavel doesn't provide a fix or direction soon I'll just revert. It

Re: [Bugme-new] [Bug 9778] New: unregister_netdevice: waiting for [device] to become free

2008-01-21 Thread David Miller
From: Evgeniy Polyakov [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 15:14:45 +0300 I will think about how to fix the problem nicely or if this patch still can be simplified/dropped, but so far it looks valid. Maybe this analysis will help someone to fix problem first. I have currently reverted

Re: [PATCH 3/4] bonding: Fix work rearming

2008-01-21 Thread Jarek Poplawski
On Mon, Jan 21, 2008 at 01:04:06PM +0900, Makito SHIOKAWA wrote: (But new_value = 0 seems needed - just like from module_param()?) Do you mean to initialize new_value before sscanf()? (There is a check 'if (sscanf(buf, %d, new_value) != 1)', so is it necesarry?) No: you mentioned about

Re: [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang

2008-01-21 Thread David Miller
From: Robert Olsson [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 14:27:13 +0100 Yes it works. e1000 tested for ~3 hours with high very high load and interface up/down every 5:th sec. Without the patch the irq's gets disabled within a couple of seconds A resolute way of handling the

Re: [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang

2008-01-21 Thread Robert Olsson
David Miller writes: Yes, this semaphore thing is highly problematic. In the most crucial areas where network driver consistency matters the most for ease of understanding and debugging, the Intel drivers choose to be different :-( The way the napi_disable() logic breaks out from

Re: [Bugme-new] [Bug 9778] New: unregister_netdevice: waiting for [device] to become free

2008-01-21 Thread Evgeniy Polyakov
On Mon, Jan 21, 2008 at 03:14:45PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: It looks like patch is still valid. Here is a problem description as I undestood. When new device (let's talk about ethernet, since that is what I tested) is being turned on, it gets neigh_parms entry

Re: [PATCH 2/3][NET] gen_estimator: list_empty() check in est_timer() fixed

2008-01-21 Thread Jarek Poplawski
On Mon, Jan 21, 2008 at 03:15:53AM -0800, David Miller wrote: From: Jarek Poplawski [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 12:19:40 +0100 On Mon, Jan 21, 2008 at 02:36:32AM -0800, David Miller wrote: ... FWIW I agree that double-negatives are confusing and we should avoid them.

[PATCH 0/6 net-2.6.25] Provide correct namespace on IPv4 packet input path.

2008-01-21 Thread Denis V. Lunev
This patchset sequentially adds namespace parameter to fib_lookup and inetdev_by_index. After that it is possible to pass network namespace from input packet to routing engine. Output path is much more intrusive and will be sent separately. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] -- To

[PATCH 3/6 net-2.6.25] [NETNS] Pass correct namespace in fib_validate_source.

2008-01-21 Thread Denis V. Lunev
Correct network namespace is available inside fib_validate_source. It can be obtained from the device passed in. The device is not NULL as in_device is obtained from it just above. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/fib_frontend.c |6 -- 1 files changed, 4

[PATCH 5/6 net-2.6.25] [NETNS] Pass correct namespace in ip_route_input_slow.

2008-01-21 Thread Denis V. Lunev
The packet on the input path always has a referrence to an input network device it is passed from. Extract network namespace from it. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/route.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH 4/6 net-2.6.25] [NETNS] Pass correct namespace in context fib_check_nh.

2008-01-21 Thread Denis V. Lunev
Correct network namespace is already used in fib_check_nh. Re-work its usage for better readability and pass into fib_lookup inetdev_by_index. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/fib_semantics.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff

[PATCH 6/6 net-2.6.25] [NETNS] Pass correct namespace in ip_rt_get_source.

2008-01-21 Thread Denis V. Lunev
ip_rt_get_source is the infamous place for which dst_ifdown kludges have been implemented. This means that rt-u.dst.dev can be safely dereferrenced obtain nd_net. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/route.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH 1/6 net-2.6.25] [NETNS] Add netns parameter to fib_lookup.

2008-01-21 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/net/ip_fib.h |9 + net/ipv4/fib_frontend.c |4 ++-- net/ipv4/fib_rules.c |4 ++-- net/ipv4/fib_semantics.c |2 +- net/ipv4/route.c |6 +++--- 5 files changed, 13 insertions(+), 12 deletions(-)

[PATCH 2/6 net-2.6.25] [NETNS] Add netns parameter to inetdev_by_index.

2008-01-21 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/linux/inetdevice.h |2 +- net/ipv4/devinet.c |6 +++--- net/ipv4/fib_semantics.c |2 +- net/ipv4/igmp.c|4 ++-- net/ipv4/ip_gre.c |3 ++- 5 files changed, 9 insertions(+), 8 deletions(-)

[PATCH 1/5] netns netfilter: change xt_table_register() return value convention

2008-01-21 Thread Alexey Dobriyan
Switch from 0/-E to ptr/PTR_ERR convention. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- include/linux/netfilter/x_tables.h |6 +++--- net/ipv4/netfilter/arp_tables.c|7 --- net/ipv4/netfilter/ip_tables.c |7 --- net/ipv6/netfilter/ip6_tables.c|7

[PATCH 2/5] netns netfilter: per-netns xt_tables

2008-01-21 Thread Alexey Dobriyan
In fact all we want is per-netns set of rules, however doing that will unnecessary complicate routines such as ipt_hook()/ipt_do_table, so make full xt_table array per-netns. Every user stubbed with init_net for a while. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] ---

[PATCH 3/5] netns netfilter: return new table from {arp,ip,ip6}t_register_table()

2008-01-21 Thread Alexey Dobriyan
Typical table module registers xt_table structure (i.e. packet_filter) and link it to list during it. We can't use one template for it because corresponding list_head will become corrupted. We also can't unregister with template because it wasn't changed at all and thus doesn't know in which list

[PATCH 4/5] netns netfilter: propagate netns from userspace

2008-01-21 Thread Alexey Dobriyan
.. all the way down to table searching functions. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- net/ipv4/netfilter/ip_tables.c | 46 - 1 file changed, 23 insertions(+), 23 deletions(-) --- a/net/ipv4/netfilter/ip_tables.c +++

[PATCH 5/5] netns netfilter: per-netns FILTER, MANGLE, RAW

2008-01-21 Thread Alexey Dobriyan
Now, iptables show and configure different set of rules in different netnss'. Filtering decisions are still made by consulting only init_net's set. Changes are identical except naming so no splitting. P.S.: one need to remove init_net checks in nf_sockopt.c and inet_create() to see the

Re: post 2.6.24-rc7 regression: unregister_netdevice: waiting for eth1 to become free

2008-01-21 Thread Mariusz Kozlowski
Hello, kernel: unregister_netdevice: waiting for eth1 to become free. Usage count = 1 Known problem: http://bugzilla.kernel.org/show_bug.cgi?id=9778 Hm ... I was largely offline on weekend and did not see that. Is there any way I can subscribe 'somewhere' to get notified about

[PATCH] SCTP: Fix kernel panic while received AUTH chunk while enabled auth

2008-01-21 Thread Wei Yongjun
If STCP is started while /proc/sys/net/sctp/auth_enable is set 0 and association is established between endpoints. Then if /proc/sys/net/sctp/auth_enable is set 1, a received AUTH chunk will cause kernel panic. Test as following: step 1: echo 0 /proc/sys/net/sctp/auth_enable step 2: SCTP

[VLAN] sparse warning fix

2008-01-21 Thread Stephen Hemminger
Minor sparse warning fix. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/8021q/vlanproc.c 2008-01-21 09:30:44.0 -0800 +++ b/net/8021q/vlanproc.c 2008-01-21 09:31:54.0 -0800 @@ -220,6 +220,7 @@ static inline int is_vlan_dev(struct net /* start read of

[IPV4] igmp sparse warnings

2008-01-21 Thread Stephen Hemminger
Partial sparse warning fix. The other conditional locking is too much for sparse to handle. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/ipv4/igmp.c 2008-01-21 09:35:58.0 -0800 +++ b/net/ipv4/igmp.c 2008-01-21 09:36:20.0 -0800 @@ -2329,6 +2329,7 @@ static

[IPV4] ipmr sparse warnings

2008-01-21 Thread Stephen Hemminger
Get rid of some of the sparse warnings. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/ipv4/ipmr.c 2008-01-21 09:37:02.0 -0800 +++ b/net/ipv4/ipmr.c 2008-01-21 09:39:56.0 -0800 @@ -141,7 +141,7 @@ struct net_device *ipmr_new_tunnel(struc

Re: [PATCH 2/2] IPV6: RFC 2011 compatibility broken

2008-01-21 Thread David Stevens
RFC 2011 doesn't apply to IPv6, and the internal names of /proc entries are not used by the SNMP protocol, but it is an unintentional incompatibility with the previous Linux entry names, so I agree. :-) +-DLS Acked-by: David L Stevens [EMAIL PROTECTED]

Re: questions on NAPI processing latency and dropped network packets

2008-01-21 Thread Chris Friesen
I've done some further digging, and it appears that one of the problems we may be facing is very high instantaneous traffic rates. Instrumentation showed up to 222K packets/sec for short periods (at least 1.1 ms, possibly longer), although the long-term average is down around 14-16K

Fwd: sysfs network namespace support - was this patch set forgotten ?

2008-01-21 Thread Ian Brown
-- Forwarded message -- From: Ian Brown [EMAIL PROTECTED] Date: Jan 20, 2008 9:08 AM Subject: sysfs network namespace support - was this patch set forgotten ? To: [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED] Hello, I saw some posts (from about a month ago) about

Re: [PATCH] PHYLIB: Locking fixes for PHY I/O potentially sleeping

2008-01-21 Thread Andy Fleming
On Jan 3, 2008, at 17:36, Nate Case wrote: PHY read/write functions can potentially sleep (e.g., a PHY accessed via I2C). The following changes were made to account for this: * Change spin locks to mutex locks * Add a BUG_ON() to phy_read() phy_write() to warn against calling

[PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure (was: Re: fixed phy support (warning related to FIXED_MII_100_FDX))

2008-01-21 Thread Anton Vorontsov
On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote: Anton, it looks like the TI AR7 CPMAC Ethernet support uses FIXED_PHY and was selecting FIXED_MII_100_FDX which is gone. Can you look into this. I get the following warning now: scripts/kconfig/conf -s arch/powerpc/Kconfig

[PATCH RESEND 1/3] RDMA/cxgb3: Flush the RQ when closing.

2008-01-21 Thread Steve Wise
RDMA/cxgb3: Flush the RQ when closing. - for kernel mode cqs, call event notification handler when flushing - flush qp when moving from RTS - CLOSING - fixed logic to identify a kernel mode qp Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_qp.c |7 +--

[PATCH 3/3] RDMA/cxgb3: Mark qp as privileged based on user capabilities.

2008-01-21 Thread Steve Wise
RDMA/cxgb3: Mark qp as privileged based on user capabilities. This is needed for zero-stag support. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/cxio_wr.h |3 ++- drivers/infiniband/hw/cxgb3/iwch_qp.c |1 + 2 files changed, 3 insertions(+), 1

[PATCH RESEND 2/3] RDMA/cxgb3: fix page shift calculation in build_phys_page_list()

2008-01-21 Thread Steve Wise
RDMA/cxgb3: fix page shift calculation in build_phys_page_list() The existing logic incorrectly maps this buffer list: 0: addr 0x10001000, size 0x1000 1: addr 0x10002000, size 0x1000 To this bogus page list: 0: 0x1000 1: 0x10002000 The shift calculation must also take into account the

[PATCH RESEND 0/3] RDMA/cxgb3 fixes

2008-01-21 Thread Steve Wise
Hey Roland, Please include these three iw_cxgb3 fixes for 2.6.25. The first two fix bugs found doing Lustre testing, and the last patch correctly marks privileged qps. Shortlog: RDMA/cxgb3: Flush the RQ when closing. RDMA/cxgb3: fix page shift calculation in build_phys_page_list()

[PATCH 1/3] RDMA/cxgb3: Flush the RQ when closing.

2008-01-21 Thread Steve Wise
RDMA/cxgb3: Flush the RQ when closing. - for kernel mode cqs, call event notification handler when flushing - flush qp when moving from RTS - CLOSING - fixed logic to identify a kernel mode qp Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_qp.c |7 +--

[PATCH 2/3] RDMA/cxgb3: fix page shift calculation in build_phys_page_list()

2008-01-21 Thread Steve Wise
RDMA/cxgb3: fix page shift calculation in build_phys_page_list() The existing logic incorrectly maps this buffer list: 0: addr 0x10001000, size 0x1000 1: addr 0x10002000, size 0x1000 To this bogus page list: 0: 0x1000 1: 0x10002000 The shift calculation must also take into account the

[PATCH RESEND 3/3] RDMA/cxgb3: Mark qp as privileged based on user capabilities.

2008-01-21 Thread Steve Wise
RDMA/cxgb3: Mark qp as privileged based on user capabilities. This is needed for zero-stag support. Signed-off-by: Steve Wise [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/cxio_wr.h |3 ++- drivers/infiniband/hw/cxgb3/iwch_qp.c |1 + 2 files changed, 3 insertions(+), 1

Re: questions on NAPI processing latency and dropped network packets

2008-01-21 Thread Ben Greear
Chris Friesen wrote: Is there anything else we can do to minimize the latency of network packet processing and avoid having to crank the rx ring size up so high? Why is it such a big deal to crank up the rx queue length? Seems like a perfectly normal way to handle bursts like this...

Re: [PATCH] [IPV4] route: fix locking in rt_run_flush()

2008-01-21 Thread Eric Dumazet
David Miller a écrit : From: Joonwoo Park [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 00:08:57 +0900 The rt_run_flush() can be stucked if it was called while netdev is on the high load. It's possible when pushing rtable to rt_hash is faster than pulling from it. The commands 'ifconfig up or

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-21 Thread Ilpo Järvinen
On Mon, 21 Jan 2008, Dave Young wrote: Please see the kernel messages following,(trigged while using some qemu session) BTW, seems there's some e100 error message as well. PCI: Setting latency timer of device :00:1b.0 to 64 e100: Intel(R) PRO/100 Network Driver, 3.5.23-k4-NAPI e100:

Re: questions on NAPI processing latency and dropped network packets

2008-01-21 Thread Eric Dumazet
Chris Friesen a écrit : I've done some further digging, and it appears that one of the problems we may be facing is very high instantaneous traffic rates. Instrumentation showed up to 222K packets/sec for short periods (at least 1.1 ms, possibly longer), although the long-term average is down

[PATCH] ipv6: update MSS even if MTU is unchanged

2008-01-21 Thread Jim Paris
This is needed because in ndisc.c, we have: static void ndisc_router_discovery(struct sk_buff *skb) { // ... if (ndopts.nd_opts_mtu) { // ... if (rt) rt-u.dst.metrics[RTAX_MTU-1] = mtu;

Please pull 'upstream-davem' branch of wireless-2.6 (2008-01-21)

2008-01-21 Thread John W. Linville
Dave, A slew of patches intended for 2.6.25... Included are some big updates to b43, iwlwifi, libertas, and rt2x00. Also included are some sizeable mac80211 updates and a bunch of cleanup work from Al Viro, as well as a smattering of other patches. More notable are two new drivers: ath5k and

[PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-21 Thread Jarek Poplawski
So, let's try something easy first: #ifdef __KERNEL__. (I know there are many esthetes around, but since this subject looks quite dirty...) Alternatively we could change an api, and as a matter of fact there was such a try some time ago, but is it really worth of such a mess? Regards, Jarek P.

Re: [PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-21 Thread Jarek Poplawski
On Mon, Jan 21, 2008 at 11:31:37PM +0100, Jarek Poplawski wrote: So, let's try something easy first: #ifdef __KERNEL__. (I know there ... SORRY!!! Of course this is still wrong, I withdraw this patch. Jarek P. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: questions on NAPI processing latency and dropped network packets

2008-01-21 Thread Chris Friesen
Ben Greear wrote: Chris Friesen wrote: Is there anything else we can do to minimize the latency of network packet processing and avoid having to crank the rx ring size up so high? Why is it such a big deal to crank up the rx queue length? Seems like a perfectly normal way to handle bursts

Re: questions on NAPI processing latency and dropped network packets

2008-01-21 Thread Chris Friesen
Eric Dumazet wrote: Chris Friesen a écrit : I've done some further digging, and it appears that one of the problems we may be facing is very high instantaneous traffic rates. Instrumentation showed up to 222K packets/sec for short periods (at least 1.1 ms, possibly longer), although the

Re: questions on NAPI processing latency and dropped network packets

2008-01-21 Thread Ben Greear
Chris Friesen wrote: Ben Greear wrote: Chris Friesen wrote: Is there anything else we can do to minimize the latency of network packet processing and avoid having to crank the rx ring size up so high? Why is it such a big deal to crank up the rx queue length? Seems like a perfectly normal

[PATCH 2.6.25 1/4][BNX2]: Disable jumbo rx paging on 5709 Ax.

2008-01-21 Thread Michael Chan
[BNX2]: Disable jumbo rx paging on 5709 Ax. The chip has problem running in this mode and needs to be disabled. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 94d1857..8348af2 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@

[PATCH 2.6.25 3/4][BNX2]: Add link-down workaround on 5706 serdes.

2008-01-21 Thread Michael Chan
[BNX2]: Add link-down workaround on 5706 serdes. In some blade systems using the 5706 serdes, the hardware sometimes does not properly generate link down interrupts. We add a workaround in the driver's timer to force a link-down when some PHY registers report loss of SYNC. The parallel detect

[PATCH 2.6.25 2/4][BNX2]: Fix minor bug in bnx2_has_work().

2008-01-21 Thread Michael Chan
[BNX2]: Fix minor bug in bnx2_has_work(). It is more correct to get the status block from the bnx2_napi struct instead of the bnx2 struct. It happens that they are the same in this case because we are using the first MSIX vector. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git

[PATCH 2.6.25 4/4][BNX2] Update version to 1.7.2.

2008-01-21 Thread Michael Chan
[BNX2] Update version to 1.7.2. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 834675f..970a003 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -1,6 +1,6 @@ /* bnx2.c: Broadcom NX2 network driver. * - * Copyright (c)

Re: [PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-21 Thread David Miller
From: Jarek Poplawski [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 23:31:37 +0100 So, let's try something easy first: #ifdef __KERNEL__. (I know there are many esthetes around, but since this subject looks quite dirty...) You can't do this, the attribute is copied to the user netlink SKB using

Re: Please pull 'upstream-davem' branch of wireless-2.6 (2008-01-21)

2008-01-21 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 15:28:35 -0500 A slew of patches intended for 2.6.25... Included are some big updates to b43, iwlwifi, libertas, and rt2x00. Also included are some sizeable mac80211 updates and a bunch of cleanup work from Al Viro, as well as a

Re: [PATCH 2.6.25 1/4][BNX2]: Disable jumbo rx paging on 5709 Ax.

2008-01-21 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 17:07:32 -0800 [BNX2]: Disable jumbo rx paging on 5709 Ax. The chip has problem running in this mode and needs to be disabled. Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied. -- To unsubscribe from this list: send the line

Re: [PATCH 2.6.25 2/4][BNX2]: Fix minor bug in bnx2_has_work().

2008-01-21 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 17:08:01 -0800 [BNX2]: Fix minor bug in bnx2_has_work(). It is more correct to get the status block from the bnx2_napi struct instead of the bnx2 struct. It happens that they are the same in this case because we are using the

Re: [PATCH 2.6.25 3/4][BNX2]: Add link-down workaround on 5706 serdes.

2008-01-21 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 17:08:24 -0800 [BNX2]: Add link-down workaround on 5706 serdes. In some blade systems using the 5706 serdes, the hardware sometimes does not properly generate link down interrupts. We add a workaround in the driver's timer to

Re: [PATCH 2.6.25 4/4][BNX2] Update version to 1.7.2.

2008-01-21 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 17:08:42 -0800 [BNX2] Update version to 1.7.2. Signed-off-by: Michael Chan [EMAIL PROTECTED] Also applied, thanks Michael. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

[BNX2]: Fix driver software flag namespace.

2008-01-21 Thread David Miller
Michael, I noticed the following while checking in your patches today. I've checked this into net-2.6.25 [BNX2]: Fix driver software flag namespace. Prefix bnx2-flags names with BNX2_* for consistency. Signed-off-by: David S. Miller [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c

Re: [VLAN] sparse warning fix

2008-01-21 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 21 Jan 2008 09:48:49 -0800 Minor sparse warning fix. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied. @@ -220,6 +220,7 @@ static inline int is_vlan_dev(struct net /* start read of /proc/net/vlan/config */ static void

  1   2   >