Re: [IPV4] ip_gre: should take care of CONFIG_IPV6_MODULE

2008-01-22 Thread Patrick McHardy
Eric Dumazet wrote: If IPV6 is configured as a module, GRE code misses some IPV6 parts. I believe this is intentional to avoid a runtime dependency on ipv6. Fixing this without pulling in the ipv6 module would be preferrable. -- To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH] bluetooth : move children of connection device to NULL before connection down

2008-01-22 Thread Dave Young
On Jan 22, 2008 2:18 PM, Marcel Holtmann [EMAIL PROTECTED] wrote: Hi Dave, Add people missed in cc-list. Thanks Dave for your continued efforts on Bluetooth bugs like this. Marcel, are you going to review/ACK/integrate/push-upstream/whatever any of these Bluetooth patches? It

[PATCH] SCTP: Fix kernel panic while received AUTH chunk with BAD shared key identifier

2008-01-22 Thread Wei Yongjun
If SCTP-AUTH is enabled, received AUTH chunk with BAD shared key identifier will cause kernel panic. Test as following: step1: enabled /proc/sys/net/sctp/auth_enable step 2: connect to SCTP server with auth capable. Association is established between endpoints. Then send a AUTH chunk with a

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-22 Thread Dave Young
On Jan 22, 2008 5:09 PM, Dave Young [EMAIL PROTECTED] wrote: On Jan 22, 2008 12:37 PM, Dave Young [EMAIL PROTECTED] wrote: On Jan 22, 2008 5:14 AM, Ilpo Järvinen [EMAIL PROTECTED] wrote: On Mon, 21 Jan 2008, Dave Young wrote: Please see the kernel messages following,(trigged

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-22 Thread Dave Young
On Jan 22, 2008 12:37 PM, Dave Young [EMAIL PROTECTED] wrote: On Jan 22, 2008 5:14 AM, Ilpo Järvinen [EMAIL PROTECTED] wrote: On Mon, 21 Jan 2008, Dave Young wrote: Please see the kernel messages following,(trigged while using some qemu session) BTW, seems there's some e100 error

Re: RFC: igb: Intel 82575 gigabit ethernet driver (take #3)

2008-01-22 Thread Jeff Garzik
Kok, Auke wrote: All, here is the third version of the igb (82575) ethernet controller driver. This driver was previously posted 2007-07-13 and 2007-12-11. Many comments received were addressed: - removed indirection wrappers in the same way as e1000e and ixgbe. - cleaned up largely against

Re: [GIT PULL] [IPV6,IPV4]: Fix several sparse warnings.

2008-01-22 Thread Eric Dumazet
On Tue, 22 Jan 2008 18:56:32 +0900 (JST) YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] wrote: diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index cb2411c..ecd9d91 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -418,7 +418,7 @@ out: void udp_err(struct sk_buff *skb, u32 info) { -

[GIT PULL] [IPV6,IPV4]: Fix several sparse warnings.

2008-01-22 Thread YOSHIFUJI Hideaki / 吉藤英明
Dave, please consider pulling following changes on top of net-2.6.25 tree: git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git net-2.6-dev-20080122 Thank you. HEADLINES - [IPV4] UDP,UDPLITE: Sparse: {__udp4_lib,udp,udplite}_err() are of void. [IPV6] UDP,UDPLITE

Re: [PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-22 Thread Herbert Xu
On Wed, Jan 16, 2008 at 03:19:03PM +1100, Rusty Russell wrote: It's far easier to deal with GSO if we don't have to parse the packet to figure out the header length. Add the field to the virtio_net_hdr struct (and fix the spaces that somehow crept in there). Why do we need this? When

Re: [IPV4] ip_gre: should take care of CONFIG_IPV6_MODULE

2008-01-22 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 09:21:26 +0100 Eric Dumazet wrote: If IPV6 is configured as a module, GRE code misses some IPV6 parts. I believe this is intentional to avoid a runtime dependency on ipv6. Fixing this without pulling in the ipv6 module would

Re: [GIT PULL] [IPV6,IPV4]: Fix several sparse warnings.

2008-01-22 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 18:56:32 +0900 (JST) Dave, please consider pulling following changes on top of net-2.6.25 tree: git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git net-2.6-dev-20080122 Pulled, thank you. -- To unsubscribe

Re: [GIT PULL] [IPV6,IPV4]: Fix several sparse warnings.

2008-01-22 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 11:03:12 +0100 On Tue, 22 Jan 2008 18:56:32 +0900 (JST) YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] wrote: @@ -418,7 +418,7 @@ out: void udp_err(struct sk_buff *skb, u32 info) { - return __udp4_lib_err(skb, info,

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-22 Thread Ilpo Järvinen
On Tue, 22 Jan 2008, Dave Young wrote: On Jan 22, 2008 12:37 PM, Dave Young [EMAIL PROTECTED] wrote: On Jan 22, 2008 5:14 AM, Ilpo Järvinen [EMAIL PROTECTED] wrote: On Mon, 21 Jan 2008, Dave Young wrote: Please see the kernel messages following,(trigged while using some qemu

[DST]: shrinks sizeof(struct rtable) by 64 bytes on x86_64

2008-01-22 Thread Eric Dumazet
On x86_64, sizeof(struct rtable) is 0x148, which is rounded up to 0x180 bytes by SLAB allocator. We can reduce this to exactly 0x140 bytes, without alignment overhead, and store 12 struct rtable per PAGE instead of 10. rate_tokens is currently defined as an unsigned long, while its content

[Bug 9750] dev: avoid a race that triggers assertion failure

2008-01-22 Thread Matti Linnanvuori
From: Matti Linnanvuori [EMAIL PROTECTED] There is a race in Linux kernel file net/core/dev.c, function dev_close. The function calls function dev_deactivate, which calls function dev_watchdog_down that deletes the watchdog timer. However, after that, a driver can call netif_carrier_ok, which

Re: [PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-22 Thread jamal
On Tue, 2008-22-01 at 08:21 +0100, Jarek Poplawski wrote: On 22-01-2008 01:29, David Miller wrote: ... Fix this right, make a structure like: struct kernel_gnet_stats_rate_est { struct gnet_stats_rate_est est; void*gen_estimator; } And

Re: [PATCH] bluetooth : move children of connection device to NULL before connection down

2008-01-22 Thread Marcel Holtmann
Hi Dave, could you tell something more about your coding style? I would like to submit patches about bluetooth according to your sytle later If I have. Maybe you could put it on the bluez web site or anywhere. it follows closely the kernel coding style as layout within the kernel

forcedeth oops

2008-01-22 Thread Andrew Brooks
Hello I'm getting an oops in forcedeth whenever I shutdown, details below. I've tried kernel 2.6.16.59 and the latest forcedeth.c from nvidia.com which is package-1.23 version-0.62 date-2007/04/27. How can I download the latest forcedeth.c (including 2008-01-13 patches) ? It's not in the latest

Re: [PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-22 Thread Jarek Poplawski
On Tue, Jan 22, 2008 at 06:42:07AM -0500, jamal wrote: ... Jarek, That looks different from the suggestion from Dave. Hmm..., I'm not sure you mean my or your suggestion here, but you are right anyway... May i throw in another bone? Theoretically i can see why it would be a really bad idea

[PATCH net-2.6.25 4/10][NETNS][FRAGS]: Make the mem counter per-namespace.

2008-01-22 Thread Pavel Emelyanov
This is also simple, but introduces more changes, since then mem counter is altered in more places. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- include/net/inet_frag.h |4 ++-- include/net/ip.h|2 +- include/net/ipv6.h

Re: [PATCH net-2.6.25 1/10][NETNS][FRAGS]: Move ctl tables around.

2008-01-22 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 16:55:23 +0300 This is a preparation for sysctl netns-ization. Move the ctl tables to the files, where the tuning variables reside. Plus make the helpers to register the tables. This will simplify the later patches and will

[PATCH net-2.6.25 6/10][NETNS][FRAGS]: Make the net.ipv4.ipfrag_timeout work in namespaces.

2008-01-22 Thread Pavel Emelyanov
Move it to the netns_frags, adjust the usage and make the appropriate ctl table writable. Now fragment, that live in different namespaces can live for different times. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- include/net/inet_frag.h |4 +++-

[PATCH net-2.6.25 0/10] Make fragments live in net namespaces

2008-01-22 Thread Pavel Emelyanov
The overall design I propose is to keep the hash table global and tag inet_frag_queue with the net. Since the fragments hash is going to be re-sizable, this is OK to keep fragments from different namespace in one hash. To speedup the evicting process LRU list is made per namespace. As far as

Re: [PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-22 Thread jamal
On Tue, 2008-22-01 at 13:29 +0100, Jarek Poplawski wrote: On Tue, Jan 22, 2008 at 06:42:07AM -0500, jamal wrote: ... Jarek, That looks different from the suggestion from Dave. Hmm..., I'm not sure you mean my or your suggestion here, but you are right anyway... Your idea to grab a

[PATCH net-2.6.25 1/10][NETNS][FRAGS]: Move ctl tables around.

2008-01-22 Thread Pavel Emelyanov
This is a preparation for sysctl netns-ization. Move the ctl tables to the files, where the tuning variables reside. Plus make the helpers to register the tables. This will simplify the later patches and will keep similar things closer to each other. ipv4, ipv6 and conntrack_reasm are patched

[PATCH net-2.6.25 2/10][NETNS][FRAGS]: Make the inet_frag_queue lookup work in namespaces.

2008-01-22 Thread Pavel Emelyanov
Since fragment management code is consolidated, we cannot have the pointer from inet_frag_queue to struct net, since we must know what king of fragment this is. So, I introduce the netns_frags structure. This one is currently empty, but will be eventually filled with per-namespace attributes.

[PATCH net-2.6.25 3/10][NETNS][FRAGS]: Make the nqueues counter per-namespace.

2008-01-22 Thread Pavel Emelyanov
This is simple - just move the variable from struct inet_frags to struct netns_frags and adjust the usage appropriately. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- include/net/inet_frag.h |4 +++- include/net/ip.h|2 +-

Re: [PATCH net-2.6.25 3/10][NETNS][FRAGS]: Make the nqueues counter per-namespace.

2008-01-22 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 16:58:13 +0300 This is simple - just move the variable from struct inet_frags to struct netns_frags and adjust the usage appropriately. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Applied. -- To unsubscribe from this list:

[PATCH net-2.6.25 8/10][NETNS][FRAGS]: Isolate the secret interval from namespaces.

2008-01-22 Thread Pavel Emelyanov
Since we have one hashtable to lookup the fragment, having different secret_interval-s for hash rebuild doesn't make sense, so move this one to inet_frags. The inet_frags_ctl becomes empty after this, so remove it. The appropriate ctl table is kept read-only in namespaces. Signed-off-by: Pavel

Re: [PATCH net-2.6.25 4/10][NETNS][FRAGS]: Make the mem counter per-namespace.

2008-01-22 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 16:59:41 +0300 This is also simple, but introduces more changes, since then mem counter is altered in more places. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Applied. -- To unsubscribe from this list: send the line

[PATCH net-2.6.25 9/10][NETNS][FRAGS]: Make the LRU list per namespace.

2008-01-22 Thread Pavel Emelyanov
The inet_frags.lru_list is used for evicting only, so we have to make it per-namespace, to evict only those fragments, who's namespace exceeded its high threshold, but not the whole hash. Besides, this helps to avoid long loops in evictor. The spinlock is not per-namespace because it protects

Re: [PATCH net-2.6.25 5/10][NETNS][FRAGS]: Duplicate sysctl tables for new namespaces.

2008-01-22 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 17:01:02 +0300 Each namespace has to have own tables to tune their different parameters, so duplicate the tables and register them. All the tables in sub-namespaces are temporarily made read-only. Signed-off-by: Pavel

Re: [PATCH net-2.6.25 6/10][NETNS][FRAGS]: Make the net.ipv4.ipfrag_timeout work in namespaces.

2008-01-22 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 17:02:17 +0300 Move it to the netns_frags, adjust the usage and make the appropriate ctl table writable. Now fragment, that live in different namespaces can live for different times. Signed-off-by: Pavel Emelyanov [EMAIL

Re: [PATCH net-2.6.25 7/10][NETNS][FRAGS]: Make thresholds work in namespaces.

2008-01-22 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 17:05:47 +0300 This is the same as with the timeout variable. Currently, after exceeding the high threshold _all_ the fragments are evicted, but it will be fixed in later patch. Signed-off-by: Pavel Emelyanov [EMAIL

[PATCH net-2.6.25 10/10][NETNS][FRAGS]: Make the pernet subsystem for fragments.

2008-01-22 Thread Pavel Emelyanov
On namespace start we mainly prepare the ctl variables. When the namespace is stopped we have to kill all the fragments that point to this namespace. The inet_frags_exit_net() handles it. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- include/net/inet_frag.h |1 +

Re: [PATCH net-2.6.25 8/10][NETNS][FRAGS]: Isolate the secret interval from namespaces.

2008-01-22 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 17:07:10 +0300 Since we have one hashtable to lookup the fragment, having different secret_interval-s for hash rebuild doesn't make sense, so move this one to inet_frags. The inet_frags_ctl becomes empty after this, so remove

Re: [PATCH net-2.6.25 9/10][NETNS][FRAGS]: Make the LRU list per namespace.

2008-01-22 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 17:08:54 +0300 The inet_frags.lru_list is used for evicting only, so we have to make it per-namespace, to evict only those fragments, who's namespace exceeded its high threshold, but not the whole hash. Besides, this helps to

Re: [PATCH net-2.6.25 10/10][NETNS][FRAGS]: Make the pernet subsystem for fragments.

2008-01-22 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 17:10:51 +0300 On namespace start we mainly prepare the ctl variables. When the namespace is stopped we have to kill all the fragments that point to this namespace. The inet_frags_exit_net() handles it. Signed-off-by: Pavel

Re: [PATCH] SCTP: Fix kernel panic while received AUTH chunk with BAD shared key identifier

2008-01-22 Thread David Miller
From: Wei Yongjun [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 17:29:20 +0900 If SCTP-AUTH is enabled, received AUTH chunk with BAD shared key identifier will cause kernel panic. Vlad, please review this. Thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [DST]: shrinks sizeof(struct rtable) by 64 bytes on x86_64

2008-01-22 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 11:50:06 +0100 On x86_64, sizeof(struct rtable) is 0x148, which is rounded up to 0x180 bytes by SLAB allocator. We can reduce this to exactly 0x140 bytes, without alignment overhead, and store 12 struct rtable per PAGE instead of

Re: [git patches] net driver updates

2008-01-22 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 06:02:31 -0500 NOTE: This is the igb as Auke submitted it. It still needs a review against ultra-recent Intel driver work. Please pull from 'upstream-davem' branch of

Re: [PATCH net-2.6.25 2/10][NETNS][FRAGS]: Make the inet_frag_queue lookup work in namespaces.

2008-01-22 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Tue, 22 Jan 2008 16:57:06 +0300 Since fragment management code is consolidated, we cannot have the pointer from inet_frag_queue to struct net, since we must know what king of fragment this is. So, I introduce the netns_frags structure. This one

[PATCH net-2.6.25 5/10][NETNS][FRAGS]: Duplicate sysctl tables for new namespaces.

2008-01-22 Thread Pavel Emelyanov
Each namespace has to have own tables to tune their different parameters, so duplicate the tables and register them. All the tables in sub-namespaces are temporarily made read-only. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- include/net/netns/ipv4.h |1 +

[PATCH net-2.6.25 7/10][NETNS][FRAGS]: Make thresholds work in namespaces.

2008-01-22 Thread Pavel Emelyanov
This is the same as with the timeout variable. Currently, after exceeding the high threshold _all_ the fragments are evicted, but it will be fixed in later patch. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- include/net/inet_frag.h |4 ++-- net/ipv4/inet_fragment.c

[IPV4]: Add missing skb-truesize increment in ip_append_page().

2008-01-22 Thread David Miller
I just checked the following into net-2.6 [IPV4]: Add missing skb-truesize increment in ip_append_page(). Signed-off-by: David S. Miller [EMAIL PROTECTED] diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index fd99fbd..e582dba 100644 --- a/net/ipv4/ip_output.c +++

[NET_SCHED 06/06]: Convert actions from rtnetlink to new netlink API

2008-01-22 Thread Patrick McHardy
[NET_SCHED]: Convert actions from rtnetlink to new netlink API Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 9d8b9cf5c729a718df7861276e6f4c4868a89bd2 tree 64eca29283578c622c492013ec6562bd95f7a7cd parent 7798bc7f67ba5ffcfc542f5c88762b6db705992e author Patrick McHardy [EMAIL

[NETLINK 03/06]: Add nla_append()

2008-01-22 Thread Patrick McHardy
[NETLINK]: Add nla_append() Used to append data to a message without a header or padding. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 8a6648ddc22e03bbdf6675780c917e8c8519f205 tree 39c68f8b7aea4e94c227fe421031e0969dac92ef parent 4cf7dba2c890608fee47fe46487c79abf322dc82 author

[NET_SCHED 02/06]: mark classifier ops __read_mostly

2008-01-22 Thread Patrick McHardy
[NET_SCHED]: mark classifier ops __read_mostly Additionally remove unnecessary NULL initilizations of the next pointer. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 4cf7dba2c890608fee47fe46487c79abf322dc82 tree 4f29f07adbaf0dfe78f6148205644b6b2dbd1717 parent

[NET_SCHED 01/06]: Move EXPORT_SYMBOL next to exported symbol

2008-01-22 Thread Patrick McHardy
[NET_SCHED]: Move EXPORT_SYMBOL next to exported symbol Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 8b868a47c5bedb1daa8534ae60c2d89fcad26781 tree 93ba760730b3b3e74250c984e871840ace8317a3 parent bae4a7effd59ef0d521de2bc97902fa0a243b544 author Patrick McHardy [EMAIL PROTECTED] Tue,

[NET_SCHED 00/06]: Conversion to new netlink API

2008-01-22 Thread Patrick McHardy
These patches convert the packet schedulers to the new netlink API. This will allow to use the new features like automatic attribute checking and gets rid of the largest rtnetlink.h user we still have. Unfortunately a gradual conversion is not really feasible, so the patches are quite large, but

[NET_SCHED 05/06]: Convert classifiers from rtnetlink to new netlink API

2008-01-22 Thread Patrick McHardy
[NET_SCHED]: Convert classifiers from rtnetlink to new netlink API Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 7798bc7f67ba5ffcfc542f5c88762b6db705992e tree 4a6d67ac7a5f1c667ed025a56264ecb35486118e parent 07a5a2c72eb790323d3e11bb2e1131f8fd43ae1d author Patrick McHardy [EMAIL

[PATCH net-2.6.25] Add packet filtering based on process's security context.

2008-01-22 Thread Tetsuo Handa
This patch modifies security_socket_post_accept() and introduces security_socket_post_recv_datagram() LSM hooks. Currently, security_socket_post_accept() is called *after* fd_install() at sys_accept(). This means that userland process might access accept()ed but not yet properly labeled socket. I

[PATCH 0/12 net-2.6.25] [NETNS]: Routing namespacing on IP output path.

2008-01-22 Thread Denis V. Lunev
This set introduces namespacing in the IP output path. The namespace is added to all routing API functions except ones with a valid socket. This is very intrusive. Routing cache is virtualized as a part of this efforts, though the hash function is not tuned to use namespace id. This not required

[PATCH 8/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_route_output_flow.

2008-01-22 Thread Denis V. Lunev
Needed to propagate it down to the __ip_route_output_key. Signed_off_by: Denis V. Lunev [EMAIL PROTECTED] --- drivers/infiniband/hw/cxgb3/iwch_cm.c |2 +- include/net/route.h |6 +++--- net/dccp/ipv4.c |2 +- net/ipv4/af_inet.c

[PATCH 3/12 net-2.6.25] [NETNS]: Add netns parameter to fib_select_default.

2008-01-22 Thread Denis V. Lunev
Currently fib_select_default calls fib_get_table() with the init_net. Prepare it to provide a correct namespace to lookup default route. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/net/ip_fib.h|3 ++- net/ipv4/fib_frontend.c |5 +++-- net/ipv4/route.c|2 +-

[PATCH 6/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_route_output_slow.

2008-01-22 Thread Denis V. Lunev
This function needs a net namespace to lookup devices, fib tables, etc. in, so pass it there. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/route.c | 22 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c

[PATCH 4/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_dev_find.

2008-01-22 Thread Denis V. Lunev
in_dev_find() need a namespace to pass it to fib_get_table(), so add an argument. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- drivers/infiniband/core/addr.c |4 ++-- drivers/infiniband/core/cma.c |2 +- include/linux/inetdevice.h |2 +- net/ipv4/fib_frontend.c|

[PATCH 1/12 net-2.6.25] [IPV4]: Declarations cleanup in ip_fib.h.

2008-01-22 Thread Denis V. Lunev
Two small issues fixed: - fib_select_multipath is exported from fib_semantics.c rather than from fib_frontend.c. So, move the declaration below appropriate comment. - struct rt_entry declaration is not used. Drop it. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/net/ip_fib.h |

[PATCH 5/12 net-2.6.25] [NETNS]: Re-export init_net via EXPORT_SYMBOL.

2008-01-22 Thread Denis V. Lunev
init_net is used added as a parameter to a lot of old API calls, f.e. ip_dev_find. These calls were exported as EXPORT_SYMBOL. So, export init_net as EXPORT_SYMBOL to keep networking API consistent. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/core/net_namespace.c |2 +- 1 files

[PATCH 2/12 net-2.6.25] [IPV4]: Consolidate fib_select_default.

2008-01-22 Thread Denis V. Lunev
The difference in the implementation of the fib_select_default when CONFIG_IP_MULTIPLE_TABLES is (not) defined looks negligible. Consolidate it and place into fib_frontend.c. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/net/ip_fib.h| 10 +- net/ipv4/fib_frontend.c |

[PATCH 7/12 net-2.6.25] [NETNS]: Add namespace parameter to __ip_route_output_key.

2008-01-22 Thread Denis V. Lunev
This is only required to propagate it down to the ip_route_output_slow. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/net/route.h |4 ++-- net/ipv4/icmp.c |4 ++-- net/ipv4/route.c|7 --- net/ipv4/xfrm4_policy.c |2 +- 4 files changed, 9

[PATCH 9/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_route_output_key.

2008-01-22 Thread Denis V. Lunev
Needed to propagate it down to the ip_route_output_flow. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- drivers/infiniband/core/addr.c |4 ++-- drivers/net/bonding/bond_main.c |2 +- include/net/route.h |2 +- net/atm/clip.c |2 +-

Re: [PATCH 1/5] netns netfilter: change xt_table_register() return value convention

2008-01-22 Thread Patrick McHardy
Alexey Dobriyan wrote: Switch from 0/-E to ptr/PTR_ERR convention. Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-2.6.25] Add packet filtering based on process's security context.

2008-01-22 Thread Casey Schaufler
--- Tetsuo Handa [EMAIL PROTECTED] wrote: ... Currently, there is no way to directly map security context from incoming packet to user process. This is because the creator or owner of a socket is not always the receiver of an incoming packet. The userland process who receives the incoming

Re: [PATCH 3/5] netns netfilter: return new table from {arp,ip,ip6}t_register_table()

2008-01-22 Thread Patrick McHardy
Alexey Dobriyan wrote: Typical table module registers xt_table structure (i.e. packet_filter) and link it to list during it. We can't use one template for it because corresponding list_head will become corrupted. We also can't unregister with template because it wasn't changed at all and thus

Re: [PATCH 4/5] netns netfilter: propagate netns from userspace

2008-01-22 Thread Patrick McHardy
Alexey Dobriyan wrote: .. all the way down to table searching functions. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] Applied. --- net/ipv4/netfilter/ip_tables.c | 46 - 1 file changed, 23 insertions(+), 23 deletions(-) What about ip6_tables

Re: [PATCH 2/5] netns netfilter: per-netns xt_tables

2008-01-22 Thread Patrick McHardy
Alexey Dobriyan wrote: In fact all we want is per-netns set of rules, however doing that will unnecessary complicate routines such as ipt_hook()/ipt_do_table, so make full xt_table array per-netns. Every user stubbed with init_net for a while. Applied. -- To unsubscribe from this list: send

Re: [PATCH 5/12 net-2.6.25] [NETNS]: Re-export init_net via EXPORT_SYMBOL.

2008-01-22 Thread Patrick McHardy
Denis V. Lunev wrote: init_net is used added as a parameter to a lot of old API calls, f.e. ip_dev_find. These calls were exported as EXPORT_SYMBOL. So, export init_net as EXPORT_SYMBOL to keep networking API consistent. I think this should go in 2.6.24 if still possible so people don't have

status inquiry (RE: [PATCH 01/03] ISATAP V2 (header file changes))

2008-01-22 Thread Templin, Fred L
Would appreciate a status update on this submission, posted 1/15/08. Thanks - Fred [EMAIL PROTECTED] -Original Message- From: Templin, Fred L Sent: Tuesday, January 15, 2008 11:57 AM To: netdev@vger.kernel.org Cc: YOSHIFUJI Hideaki / 吉藤英明 Subject: [PATCH 01/03] ISATAP V2 (header

Re: [PATCH 5/5] netns netfilter: per-netns FILTER, MANGLE, RAW

2008-01-22 Thread Patrick McHardy
Alexey Dobriyan wrote: Now, iptables show and configure different set of rules in different netnss'. Filtering decisions are still made by consulting only init_net's set. Changes are identical except naming so no splitting. P.S.: one need to remove init_net checks in nf_sockopt.c and

Re: [PATCH 5/12 net-2.6.25] [NETNS]: Re-export init_net via EXPORT_SYMBOL.

2008-01-22 Thread Denis V. Lunev
Patrick McHardy wrote: Denis V. Lunev wrote: init_net is used added as a parameter to a lot of old API calls, f.e. ip_dev_find. These calls were exported as EXPORT_SYMBOL. So, export init_net as EXPORT_SYMBOL to keep networking API consistent. I think this should go in 2.6.24 if still

Re: [PATCH] PHYLIB: Locking fixes for PHY I/O potentially sleeping

2008-01-22 Thread David Hollis
On Thu, 2008-01-03 at 17:36 -0600, Nate Case wrote: PHY read/write functions can potentially sleep (e.g., a PHY accessed via I2C). The following changes were made to account for this: * Change spin locks to mutex locks * Add a BUG_ON() to phy_read() phy_write() to warn against

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-22 Thread Rick Jones
When parsing the -P option in scan_socket_args() of src/nettest_bsd.c, netperf is using break_args() from src/netsh.c which indeed if the command line says -P 12345 will set both the local and remote port numbers to 12345. If instead you were to say -P 12345, it will use 12345 only for the

Re: [PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-22 Thread Jarek Poplawski
On Tue, Jan 22, 2008 at 08:54:28AM -0500, jamal wrote: On Tue, 2008-22-01 at 13:29 +0100, Jarek Poplawski wrote: On Tue, Jan 22, 2008 at 06:42:07AM -0500, jamal wrote: ... Jarek, That looks different from the suggestion from Dave. Hmm..., I'm not sure you mean my or your

Re: forcedeth oops

2008-01-22 Thread Jeff Garzik
Andrew Brooks wrote: Hello I'm getting an oops in forcedeth whenever I shutdown, details below. I've tried kernel 2.6.16.59 and the latest forcedeth.c from nvidia.com which is package-1.23 version-0.62 date-2007/04/27. How can I download the latest forcedeth.c (including 2008-01-13 patches) ?

[PATCH] [IrDA] LMP discovery timer not started by default

2008-01-22 Thread Samuel Ortiz
Hi Dave, By default, LMP sets up a 3 seconds timer for discovery. We don't need it until discovery is set to 1. This patch is against your latest net-2.6.25 tree. From: Ross Burton [EMAIL PROTECTED] Signed-off-by: Ross Burton [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] ---

[0/4] DST: Distributed storage: Succumbed to live ant.

2008-01-22 Thread Evgeniy Polyakov
Distributed storage: Succumbed to live ant. I'm pleased to announce the 14'th release of the distributed storage subsystem (DST). DST allows to form a storage on top of local and remote nodes and combine them into linear or mirroring setup, which in turn can be exported to remote nodes. This

[4/4] DST: Algorithms used in distributed storage.

2008-01-22 Thread Evgeniy Polyakov
Algorithms used in distributed storage. Mirror and linear mapping code. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/drivers/block/dst/alg_linear.c b/drivers/block/dst/alg_linear.c new file mode 100644 index 000..2f9ed65 --- /dev/null +++ b/drivers/block/dst/alg_linear.c

[3/4] DST: Network state machine.

2008-01-22 Thread Evgeniy Polyakov
Network state machine. Includes network async processing state machine and related tasks. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/drivers/block/dst/kst.c b/drivers/block/dst/kst.c new file mode 100644 index 000..4ff14ce --- /dev/null +++ b/drivers/block/dst/kst.c @@

[1/4] DST: Distributed storage documentation.

2008-01-22 Thread Evgeniy Polyakov
Distributed storage documentation. Algorithms used in the system, userspace interfaces (sysfs dirs and files), design and implementation details are described here. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/Documentation/dst/algorithms.txt

[2/4] DST: Core distributed storage files.

2008-01-22 Thread Evgeniy Polyakov
Core distributed storage files. Include userspace interfaces, initialization, block layer bindings and other core functionality. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index b4c8319..ca6592d 100644 ---

[PATCH] [AF_X25]: constify function pointer tables

2008-01-22 Thread Jan Engelhardt
Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] --- net/x25/x25_proc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/x25/x25_proc.c b/net/x25/x25_proc.c index 7d55e50..3faec8e 100644 --- a/net/x25/x25_proc.c +++ b/net/x25/x25_proc.c @@ -287,7 +287,7 @@ static const

[PATCH] [AF_RXRPC]: constify function pointer tables

2008-01-22 Thread Jan Engelhardt
Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] --- net/rxrpc/ar-call.c |2 +- net/rxrpc/ar-internal.h |6 +++--- net/rxrpc/ar-proc.c |6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/net/rxrpc/ar-call.c b/net/rxrpc/ar-call.c index 3c04b00..d923124

Re: [PATCH 2.6.23+] ingress classify to [nf]mark

2008-01-22 Thread Dzianis Kahanovich
Too many pixels to smoke. Sorry. May be so? ;)) (if undefined classid not overwrited by random value tc_classify) Even tc say to classid=0 - --- 1/net/sched/sch_ingress.c 2008-01-12 17:27:05.0 +0200 +++ 2/net/sched/sch_ingress.c 2008-01-22 22:09:32.0 +0200 @@ -136,6

WARNING, tcp_fastretrans_alert, rc6-git11

2008-01-22 Thread Denys Fedoryshchenko
Just got on one of proxies, under high load. It is a bit old rc, so probably my report not interesting, but since it is production machines, i cannot change too often. Kernel is 2.6.24-rc6-git11 Some sysctl adjustments done. Please tell me if need more information. There is rules in iptables

Re: [PATCH 0/6] PS3: gelic: gelic updates for 2.6.25

2008-01-22 Thread John W. Linville
On Thu, Dec 13, 2007 at 07:38:28PM +0900, Masakazu Mokuno wrote: Here is a set of updates for PS3 gelic network driver. This patch set requires other patches which were already submitted by Geert (http://marc.info/?l=linux-kernelm=119626095605487). [1] PS3: gelic: Fix the wrong dev_id

Re: [PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-22 Thread Rusty Russell
On Tuesday 22 January 2008 21:36:30 Herbert Xu wrote: On Wed, Jan 16, 2008 at 03:19:03PM +1100, Rusty Russell wrote: It's far easier to deal with GSO if we don't have to parse the packet to figure out the header length. Add the field to the virtio_net_hdr struct (and fix the spaces

Re: [PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-22 Thread Herbert Xu
On Wed, Jan 23, 2008 at 09:06:14AM +1100, Rusty Russell wrote: So this field is fine with me as long as it is named as such to avoid confusion since it really has nothing to do with GSO as you also need it for SG with large MTUs. Hmm, how about just hdr_len rather than gso_hdr_len?

Re: WARNING, tcp_fastretrans_alert, rc6-git11

2008-01-22 Thread Ilpo Järvinen
On Tue, 22 Jan 2008, Denys Fedoryshchenko wrote: Just got on one of proxies, under high load. It is a bit old rc, so probably my report not interesting, but since it is production machines, i cannot change too often. Kernel is 2.6.24-rc6-git11 It's not at all useless, there hasn't been any

Re: [PATCH RESEND 3/3] RDMA/cxgb3: Mark qp as privileged based on user capabilities.

2008-01-22 Thread Roland Dreier
thanks, applied 1-3 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[IPV4 7/9] fib_trie: dump table in sorted order

2008-01-22 Thread Stephen Hemminger
It is easier with TRIE to dump the data traversal rather than interating over every possible prefix. This saves some time and makes the dump come out in sorted order. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/ipv4/fib_trie.c 2008-01-22 12:58:59.0 -0800 +++

[IPV4 2/9] fib_trie: style cleanup

2008-01-22 Thread Stephen Hemminger
Style cleanups: * make check_leaf return -1 or plen, rather than by reference * Get rid of #ifdef that is always set * split out embedded function calls in if statements. * checkpatch warnings Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/ipv4/fib_trie.c

[IPV4 9/9] fib_trie: avoid rescan on dump

2008-01-22 Thread Stephen Hemminger
This converts dumping (and flushing) of large route tables form O(N^2) to O(N). If the route dump took multiple pages then the dump routine gets called again. The old code kept track of location by counter, the new code instead uses the last key. This is a really big win ( 0.3 sec vs 12 sec) for

[IPV4 6/9] fib_trie: iterator recode

2008-01-22 Thread Stephen Hemminger
Remove the complex loop structure of nextleaf() andreplace it with a simpler tree walker. This improves the performance and is much cleaner. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/ipv4/fib_trie.c 2008-01-22 09:52:46.0 -0800 +++ b/net/ipv4/fib_trie.c

[IPV4 5/9] fib_trie: dump message multiple part flag

2008-01-22 Thread Stephen Hemminger
Match fib_hash, and set NLM_F_MULTI to handle multiple part messages. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/ipv4/fib_trie.c 2008-01-21 17:52:10.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-21 17:52:11.0 -0800 @@ -1895,7 +1895,7 @@ static int

[IPV4 1/9] fib_trie: put leaf nodes in a slab cache

2008-01-22 Thread Stephen Hemminger
This improves locality for operations that touch all the leaves. Save space since these entries don't need to be hardware cache aligned. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/ipv4/fib_trie.c 2008-01-21 10:16:10.0 -0800 +++ b/net/ipv4/fib_trie.c

[IPV4 0/9] TRIE performance patches

2008-01-22 Thread Stephen Hemminger
Time to handle a full BGP load (163K of routes). Before: LoadDumpFlush hash3.5 0.50.7 2.6.23.14 3.4 19.310.3 net-2.6.25 3.4 18.79.8 After: kmem_cache 3.8

[IPV4 3/9] fib_trie: compute size when needed

2008-01-22 Thread Stephen Hemminger
Compute the number of prefixes when needed, rather than doing bookeeping. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/ipv4/fib_trie.c 2008-01-21 17:45:03.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-21 17:45:03.0 -0800 @@ -143,12 +143,12 @@ struct

[IPV4 8/9] fib_trie: avoid extra search on delete

2008-01-22 Thread Stephen Hemminger
Get rid of extra search that made route deletion O(n). Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/ipv4/fib_trie.c 2008-01-22 15:24:41.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-22 15:25:32.0 -0800 @@ -1542,49 +1542,23 @@ found: return ret; }

[IPV4 4/9] fib_trie: use hash list

2008-01-22 Thread Stephen Hemminger
The code to dump can use the existing hash chain rather than doing repeated lookup. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/net/ipv4/fib_trie.c 2008-01-21 17:45:03.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-21 17:45:08.0 -0800 @@ -2396,31 +2396,30 @@

  1   2   >