Re: [PATCH] SCTP: Fix kernel panic while received AUTH chunk while enabled auth

2008-02-05 Thread Wei Yongjun
If STCP is started while /proc/sys/net/sctp/auth_enable is set 0 and association is established between endpoints. Then if /proc/sys/net/sctp/auth_enable is set 1, a received AUTH chunk will cause kernel panic. Test as following: step 1: echo 0 /proc/sys/net/sctp/auth_enable step 2: SCTP

Re: [Wireless, ath5k] 2.6.24-git13 9135f1901ee6449dfe338adf6e40e9c2025b8150

2008-02-05 Thread Jiri Slaby
On 02/04/2008 10:40 PM, Oliver Pinter wrote: On 2/4/08, Oliver Pinter [EMAIL PROTECTED] wrote: On 2/4/08, Jiri Slaby [EMAIL PROTECTED] wrote: On 02/04/2008 03:00 PM, Oliver Pinter (Pintér Olivér) wrote: [ 413.118874] wpa_supplicant[4388]: segfault at 30 ip 080697ca sp bfc9cab0 error 4 in

Re: [PATCH] SCTP: Fix kernel panic while received AUTH chunk with BAD shared key identifier

2008-02-05 Thread Wei Yongjun
If SCTP-AUTH is enabled, received AUTH chunk with BAD shared key identifier will cause kernel panic. Test as following: step1: enabled /proc/sys/net/sctp/auth_enable step 2: connect to SCTP server with auth capable. Association is established between endpoints. Then send a AUTH chunk with a

[FIB] fix fib_proc compilation error

2008-02-05 Thread Daniel Lezcano
Subject: fix fib_proc compilation error From: Daniel Lezcano [EMAIL PROTECTED] Fix fib_proc_[init|exit] definition when CONFIG_PROCFS=no Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] --- include/net/ip_fib.h | 10 ++ 1 file changed, 10 insertions(+) Index:

RE: LRO ip_summed

2008-02-05 Thread Kostya B
1. Let's assume a driver which has a HW csum capability, however it has a privilege to assign any value for ip_summed. For example the driver assigns unnecessary for most of the packets, however it fails to verify the packets less than 96 bytes (checksum_none). Now, the LRO will aggregate all

[IPV6] fix sysctl compilation error

2008-02-05 Thread Daniel Lezcano
Subject: fix sysctl compilation error From: Daniel Lezcano [EMAIL PROTECTED] Move ipv6_icmp_sysctl_init and ipv6_route_sysctl_init into the right ifdef section otherwise that does not compile when CONFIG_SYSCTL=yes and CONFIG_PROC_FS=no Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] Acked-by:

Re: [PATCH 00/24 for-2.6.25] DM9000 updates for 2.6.25

2008-02-05 Thread Laurent Pinchart
On Tuesday 05 February 2008 01:01, Ben Dooks wrote: This patch set is a series of updates for the DM9000 driver, to tidy-up some of the source, stop the accesses to the PHY and EEPROM sitting and spinning with locks held, and to add ethtool support. This set includes a pair of patches from

Re: LRO ip_summed

2008-02-05 Thread Jan-Bernd Themann
On Tuesday 05 February 2008 09:56, Kostya B wrote: 1. Let's assume a driver which has a HW csum capability, however it has a privilege to assign any value for ip_summed. For example the driver assigns unnecessary for most of the packets, however it fails to verify the packets less than 96

Re: Slow OOM in netif_RX function

2008-02-05 Thread Ivan Mitev
[(the other) Ivan took a few days holidays, so I'm replacing him for this issue.] Andi, you spotted it, it was really the start of an IP header, and it shows up that these are ESP packets for a quite complicated VPN tunnel we have (re-routing packets from an office to another, with some NAT

[PATCH] [IPV4]: Formatting fix for /proc/net/fib_trie.

2008-02-05 Thread Denis V. Lunev
The line in the /proc/net/fib_trie for route with TOS specified - has extra \n at the end - does not have a space after route scope like below. |-- 1.1.1.1 /32 universe UNICASTtos =1 Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/fib_trie.c |3 +-- 1

Re: [IPV6] fix sysctl compilation error

2008-02-05 Thread David Miller
From: Daniel Lezcano [EMAIL PROTECTED] Date: Tue, 05 Feb 2008 10:10:05 +0100 Subject: fix sysctl compilation error From: Daniel Lezcano [EMAIL PROTECTED] Move ipv6_icmp_sysctl_init and ipv6_route_sysctl_init into the right ifdef section otherwise that does not compile when

Re: [PATCH] [NET_SCHED] Add #ifdef CONFIG_NET_EMATCH in net/sched/cls_flow.c (latest git broken build)

2008-02-05 Thread David Miller
From: Rami Rosen [EMAIL PROTECTED] Date: Sun, 3 Feb 2008 10:51:42 +0200 The 2.6 latest git build was broken when using the following configuration options: CONFIG_NET_EMATCH=n CONFIG_NET_CLS_FLOW=y with the following error: net/sched/cls_flow.c: In function 'flow_dump':

Re: [PATCH] [IPV4]: Formatting fix for /proc/net/fib_trie.

2008-02-05 Thread David Miller
From: Denis V. Lunev [EMAIL PROTECTED] Date: Tue, 5 Feb 2008 12:58:56 +0300 The line in the /proc/net/fib_trie for route with TOS specified - has extra \n at the end - does not have a space after route scope like below. |-- 1.1.1.1 /32 universe UNICASTtos =1

Re: [2.6 patch] xfrm4_beet_input(): fix an if()

2008-02-05 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Sun, 3 Feb 2008 09:22:26 +1100 On Sat, Feb 02, 2008 at 11:16:35PM +0200, Adrian Bunk wrote: A bug every C programmer makes at some point in time... Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Good catch! Acked-by: Herbert Xu [EMAIL

Re: [FIB] fix fib_proc compilation error

2008-02-05 Thread David Miller
From: Daniel Lezcano [EMAIL PROTECTED] Date: Tue, 05 Feb 2008 10:11:54 +0100 Subject: fix fib_proc compilation error From: Daniel Lezcano [EMAIL PROTECTED] Fix fib_proc_[init|exit] definition when CONFIG_PROCFS=no Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] Li Zefan already posted a

Re: [PATCH][INET]: Fix accidentally broken inet(6)_hash_connect's port offset calculations.

2008-02-05 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Mon, 04 Feb 2008 11:10:37 +0300 The port offset calculations depend on the protocol family, but, as Adrian noticed, I broke this logic with the commit 5ee31fc1ecdcbc234c8c56dcacef87c8e09909d8 [INET]: Consolidate inet(6)_hash_connect.

Re: [patch 7/7] rfcomm tty: destroy before tty_close()

2008-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 04 Feb 2008 23:48:20 -0800 From: Dave Young [EMAIL PROTECTED] rfcomm dev could be deleted in tty_hangup, so we must not call rfcomm_dev_del again to prevent from destroying rfcomm dev before tty close. Signed-off-by: Dave Young [EMAIL PROTECTED] Cc:

Re: [patch 6/7] hci_ldisc: fix null pointer deref

2008-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 04 Feb 2008 23:48:18 -0800 akpm: No idea. trollmerge. Cc: Arjan van de Ven [EMAIL PROTECTED] Cc: Alan Cox [EMAIL PROTECTED] Cc: Marcel Holtmann [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] I'll let Marcel and/or Alan take a look

Re: [patch 5/7] bluetooth: blacklist another Broadcom BCM2035 device

2008-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 04 Feb 2008 23:48:17 -0800 From: Andy Shevchenko [EMAIL PROTECTED] This device is recognized as bluetooth, but still not works. Signed-off-by: Andy Shevchenko [EMAIL PROTECTED] Cc: Marcel Holtmann [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL

Re: [patch 4/7] drivers/bluetooth/btsdio.c: fix double-free

2008-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 04 Feb 2008 23:48:16 -0800 From: Adrian Bunk [EMAIL PROTECTED] This patch fixes a double-free spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Applied. -- To unsubscribe from

Re: [patch 3/7] drivers/bluetooth/bpa10x.c: fix memleak

2008-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 04 Feb 2008 23:48:16 -0800 From: Adrian Bunk [EMAIL PROTECTED] This patch fixea a memleak spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Applied, thanks. -- To unsubscribe

Re: [patch 2/7] bluetooth: uninlining

2008-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 04 Feb 2008 23:48:15 -0800 From: Andrew Morton [EMAIL PROTECTED] Remove all those inlines which were either a) unneeded or b) increased code size. textdata bss dec hex filename before: 6997 74 870791ba7

Re: [patch 1/7] bluetooth: hidp_process_hid_control remove unnecessary parameter dealing

2008-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 04 Feb 2008 23:48:13 -0800 From: Dave Young [EMAIL PROTECTED] According to the bluetooth HID spec v1.0 chapter 7.4.2 This code requests a major state change in a BT-HID device. A HID_CONTROL request does not generate a HANDSHAKE response. A

Re: [patch 2/2] tun: impossible to deassert IFF_ONE_QUEUE or IFF_NO_PI

2008-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 04 Feb 2008 23:45:21 -0800 From: Nathaniel Filardo [EMAIL PROTECTED] Taken from http://bugzilla.kernel.org/show_bug.cgi?id=9806 The TUN/TAP driver only permits one-way transitions of IFF_NO_PI or IFF_ONE_QUEUE during the lifetime of a tap/tun interface.

Re: [PATCH] SCTP: Fix kernel panic while received AUTH chunk with BAD shared key identifier

2008-02-05 Thread David Miller
From: Wei Yongjun [EMAIL PROTECTED] Date: Tue, 05 Feb 2008 17:26:37 +0900 If SCTP-AUTH is enabled, received AUTH chunk with BAD shared key identifier will cause kernel panic. ... Signed-off-by: Wei Yongjun [EMAIL PROTECTED] Acked-by: Neil Horman [EMAIL PROTECTED] Acked-by: Vlad Yasevich

Re: [PATCH] SCTP: Fix kernel panic while received AUTH chunk while enabled auth

2008-02-05 Thread David Miller
From: Wei Yongjun [EMAIL PROTECTED] Date: Tue, 05 Feb 2008 17:21:06 +0900 If STCP is started while /proc/sys/net/sctp/auth_enable is set 0 and association is established between endpoints. Then if /proc/sys/net/sctp/auth_enable is set 1, a received AUTH chunk will cause kernel panic. ...

Re: [patch 1/2] hamradio: fix dmascc section mismatch

2008-02-05 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 04 Feb 2008 23:45:20 -0800 From: Randy Dunlap [EMAIL PROTECTED] hw[] is used in both init and exit functions so it cannot be initdata (section mismatch is when CONFIG_MODULES=n and CONFIG_DMASCC=y). WARNING: vmlinux.o(.exit.text+0xba7): Section mismatch:

Re: [NET]: Remove further references to net-modules.txt

2008-02-05 Thread David Miller
From: Johann Felix Soden [EMAIL PROTECTED] Date: Mon, 04 Feb 2008 08:31:40 +0100 From: Johann Felix Soden [EMAIL PROTECTED] The Kconfig of igb and enc28j60 contains references to obsolet Documentation/networking/net-modules.txt. Signed-off-by: Johann Felix Soden [EMAIL PROTECTED]

Re: [2.6 patch] rtnetlink.c: remove no longer used functions

2008-02-05 Thread David Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Fri, 1 Feb 2008 18:19:04 +0200 On Wed, Jan 30, 2008 at 09:04:33PM +0100, Patrick McHardy wrote: Adrian Bunk wrote: This patch #if 0's the following no longer used functions: - rtattr_parse() - rtattr_strlcpy() - __rtattr_parse_nested_compat()

Re: [PATCH] add if_addrlabel.h to sanitized headers

2008-02-05 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 31 Jan 2008 22:37:31 -0800 if_addrlabel.h is needed for iproute2 usage. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH] vlan tag match

2008-02-05 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 31 Jan 2008 21:07:32 -0800 Provide a way to use tc filters on vlan tag even if tag is buried in skb due to hardware acceleration. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied, thanks. -- To unsubscribe from this list: send

[PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.

2008-02-05 Thread Rami Rosen
Hi, When CONFIG_PROC_FS is not set and CONFIG_PPPOL2TP is set, we have the following warning in build: drivers/net/pppol2tp.c: In function 'pppol2tp_init': drivers/net/pppol2tp.c:2472: warning: label 'out_unregister_pppox_proto' defined but not used This patches fixes this warning by adding

Re: locking api self-test hanging

2008-02-05 Thread Bernhard Walle
* Andrew Morton [EMAIL PROTECTED] [2008-02-04 14:04]: but that code really needs help. Using spin_lock_irqsave() is what rtc_get_rtc_time() does which was used before I changed to get_rtc_time() does. So it should be ok. I missed that difference. However, I agree with you the whole RTC

[PATCH] virtio_net: Fix open - interrupt race

2008-02-05 Thread Christian Borntraeger
I got the following oops during interface ifup. Unfortunately its not easily reproducable so I cant say for sure that my fix fixes this problem, but I am confident and I think its correct anyway: 2kernel BUG at /space/kvm/drivers/virtio/virtio_ring.c:234! 4illegal operation: 0001 [#1]

etcnet Wi-Fi tuning

2008-02-05 Thread Van Petron
Hello, Can you help me? What can I read to solve the task: The is Altlinux installed on the computer with Ethernet card connected with the local network/Internet (DHCP) + WiFi USB stick. There is notebook with Windows XP + Wi-FI PCMCIA card. I want to connect with notebook AD-HOC: Samba,

Re: [PATCH] vlan tag match

2008-02-05 Thread Patrick McHardy
David Miller wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 31 Jan 2008 21:50:25 -0800 On Fri, 01 Feb 2008 06:34:34 +0100 Patrick McHardy [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: Provide a way to use tc filters on vlan tag even if tag is buried in skb due to hardware

[PATCH] SCTP: Fix kernel panic while received ASCONF chunk with bad serial number

2008-02-05 Thread Wei Yongjun
While recevied ASCONF chunk with serial number less then needed, kernel will treat this chunk as a retransmitted ASCONF chunk and find cached ASCONF-ACK chunk used sctp_assoc_lookup_asconf_ack(). But this function will always return NO-NULL. So response with cached ASCONF-ACKs chunk will cause

[NET_SCHED 04/04]: cls_flow: support classification based on VLAN tag

2008-02-05 Thread Patrick McHardy
[NET_SCHED]: cls_flow: support classification based on VLAN tag Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 104092e6d90cba5fa00902a3154155872d693f42 tree 0e3fd5871a861fa022bbc2f34d314bb8672b556a parent 03faf81b8195be455c3c7592d76d712ea9d80b13 author Patrick McHardy [EMAIL

[NET_SCHED 00/04]: Two fixes + cls_flow VLAN tag based classification

2008-02-05 Thread Patrick McHardy
These patches fix a compile warning in em_meta, an invalid check in the flow classifier and add VLAN tag based classification to cls_flow. Please apply, thanks. include/linux/if_vlan.h |7 --- include/linux/pkt_cls.h |1 + net/sched/cls_flow.c| 17 +++--

[VLAN 03/04]: Constify skb argument to vlan_get_tag()

2008-02-05 Thread Patrick McHardy
[VLAN]: Constify skb argument to vlan_get_tag() Required by next patch to use it from the flow classifier. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 03faf81b8195be455c3c7592d76d712ea9d80b13 tree 9da377d2bd44421494a4c4d7cf6c705d199c26ce parent

[NET_SCHED 01/04]: em_meta: fix compile warning

2008-02-05 Thread Patrick McHardy
[NET_SCHED]: em_meta: fix compile warning net/sched/em_meta.c: In function 'meta_int_vlan_tag': net/sched/em_meta.c:179: warning: 'tag' may be used uninitialized in this function Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit adfab462c5e0a32274927bba4eec3afc6e35 tree

[NET_SCHED 02/04]: cls_flow: fix key mask validity check

2008-02-05 Thread Patrick McHardy
[NET_SCHED]: cls_flow: fix key mask validity check Since we're using fls(), we need to check whether the value is non-zero first. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 2e5915ef51e55135522e59e041bb176432857d82 tree 9a42fac3d1646a378acdc91b55642b68c9d97dde parent

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Andi Kleen
On Mon, Feb 04, 2008 at 03:01:01PM -0800, Glenn Griffin wrote: Add IPv6 support to TCP SYN cookies. This is written and tested against 2.6.24, and applies cleanly to linus' current HEAD (d2fc0b). Unfortunately linus' HEAD breaks my sky2 card at the moment, so I'm unable to test against that.

[IPROUTE]: cls_flow: add vlan-tag support

2008-02-05 Thread Patrick McHardy
commit 94e9cba778cb97d77d9146dc3bd38ff195bc2c8a Author: Patrick McHardy [EMAIL PROTECTED] Date: Sat Feb 2 18:22:16 2008 +0100 [IPROUTE]: cls_flow: add vlan-tag support Signed-off-by: Patrick McHardy [EMAIL PROTECTED] diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h

Re: [PATCH] SCTP: Fix kernel panic while received ASCONF chunk with bad serial number

2008-02-05 Thread Vlad Yasevich
Wei Yongjun wrote: While recevied ASCONF chunk with serial number less then needed, kernel will treat this chunk as a retransmitted ASCONF chunk and find cached ASCONF-ACK chunk used sctp_assoc_lookup_asconf_ack(). But this function will always return NO-NULL. So response with cached

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Andi Kleen
On Tue, Feb 05, 2008 at 03:42:13PM +, Alan Cox wrote: Syncookies are discouraged these days. They disable too many valuable TCP features (window scaling, SACK) and even without them the kernel is usually strong enough to defend against syn floods and systems have much more memory

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Alan Cox
Also your sub PC class appliances rarely run LISTEN servers anyways that are open to the world. Really. The ones that first come to mind often have exposed ports including PDA devices and phones. (Ditto low end PC boxes - portscan an EEPC some day ;)) Is the other stuff enough - good question,

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Andi Kleen
On Tue, Feb 05, 2008 at 04:03:01PM +, Alan Cox wrote: Also your sub PC class appliances rarely run LISTEN servers anyways that are open to the world. Really. The ones that first come to mind often have exposed ports including PDA devices and phones. (Ditto low end PC boxes - portscan

Re: netatalk slow after system upgrade (possibly kernel problem?)

2008-02-05 Thread Michael Monnerie
(I let full quote here for reference, my text is on the bottom) On Sonntag, 27. Januar 2008 Andrew Morton wrote: (cc netdev) On Fri, 25 Jan 2008 12:55:42 +0100 Michael Monnerie [EMAIL PROTECTED] wrote: Dear lists, I've been spending a LOT of time trying to find out where's the

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Alan Cox
Syncookies are discouraged these days. They disable too many valuable TCP features (window scaling, SACK) and even without them the kernel is usually strong enough to defend against syn floods and systems have much more memory than they used to be. Somewhat untrue. Network speeds have risen

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Alan Cox
What kind of LISTEN ports? And does it matter if they're DoS'ed? I guess that depends on the opinion of the owner - Push based mobile services - Email delivery - VoIP - Management ports - Peer to peer data transfer - Instant messaging direct user/user connections Some of that can also be

Re: [PATCH] vlan tag match

2008-02-05 Thread Stephen Hemminger
On Tue, 05 Feb 2008 15:26:07 +0100 Patrick McHardy [EMAIL PROTECTED] wrote: David Miller wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 31 Jan 2008 21:50:25 -0800 On Fri, 01 Feb 2008 06:34:34 +0100 Patrick McHardy [EMAIL PROTECTED] wrote: Stephen Hemminger wrote:

Re: Still oopsing in nf_nat_move_storage()

2008-02-05 Thread Thomas Woerner
Patrick McHardy wrote: Chuck Ebbert wrote: On 01/31/2008 01:03 PM, Chuck Ebbert wrote: On 01/29/2008 12:18 PM, Patrick McHardy wrote: Chuck Ebbert wrote: nf_nat_move_storage(): /usr/src/debug/kernel-2.6.23/linux-2.6.23.i686/net/ipv4/netfilter/nf_nat_core.c:612 87: f7 47 64 80

Re: [patch 6/7] hci_ldisc: fix null pointer deref

2008-02-05 Thread Marcel Holtmann
Hi David, akpm: No idea. trollmerge. Cc: Arjan van de Ven [EMAIL PROTECTED] Cc: Alan Cox [EMAIL PROTECTED] Cc: Marcel Holtmann [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] I'll let Marcel and/or Alan take a look at this one. we might have to re-work

Re: [patch 5/7] bluetooth: blacklist another Broadcom BCM2035 device

2008-02-05 Thread Marcel Holtmann
Hi David, From: Andy Shevchenko [EMAIL PROTECTED] This device is recognized as bluetooth, but still not works. Signed-off-by: Andy Shevchenko [EMAIL PROTECTED] Cc: Marcel Holtmann [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Applied. But, what driver

[e1000][net-2.6 tree] Regression: driver doesn't detect card on my node.

2008-02-05 Thread Pavel Emelyanov
The commit 093af8d7f0ba3c6be1485973508584ef081e9f93 x86_32: trim memory by updating e820 broke my e1000 card: on loading driver says that e1000: probe of :04:03.0 failed with error -5 and the interface doesn't appear. With this commit reset everything is OK. lspci

Re: [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.

2008-02-05 Thread James Chapman
Acked-by: James Chapman [EMAIL PROTECTED] Rami Rosen wrote: Hi, When CONFIG_PROC_FS is not set and CONFIG_PPPOL2TP is set, we have the following warning in build: drivers/net/pppol2tp.c: In function 'pppol2tp_init': drivers/net/pppol2tp.c:2472: warning: label 'out_unregister_pppox_proto'

status inquiry #3 (RE: [PATCH 01/03] ISATAP V2 (header file changes))

2008-02-05 Thread Templin, Fred L
Would appreciate a status update on this submission, posted 1/15/08. Thanks - Fred [EMAIL PROTECTED] -Original Message- From: Templin, Fred L Sent: Tuesday, January 15, 2008 11:57 AM To: netdev@vger.kernel.org Cc: YOSHIFUJI Hideaki / 吉藤英明 Subject: [PATCH 01/03] ISATAP V2 (header

Re: [e1000][net-2.6 tree] Regression: driver doesn't detect card on my node.

2008-02-05 Thread Kok, Auke
[Added Ingo, Thomas, Justin who signed off on the patch/tested it] Pavel Emelyanov wrote: The commit 093af8d7f0ba3c6be1485973508584ef081e9f93 x86_32: trim memory by updating e820 broke my e1000 card: on loading driver says that e1000: probe of :04:03.0 failed

Re: [e1000][net-2.6 tree] Regression: driver doesn't detect card on my node.

2008-02-05 Thread Yinghai Lu
On Tuesday 05 February 2008 09:24:17 am Kok, Auke wrote: [Added Ingo, Thomas, Justin who signed off on the patch/tested it] Pavel Emelyanov wrote: The commit 093af8d7f0ba3c6be1485973508584ef081e9f93 x86_32: trim memory by updating e820 broke my e1000 card: on loading

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Michael Pyne [EMAIL PROTECTED] Partially revert a change to mac address detection introduced to the forcedeth driver. The change was intended to correct mac address detection for newer nVidia chipsets where the mac address was stored in reverse order. One of

Re: [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.

2008-02-05 Thread Jeff Garzik
Rami Rosen wrote: Hi, When CONFIG_PROC_FS is not set and CONFIG_PPPOL2TP is set, we have the following warning in build: drivers/net/pppol2tp.c: In function 'pppol2tp_init': drivers/net/pppol2tp.c:2472: warning: label 'out_unregister_pppox_proto' defined but not used This patches fixes

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Glenn Griffin
Syncookies are discouraged these days. They disable too many valuable TCP features (window scaling, SACK) and even without them the kernel is usually strong enough to defend against syn floods and systems have much more memory than they used to be. So I don't think it makes much sense to add

Re: [PATCH] [POWERPC] iSeries: fix section mismatch in iseries_veth

2008-02-05 Thread Jeff Garzik
Stephen Rothwell wrote: WARNING: vmlinux.o(.text+0x25dca0): Section mismatch in reference from the function .veth_probe() to the function .init.text:.veth_probe_one() Signed-off-by: Stephen Rothwell [EMAIL PROTECTED] --- drivers/net/iseries_veth.c |2 +- 1 files changed, 1 insertions(+),

Re: [patch 3/4] mv643xx_eth: fix byte order when checksum offload is enabled

2008-02-05 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Byron Bradley [EMAIL PROTECTED] The Marvell Orion system on chips have an integrated mv643xx MAC. On these little endian ARM devices mv643xx will oops when checksum offload is enabled. Swapping the byte order of the protocol and checksum solves this problem.

Re: [PATCH] xircom_cb should return NETDEV_TX_BUSY when there are no descriptors available

2008-02-05 Thread Jeff Garzik
Erik Mouw wrote: Hi, Changes in other networking paths uncovered a bug in the xircom_cb driver which made the kernel spew lots of the following error messages: BUG eth1 code -5 qlen 0 It turned out that the driver returned -EIO when there was no descriptor available for sending packets. It

Re: [PATCH 8/8] ixgbe: add real-time traffic counters

2008-02-05 Thread Jeff Garzik
Auke Kok wrote: From: Ayyappan Veeraiyan [EMAIL PROTECTED] Just like our other drivers before we can switch ixgbe to provide real-time packet/byte counters to the stack easily. Signed-off-by: Ayyappan Veeraiyan [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] ---

Re: [PATCH 1/3] Generic HDLC - fix kernel panic

2008-02-05 Thread Jeff Garzik
Krzysztof Halasa wrote: Fixes kernel panic in Frame Relay mode Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED] applied 1-3 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] sky2: fix for Yukon FE (regression in 2.6.25)

2008-02-05 Thread Jeff Garzik
Stephen Hemminger wrote: The Yukon FE chip has a ram buffer therefore it needs the alignment restriction and hang check workarounds. Therefore: * Autodetect the prescence/absence of ram buffer * Rename the flag value to reflect this * Use it consistently (ie don't reread register)

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread H. Peter Anvin
Jeff Garzik wrote: Signed-off-by: Andrew Morton [EMAIL PROTECTED] NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the specific motherboard (dmi_check_system), and flip flag according to success/failure of that check. Either that, or detect

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Jeff Garzik
H. Peter Anvin wrote: Jeff Garzik wrote: Signed-off-by: Andrew Morton [EMAIL PROTECTED] NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the specific motherboard (dmi_check_system), and flip flag according to success/failure of that check.

[PATCH] [IPV4]: Fix compiler error with CONFIG_PROC_FS=n

2008-02-05 Thread Johann Felix Soden
From: Johann Felix Soden [EMAIL PROTECTED] Handle CONFIG_PROC_FS=n in net/ipv4/fib_frontend.c because: net/ipv4/fib_frontend.c: In function 'fib_net_init': net/ipv4/fib_frontend.c:1032: error: implicit declaration of function 'fib_proc_init' net/ipv4/fib_frontend.c: In function 'fib_net_exit':

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Jeff Garzik
Andrew Morton wrote: On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Signed-off-by: Andrew Morton [EMAIL PROTECTED] NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the specific motherboard (dmi_check_system), and flip

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Ayaz Abdulla
Andrew Morton wrote: On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Signed-off-by: Andrew Morton [EMAIL PROTECTED] NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the specific motherboard (dmi_check_system), and

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Andi Kleen
On Tue, Feb 05, 2008 at 10:29:28AM -0800, Glenn Griffin wrote: Syncookies are discouraged these days. They disable too many valuable TCP features (window scaling, SACK) and even without them the kernel is usually strong enough to defend against syn floods and systems have much more memory

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Ayaz Abdulla
Jeff Garzik wrote: Ayaz Abdulla wrote: Andrew Morton wrote: On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Signed-off-by: Andrew Morton [EMAIL PROTECTED] NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Andi Kleen
The problem is that any reasonably recent PC can generate enough forged SYN packets to overwhelm reasonable SYN queues on a much more powerful server. Have you actually seen this with a recent kernel in the wild or are you just talking theoretically? Linux uses some heuristics to manage the

[patch 2.6.24-git] net/enc28j60: oops fix, low power mode

2008-02-05 Thread David Brownell
From: David Brownell [EMAIL PROTECTED] Prevent unaligned packet oops on enc28j60 packet RX. Keep enc28j60 chips in low-power mode when they're not in use. At typically 120 mA, these chips run hot even when idle. Low power mode cuts that power usage by a factor of around 100. Signed-off-by:

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Andrew Morton
On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Signed-off-by: Andrew Morton [EMAIL PROTECTED] NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the specific motherboard (dmi_check_system), and flip flag according to

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread Jeff Garzik
Ayaz Abdulla wrote: Andrew Morton wrote: On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Signed-off-by: Andrew Morton [EMAIL PROTECTED] NAK - this fixes one set of users, and breaks a working set of users. Need to add DMI check for the specific motherboard

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Ross Vandegrift
On Tue, Feb 05, 2008 at 10:29:28AM -0800, Glenn Griffin wrote: Syncookies are discouraged these days. They disable too many valuable TCP features (window scaling, SACK) and even without them the kernel is usually strong enough to defend against syn floods and systems have much more memory

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Jan Engelhardt
On Feb 5 2008 16:55, Andi Kleen wrote: On Mon, Feb 04, 2008 at 03:01:01PM -0800, Glenn Griffin wrote: Add IPv6 support to TCP SYN cookies. This is written and tested against 2.6.24, and applies cleanly to linus' current HEAD (d2fc0b). Unfortunately linus' HEAD breaks my sky2 card at the

Re: [patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-05 Thread H. Peter Anvin
Jeff Garzik wrote: Indeed, that would work too... though we would need to put out a call for Gigabyte testers during 2.6.25-rc. It is an entirely reasonable scenario for NVIDIA to deploy a fix to Gigabyte, which would then return us to the same scenario we have today: some work and some

Re: [PATCH] [IPV4]: Fix compiler error with CONFIG_PROC_FS=n

2008-02-05 Thread Denis V. Lunev
Johann Felix Soden wrote: From: Johann Felix Soden [EMAIL PROTECTED] Handle CONFIG_PROC_FS=n in net/ipv4/fib_frontend.c because: net/ipv4/fib_frontend.c: In function 'fib_net_init': net/ipv4/fib_frontend.c:1032: error: implicit declaration of function 'fib_proc_init'

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Evgeniy Polyakov
On Tue, Feb 05, 2008 at 09:02:11PM +0100, Andi Kleen ([EMAIL PROTECTED]) wrote: On Tue, Feb 05, 2008 at 10:29:28AM -0800, Glenn Griffin wrote: Syncookies are discouraged these days. They disable too many valuable TCP features (window scaling, SACK) and even without them the kernel is

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Andi Kleen
On Tue, Feb 05, 2008 at 11:39:11PM +0300, Evgeniy Polyakov wrote: On Tue, Feb 05, 2008 at 09:02:11PM +0100, Andi Kleen ([EMAIL PROTECTED]) wrote: On Tue, Feb 05, 2008 at 10:29:28AM -0800, Glenn Griffin wrote: Syncookies are discouraged these days. They disable too many valuable TCP

[PATCH] ipvs: Make wrr no available servers error message rate-limited

2008-02-05 Thread Sven Wegener
No available servers is more an error message than something informational. It should also be rate-limited, else we're going to flood our logs on a busy director, if all real servers are out of order with a weight of zero. Signed-off-by: Sven Wegener [EMAIL PROTECTED] --- Actually, do we need

Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table

2008-02-05 Thread Josh Boyer
On Thu, 31 Jan 2008 10:14:58 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Wed, 2008-01-30 at 07:16 +0100, Stefan Roese wrote: On Wednesday 16 January 2008, Josh Boyer wrote: On Wed, 16 Jan 2008 20:53:59 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Wed,

Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table

2008-02-05 Thread Benjamin Herrenschmidt
Jeff, any chance this can get into .25 soon? I have another patch queued up behind this one that requires it, and I don't see it in any of your trees or branches. Or, if you aren't opposed, I can take it through Paul's tree with your Ack. In case my it's fine wasn't enough, here's an:

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Ross Vandegrift
On Tue, Feb 05, 2008 at 09:11:06PM +0100, Andi Kleen wrote: The problem is that any reasonably recent PC can generate enough forged SYN packets to overwhelm reasonable SYN queues on a much more powerful server. Have you actually seen this with a recent kernel in the wild or are you just

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Alan Cox
How does syncookies prevent windows from growing? Enabling them doesn't. Most (if not all) distributions have them enabled and window growing works just fine. Actually I do not see any reason why connection establishment handshake should prevent any run-time operations at all, even if it

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Alan Cox
So I don't think it makes much sense to add more code to it, sorry. Distributions should then probably deactivate it by default. SUSE 10.3 for example still has it enabled on default installs. Even though I work the loyal opposition to SuSE I'd say SuSE 10.3 is correct in having it enabled

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Willy Tarreau
Hi Andi, Alan, I've run extensive tests with/without syn cookies recently. On Tue, Feb 05, 2008 at 05:39:12PM +0100, Andi Kleen wrote: On Tue, Feb 05, 2008 at 03:42:13PM +, Alan Cox wrote: Syncookies are discouraged these days. They disable too many valuable TCP features (window

[PATCH 1/5] forcedeth: restart tx/rx

2008-02-05 Thread Ayaz Abdulla
This patch fixes the issue where the transmitter and receiver must be restarted when applying new changes to certain registers. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2008-01-15 17:41:00.0 -0500 +++ new/drivers/net/forcedeth.c 2008-01-15

[PATCH 2/5] forcedeth: tx collision fix

2008-02-05 Thread Ayaz Abdulla
This patch supports a new fix in hardware regarding tx collisions. In the cases where we are in autoneg mode and the link partner is in forced mode, we need to setup the tx deferral register differently in order to reduce collisions on the wire. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED]

[PATCH 3/5] forcedeth: phy status fix

2008-02-05 Thread Ayaz Abdulla
The driver needs to ack only the phy status bits that it is currently handling and preserve the other bits for the other handlers. For example, when reading/writing from the phy, it should not clear the link change interrupt bit. This will cause a missing link change interrupt. Signed-off-by:

[PATCH 4/5] forcedeth: tx pause watermarks

2008-02-05 Thread Ayaz Abdulla
New chipsets introduced variant Rx FIFO sizes that need to be taken into account when setting up the tx pause watermarks. This patch introduces the new device feature flags based on a version and implements the new watermarks. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] ---

[PATCH 5/5] forcedeth: preserve registers

2008-02-05 Thread Ayaz Abdulla
Various registers need to be preserved before resetting the device. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2008-01-17 16:51:40.0 -0500 +++ new/drivers/net/forcedeth.c 2008-01-20 11:56:45.0 -0500 @@ -1443,16 +1443,30 @@ { struct

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Evgeniy Polyakov
On Tue, Feb 05, 2008 at 09:53:45PM +0100, Andi Kleen ([EMAIL PROTECTED]) wrote: How does syncookies prevent windows from growing? Syncookies do not allow window scaling so you can't have any windows 64k Then you meant not windows change, but the fact, that option is ignored as long as sack

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-05 Thread Evgeniy Polyakov
Hi Alan. On Tue, Feb 05, 2008 at 09:20:17PM +, Alan Cox ([EMAIL PROTECTED]) wrote: Most (if not all) distributions have them enabled and window growing works just fine. Actually I do not see any reason why connection establishment handshake should prevent any run-time operations at all,

  1   2   >