[PATCH] Fix comment for skb_pull_rcsum

2008-02-10 Thread Urs Thuermann
Fix comment for skb_pull_rcsum Signed-off-by: Urs Thuermann [EMAIL PROTECTED] --- Index: net-2.6/net/core/skbuff.c === --- net-2.6.orig/net/core/skbuff.c 2008-02-06 22:17:58.0 +0100 +++ net-2.6/net/core/skbuff.c

[RFC, PATCH]: Pass link level header from/to PPP interface

2008-02-10 Thread Urs Thuermann
The PPP interface strips off the PPP header from the packet before passing it up with netif_rx(). On the xmit path, it has to add the PPP header itself because dev-header_ops is NULL. This means that a PF_PACKET, SOCK_RAW socket can't get the link level header and has to use the sll_protocol

[PATCH resend] qla3xxx: convert byte order of constant instead of variable

2008-02-10 Thread Marcin Slusarz
convert byte order of constant instead of variable which can be done at compile time (vs run time) Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] --- drivers/net/qla3xxx.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c

Re: [RFC] ipvs: Cleanup sync daemon code

2008-02-10 Thread Sven Wegener
On Sat, 9 Feb 2008, Christoph Hellwig wrote: On Sun, Feb 10, 2008 at 12:38:11AM +0100, Sven Wegener wrote: struct ip_vs_sync_thread_data { - struct completion *startup; + struct completion *startup; /* set to NULL once completed */ This is not needed anmore. kthread_run

[PATCH v2][AX25] af_ax25: remove sock lock in ax25_info_show()

2008-02-10 Thread Jarek Poplawski
Hi, Here is a little bit better version, I hope. Regards, Jarek P. -- (take 2) Subject: [AX25] af_ax25: remove sock lock in ax25_info_show() This lockdep warning: === [ INFO: possible circular locking dependency detected ]

[PATCH] [IPV6] Minor cleanup: remove unused method declaration (net/ndisc.h).

2008-02-10 Thread Rami Rosen
Hi, This patch removes unused declaration of dflt_rt_lookup() method in include/net/ndisc.h Regards, Rami Rosen Signed-off-by: Rami Rosen [EMAIL PROTECTED] diff --git a/include/net/ndisc.h b/include/net/ndisc.h index 6684f7e..59b7062 100644 --- a/include/net/ndisc.h +++ b/include/net/ndisc.h

Re: [patch 2.6.24-git] net/enc28j60: low power mode

2008-02-10 Thread David Brownell
Keep enc28j60 chips in low-power mode when they're not in use. At typically 120 mA, these chips run hot even when idle; this low power mode cuts that power usage by a factor of around 100. This version provides a generic routine to poll a register until its masked value equals some value ... e.g.

Re: [patch 2.6.24-git] net/enc28j60: low power mode

2008-02-10 Thread David Brownell
On Thursday 07 February 2008, Claudio Lanconelli wrote: Sorry, let me repeat what I said in previous mail. I propose you to add set_lowpower(true) in the enc28j60_probe() As the current patch does... and in the enc28j60_net_close() after enc28j60_hw_disable(). Probably we don't need to

Re: [patch 2.6.24-git] net/enc28j60: oops fix, low power mode

2008-02-10 Thread David Brownell
On Thursday 07 February 2008, Claudio Lanconelli wrote: David Brownell wrote: How long did that take? I did about four dozen ifconfig eth1 up sleep 3 ifconfig eth1 down cycles ... it worked fine. The sleep was to let the link negotiation complete. After a

Re: [PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer

2008-02-10 Thread Bernard Pidoux F6BVP
Hi Jarek, Sorry, I should have been more explicit about the patches I applied. My CPU is an Intel Core 2 duo and I compiled 2.6.24 with SMP option. I applied 3 patches you have submitted for ax25 before I observed the possible locking. That is : mkiss patch diff --git

Re: [PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer

2008-02-10 Thread Jann Traschewski
Patches from Jarek applied (incl. both testing patches). Machine is stable since 2 days now. Regards, Jann -Ursprüngliche Nachricht- Von: Jarek Poplawski [mailto:[EMAIL PROTECTED] Gesendet: Mittwoch, 6. Februar 2008 10:14 An: netdev@vger.kernel.org Cc: Ralf Baechle; Jann

Re: [PATCH] New device for DM9601 usb net driver

2008-02-10 Thread Peter Korsgaard
Robert == Robert Brockway [EMAIL PROTECTED] writes: Robert Hi Peter. I've verified that the Hirose USB-100 (0x0a47, Robert 0x9601) is a clone of the DAVICOM DM9601. I patched dm9601.c Robert to identify this device and now have these in production. Robert Unified diff against 2.6.24

[PATCH] 3c509: convert to isa_driver and pnp_driver v5

2008-02-10 Thread Ondrej Zary
Hello, this patch converts 3c509 driver to isa_driver and pnp_driver. The result is that autoloading using udev and hibernation works with ISA PnP cards. It also adds hibernation support for non-PnP ISA cards. xcvr module parameter was removed as its value was not used. Tested using 3 ISA

Netfilter fixes to 2.6.24-git

2008-02-10 Thread Jan Engelhardt
Hi to everyone, I have been unable to reach the netfilter and net maintainers the past week regarding inclusion of patches, but most importantly a group of fixes at [0]-[3]. I am kind of at a loss here but to turn up the volume and write to more people on how to proceed. thanks, Jan [0]

[PATCH] drivers/net/sis190: fix section mismatch warning in sis190_get_mac_addr

2008-02-10 Thread Sergio Luis
Fix following warnings: WARNING: drivers/net/sis190.o(.text+0x103): Section mismatch in reference from the function sis190_get_mac_addr() to the function .devinit.text:sis190_get_mac_addr_from_apc() WARNING: drivers/net/sis190.o(.text+0x10e): Section mismatch in reference from the function

HTB(?) softlockup, vanilla 2.6.24

2008-02-10 Thread Denys Fedoryshchenko
It is very difficult to reproduce, happened after running about 1month. No changes done in classes at that time Feb 10 15:53:22 SHAPER [ 8271.778915] BUG: NMI Watchdog detected LOCKUP Feb 10 15:53:22 SHAPER on CPU1, eip c01f0e5d, registers: Feb 10 15:53:22 SHAPER [ 8271.778952] Modules linked

[PATCH 5/8] drivers/net/mv643xx_eth.c: Use FIELD_SIZEOF

2008-02-10 Thread Julia Lawall
From: Julia Lawall [EMAIL PROTECTED] Robert P.J. Day proposed to use the macro FIELD_SIZEOF in replace of code that matches its definition. The modification was made using the following semantic patch (http://www.emn.fr/x-info/coccinelle/) // smpl @haskernel@ @@ #include linux/kernel.h

Re: Pull request for 'r6040' branch

2008-02-10 Thread Florian Fainelli
Hi Francois, Jeff, Le mardi 5 février 2008, Francois Romieu a écrit : Please pull from branch 'r6040' in repository git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git r6040 to get the changes below. I have simply rebased the r6040 branch from december on top of Linus's

[2.6.25-rc1] Locks in udp_recvmsg()?

2008-02-10 Thread Tetsuo Handa
Hello. I found that udp_recvmsg() in net/ipv4/udp.c for 2.6.25-rc1 calls lock_sock() only when it releases the datagram (i.e. out_free: and csum_copy_err:). Is it correct to call __skb_recv_datagram() without calling lock_sock() when it acquires the datagram (i.e. try_again:)? Regards. -- To

Re: Netfilter fixes to 2.6.24-git

2008-02-10 Thread David Miller
From: Jan Engelhardt [EMAIL PROTECTED] Date: Sun, 10 Feb 2008 22:02:35 +0100 (CET) I have been unable to reach the netfilter and net maintainers the past week regarding inclusion of patches, but most importantly a group of fixes at [0]-[3]. I am kind of at a loss here but to turn up the

Re: Netfilter fixes to 2.6.24-git

2008-02-10 Thread Patrick McHardy
David Miller wrote: From: Jan Engelhardt [EMAIL PROTECTED] Date: Sun, 10 Feb 2008 22:02:35 +0100 (CET) I have been unable to reach the netfilter and net maintainers the past week regarding inclusion of patches, but most importantly a group of fixes at [0]-[3]. I am kind of at a loss here but

Re: [patch 1/2] qeth: new qeth device driver

2008-02-10 Thread Frank Blaschka
Paul E. McKenney schrieb: On Fri, Feb 08, 2008 at 03:10:00PM +0100, [EMAIL PROTECTED] wrote: From: Frank Blaschka [EMAIL PROTECTED] List of major changes and improvements: no manipulation of the global ARP constructor clean code split into core, layer 2 and layer 3 functionality better