Re: Network namespace and tc?

2008-02-14 Thread Denis V. Lunev
Hello, Stephen! Namespaces are not fully implemented yet :) Right now we we have only basic infrastructure in the mainstream and, currently, we can't even run TCP in different namespace :( We hope this will be changed very soon. These marks (net != init_net) are used to - mark places we need to

Re: Network namespace and tc?

2008-02-14 Thread Daniel Lezcano
Denis V. Lunev wrote: Hello, Stephen! Namespaces are not fully implemented yet :) Right now we we have only basic infrastructure in the mainstream and, currently, we can't even run TCP in different namespace :( We hope this will be changed very soon. These marks (net != init_net) are used to -

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-14 Thread Christoph Raisch
Dave Hansen [EMAIL PROTECTED] wrote on 13.02.2008 18:05:00: On Wed, 2008-02-13 at 16:17 +0100, Jan-Bernd Themann wrote: Constraints imposed by HW / FW: - eHEA has own MMU - eHEA Memory Regions (MRs) are used by the eHEA MMU to translate virtual addresses to absolute addresses (like

[PATCH][IPROUTE2]Add missing prefix bit length for addrlabel

2008-02-14 Thread Varun Chandramohan
The prefix bit lenght value was not updated, resulting in incorrect addrlabel entry. This patch fixes that issue. Signed-off-by: Varun Chandramohan [EMAIL PROTECTED] --- ip/ipaddrlabel.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/ip/ipaddrlabel.c b/ip/ipaddrlabel.c

[PATCH] net/enc28j60: low power mode

2008-02-14 Thread Claudio Lanconelli
Keep enc28j60 chips in low-power mode when they're not in use. At typically 120 mA, these chips run hot even when idle; this low power mode cuts that power usage by a factor of around 100. This version provides a generic routine to poll a register until its masked value equals some value ...

Re: [patch 2.6.24-git] net/enc28j60: oops fix, low power mode

2008-02-14 Thread Claudio Lanconelli
David Brownell wrote: On Monday 11 February 2008, Claudio Lanconelli wrote: I have tried your latest patch. Only after the following change it works fine (no more rx errors during ifconfig up). Hmm, what chip rev do you have? Different errata and all. ISTR mine is rev4; so, not the

[PATCH][KEY] fix bug in spdadd

2008-02-14 Thread Kazunori MIYAZAWA
This patch fix a BUG when adding spds which have same selector. Signed-off-by: Kazunori MIYAZAWA [EMAIL PROTECTED] -- Kazunori Miyazawa diff --git a/net/key/af_key.c b/net/key/af_key.c index b3ac85e..1c85392 100644 --- a/net/key/af_key.c +++ b/net/key/af_key.c @@ -2291,6 +2291,7 @@ static int

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-14 Thread Jarek Poplawski
Hi, It seems, this nice report is still uncomplete: could you check if there could have been something more yet? Thanks, Jarek P. On Tue, Feb 12, 2008 at 10:58:21AM +, James Chapman wrote: ... Here is a trace from when we had _bh locks. Feb 5 16:26:32

[DCCP] [PATCH 0/5]: Extend CCID interface so that CCID-2 stops polling

2008-02-14 Thread Gerrit Renker
This set of patches extends the packet sending/dequeuing interface, which is currently restricted to using time intervals only. This forces CCID-2 into a constant polling mode, which is removed in patch #4. Patch #1: Extends the CCID packet dequeuing interface to allow CCIDs to

[PATCH 3/5] [DCCP]: Empty the write queue when disconnecting

2008-02-14 Thread Gerrit Renker
dccp_disconnect() can be called due to several reasons: 1. when the connection setup failed (inet_stream_connect()); 2. when shutting down (inet_shutdown(), inet_csk_listen_stop()); 3. when aborting the connection (dccp_close() with 0 linger time). In case (1) the write queue is empty. This

[PATCH 4/5] [CCID2]: Stop polling

2008-02-14 Thread Gerrit Renker
This updates CCID2 to use the CCID dequeuing mechanism, converting from previous constant-polling to a now event-driven mechanism. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] --- net/dccp/ccids/ccid2.c | 21 + net/dccp/ccids/ccid2.h |5 + 2 files changed, 18

[PATCH 5/5] [CCID]: Unused argument

2008-02-14 Thread Gerrit Renker
This removes the argument `more' from ccid_hc_tx_packet_sent, since it was nowhere used in the entire code. (Anecdotally, this argument was not even used in the original KAME code where the function originally came from; compare the variable moreToSend in the

[PATCH 2/5] [CCID]: Refine the wait-for-ccid mechanism

2008-02-14 Thread Gerrit Renker
This extends the existing wait-for-ccid routine so that it may be used with different types of CCID. It further addresses the problems listed below. The code looks if the write queue is non-empty and grants the TX CCID up to `timeout' jiffies to drain the queue. It will instead purge that queue

[PATCH 1/5] [DCCP]: Extend CCID packet dequeueing interface

2008-02-14 Thread Gerrit Renker
This extends the packet dequeuing interface of dccp_write_xmit() to allow 1. CCIDs to take care of timing when the next packet may be sent; 2. delayed sending (as before, with an inter-packet gap up to 65.535 seconds). The main purpose is to take CCID2 out of its polling mode (when it is

Re: [PATCH][KEY] fix bug in spdadd

2008-02-14 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Thu, 14 Feb 2008 20:55:40 +0900), Kazunori MIYAZAWA [EMAIL PROTECTED] says: This patch fix a BUG when adding spds which have same selector. Signed-off-by: Kazunori MIYAZAWA [EMAIL PROTECTED] I think we need to fix xfrm_user side as well. --- [PATCH]

[PATCH 06/14] drivers/net/arcnet/arcnet.c: Use time_* macros

2008-02-14 Thread S . Çağlar Onur
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly Cc: netdev@vger.kernel.org

[PATCH 10/14] drivers/net/tokenring/3c359.c: Use time_* macros

2008-02-14 Thread S . Çağlar Onur
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly Cc: netdev@vger.kernel.org

[PATCH 07/14] drivers/net/ax88796.c: Use time_* macros

2008-02-14 Thread S . Çağlar Onur
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly Cc: netdev@vger.kernel.org

Re: [PATCH][RFC] race in generic address resolution

2008-02-14 Thread Benjamin Thery
Hi, It seems this patch hangs my machine very quickly when there are some ICMPv6 traffic. I'm using net-2.6, pulled today (14th Feb). I had some unexpected hangs on my SMP test machines and I bisected the problem to 69cc64d8d92bf852f933e90c888dfff083bd4fc9 [NDISC]: Fix race in generic address

broken link-local multicast?

2008-02-14 Thread Marco d'Itri
Link-local multicast appears to be broken on some interfaces of some of my firewalls. I think that this started after I configured quagga's ospf6d (which does not work because of this), but I am not totally sure. Does anybody have any idea about how to debug this? [EMAIL PROTECTED]:~# ping6 -c 1

Re: [PATCH][RFC] race in generic address resolution

2008-02-14 Thread Benjamin Thery
I ran some additional tests and these traces may also be usefull. They appears before the soft-lockup are detected. fermi:~# ping6 -c 500 -f 2007::1 PING 2007::1(2007::1) 56 data bytes . === [ INFO: possible circular locking dependency detected

Re: [PATCH 2/2] add rcu_assign_index() if ever needed

2008-02-14 Thread Paul E. McKenney
On Thu, Feb 14, 2008 at 09:02:09AM +0530, Gautham R Shenoy wrote: On Wed, Feb 13, 2008 at 02:05:15PM -0800, Paul E. McKenney wrote: Hello again! This is a speculative patch that as far as I can tell is not yet required. If anyone applies RCU to a data structure allocated out of an array,

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-14 Thread Dave Hansen
On Thu, 2008-02-14 at 09:46 +0100, Christoph Raisch wrote: Dave Hansen [EMAIL PROTECTED] wrote on 13.02.2008 18:05:00: On Wed, 2008-02-13 at 16:17 +0100, Jan-Bernd Themann wrote: Constraints imposed by HW / FW: - eHEA has own MMU - eHEA Memory Regions (MRs) are used by the eHEA MMU

[PATCH] Make sure sockets implement splice_read

2008-02-14 Thread Rémi Denis-Courmont
Fixes a segmentation fault when trying to splice from a non-TCP socket. Signed-off-by: Rémi Denis-Courmont [EMAIL PROTECTED] --- net/socket.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/net/socket.c b/net/socket.c index 7651de0..b6d35cd 100644 --- a/net/socket.c

Re: [PATCH 2.6.25] igb: fix legacy mode irq issue

2008-02-14 Thread Kok, Auke
Andy Gospodarek wrote: I booted an igb kernel with the option pci=nomsi and instantly noticed that interrupts no longer worked on my igb device. I took a look at the interrupt initialization and quickly discovered a comment stating: DO NOT USE EIAME or IAME in legacy mode It seemed a bit

Re: [PATCH 2/2] add rcu_assign_index() if ever needed

2008-02-14 Thread Randy Dunlap
On Wed, 13 Feb 2008 14:05:15 -0800 Paul E. McKenney wrote: Hello again! This is a speculative patch that as far as I can tell is not yet required. If anyone applies RCU to a data structure allocated out of an array, using array indexes in place of pointers to link the array elements

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-14 Thread Badari Pulavarty
On Thu, 2008-02-14 at 09:12 -0800, Dave Hansen wrote: .. - Use currently other not exported functions in kernel/resource.c, like walk_memory_resource (where we would still need the maximum possible number of pages NR_MEM_SECTIONS) It isn't the act of exporting that's the

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-14 Thread Dave Hansen
On Thu, 2008-02-14 at 09:36 -0800, Badari Pulavarty wrote: I am not sure what you are trying to do with walk_memory_resource(). The behavior is different on ppc64. Hotplug memory usage assumes that all the memory resources (all system memory, not just IOMEM) are represented in

[PATCH 2/2] e1000e: PCIe devices do not need to unset MANC_ARP_ENA

2008-02-14 Thread Auke Kok
From: David Graham [EMAIL PROTECTED] Users reported that ARP's were lost with e1000e. The problem is fixed by not enabling this manageability configuration bit. None of the release_manageability code is actually needed as the normal device reset during a shutdown returns everthing to the right

Re: [Bugme-new] [Bug 9990] New: tg3: eth0: The system may be re-ordering memory-mapped I/O cycles

2008-02-14 Thread Andrew Morton
On Thu, 14 Feb 2008 01:59:12 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9990 Summary: tg3: eth0: The system may be re-ordering memory-mapped I/O cycles Product: Drivers Version: 2.5

[PATCH 1/2] igb: PCIe devices do not need to unset MANC_ARP_ENA

2008-02-14 Thread Auke Kok
From: David Graham [EMAIL PROTECTED] Users reported that ARP's were lost with igb. The problem is fixed by not enabling this manageability configuration bit. None of the release_manageability code is actually needed as the normal device reset during a shutdown returns everthing to the right

Re: [RFC, PATCH]: Pass link level header from/to PPP interface

2008-02-14 Thread Urs Thuermann
David Miller [EMAIL PROTECTED] writes: Can tcpdump and libpcap already handle PPP properly? Yes, with the (admittedly non-serious) limitation, that both, tcpdump and tcpdump -e don't show the PPP header. I don't remember how tcpdump behaved on BSD in this respect (so many years ago), but I

Re: [PATCH 2/2] add rcu_assign_index() if ever needed

2008-02-14 Thread Paul E. McKenney
On Thu, Feb 14, 2008 at 09:24:27AM -0800, Randy Dunlap wrote: On Wed, 13 Feb 2008 14:05:15 -0800 Paul E. McKenney wrote: Hello again! This is a speculative patch that as far as I can tell is not yet required. If anyone applies RCU to a data structure allocated out of an array, using

Re: [Bugme-new] [Bug 9990] New: tg3: eth0: The system may be re-ordering memory-mapped I/O cycles

2008-02-14 Thread Andy Gospodarek
On Thu, Feb 14, 2008 at 10:24:25AM -0800, Andrew Morton wrote: On Thu, 14 Feb 2008 01:59:12 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9990 Summary: tg3: eth0: The system may be re-ordering memory-mapped I/O cycles

Re: [PATCH] plusb.c patched to support Belkin F5U258 USB host-to-host cable

2008-02-14 Thread David Brownell
On Thursday 14 February 2008, tony_gibbs wrote: I have tried to make the changes I have been working on and testing with your help into a patch as attached. Please let me know what you think of it. It arrived line wrapped, and turned on debug options that should stay off by default ... it

Re: [Bugme-new] [Bug 9990] New: tg3: eth0: The system may be re-ordering memory-mapped I/O cycles

2008-02-14 Thread Michael Chan
On Thu, 2008-02-14 at 13:56 -0500, Andy Gospodarek wrote: On Thu, Feb 14, 2008 at 10:24:25AM -0800, Andrew Morton wrote: On Thu, 14 Feb 2008 01:59:12 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9990 Summary: tg3: eth0: The system may

Re: [PATCH] plusb.c patched to support Belkin F5U258 USB host-to-host cable

2008-02-14 Thread tony_gibbs
Dear Dave, Thanks for the reply. I don't know why it arrived line-wrapped, and I thought I had turned DEBUG off. So I need to try again on those. What device name should be there? Just PL-25A1? or Belkin F5U258? Yes I did get it to pass data back and forth, and I posted a message to linux-usb

Re: [Bugme-new] [Bug 9990] New: tg3: eth0: The system may be re-ordering memory-mapped I/O cycles

2008-02-14 Thread Andy Gospodarek
On Thu, Feb 14, 2008 at 01:25:27PM -0800, Michael Chan wrote: On Thu, 2008-02-14 at 13:56 -0500, Andy Gospodarek wrote: On Thu, Feb 14, 2008 at 10:24:25AM -0800, Andrew Morton wrote: On Thu, 14 Feb 2008 01:59:12 -0800 (PST) [EMAIL PROTECTED] wrote:

Re: [PATCH][KEY] fix bug in spdadd

2008-02-14 Thread David Miller
From: Kazunori MIYAZAWA [EMAIL PROTECTED] Date: Thu, 14 Feb 2008 20:55:40 +0900 This patch fix a BUG when adding spds which have same selector. Signed-off-by: Kazunori MIYAZAWA [EMAIL PROTECTED] Applied, thanks! -- To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH][KEY] fix bug in spdadd

2008-02-14 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] Date: Fri, 15 Feb 2008 01:54:05 +1100 (EST) [PATCH] [XFRM]: Avoid bogus BUG() when throwing new policy away. When we destory a new policy entry, we need to tell xfrm_policy_destroy() explicitly that the entry is not alive yet. Applied.

Re: [Bugme-new] [Bug 9990] New: tg3: eth0: The system may be re-ordering memory-mapped I/O cycles

2008-02-14 Thread Michael Chan
On Thu, 2008-02-14 at 17:12 -0500, Andy Gospodarek wrote: On Thu, Feb 14, 2008 at 01:25:27PM -0800, Michael Chan wrote: On Thu, 2008-02-14 at 13:56 -0500, Andy Gospodarek wrote: That should be a simple matter of adding the right pci-ids to tg3_get_invariants -- hopefully Ralf will respond

[PATCH 2.6.24 1/1] sch_htb: fix too many events situation

2008-02-14 Thread Martin Devera
From: Martin Devera [EMAIL PROTECTED] HTB is event driven algorithm and part of its work is to apply scheduled events at proper times. It tried to defend itself from livelock by processing only limited number of events per dequeue. Because of faster computers some users already hit this hardcoded

Re: [Bugme-new] [Bug 9990] New: tg3: eth0: The system may be re-ordering memory-mapped I/O cycles

2008-02-14 Thread Andy Gospodarek
On Thu, Feb 14, 2008 at 02:48:09PM -0800, Michael Chan wrote: On Thu, 2008-02-14 at 17:12 -0500, Andy Gospodarek wrote: On Thu, Feb 14, 2008 at 01:25:27PM -0800, Michael Chan wrote: On Thu, 2008-02-14 at 13:56 -0500, Andy Gospodarek wrote: That should be a simple matter of adding the

Re: [Bugme-new] [Bug 9990] New: tg3: eth0: The system may be re-ordering memory-mapped I/O cycles

2008-02-14 Thread Michael Chan
On Thu, 2008-02-14 at 18:21 -0500, Andy Gospodarek wrote: On Thu, Feb 14, 2008 at 02:48:09PM -0800, Michael Chan wrote: Andy, I think you still missed my point. I don't believe this problem was caused by the bridge or the chipset at all. Some corruption caused us to not find the SKB in

tbench regression in 2.6.25-rc1

2008-02-14 Thread Zhang, Yanmin
Comparing with kernel 2.6.24, tbench result has regression with 2.6.25-rc1. 1) On 2 quad-core processor stoakley: 4%. 2) On 4 quad-core processor tigerton: more than 30%. bisect located below patch. b4ce92775c2e7ff9cf79cca4e0a19c8c5fd6287b is first bad commit commit

Re: [IPV6]: Fix IPsec datagram fragmentation

2008-02-14 Thread Herbert Xu
On Tue, Feb 12, 2008 at 06:08:28PM -0800, David Miller wrote: [IPV6]: Fix IPsec datagram fragmentation Applied, and I'll queue this up to -stable as well. Sorry, David Stevens just told me that it doesn't work as intended. [IPV6]: Fix reversed local_df test in ip6_fragment I managed to

[RFC PATCH] [XFRM]: Fix ordering issue in xfrm_dst_hash_transfer().

2008-02-14 Thread YOSHIFUJI Hideaki / 吉藤英明
Keep ordering of policy entries with same selector in xfrm_dst_hash_transfer(). Issue should not appear in usual cases because multiple policy entries with same selector are basically not allowed so far. Bug was pointed out by Sebastien Decugis [EMAIL PROTECTED]. We could convert bydst from

Re: tbench regression in 2.6.25-rc1

2008-02-14 Thread Eric Dumazet
Zhang, Yanmin a écrit : Comparing with kernel 2.6.24, tbench result has regression with 2.6.25-rc1. 1) On 2 quad-core processor stoakley: 4%. 2) On 4 quad-core processor tigerton: more than 30%. bisect located below patch. b4ce92775c2e7ff9cf79cca4e0a19c8c5fd6287b is first bad commit commit

Re: [IPV6]: Fix IPsec datagram fragmentation

2008-02-14 Thread Bill Fink
Hi Herbert, On Fri, 15 Feb 2008, Herbert Xu wrote: On Tue, Feb 12, 2008 at 06:08:28PM -0800, David Miller wrote: [IPV6]: Fix IPsec datagram fragmentation Applied, and I'll queue this up to -stable as well. Sorry, David Stevens just told me that it doesn't work as intended.

Re: [RFC PATCH] [XFRM]: Fix ordering issue in xfrm_dst_hash_transfer().

2008-02-14 Thread Sebastien Decugis
It works, thank you! Acked-by: Sebastien Decugis [EMAIL PROTECTED] YOSHIFUJI Hideaki / 吉藤英明 a écrit : Keep ordering of policy entries with same selector in xfrm_dst_hash_transfer(). Issue should not appear in usual cases because multiple policy entries with same selector are basically not

Re: [IPV6]: Fix IPsec datagram fragmentation

2008-02-14 Thread Herbert Xu
On Fri, Feb 15, 2008 at 01:13:13AM -0500, Bill Fink wrote: I think the setting of skb-local_def is still backwards in your original patch: You're quite right. Thanks for pointing this out! [IPV6]: Fix reversed local_df test in ip6_fragment I managed to reverse the local_df test when

Re: tbench regression in 2.6.25-rc1

2008-02-14 Thread Zhang, Yanmin
On Fri, 2008-02-15 at 07:05 +0100, Eric Dumazet wrote: Zhang, Yanmin a �crit : Comparing with kernel 2.6.24, tbench result has regression with 2.6.25-rc1. 1) On 2 quad-core processor stoakley: 4%. 2) On 4 quad-core processor tigerton: more than 30%. bisect located below patch.

Re: broken link-local multicast?

2008-02-14 Thread Pekka Savola
On Thu, 14 Feb 2008, Marco d'Itri wrote: Does anybody have any idea about how to debug this? [EMAIL PROTECTED]:~# ping6 -c 1 -I eth1 ff02::1 connect: Network is unreachable Maybe 'netstat -gn' could give clues, because you should be receiving a response at least from the loopback address.

Re: broken link-local multicast?

2008-02-14 Thread David Stevens
Pekka, I first thought the interface might be down when I saw this one, except the interface route is present in the route list he shows later. That's normally deleted when the interface is down. And a failure to be in the group just wouldn't answer-- shouldn't cause net