Re: [PATCH net] ipv4: Avoid crashing in ip_error

2015-05-22 Thread Eric Dumazet
On Fri, 2015-05-22 at 04:58 -0500, Eric W. Biederman wrote: ip_error does not check if in_dev is NULL before dereferencing it. Therefore handle this weird case by just dropping the packet if !in_dev. It will result in dropping the packet sooner, and will not result in an actual change of

[PATCH net] ipv4: Avoid crashing in ip_error

2015-05-22 Thread Eric W. Biederman
ip_error does not check if in_dev is NULL before dereferencing it. IThe following sequence of calls is possible: CPU A CPU B ip_rcv_finish ip_route_input_noref() ip_route_input_slow() inetdev_destroy() dst_input() With the

[PATCH 2/3] netfilter: ensure number of counters is 0 in do_replace()

2015-05-22 Thread Pablo Neira Ayuso
From: Dave Jones da...@codemonkey.org.uk After improving setsockopt() coverage in trinity, I started triggering vmalloc failures pretty reliably from this code path: warn_alloc_failed+0xe9/0x140 __vmalloc_node_range+0x1be/0x270 vzalloc+0x4b/0x50 __do_replace+0x52/0x260 [ip_tables]

[PATCH 3/3] Revert netfilter: bridge: query conntrack about skb dnat

2015-05-22 Thread Pablo Neira Ayuso
From: Florian Westphal f...@strlen.de This reverts commit c055d5b03bb4cb69d349d787c9787c0383abd8b2. There are two issues: 'dnat_took_place' made me think that this is related to -j DNAT/MASQUERADE. But thats only one part of the story. This is also relevant for SNAT when we undo snat

[PATCH 1/3] netfilter: nfnetlink_{log,queue}: Register pernet in first place

2015-05-22 Thread Pablo Neira Ayuso
From: Francesco Ruggeri frugg...@aristanetworks.com nfnetlink_{log,queue}_init() register the netlink callback nf*_rcv_nl_event before registering the pernet_subsys, but the callback relies on data structures allocated by pernet init functions. When nfnetlink_{log,queue} is loaded, if a netlink

[PATCH 0/3] Netfilter fixes for net

2015-05-22 Thread Pablo Neira Ayuso
Hi David, The following patchset contain Netfilter fixes for your net tree, they are: 1) Fix a race in nfnetlink_log and nfnetlink_queue that can lead to a crash. This problem is due to wrong order in the per-net registration and netlink socket events. Patch from Francesco Ruggeri. 2)

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-22 Thread Oliver Neukum
On Thu, 2015-05-21 at 22:46 +0200, Arend van Spriel wrote: On 05/21/15 19:32, Takashi Iwai wrote: Well, if the probe requires the access to a user-space file, it can't be done during resume. That's the very problem we're seeing now. The firmware loader can't help much alone if it's a new

Re: pull-request: wireless-drivers-next 2015-05-21

2015-05-22 Thread Michal Kazior
On 21 May 2015 at 15:39, Kalle Valo kv...@codeaurora.org wrote: Hi Dave, here's a wireless-drivers pull request for 4.2. This time please pay extra attention to this pull as there are two problems: First of all as you can see the diffstat from git-pull-request in the end is just weird. I

[PATCH net,stable-4.0] cdc_ncm: Fix tx_bytes statistics

2015-05-22 Thread Bjørn Mork
The tx_curr_frame_payload field is u32. When we try to calculate a small negative delta based on it, we end up with a positive integer close to 2^32 instead. So the tx_bytes pointer increases by about 2^32 for every transmitted frame. Fix by calculating the delta as a signed long. Cc: Ben

[PATCH net-next] cxgb4: Add PHY firmware support for T420-BT cards

2015-05-22 Thread Hariprasad Shenai
Add support for flashing 10GBaseT adapter with BCM 84834 PHY and Aquantia AQ1202 PHY. Updating of the PHY firmware must happen before the INITIALIZE_CMD. Signed-off-by: Hariprasad Shenai haripra...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 39 -

xen-netfront crash when detaching network while some network activity

2015-05-22 Thread Marek Marczykowski-Górecki
Hi all, I'm experiencing xen-netfront crash when doing xl network-detach while some network activity is going on at the same time. It happens only when domU has more than one vcpu. Not sure if this matters, but the backend is in another domU (not dom0). I'm using Xen 4.2.2. It happens on kernel

Re: ingress policying for realtime protocol

2015-05-22 Thread Jamal Hadi Salim
On 05/21/15 14:58, Uwe Kleine-König wrote: Hello, My picture of the network stack might be wrong, but if the ethernet driver queues say 5 packets to the network stack and the fourth is a MRP packet than a priorization that makes the fourth packet processed first would be nice. If there is

Re: pull-request: wireless-drivers-next 2015-05-21

2015-05-22 Thread Michal Kazior
On 22 May 2015 at 14:27, Kalle Valo kv...@codeaurora.org wrote: Michal Kazior michal.kaz...@tieto.com writes: On 21 May 2015 at 15:39, Kalle Valo kv...@codeaurora.org wrote: [...] + static int ath10k_vdev_start_restart(struct ath10k_vif *arvif, +const struct

Re: pull-request: wireless-drivers-next 2015-05-21

2015-05-22 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 21 May 2015 at 15:39, Kalle Valo kv...@codeaurora.org wrote: Secondly there's a non-trivial conflict in drivers/net/wireless/ath/ath10k/mac.c which is due to removal of FIF_PROMISC_IN_BSS in commit df1404650c. You need to remove more code

[PATCHv2 net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-22 Thread Linus Lüssing
Network managers like netifd (used in OpenWRT for instance) try to configure interface options after creation but before setting the interface up. Unfortunately the sysfs / bridge currently only allows to configure the hash_max and multicast_router options when the bridge interface is up. But

[PATCH v2 3/3] ARM: zynq: DT: Use the zynq binding with macb

2015-05-22 Thread Nathan Sullivan
Use the new zynq binding for macb ethernet, since it will disable half duplex gigabit like the Zynq TRM says to do. Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com --- arch/arm/boot/dts/zynq-7000.dtsi |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 1/3] net: macb: Document zynq gem dt binding

2015-05-22 Thread Nathan Sullivan
Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com --- Documentation/devicetree/bindings/net/cdns-emac.txt |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/cdns-emac.txt b/Documentation/devicetree/bindings/net/cdns-emac.txt index

[PATCH v2 2/3] net: macb: Disable half duplex gigabit on Zynq

2015-05-22 Thread Nathan Sullivan
According to the Zynq TRM, gigabit half duplex is not supported. Add a new cap and compatible string so Zynq can avoid advertising that mode. Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com --- drivers/net/ethernet/cadence/macb.c | 12 drivers/net/ethernet/cadence/macb.h |

[PATCH -next, V3 0/2] net: force refragmentation for DF reassembed skbs

2015-05-22 Thread Florian Westphal
output path tests: if (skb-len mtu) ip_fragment() This breaks connectivity in one corner case: If the skb was reassembled, but has the DF bit set and .. .. its reassembled size is = outdev mtu .. .. we will forward a DF packet larger than what the sender transmitted on wire. If a

[PATCH -next 2/2] ip_fragment: don't forward defragmented DF packet

2015-05-22 Thread Florian Westphal
We currently always send fragments without DF bit set. Thus, given following setup: mtu1500 - mtu1500:1400 - mtu1400:1280 - mtu1280 A R1 R2 B Where R1 and R2 run linux with netfilter defragmentation/conntrack enabled, then if Host A sent a fragmented packet

[PATCH -next 1/2] net: ipv4: avoid repeated calls to ip_skb_dst_mtu helper

2015-05-22 Thread Florian Westphal
ip_skb_dst_mtu is small inline helper, but its called in several places. before: 17061 44 0 1710542d1 net/ipv4/ip_output.o after: 16805 44 0 1684941d1 net/ipv4/ip_output.o Signed-off-by: Florian Westphal f...@strlen.de --- net/ipv4/ip_output.c | 19

Re: net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Mark Salyzyn
On 05/22/2015 02:50 AM, Hannes Frederic Sowa wrote: On Do, 2015-05-21 at 09:25 -0700, Mark Salyzyn wrote: got a rare NULL pointer dereference in clear_bit Signed-off-by: Mark Salyzyn saly...@android.com --- net/unix/af_unix.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v2] net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Mark Salyzyn
got a rare NULL pointer dereference in clear_bit Signed-off-by: Mark Salyzyn saly...@android.com v2: switch to sock_flag(sk, SOCK_DEAD) and added net/caif/caif_socket.c net/caif/caif_socket.c | 4 net/unix/af_unix.c | 4 2 files changed, 8 insertions(+) diff --git

Re: [PATCH net] ipv4: Avoid crashing in ip_error

2015-05-22 Thread Vittorio G (VittGam)
Il 22.05.2015 14:08 Eric Dumazet ha scritto: On Fri, 2015-05-22 at 04:58 -0500, Eric W. Biederman wrote: ip_error does not check if in_dev is NULL before dereferencing it. Therefore handle this weird case by just dropping the packet if !in_dev. It will result in dropping the packet sooner,

Re: [PATCH v4 net-next 09/11] net: Add IPv6 flow label to flow_keys

2015-05-22 Thread Tom Herbert
On Fri, May 22, 2015 at 1:14 AM, Jiri Pirko j...@resnulli.us wrote: Fri, May 22, 2015 at 02:11:44AM CEST, t...@herbertland.com wrote: In flow_dissector set the flow label in flow_keys for IPv6. This also removes the shortcircuiting of flow dissection when a non-zero label is present, the flow

Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-05-22 Thread Tom Herbert
On Fri, May 22, 2015 at 12:57 AM, Jiri Pirko j...@resnulli.us wrote: Fri, May 22, 2015 at 02:11:40AM CEST, t...@herbertland.com wrote: This patch adds full IPv6 addresses into flow_keys and uses them as input to the flow hash function. The implementation supports either IPv4 or IPv6 addresses in

Re: [PATCH v4 net-next 09/11] net: Add IPv6 flow label to flow_keys

2015-05-22 Thread Jiri Pirko
Fri, May 22, 2015 at 05:14:21PM CEST, t...@herbertland.com wrote: On Fri, May 22, 2015 at 1:14 AM, Jiri Pirko j...@resnulli.us wrote: Fri, May 22, 2015 at 02:11:44AM CEST, t...@herbertland.com wrote: In flow_dissector set the flow label in flow_keys for IPv6. This also removes the shortcircuiting

Re: [PATCH -next 2/2] ip_fragment: don't forward defragmented DF packet

2015-05-22 Thread Hannes Frederic Sowa
On Fr, 2015-05-22 at 16:32 +0200, Florian Westphal wrote: We currently always send fragments without DF bit set. Thus, given following setup: mtu1500 - mtu1500:1400 - mtu1400:1280 - mtu1280 A R1 R2 B Where R1 and R2 run linux with netfilter

RE: [PATCH v5 3/3] ixgbe: Add new ndo to trust VF

2015-05-22 Thread Rose, Gregory V
-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Hiroshi Shimamoto Sent: Thursday, May 21, 2015 7:31 PM To: Skidmore, Donald C; Kirsher, Jeffrey T; intel-wired- l...@lists.osuosl.org Cc: nhor...@redhat.com; jogre...@redhat.com;

[PATCH net-next] test_bpf: Add backward jump test case

2015-05-22 Thread Alexei Starovoitov
From: Michael Holzheu holz...@linux.vnet.ibm.com Currently the testsuite does not have a test case with a backward jump. The s390x JIT (kernel 4.0) had a bug in that area. So add one new test case for this now. Signed-off-by: Michael Holzheu holz...@linux.vnet.ibm.com Signed-off-by: Alexei

[PATCH] bridge: fix parsing of MLDv2 reports

2015-05-22 Thread Thadeu Lima de Souza Cascardo
When more than a multicast address is present in a MLDv2 report, all but the first address is ignored, because the code breaks out of the loop if there has not been an error adding that address. This has caused failures when two guests connected through the bridge tried to communicate using IPv6.

Re: [PATCH -next 1/2] net: ipv4: avoid repeated calls to ip_skb_dst_mtu helper

2015-05-22 Thread Hannes Frederic Sowa
On Fr, 2015-05-22 at 16:32 +0200, Florian Westphal wrote: ip_skb_dst_mtu is small inline helper, but its called in several places. before: 17061 44 0 1710542d1 net/ipv4/ip_output.o after: 16805 44 0 1684941d1 net/ipv4/ip_output.o Signed-off-by: Florian

Re: [PATCH v2 1/3] net: macb: Document zynq gem dt binding

2015-05-22 Thread Nicolas Ferre
Le 22/05/2015 16:22, Nathan Sullivan a écrit : Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- Documentation/devicetree/bindings/net/cdns-emac.txt |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH net-next v2 0/4] sfc: add MCDI tracing

2015-05-22 Thread Edward Cree
On 21/05/15 23:52, David Miller wrote: All of this work to allocate the buffer, add messages to it, and dump it to some user obtainable location duplicates existing infrastructure in the kernel. Please do not do this, and instead use the kernel's existing tracing infrastructure to implement

Re: [PATCH v2 2/3] net: macb: Disable half duplex gigabit on Zynq

2015-05-22 Thread Nicolas Ferre
Le 22/05/2015 16:22, Nathan Sullivan a écrit : According to the Zynq TRM, gigabit half duplex is not supported. Add a new cap and compatible string so Zynq can avoid advertising that mode. Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com

RE: [PATCH v5 2/3] if_link: Add control trust VF

2015-05-22 Thread Rose, Gregory V
-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Hiroshi Shimamoto Sent: Tuesday, May 19, 2015 5:04 PM To: Kirsher, Jeffrey T; intel-wired-...@lists.osuosl.org Cc: nhor...@redhat.com; jogre...@redhat.com; Choi, Sy Jong; Rony

Re: net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Hannes Frederic Sowa
On Fr, 2015-05-22 at 07:51 -0700, Mark Salyzyn wrote: On 05/22/2015 02:50 AM, Hannes Frederic Sowa wrote: On Do, 2015-05-21 at 09:25 -0700, Mark Salyzyn wrote: got a rare NULL pointer dereference in clear_bit Signed-off-by: Mark Salyzyn saly...@android.com --- net/unix/af_unix.c | 5

Re: [PATCH net-next] test_bpf: Add backward jump test case

2015-05-22 Thread Daniel Borkmann
On 05/22/2015 05:36 PM, Alexei Starovoitov wrote: From: Michael Holzheu holz...@linux.vnet.ibm.com Currently the testsuite does not have a test case with a backward jump. The s390x JIT (kernel 4.0) had a bug in that area. So add one new test case for this now. Signed-off-by: Michael Holzheu

Re: [Xen-devel] xen-netfront crash when detaching network while some network activity

2015-05-22 Thread David Vrabel
On 22/05/15 12:49, Marek Marczykowski-Górecki wrote: Hi all, I'm experiencing xen-netfront crash when doing xl network-detach while some network activity is going on at the same time. It happens only when domU has more than one vcpu. Not sure if this matters, but the backend is in another

Re: [PATCH] bridge: fix parsing of MLDv2 reports

2015-05-22 Thread Cong Wang
On Fri, May 22, 2015 at 8:18 AM, Thadeu Lima de Souza Cascardo casca...@redhat.com wrote: When more than a multicast address is present in a MLDv2 report, all but the first address is ignored, because the code breaks out of the loop if there has not been an error adding that address. This has

RE: [PATCH net-next 1/3] cxgb4: Add support for loopback between VI of same port

2015-05-22 Thread Casey Leedom
| From: David Miller [da...@davemloft.net] | Sent: Thursday, May 21, 2015 12:30 PM | | The prevailing assumption is that it's OK to have configuration | settings that can't be undone. | | And that's bogus from the beginning. Oh I definitely understand that and agree. Unfortunately I've

Re: [Intel-wired-lan] [PATCH v5] ixgbe: Add module parameter to disable VLAN filter

2015-05-22 Thread Alexander Duyck
On 05/21/2015 06:10 AM, Hiroshi Shimamoto wrote: From: Hiroshi Shimamoto h-shimam...@ct.jp.nec.com Introduce module parameter disable_hw_vlan_filter to disable HW VLAN filter on ixgbe module load. From the hardware limitation, there are only 64 VLAN entries for HW VLAN filter, and it leads

Re: net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Mark Salyzyn
On 05/22/2015 08:35 AM, Hannes Frederic Sowa wrote: I still wonder if we need to actually recheck the condition and not simply break out of unix_stream_data_wait: We return to the unix_stream_recvmsg loop and recheck the sk_receive_queue. At this point sk_receive_queue is not really protected

Re: [PATCHv2 net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-22 Thread Cong Wang
On Fri, May 22, 2015 at 6:32 AM, Linus Lüssing linus.luess...@c0d3.blue wrote: Changelog v2: * remove another now unnecessary -ENOENT initialization * consistently initialize to -EINVAL, allowing to shorten two switch-cases Looks perfect now. :) Thanks for update. -- To unsubscribe from this

Re: [PATCH net] ipv4: fill in table id when replacing a route

2015-05-22 Thread Alexander Duyck
On 05/22/2015 04:40 AM, Michal Kubecek wrote: When replacing an IPv4 route, tb_id member of the new fib_alias structure is not set in the replace code path so that the new route is ignored. Fixes: 0ddcf43d5d4a (ipv4: FIB Local/MAIN table collapse) Signed-off-by: Michal Kubecek mkube...@suse.cz

Re: [Xen-devel] xen-netfront crash when detaching network while some network activity

2015-05-22 Thread Marek Marczykowski-Górecki
On Fri, May 22, 2015 at 05:25:44PM +0100, David Vrabel wrote: On 22/05/15 12:49, Marek Marczykowski-Górecki wrote: Hi all, I'm experiencing xen-netfront crash when doing xl network-detach while some network activity is going on at the same time. It happens only when domU has more than

Re: [Xen-devel] xen-netfront crash when detaching network while some network activity

2015-05-22 Thread David Vrabel
On 22/05/15 17:42, Marek Marczykowski-Górecki wrote: On Fri, May 22, 2015 at 05:25:44PM +0100, David Vrabel wrote: On 22/05/15 12:49, Marek Marczykowski-Górecki wrote: Hi all, I'm experiencing xen-netfront crash when doing xl network-detach while some network activity is going on at the same

[PATCH] iproute2: update ip-link.8 for geneve tunnels

2015-05-22 Thread John W. Linville
Signed-off-by: John W. Linville linvi...@tuxdriver.com --- man/man8/ip-link.8.in | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index 714aab488d4a..8cac246d7296 100644 --- a/man/man8/ip-link.8.in +++

Re: [PATCH v3] iproute2: GENEVE support

2015-05-22 Thread John W. Linville
On Thu, May 21, 2015 at 03:19:01PM -0700, Stephen Hemminger wrote: On Wed, 13 May 2015 13:02:28 -0400 John W. Linville linvi...@tuxdriver.com wrote: Signed-off-by: John W. Linville linvi...@tuxdriver.com Applied. Please send update to man pages as well. Sorry for that oversight...coming

Re: [PATCH net,stable-4.0] cdc_ncm: Fix tx_bytes statistics

2015-05-22 Thread Bjørn Mork
On 22 May 2015 19:22:47 CEST, Ben Hutchings ben.hutchi...@codethink.co.uk wrote: On Fri, 2015-05-22 at 13:15 +0200, Bjørn Mork wrote: The tx_curr_frame_payload field is u32. When we try to calculate a small negative delta based on it, we end up with a positive integer close to 2^32 instead.

Re: [PATCH net] ipv4: Avoid crashing in ip_error

2015-05-22 Thread Vittorio G (VittGam)
Il 22.05.2015 20:24 David Miller ha scritto: Looks good, applied and queued up for -stable, thanks! That's great! I think this should also be backported up to Linux mainline 3.10, since the original commit that introduced the bug first appeared in 3.6. -- To unsubscribe from this list: send

Re: [PATCHv2 net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-22 Thread David Miller
From: Linus Lüssing linus.luess...@c0d3.blue Date: Fri, 22 May 2015 15:32:37 +0200 @@ -1786,14 +1784,8 @@ int br_multicast_set_router(struct net_bridge *br, unsigned long val) case 1: br-multicast_router = val; err = 0; - break; - -

Re: [PATCH v2 2/3] net: macb: Disable half duplex gigabit on Zynq

2015-05-22 Thread David Miller
From: Nathan Sullivan nathan.sulli...@ni.com Date: Fri, 22 May 2015 09:22:10 -0500 According to the Zynq TRM, gigabit half duplex is not supported. Add a new cap and compatible string so Zynq can avoid advertising that mode. Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com Applied. --

Re: [PATCH v2 1/3] net: macb: Document zynq gem dt binding

2015-05-22 Thread David Miller
From: Nathan Sullivan nathan.sulli...@ni.com Date: Fri, 22 May 2015 09:22:09 -0500 Signed-off-by: Nathan Sullivan nathan.sulli...@ni.com Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH -next, V3 0/2] net: force refragmentation for DF reassembed skbs

2015-05-22 Thread David Miller
From: Florian Westphal f...@strlen.de Date: Fri, 22 May 2015 16:32:49 +0200 IP (ttl 64, id 12345, offset 0, flags [+, DF], proto UDP (17), length 1204) 192.168.7.1.42 10.23.42.2.42: UDP, length 1400 IP (ttl 64, id 12345, offset 1184, flags [DF], proto UDP (17), length 244)

Re: [PATCH net-next v2 0/4] sfc: add MCDI tracing

2015-05-22 Thread David Miller
From: Edward Cree ec...@solarflare.com Date: Fri, 22 May 2015 15:49:46 +0100 On 21/05/15 23:52, David Miller wrote: All of this work to allocate the buffer, add messages to it, and dump it to some user obtainable location duplicates existing infrastructure in the kernel. Please do not do

Re: [PATCH net] ipv4: Avoid crashing in ip_error

2015-05-22 Thread David Miller
From: Vittorio G (VittGam) linuxb...@vittgam.net Date: Fri, 22 May 2015 20:48:38 +0200 Il 22.05.2015 20:24 David Miller ha scritto: Looks good, applied and queued up for -stable, thanks! That's great! I think this should also be backported up to Linux mainline 3.10, since the original

Re: [PATCH] bridge: fix parsing of MLDv2 reports

2015-05-22 Thread David Miller
From: Thadeu Lima de Souza Cascardo casca...@redhat.com Date: Fri, 22 May 2015 12:18:59 -0300 When more than a multicast address is present in a MLDv2 report, all but the first address is ignored, because the code breaks out of the loop if there has not been an error adding that address.

Re: [PATCH net-next] test_bpf: Add backward jump test case

2015-05-22 Thread David Miller
From: Alexei Starovoitov a...@plumgrid.com Date: Fri, 22 May 2015 08:36:40 -0700 From: Michael Holzheu holz...@linux.vnet.ibm.com Currently the testsuite does not have a test case with a backward jump. The s390x JIT (kernel 4.0) had a bug in that area. So add one new test case for this now.

Re: [Xen-devel] xen-netfront crash when detaching network while some network activity

2015-05-22 Thread Marek Marczykowski-Górecki
On Fri, May 22, 2015 at 05:58:41PM +0100, David Vrabel wrote: On 22/05/15 17:42, Marek Marczykowski-Górecki wrote: On Fri, May 22, 2015 at 05:25:44PM +0100, David Vrabel wrote: On 22/05/15 12:49, Marek Marczykowski-Górecki wrote: Hi all, I'm experiencing xen-netfront crash when doing xl

Re: [PATCH net-next] tcp: fix a potential deadlock in tcp_get_info()

2015-05-22 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Thu, 21 May 2015 21:51:19 -0700 From: Eric Dumazet eduma...@google.com Taking socket spinlock in tcp_get_info() can deadlock, as inet_diag_dump_icsk() holds the hashinfo-ehash_locks[i], while packet processing can use the reverse locking

Re: [PATCH net-next] tcp: fix a potential deadlock in tcp_get_info()

2015-05-22 Thread Eric Dumazet
On Fri, 2015-05-22 at 10:56 -0700, Eric Dumazet wrote: On Fri, 2015-05-22 at 13:50 -0400, David Miller wrote: This bug exists in 'net' so I've applied it there. Thanks Eric. Oh thats right, sorry for this, as you'll probably have a conflict when merging net into net-next. Also I am

Re: [patch net-next] flow_dissector: do not break if ports are not needed in flowlabel

2015-05-22 Thread David Miller
From: Jiri Pirko j...@resnulli.us Date: Fri, 22 May 2015 11:05:58 +0200 This restored previous behaviour. If caller does not want ports to be filled, we should not break. Fixes: 06635a35d13d (flow_dissect: use programable dissector in skb_flow_dissect and friends) Signed-off-by: Jiri

Re: [PATCH net] ipv4: fill in table id when replacing a route

2015-05-22 Thread David Miller
From: Michal Kubecek mkube...@suse.cz Date: Fri, 22 May 2015 13:40:09 +0200 (CEST) When replacing an IPv4 route, tb_id member of the new fib_alias structure is not set in the replace code path so that the new route is ignored. Fixes: 0ddcf43d5d4a (ipv4: FIB Local/MAIN table collapse)

Re: [PATCH net,stable-4.0] cdc_ncm: Fix tx_bytes statistics

2015-05-22 Thread David Miller
From: Bjørn Mork bj...@mork.no Date: Fri, 22 May 2015 13:15:22 +0200 The tx_curr_frame_payload field is u32. When we try to calculate a small negative delta based on it, we end up with a positive integer close to 2^32 instead. So the tx_bytes pointer increases by about 2^32 for every

Re: net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Hannes Frederic Sowa
On Fri, May 22, 2015, at 18:24, Mark Salyzyn wrote: On 05/22/2015 08:35 AM, Hannes Frederic Sowa wrote: I still wonder if we need to actually recheck the condition and not simply break out of unix_stream_data_wait: We return to the unix_stream_recvmsg loop and recheck the

Re: [PATCH net-next] tcp: fix a potential deadlock in tcp_get_info()

2015-05-22 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 22 May 2015 11:08:39 -0700 On Fri, 2015-05-22 at 11:03 -0700, Eric Dumazet wrote: Also I am wondering if not explicitly include linux/u64_stats_sync.h could break one arch... Sorry for the false alarm, we should be good because of

Re: [PATCH net] ipv4: Avoid crashing in ip_error

2015-05-22 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Fri, 22 May 2015 04:58:12 -0500 ip_error does not check if in_dev is NULL before dereferencing it. IThe following sequence of calls is possible: CPU A CPU B ip_rcv_finish ip_route_input_noref()

Re: [PATCH 0/3] Netfilter fixes for net

2015-05-22 Thread David Miller
From: Pablo Neira Ayuso pa...@netfilter.org Date: Fri, 22 May 2015 12:34:03 +0200 The following patchset contain Netfilter fixes for your net tree, they are: 1) Fix a race in nfnetlink_log and nfnetlink_queue that can lead to a crash. This problem is due to wrong order in the per-net

Re: [PATCH net] ipv4: Avoid crashing in ip_error

2015-05-22 Thread Vittorio G (VittGam)
Il 22.05.2015 21:05 David Miller ha scritto: From: Vittorio G (VittGam) linuxb...@vittgam.net Date: Fri, 22 May 2015 20:48:38 +0200 I think this should also be backported up to Linux mainline 3.10, since the original commit that introduced the bug first appeared in 3.6. Ummm, that's what

[PATCH net-next 2/4] sfc: add sysfs entry to control MCDI tracing

2015-05-22 Thread Edward Cree
MCDI tracing is enabled per-function with a sysfs file /sys/class/net/NET_DEV/device/mcdi_logging Signed-off-by: Edward Cree ec...@solarflare.com --- drivers/net/ethernet/sfc/Kconfig | 3 ++- drivers/net/ethernet/sfc/efx.c | 49 ++--

[PATCH net-next 1/4] sfc: add tracing of MCDI commands

2015-05-22 Thread Edward Cree
MCDI tracing is conditional on CONFIG_SFC_MCDI_LOGGING, which is enabled by default. Each MCDI command will produce a console line like sfc dom:bus:dev:fn ifname: MCDI RPC REQ: [...] where etc. are the raw MCDI payload in 32-bit hex chunks. The response will then

[PATCH net-next v3 0/4] sfc: add MCDI tracing

2015-05-22 Thread Edward Cree
This patchset adds support for logging MCDI (Management-Controller-to- Driver Interface) interactions between the sfc driver and a bound device, to aid in debugging. Solarflare has a tool to decode the resulting traces and will look to open-source this if there is any external interest, but the

[PATCH net-next 4/4] sfc: Initialise MCDI buffers to 0 on declaration.

2015-05-22 Thread Edward Cree
From: Jon Cooper jcoo...@solarflare.com Prevents possible kernel memory disclosure from MCDI logging if some fields of an MCDI request were not initialised, or if a response length is not a multiple of 32 bits. Signed-off-by: Edward Cree ec...@solarflare.com ---

[PATCH net-next 3/4] sfc: add module parameter to enable MCDI logging on new functions

2015-05-22 Thread Edward Cree
As many issues are encountered at probe time, where MCDI logging can't be enabled through the sysfs node, this change adds a module parameter 'mcdi_logging_default', which defaults to false. When set to true, newly- probed functions will have MCDI logging enabled. The setting can

Re: [PATCH -next, V3 0/2] net: force refragmentation for DF reassembed skbs

2015-05-22 Thread Florian Westphal
David Miller da...@davemloft.net wrote: [ cc'd Maxime Bizon ] From: Florian Westphal f...@strlen.de Date: Fri, 22 May 2015 16:32:49 +0200 IP (ttl 64, id 12345, offset 0, flags [+, DF], proto UDP (17), length 1204) 192.168.7.1.42 10.23.42.2.42: UDP, length 1400 IP (ttl 64, id

Re: [RFC PATCH 08/13] xen-netback: clone skb if skb-xmit_more is set

2015-05-22 Thread Joao Martins
On 19 May 2015, at 17:36, Wei Liu wei.l...@citrix.com wrote: On Tue, May 12, 2015 at 07:18:32PM +0200, Joao Martins wrote: On xenvif_start_xmit() we have an additional queue to the netback RX kthread that will sends the packet. When using burst1 pktgen sets skb-xmit_more to tell the driver

Re: [PATCH net-next] tcp: fix a potential deadlock in tcp_get_info()

2015-05-22 Thread Eric Dumazet
On Fri, 2015-05-22 at 11:03 -0700, Eric Dumazet wrote: Also I am wondering if not explicitly include linux/u64_stats_sync.h could break one arch... Sorry for the false alarm, we should be good because of snmp.h -- To unsubscribe from this list: send the line unsubscribe netdev in the body of

Re: [PATCH net-next] tcp: fix a potential deadlock in tcp_get_info()

2015-05-22 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 22 May 2015 10:56:36 -0700 On Fri, 2015-05-22 at 13:50 -0400, David Miller wrote: This bug exists in 'net' so I've applied it there. Thanks Eric. Oh thats right, sorry for this, as you'll probably have a conflict when merging net

Re: [PATCH net,stable-4.0] cdc_ncm: Fix tx_bytes statistics

2015-05-22 Thread Ben Hutchings
On Fri, 2015-05-22 at 13:15 +0200, Bjørn Mork wrote: The tx_curr_frame_payload field is u32. When we try to calculate a small negative delta based on it, we end up with a positive integer close to 2^32 instead. So the tx_bytes pointer increases by about 2^32 for every transmitted frame.

RE: [PATCH v5 3/3] ixgbe: Add new ndo to trust VF

2015-05-22 Thread Skidmore, Donald C
-Original Message- From: Rose, Gregory V Sent: Friday, May 22, 2015 8:08 AM To: Hiroshi Shimamoto; Skidmore, Donald C; Kirsher, Jeffrey T; intel-wired- l...@lists.osuosl.org Cc: nhor...@redhat.com; jogre...@redhat.com; Linux Netdev List; Choi, Sy Jong; Rony Efraim; David Miller;

Re: [PATCH net-next] openvswitch: include datapath actions with sampled-packet upcall to userspace

2015-05-22 Thread Pravin Shelar
On Wed, May 20, 2015 at 12:32 PM, Neil McKee neil.mc...@inmon.com wrote: Directly associate a sampled packet with the path it takes through the virtual switch. Path information currently includes mangling, encapsulation and decapsulation actions for tunneling protocols GRE, VXLAN, Geneve,

Re: [PATCH net-next] tcp: fix a potential deadlock in tcp_get_info()

2015-05-22 Thread Eric Dumazet
On Fri, 2015-05-22 at 13:50 -0400, David Miller wrote: This bug exists in 'net' so I've applied it there. Thanks Eric. Oh thats right, sorry for this, as you'll probably have a conflict when merging net into net-next. Thanks. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH net-next 1/3] cxgb4: Add support for loopback between VI of same port

2015-05-22 Thread David Miller
From: Casey Leedom lee...@chelsio.com Date: Fri, 22 May 2015 16:49:03 + Oh I definitely understand that and agree. Unfortunately I've inherited a driver architecture that makes that ... difficult for many operations ... And I have an internal bug filed against me to fix those

<    1   2