Re: [PATCH net] ipv4: Avoid crashing in ip_error

2015-05-24 Thread Julian Anastasov
Hello, On Sat, 23 May 2015, Eric Dumazet wrote: Not sure if that can help but both RCU_INIT_POINTER calls in veth_dellink can be before the unregister_netdevice_queue ones. May be it will help for the case when veth_dellink is called with head=NULL. As result, veth_xmit will

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-24 Thread Stephan Mueller
Am Sonntag, 24. Mai 2015, 11:34:20 schrieb Herbert Xu: Hi Herbert, On Sat, May 23, 2015 at 08:04:19PM +0200, Stephan Mueller wrote: Am Freitag, 22. Mai 2015, 16:31:04 schrieb Herbert Xu: Hi Herbert, This patch makes use of the new AEAD interface which uses a single SG list

Re: [linux-nfc] [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

2015-05-24 Thread Samuel Ortiz
Hi Robert, On Wed, Apr 01, 2015 at 06:35:31PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:30 AM, Samuel Ortiz sa...@linux.intel.com wrote: + /* If a patch was applied the new version is checked */ + if (patched) { + r = nci_init(ndev); + if (r)

Re: [linux-nfc] [PATCH 3/8] NFC: NCI: Adds NCI init and reset API for drivers

2015-05-24 Thread Samuel Ortiz
Hi Robert, On Tue, Mar 31, 2015 at 05:05:53PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Robert, On Tue, Feb 24, 2015 at 12:01:47PM +0200, Robert Dolca wrote: In order to communicate with the device during the setup phase,

Re: [linux-nfc] [PATCH 1/8] NFC: NCI: Allow connection close with dev down

2015-05-24 Thread Samuel Ortiz
Hi Robert, On Tue, Mar 31, 2015 at 05:03:42PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Robert, On Tue, Feb 24, 2015 at 12:01:45PM +0200, Robert Dolca wrote: By calling __nci_request instead of nci_request allows the driver

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-24 Thread Haggai Eran
On 24 May 2015 at 00:16, Larry Finger larry.fin...@lwfinger.net wrote: The driver is reporting a warning at kernel/time/timer.c:1096 due to calling del_timer_sync() while in interrupt mode. Such warnings are fixed by calling del_timer() instead. Signed-off-by: Larry Finger

Re: [PATCH] net: use msecs_to_jiffies for conversion to jiffies

2015-05-24 Thread David Miller
From: Nicholas Mc Guire hof...@osadl.org Date: Sat, 23 May 2015 15:43:36 +0200 API compliance scanning with coccinelle flagged: ./net/irda/timer.c:63:35-37: use of msecs_to_jiffies probably perferable Converting milliseconds to jiffies by val * HZ / 1000 technically is not a clean solution

[PATCH net-next] tcp/dccp: try to not exhaust ip_local_port_range in connect()

2015-05-24 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com A long standing problem on busy servers is the tiny available TCP port range (/proc/sys/net/ipv4/ip_local_port_range) and the default sequential allocation of source ports in connect() system call. If a host is having a lot of active TCP sessions, chances

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-24 Thread Larry Finger
On 05/24/2015 02:03 PM, Haggai Eran wrote: On 24 May 2015 at 00:16, Larry Finger larry.fin...@lwfinger.net wrote: The driver is reporting a warning at kernel/time/timer.c:1096 due to calling del_timer_sync() while in interrupt mode. Such warnings are fixed by calling del_timer() instead.

Re: BUG: rwlock bad magic on CPU#1, NetworkManager/

2015-05-24 Thread Jeremiah Mahler
Johannes, On Tue, May 19, 2015 at 12:15:28AM -0700, Jeremiah Mahler wrote: Johannes, You mentioned off-list that you might have a fix for this somewhere in mac80211-next. Do you have any idea when this will make it in to -next? It is still broken as of -next 20150518. -- - Jeremiah

Re: [PATCH net-next v3 0/4] sfc: add MCDI tracing

2015-05-24 Thread David Miller
From: Edward Cree ec...@solarflare.com Date: Fri, 22 May 2015 20:19:25 +0100 This patchset adds support for logging MCDI (Management-Controller-to- Driver Interface) interactions between the sfc driver and a bound device, to aid in debugging. Solarflare has a tool to decode the resulting

[RFC V7 PATCH 6/7] vhost: interrupt coalescing support

2015-05-24 Thread Jason Wang
This patch implements basic interrupt coalescing support. This is done by introducing two new per virtqueue parameters: - max_coalescced_buffers: maximum number of buffers before trying to issue an interrupt. - coalesce_usecs: maximum number of microseconds waited if at least one buffer is

[RFC V7 PATCH 5/7] virtio_net: enable tx interrupt

2015-05-24 Thread Jason Wang
This patch enable tx interrupt for virtio-net driver. This can make socket accounting works again and help to reduce the buffer bloat. To reduce the performance impacts, only enable tx interrupt on newer host with interrupt coalescing support. Signed-off-by: Jason Wang jasow...@redhat.com ---

[RFC V7 PATCH 4/7] virtio-net: add basic interrupt coalescing support

2015-05-24 Thread Jason Wang
This patch enables the interrupt coalescing setting through ethtool. Cc: Rusty Russell ru...@rustcorp.com.au Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Jason Wang jasow...@redhat.com --- drivers/net/virtio_net.c | 62

[RFC V7 PATCH 7/7] vhost_net: add interrupt coalescing support

2015-05-24 Thread Jason Wang
Signed-off-by: Jason Wang jasow...@redhat.com --- drivers/vhost/net.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 7d137a4..5ee28b7 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -320,6 +320,9 @@ static void

[RFC V7 PATCH 3/7] virtio-net: optimize free_old_xmit_skbs stats

2015-05-24 Thread Jason Wang
We already have counters for sent packets and sent bytes. Use them to reduce the number of u64_stats_update_begin/end(). Take care not to bother with stats update when called speculatively. Cc: Rusty Russell ru...@rustcorp.com.au Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Jason Wang

Re: [PATCH] net: use msecs_to_jiffies for conversion to jiffies

2015-05-24 Thread Nicholas Mc Guire
On Sun, 24 May 2015, David Miller wrote: From: Nicholas Mc Guire hof...@osadl.org Date: Sat, 23 May 2015 15:43:36 +0200 API compliance scanning with coccinelle flagged: ./net/irda/timer.c:63:35-37: use of msecs_to_jiffies probably perferable Converting milliseconds to jiffies by val

Re: [PATCH net-next] bridge: skip fdb add if the port shouldn't learn

2015-05-24 Thread David Miller
From: Nikolay Aleksandrov niko...@cumulusnetworks.com Date: Thu, 21 May 2015 03:42:57 -0700 From: Wilson Kok w...@cumulusnetworks.com Check in fdb_add_entry() if the source port should learn, similar check is used in br_fdb_update. Note that new fdb entries which are added manually or as

Re: [PATCH net-next 0/6] mlx4: Enable single ported VFs over IB ports

2015-05-24 Thread David Miller
From: Or Gerlitz ogerl...@mellanox.com Date: Thu, 21 May 2015 15:14:04 +0300 This series further enhances the support for mlx4 single ported VFs introduced in 3.15 to work over IB ports too. Just as quick reminder, the ConnectX3 device family exposes one PCI device which serves both

Re: pull-request: wireless-drivers-next 2015-05-21

2015-05-24 Thread David Miller
From: Kalle Valo kv...@codeaurora.org Date: Thu, 21 May 2015 16:39:04 +0300 here's a wireless-drivers pull request for 4.2. This time please pay extra attention to this pull as there are two problems: First of all as you can see the diffstat from git-pull-request in the end is just weird. I

Re: [PATCH net-next] cxgb4: Add PHY firmware support for T420-BT cards

2015-05-24 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Fri, 22 May 2015 21:58:21 +0530 Add support for flashing 10GBaseT adapter with BCM 84834 PHY and Aquantia AQ1202 PHY. Updating of the PHY firmware must happen before the INITIALIZE_CMD. Signed-off-by: Hariprasad Shenai

Re: [PATCH net] x86: bpf_jit: fix compilation of large bpf programs

2015-05-24 Thread David Miller
From: Alexei Starovoitov a...@plumgrid.com Date: Fri, 22 May 2015 15:42:55 -0700 x86 has variable length encoding. x86 JIT compiler is trying to pick the shortest encoding for given bpf instruction. While doing so the jump targets are changing, so JIT is doing multiple passes over the

Re: [PATCH trivial] enic: Grammar s/an negative/a negative/

2015-05-24 Thread David Miller
From: Geert Uytterhoeven geert+rene...@glider.be Date: Thu, 21 May 2015 14:09:14 +0200 Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Applied to net-next, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org

Re: [PATCH net-next v1 0/3] amd-xgbe: AMD XGBE driver updates 2015-05-22

2015-05-24 Thread David Miller
From: Tom Lendacky thomas.lenda...@amd.com Date: Fri, 22 May 2015 16:32:03 -0500 The following patches are included in this driver update series: - Retrieve and set an additional hardware feature setting - Fix the initial mode/speed determination when auto-negotiation is disabled - Add

Re: [PATCH net-next] test_bpf: add more eBPF jump torture cases

2015-05-24 Thread David Miller
From: Daniel Borkmann dan...@iogearbox.net Date: Sat, 23 May 2015 01:10:07 +0200 Add two more eBPF test cases for JITs, i.e. the second one revealed a bug in the x86_64 JIT compiler, where only an int3 filled image from the allocator was emitted and later wrongly set by the compiler as the

Re: [PATCH net] net: phy: bcm7xxx: Fix 7425 PHY ID and flags

2015-05-24 Thread David Miller
From: Florian Fainelli f.faine...@gmail.com Date: Fri, 22 May 2015 14:07:30 -0700 While adding support for 7425 PHY in the 7xxx PHY driver, the ID that was used was actually coming from an external PHY: a BCM5461x. Fix this by using the proper ID for the internal 7425 PHY and set the

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-24 Thread Sudip Mukherjee
I haven't been using kernel v4.1 so I haven't seen this warning, but looking at the code it seems to originate from the two recent patches to remove _cancel_timer and _cancel_timer_ex. I see that there's another patch in lkml [1] that changes del_timer_sync back to del_timer in more places.

Re: [PATCH v3 -next] ip: reject too-big defragmented DF-skb when forwarding

2015-05-24 Thread David Miller
From: Florian Westphal f...@strlen.de Date: Fri, 22 May 2015 00:06:40 +0200 Send icmp pmtu error if we find that the largest fragment of df-skb exceeded the output path mtu. The ip output path will still catch this later on but we can avoid the forward/postrouting hook traversal by

[PATCH v3 net-next 1/2] rocker: remove unused rocker_port parameter from rocker_port_kfree

2015-05-24 Thread Simon Horman
Remove unused rocker_port parameter from rocker_port_kfree. Also remove the rocker_port parameter from callers of rocker_port_kfree where the parameter it is now unused. Signed-off-by: Simon Horman simon.hor...@netronome.com Acked-by: Scott Feldman sfel...@gmail.com --- v3 * Rebased v2 * Added

[PATCH v3 net-next 2/2] rocker: mark parameters and local variables as const

2015-05-24 Thread Simon Horman
Mark parameters and local variables as const where possible. Signed-off-by: Simon Horman simon.hor...@netronome.com Acked-by: Scott Feldman sfel...@gmail.com --- v3 * Rebased and updated to cover new parameters and local variables that may be const * Added Scott Feldman's Ack v2 * Make more

[RFC V7 PATCH 2/7] virtio_ring: try to disable event index callbacks in virtqueue_disable_cb()

2015-05-24 Thread Jason Wang
Currently, we do nothing to prevent the callbacks in virtqueue_disable_cb() when event index is used. This may cause spurious interrupts which may damage the performance. This patch tries to publish last_used_idx as the used even to prevent the callbacks. Signed-off-by: Jason Wang

[RFC V7 PATCH 0/7] enable tx interrupts for virtio-net

2015-05-24 Thread Jason Wang
Hi: This is a new version of trying to enable tx interrupts for virtio-net. We used to try to avoid tx interrupts and orphan packets before transmission for virtio-net. This breaks socket accounting and can lead serveral other side effects e.g: - Several other functions which depends on socket

[PATCH v3 net-next 0/2] rocker: unused parameter and const cleanups

2015-05-24 Thread Simon Horman
This series provides some minor though verbose cleanup of rocker. The second patch depends on the first though it could be rebased. I had previously asked for v2 to be put on hold while some bugs I had found in the rocker driver were shaken out. That has now happened and the bugs turned out to

[RFC V7 PATCH 1/7] virito-pci: add coalescing parameters setting

2015-05-24 Thread Jason Wang
This patch introduces a transport specific methods to set or get the coalescing parameters and implement the pci methods. Signed-off-by: Jason Wang jasow...@redhat.com --- drivers/virtio/virtio_pci_modern.c | 15 +++ include/linux/virtio_config.h | 8