[PATCH net v2] enic: fix issues in enic_poll

2015-07-01 Thread Govindarajulu Varadarajan
In enic_poll, we clean tx and rx queues, when low latency busy socket polling is happening, enic_poll will only clean tx queue. After cleaning tx, it should return total budget for re-poll. There is a small window between vnic_intr_unmask() and enic_poll_unlock_napi(). In this window if an irq

Re: [PATCH 0/2] Error message clean-ups for Renesas R-Car CAN driver

2015-07-01 Thread Marc Kleine-Budde
On 06/20/2015 02:49 AM, Sergei Shtylyov wrote: Hello. Here's the set of 2 patches against Marc Kleine-Budde's 'linux-can.git' repo plus 3 fix patches just posted; they are small error message cleanups for the Renesas R-Car CAN driver. Applied both series to can/master. Thanks, Marc --

Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN

2015-07-01 Thread Joe Perches
On Wed, 2015-07-01 at 12:56 +0200, Eric Dumazet wrote: On Tue, 2015-06-30 at 20:25 +0300, Nicolae Rosia wrote: diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c [] @@ -2554,9 +2554,9 @@ static void at91ether_rx(struct net_device *dev) while

Re: macb: zynq: why is SG disabled?

2015-07-01 Thread Cyrille Pitchen
Le 01/07/2015 17:14, Nicolae Rosia a écrit : Hello, After reading the GEM part of Zynq7000 Technical Reference Manual [0], I think that SG should be supported. Is there a reason why SG is disabled in macb for Zynq? Best regards, Nicolae Rosia Hi Nicolae, when the scatter-gather patch

Re: mlx4: failed to allocate default counter port 1

2015-07-01 Thread Sebastian Ott
On Wed, 1 Jul 2015, Sebastian Ott wrote: On Wed, 1 Jul 2015, Or Gerlitz wrote: On 6/30/2015 5:17 PM, Sebastian Ott wrote: On Tue, 30 Jun 2015, Or Gerlitz wrote: On 6/30/2015 4:24 PM, Sebastian Ott wrote: Do you run the VF on the same system/kernel as the PF, or the VF is

Re: mlx4: failed to allocate default counter port 1

2015-07-01 Thread Or Gerlitz
On 6/30/2015 5:17 PM, Sebastian Ott wrote: On Tue, 30 Jun 2015, Or Gerlitz wrote: On 6/30/2015 4:24 PM, Sebastian Ott wrote: Do you run the VF on the same system/kernel as the PF, or the VF is probed to VM which runs the latest kernel and the PF runsolder kernel (which?) The latter case. The

Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN

2015-07-01 Thread Nicolae Rosia
On 07/01/2015 04:44 PM, Eric Dumazet wrote: I really doubt this adapter can process millions of packets per second ? I was suggesting this since I was taking into consideration the comment from skbuff.c, we can save several CPU cycles by avoiding having to disable and re-enable IRQs. Is there

Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN

2015-07-01 Thread Nicolae Rosia
On 07/01/2015 01:56 PM, Eric Dumazet wrote: Then please use netdev_alloc_skb_ip_align(), so that you get rid of skb_reserve() Thank you for the suggestion. I can do that. A related question, should I also replace netdev_alloc with napi_alloc_skb in places where I have a napi struct? -- To

Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN

2015-07-01 Thread Eric Dumazet
On Wed, 2015-07-01 at 16:29 +0300, Nicolae Rosia wrote: On 07/01/2015 01:56 PM, Eric Dumazet wrote: Then please use netdev_alloc_skb_ip_align(), so that you get rid of skb_reserve() Thank you for the suggestion. I can do that. A related question, should I also replace netdev_alloc with

Re: mlx4: failed to allocate default counter port 1

2015-07-01 Thread Sebastian Ott
On Wed, 1 Jul 2015, Or Gerlitz wrote: On 6/30/2015 5:17 PM, Sebastian Ott wrote: On Tue, 30 Jun 2015, Or Gerlitz wrote: On 6/30/2015 4:24 PM, Sebastian Ott wrote: Do you run the VF on the same system/kernel as the PF, or the VF is probed to VM which runs the latest kernel

[PATCH] rionet: Don't try to corrupt skbuff assigning data pointer directly

2015-07-01 Thread Alexander Sverdlin
It's not allowed to assign data pointer of skbuff directly, this makes no sense if the assigned pointer is the very same as already existing one, or it brakes all the pointer arithmetics in all other cases. We cannot do better as just compare them and report BUG() in case of mismatch.

[PULL] virtio/vhost: cross endian support

2015-07-01 Thread Michael S. Tsirkin
The following changes since commit 8a7b19d8b542b87bccc3eaaf81dcc90a5ca48aea: include/uapi/linux/virtio_balloon.h: include linux/virtio_types.h (2015-06-01 15:46:54 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for

Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN

2015-07-01 Thread Nicolas Ferre
Le 30/06/2015 19:25, Nicolae Rosia a écrit : Signed-off-by: Nicolae Rosia nicolae.ro...@certsign.ro Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks, bye. --- drivers/net/ethernet/cadence/macb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

4.1 regression in resizable hashtable tests

2015-07-01 Thread Meelis Roos
This is 4.1 on sparc64 - one of my boxes that happens to have most runtime test left on from some debugging effort. In 4.0 it was fine, 4.1 gives this in dmesg: [ 31.898697] Running resizable hashtable tests... [ 31.898915] Adding 2048 keys [ 31.952911] Traversal complete: counted=17,

Re: [RFC] COLO Proxy Module

2015-07-01 Thread Wen Congyang
On 06/30/2015 05:19 PM, Patrick McHardy wrote: On 30.06, Li Zhijian wrote: |ping... and i have another question: can i add a new |||nf_ct_ext_id simply without touching the exiting kernel code?| No, the kernel needs to know the highest extension ID in order to allocate space for the

Re: [PATCH] rtnetlink: Actually use the policy for the IFLA_VF_INFO

2015-07-01 Thread Daniel Borkmann
Hi Jason, On 07/01/2015 12:52 AM, Jason Gunthorpe wrote: It turns out the policy was defined but never actually checked, so lets check it. Fixes: ebc08a6f47ee (rtnetlink: Add VF config code to rtnetlink) I would argue that the actual commit would be ... Fixes: c02db8c6290b (rtnetlink: make

Re: [PATCH] ax88179_178a: add reset functionality in reset_resume

2015-07-01 Thread Vivek Kumar Bhagat
Hello David, I configured my email client and below patch does not have indentation issue of converting tabs into spaces. I hope it should be accepted. Thanks, Vivek --- Original Message --- Sender : Vivek Kumar Bhagatvivek.bha...@samsung.com Chief Engineer/SRI-Delhi-System S/W 1

Re: [RFC] virtio_net: Adding tx_timeout function.

2015-07-01 Thread Michael S. Tsirkin
On Wed, Jun 24, 2015 at 10:31:09PM -0300, Julio Faracco wrote: 2015-06-24 3:10 GMT-03:00 Michael S. Tsirkin m...@redhat.com: On Tue, Jun 23, 2015 at 10:44:29PM -0300, Julio Faracco wrote: virtio_net paravirtualized driver does not have a tx_timeout() function to guarantee that the

Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN

2015-07-01 Thread Eric Dumazet
On Tue, 2015-06-30 at 20:25 +0300, Nicolae Rosia wrote: Signed-off-by: Nicolae Rosia nicolae.ro...@certsign.ro --- drivers/net/ethernet/cadence/macb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.c

macb: zynq: why is SG disabled?

2015-07-01 Thread Nicolae Rosia
Hello, After reading the GEM part of Zynq7000 Technical Reference Manual [0], I think that SG should be supported. Is there a reason why SG is disabled in macb for Zynq? Best regards, Nicolae Rosia -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN

2015-07-01 Thread Nicolae Rosia
On Wed, Jul 1, 2015 at 6:33 PM, Eric Dumazet eric.duma...@gmail.com wrote: [...] This only matters in terms of few nano seconds per packet, so for 10Gb+ NIC anyway. Absolute noise for most NIC. I'll give it a try and benchmark. I achieved a huge speedup by moving TX into napi [0], but my

Re: [PATCH v4.2-rc1] printk: make extended printk support conditional on netconsole

2015-07-01 Thread Petr Mladek
On Mon 2015-06-29 19:31:40, Tejun Heo wrote: 6fe29354befe (printk: implement support for extended console drivers) implemented extended printk support for extended netconsole. The code added was miniscule but it added static 8k buffer unconditionally unnecessarily bloating the kernel for cases

Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN

2015-07-01 Thread Eric Dumazet
On Wed, 2015-07-01 at 17:29 +0300, Nicolae Rosia wrote: On 07/01/2015 04:44 PM, Eric Dumazet wrote: I really doubt this adapter can process millions of packets per second ? I was suggesting this since I was taking into consideration the comment from skbuff.c, we can save several CPU cycles

Re: [PULL] virtio/vhost: cross endian support

2015-07-01 Thread Linus Torvalds
On Wed, Jul 1, 2015 at 12:02 PM, Linus Torvalds torva...@linux-foundation.org wrote: Doing a unconditional byte swap is faster and simpler than the crazy conditionals. Unconditional endianness not only makes for simpler and faster code, it also ends up being easier to debug and add things like

Re: [PULL] virtio/vhost: cross endian support

2015-07-01 Thread Linus Torvalds
On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin m...@redhat.com wrote: virtio/vhost: cross endian support Ugh. Does this really have to be dynamic? Can't virtio do the sane thing, and just use a _fixed_ endianness? Doing a unconditional byte swap is faster and simpler than the crazy

[PATCH net-next] net: bail on sock_wfree, sock_rfree when we have a TCP_TIMEWAIT sk

2015-07-01 Thread Alex Gartrell
If we early-demux bind a TCP_TIMEWAIT socket to an skb and then orphan it (as we need to do in the ipvs forwarding case), sock_wfree and sock_rfree are going to reach into the inet_timewait_sock and mess with fields that don't exist. Signed-off-by: Alex Gartrell agartr...@fb.com ---

Re: mlx4: failed to allocate default counter port 1

2015-07-01 Thread Or Gerlitz
On Wed, Jul 1, 2015 at 5:18 PM, Sebastian Ott seb...@linux.vnet.ibm.com wrote: OK, using this patch it worked: yep, I forgot to recap err to zero. By it worked you mean the VF is live and kicking, all functionality you had before the 4.2 merge window is back again? -- To unsubscribe from this

Re: [PATCH net-next] net: bail on sock_wfree, sock_rfree when we have a TCP_TIMEWAIT sk

2015-07-01 Thread David Miller
From: Alex Gartrell agartr...@fb.com Date: Wed, 1 Jul 2015 13:13:09 -0700 If we early-demux bind a TCP_TIMEWAIT socket to an skb and then orphan it (as we need to do in the ipvs forwarding case), sock_wfree and sock_rfree are going to reach into the inet_timewait_sock and mess with fields that

[PATCH V2] cdc_ncm: Add support for moving NDP to end of NCM frame

2015-07-01 Thread Enrico Mioso
NCM specs are not actually mandating a specific position in the frame for the NDP (Network Datagram Pointer). However, some Huawei devices will ignore our aggregates if it is not placed after the datagrams it points to. Add support for doing just this, in a per-device configurable way. While at

[PATCH 1/2 net-next] tcp: reduce cwnd if retransmit is lost in CA_Loss

2015-07-01 Thread Yuchung Cheng
If the retransmission in CA_Loss is lost again, we should not continue to slow start or raise cwnd in congestion avoidance mode. Instead we should enter fast recovery and use PRR to reduce cwnd, following the principle in RFC5681: ... or the loss of a retransmission, should be taken as two

[PATCH 2/2 net-next] tcp: PRR uses CRB mode by default and SS mode conditionally

2015-07-01 Thread Yuchung Cheng
PRR slow start is often too aggressive especially when drops are caused by traffic policers. The policers mainly use token bucket to enforce the rate so sending (twice) faster than the delivery rate causes excessive drops. This patch changes PRR to the conservative reduction bound (CRB) mode in

[PATCH 0/2 net-next] tcp: reducing lost retransmits in recovery

2015-07-01 Thread Yuchung Cheng
This patch series reduces lost retransmits in recovery, in particular when dealing with traffic policers. The main problem is that slow start in recovery under policing can cause massive lost and retransmit storms: any excess sending rate turns into drops. The solution is to avoid doing slow start

Re: [PATCH net-next] net: bail on sock_wfree, sock_rfree when we have a TCP_TIMEWAIT sk

2015-07-01 Thread Eric Dumazet
On Wed, Jul 1, 2015 at 11:14 PM, David Miller da...@davemloft.net wrote: From: Alex Gartrell agartr...@fb.com Date: Wed, 1 Jul 2015 13:13:09 -0700 If we early-demux bind a TCP_TIMEWAIT socket to an skb and then orphan it (as we need to do in the ipvs forwarding case), sock_wfree and

Re: [PATCH] ax88179_178a: add reset functionality in reset_resume

2015-07-01 Thread David Miller
From: Vivek Kumar Bhagat vivek.bha...@samsung.com Date: Wed, 01 Jul 2015 11:33:58 + (GMT) I configured my email client and below patch does not have indentation issue of converting tabs into spaces. I hope it should be accepted. Patchwork is not recognizing your postings as a patch

Re: Wiring up direct socket calls on x86_32 Linux?

2015-07-01 Thread Tulio Magno Quites Machado Filho
Andy Lutomirski l...@amacapital.net writes: Hi all- sys_socketcall sucks. If nothing else, it's impossible to filter with seccomp. Should we wire up the real socket calls so that user code can (very slowly) start migrating? I think the list is: - socket - bind - connect - listen

Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN

2015-07-01 Thread Eric Dumazet
On Wed, 2015-07-01 at 18:53 +0300, Nicolae Rosia wrote: On Wed, Jul 1, 2015 at 6:33 PM, Eric Dumazet eric.duma...@gmail.com wrote: [...] This only matters in terms of few nano seconds per packet, so for 10Gb+ NIC anyway. Absolute noise for most NIC. I'll give it a try and benchmark. I

Re: [PATCH net] enic: fix issues in enic_poll

2015-07-01 Thread David Miller
From: Govindarajulu Varadarajan _gov...@gmx.com Date: Wed, 1 Jul 2015 11:23:54 +0530 Current code checks only rx work done to complete napi. It completely ignores tx work done. If we have only tx packets to clean and no rq work, we always napi complete instead of re-poll. Change this behavior

iproute 4.1.1

2015-07-01 Thread Stephen Hemminger
I am putting out iproute2 4.1.1 (ie stable) on Monday. Will include fixes for MPLS and TIPC that are already in latest (master). Is there any other fixes which people think are urgent enough to backport. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

[PATCH] ipv6: Make MLD packets to only be processed locally.

2015-07-01 Thread Angga
Before commit daad151263cf334 (ipv6: Make ipv6_is_mld() inline and use it from ip6_mc_input(). MLD packets were only processed locally. After the change, a copy of MLD packet goes through ip6_mr_input, causing MRT6MSG_NOCACHE message to be generated to user space. Make MLD packet only processed

Issue with active-backup mode bond and bridge

2015-07-01 Thread pengyi Peng(Yi)
I find that kernel seems to be not well handled with the combination of bonding and bridge module. I have a physical host with two nics that are bonded together (active backup mode). Each nic is connected to a separate L2 switch. And the two L2 switchs are connected to a L3 switch. If the

Re: [PATCH 1/1] net namespace: dynamically configure new net namespace inherit net config

2015-07-01 Thread yzhu1
Hi, David This patch is applied in our linux for a long time. It should work well. Would you like to let me know your advice about this patch? Thanks a lot. Zhu Yanjun On 06/26/2015 05:37 PM, Zhu Yanjun wrote: The new net namespace can inherit from the original net config, or the current net

RE: macb: zynq: why is SG disabled?

2015-07-01 Thread Punnaiah Choudary Kalluri
Hi Nicolae and Cyrille, SG feature was not tested for Zynq using macb driver but tested it using the emacps Driver in Xilinx tree (this driver is deprecated recently) We will test and enable this feature in driver for Zynq. Regards, Punnaiah -Original Message- From: Cyrille

Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN

2015-07-01 Thread Eric Dumazet
On Wed, 2015-07-01 at 10:06 -0700, Joe Perches wrote: On Wed, 2015-07-01 at 12:56 +0200, Eric Dumazet wrote: On Tue, 2015-06-30 at 20:25 +0300, Nicolae Rosia wrote: diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c [] @@ -2554,9 +2554,9 @@ static

Re: [PATCH net-next] net: bail on sock_wfree, sock_rfree when we have a TCP_TIMEWAIT sk

2015-07-01 Thread Eric Dumazet
On Thu, 2015-07-02 at 01:26 +0200, Eric Dumazet wrote: On Thu, Jul 2, 2015 at 1:18 AM, Alex Gartrell alexgartr...@gmail.com wrote: On Wednesday, July 1, 2015, Eric Dumazet eduma...@google.com wrote: On Wed, Jul 1, 2015 at 11:14 PM, David Miller da...@davemloft.net wrote: From: Alex

[PATCH] add stealth mode

2015-07-01 Thread Matteo Croce
Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP Dest-Unreach for UDP. Also disables ICMP replies to echo request and timestamp. The stealth mode can be enabled selectively for a single interface. --- include/linux/inetdevice.h | 1 +

Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN

2015-07-01 Thread Joe Perches
On Thu, 2015-07-02 at 00:13 +0200, Eric Dumazet wrote: On Wed, 2015-07-01 at 10:06 -0700, Joe Perches wrote: On Wed, 2015-07-01 at 12:56 +0200, Eric Dumazet wrote: On Tue, 2015-06-30 at 20:25 +0300, Nicolae Rosia wrote: diff --git a/drivers/net/ethernet/cadence/macb.c

Re: [PATCH net-next] net: bail on sock_wfree, sock_rfree when we have a TCP_TIMEWAIT sk

2015-07-01 Thread Eric Dumazet
On Thu, Jul 2, 2015 at 1:18 AM, Alex Gartrell alexgartr...@gmail.com wrote: On Wednesday, July 1, 2015, Eric Dumazet eduma...@google.com wrote: On Wed, Jul 1, 2015 at 11:14 PM, David Miller da...@davemloft.net wrote: From: Alex Gartrell agartr...@fb.com Date: Wed, 1 Jul 2015 13:13:09 -0700

Re: [PATCH net-next v1 1/1] drivers: net: xgene: Fix the compilation error error: implicit declaration of function 'acpi_evaluate_integer' in APM X-Gene ethernet driver.

2015-07-01 Thread Suman Tripathi
Hi , Any comments on this patch . On Wed, Jun 24, 2015 at 1:51 PM, Suman Tripathi stripa...@apm.com wrote: This patch guards the acpi_evaluate_interger function as it fails the build for NON_ACPI CONFIG. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Suman Tripathi

Re: [PATCH net-next] net: bail on sock_wfree, sock_rfree when we have a TCP_TIMEWAIT sk

2015-07-01 Thread Alex Gartrell
On Wed, Jul 1, 2015 at 4:26 PM, Eric Dumazet eduma...@google.com wrote: I think you are mistaken Alex. Indeed, I was! Should be unsurpising. socket early demux cannot possibly set skb-destructor to sock_rfree() Yeah I will admit adding the code to sock_rfree reflexively out of paranoia.