Re: [PATCH net 2/2] r8152: reset device when tx timeout

2015-07-28 Thread Oliver Neukum
On Tue, 2015-07-28 at 15:36 +0800, Hayes Wang wrote: The device reset is necessary if the hw becomes abnormal and stops transmitting packets. You are not the first one to face this problem. Hence there is a helper: * usb_queue_reset_device - Reset a USB device from an atomic context *

Re: [PATCH net 1/2] r8152: add pre_reset and post_reset

2015-07-28 Thread Oliver Neukum
On Tue, 2015-07-28 at 15:36 +0800, Hayes Wang wrote: Add rtl8152_pre_reset() and rtl8152_post_reset() which are used when calling usb_reset_device(). The two functions could reduce the time of reset when calling usb_reset_device() after probe(). Signed-off-by: Hayes Wang

[PATCH] Drivers: isdn: Drop unnecessary continue

2015-07-28 Thread Shraddha Barke
The semantic patch used to make this change is : @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Shraddha Barke shraddha.6...@gmail.com --- drivers/isdn/hardware/mISDN/hfcsusb.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH net-next 3/4] dwc_eth_qos: Add the synopsys folder to the build system.

2015-07-28 Thread Lars Persson
Signed-off-by: Lars Persson lar...@axis.com --- drivers/net/ethernet/Kconfig | 1 + drivers/net/ethernet/Makefile | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig index f3bb178..05aa759 100644 --- a/drivers/net/ethernet/Kconfig +++

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-28 Thread Michal Kubecek
On Tue, Jul 28, 2015 at 02:27:57AM +, Richard Laing wrote: From: Richard Laing richard.la...@alliedtelesis.co.nz Enable flow-based ECMP. Currently if equal-cost multipath is enabled the kernel chooses between equal cost paths for each matching packet, essentially packets are

[PATCH] Drivers: isdn: Drop unnecessary continue

2015-07-28 Thread Shraddha Barke
The semantic patch used to make this change is : @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Shraddha Barke shraddha.6...@gmail.com --- drivers/isdn/hardware/mISDN/hfcsusb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

RE: [PATCH v1 net-next 1/1] net: fec: add stop mode request on/off implemention

2015-07-28 Thread Duan Andy
Hi, David, From: Duan Fugang-B38611 Sent: Monday, July 27, 2015 9:28 AM To: 'David Miller' Cc: netdev@vger.kernel.org; Li Frank-B20596; step...@networkplumber.org Subject: RE: [PATCH v1 net-next 1/1] net: fec: add stop mode request on/off implemention From: David Miller da...@davemloft.net

RE: [PATCH net 2/2] r8152: reset device when tx timeout

2015-07-28 Thread Hayes Wang
Oliver Neukum [mailto:oneu...@suse.com] Sent: Tuesday, July 28, 2015 4:57 PM [...] * usb_queue_reset_device - Reset a USB device from an atomic context * @iface: USB interface belonging to the device to reset * * This function can be used to reset a USB device from an atomic * context,

[PATCH net-next 4/4] dwc_eth_qos: Add maintainer info

2015-07-28 Thread Lars Persson
Add maintainer information for the Synopsys DWC Ethernet QOS driver. Signed-off-by: Lars Persson lar...@axis.com --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a226416..0c78766 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8903,6

[PATCH net-next 2/4] dwc_eth_qos: Add support for Synopsys DWC Ethernet QoS

2015-07-28 Thread Lars Persson
This patch adds a platform driver for the new generation of the gigabit ethernet IP from Synopsys. It is developed for version 4.10a of the IP core. Signed-off-by: Lars Persson lar...@axis.com --- drivers/net/ethernet/synopsys/Kconfig | 27 + drivers/net/ethernet/synopsys/Makefile |

[PATCH net-next 1/4] dwc_eth_qos: Add Synopsys DWC Ethernet QoS bindings

2015-07-28 Thread Lars Persson
Add device tree binding documentation for the Synopsys DWC Ethernet QoS driver supporting revision 4.10a of the hardware IP. Signed-off-by: Lars Persson lar...@axis.com --- .../bindings/net/snps,dwc-qos-ethernet.txt | 75 ++ 1 file changed, 75 insertions(+) create

Re: [PATCH] Drivers: isdn: Drop unnecessary continue

2015-07-28 Thread Julia Lawall
On Tue, 28 Jul 2015, Shraddha Barke wrote: The semantic patch used to make this change is : @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Shraddha Barke shraddha.6...@gmail.com --- drivers/isdn/hardware/mISDN/hfcsusb.c | 1 - 1 file

Re: [PATCH net-next 0/4] net/mlx4_en: Hardware accelerated 802.1ad

2015-07-28 Thread Or Gerlitz
On 7/28/2015 1:00 AM, David Miller wrote: Series applied, thanks. Hi Dave, I don't see this on your kernel.org clone.. maybe forgot to press on the push button? Or. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More

[PATCH net 2/2] r8152: reset device when tx timeout

2015-07-28 Thread Hayes Wang
The device reset is necessary if the hw becomes abnormal and stops transmitting packets. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/net/usb/r8152.c

[PATCH net 1/2] r8152: add pre_reset and post_reset

2015-07-28 Thread Hayes Wang
Add rtl8152_pre_reset() and rtl8152_post_reset() which are used when calling usb_reset_device(). The two functions could reduce the time of reset when calling usb_reset_device() after probe(). Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 68

[PATCH net 0/2] r8152: device reset

2015-07-28 Thread Hayes Wang
Although the driver works normally, we find the device may get all 0xff data when tranmitting packets on certain platforms. It would break the device and no packet could be transmitted. The reset is necessary to recover the hw for this situation. Hayes Wang (2): r8152: add pre_reset and

[PATCH] mac80211: fix invalid read in minstrel_sort_best_tp_rates()

2015-07-28 Thread Adrien Schildknecht
At the last iteration of the loop, j may equal zero and thus tp_list[j - 1] causes an invalid read. Changed the logic of the loop so that j - 1 is always = 0. Signed-off-by: Adrien Schildknecht adrien+...@schischi.me --- net/mac80211/rc80211_minstrel.c | 11 ++- 1 file changed, 6

Re: [PATCH net-next 0/4] net/mlx4_en: Hardware accelerated 802.1ad

2015-07-28 Thread David Miller
From: Or Gerlitz ogerl...@mellanox.com Date: Tue, 28 Jul 2015 10:51:08 +0300 On 7/28/2015 1:00 AM, David Miller wrote: Series applied, thanks. Hi Dave, I don't see this on your kernel.org clone.. maybe forgot to press on the push button? It should be there now. -- To unsubscribe from

Re: [PATCH] Drivers: isdn: Drop unnecessary continue

2015-07-28 Thread Julia Lawall
The patch should have v2 in the subject line, and should have a description of the change since the previous version under the --- On Tue, 28 Jul 2015, Shraddha Barke wrote: The semantic patch used to make this change is : @@ @@ for (...;...;...) { ... if (...) { ... -

[PATCH net-next 0/4] dwc_eth_qos: Add support for Synopsys DWC Ethernet QoS

2015-07-28 Thread Lars Persson
This is a driver supporting version 4.10a of the Synopsys DWC Ethernet QoS gigabit ethernet controller. The IP has changed significantly compared to the dwmac1000 so a separate driver is justified. The IP is highly configurable at synthesis time. This driver has been developed for a subset of the

[PATCH net-next 0/2] net: Initialize sk_hash to random value and reset for failing cnxs

2015-07-28 Thread Tom Herbert
This patch set implements a common function to simply set sk_txhash to a random number instead of going through the trouble to call flow dissector. From dst_negative_advice we now reset the sk_txhash in hopes of finding a better ECMP path through the network. Changing sk_txhash affects: - IPv6

[PATCH net-next 1/2] net: Set sk_txhash from a random number

2015-07-28 Thread Tom Herbert
This patch creates sk_set_txhash and eliminates protocol specific inet_set_txhash and ip6_set_txhash. sk_set_txhash simply sets a random number instead of performing flow dissection. sk_set_txash is also allowed to be called multiple times for the same socket, we'll need this when redoing the hash

RE: [PATCH 1/5] Add functions producing system time given a backing counter value

2015-07-28 Thread Hall, Christopher S
-Original Message- From: John Stultz [mailto:john.stu...@linaro.org] Sent: Monday, July 27, 2015 8:44 PM To: Hall, Christopher S Cc: Thomas Gleixner; Richard Cochran; Ingo Molnar; Kirsher, Jeffrey T; Ronciak, John; H. Peter Anvin; x...@kernel.org; lkml; netdev@vger.kernel.org

Re: [PATCH iproute2 net-next] bridge: mdb: add support for vlans

2015-07-28 Thread Stephen Hemminger
On Tue, 28 Jul 2015 13:17:35 +0200 Nikolay Aleksandrov niko...@cumulusnetworks.com wrote: On 07/15/2015 05:45 PM, Nikolay Aleksandrov wrote: This patch allows the user to specify the vlan of the mdb group being added or deleted and adds support for displaying the vlan when dumping mdb

RE: [PATCH 3/5] Add calls to translate Always Running Timer (ART) to system time

2015-07-28 Thread Hall, Christopher S
-Original Message- From: John Stultz [mailto:john.stu...@linaro.org] Sent: Monday, July 27, 2015 9:11 PM To: Hall, Christopher S Cc: Thomas Gleixner; Richard Cochran; Ingo Molnar; Kirsher, Jeffrey T; Ronciak, John; H. Peter Anvin; x...@kernel.org; lkml; netdev@vger.kernel.org

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread Hannes Frederic Sowa
Hi roopa, On Tue, Jul 28, 2015, at 21:28, roopa wrote: On 7/28/15, 6:04 AM, Hannes Frederic Sowa wrote: Can't you simply use ipv6_stub_impl.ipv6_dst_lookup with sk=NULL to do that and don't have a run-time dependency on IPv6 at all (for the cost of a function pointer).

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread roopa
On 7/28/15, 3:22 PM, Hannes Frederic Sowa wrote: Hi roopa, On Tue, Jul 28, 2015, at 21:28, roopa wrote: ipv6_stub_impl.ipv6_dst_lookup seems to require sk today. But it only needs it to get 'net' in the beginning and sk is optional afterwards. I will submit a patch to add 'net' as an arg

Re: [PATCH net] bridge: mdb: fix delmdb state in the notification

2015-07-28 Thread Cong Wang
On Tue, Jul 28, 2015 at 4:10 AM, Nikolay Aleksandrov ra...@blackwall.org wrote: From: Nikolay Aleksandrov niko...@cumulusnetworks.com Since mdb states were introduced when deleting an entry the state was left as it was set in the delete request from the user which leads to the following

RE: [PATCH 3/5] Add calls to translate Always Running Timer (ART) to system time

2015-07-28 Thread Hall, Christopher S
-Original Message- From: Andy Lutomirski [mailto:l...@kernel.org] Sent: Monday, July 27, 2015 6:32 PM To: Hall, Christopher S; john.stu...@linaro.org; t...@linutronix.de; richardcoch...@gmail.com; mi...@redhat.com; Kirsher, Jeffrey T; Ronciak, John; h...@zytor.com; x...@kernel.org

[PATCH 0/3] net: netcp: bug fixes for dynamic module support

2015-07-28 Thread Murali Karicheri
This series fixes few bugs to allow keystone netcp modules to be dynamically loaded and removed. Currently it allows following sequence multiple times insmod cpsw_ale.ko insmod davinci_mdio.ko insmod keystone_netcp.ko insmod keystone_netcp_ethss.ko ifup eth0 ifup eth1 ping hosts on eth0

[PATCH 2/3] net: netcp: ethss: fix up incorrect use of list api

2015-07-28 Thread Murali Karicheri
The code seems to assume a null is returned when the list is empty from first_sec_slave() to break the loop which is incorrect. Fix the code by using list_empty(). Signed-off-by: Murali Karicheri m-kariche...@ti.com --- drivers/net/ethernet/ti/netcp_ethss.c | 5 ++--- 1 file changed, 2

[PATCH 1/3] net: netcp: fix cleanup interface list in netcp_remove()

2015-07-28 Thread Murali Karicheri
Currently if user do rmmod keystone_netcp.ko following warning is seen :- [ 59.035891] [ cut here ] [ 59.040535] WARNING: CPU: 2 PID: 1619 at drivers/net/ethernet/ti/ netcp_core.c:2127 netcp_remove) This is because the interface list is not cleaned up in netcp_remove.

[PATCH net-next v5 2/2] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch uses ipv6_stub_impl.ipv6_dst_lookup instead of ip6_route_output. And wraps affected code under IS_ENABLED(CONFIG_INET) and

[PATCH net-next v5 0/2] af_mpls: fix undefined reference to ip6_route_output with CONFIG_IPV6=n

2015-07-28 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch series uses ipv6_stub_impl.ipv6_dst_lookup instead of ip6_route_output. Follows the vxlan drivers usage of ipv6_stub_impl.ipv6_dst_lookup. There is no sk in the af_mpls context from where ipv6_stub_impl.ipv6_dst_lookup is used. sk appears

[PATCH net-next v5 1/2] ipv6: change ipv6_stub_impl.ipv6_dst_lookup to take net argument

2015-07-28 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds net argument to ipv6_stub_impl.ipv6_dst_lookup for use cases where sk is not available (like mpls). sk appears to be needed to get the namespace 'net' and is optional otherwise. This patch series changes ipv6_stub_impl.ipv6_dst_lookup

Re: [PATCH net] bridge: mdb: fix delmdb state in the notification

2015-07-28 Thread Nikolay Aleksandrov
On 07/29/2015 12:38 AM, Cong Wang wrote: On Tue, Jul 28, 2015 at 4:10 AM, Nikolay Aleksandrov ra...@blackwall.org wrote: From: Nikolay Aleksandrov niko...@cumulusnetworks.com Since mdb states were introduced when deleting an entry the state was left as it was set in the delete request from

[PATCH net-next 2/2] net: Recompute sk_txhash on negative routing advice

2015-07-28 Thread Tom Herbert
When a connection is failing a transport protocol calls dst_negative_advice to try to get a better route. This patch includes changing the sk_txhash in that function. This provides a rudimentary method to try to find a different path in the network since sk_txhash affects ECMP on the local host

Re: [PATCH iproute2 v7 4/4] ip link: proto_down config and display.

2015-07-28 Thread Stephen Hemminger
On Tue, 14 Jul 2015 13:43:22 -0700 anurad...@cumulusnetworks.com wrote: From: Anuradha Karuppiah anurad...@cumulusnetworks.com This patch adds support to set and display protodown on a switch port. The switch driver can handle this error state by doing a phys down on the port. One example

Re: [PATCH 3/5] Add calls to translate Always Running Timer (ART) to system time

2015-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2015 at 6:18 PM, Hall, Christopher S christopher.s.h...@intel.com wrote: -Original Message- From: Andy Lutomirski [mailto:l...@kernel.org] Sent: Monday, July 27, 2015 6:32 PM To: Hall, Christopher S; john.stu...@linaro.org; t...@linutronix.de;

Re: [PATCHv2] net/ipv6: add sysctl option accept_ra_hop_limit

2015-07-28 Thread Hangbin Liu
2015-07-28 11:58 GMT+08:00 YOSHIFUJI Hideaki hideaki.yoshif...@miraclelinux.com: Hi, Hangbin Liu wrote: 2015-07-28 7:50 GMT+08:00 YOSHIFUJI Hideaki/吉藤英明 hideaki.yoshif...@miraclelinux.com: Hi, Hangbin Liu wrote: Commit 6fd99094de2b (ipv6: Don't reduce hop limit for an interface) disabled

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-28 Thread Francois Romieu
Mugunthan V N mugunthan...@ti.com : On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : [...] @@ -752,13 +753,22 @@ static irqreturn_t cpsw_tx_interrupt(int irq, void *dev_id) struct cpsw_priv *priv = dev_id; cpdma_ctlr_eoi(priv-dma,

Re: [PATCHv2] net/ipv6: add sysctl option accept_ra_hop_limit

2015-07-28 Thread YOSHIFUJI Hideaki
Hangbin Liu wrote: 2015-07-28 11:58 GMT+08:00 YOSHIFUJI Hideaki hideaki.yoshif...@miraclelinux.com: Hi, Hangbin Liu wrote: 2015-07-28 7:50 GMT+08:00 YOSHIFUJI Hideaki/吉藤英明 hideaki.yoshif...@miraclelinux.com: Hi, Hangbin Liu wrote: Commit 6fd99094de2b (ipv6: Don't reduce hop limit for an

[PATCH net] bridge: Fix network header pointer for vlan tagged packets

2015-07-28 Thread Toshiaki Makita
There are several devices that can receive vlan tagged packets with CHECKSUM_PARTIAL like tap, possibly veth and xennet. When (multiple) vlan tagged packets with CHECKSUM_PARTIAL are forwarded by bridge to a device with the IP_CSUM feature, they end up with checksum error because before entering

[PATCH v4 0/7] introduce Hyper-V VM Sockets(hvsock)

2015-07-28 Thread Dexuan Cui
Changes since v1: - updated [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature - added __init and __exit for the module init/exit functions - net/hv_sock/Kconfig: default m - default m if HYPERV - MODULE_LICENSE: Dual MIT/GPL - Dual BSD/GPL Changes since v2: -

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Eric W. Biederman
Hannes Frederic Sowa han...@stressinduktion.org writes: Hello Eric, On Mon, 2015-07-27 at 15:33 -0500, Eric W. Biederman wrote: David Ahern d...@cumulusnetworks.com writes: Allow tasks to have a default device index for binding sockets. If set the value is passed to all

[PATCH] net: rfkill-regulator: fix compiler warning

2015-07-28 Thread Robert ABEL
pdata char* name = const char* name Signed-off-by: Robert ABEL ra...@cit-ec.uni-bielefeld.de --- include/linux/rfkill-regulator.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/rfkill-regulator.h b/include/linux/rfkill-regulator.h index aca36bc..594d8e7 100644

[PATCH net-next 5/5] s390/bpf: recache skb-data/hlen for skb_vlan_push/pop

2015-07-28 Thread Michael Holzheu
Allow eBPF programs attached to TC qdiscs call skb_vlan_push/pop via helper functions. These functions may change skb-data/hlen. This data is cached by s390 JIT to improve performance of ld_abs/ld_ind instructions. Therefore after a change we have to reload the data. In case of usage of

[PATCH net-next 2/5] s390/bpf: Fix multiple macro expansions

2015-07-28 Thread Michael Holzheu
The EMIT6_DISP_LH macro passes the disp parameter to the _EMIT6_DISP_LH macro. The _EMIT6_DISP_LH macro uses the disp parameter twice: unsigned int __disp_h = ((u32)disp) 0xff000; unsigned int __disp_l = ((u32)disp) 0x00fff; The EMIT6_DISP_LH is used several times with EMIT_CONST_U64() as

[PATCH net-next 1/5] s390/bpf: clear correct BPF accumulator register

2015-07-28 Thread Michael Holzheu
Currently we assumed the following BPF to eBPF register mapping: - BPF_REG_A - BPF_REG_7 - BPF_REG_X - BPF_REG_8 Unfortunately this mapping is wrong. The correct mapping is: - BPF_REG_A - BPF_REG_0 - BPF_REG_X - BPF_REG_7 So clear the correct registers and use the BPF_REG_A and BPF_REG_X

Re: ARP response with link local IP, why not broadcast

2015-07-28 Thread Sebastian Fett
Just a quick update on the subject. Thanks for the input. It's good to see that I am not the only one that has this problem. Right now we go with our initial approach and bcast our arp responses. We have a very local network build only for one purpose. Other devices in that network use the same

Re: [PATCH] Drivers: isdn: Drop unnecessary continue

2015-07-28 Thread Eric Dumazet
On Tue, 2015-07-28 at 14:11 +0530, Shraddha Barke wrote: The semantic patch used to make this change is : @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Shraddha Barke shraddha.6...@gmail.com --- drivers/isdn/hardware/mISDN/hfcsusb.c | 5

[PATCH net-next 3/5] s390/bpf: increase BPF_SIZE_MAX

2015-07-28 Thread Michael Holzheu
Currently we have the restriction that jitted BPF programs can have a maximum size of one page. The reason is that we use short displacements for the literal pool. The 20 bit displacements are available since z990 and BPF requires z196 as minimum. Therefore we can remove this restriction and use

[PATCH net-next 0/5] s390/bpf: recache skb-data/hlen for skb_vlan_push/pop

2015-07-28 Thread Michael Holzheu
Hi Dave, Here the s390 backend for Alexei's patch 4e10df9a60d9 (bpf: introduce bpf_skb_vlan_push/pop() helpers) plus two bugfixes and two minor improvements. The first patch s390/bpf: clear correct BPF accumulator register will also go upstream via Martin's fixes branch. Ok for you? Regards,

[PATCH net-next 4/5] s390/bpf: Only clear A and X for converted BPF programs

2015-07-28 Thread Michael Holzheu
Only classic BPF programs that have been converted to eBPF need to clear the A and X registers. We can check for converted programs with: bpf_prog-type == BPF_PROG_TYPE_UNSPEC So add the check and skip initialization for real eBPF programs. Signed-off-by: Michael Holzheu

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Hannes Frederic Sowa
On Tue, 2015-07-28 at 08:54 -0500, Eric W. Biederman wrote: Hannes Frederic Sowa han...@stressinduktion.org writes: Hello Eric, On Mon, 2015-07-27 at 15:33 -0500, Eric W. Biederman wrote: David Ahern d...@cumulusnetworks.com writes: Allow tasks to have a default device index

[PATCH net] ebpf, x86: fix general protection fault when tail call is invoked

2015-07-28 Thread Daniel Borkmann
With eBPF JIT compiler enabled on x86_64, I was able to reliably trigger the following general protection fault out of an eBPF program with a simple tail call, f.e. tracex5 (or a stripped down version of it): [ 927.097918] general protection fault: [#1] SMP DEBUG_PAGEALLOC [...] [

[PATCH net] sctp: fix sockopt size check

2015-07-28 Thread Marcelo Ricardo Leitner
The problem is not on being bigger than what we want, but on being smaller, as it causes read of invalid memory. Note that the struct changes on commit 7e8616d8e773 didn't affect sctp_setsockopt_events one but that's where this check was flipped. Fixes: 7e8616d8e773 ([SCTP]: Update AUTH

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread Robert Shearman
On 28/07/15 07:40, Roopa Prabhu wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP to lookup nexthop device if user has not

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread roopa
On 7/28/15, 7:17 AM, Robert Shearman wrote: On 28/07/15 07:40, Roopa Prabhu wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP to

Re: [net-next 0/16] Proposal for VRF-lite - v3

2015-07-28 Thread David Ahern
On 7/27/15 2:30 PM, Eric W. Biederman wrote: This paragraph is false when it comes to sockets, as I have already pointed out. - VPN Routing and Forwarding (RFC4364 and it's kin) implies isolation strong enough to allow using the the same ip on different machines in different VPN instances

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread David Ahern
On 7/28/15 10:01 AM, Eric Dumazet wrote: On Tue, 2015-07-28 at 14:19 +0200, Hannes Frederic Sowa wrote: Hello Eric, On Mon, 2015-07-27 at 15:33 -0500, Eric W. Biederman wrote: David Ahern d...@cumulusnetworks.com writes: Allow tasks to have a default device index for binding sockets. If set

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Andy Lutomirski
On Jul 27, 2015 11:33 AM, David Ahern d...@cumulusnetworks.com wrote: Allow tasks to have a default device index for binding sockets. If set the value is passed to all AF_INET/AF_INET6 sockets when they are created. This is not intended to be a review of the concept. I haven't thought about

Re: [PATCH 1/3] net: mdio-octeon: Modify driver to work on both ThunderX and Octeon

2015-07-28 Thread David Daney
On 07/27/2015 07:14 PM, mohun...@gmail.com wrote: From: Radha Mohan Chintakuntla rchintakun...@cavium.com This patch modifies the mdio-octeon driver to work on both ThunderX and Octeon SoCs from Cavium Inc. Signed-off-by: Sunil Goutham sgout...@cavium.com Signed-off-by: Radha Mohan

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Eric Dumazet
On Tue, 2015-07-28 at 14:19 +0200, Hannes Frederic Sowa wrote: Hello Eric, On Mon, 2015-07-27 at 15:33 -0500, Eric W. Biederman wrote: David Ahern d...@cumulusnetworks.com writes: Allow tasks to have a default device index for binding sockets. If set the value is passed to all

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread David Ahern
On 7/28/15 9:25 AM, Andy Lutomirski wrote: On Jul 27, 2015 11:33 AM, David Ahern d...@cumulusnetworks.com wrote: Allow tasks to have a default device index for binding sockets. If set the value is passed to all AF_INET/AF_INET6 sockets when they are created. This is not intended to be a

[PATCH 0/8] Use correctly the Xen memory terminologies in Linux

2015-07-28 Thread Julien Grall
Hi all, This patch series aims to use the memory terminologies described in include/linux/mm.h [1] for Linux xen code. Linux is using mistakenly MFN when GFN is meant, I suspect this is because the first support of Xen was for PV. This has brought some misimplementation of memory helpers on ARM

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread roopa
On 7/28/15, 6:04 AM, Hannes Frederic Sowa wrote: On Mon, 2015-07-27 at 23:40 -0700, Roopa Prabhu wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch adds new

RE: [PATCH net 1/2] r8152: add pre_reset and post_reset

2015-07-28 Thread Hayes Wang
Oliver Neukum [mailto:oneu...@suse.com] Sent: Tuesday, July 28, 2015 4:53 PM [...] + return 0; + + netdev = tp-netdev; + if (!netif_running(netdev)) + return 0; + + ret = usb_autopm_get_interface(intf); + if (ret 0) + return ret; What

[PATCH V4 2/7] Drivers: hv: vmbus: define a new VMBus message type for hvsock

2015-07-28 Thread Dexuan Cui
A function to send the type of message is also added. The coming net/hvsock driver will use this function to proactively request the host to offer a VMBus channel for a new hvsock connection. Signed-off-by: Dexuan Cui de...@microsoft.com --- drivers/hv/channel.c | 15 +++

[PATCH V4 3/7] Drivers: hv: vmbus: add APIs to send/recv hvsock packet and get the r/w-ability

2015-07-28 Thread Dexuan Cui
This will be used by the coming net/hvsock driver. Signed-off-by: Dexuan Cui de...@microsoft.com --- drivers/hv/channel.c | 134 ++ drivers/hv/hyperv_vmbus.h | 4 ++ drivers/hv/ring_buffer.c | 14 + include/linux/hyperv.h| 32

[PATCH V4 6/7] hvsock: introduce Hyper-V VM Sockets feature

2015-07-28 Thread Dexuan Cui
Hyper-V VM sockets (hvsock) supplies a byte-stream based communication mechanism between the host and a guest. It's kind of TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V VM Sockets, applications between the host and a guest can talk with each other

[PATCH V4 7/7] Drivers: hv: vmbus: disable local interrupt when hvsock's callback is running

2015-07-28 Thread Dexuan Cui
In the SMP guest case, when the per-channel callback hvsock_events() is running on virtual CPU A, if the guest tries to close the connection on virtual CPU B: we invoke vmbus_close() - vmbus_close_internal(), then we can have trouble: on B, vmbus_close_internal() will send IPI reset_channel_cb()

[PATCH V4 4/7] Drivers: hv: vmbus: add APIs to register callbacks to process hvsock connection

2015-07-28 Thread Dexuan Cui
With the 2 APIs supplied by the VMBus driver, the coming net/hvsock driver can register 2 callbacks and can know when a new hvsock connection is offered by the host, and when a hvsock connection is being closed by the host. Signed-off-by: Dexuan Cui de...@microsoft.com --- drivers/hv/Makefile

Re: [PATCH net 1/2] r8152: add pre_reset and post_reset

2015-07-28 Thread Oliver Neukum
On Tue, 2015-07-28 at 09:52 +, Hayes Wang wrote: Oliver Neukum [mailto:oneu...@suse.com] Sent: Tuesday, July 28, 2015 4:53 PM [...] + return 0; + + netdev = tp-netdev; + if (!netif_running(netdev)) + return 0; + + ret = usb_autopm_get_interface(intf);

[PATCH net-next] net/mlx4_en: Hardware accelerated 802.1ad works only on the first port

2015-07-28 Thread Amir Vadai
Fix mistakenly used, hard coded, port number in get_phv_bit() Fixes: 77fc29c (net/mlx4_core: Preparations for 802.1ad VLAN support) Signed-off-by: Amir Vadai am...@mellanox.com --- Hi Dave, Because of my mistake I've sent a version [1] without some internal review fixes. This patch fix the only

[PATCH V4 1/7] Drivers: hv: vmbus: define the new offer type for Hyper-V socket (hvsock)

2015-07-28 Thread Dexuan Cui
A helper function is also added. Signed-off-by: Dexuan Cui de...@microsoft.com --- include/linux/hyperv.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index 30d3a1f..2ca3ac1 100644 --- a/include/linux/hyperv.h +++

Re: [PATCH iproute2 net-next] bridge: mdb: add support for router add/del notifications monitoring

2015-07-28 Thread Nikolay Aleksandrov
On 07/27/2015 11:49 PM, Nikolay Aleksandrov wrote: On 27 Jul 2015, at 23:40, Stephen Hemminger step...@networkplumber.org wrote: On Mon, 27 Jul 2015 13:44:05 +0200 Nikolay Aleksandrov ra...@blackwall.org wrote: From: Nikolay Aleksandrov niko...@cumulusnetworks.com This patch adds

Re: [PATCH] packet: tpacket_snd(): fix signed/unsigned comparison

2015-07-28 Thread Eric Dumazet
On Tue, 2015-07-28 at 13:07 +0200, Daniel Borkmann wrote: On 07/28/2015 12:57 PM, Alexander Drozdov wrote: tpacket_fill_skb() can return a negative value (-errno) which is stored in tp_len variable. In that case the following condition will be (but shouldn't be) true: tp_len dev-mtu +

[PATCH net] bridge: mdb: fix delmdb state in the notification

2015-07-28 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov niko...@cumulusnetworks.com Since mdb states were introduced when deleting an entry the state was left as it was set in the delete request from the user which leads to the following output when doing a monitor (for example): $ bridge mdb add dev br0 port eth3 grp

Re: [PATCH net v2 2/2] r8152: reset device when tx timeout

2015-07-28 Thread Oliver Neukum
On Tue, 2015-07-28 at 20:08 +0800, Hayes Wang wrote: static void rtl8152_tx_timeout(struct net_device *netdev) { struct r8152 *tp = netdev_priv(netdev); - int i; netif_warn(tp, tx_err, netdev, Tx timeout\n); - for (i = 0; i RTL8152_MAX_TX; i++) -

RE: [PATCH net v2 2/2] r8152: reset device when tx timeout

2015-07-28 Thread Hayes Wang
Oliver Neukum [mailto:oneu...@suse.com] Sent: Tuesday, July 28, 2015 8:14 PM [...] static void rtl8152_tx_timeout(struct net_device *netdev) { struct r8152 *tp = netdev_priv(netdev); - int i; netif_warn(tp, tx_err, netdev, Tx timeout\n); - for (i = 0; i

[PATCH net] bridge: mcast: give fast leave precedence over multicast router and querier

2015-07-28 Thread Nikolay Aleksandrov
From: Satish Ashok sas...@cumulusnetworks.com When fast leave is configured on a bridge port and an IGMP leave is received for a group, the group is not deleted immediately if there is a router detected or if multicast querier is configured. Ideally the group should be deleted immediately when

[PATCH] packet: tpacket_snd(): fix signed/unsigned comparison

2015-07-28 Thread Alexander Drozdov
tpacket_fill_skb() can return a negative value (-errno) which is stored in tp_len variable. In that case the following condition will be (but shouldn't be) true: tp_len dev-mtu + dev-hard_header_len as dev-mtu and dev-hard_header_len are both unsigned. That may lead to just returning an

Re: [PATCH] packet: tpacket_snd(): fix signed/unsigned comparison

2015-07-28 Thread Daniel Borkmann
On 07/28/2015 12:57 PM, Alexander Drozdov wrote: tpacket_fill_skb() can return a negative value (-errno) which is stored in tp_len variable. In that case the following condition will be (but shouldn't be) true: tp_len dev-mtu + dev-hard_header_len as dev-mtu and dev-hard_header_len are both

[PATCH net v2 1/2] r8152: add pre_reset and post_reset

2015-07-28 Thread Hayes Wang
Add rtl8152_pre_reset() and rtl8152_post_reset() which are used when calling usb_reset_device(). The two functions could reduce the time of reset when calling usb_reset_device() after probe(). Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 54

[PATCH net v2 2/2] r8152: reset device when tx timeout

2015-07-28 Thread Hayes Wang
The device reset is necessary if the hw becomes abnormal and stops transmitting packets. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index

[PATCH net v2 0/2] r8152: device reset

2015-07-28 Thread Hayes Wang
v2: For patch #1, remove usb_autopm_get_interface(), usb_autopm_put_interface(), and the checking of intf-condition. For patch #2, replace the original method with usb_queue_reset_device() to reset the device. v1: Although the driver works normally, we find the device may get all 0xff data

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Hannes Frederic Sowa
Hello Eric, On Mon, 2015-07-27 at 15:33 -0500, Eric W. Biederman wrote: David Ahern d...@cumulusnetworks.com writes: Allow tasks to have a default device index for binding sockets. If set the value is passed to all AF_INET/AF_INET6 sockets when they are created. The task setting

[PATCH net-next] packet: remove handling of tx_ring from prb_shutdown_retire_blk_timer()

2015-07-28 Thread Tobias Klauser
Follow e8e85cc5eb57 (packet: remove handling of tx_ring) and remove the tx_ring parameter from prb_shutdown_retire_blk_timer() as it is only called with tx_ring = 0. Signed-off-by: Tobias Klauser tklau...@distanz.ch --- net/packet/af_packet.c | 6 ++ 1 file changed, 2 insertions(+), 4

Re: [PATCH iproute2 net-next] bridge: mdb: add support for vlans

2015-07-28 Thread Nikolay Aleksandrov
On 07/15/2015 05:45 PM, Nikolay Aleksandrov wrote: This patch allows the user to specify the vlan of the mdb group being added or deleted and adds support for displaying the vlan when dumping mdb information or monitoring it. It also updates the man page to reflect the new vid argument for

Re: [PATCH net v2 2/2] r8152: reset device when tx timeout

2015-07-28 Thread Oliver Neukum
On Tue, 2015-07-28 at 12:31 +, Hayes Wang wrote: Oliver Neukum [mailto:oneu...@suse.com] Sent: Tuesday, July 28, 2015 8:14 PM [...] static void rtl8152_tx_timeout(struct net_device *netdev) { struct r8152 *tp = netdev_priv(netdev); - int i;

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread Hannes Frederic Sowa
On Mon, 2015-07-27 at 23:40 -0700, Roopa Prabhu wrote: From: Roopa Prabhu ro...@cumulusnetworks.com Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP to lookup nexthop device if

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-28 Thread Mugunthan V N
On Wednesday 29 July 2015 04:00 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : [...] @@ -752,13 +753,22 @@ static irqreturn_t cpsw_tx_interrupt(int irq, void *dev_id) struct

Re: [PATCH net-next 5/5] s390/bpf: recache skb-data/hlen for skb_vlan_push/pop

2015-07-28 Thread Alexei Starovoitov
On 7/28/15 7:10 AM, Michael Holzheu wrote: Allow eBPF programs attached to TC qdiscs call skb_vlan_push/pop via helper functions. These functions may change skb-data/hlen. This data is cached by s390 JIT to improve performance of ld_abs/ld_ind instructions. Therefore after a change we have to

Re: [PATCH net] ebpf, x86: fix general protection fault when tail call is invoked

2015-07-28 Thread Alexei Starovoitov
On 7/28/15 6:26 AM, Daniel Borkmann wrote: After patch, disassembly: [...] 9e: lea0x80(%rsi,%rdx,8),%rax --- CONFIG_LOCKDEP/CONFIG_LOCK_STAT 48 8d 84 d6 80 00 00 00 a6: mov(%rax),%rax 48 8b 00 [...] [...] 9e: lea0x50(%rsi,%rdx,8),%rax

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-28 Thread David Vrabel
On 28/07/15 16:02, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This brough some misimplementation of helpers on ARM and make the developper confused the expected behavior.

Please can I trust you?

2015-07-28 Thread Brice Adams
My Dear Friend, I am Mr. Brice Adams, staff and auditor of a Bank in Lome, Togo Republic. I am the Account Officer to (Late Mr. Daniel I. Glade) whose account is presently dormant, I advise you to keep this as a top secret as I am still in service and intend to retire from service after I

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Tom Herbert
On Tue, Jul 28, 2015 at 9:11 AM, David Ahern d...@cumulusnetworks.com wrote: On 7/28/15 9:25 AM, Andy Lutomirski wrote: On Jul 27, 2015 11:33 AM, David Ahern d...@cumulusnetworks.com wrote: Allow tasks to have a default device index for binding sockets. If set the value is passed to all

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Eric Dumazet
On Tue, 2015-07-28 at 10:07 -0600, David Ahern wrote: Problems with using network namespaces for VRFs has been discussed in the past. e.g., http://www.spinics.net/lists/netdev/msg298368.html Great. Are you suggesting to get rid of network namespaces ? If not, your proposal only

Re: [PATCH net-next 13/16] net: Introduce VRF device driver - v2

2015-07-28 Thread David Ahern
On 7/27/15 2:01 PM, Nikolay Aleksandrov wrote: + + if (!vrf_is_master(dev) || vrf_is_master(port_dev) || Hmm, this means that bonds won't be able to be VRF slaves. They have the IFF_MASTER flag set. Right, will change to the IFF_VRF_MASTER flag. + vrf_is_slave(port_dev))

  1   2   >