Re: [PATCH net V2] virtio-net: drop NETIF_F_FRAGLIST

2015-08-05 Thread Michael S. Tsirkin
On Wed, Aug 05, 2015 at 10:34:04AM +0800, Jason Wang wrote: virtio declares support for NETIF_F_FRAGLIST, but assumes that there are at most MAX_SKB_FRAGS + 2 fragments which isn't always true with a fraglist. A longer fraglist in the skb will make the call to skb_to_sgvec overflow the sg

[PATCH 3/3] be2net: protect eqo-affinity_mask from getting freed twice

2015-08-05 Thread Sathya Perla
From: Kalesh AP kalesh.pura...@avagotech.com There are paths in the driver such as an unrecoverable error (UE) detection followed by a driver unload wherein be_clear() is invoked twice. Individual data structures are reset so that they are not cleaned/freed twice. This patch does the same for

[PATCH 1/3] be2net: enable IFACE filters only after creating RXQs

2015-08-05 Thread Sathya Perla
From: Kalesh AP kalesh.pura...@avagotech.com HW issues were observed on Lancer adapters if IFACE filters (flags, mac addrs etc) are enabled *before* creating RXQs. This patch changes the driver design by enabling filters in be_open() -- instead of be_setup() -- after RXQs are created and buffers

[PATCH 0/3] be2net: patch set

2015-08-05 Thread Sathya Perla
Hi David, This patch set contains 2 driver fixes to a Lancer HW issue and a fix to a double free bug. Pls apply to the net tree. Thanks! Patch 1 now enables filters only after creating RXQs. This is done as HW issues were observed on Lancer adapters if filters (flags, mac addrs etc) are enabled

[PATCH 2/3] be2net: post buffers before destroying RXQs in Lancer

2015-08-05 Thread Sathya Perla
From: Kalesh AP kalesh.pura...@avagotech.com An RX stall issue was seen on Lancer adapters, when RXQs are destroyed while they are in an out of buffer state. This patch fixes this issue by posting 64 buffers to each RXQ before destroying them in the close path. This is done after ensuring that no

[PATCH net-next v3] openvswitch: Make 100 percents packets sampled when sampling rate is 1.

2015-08-05 Thread Wenyu Zhang
When sampling rate is 1, the sampling probability is UINT32_MAX. The packet should be sampled even the prandom32() generate the number of UINT32_MAX. And none packet need be sampled when the probability is 0. Signed-off-by: Wenyu Zhang wen...@vmware.com --- net/openvswitch/actions.c |5 -

[PATCH] cc2520: set the default fifo pin value from platform data

2015-08-05 Thread LIYONG
Without the device tree support, the fifo_pin is uninitialized, this Patch will set the fifo_pin value based on platform data Signed-off-by: Yong Li sdliy...@gmail.com ---  drivers/net/ieee802154/cc2520.c | 1 +  1 file changed, 1 insertion(+) diff --git a/drivers/net/ieee802154/cc2520.c

Re: rtnl_mutex deadlock?

2015-08-05 Thread Jiri Pirko
Wed, Aug 05, 2015 at 07:31:30AM CEST, cw...@twopensource.com wrote: On Tue, Aug 4, 2015 at 8:48 AM, Linus Torvalds torva...@linux-foundation.org wrote: Sorry for the spamming of random rtnetlink people, but I just resumed my laptop at PDX, and networking was dead. It looks like a deadlock on

Re: rtnl_mutex deadlock?

2015-08-05 Thread Linus Torvalds
On Wed, Aug 5, 2015 at 9:43 AM, Jiri Pirko j...@resnulli.us wrote: Indeed. Most probably, NETLINK_CB(skb).portid got zeroed. Linus, are you able to reproduce this or is it a one-time issue? I don't think I'm able to reproduce this, it's happened only once so far. Linus -- To

[PATCH net-master v2] net: fec: fix initial runtime PM refcount

2015-08-05 Thread Uwe Kleine-König
From: Lucas Stach l.st...@pengutronix.de The clocks are initially active and thus the device is marked active. This still keeps the PM refcount at 0, the pm_runtime_put_autosuspend() call at the end of probe then leaves us with an invalid refcount of -1, which in turn leads to the device staying

Re: [PATCHv2 net-next 4/9] netfilter: connlabels: Export setting connlabel length

2015-08-05 Thread Florian Westphal
Joe Stringer joestrin...@nicira.com wrote: Add functions to change connlabel length into nf_conntrack_labels.c so they may be reused by other modules like OVS and nftables without needing to jump through xt_match_check() hoops. Looks good, thanks Joe. Acked-by: Florian Westphal f...@strlen.de

Re: [BUG] net/ipv4: inconsistent routing table

2015-08-05 Thread Daniel Borkmann
[ please cc netdev ] On 08/05/2015 10:56 AM, Zang MingJie wrote: Hi: I found a bug when remove an ip address which is referenced by a routing entry. step to reproduce: ip li add type dummy ip li set dummy0 up ip ad add 10.0.0.1/24 dev dummy0 ip ad add 10.0.0.2/24 dev dummy0 ip ro add default

Re: [PATCH 00/18] Netfilter updates for net-next

2015-08-05 Thread David Miller
From: Pablo Neira Ayuso pa...@netfilter.org Date: Tue, 4 Aug 2015 12:02:30 +0200 The following patchset contains Netfilter updates for net-next, they are: Applied, thanks Pablo. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH v6 2/4] bpf: Add new bpf map type to store the pointer to struct perf_event

2015-08-05 Thread Peter Zijlstra
On Tue, Aug 04, 2015 at 08:58:14AM +, Kaixu Xia wrote: diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 2027809..81fc99e 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -641,6 +641,8 @@ extern int perf_event_init_task(struct

Re: [PATCH v6 2/4] bpf: Add new bpf map type to store the pointer to struct perf_event

2015-08-05 Thread Peter Zijlstra
On Tue, Aug 04, 2015 at 10:43:35AM -0700, Alexei Starovoitov wrote: +static void *perf_event_fd_array_get_ptr(struct bpf_map *map, int fd) +{ +struct perf_event *event; +struct perf_event_attr *attr; + +event = perf_event_get(fd); +if (IS_ERR(event)) +return

Re: [PATCH v6 2/4] bpf: Add new bpf map type to store the pointer to struct perf_event

2015-08-05 Thread Peter Zijlstra
On Tue, Aug 04, 2015 at 08:58:14AM +, Kaixu Xia wrote: +static void *perf_event_fd_array_get_ptr(struct bpf_map *map, int fd) +{ + struct perf_event *event; + struct perf_event_attr *attr; + + event = perf_event_get(fd); + if (IS_ERR(event)) + return event;

Re: [PATCH v6 3/4] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter

2015-08-05 Thread Peter Zijlstra
On Tue, Aug 04, 2015 at 08:58:15AM +, Kaixu Xia wrote: diff --git a/kernel/events/core.c b/kernel/events/core.c index 6251b53..726ca1b 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -8599,6 +8599,25 @@ struct perf_event_attr *perf_event_attrs(struct perf_event *event)

Re: [PATCH v6 0/4] bpf: Introduce the new ability of eBPF programs to access hardware PMU counter

2015-08-05 Thread Peter Zijlstra
Please split out the core perf API stuff into separate patches. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Stefano Stabellini
On Tue, 4 Aug 2015, Boris Ostrovsky wrote: On 08/04/2015 02:12 PM, Julien Grall wrote: /* * We detect special mappings in one of two ways: @@ -217,9 +232,13 @@ static inline unsigned long bfn_to_local_pfn(unsigned long mfn) /* VIRT - MACHINE conversion */ #define

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Stefano Stabellini
On Tue, 4 Aug 2015, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This resulted in some misimplementation of helpers on ARM and confused developers about the expected behavior.

Re: [PATCH v6 3/4] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter

2015-08-05 Thread Peter Zijlstra
On Wed, Aug 05, 2015 at 12:04:25PM +0200, Peter Zijlstra wrote: On Tue, Aug 04, 2015 at 08:58:15AM +, Kaixu Xia wrote: + event-ctx-task != current) Strictly speaking we should hold rcu_read_lock around dereferencing event-ctx (or have IRQs disabled -- although I know Paul doesn't

[PATCH v2] e1000e: Modify tx/rx configurations to avoid null pointer dereferences in e1000_open

2015-08-05 Thread Jia-Ju Bai
When e1000e_setup_rx_resources is failed in e1000_open, e1000e_free_tx_resources in err_setup_rx segment is executed. writel(0, tx_ring-head) statement in e1000_clean_tx_ring in e1000e_free_tx_resources will cause a null poonter dereference(crash), because tx_ring-head is only assigned in

Re: [PATCH v6 3/4] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter

2015-08-05 Thread xiakaixu
于 2015/8/5 18:04, Peter Zijlstra 写道: On Tue, Aug 04, 2015 at 08:58:15AM +, Kaixu Xia wrote: diff --git a/kernel/events/core.c b/kernel/events/core.c index 6251b53..726ca1b 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -8599,6 +8599,25 @@ struct perf_event_attr

Re: [PATCH v2] e1000e: Modify tx/rx configurations to avoid null pointer dereferences in e1000_open

2015-08-05 Thread Jeff Kirsher
On Wed, 2015-08-05 at 18:16 +0800, Jia-Ju Bai wrote: When e1000e_setup_rx_resources is failed in e1000_open, e1000e_free_tx_resources in err_setup_rx segment is executed. writel(0, tx_ring-head) statement in e1000_clean_tx_ring in e1000e_free_tx_resources will cause a null poonter

[PATCH] r8169:Fill with zero Tx descriptors

2015-08-05 Thread Corcodel Marian
This patch fill with zero Tx descriptors before use.Is only onpart by more patches but is critical.(critical) Signed-off-by: Corcodel Marian corcodel.mar...@gmail.com diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 3df51fa..bf78f94 100644

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Julien Grall
Hi Boris, On 05/08/15 00:16, Boris Ostrovsky wrote: On 08/04/2015 02:12 PM, Julien Grall wrote: /* * We detect special mappings in one of two ways: @@ -217,9 +232,13 @@ static inline unsigned long bfn_to_local_pfn(unsigned long mfn) /* VIRT - MACHINE conversion */ #define

Re: net: Fix skb_set_peeked use-after-free bug

2015-08-05 Thread Konstantin Khlebnikov
On 04.08.2015 10:42, Herbert Xu wrote: Brenden Blanco bbla...@plumgrid.com wrote: [ 318.244596] BUG: unable to handle kernel NULL pointer dereference at 008e [ 318.245182] IP: [81455e7c] __skb_recv_datagram+0xbc/0x5a0 Replying to myself, and adding commit interested

[PATCH v2 1/2] ethtool: changes of emac_regs structure accordingly within driver emac_regs structure.

2015-08-05 Thread Ivan Mikhaylov
* do the redefinition of emac_regs struct from driver structure perspective and passing size from actual struct size, not from memory area variable which set in dts file. * passing variable from dts option may cause a problem with output below MII's section which we're fixing with this and

[PATCH v2 2/2] ethtool: add versioning for emac chips

2015-08-05 Thread Ivan Mikhaylov
* add three types of network chips : emac, emac4, emac4sync * add emac4sync processing in print_emac_regs Signed-off-by: Ivan Mikhaylov i...@ru.ibm.com --- ibm_emac.c | 56 +--- 1 file changed, 45 insertions(+), 11 deletions(-) diff --git

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Boris Ostrovsky
On 08/05/2015 06:51 AM, Julien Grall wrote: diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index 09dc447..25e3cce 100644 --- a/drivers/video/fbdev/xen-fbfront.c +++ b/drivers/video/fbdev/xen-fbfront.c @@ -539,7 +539,7 @@ static int xenfb_remove(struct

Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Julien Grall
On 05/08/15 13:19, Boris Ostrovsky wrote: On 08/05/2015 06:51 AM, Julien Grall wrote: diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index 09dc447..25e3cce 100644 --- a/drivers/video/fbdev/xen-fbfront.c +++ b/drivers/video/fbdev/xen-fbfront.c @@ -539,7

Re: [PATCH v2] e1000e: Modify tx/rx configurations to avoid null pointer dereferences in e1000_open

2015-08-05 Thread Jia-Ju Bai
On 08/05/2015 06:43 PM, Jeff Kirsher wrote: Is your intention that this patch replace the existing patch: http://patchwork.ozlabs.org/patch/502990/ ...which is currently in my queue? Okay, please replace the previous patch. -- To unsubscribe from this list: send the line unsubscribe netdev

Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Boris Ostrovsky
On 08/05/2015 08:33 AM, Julien Grall wrote: On 05/08/15 13:19, Boris Ostrovsky wrote: On 08/05/2015 06:51 AM, Julien Grall wrote: diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c index 09dc447..25e3cce 100644 --- a/drivers/video/fbdev/xen-fbfront.c +++

[PATCH 4/4] batman-adv: initialize up/down values when adding a gateway

2015-08-05 Thread Antonio Quartulli
From: Simon Wunderlich si...@open-mesh.com Without this initialization, gateways which actually announce up/down bandwidth of 0/0 could be added. If these nodes get purged via _batadv_purge_orig() later, the gw_node structure does not get removed since batadv_gw_node_delete() updates the gw_node

[PATCH 3/4] batman-adv: protect tt_local_entry from concurrent delete events

2015-08-05 Thread Antonio Quartulli
From: Marek Lindner mareklind...@neomailbox.ch The tt_local_entry deletion performed in batadv_tt_local_remove() was neither protecting against simultaneous deletes nor checking whether the element was still part of the list before calling hlist_del_rcu(). Replacing the hlist_del_rcu() call with

[PATCH 2/4] batman-adv: fix kernel crash due to missing NULL checks

2015-08-05 Thread Antonio Quartulli
From: Marek Lindner mareklind...@neomailbox.ch batadv_softif_vlan_get() may return NULL which has to be verified by the caller. Fixes: 35df3b298fc8 (batman-adv: fix TT VLAN inconsistency on VLAN re-add) Reported-by: Ryan Thompson r...@eero.com Signed-off-by: Marek Lindner

pull request [net]: batman-adv fixes 20150805

2015-08-05 Thread Antonio Quartulli
Hello David, here you have our patchset for net/linux-4.2 which contains only patches that we think to be important (meaning they fix critical crashes/misbehaviours actually reported by some users). Patch 1 (by me) is preventing DAT from injecting replies received from the mesh into the LAN

[PATCH 1/4] batman-adv: avoid DAT to mess up LAN state

2015-08-05 Thread Antonio Quartulli
When a node running DAT receives an ARP request from the LAN for the first time, it is likely that this node will request the ARP entry through the distributed ARP table (DAT) in the mesh. Once a DAT reply is received the asking node must check if the MAC address for which the IP address has been

Re: [PATCH] r8169:Fill with zero Tx descriptors

2015-08-05 Thread Sergei Shtylyov
Hello. On 8/5/2015 1:46 PM, Corcodel Marian wrote: This patch fill with zero Tx descriptors before use.Is only onpart by more patches but is critical.(critical) Signed-off-by: Corcodel Marian corcodel.mar...@gmail.com diff --git a/drivers/net/ethernet/realtek/r8169.c

RE: [PATCH 2/4] batman-adv: fix kernel crash due to missing NULL checks

2015-08-05 Thread David Laight
From: Of Antonio Quartulli Sent: 05 August 2015 13:52 From: Marek Lindner mareklind...@neomailbox.ch batadv_softif_vlan_get() may return NULL which has to be verified by the caller. ... diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index c002961..a2fc843

[v4, 0/9] Freescale DPAA FMan

2015-08-05 Thread igal.liberman
From: Igal Liberman igal.liber...@freescale.com The Freescale Data Path Acceleration Architecture (DPAA) is a set of hardware components on specific QorIQ multicore processors. This architecture provides the infrastructure to support simplified sharing of networking interfaces and accelerators by

[v4, 1/9] fsl/fman: Add the FMan FLIB

2015-08-05 Thread igal.liberman
From: Igal Liberman igal.liber...@freescale.com The FMan FLib provides the basic API used by the FMan drivers to configure and control the FMan hardware. Signed-off-by: Igal Liberman igal.liber...@freescale.com --- drivers/net/ethernet/freescale/Kconfig |1 +

[v4, 3/9] fsl/fman: Add the FMan MAC FLIB

2015-08-05 Thread igal.liberman
From: Igal Liberman igal.liber...@freescale.com The FMan MAC FLib provides basic API used by the drivers to configure and control the FMan MAC hardware. Signed-off-by: Igal Liberman igal.liber...@freescale.com --- drivers/net/ethernet/freescale/fman/Makefile |1 +

[PATCH 5/5] net: rfkill: gpio: remove rfkill_gpio_platform_data

2015-08-05 Thread Heikki Krogerus
No more users for it. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com --- include/linux/rfkill-gpio.h | 37 - net/rfkill/Kconfig | 3 +-- net/rfkill/rfkill-gpio.c| 8 3 files changed, 1 insertion(+), 47 deletions(-)

[PATCH 2/5] net: rfkill: add rfkill_find_type function

2015-08-05 Thread Heikki Krogerus
Helper for finding the type based on name. Useful if the type needs to be determined based on device property. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com --- include/linux/rfkill.h | 15 + net/rfkill/core.c | 57

[PATCH 4/5] ARM: tegra: use build-in device properties with rfkill_gpio

2015-08-05 Thread Heikki Krogerus
Pass the rfkill name and type to the device with properties instead of driver specific platform data. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com CC: Alexandre Courbot gnu...@gmail.com CC: Thierry Reding thierry.red...@gmail.com CC: Stephen Warren swar...@wwwdotorg.org ---

Re: [PATCH] r8169:Fill with zero Tx descriptors

2015-08-05 Thread Ivan Vecera
On 5.8.2015 12:46, Corcodel Marian wrote: This patch fill with zero Tx descriptors before use.Is only onpart by more patches but is critical.(critical) Signed-off-by: Corcodel Marian corcodel.mar...@gmail.com diff --git a/drivers/net/ethernet/realtek/r8169.c

[PATCH 0/5] net: rfkill: gpio: replace platform data with build-in property

2015-08-05 Thread Heikki Krogerus
The first patch adds a few helper macros for build-in property creation and the second makes it possible to get the rfkill type index based on name. The rest deal with rfkill-gpio. Cheers, Heikki Krogerus (5): device property: helper macros for property entry creation net: rfkill: add

[PATCH 1/5] device property: helper macros for property entry creation

2015-08-05 Thread Heikki Krogerus
Marcos for easier creation of build-in property entries. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com --- include/linux/property.h | 35 +++ 1 file changed, 35 insertions(+) diff --git a/include/linux/property.h b/include/linux/property.h index

[PATCH 3/5] net: rfkill: gpio: get the name and type from device property

2015-08-05 Thread Heikki Krogerus
This prepares the driver for removal of platform data. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com --- net/rfkill/rfkill-gpio.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c index

[v4, 4/9] fsl/fman: Add FMan MURAM support

2015-08-05 Thread igal.liberman
From: Igal Liberman igal.liber...@freescale.com Add Frame Manager Multi-User RAM support. Signed-off-by: Igal Liberman igal.liber...@freescale.com --- drivers/net/ethernet/freescale/fman/Kconfig|1 + drivers/net/ethernet/freescale/fman/Makefile |6 +-

[v4, 8/9] fsl/fman: Add FMan Port Support

2015-08-05 Thread igal.liberman
From: Igal Liberman igal.liber...@freescale.com This patch adds The FMan Port configuration, initialization and runtime control routines. Signed-off-by: Igal Liberman igal.liber...@freescale.com --- drivers/net/ethernet/freescale/fman/Makefile |2 +-

[v4, 5/9] fsl/fman: Add Frame Manager support

2015-08-05 Thread igal.liberman
From: Igal Liberman igal.liber...@freescale.com Add Frame Manger Driver support. This patch adds The FMan configuration, initialization and runtime control routines. Signed-off-by: Igal Liberman igal.liber...@freescale.com --- drivers/net/ethernet/freescale/fman/Makefile |2 +-

Re: [PATCH v6 3/4] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter

2015-08-05 Thread Peter Zijlstra
On Wed, Aug 05, 2015 at 12:04:25PM +0200, Peter Zijlstra wrote: Also, you probably want a WARN_ON(in_nmi()) there, this function is _NOT_ NMI safe. I had a wee think about that, and I think the below is safe. (with the obvious problem that WARN from NMI context is not safe) It does not give

[v4, 2/9] fsl/fman: Add the FMan port FLIB

2015-08-05 Thread igal.liberman
From: Igal Liberman igal.liber...@freescale.com The FMan Port FLib provides basic API used by the drivers to configure and control the FMan Port hardware. Signed-off-by: Igal Liberman igal.liber...@freescale.com --- drivers/net/ethernet/freescale/fman/Makefile |2 +

[v4, 9/9] fsl/fman: Add FMan MAC driver

2015-08-05 Thread igal.liberman
From: Igal Liberman igal.liber...@freescale.com This patch adds the Ethernet MAC driver support. Signed-off-by: Igal Liberman igal.liber...@freescale.com Signed-off-by: Madalin Bucur madalin.bu...@freescale.com --- drivers/net/ethernet/freescale/fman/inc/mac.h | 135

[v4, 7/9] fsl/fman: Add FMan SP support

2015-08-05 Thread igal.liberman
From: Igal Liberman igal.liber...@freescale.com Add Storage Profiles support. The Storage Profiles contain parameters that are used by the FMan in order to store frames being received on the Rx ports, or to determine the parameters that affect writing the Internal Context in the frame margin on

Re: [PATCH v6 3/4] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter

2015-08-05 Thread Peter Zijlstra
On Wed, Aug 05, 2015 at 03:53:17PM +0200, Peter Zijlstra wrote: +/* + * NMI-safe method to read a local event, that is an event that + * is: + * - either for the current task, or for this CPU + * - does not have inherit set, for inherited task events + * will not be local and we

Re: [PATCH 1/5] device property: helper macros for property entry creation

2015-08-05 Thread Andy Shevchenko
On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote: Marcos for easier creation of build-in property entries. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com --- include/linux/property.h | 35 +++ 1 file changed, 35 insertions(+) diff

[PATCH] igb: Fix a memory leak in igb_probe

2015-08-05 Thread Jia-Ju Bai
In error handling code of igb_probe, the memory adapter-shadow_vfta allocated by kcalloc in igb_sw_init is not freed. So when register_netdev or igb_init_i2c is failed, a memory leak will occur. This patch adds kfree to fix it. Signed-off-by: Jia-Ju Bai baijiaju1...@163.com ---

Re: [PATCH 2/5] net: rfkill: add rfkill_find_type function

2015-08-05 Thread Andy Shevchenko
On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote: Helper for finding the type based on name. Useful if the type needs to be determined based on device property. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com --- include/linux/rfkill.h | 15 +

Re: [PATCH 1/5] device property: helper macros for property entry creation

2015-08-05 Thread Shevchenko, Andriy
On Wed, 2015-08-05 at 17:02 +0300, Andy Shevchenko wrote: On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote: [] +#define PROP_ENTRY_STRING(_name_, _val_) { \ …_STRING_ARRAY I can notice. s / can / can't / + .name = _name_, \ + .type = DEV_PROP_STRING, \ + .nval = 1,

Re: [PATCH 5/5] net: rfkill: gpio: remove rfkill_gpio_platform_data

2015-08-05 Thread Andy Shevchenko
On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote: No more users for it. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com --- include/linux/rfkill-gpio.h | 37 --- -- net/rfkill/Kconfig | 3 +-- net/rfkill/rfkill-gpio.c|

Re: [PATCH net-next] vxlan: expose COLLECT_METADATA flag to user space

2015-08-05 Thread Thomas Graf
On 08/03/15 at 02:14pm, Jesse Gross wrote: On Fri, Jul 31, 2015 at 8:41 AM, Alexei Starovoitov a...@plumgrid.com wrote: thanks. I think exposing collect_metadata for vxlan and in the future for other tunnel types is the clean enough way, though the other alternative would be to get rid of

Re: [PATCH net-next] vxlan: combine VXLAN_FLOWBASED into VXLAN_COLLECT_METADATA

2015-08-05 Thread Thomas Graf
On 08/04/15 at 10:51pm, Alexei Starovoitov wrote: IFLA_VXLAN_FLOWBASED is useless without IFLA_VXLAN_COLLECT_METADATA, so combine them into single IFLA_VXLAN_COLLECT_METADATA flag. 'flowbased' doesn't convey real meaning of the vxlan tunnel mode. This mode can be used by routing, tc+bpf and

[PATCH RFC 1/2] of: separate fixed link parsing from registration

2015-08-05 Thread Madalin Bucur
Some drivers may need to parse the fixed link values before registering the fixed link phy or access the status values. Separate the parsing from the actual registration and provide an export for the added parsing function. Signed-off-by: Madalin Bucur madalin.bu...@freescale.com ---

[PATCH RFC 2/2] fsl_fman: use fixed_phy_status for MEMAC

2015-08-05 Thread Madalin Bucur
Use the speed and duplex information from the device tree fixed link node accessing the status structure parsed by of_phy_parse_fixed_link(). Signed-off-by: Madalin Bucur madalin.bu...@freescale.com --- .../ethernet/freescale/fman/flib/fsl_fman_memac.h | 6 ++--

[PATCH 0/2] of: fsl/fman: reuse the fixed node parsing code

2015-08-05 Thread Madalin Bucur
The FMan MAC configuration code needs the speed and duplex information for fixed-link interfaces that is parsed now by the of function of_phy_register_fixed_link(). This parses the fixed-link parameters but does not expose to the caller neither the phy_device pointer nor the status struct where it

Re: veths often slow to come up

2015-08-05 Thread Thadeu Lima de Souza Cascardo
On Tue, Aug 04, 2015 at 08:26:28PM -0700, Cong Wang wrote: (Cc'ing netdev for network issues) On Tue, Aug 4, 2015 at 6:42 AM, Shaun Crampton shaun.cramp...@metaswitch.com wrote: Please CC me on any responses, thanks. Setting both ends of a veth to be oper UP completes very quickly but I

Re: [PATCH] ARCNET: fix hard_header_len limit

2015-08-05 Thread Michael Grzeschik
On Thu, Jul 30, 2015 at 11:16:36AM -0700, David Miller wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de Date: Thu, 30 Jul 2015 15:34:36 +0200 The commit 9c7077622dd9 (packet: make packet_snd fail on len smaller than l2 header) adds the check for minimum packet length of the used

[PATCH net-next] r8169:Issues on alloc memory

2015-08-05 Thread Corcodel Marian
Many, many issues DESC_ARRAY represent number of descriptor on array on Tx and Rx and is fit with TxDesc and RxDesc structure, MAX_DESCRIPTORS is 1024 on Rx and Tx wich is included 256 Descriptors from chip on Rx and Tx. DESC_ARRAY * NUM_ARRAYS_MAX must fit with MAX_DESCRIPTORS 256 from

[v2 9/9] dpaa_eth: add trace points

2015-08-05 Thread Madalin Bucur
Add trace points on the hot processing path. Signed-off-by: Ruxandra Ioana Radulescu ruxandra.radule...@freescale.com --- drivers/net/ethernet/freescale/dpaa/Makefile | 1 + drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 12 ++ drivers/net/ethernet/freescale/dpaa/dpaa_eth.h |

[v2 2/9] dpaa_eth: add support for DPAA Ethernet

2015-08-05 Thread Madalin Bucur
This introduces the Freescale Data Path Acceleration Architecture (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan, BMan, PAMU and FMan drivers to deliver Ethernet connectivity on the Freescale DPAA QorIQ platforms. Signed-off-by: Madalin Bucur madalin.bu...@freescale.com ---

[v2 5/9] dpaa_eth: add ethtool functionality

2015-08-05 Thread Madalin Bucur
Add support for basic ethtool operations. Signed-off-by: Madalin Bucur madalin.bu...@freescale.com --- drivers/net/ethernet/freescale/dpaa/Makefile | 2 +- .../net/ethernet/freescale/dpaa/dpaa_eth_common.c | 2 + .../net/ethernet/freescale/dpaa/dpaa_eth_common.h | 3 +

[v2 7/9] dpaa_eth: add debugfs counters

2015-08-05 Thread Madalin Bucur
Add a series of counters to be exported through debugfs: - add detailed counters for reception errors; - add detailed counters for QMan enqueue reject events; - count the number of fragmented skbs received from the stack; - count all frames received on the Tx confirmation path; - add congestion

[v2 6/9] dpaa_eth: add sysfs exports

2015-08-05 Thread Madalin Bucur
Export Frame Queue and Buffer Pool IDs through sysfs. Signed-off-by: Madalin Bucur madalin.bu...@freescale.com --- drivers/net/ethernet/freescale/dpaa/Makefile | 2 +- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 + drivers/net/ethernet/freescale/dpaa/dpaa_eth.h | 3 +

[v2 8/9] dpaa_eth: add debugfs entries

2015-08-05 Thread Madalin Bucur
Export per CPU counters through debugfs. Signed-off-by: Madalin Bucur madalin.bu...@freescale.com --- drivers/net/ethernet/freescale/dpaa/Kconfig| 7 + drivers/net/ethernet/freescale/dpaa/Makefile | 3 + drivers/net/ethernet/freescale/dpaa/dpaa_debugfs.c | 272

[v2 3/9] dpaa_eth: add support for S/G frames

2015-08-05 Thread Madalin Bucur
Add support for Scater/Gather (S/G) frames. The FMan can place the frame content into multiple buffers and provide a S/G Table (SGT) into one first buffer with references to the others. Signed-off-by: Madalin Bucur madalin.bu...@freescale.com --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c

[v2 4/9] dpaa_eth: add driver's Tx queue selection mechanism

2015-08-05 Thread Madalin Bucur
Allow the selection of the transmission queue based on the CPU id. Signed-off-by: Madalin Bucur madalin.bu...@freescale.com --- drivers/net/ethernet/freescale/dpaa/Kconfig | 10 ++ drivers/net/ethernet/freescale/dpaa/dpaa_eth.c| 3 +++

[v2 1/9] devres: add devm_alloc_percpu()

2015-08-05 Thread Madalin Bucur
Introduce managed counterparts for alloc_percpu() and free_percpu(). Add devm_alloc_percpu() and devm_free_percpu() into the managed interfaces list. Signed-off-by: Madalin Bucur madalin.bu...@freescale.com --- Documentation/driver-model/devres.txt | 4 +++ drivers/base/devres.c

[v2 0/9] dpaa_eth: Add the Freescale DPAA Ethernet driver

2015-08-05 Thread Madalin Bucur
This patch series adds the Ethernet driver for the Freescale QorIQ Data Path Acceleration Architecture (DPAA). This version includes changes following the feedback received on previous versions from Eric Dumazet, Bob Cochran, Joe Perches, Paul Bolle, Joakim Tjernlund, Scott Wood, David Miller -

[PATCH] sky2: Add module parameter for passing the MAC address

2015-08-05 Thread Liviu Dudau
For designs where EEPROMs are not connected to PCI Yukon2 chips we need to get the MAC address from the firmware. Add a module parameter called 'mac_address' for this. It will be used if no DT node can be found and the B2_MAC register holds an invalid value. Signed-off-by: Liviu Dudau

Re: [PATCH v6 3/4] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter

2015-08-05 Thread Alexei Starovoitov
On 8/5/15 3:04 AM, Peter Zijlstra wrote: + __perf_event_read(event); + return perf_event_count(event); +} Also, you probably want a WARN_ON(in_nmi()) there, this function is _NOT_ NMI safe. we check that very early on: unsigned int trace_call_bpf(struct bpf_prog *prog, void *ctx) {

[PATCH net-next] net/mlx5_core: Set log_uar_page_sz for non 4K page size architecture

2015-08-05 Thread clsoto
From: Carol L Soto cls...@linux.vnet.ibm.com failed to configure the page size for architectures with page size different than 4K. Signed-off-by: Carol L Soto cls...@linux.vnet.ibm.com --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v6 3/4] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter

2015-08-05 Thread Peter Zijlstra
On Wed, Aug 05, 2015 at 09:08:32AM -0700, Alexei Starovoitov wrote: On 8/5/15 6:53 AM, Peter Zijlstra wrote: +/* + * If the event is currently on this CPU, its either a per-task event, + * or local to this CPU. Furthermore it means its ACTIVE (otherwise + * oncpu == -1). +

Re: [Xen-devel] printk from softirq on xen: hard lockup

2015-08-05 Thread Jason A. Donenfeld
Hi folks, I have written an extremely simple reproducer. Xen 4.5.1. Linux 4.1.3. Config attached. Reproducer attached. Makefile attached. It results in the COMPLETE lockup of the system when it receives a network packet over the Xen PV network interface. The lockup is 100% reliable. As in the

[PATCH net-next] net: Fix race condition in store_rps_map

2015-08-05 Thread Tom Herbert
There is a race condition in store_rps_map that allows jump label count in rps_needed to go below zero. This can happen when concurrently attempting to set and a clear map. Scenario: 1. rps_needed count is zero 2. New map is assigned by setting thread, but rps_needed count _not_ yet

Re: [PATCH] sky2: Add module parameter for passing the MAC address

2015-08-05 Thread Stephen Hemminger
On Wed, 5 Aug 2015 16:50:54 +0100 Liviu Dudau liviu.du...@arm.com wrote: For designs where EEPROMs are not connected to PCI Yukon2 chips we need to get the MAC address from the firmware. Add a module parameter called 'mac_address' for this. It will be used if no DT node can be found and the

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Dmitry Torokhov
On Wed, Aug 05, 2015 at 11:08:55AM +0100, Stefano Stabellini wrote: On Tue, 4 Aug 2015, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This resulted in some misimplementation

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Wei Liu
On Tue, Aug 04, 2015 at 07:12:48PM +0100, Julien Grall wrote: [...] diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 7d50711..3b7b7c3 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -314,7 +314,7 @@ static

[PATCH 08/10] net: Use passed in table for nexthop lookups

2015-08-05 Thread David Ahern
If a user passes in a table for new routes use that table for nexthop lookups. Specifically, this solves the case where a connected route does not exist in the main table, but only another table and then a subsequent route is added with a next hop using the connected route. ie., $ ip route ls

[PATCH net-next 00/10] VRF-lite - v4

2015-08-05 Thread David Ahern
In the context of internet scale routing a requirement that always comes up is the need to partition the available routing tables into disjoint routing planes. A specific use case is the multi-tenancy problem where each tenant has their own unique routing tables and in the very least need

[PATCH] iproute2: Add support for VRF device

2015-08-05 Thread David Ahern
Allow user to create a vrf device and specify its table binding. Based on the iplink_vlan implementation. Signed-off-by: Shrijeet Mukherjee s...@cumulusnetworks.com Signed-off-by: David Ahern d...@cumulusnetworks.com --- include/linux/if_link.h | 8 + ip/Makefile | 2 +-

[PATCH 01/10] net: Introduce VRF related flags and helpers

2015-08-05 Thread David Ahern
Add a VRF_MASTER flag for interfaces and helper functions for determining if a device is a VRF_MASTER. Add link attribute for passing VRF_TABLE id. Add vrf_ptr to netdevice. Add various macros for determining if a device is a VRF device, the index of the master VRF device and table associated

[PATCH 05/10] net: Add inet_addr lookup by table

2015-08-05 Thread David Ahern
Currently inet_addr_type and inet_dev_addr_type expect local addresses to be in the local table. With the VRF device local routes for devices associated with a VRF will be in the table associated with the VRF. Provide an alternate inet_addr lookup to use a specific table rather than defaulting to

[PATCH 03/10] net: Use VRF device index for lookups on TX

2015-08-05 Thread David Ahern
As with ingress use the index of VRF master device for route lookups on egress. However, the oif should only be used to direct the lookups to a specific table. Routes in the table are not based on the VRF device but rather interfaces that are part of the VRF so do not consider the oif for lookups

[PATCH 10/10] net: Introduce VRF device driver

2015-08-05 Thread David Ahern
This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a VRF master device with an associated table and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all connected routes for the enslaved

[PATCH 02/10] net: Use VRF device index for lookups on RX

2015-08-05 Thread David Ahern
On ingress use index of VRF master device for route lookups if real device is enslaved. Rules are expected to be installed for the VRF device to direct lookups to a specific table. Signed-off-by: Shrijeet Mukherjee s...@cumulusnetworks.com Signed-off-by: David Ahern d...@cumulusnetworks.com ---

[PATCH 04/10] udp: Handle VRF device

2015-08-05 Thread David Ahern
For unconnected UDP sockets using a VRF device lookup source address based on VRF table. This allows the UDP header to be properly setup before showing up at the VRF device via the dst. Signed-off-by: Shrijeet Mukherjee s...@cumulusnetworks.com Signed-off-by: David Ahern d...@cumulusnetworks.com

[PATCH 09/10] net: Use VRF device index for socket lookups

2015-08-05 Thread David Ahern
The intent of the VRF device is to leverage the existing SO_BINDTODEVICE as a means of creating L3 domains. Since sockets are expected to be bound to the VRF device the index of the master device needs to be used for socket lookups. Signed-off-by: Shrijeet Mukherjee s...@cumulusnetworks.com

  1   2   >