Re: [RFC PATCH net] sctp: ASCONF-ACK with Unresolvable Address should be sent

2015-08-10 Thread lucien xin
On Mon, Jul 27, 2015 at 9:44 PM, Marcelo Ricardo Leitner marcelo.leit...@gmail.com wrote: On Sat, Jul 25, 2015 at 01:08:08PM +0800, Xin Long wrote: RFC 5061: This is an opaque integer assigned by the sender to identify each request parameter. The receiver of the ASCONF Chunk will copy

[PATCH net-next] bpf: fix the bug 'struct bpf_array' has no member named 'prog' in s390 architecture

2015-08-10 Thread Kaixu Xia
'Kbuild test robot' sent me an email about a build error 'struct bpf_array' has no member named 'prog' in s390 architecture. This error is caused by commit: 2a36f0b92eb 638dd023870574eb471b1c56be9ad [656/692] bpf: Make the bpf _prog_array_map more generic. In this patch, the member 'prog' of

Re: [PATCH v2] net/fddi: remove HWM_REVERSE() macro

2015-08-10 Thread yalin wang
On Aug 11, 2015, at 12:24, David Miller da...@davemloft.net wrote: From: yalin wang yalin.wang2...@gmail.com Date: Tue, 11 Aug 2015 09:57:21 +0800 HWM_REVERSE() macro is unused, remove it. Signed-off-by: yalin wang yalin.wang2...@gmail.com Your email client has corrupted this patch.

[PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

2015-08-10 Thread yalin wang
HWM_REVERSE() macro is unused, remove it. Signed-off-by: yalin wang yalin.wang2...@gmail.com --- drivers/net/fddi/skfp/h/hwmtm.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/net/fddi/skfp/h/hwmtm.h b/drivers/net/fddi/skfp/h/hwmtm.h index 5924d42..4ca2341 100644 ---

Re: [PATCH net-next] bpf: fix the bug 'struct bpf_array' has no member named 'prog' in s390 architecture

2015-08-10 Thread David Miller
From: Kaixu Xia xiaka...@huawei.com Date: Tue, 11 Aug 2015 05:00:24 + 'Kbuild test robot' sent me an email about a build error 'struct bpf_array' has no member named 'prog' in s390 architecture. This error is caused by commit: 2a36f0b92eb 638dd023870574eb471b1c56be9ad [656/692] bpf: Make

Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

2015-08-10 Thread David Miller
From: yalin wang yalin.wang2...@gmail.com Date: Tue, 11 Aug 2015 13:11:22 +0800 HWM_REVERSE() macro is unused, remove it. Signed-off-by: yalin wang yalin.wang2...@gmail.com You did not do as I asked you to, this patch is still corrupted and there is no way you successfully applied what is in

Re: VxLAN support question

2015-08-10 Thread Alexei Starovoitov
On 8/10/15 4:47 PM, Andrew Qu wrote: Pretty much what I want is that kernel will have about 1K interfaces (something like Tunnel100.1-tunnel100.1000 To be created and attached to 1K bridge domains on which each VNI is associated with given VNI to bridge-domain will be assigned using other

Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

2015-08-10 Thread yalin wang
On Aug 11, 2015, at 13:37, David Miller da...@davemloft.net wrote: From: yalin wang yalin.wang2...@gmail.com Date: Tue, 11 Aug 2015 13:11:22 +0800 HWM_REVERSE() macro is unused, remove it. Signed-off-by: yalin wang yalin.wang2...@gmail.com You did not do as I asked you to, this

Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp()

2015-08-10 Thread Jonathan Maxwell
What if the carrier check passes, and then the chip reset starts on another cpu? You'll have the same problem. Okay, let me see if I can come up with a better way to mitigate this. On Tue, Aug 11, 2015 at 2:22 PM, David Miller da...@davemloft.net wrote: From: Jon Maxwell jmaxwel...@gmail.com

[PATCH net-next] vxlan: fix fdb_dump index calculation

2015-08-10 Thread Atzm Watanabe
When too many remotes are bound to an FDB entry, index may not be increased. This problem will be caused on the large scale environment that is based on the unicast default destination, for instance. Signed-off-by: Atzm Watanabe a...@iij.ad.jp --- drivers/net/vxlan.c | 10 +- 1 file

Re: [PATCHv1 bluetooth-next] cc2520: set the default fifo pin value from platform data

2015-08-10 Thread Varka Bhadram
Yup... :-) Your name in the From (LIYONG) address is different from SOB (Yong Li) address. It should be same, please fix your email-client. On 08/10/2015 12:59 PM, LIYONG wrote: In case of the device tree support is disabled, the fifo_pin is uninitialized, this patch will set the fifo_pin

[PATCH] net/fddi:change HWM_REVERSE() macro

2015-08-10 Thread yalin wang
change HWM_REVERSE() macro to generic le32_to_cpu() Signed-off-by: yalin wang yalin.wang2...@gmail.com --- drivers/net/fddi/skfp/h/hwmtm.h | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/net/fddi/skfp/h/hwmtm.h b/drivers/net/fddi/skfp/h/hwmtm.h index

Re: [PATCH net-next v3 0/8] net: dsa: mv88e6xxx: support switchdev FDB objects

2015-08-10 Thread Vivien Didelot
Hi Andrew, On 15-08-10 16:11:38, Andrew Lunn wrote: On Mon, Aug 10, 2015 at 09:09:45AM -0400, Vivien Didelot wrote: This patchset refactors the FDB management in the mv88e6xxx code and adds the glue in DSA to use the switchdev FDB objects. Hi Vivien Thanks for reworking these

[PATCH net] inet: fix races with reqsk timers

2015-08-10 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com reqsk_queue_destroy() and reqsk_queue_unlink() should use del_timer_sync() instead of del_timer() before calling reqsk_put(), otherwise we could free a req still used by another cpu. But before doing so, reqsk_queue_destroy() must release syn_wait_lock

Re: [PATCH] net/fddi:change HWM_REVERSE() macro

2015-08-10 Thread Joe Perches
On Tue, 2015-08-11 at 00:14 +0800, yalin wang wrote: HWM_REVERSE Is unused and it would be better if removed. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 08/10] ss: symmetrical subhandler output extension example

2015-08-10 Thread Eric Dumazet
On Mon, 2015-08-10 at 15:19 +0300, Sergei Shtylyov wrote: {} not needed. I guess you haven't run your patches thru scripts/checkpatch.pl? Yes, although this is missing from iproute2 sources ;) -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

[PATCH net-next 9/9] net: Introduce VRF device driver

2015-08-10 Thread David Ahern
This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a VRF master device with an associated table and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all connected routes for the enslaved

[PATCH 3/5] netfilter: conntrack: Use flags in nf_ct_tmpl_alloc()

2015-08-10 Thread Pablo Neira Ayuso
From: Joe Stringer joestrin...@nicira.com The flags were ignored for this function when it was introduced. Also fix the style problem in kzalloc. Fixes: 0838aa7fc (netfilter: fix netns dependencies with conntrack templates) Signed-off-by: Joe Stringer joestrin...@nicira.com Signed-off-by: Pablo

[PATCH 4/5] netfilter: ip6t_SYNPROXY: fix NULL pointer dereference

2015-08-10 Thread Pablo Neira Ayuso
From: Phil Sutter p...@nwl.cc This happens when networking namespaces are enabled. Suggested-by: Patrick McHardy ka...@trash.net Signed-off-by: Phil Sutter p...@nwl.cc Acked-by: Patrick McHardy ka...@trash.net Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org ---

[PATCH 1/5] netfilter: nf_conntrack: silence warning on falling back to vmalloc()

2015-08-10 Thread Pablo Neira Ayuso
Since 88eab472ec21 (netfilter: conntrack: adjust nf_conntrack_buckets default value), the hashtable can easily hit this warning. We got reports from users that are getting this message in a quite spamming fashion, so better silence this. Signed-off-by: Pablo Neira Ayuso pa...@netfilter.org

Re: [PATCH net-next 1/2] net: track link status of ipv6 nexthops

2015-08-10 Thread David Miller
From: Andy Gospodarek go...@cumulusnetworks.com Date: Thu, 6 Aug 2015 11:42:33 -0400 Add support to track current link status of ipv6 nexthops to match recent changes that added support for ipv4 nexthops. There was not a field already available that could track these and no space available

[PATCH 0/5] Netfilter fixes for net

2015-08-10 Thread Pablo Neira Ayuso
Hi David, The following patchset contains five Netfilter fixes for your net tree, they are: 1) Silence a warning on falling back to vmalloc(). Since 88eab472ec21, we can easily hit this warning message, that gets users confused. So let's get rid of it. 2) Recently when porting the

[PATCH 2/5] netfilter: nf_conntrack: checking for IS_ERR() instead of NULL

2015-08-10 Thread Pablo Neira Ayuso
From: Dan Carpenter dan.carpen...@oracle.com We recently changed this from nf_conntrack_alloc() to nf_ct_tmpl_alloc() so the error handling needs to changed to check for NULL instead of IS_ERR(). Fixes: 0838aa7fcfcd ('netfilter: fix netns dependencies with conntrack templates') Signed-off-by:

[PATCH 5/5] netfilter: SYNPROXY: fix sending window update to client

2015-08-10 Thread Pablo Neira Ayuso
From: Phil Sutter p...@nwl.cc Upon receipt of SYNACK from the server, ipt_SYNPROXY first sends back an ACK to finish the server handshake, then calls nf_ct_seqadj_init() to initiate sequence number adjustment of forwarded packets to the client and finally sends a window update to the client to

Re: [PATCH net] netlink: make sure -EBUSY won't escape from netlink_insert

2015-08-10 Thread David Miller
From: Daniel Borkmann dan...@iogearbox.net Date: Fri, 7 Aug 2015 00:26:41 +0200 Linus reports the following deadlock on rtnl_mutex; triggered only once so far (extract): ... It seems so far plausible that the recursive call into rtnetlink_rcv() looks suspicious. One way, where this could

Re: kernel warning in tcp_fragment

2015-08-10 Thread Jovi Zhangwei
Ping? We saw a lot of this warnings in our production system. It would be great appreciate if someone can give us the fix on this warnings. :) On Fri, Jul 31, 2015 at 11:04 AM, Jovi Zhangwei j...@cloudflare.com wrote: Hi Eric, Would you like share your thought on this bug? great thanks. On

Re: [PATCH 08/10] ss: symmetrical subhandler output extension example

2015-08-10 Thread Sergei Shtylyov
On 08/10/2015 05:53 PM, Eric Dumazet wrote: {} not needed. I guess you haven't run your patches thru scripts/checkpatch.pl? Yes, although this is missing from iproute2 sources ;) Oh, sorry, somehow I thought it's a kernel patch. :-) MBR, Sergei -- To unsubscribe from this list:

Re: IPv6 and private net with masquerading not working correctly

2015-08-10 Thread Cong Wang
(Cc'ing netdev and netfilter-devel) On Fri, Aug 7, 2015 at 6:00 AM, Gerhard Wiesinger li...@wiesinger.com wrote: On 06.08.2015 20:43, Gerhard Wiesinger wrote: Hello, I'm having the following problem with IPv6 and a private internal LAN which will be masqueraded to the public internet (I

[PATCH net-next 00/10] VRF-lite - v5

2015-08-10 Thread David Ahern
In the context of internet scale routing a requirement that always comes up is the need to partition the available routing tables into disjoint routing planes. A specific use case is the multi-tenancy problem where each tenant has their own unique routing tables and in the very least need

[PATCH net-next 2/9] net: Use VRF device index for lookups on RX

2015-08-10 Thread David Ahern
On ingress use index of VRF master device for route lookups if real device is enslaved. Rules are expected to be installed for the VRF device to direct lookups to a specific table. Signed-off-by: Shrijeet Mukherjee s...@cumulusnetworks.com Signed-off-by: David Ahern d...@cumulusnetworks.com ---

[PATCH 06/10] ss: replaced old output mechanisms with fmt handlers interfaces

2015-08-10 Thread Matthias Tafelmeier
Now, since the fmt (json, hr) handlers are in place, all can be output via these newly deviced code parts. Signed-off-by: Matthias Tafelmeier matthias.tafelme...@gmx.net Suggested-by: Hagen Paul Pfeifer ha...@jauu.net --- misc/ss.c | 330

[PATCH 09/10] ss: symmetrical formatter extension example

2015-08-10 Thread Matthias Tafelmeier
This commit shall show shortly where to place changes when one wants to extend an ss output formatter with a new handler (format print procedure). The extension is done symmetrically. That means, every up to now existing formatter is extended with a semantically equivalent handler (hr and json

V2 iproute2: full ss json support and general output simplification

2015-08-10 Thread Matthias Tafelmeier
TLDR: - add full JSON support for ss - Patchset provides a general and easy to use abstraction to extend ss later - Patchset size is large to minimize daily use (user should not deal with formation (json, human readble) later on) - Patches 8/10 and 9/10 illustrate how to extend ss for new

[PATCH 08/10] ss: symmetrical subhandler output extension example

2015-08-10 Thread Matthias Tafelmeier
This small sized patch shall convey the locations which have to be changed for a symmetrical output extension. Symmetrical means in this context all existing semantically related handlers in the diverse formatters (for hr and json up to now). Signed-off-by: Matthias Tafelmeier

[PATCH 04/10] ss: prepare timer for output handler usage

2015-08-10 Thread Matthias Tafelmeier
Minor preparation Patch Renamed, and exported timer to not have to pass it as a function local parameter argument. Signed-off-by: Matthias Tafelmeier matthias.tafelme...@gmx.net Suggested-by: Hagen Paul Pfeifer ha...@jauu.net --- misc/ss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 07/10] ss: renaming and export of current_filter

2015-08-10 Thread Matthias Tafelmeier
Exported current_filter as ss_current_filter, because in the fmt handlers, I need that piece of info to resolve out issues of json. Signed-off-by: Matthias Tafelmeier matthias.tafelme...@gmx.net Suggested-by: Hagen Paul Pfeifer ha...@jauu.net --- misc/ss.c | 218

[PATCH 03/10] ss: removed obsolet fmt functions

2015-08-10 Thread Matthias Tafelmeier
Those functions are obsoleted since the new fmt handler mechanism subsumes their tasks. Rendundancy would be contradictory to the new mechanism. Signed-off-by: Matthias Tafelmeier matthias.tafelme...@gmx.net Suggested-by: Hagen Paul Pfeifer ha...@jauu.net --- misc/ss.c | 190

[PATCH 02/10] ss: created formatters for json and hr

2015-08-10 Thread Matthias Tafelmeier
This patch creates a central formatter module that acts as a kind of switch. From there, more specific handler modules for the certain output formats are called. Up to now, humand readable and json do exist. That prepares ss for potential output format extensions in the future. With the help of

[PATCH 05/10] ss: framed skeleton for json output in ss

2015-08-10 Thread Matthias Tafelmeier
This patch just adds the --json flag to ss. Also it ensures proper stats components bracketization – that goes for ex. TCP, UDP, NETLINK etc. Moreover, this patch prevents human readable headers to be printed. The first element flag ensures, that every first output json container element is

[PATCH 01/10] ss: rooted out ss type declarations for output formatters

2015-08-10 Thread Matthias Tafelmeier
The prospected output formatters and ss do share type declarations like slabstat or tcpstat so that the decision has been made to centralize those declarations in ss_types.h. Potential future declarations shall be placed there. The latter should help amend the extent of ss.c as well.

[PATCH 10/10] ss: fixed free on local array for valid json output

2015-08-10 Thread Matthias Tafelmeier
Minor fix to enable json output. Freeing of automatic char array name which will get freed after function stack cleanup. Another one after tcp_stats_fmt for freeing automatic tcpstats struct instance. Signed-off-by: Matthias Tafelmeier matthias.tafelme...@gmx.net Suggested-by: Hagen Paul Pfeifer

Re: [PATCH 08/10] ss: symmetrical subhandler output extension example

2015-08-10 Thread Matthias Tafelmeier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA384 {} not needed. I guess you haven't run your patches thru scripts/checkpatch.pl? Yes, although this is missing from iproute2 sources ;) Thank you for reviewing so far. I see there slipped some parts of the patch through according

Re: [RFC PATCH net-next] tcp: reduce cpu usage under tcp memory pressure when SO_SNDBUF is set

2015-08-10 Thread Jason Baron
On 08/10/2015 10:47 AM, Eric Dumazet wrote: On Fri, 2015-08-07 at 18:31 +, Jason Baron wrote: From: Jason Baron jba...@akamai.com When SO_SNDBUF is set and we are under tcp memory pressure, the effective write buffer space can be much lower than what was set using SO_SNDBUF. For

[PATCH] mkiss: Fix error handling in mkiss_open()

2015-08-10 Thread Fabio Estevam
If register_netdev() fails we are not propagating the error and we return success because ax_open() succeeded previously. Fix this by checking the return value of ax_open() and register_netdev() and propagate the error in case of failure. Reported-by: RUC_Soft_Sec zy900...@163.com

Re: [PATCH v2] openvswitch: Fix L4 checksum handling when dealing with IP fragments

2015-08-10 Thread David Miller
From: Glenn Griffin ggriffin.ker...@gmail.com Date: Mon, 10 Aug 2015 10:43:16 -0700 On Mon, Aug 03, 2015 at 02:03:28PM -0700, David Miller wrote: From: Glenn Griffin ggriffin.ker...@gmail.com Date: Mon, 3 Aug 2015 09:56:54 -0700 openvswitch modifies the L4 checksum of a packet when

[PATCH net-next 8/9] net: Use passed in table for nexthop lookups

2015-08-10 Thread David Ahern
If a user passes in a table for new routes use that table for nexthop lookups. Specifically, this solves the case where a connected route does not exist in the main table, but only another table and then a subsequent route is added with a next hop using the connected route. ie., $ ip route ls

[PATCH] iproute2: Add support for VRF device

2015-08-10 Thread David Ahern
Allow user to create a vrf device and specify its table binding. Based on the iplink_vlan implementation. Signed-off-by: Shrijeet Mukherjee s...@cumulusnetworks.com Signed-off-by: David Ahern d...@cumulusnetworks.com --- include/linux/if_link.h | 8 + ip/Makefile | 2 +-

[PATCH net-next 6/9] net: Fix up inet_addr_type checks

2015-08-10 Thread David Ahern
Currently inet_addr_type and inet_dev_addr_type expect local addresses to be in the local table. With the VRF device local routes for devices associated with a VRF will be in the table associated with the VRF. Provide an alternate inet_addr lookup to use a specific table rather than defaulting to

[PATCH net-next 7/9] net: Add routes to the table associated with the device

2015-08-10 Thread David Ahern
When a device associated with a VRF is brought up or down routes should be added to/removed from the table associated with the VRF. fib_magic defaults to using the main or local tables. Have it use the table with the device if there is one. A part of this is directing prefsrc validations to the

[PATCH net-next 5/9] net: Add inet_addr lookup by table

2015-08-10 Thread David Ahern
Currently inet_addr_type and inet_dev_addr_type expect local addresses to be in the local table. With the VRF device local routes for devices associated with a VRF will be in the table associated with the VRF. Provide an alternate inet_addr lookup to use a specific table rather than defaulting to

Re: [PATCH net] bna: fix interrupts storm caused by erroneous packets

2015-08-10 Thread David Miller
From: Ivan Vecera ivec...@redhat.com Date: Thu, 6 Aug 2015 22:48:23 +0200 The commit e29aa33 bna: Enable Multi Buffer RX moved packets counter increment from the beginning of the NAPI processing loop after the check for erroneous packets so they are never accounted. This counter is used to

Re: [PATCH iproute2] tipc: fix bearer get/set help synopsis

2015-08-10 Thread Stephen Hemminger
On Fri, 7 Aug 2015 09:55:09 +0200 richard.a...@ericsson.com wrote: From: Richard Alpe richard.a...@ericsson.com One option is required for bearer set and bearer get. Applied, thanks -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH v2] openvswitch: Fix L4 checksum handling when dealing with IP fragments

2015-08-10 Thread Glenn Griffin
On Mon, Aug 03, 2015 at 02:03:28PM -0700, David Miller wrote: From: Glenn Griffin ggriffin.ker...@gmail.com Date: Mon, 3 Aug 2015 09:56:54 -0700 openvswitch modifies the L4 checksum of a packet when modifying the ip address. When an IP packet is fragmented only the first fragment

[PATCH net-next 1/9] net: Introduce VRF related flags and helpers

2015-08-10 Thread David Ahern
Add a VRF_MASTER flag for interfaces and helper functions for determining if a device is a VRF_MASTER. Add link attribute for passing VRF_TABLE id. Add vrf_ptr to netdevice. Add various macros for determining if a device is a VRF device, the index of the master VRF device and table associated

[PATCH net-next 4/9] udp: Handle VRF device in sendmsg

2015-08-10 Thread David Ahern
For unconnected UDP sockets using a VRF device lookup source address based on VRF table. This allows the UDP header to be properly setup before showing up at the VRF device via the dst. Signed-off-by: Shrijeet Mukherjee s...@cumulusnetworks.com Signed-off-by: David Ahern d...@cumulusnetworks.com

[PATCH net-next 3/9] net: Use VRF device index for lookups on TX

2015-08-10 Thread David Ahern
As with ingress use the index of VRF master device for route lookups on egress. However, the oif should only be used to direct the lookups to a specific table. Routes in the table are not based on the VRF device but rather interfaces that are part of the VRF so do not consider the oif for lookups

Re: [PATCH 0/3] Fixes for the network driver of Marvell Armada 375 SoC

2015-08-10 Thread David Miller
From: Marcin Wojtas m...@semihalf.com Date: Thu, 6 Aug 2015 19:00:27 +0200 This is a set of three patches that fix long-lasting problems implemented in the initial support for the Armada 375 network controller. Due to an inappropriate concept of handling the per-CPU sent packets'

Re: [PATCH iproute2 -next] m_bpf: add frontend support for late binding

2015-08-10 Thread Stephen Hemminger
On Fri, 7 Aug 2015 11:36:50 +0200 Daniel Borkmann dan...@iogearbox.net wrote: Frontend support for kernel commit a5c90b29e5cc (act_bpf: properly support late binding of bpf action to a classifier). Signed-off-by: Daniel Borkmann dan...@iogearbox.net Applied to net-next -- To unsubscribe

Re: [PATCH iproute2 net-next] iplink: bonding: add support for IFLA_BOND_TLB_DYNAMIC_LB

2015-08-10 Thread Stephen Hemminger
On Mon, 3 Aug 2015 12:19:55 +0200 Nikolay Aleksandrov ra...@blackwall.org wrote: From: Nikolay Aleksandrov niko...@cumulusnetworks.com Add support to be able to set and show the value of tlb_dynamic_lb (IFLA_BOND_TLB_DYNAMIC_LB). Example: $ ip -d link show dev bond0 type bond 7: bond0:

Re: [iproute PATCH] misc/ss: don't imply -a when -A was specified

2015-08-10 Thread Stephen Hemminger
On Fri, 7 Aug 2015 15:31:27 +0200 Phil Sutter p...@nwl.cc wrote: Signed-off-by: Phil Sutter p...@nwl.cc Ok, applied -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: kernel warning in tcp_fragment

2015-08-10 Thread Neal Cardwell
On Mon, Aug 10, 2015 at 2:10 PM, Jovi Zhangwei j...@cloudflare.com wrote: Ping? We saw a lot of this warnings in our production system. It would be great appreciate if someone can give us the fix on this warnings. :) What is your net.ipv4.tcp_mtu_probing setting? If 1, have you tried setting

Re: [PATCH net-next 1/2] net: track link status of ipv6 nexthops

2015-08-10 Thread Andy Gospodarek
On Mon, Aug 10, 2015 at 10:54:00AM -0700, David Miller wrote: From: Andy Gospodarek go...@cumulusnetworks.com Date: Thu, 6 Aug 2015 11:42:33 -0400 Add support to track current link status of ipv6 nexthops to match recent changes that added support for ipv4 nexthops. There was not a

Re: [RFC PATCH net-next] tcp: reduce cpu usage under tcp memory pressure when SO_SNDBUF is set

2015-08-10 Thread Eric Dumazet
On Fri, 2015-08-07 at 18:31 +, Jason Baron wrote: From: Jason Baron jba...@akamai.com When SO_SNDBUF is set and we are under tcp memory pressure, the effective write buffer space can be much lower than what was set using SO_SNDBUF. For example, we may have set the buffer to 100kb, but

Re: [PATCH net-next v3 7/8] net: switchdev: support static FDB addresses

2015-08-10 Thread Scott Feldman
On Mon, Aug 10, 2015 at 6:09 AM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: This patch adds an ndm_state member to the switchdev_obj_fdb structure, in order to support static FDB addresses. Set Rocker ndm_state to NUD_REACHABLE. Signed-off-by: Vivien Didelot

[PATCH 2/3] gianfar: correct list membership accounting

2015-08-10 Thread Jakub Kicinski
From: Jakub Kicinski kubak...@wp.pl At a cost of one line let's make sure .count is correct when calling gfar_process_filer_changes(). Signed-off-by: Jakub Kicinski kubak...@wp.pl --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH net] ipv6: don't reject link-local nexthop on other interface

2015-08-10 Thread David Miller
From: Florian Westphal f...@strlen.de Date: Fri, 7 Aug 2015 10:54:28 +0200 48ed7b26faa7 (ipv6: reject locally assigned nexthop addresses) is too strict; it rejects following corner-case: ip -6 route add default via fe80::1:2:3 dev eth1 [ where fe80::1:2:3 is assigned to a local

Re: [PATCH net-next] net: fec: fix the race between xmit and bdp reclaiming path

2015-08-10 Thread David Miller
From: Kevin Hao haoke...@gmail.com Date: Fri, 7 Aug 2015 13:52:37 +0800 When we transmit a fragmented skb, we may run into a race like the following scenario (assume txq-cur_tx is next to txq-dirty_tx): cpu 0 cpu 1 fec_enet_txq_submit_skb

[FWD] PROBLEM: there exists a wrong return value of function mkiss_open()

2015-08-10 Thread Linus Torvalds
I don't know how many people care about hamradio, but the report that mkiss_open() returns success even when register_netdev() fails seems entirely true. The email was just not sent to the right people.. Linus On Sun, Aug 9, 2015 at 5:08 PM, RUC_Soft_Sec zy900...@163.com

[PATCH 3/3] gianfar: remove faulty filer optimizer

2015-08-10 Thread Jakub Kicinski
From: Jakub Kicinski kubak...@wp.pl Current filer rule optimization is broken in several ways: (1) It destroys rule ordering. (2) It performs reads/writes beyond end of allocated tables. (3) It breaks badly for rules with more than 2 specifiers (e.g. matching ip, port, tos). (4) We

[PATCH 1/3] gianfar: correct filer table writing

2015-08-10 Thread Jakub Kicinski
From: Jakub Kicinski kubak...@wp.pl MAX_FILER_IDX is the last usable index. Using less-than will already guarantee that one entry for catch-all rule will be left, no need to subtract 1 here. Signed-off-by: Jakub Kicinski kubak...@wp.pl --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 5

[PATCH 0/3] gianfar: filer changes

2015-08-10 Thread Jakub Kicinski
From: Jakub Kicinski kubak...@wp.pl Hi, I've been working with the gianfar filer code recently and got some code to offer. Well, maybe not that much code to offer actually: two small fixes and removal of the current optimizer. I'm not sure what your feelings on patch 3 will be. It would be

Re: [PATCHv2 net-next 5/9] openvswitch: Add conntrack action

2015-08-10 Thread Joe Stringer
On 6 August 2015 at 14:36, Pravin Shelar pshe...@nicira.com wrote: +static void ovs_fragment(struct vport *vport, struct sk_buff *skb, +unsigned int mru, __be16 ethertype) +{ + if (skb_network_offset(skb) MAX_L2_LEN) { + OVS_NLERR(1, L2 header too

Re: [PATCH net-next v2] bridge: netlink: add support for vlan_filtering attribute

2015-08-10 Thread David Miller
From: Nikolay Aleksandrov ra...@blackwall.org Date: Fri, 7 Aug 2015 19:40:45 +0300 From: Nikolay Aleksandrov niko...@cumulusnetworks.com This patch adds the ability to toggle the vlan filtering support via netlink. Since we're already running with rtnl in .changelink() we don't need to

Re: [PATCH net-next] net: add explicit logging and stat for neighbour table overflow

2015-08-10 Thread David Miller
From: r...@tardy.usa.hp.com (Rick Jones) Date: Fri, 7 Aug 2015 11:10:37 -0700 (PDT) From: Rick Jones rick.jon...@hp.com Add an explicit neighbour table overflow message (ratelimited) and statistic to make diagnosing neighbour table overflows tractable in the wild. Diagnosing a neighbour

Re: [RFC PATCH 1/4] vhost: Introduce a universal thread to serve all users

2015-08-10 Thread Bandan Das
Michael S. Tsirkin m...@redhat.com writes: On Mon, Jul 13, 2015 at 12:07:32AM -0400, Bandan Das wrote: vhost threads are per-device, but in most cases a single thread is enough. This change creates a single thread that is used to serve all guests. However, this complicates cgroups

Re: [RFC PATCH 1/4] vhost: Introduce a universal thread to serve all users

2015-08-10 Thread Bandan Das
Bandan Das b...@redhat.com writes: Michael S. Tsirkin m...@redhat.com writes: On Mon, Jul 13, 2015 at 12:07:32AM -0400, Bandan Das wrote: vhost threads are per-device, but in most cases a single thread is enough. This change creates a single thread that is used to serve all guests.

Re: [PATCH] eventfd: implementation of EFD_MASK flag

2015-08-10 Thread Martin Sustrik
On 2015-08-10 10:57, Damian Hobson-Garcia wrote: Hi Martin, Thanks for your comments. On 2015-08-10 3:39 PM, Martin Sustrik wrote: On 2015-08-10 08:23, Damian Hobson-Garcia wrote: Replying to my own post, but I had the following comments/questions. Martin, if you have any response to my

Re: [PATCH net-next] net: dsa: mv88e6352: Use mnemonics for EEPROM registers and bits

2015-08-10 Thread David Miller
From: Andrew Lunn and...@lunn.ch Date: Sat, 8 Aug 2015 17:04:50 +0200 Add register definitions #defines for accessing the EEPROM. Signed-off-by: Andrew Lunn and...@lunn.ch Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

[patch] hamradio/kiss: missing error code in mkiss_open()

2015-08-10 Thread Dan Carpenter
If register_netdev() fails we return success but we should return an error code instead. Reported-by: RUC_Soft_Sec zy900...@163.com Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index 2ffbf13..dcb6bb7 100644 ---

Re: kernel warning in tcp_fragment

2015-08-10 Thread Jovi Zhangwei
Hi Neal, Great thanks for your reply, we will arrange testing against that patch. On Mon, Aug 10, 2015 at 11:35 AM, Neal Cardwell ncardw...@google.com wrote: On Mon, Aug 10, 2015 at 2:10 PM, Jovi Zhangwei j...@cloudflare.com wrote: Ping? We saw a lot of this warnings in our production

Re: [RFC PATCH net-next] tcp: reduce cpu usage under tcp memory pressure when SO_SNDBUF is set

2015-08-10 Thread Eric Dumazet
On Mon, 2015-08-10 at 13:29 -0400, Jason Baron wrote: + thanks. better? --- a/include/net/sock.h +++ b/include/net/sock.h @@ -798,8 +798,10 @@ static inline int sk_stream_min_wspace(const struct sock *sk) static inline int sk_stream_wspace(const struct sock *sk) { -

Re: [PATCH net-next] dsa: Support multiple MDIO busses

2015-08-10 Thread David Miller
From: Andrew Lunn and...@lunn.ch Date: Sat, 8 Aug 2015 17:09:14 +0200 When using a cluster of switches, some topologies will have an MDIO bus per switch, not one for the whole cluster. Allow this to be represented in the device tree, by adding an optional mii-bus property at the switch

Re: [patch 2/2] cxgb4: cleanup some indenting

2015-08-10 Thread David Miller
From: Dan Carpenter dan.carpen...@oracle.com Date: Sat, 8 Aug 2015 22:15:59 +0300 Add or remove some tabs so that statements line up correctly. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Applied to 'net-next', thanks Dan. -- To unsubscribe from this list: send the line unsubscribe

Re: [patch 1/2 -mainline] cxgb4: missing curly braces in t4_setup_debugfs()

2015-08-10 Thread David Miller
From: Dan Carpenter dan.carpen...@oracle.com Date: Sat, 8 Aug 2015 22:15:25 +0300 There were missing curly braces so it means we call add_debugfs_mem() unintentionally. Fixes: 3ccc6cf74d8c ('cxgb4: Adds support for T6 adapter') Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Applied

Re: [PATCH] isdn:remove reverse_bits(), use revbit8()

2015-08-10 Thread David Miller
From: yalin wang yalin.wang2...@gmail.com Date: Mon, 10 Aug 2015 17:15:57 +0800 This change isdn driver, remove reverse_bits() function, use the generic revbit8() function instead. Signed-off-by: yalin wang yalin.wang2...@gmail.com Applied, however please format your Subject lines better in

ipv6_mc_check_mld - kernel BUG at net/core/skbuff.c:1128

2015-08-10 Thread Brenden Blanco
Hi folks, Here is a crash that I am able to easily reproduce. The setup is: 2 VMs, running in libvirt (qemu-kvm) CPU mode is host-passthrough, virtio drivers used wherever available Disable ipv6 (just to limit the amount of multicast noise) Set up a multicast vxlan tunnel between the two VMs

Re: [PATCH net-next v5 0/4] GRE: Use flow based tunneling for OVS GRE vport.

2015-08-10 Thread David Miller
From: Pravin B Shelar pshe...@nicira.com Date: Fri, 7 Aug 2015 23:49:50 -0700 Following patches make use of new Using GRE tunnel meta data collection feature. This allows us to directly use netdev based GRE tunnel implementation. While doing so I have removed GRE demux API which were

Re: [PATCH net 0/2] bnx2x: small fixes

2015-08-10 Thread David Miller
From: Yuval Mintz yuval.mi...@qlogic.com Date: Mon, 10 Aug 2015 12:49:34 +0300 This adds 2 small fixes, one to error flows during memory release and the other to flash writes via ethtool API. Series applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body

[PATCH net] inet: fix possible request socket leak

2015-08-10 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com In commit b357a364c57c9 (inet: fix possible panic in reqsk_queue_unlink()), I missed fact that tcp_check_req() can return the listener socket in one case, and that we must release the request socket refcount or we leak it. Tested: Following packetdrill

[PATCH] rt2x00: adjust EEPROM_SIZE for rt2500usb

2015-08-10 Thread Adrien Schildknecht
rt2500usb_validate_eeprom() read data up to 0x6e (EEPROM_CALIBRATE_OFFSET) but only 0x6a bytes has been allocated and read from the eeprom. This lead to out-of-bound accesses and invalid values for EEPROM_BBPTUNE_R17 and EEPROM_CALIBRATE_OFFSET. Change the EEPROM_SIZE to 0x6e in order to

[PATCH] xfrm: Add oif to dst lookups

2015-08-10 Thread David Ahern
Rules can be installed that direct route lookups to specific tables based on oif. Plumb the oif through the xfrm lookups so it gets set in the flow struct and passed to the resolver routines. Signed-off-by: David Ahern d...@cumulusnetworks.com --- include/net/xfrm.h | 7 +--

VxLAN support question

2015-08-10 Thread Andrew Qu
Hi VxLAN experts, In user space, we are developing a CLI as the following: Interface tunnel 100 Mode vxlan Remote ip ipv4 19.1.1.1 Local ip ipv4 20.1.1.1 Vni 1-1000 With Kernel 3.12.37, we can't support above configurations in kernel. (OR PLEASE Correct me if I am wrong)

RE: [v4, 0/9] Freescale DPAA FMan

2015-08-10 Thread Liberman Igal
Hello David, Thank you for your feedback. I understand your concerns regarding the FMan driver, we've come a long way from where we started but still there are issues. The community support is critical for getting the code to the desired quality level and I appreciate the support I receive

Re: [PATCH net-next 0/6] qlcnic: enhancements

2015-08-10 Thread David Miller
From: Shahed Shaikh shahed.sha...@qlogic.com Date: Fri, 7 Aug 2015 07:17:01 -0400 This series adds few enhancements. o Patch from Harish reorders the sequence of header files inclusion, keeping kernel's header files on top. o Firmware introduced a new feature which allows driver

Re: [PATCH v2 bluetooth-next] cc2520: set the default fifo pin value from platform data

2015-08-10 Thread Varka Bhadram
On 08/11/2015 08:13 AM, sdliy...@gmail.com wrote: From: Yong Li sdliy...@gmail.com When the device tree support is disabled, the fifo_pin is uninitialized, this patch will set the fifo_pin value based on platform data Signed-off-by: Yong Li sdliy...@gmail.com Acked-by: Varka Bhadram

Re: [PATCH] net: Unbreak resetting default values for tcp_wmem/udp_wmem_min

2015-08-10 Thread Calvin Owens
On Sunday 08/09 at 22:41 -0700, David Miller wrote: From: Calvin Owens calvinow...@fb.com Date: Wed, 5 Aug 2015 13:26:54 -0700 Commit 8133534c760d4083 (net: limit tcp/udp rmem/wmem to SOCK_{RCV,SND}BUF_MIN) modified four sysctls to enforce that the values written to them are not less

Re: [PATCH] net: Unbreak resetting default values for tcp_wmem/udp_wmem_min

2015-08-10 Thread David Miller
From: Calvin Owens calvinow...@fb.com Date: Mon, 10 Aug 2015 20:34:06 -0700 I'm really questioning the limitation itself: why enforce a minimum of SOCK_MIN_SNDBUF here? Why not SK_MEM_QUANTUM? Commit 8133534c760d4083 referred to b1cb59cf2efe7971, which choose to use the SOCK_MIN constants

Re: [PATCH] mkiss: Fix error handling in mkiss_open()

2015-08-10 Thread David Miller
From: Fabio Estevam fabio.este...@freescale.com Date: Mon, 10 Aug 2015 14:22:43 -0300 If register_netdev() fails we are not propagating the error and we return success because ax_open() succeeded previously. Fix this by checking the return value of ax_open() and register_netdev() and

Re: [PATCH 0/5] Netfilter fixes for net

2015-08-10 Thread David Miller
From: Pablo Neira Ayuso pa...@netfilter.org Date: Mon, 10 Aug 2015 19:58:34 +0200 The following patchset contains five Netfilter fixes for your net tree, they are: 1) Silence a warning on falling back to vmalloc(). Since 88eab472ec21, we can easily hit this warning message, that gets

Re: [PATCH net-next] mellanox: mlxsw: Use '%zx' to print size_t format

2015-08-10 Thread David Miller
From: Fabio Estevam fabio.este...@freescale.com Date: Mon, 10 Aug 2015 09:54:28 -0300 Use '%zx' to print size_t format in order to fix the following build warning: drivers/net/ethernet/mellanox/mlxsw/item.h:65:3: warning: format '%lx' expects argument of type 'long unsigned int', but

  1   2   >