Re: [PATCH] iproute2: Extend bridge command to configure ageing interval on bridge devices.

2015-08-14 Thread Michal Kubecek
On Fri, Aug 14, 2015 at 09:50:02AM +, Premkumar Jonnala wrote: Extend bridge command to configure and retrieve ageing interval for bridge devices. Netlink messaging is used to configure and retrieve the ageing interval. Signed-off-by: Premkumar Jonnala pjonn...@broadcom.com ... diff

pull-request: mac80211 2015-08-14

2015-08-14 Thread Johannes Berg
Hi Dave, I'm back from vacation, and found a single bugfix waiting. It's in this pull request, but I'm not quite up to speed as to what's happening with the release. If it goes in, great; if not I've already tagged it with Cc stable anyway. Thanks, johannes The following changes since commit

Re: [PATCH 1/6] net/bonding: enable LRO if one device supports it

2015-08-14 Thread Michal Kubecek
On Thu, Aug 13, 2015 at 02:02:55PM -0400, Jarod Wilson wrote: Currently, all bonding devices come up, and claim to have LRO support, which ethtool will let you toggle on and off, even if none of the underlying hardware devices actually support it. While the bonding driver takes precautions for

[PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-14 Thread Premkumar Jonnala
Bridge devices have ageing interval used to age out MAC addresses from FDB. This ageing interval was not configuratble. Enable netlink based configuration of ageing interval for bridges and switch devices. The ageing interval changes the timer used to purge inactive FDB entries in bridges. The

Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

2015-08-14 Thread roopa
On 8/13/15, 11:23 PM, Premkumar Jonnala wrote: Bridge devices have ageing interval used to age out MAC addresses from FDB. This ageing interval was not configuratble. Enable netlink based configuration of ageing interval for bridges and switch devices. The ageing interval changes the timer

Re: [PATCH net-next 1/3] lwt: Add support to redirect dst.input

2015-08-14 Thread roopa
On 8/13/15, 9:54 AM, Tom Herbert wrote: This patch adds the capability to redirect dst input in the same way that dst output is redirected by LWT. Also, save the original dst.input and and dst.out when setting up lwtunnel redirection. These can be called by the client as a pass- through.

Re: [PATCH] iwlwifi: out-of-bounds access in iwl_init_sband_channels

2015-08-14 Thread Kalle Valo
Adrien Schildknecht adrien+...@schischi.me writes: Hi, On 08/14/2015 03:36 AM, Adrien Schildknecht wrote: Both loops of this function compare data from the 'chan' array and then check if the index is valid. The 2 conditions should be inverted to avoid an out-of-bounds access.

[PATCH 1/1] Revert net: fec: Ensure clocks are enabled while using mdio bus

2015-08-14 Thread Peter Chen
It causes the i.mx6sx sdb board hang when using nfsroot during boots up at v4.2-rc6. This reverts commit 8fff755e9f8d0f70a595e79f248695ce6aef5cc3. Cc: netdev@vger.kernel.org Cc: Fugang Duan b38...@freescale.com Cc: shawn@linaro.org Cc: fabio.este...@freescale.com Cc: tyler.ba...@linaro.org

Re: [PATCH 1/2] average: provide macro to create static EWMA

2015-08-14 Thread Johannes Berg
On Thu, 2015-08-13 at 17:26 -0700, David Miller wrote: From: Johannes Berg johan...@sipsolutions.net Date: Thu, 13 Aug 2015 11:11:48 +0200 From: Johannes Berg johannes.b...@intel.com Having the EWMA parameters stored in the runtime struct imposes memory requirements for the constant

RE: [PATCH 1/1] Revert net: fec: Ensure clocks are enabled while using mdio bus

2015-08-14 Thread Duan Andy
From: Peter Chen peter.c...@freescale.com Sent: Friday, August 14, 2015 1:48 PM To: da...@davemloft.net Cc: Chen Peter-B29397; netdev@vger.kernel.org; Duan Fugang-B38611; shawn@linaro.org; Estevam Fabio-R49496; tyler.ba...@linaro.org; Lucas Stach; Andrew Lunn Subject: [PATCH 1/1] Revert

Re: [PATCH v2 4/4] Added getsynctime64() callback

2015-08-14 Thread Richard Cochran
On Thu, Aug 13, 2015 at 09:10:36PM +, Hall, Christopher S wrote: + if (!cpu_has_art) + return -EOPNOTSUPP; Perform this check before registration, setting .getsynctime64 accordingly. The problem here is that ART initialization doesn't happen until we install TSC as a

Re: [PATCH] iwlwifi: out-of-bounds access in iwl_init_sband_channels

2015-08-14 Thread Adrien Schildknecht
Hi, On 08/14/2015 03:36 AM, Adrien Schildknecht wrote: Both loops of this function compare data from the 'chan' array and then check if the index is valid. The 2 conditions should be inverted to avoid an out-of-bounds access. Was that found by a static analyzer or any other

[net-next:master 751/762] DockBook: Warning(include/linux/netdevice.h:1293): Enum value 'IFF_VRF_MASTER' not described in enum 'netdev_priv_flags'

2015-08-14 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: d52736e24fe2e927c26817256f8d1a3c8b5d51a0 commit: 4e3c89920cd3a6cfce22c6f537690747c26128dd [751/762] net: Introduce VRF related flags and helpers reproduce: make htmldocs All warnings (new ones prefixed by ):

Re: [PATCH net-next 1/3] lwt: Add support to redirect dst.input

2015-08-14 Thread Robert Shearman
On 13/08/15 17:54, Tom Herbert wrote: This patch adds the capability to redirect dst input in the same way that dst output is redirected by LWT. Also, save the original dst.input and and dst.out when setting up lwtunnel redirection. These can be called by the client as a pass- through. The

4.1.5 oops in alloc_skb_with_frags

2015-08-14 Thread Ortwin Glück
Hi, I got a series of (same) Oopses on a fresh 4.1.5 on KDE startup: Aug 14 08:45:38 gandalf kernel: PGD 0 Aug 14 08:45:38 gandalf kernel: Oops: [#1] PREEMPT SMP Aug 14 08:45:38 gandalf kernel: Modules linked in: radeon cfbfillrect cfbimgblt cfbcopyarea fbcon i2c_algo_bit bit blit

Re: [PATCH] mm: make page pfmemalloc check more robust

2015-08-14 Thread Vlastimil Babka
On 08/13/2015 04:40 PM, Eric Dumazet wrote: On Thu, 2015-08-13 at 11:13 +0200, Vlastimil Babka wrote: Given that this apparently isn't the first case of this localhost issue, I wonder if network code should just clear skb-pfmemalloc during send (or maybe just send over localhost). That would

Re: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-14 Thread Andrew Lunn
Hi Philip So with a bit of poking and prodding, we have a much better understanding as to why this is O.K. Maybe your next patch can quote the relevant RFCs and have a much fuller commit message? Thanks Andrew -- To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH 6/6] MIPS: net: BPF: Introduce BPF ASM helpers

2015-08-14 Thread Markos Chandras
On Thu, Aug 13, 2015 at 10:42:46PM +0200, Aurelien Jarno wrote: This patch relies on R2 instructions, and thus the Linux kernel fails to build when targetting non-R2 CPUs. See for example: https://buildd.debian.org/status/fetch.php?pkg=linuxarch=mipselver=4.2%7Erc6-1%7Eexp1stamp=143948

Re: [PATCH] net/fsl: simplify Kconfig dependency list for fsl networking

2015-08-14 Thread Geert Uytterhoeven
On Fri, Aug 14, 2015 at 12:01 AM, Stuart Yoder stuart.yo...@freescale.com wrote: make the list of Kconfig dependencies for Freescale networking more general. Simplify to supported architectures: ARM, ARM64, PPC, M68K Signed-off-by: Stuart Yoder stuart.yo...@freescale.com ---

Re: [PATCH 1/1] Revert net: fec: Ensure clocks are enabled while using mdio bus

2015-08-14 Thread Lucas Stach
Am Freitag, den 14.08.2015, 08:25 + schrieb Peter Chen: Am Freitag, den 14.08.2015, 13:47 +0800 schrieb Peter Chen: It causes the i.mx6sx sdb board hang when using nfsroot during boots up at v4.2-rc6. This reverts commit 8fff755e9f8d0f70a595e79f248695ce6aef5cc3. Cc:

[PATCH v2] iwlwifi: out-of-bounds access in iwl_init_sband_channels

2015-08-14 Thread Adrien Schildknecht
KASan error report: == BUG: KASan: out of bounds access in iwl_init_sband_channels+0x207/0x260 [iwlwifi] at addr 8800c2d0aac8 Read of size 4 by task modprobe/329 ==

Re: GCOV_PROFILE_ALL breaks BUILD_BUG_ON(!is_power_of_2(8))

2015-08-14 Thread Johannes Berg
On Fri, 2015-08-14 at 11:00 +0200, Michal Kubecek wrote: but should I have expected this? It might have something to do with the fact that is_power_of_2() being an inline function, perhaps with this compiler option it translates to something that can't be used in the context

Re: Linux kernel commit breaks IPMI on iface downing

2015-08-14 Thread Sébastien Bocahu
The BNX2 firmware has already been updated to the latest version available from Dell. root@debian:~# ethtool -i eth0 | grep firmware firmware-version: 6.4.5 bc 5.2.3 NCSI 2.0.11 2015-08-14 3:30 GMT+02:00 Michael Chan mc...@broadcom.com: +netdev and Harish who is the current maintainer of bnx2

Re: [PATCH 1/1] Revert net: fec: Ensure clocks are enabled while using mdio bus

2015-08-14 Thread Lucas Stach
Am Freitag, den 14.08.2015, 13:47 +0800 schrieb Peter Chen: It causes the i.mx6sx sdb board hang when using nfsroot during boots up at v4.2-rc6. This reverts commit 8fff755e9f8d0f70a595e79f248695ce6aef5cc3. Cc: netdev@vger.kernel.org Cc: Fugang Duan b38...@freescale.com Cc:

[PATCH net-next]r8169.c: Force transmission when nic refuse to start.

2015-08-14 Thread Corcodel Marian
Brute force transmission when Rx interrupt exist on interface is up. Guaranteed to start on full duplex and not maximum speed.When set half duplex working same without this patch. For apply this patch set --whitespace=warn Signed-off-by: Corcodel Marian corcodel.mar...@gmail.com diff --git

Re: [PATCH v2] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-14 Thread Igor Plyatov
Dear Michael, Hi Igor, Am Donnerstag, 13. August 2015, 22:18:34 schrieben Sie: * Due to HW bug, LAN8700 sometimes does not detect presence of energy in the Ethernet cable in Energy Detect Power-Down mode (e.g while EDPWRDOWN bit is set, the ENERGYON bit does not asserted sometimes).

GCOV_PROFILE_ALL breaks BUILD_BUG_ON(!is_power_of_2(8))

2015-08-14 Thread Johannes Berg
+linux-kernel +#define DECLARE_EWMA(name, _factor, _weight) \ + struct ewma_##name { \ +unsigned long internal; \ + };

[PATCH net v2] ppp: fix device unregistration upon netns deletion

2015-08-14 Thread Guillaume Nault
PPP devices may get automatically unregistered when their network namespace is getting removed. This happens if the ppp control plane daemon (e.g. pppd) exits while it is the last user of this namespace. This leads to several races: * ppp_exit_net() may destroy the per namespace idr

Re: [PATCH 0/2] net: introduce IFF_NO_QUEUE as successor of zero tx_queue_len

2015-08-14 Thread Phil Sutter
On Thu, Aug 13, 2015 at 12:11:57PM -0700, Stephen Hemminger wrote: On Thu, 13 Aug 2015 20:40:37 +0200 Jesper Dangaard Brouer bro...@redhat.com wrote: On Thu, 13 Aug 2015 10:49:50 -0700 Stephen Hemminger step...@networkplumber.org wrote: On Thu, 13 Aug 2015 19:01:05 +0200 Phil

Re: [PATCH net-next 0/2] ppp: implement x-netns support

2015-08-14 Thread Guillaume Nault
On Thu, Aug 13, 2015 at 09:20:04PM -0700, David Miller wrote: From: Guillaume Nault g.na...@alphalink.fr Date: Thu, 13 Aug 2015 15:28:02 +0200 This series allows PPP devices to reside in a different netns from the PPP unit/channels. Packets only cross netns boundaries when they're

[patch] net: ethernet: micrel: fix an error code

2015-08-14 Thread Dan Carpenter
The dma_mapping_error() function returns true or false. We should return -ENOMEM if it there is a dma mapping error. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/net/ethernet/micrel/ks8842.c b/drivers/net/ethernet/micrel/ks8842.c index f78909a..09d2e16 100644 ---

RE: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-14 Thread Philip Downey
Sorry for the duplication - I responded in a similar manner before seeing this. Thanks Philip -Original Message- From: Thadeu Lima de Souza Cascardo [mailto:casca...@redhat.com] Sent: Thursday, August 13, 2015 7:08 PM To: Andrew Lunn Cc: Philip Downey; David Miller;

RE: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-14 Thread Philip Downey
Hi Andrew Answers inline... -Original Message- From: Andrew Lunn [mailto:and...@lunn.ch] Sent: Thursday, August 13, 2015 6:02 PM To: Philip Downey Cc: David Miller; kuz...@ms2.inr.ac.ru; jmor...@namei.org; yoshfuji@linux- ipv6.org; ka...@trash.net; linux-ker...@vger.kernel.org;

Re: [PATCHv1 net-next 0/5] netlink: mmap: kernel panic and some issues

2015-08-14 Thread Ken-ichirou MATSUZAWA
Hi, Thank you for taking your time. Please let me explain these with code samples on gist. I can not describe and arrange it well, sorry. normal socket nflog sample: https://gist.github.com/chamaken/dc0f80c14862e8061c06/raw/2d6da8fff31ef61af77e68713fdb1d71978746a6/nflog.c set

RE: [PATCH 1/1] Revert net: fec: Ensure clocks are enabled while using mdio bus

2015-08-14 Thread Peter Chen
Am Freitag, den 14.08.2015, 13:47 +0800 schrieb Peter Chen: It causes the i.mx6sx sdb board hang when using nfsroot during boots up at v4.2-rc6. This reverts commit 8fff755e9f8d0f70a595e79f248695ce6aef5cc3. Cc: netdev@vger.kernel.org Cc: Fugang Duan b38...@freescale.com Cc:

Re: GCOV_PROFILE_ALL breaks BUILD_BUG_ON(!is_power_of_2(8))

2015-08-14 Thread Michal Kubecek
On Fri, Aug 14, 2015 at 10:29:04AM +0200, Johannes Berg wrote: +linux-kernel +#define DECLARE_EWMA(name, _factor, _weight) \ + struct ewma_##name { \ + unsigned long internal;

Re: [PATCH 1/1] Revert net: fec: Ensure clocks are enabled while using mdio bus

2015-08-14 Thread Peter Chen
On Fri, Aug 14, 2015 at 10:27:33AM +0200, Lucas Stach wrote: Am Freitag, den 14.08.2015, 08:25 + schrieb Peter Chen: Am Freitag, den 14.08.2015, 13:47 +0800 schrieb Peter Chen: It causes the i.mx6sx sdb board hang when using nfsroot during boots up at v4.2-rc6. This

RE: [PATCH] IGMP: Inhibit reports for local multicast groups

2015-08-14 Thread Philip Downey
Hi Andrew Will resubmit with the information you suggest. There might be a slight delay for this as I am on holiday now for a week. Rest regards Philip -Original Message- From: Andrew Lunn [mailto:and...@lunn.ch] Sent: Friday, August 14, 2015 2:35 PM To: Philip Downey Cc: David

[PATCH net-next] lwtunnel: rename ip lwtunnel attributes

2015-08-14 Thread Jiri Benc
We already have IFLA_IPTUN_ netlink attributes. The IP_TUN_ attributes look very similar, yet they serve very different purpose. This is confusing for anyone trying to implement a user space tool supporting lwt. As the IP_TUN_ attributes are used only for the lightweight tunnels, prefix them with

Re: [PATCH net-next 2/4] packet: add eBPF fanout mode

2015-08-14 Thread Daniel Borkmann
[ @Willem: RH email doesn't exist anymore, I took it out, otherwise every reply gets a bounce. ;) ] On 08/14/2015 07:03 PM, Alexei Starovoitov wrote: On 8/14/15 8:50 AM, Willem de Bruijn wrote: ... all looks great except in the above the check: if (new-type !=

Re: [PATCH net-next 2/4] packet: add eBPF fanout mode

2015-08-14 Thread Willem de Bruijn
[ @Willem: RH email doesn't exist anymore, I took it out, otherwise every reply gets a bounce. ;) ] Sorry for using the wrong address, Daniel. Also instead of: #define PACKET_FANOUT_BPF6 #define PACKET_FANOUT_EBPF7 I would call them FANOUT_CBPF and FANOUT_EBPF to be

Re: [PATCH net-next]r8169.c: Force transmission when nic refuse to start.

2015-08-14 Thread Francois Romieu
Corcodel Marian corcodel.mar...@gmail.com : [...] diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index eb2d2a4..6882eab 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -7470,15 +7470,22 @@ static int

Re: [PATCH net-next 2/4] packet: add eBPF fanout mode

2015-08-14 Thread Daniel Borkmann
On 08/14/2015 09:27 PM, Willem de Bruijn wrote: ... Btw, in case someone sets sock_flag(sk, SOCK_FILTER_LOCKED), perhaps we should also apply it on fanout? Good point. With classic bpf, packet access control is fully enforced in per-socket filters, but playing with load balancing filters could

Re: [PATCH net-next 2/4] packet: add eBPF fanout mode

2015-08-14 Thread Willem de Bruijn
On Fri, Aug 14, 2015 at 1:03 PM, Alexei Starovoitov a...@plumgrid.com wrote: On 8/14/15 8:50 AM, Willem de Bruijn wrote: +static int fanout_set_data_ebpf(struct packet_fanout *f, char __user *data, + unsigned int len) +{ + struct bpf_prog *new; +

[PATCH net] be2net: avoid vxlan offloading on multichannel configs

2015-08-14 Thread Ivan Vecera
VxLAN offloading is not functional if the NIC is running in multichannel mode (UMC, FLEX-10, VNIC...). Enabling this additionally kills whole connectivity through the NIC and the device needs to be down and up to restore it. The firmware should take care about it and does not allow the conversion

Re: Fw: [Bug 102861] New: soft lockup with inet: fix races with reqsk timers

2015-08-14 Thread Eric Dumazet
On Fri, 2015-08-14 at 08:57 -0700, Stephen Hemminger wrote: Begin forwarded message: Date: Fri, 14 Aug 2015 14:32:56 + From: bugzilla-dae...@bugzilla.kernel.org bugzilla-dae...@bugzilla.kernel.org To: shemmin...@linux-foundation.org shemmin...@linux-foundation.org Subject: [Bug

[PATCH v2 net 2/3] ipv6: Add rt6_make_pcpu_route()

2015-08-14 Thread Martin KaFai Lau
It is a prep work for fixing a potential deadlock when creating a pcpu rt. The current rt6_get_pcpu_route() will also create a pcpu rt if one does not exist. This patch moves the pcpu rt creation logic into another function, rt6_make_pcpu_route(). Signed-off-by: Martin KaFai Lau ka...@fb.com

[PATCH v2 net 0/3] ipv6: Fix a potential deadlock when creating pcpu rt

2015-08-14 Thread Martin KaFai Lau
v1 - v2: A minor change in the commit message of patch 2. This patch series fixes a potential deadlock when creating a pcpu rt. It happens when dst_alloc() decided to run gc. Something like this: read_lock(table-tb6_lock); ip6_rt_pcpu_alloc() = dst_alloc() = ip6_dst_gc() =

Re: [PATCH net-next 2/4] packet: add eBPF fanout mode

2015-08-14 Thread Alexei Starovoitov
On 8/14/15 8:50 AM, Willem de Bruijn wrote: +static int fanout_set_data_ebpf(struct packet_fanout *f, char __user *data, + unsigned int len) +{ + struct bpf_prog *new; + u32 fd; + + if (len != sizeof(fd)) + return -EINVAL; + if

[PATCH v3] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-14 Thread Igor Plyatov
* Due to HW bug, LAN8700 sometimes does not detect presence of energy in the Ethernet cable in Energy Detect Power-Down mode (e.g while EDPWRDOWN bit is set, the ENERGYON bit does not asserted sometimes). This is a common bug of LAN87xx family of PHY chips. * The lan87xx_read_status() was

Re: Several races in usbnet module (kernel 4.1.x)

2015-08-14 Thread Eugene Shatokhin
Hi, 21.07.2015 17:22, Oliver Neukum пишет: On Mon, 2015-07-20 at 21:13 +0300, Eugene Shatokhin wrote: And here, the code clears EVENT_RX_KILL bit in dev-flags, which may execute concurrently with the above operation: #0 clear_bit (bitops.h:113, inlined) #1 usbnet_bh (usbnet.c:1475) /*

Re: [PATCH net-next] lwtunnel: rename ip lwtunnel attributes

2015-08-14 Thread Thomas Graf
On 08/14/15 at 04:40pm, Jiri Benc wrote: We already have IFLA_IPTUN_ netlink attributes. The IP_TUN_ attributes look very similar, yet they serve very different purpose. This is confusing for anyone trying to implement a user space tool supporting lwt. As the IP_TUN_ attributes are used only

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2015-08-14 Thread Florian Fainelli
Le 08/13/15 21:23, shh@gmail.com a écrit : From: Shaohui Xie shaohui@freescale.com Currently, if phy state is PHY_RUNNING, we always register a CHANGE when phy works in polling or interrupt ignored, this will make the adjust_link being called even the phy link did Not changed.

Re: [PATCH v2] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-14 Thread Michael Heimpold
Hi Igor, Am Freitag, 14. August 2015, 11:03:04 schrieb Igor Plyatov: Dear Michael, Hi Igor, Am Donnerstag, 13. August 2015, 22:18:34 schrieben Sie: * Due to HW bug, LAN8700 sometimes does not detect presence of energy in the Ethernet cable in Energy Detect Power-Down mode

Re: [PATCH v2] net: phy: workaround for buggy cable detection by LAN8700 after cable plugging

2015-08-14 Thread Igor Plyatov
Dear Michael, The LAN8700, LAN8710, LAN8720 is a product of the SMSC company. Microchip acquired SMSC in August 2012. The LAN8700 is a legacy product for Microchip and they will not update anything about it. So, even if Microchip know about HW bug, then there is no chance to have Errata sheet

Re: [PATCH net-next 04/11] udp: Handle VRF device in sendmsg

2015-08-14 Thread Tom Herbert
On Thu, Aug 13, 2015 at 1:59 PM, David Ahern d...@cumulusnetworks.com wrote: For unconnected UDP sockets using a VRF device lookup source address based on VRF table. This allows the UDP header to be properly setup before showing up at the VRF device via the dst. Signed-off-by: Shrijeet

[PATCH] usbnet: Fix two races between usbnet_stop() and the BH

2015-08-14 Thread Eugene Shatokhin
Both races may happen when a device (e.g. YOTA 4G LTE Modem) is unplugged while the system is downloading a large file from the Net. Hardware breakpoints and Kprobes with delays were used to confirm that the races do actually happen. 1. The first race is on skb_queue ('next' pointer) between

Re: [PATCH RFC net 0/3] ipv6: Fix potential deadlock when creating pcpu rt

2015-08-14 Thread Martin KaFai Lau
On Thu, Aug 13, 2015 at 05:29:09PM -0700, David Miller wrote: From: Martin KaFai Lau ka...@fb.com Date: Thu, 13 Aug 2015 00:58:00 -0700 This patch series fixes a potential deadlock when creating a pcpu rt. It happens when dst_alloc() decided to run gc. Something like this:

[PATCH v2 net 3/3] ipv6: Fix a potential deadlock when creating pcpu rt

2015-08-14 Thread Martin KaFai Lau
rt6_make_pcpu_route() is called under read_lock(table-tb6_lock). rt6_make_pcpu_route() calls ip6_rt_pcpu_alloc(rt) which then calls dst_alloc(). dst_alloc() _may_ call ip6_dst_gc() which takes the write_lock(tabl-tb6_lock). A visualized version: read_lock(table-tb6_lock); rt6_make_pcpu_route();

[PATCH v2 net 1/3] ipv6: Remove un-used argument from ip6_dst_alloc()

2015-08-14 Thread Martin KaFai Lau
After 4b32b5ad31a6 (ipv6: Stop rt6_info from using inet_peer's metrics), ip6_dst_alloc() does not need the 'table' argument. This patch cleans it up. Signed-off-by: Martin KaFai Lau ka...@fb.com CC: Hannes Frederic Sowa han...@stressinduktion.org --- net/ipv6/route.c | 21 +

Re: Linux 4.2-rc6 regression: RIP: e030:[ffffffff8110fb18] [ffffffff8110fb18] detach_if_pending+0x18/0x80

2015-08-14 Thread Sander Eikelenboom
/0:0] [ 6620.282805] Modules linked in: [ 6620.282805] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.2.0-rc6-20150814-linus-doflr-apicrevert+ #1 [ 6620.282805] task: 8221a580 ti: 8220 task.ti: 8220 [ 6620.282805] RIP: e030:[8100122a] [8100122a

[PATCH] rhashtable-test: extend to test concurrency

2015-08-14 Thread Phil Sutter
After having tested insertion, lookup, table walk and removal, spawn a number of threads running operations on the same rhashtable. Each of them will: 1) insert it's own set of objects, 2) lookup every successfully inserted object and finally 3) remove objects in several rounds until all of them

Re: [PATCH net-next 1/3] lwt: Add support to redirect dst.input

2015-08-14 Thread Tom Herbert
I will send out a v2 short, this breaks compilation when CONFIG_LWTUNNEL is not defined. On Thu, Aug 13, 2015 at 9:54 AM, Tom Herbert t...@herbertland.com wrote: This patch adds the capability to redirect dst input in the same way that dst output is redirected by LWT. Also, save the original

Re: [BUG net-next] infamous dev refcnt leak... again.

2015-08-14 Thread Eric Dumazet
On Fri, 2015-08-14 at 17:19 -0600, David Ahern wrote: On 8/14/15 5:14 PM, Eric Dumazet wrote: On Fri, 2015-08-14 at 14:14 -0700, Eric Dumazet wrote: While rebooting host running latest net-next unregister_netdevice: waiting for eth0 to become free. Usage count = 4 Oh well...

Re: Linux 4.2-rc6 regression: RIP: e030:[ffffffff8110fb18] [ffffffff8110fb18] detach_if_pending+0x18/0x80

2015-08-14 Thread Eric Dumazet
On Sat, 2015-08-15 at 00:09 +0200, Sander Eikelenboom wrote: On 2015-08-13 00:41, Eric Dumazet wrote: On Wed, 2015-08-12 at 23:46 +0200, Sander Eikelenboom wrote: Thanks for the reminder, but luckily i was aware of that, seen enough of your replies asking for patches to be resubmitted

Re: [BUG net-next] infamous dev refcnt leak... again.

2015-08-14 Thread Eric Dumazet
On Fri, 2015-08-14 at 14:14 -0700, Eric Dumazet wrote: While rebooting host running latest net-next unregister_netdevice: waiting for eth0 to become free. Usage count = 4 Oh well... It looks like David Ahern recent changes uncover a bug ? Not clear which commit is at fault. Maybe

RE: [Intel-wired-lan] [PATCH v2] e1000e: Modify tx/rx configurations to avoid null pointer dereferences in e1000_open

2015-08-14 Thread Brown, Aaron F
From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Jia-Ju Bai Sent: Wednesday, August 05, 2015 3:16 AM To: Kirsher, Jeffrey T; Brandeburg, Jesse Cc: netdev@vger.kernel.org; Jia-Ju Bai; intel-wired-...@lists.osuosl.org; linux-ker...@vger.kernel.org Subject:

Re: [B.A.T.M.A.N.] [PATCH 03/10] batman-adv: Make DAT capability changes atomic

2015-08-14 Thread Antonio Quartulli
On 11/08/15 21:36, Sergei Shtylyov wrote: /* check if orig node candidate is running DAT */ -if (!(candidate-capabilities BATADV_ORIG_CAPA_HAS_DAT)) +if (!(test_bit(BATADV_ORIG_CAPA_HAS_DAT, candidate-capabilities))) () around the tst_bit() call not needed. Thanks for

pull request: batman-adv 20150814

2015-08-14 Thread Antonio Quartulli
Hi David, this is our first batch intended for net-next/linux-4.3 (resent after fixing the parenthesis as reported by Sergei). Here you have all those non-critical fixes/changes that we couldn't merge into the net tree as it was already too late in the release cycle. This is a summary of what

[PATCH 04/10] batman-adv: Make NC capability changes atomic

2015-08-14 Thread Antonio Quartulli
From: Linus Lüssing linus.luess...@c0d3.blue Bitwise OR/AND assignments in C aren't guaranteed to be atomic. One OGM handler might undo the set/clear of a specific bit from another handler run in between. Fix this by using the atomic set_bit()/clear_bit()/test_bit() functions. Fixes:

[BUG net-next] infamous dev refcnt leak... again.

2015-08-14 Thread Eric Dumazet
While rebooting host running latest net-next unregister_netdevice: waiting for eth0 to become free. Usage count = 4 Oh well... -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH 10/10] batman-adv: Fix potentially broken skb network header access

2015-08-14 Thread Antonio Quartulli
From: Linus Lüssing linus.luess...@c0d3.blue The two commits noted below added calls to ip_hdr() and ipv6_hdr(). They need a correctly set skb network header. Unfortunately we cannot rely on the device drivers to set it for us. Therefore setting it in the beginning of the according

[PATCH net-next] ipv6: trivial whitespace fix

2015-08-14 Thread Ian Morris
Change brace placement to be in line with coding standards Signed-off-by: Ian Morris i...@chirality.org.uk --- net/ipv6/udp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index e51fc3e..0aba654 100644 --- a/net/ipv6/udp.c +++

Re: [PATCH 1/6] net/bonding: enable LRO if one device supports it

2015-08-14 Thread Jarod Wilson
On 2015-08-14 2:56 AM, Michal Kubecek wrote: On Thu, Aug 13, 2015 at 02:02:55PM -0400, Jarod Wilson wrote: Currently, all bonding devices come up, and claim to have LRO support, which ethtool will let you toggle on and off, even if none of the underlying hardware devices actually support it.

Re: [BUG net-next] infamous dev refcnt leak... again.

2015-08-14 Thread Eric Dumazet
On Fri, 2015-08-14 at 16:31 -0700, Eric Dumazet wrote: I simply reboot my host. eth0 device can not be dismantled and block the reboot, I gave to reset the host. I get the issue every time. I confirm reverting 3bfd847203c6d89532f836ad3f5b4ff4ced26dd9 removes the issue for me. Also,

Re: [PATCH 1/5] net: add Hisilicon Network Subsystem support (config and documents)

2015-08-14 Thread Arnd Bergmann
On Friday 14 August 2015 18:30:18 Kenneth Lee wrote: diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt new file mode 100644 index 000..5ab6969 --- /dev/null +++

[PATCH 01/10] batman-adv: Replace gw_reselect divisor with simple shift

2015-08-14 Thread Antonio Quartulli
From: Sven Eckelmann s...@narfation.org The gw_factor is divided by BATADV_TQ_LOCAL_WINDOW_SIZE ** 2 * 64. But the rest of the calculation has nothing to do with the tq window size and therefore the calculation is just (tmp_gw_factor / (64 ** 3)). Replace it with a simple shift to avoid a costly

[PATCH 02/10] batman-adv: Avoid u32 overflow during gateway select

2015-08-14 Thread Antonio Quartulli
From: Ruben Wisniewski ru...@freifunk-nrw.de The gateway selection based on fast connections is using a single value calculated from the average tq (0-255) and the download bandwidth (in 100Kibit). The formula for the first step (tq ** 2 * 1 * bandwidth) tends to overflow a u32 with low

[PATCH net-next] ipv6: remove unnecessary include

2015-08-14 Thread Ian Morris
printk.h does not need to be explicitly included as we include kernel.h which already called it. Signed-off-by: Ian Morris i...@chirality.org.uk --- net/ipv6/ip6_offload.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c index 08b6204..1cb2dc7

Re: Linux 4.2-rc6 regression: RIP: e030:[ffffffff8110fb18] [ffffffff8110fb18] detach_if_pending+0x18/0x80

2015-08-14 Thread Sander Eikelenboom
that before, because it wasn't in yet .. and likely to fix the issue, also pulled and compiling now. -- Sander NMI watchdog: BUG: soft lockup - CPU#0 stuck for 506s! [swapper/0:0] [ 6620.282805] Modules linked in: [ 6620.282805] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.2.0-rc6-20150814

Re: [PATCH net] be2net: avoid vxlan offloading on multichannel configs

2015-08-14 Thread Ajit Kumar Khaparde
On Aug 14, 2015, at 3:30 PM, Ivan Vecera ivec...@redhat.com wrote: VxLAN offloading is not functional if the NIC is running in multichannel mode (UMC, FLEX-10, VNIC...). Enabling this additionally kills whole connectivity through the NIC and the device needs to be down and up to restore

[PATCH 09/10] batman-adv: remove broadcast packets scheduled for purged outgoing if

2015-08-14 Thread Antonio Quartulli
From: Simon Wunderlich si...@open-mesh.com When an interface is purged, the broadcast packets scheduled for this interface should get purged as well. Signed-off-by: Simon Wunderlich si...@open-mesh.com Signed-off-by: Marek Lindner mareklind...@neomailbox.ch Signed-off-by: Antonio Quartulli

Re: [PATCH 3/5] net: add Hisilicon Network Subsystem MDIO support

2015-08-14 Thread Arnd Bergmann
On Friday 14 August 2015 18:30:20 Kenneth Lee wrote: +#define MDIO_BASE_ADDR 0x403C Does not belong in here (and is not used) +#define MDIO_COMMAND_REG 0x0 +#define MDIO_ADDR_REG 0x4 +#define MDIO_WDATA_REG 0x8 +#define

[PATCH 05/10] batman-adv: Make TT capability changes atomic

2015-08-14 Thread Antonio Quartulli
From: Linus Lüssing linus.luess...@c0d3.blue Bitwise OR/AND assignments in C aren't guaranteed to be atomic. One OGM handler might undo the set/clear of a specific bit from another handler run in between. Fix this by using the atomic set_bit()/clear_bit()/test_bit() functions. Fixes:

[PATCH 07/10] batman-adv: Fix potential synchronization issues in mcast tvlv handler

2015-08-14 Thread Antonio Quartulli
From: Linus Lüssing linus.luess...@c0d3.blue So far the mcast tvlv handler did not anticipate the processing of multiple incoming OGMs from the same originator at the same time. This can lead to various issues: * Broken refcounting: For instance two mcast handlers might both assume that an

[PATCH 08/10] batman-adv: protect tt request from double deletion

2015-08-14 Thread Antonio Quartulli
From: Marek Lindner mareklind...@neomailbox.ch The list_del() calls were changed to list_del_init() to prevent an accidental double deletion in batadv_tt_req_node_new(). Signed-off-by: Marek Lindner mareklind...@neomailbox.ch Signed-off-by: Antonio Quartulli anto...@meshcoding.com ---

[PATCH 06/10] batman-adv: Make MCAST capability changes atomic

2015-08-14 Thread Antonio Quartulli
From: Linus Lüssing linus.luess...@c0d3.blue Bitwise OR/AND assignments in C aren't guaranteed to be atomic. One OGM handler might undo the set/clear of a specific bit from another handler run in between. Fix this by using the atomic set_bit()/clear_bit()/test_bit() functions. Fixes:

[PATCH 03/10] batman-adv: Make DAT capability changes atomic

2015-08-14 Thread Antonio Quartulli
From: Linus Lüssing linus.luess...@c0d3.blue Bitwise OR/AND assignments in C aren't guaranteed to be atomic. One OGM handler might undo the set/clear of a specific bit from another handler run in between. Fix this by using the atomic set_bit()/clear_bit()/test_bit() functions. Fixes:

Global protection fault in netfilter code

2015-08-14 Thread Trond Myklebust
Hi, When doing NFS stress tests in a VM with a recent kernel (yesterday's commit 7ddab73346a1 Merge branch 'fixes' of git ://ftp.arm.linux.org.uk/~rmk/linux-arm), I've been seeing the following General Protection Fault code apparently in the nf_conntrack code: PID: 358TASK: 88003630cb80

Re: [BUG net-next] infamous dev refcnt leak... again.

2015-08-14 Thread David Ahern
On 8/14/15 5:14 PM, Eric Dumazet wrote: On Fri, 2015-08-14 at 14:14 -0700, Eric Dumazet wrote: While rebooting host running latest net-next unregister_netdevice: waiting for eth0 to become free. Usage count = 4 Oh well... It looks like David Ahern recent changes uncover a bug ? Not

[PATCH net-next v2 1/4] packet: add classic BPF fanout mode

2015-08-14 Thread Willem de Bruijn
From: Willem de Bruijn will...@google.com Add fanout mode PACKET_FANOUT_CBPF that accepts a classic BPF program to select a socket. This avoids having to keep adding special case fanout modes. One example use case is application layer load balancing. The QUIC protocol, for instance, encodes a

[PATCH net-next v2 2/4] packet: add extended BPF fanout mode

2015-08-14 Thread Willem de Bruijn
From: Willem de Bruijn will...@google.com Add fanout mode PACKET_FANOUT_EBPF that accepts an en extended BPF program to select a socket. Update the internal eBPF program by passing to socket option SOL_PACKET/PACKET_FANOUT_DATA a file descriptor returned by bpf(). Signed-off-by: Willem de

[PATCH net-next v2 3/4] selftests/net: test classic bpf fanout mode

2015-08-14 Thread Willem de Bruijn
From: Willem de Bruijn will...@google.com Test PACKET_FANOUT_CBPF by inserting a cBPF program that selects a socket by payload. Requires modifying the test program to send packets with multiple payloads. Also fix a bug in testing the return value of mmap() Signed-off-by: Willem de Bruijn

[PATCH net-next v2 4/4] selftests/net: test extended BPF fanout mode

2015-08-14 Thread Willem de Bruijn
From: Willem de Bruijn will...@google.com Test PACKET_FANOUT_EBPF by inserting a program into the the kernel with bpf(), then attaching it to the fanout group. Observe the same payload-based distribution as in the PACKET_FANOUT_CBPF test. Signed-off-by: Willem de Bruijn will...@google.com ---

[PATCH net-next v2 0/4] packet: add cBPF and eBPF fanout modes

2015-08-14 Thread Willem de Bruijn
From: Willem de Bruijn will...@google.com Allow programmable fanout modes. Support both classical BPF programs passed directly and extended BPF programs passed by file descriptor. One use case is packet steering by deep packet inspection, for instance for packet steering by application layer

Re: [PATCH net-next 04/11] udp: Handle VRF device in sendmsg

2015-08-14 Thread David Ahern
On 8/14/15 9:16 PM, Tom Herbert wrote: At least collect this code into one (static inline) function to better minimize the code churn in udp. If this is general functionality that can be used by other drivers then abstract it out as such. Also, if the VRF driver is not configured it seems like

Re: [PATCH net-next 2/4] packet: add eBPF fanout mode

2015-08-14 Thread Willem de Bruijn
On Fri, Aug 14, 2015 at 3:46 PM, Daniel Borkmann dan...@iogearbox.net wrote: On 08/14/2015 09:27 PM, Willem de Bruijn wrote: ... Btw, in case someone sets sock_flag(sk, SOCK_FILTER_LOCKED), perhaps we should also apply it on fanout? Good point. With classic bpf, packet access control is

Re: [PATCHv1 net-next 0/5] netlink: mmap: kernel panic and some issues

2015-08-14 Thread Ken-ichirou MATSUZAWA
Hi, Thank you for taking your time and trying to understand, even though one of samples is wrong. correct one is: rx only mmaped nflog sample: https://gist.github.com/chamaken/dc0f80c14862e8061c06/raw/365c8a106840368f313a3791958da9be0f5fbed0/rxring-nflog.c Currently, what happens is

Re: [PATCH net-next 04/11] udp: Handle VRF device in sendmsg

2015-08-14 Thread Tom Herbert
On Fri, Aug 14, 2015 at 10:58 AM, Shrijeet Mukherjee s...@cumulusnetworks.com wrote: On Fri, Aug 14, 2015 at 9:27 AM, Tom Herbert t...@herbertland.com wrote: On Thu, Aug 13, 2015 at 1:59 PM, David Ahern d...@cumulusnetworks.com wrote: For unconnected UDP sockets using a VRF device lookup

RE: [PATCH net] igb: Fix oops caused by missing queue pairing

2015-08-14 Thread Brown, Aaron F
From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Shota Suzuki Sent: Tuesday, June 30, 2015 5:26 PM To: Kirsher, Jeffrey T; Brandeburg, Jesse; Nelson, Shannon; Wyborny, Carolyn; Skidmore, Donald C; Vick, Matthew; Ronciak, John; Williams, Mitch A;

  1   2   >