[net-next 13/18] fm10k: TRIVIAL fix up ordering of __always_unused and style

From: Jacob Keller Fix some style issues in debugfs code, and correct ordering of void and __always_unused. Technically, the order does not matter, but preferred style is to put the macro between the type and name. Signed-off-by: Jacob Keller

[net-next 14/18] fm10k: send traffic on default VID to VLAN device if we have one

From: Jacob Keller This patch ensures that VLAN traffic on the default VID will go to the corresponding VLAN device if it exists. To do this, mask the rx_ring VID if we have an active VLAN on that VID. For this to work correctly, we need to update

[net-next 18/18] fm10k: fix iov_msg_mac_vlan_pf VID checks

From: Jacob Keller The VF will send a message to request multicast addresses with the default VID. In the current code, if the PF has statically assigned a VLAN to a VF, then the VF will not get the multicast addresses. Fix up all of the various VLAN messages to use

[net-next 00/18][pull request] Intel Wired LAN Driver Updates 2015-09-15

This series contains updates to ixgbe and fm10k. Don fixes a ixgbe issue by adding checks for systems that do not have SFP's to avoid incorrectly acting on interrupts that are falsely interpreted as SFP events. Alex Williamson adds a fix for ixgbe to disable SR-IOV prior to unregistering the

[net-next 15/18] fm10k: TRIVIAL fix typo in fm10k_netdev.c

From: Jacob Keller Signed-off-by: Jacob Keller Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH next 04/30] xfrm: Remove unused afinfo method init_dst

Signed-off-by: "Eric W. Biederman" --- include/net/xfrm.h | 2 -- net/xfrm/xfrm_policy.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/include/net/xfrm.h b/include/net/xfrm.h index 312e3fee9ccf..fd176106909a 100644 --- a/include/net/xfrm.h +++

[PATCH next 01/30] netfilter: Remove !CONFIG_NETFITLER definition of nf_hook_thresh

The !CONFIG_NETFILTER definition of nf_hook_thresh calls okfn when the CONFIG_NETFITLER defintion does not, making it buggy. As the !CONFIG_NETFILTER defintion of nf_hook_thresh is not used remove it rather than fix it. Signed-off-by: "Eric W. Biederman" ---

[PATCH net] net/mlx4_en:

From: Eric Dumazet When changing rss key, we do not want to overwrite user provided key by the one provided by netdev_rss_key_fill(), which is the host random key generated at boot time. Fixes: 947cbb0ac242 ("net/mlx4_en: Support for configurable RSS hash function")

Re: [PATCH net-next 2/2] bpf: add bpf_redirect() helper

On 15-09-15 06:51 PM, Alexei Starovoitov wrote: > Existing bpf_clone_redirect() helper clones skb before redirecting > it to RX or TX of destination netdev. > Introduce bpf_redirect() helper that does that without cloning. > > Benchmarked with two hosts using 10G ixgbe NICs. > One host is doing

Re: [PATCH net-next 2/2] bpf: add bpf_redirect() helper

On 9/15/15 8:10 PM, John Fastabend wrote: Nice, I like this. But just to be sure I read this correctly this will only work on the ingress qdisc for now right? To get the tx side working will require a bit more care. correct. For egress I'm waiting for Daniel to resubmit his preclassifier patch

Re: [PATCH v3 net-next 1/2] ipv4: L3 hash-based multipath

On Tue, 15 Sep 2015 14:40:48 -0700 Alexander Duyck wrote: > On 09/15/2015 01:29 PM, Peter Nørlund wrote: > > Replaces the per-packet multipath with a hash-based multipath using > > source and destination address. > > > > Signed-off-by: Peter Nørlund

Re: [PATCH net-next 2/2] bonding: use l4 hash if available

On Tue, Sep 15, 2015 at 3:24 PM, Eric Dumazet wrote: > > From: Eric Dumazet > > If skb carries a l4 hash, no need to perform a flow dissection. > > Performance is slightly better : > > lpaa5:~# ./super_netperf 200 -H lpaa6 -t TCP_RR -l 100 >

Re: [PATCH net v2] openvswitch: Fix mask generation for nested attributes.

From: Jesse Gross Date: Fri, 11 Sep 2015 18:38:28 -0700 > Masks were added to OVS flows in a way that was backwards compatible > with userspace programs that did not generate masks. As a result, it is > possible that we may receive flows that do not have a mask and we need > to

Re: [PATCH 25/39] net: core: drop null test before destroy functions

From: Julia Lawall Date: Sun, 13 Sep 2015 14:15:18 +0200 > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) { >

Re: [PATCH 34/39] dccp: drop null test before destroy functions

From: Julia Lawall Date: Sun, 13 Sep 2015 14:15:27 +0200 > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression x; > @@ > > -if (x != NULL) >

Re: [PATCH 10/39] atm: he: drop null test before destroy functions

From: Julia Lawall Date: Sun, 13 Sep 2015 14:15:03 +0200 > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) >

Re: [PATCH net-next 2/2] bonding: use l4 hash if available

On Tue, 2015-09-15 at 16:45 -0700, Tom Herbert wrote: > > + if (bond->params.xmit_policy == BOND_XMIT_POLICY_ENCAP34 && > > + skb->l4_hash) > > + return skb->hash; > > + > > if (bond->params.xmit_policy == BOND_XMIT_POLICY_LAYER2 || > >

Re: [PATCH net-next 2/2] bonding: use l4 hash if available

On Tue, Sep 15, 2015 at 4:20 PM, Eric Dumazet wrote: > On Tue, 2015-09-15 at 15:54 -0700, Mahesh Bandewar wrote: > >> > + if (bond->params.xmit_policy == BOND_XMIT_POLICY_ENCAP34 && >> > + skb->l4_hash) >> if (ENCAP34 || LAYER34) && l4_hash) may be? > >

[net-next 08/18] fm10k: Don't assume page fragments are page size

From: Alexander Duyck This change pulls out the optimization that assumed that all fragments would be limited to page size. That hasn't been the case for some time now and to assume this is incorrect as the TCP allocator can provide up to a 32K page fragment.

[net-next 10/18] fm10k: allow creation of VLAN interfaces even while down

From: Jacob Keller We re-sync upon going up, so there is little reason to worry about not syncing immediately with switch. This prevents an error that occurs if you add a VLAN interface while down. Signed-off-by: Jacob Keller Tested-by:

[net-next 16/18] fm10k: re-enable VF after a full reset on detection of a Malicious event

From: Jacob Keller Modify behavior of Malicious Driver Detection events. Presently, the hardware disables the VF queues and re-assigns them to the PF. This causes the VF in question to continuously Tx hang, because it assumes that it can transmit over the queues in

[net-next 06/18] fm10k: update fm10k_slot_warn to use pcie_get_minimum link

From: Jacob Keller This is useful in cases where we connect to a slot at Gen3, but the slot is behind a bus which only connected at Gen2. This generally only happens when a PCIe switch is in the sequence of devices, and can be very confusing when you see slow

[net-next 07/18] fm10k: update netdev perm_addr during reinit, instead of at up

From: Jacob Keller Update the netdev permanent address during fm10k_reinit enables the user to immediately see the new MAC address on the VF even if the device isn't up. The previous code required that the device by opened before changes would appear. Signed-off-by:

[net-next 03/18] ixgbe: Limit lowest interrupt rate for adaptive interrupt moderation to 12K

From: Alexander Duyck This patch updates the lowest limit for adaptive interrupt interrupt moderation to roughly 12K interrupts per second. The way I came about reaching 12K as the desired interrupt rate is by testing with UDP flows. Specifically I had a simple

[net-next 11/18] fm10k: don't store sw_vid at reset

From: Jacob Keller If we store the sw_vid at reset of PF, then we accidentally prevent the VF from receiving the message to update its default VID. This only occurs if the VF is created before the PF has come up, which is the standard way of creating VFs when using the

[net-next 12/18] fm10k: remove is_slot_appropriate

From: Jacob Keller This function is no longer used now that we have updated fm10k_slot_warn functionality. Signed-off-by: Jacob Keller Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher

[net-next 02/18] ixgbe: Teardown SR-IOV before unregister_netdev()

From: Alex Williamson When the .remove() callback for a PF is called, SR-IOV support for the device is disabled, which requires unbinding and removing the VFs. The VFs may be in-use either by the host kernel or userspace, such as assigned to a VM through vfio-pci. In

[net-next 17/18] fm10k: Only trigger data path reset if fabric is up

From: Alexander Duyck This change makes it so that we only trigger the data path reset if the fabric is ready to handle traffic. The general idea is to avoid triggering the reset unless the switch API is ready for us. Otherwise we can just postpone the reset until

[net-next 01/18] ixgbe: fix issue with SFP events with new X550 devices

From: Don Skidmore Add checks for systems that don't have SFP's to avoid incorrectly acting on interrupts that are falsely interpreted as SFP events. This also includes a modified check generating the EICR mask to be more forward-looking. Signed-off-by: Don Skidmore

Re: linux-next: build failure after merge of the tip tree

From: Stephen Rothwell Date: Wed, 16 Sep 2015 11:30:53 +1000 > I have added the following fix patch for today: > > From: Stephen Rothwell > Date: Wed, 16 Sep 2015 11:10:16 +1000 > Subject: [PATCH] cdc: add header guards > > Signed-off-by: Stephen

Re: [PATCH net-next 2/2] bonding: use l4 hash if available

On Tue, Sep 15, 2015 at 5:03 PM, Eric Dumazet wrote: > On Tue, 2015-09-15 at 16:45 -0700, Tom Herbert wrote: >> > + if (bond->params.xmit_policy == BOND_XMIT_POLICY_ENCAP34 && >> > + skb->l4_hash) >> > + return skb->hash; >> > + >> >

Re: [PATCHv2 net] cxgb4vf: support for single-threading access to adapter mailbox registers

On Mon, Sep 14, 2015 at 19:08:34 +0530, Hariprasad Shenai wrote: > The issue is the for the Virtual Function Driver, the only way to get the > Virtual Interface statistics is to issue mailbox commands to ask the > firmware for the VI Stats. And, because the VI Stats command can only > retrieve a

Re: [PATCH net-next 2/2] bpf: add bpf_redirect() helper

On 15-09-15 09:11 PM, Alexei Starovoitov wrote: > On 9/15/15 8:10 PM, John Fastabend wrote: >> Nice, I like this. But just to be sure I read this correctly this will >> only work on the ingress qdisc for now right? To get the tx side working >> will require a bit more care. > > correct. > For

FW: [RFC net-next 01/10] qed: Add module with basic common support

> From: Yuval Mintz > Date: Thu, 10 Sep 2015 16:54:12 +0300 > > Documentation/networking/LICENSE.qlogic| 288 ++ > I do not want to get into the habit of having to add copy after copy > of the GPL v2 to the source tree, so this is rather inappropriate. >

Re: [PATCH net-next 2/2] bpf: add bpf_redirect() helper

On 9/15/15 9:50 PM, John Fastabend wrote: Looks like you can remove the check. I would prefer to let the stack handle this case using normal mechanisms. I had to do a bit of tracking but netif_running check equates roughly to your IFF_UP case via, ... Seem reasonable? Or did you put it there

Re: [PATCH v3 net-next] rtnetlink: RTEXT_FILTER_SKIP_STATS support to avoid dumping inet/inet6 stats

From: Sowmini Varadhan Date: Fri, 11 Sep 2015 16:48:48 -0400 > > Many commonly used functions like getifaddrs() invoke RTM_GETLINK > to dump the interface information, and do not need the > the AF_INET6 statististics that are always returned by default > from

Re: [PATCH net-next 2/2] bonding: use l4 hash if available

On Tue, Sep 15, 2015 at 3:24 PM, Eric Dumazet wrote: > From: Eric Dumazet > > If skb carries a l4 hash, no need to perform a flow dissection. > > Performance is slightly better : > > lpaa5:~# ./super_netperf 200 -H lpaa6 -t TCP_RR -l 100 > 2.39012e+06

[net-next 05/18] fm10k: only prevent removal of default VID rules

From: Jacob Keller This allows us to correctly add a VLAN even if it matches our default VID. However, we don't want to remove the VID rules once that VLAN is deleted. Correctly remove the stack layers information of the VLAN, but then return to forwarding that VID as

[net-next 09/18] fm10k: Report MAC address on driver load

From: Alexander Duyck This change adds the MAC address to the list of values recorded on driver load. The MAC address represents the serial number of the unit and allows us to track the value should a card be replaced in a system. The log message should now be

[net-next 04/18] fm10k: disable service task during suspend

From: Jacob Keller The service task reads some registers as part of its normal routine, even while the interface is down. Normally this is ok. However, during suspend we have disabled the PCI device. Due to this, registers will read in the same way as a surprise-remove

[PATCH next 08/30] ipv4: Compute net once in ip_rcv

Signed-off-by: "Eric W. Biederman" --- net/ipv4/ip_input.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c index f4fc8a77aaa7..ff908863f22e 100644 --- a/net/ipv4/ip_input.c +++

[PATCH next 03/30] netfilter: Pass net to nf_hook_thresh

Signed-off-by: "Eric W. Biederman" --- include/linux/netfilter.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/include/linux/netfilter.h b/include/linux/netfilter.h index 889ac0e11f01..042148dc1e22 100644 --- a/include/linux/netfilter.h

[PATCH next 02/30] netfilter: Store net in nf_hook_state

Signed-off-by: "Eric W. Biederman" --- include/linux/netfilter.h | 5 - include/linux/netfilter_ingress.h | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/linux/netfilter.h b/include/linux/netfilter.h index

[PATCH next 05/30] net: Merge dst_output and dst_output_sk

Add a sock paramter to dst_output making dst_output_sk superfluous. Add a skb->sk parameter to all of the callers of dst_output Have the callers of dst_output_sk call dst_output. Signed-off-by: "Eric W. Biederman" --- include/net/dst.h | 6 +-

[PATCH next 12/30] ipv4: Explicitly compute net in ip_fragment

Signed-off-by: "Eric W. Biederman" --- net/ipv4/ip_output.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index 85b72d450184..095754c99061 100644 --- a/net/ipv4/ip_output.c +++ b/net/ipv4/ip_output.c @@

[PATCH next 29/30] netfilter: Use nf_hook_state.net

Instead of saying "net = dev_net(state->in?state->in:state->out)" just say "state->net". As that information is now availabe, much less confusing and much less error prone. Signed-off-by: "Eric W. Biederman" --- net/bridge/netfilter/ebtable_filter.c | 4 ++--

[PATCH next 14/30] ipv4: Only compute net once in ip_rcv_finish

Signed-off-by: "Eric W. Biederman" --- net/ipv4/ip_input.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c index ff908863f22e..cc242b9501d9 100644 --- a/net/ipv4/ip_input.c +++ b/net/ipv4/ip_input.c

[PATCH next 15/30] ipv4: Only compute net once in ipmr_forward_finish

Signed-off-by: "Eric W. Biederman" --- net/ipv4/ipmr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index 075bc695ae34..dfe4e8ec6c3a 100644 --- a/net/ipv4/ipmr.c +++ b/net/ipv4/ipmr.c @@ -1681,9 +1681,10 @@

[PATCH next 17/30] arp: Introduce arp_xmit_finish

The function dev_queue_xmit_skb_sk is unncessary and very confusing. Introduce arp_xmit_finish to remove the need for dev_queue_xmit_skb_sk, and have arp_xmit_finish call dev_queue_xmit. Signed-off-by: "Eric W. Biederman" --- net/ipv4/arp.c | 7 ++- 1 file changed, 6

[PATCH next 09/30] ipv4: Remember the net in ip_output and ip_mc_output

This is a prepatory patch to passing net int the netfilter hooks, where net will be used again. Signed-off-by: "Eric W. Biederman" --- net/ipv4/ip_output.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_output.c

[PATCH next 07/30] ipv4: Compute net once in ip_forward_finish

Signed-off-by: "Eric W. Biederman" --- net/ipv4/ip_forward.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_forward.c b/net/ipv4/ip_forward.c index ba2f66b3b3f6..95235c813f18 100644 --- a/net/ipv4/ip_forward.c +++

[PATCH next 06/30] ipv4: Compute net once in ip_forward

Compute struct net from the input device in ip_forward before it is used. Signed-off-by: "Eric W. Biederman" --- net/ipv4/ip_forward.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_forward.c b/net/ipv4/ip_forward.c index

[PATCH next 10/30] ipv4: Don't recompute net in ipmr_queue_xmit

Calling dev_net(dev) for is just silly. Signed-off-by: "Eric W. Biederman" --- net/ipv4/ipmr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index a0a5def920fc..075bc695ae34 100644 --- a/net/ipv4/ipmr.c +++

Re: [net-next PATCH] net: bridge: fix for bridging 802.1Q without REORDER_HDR

On 09/15/2015 02:17 PM, Phil Sutter wrote: > On Tue, Sep 15, 2015 at 11:11:53AM -0400, Vlad Yasevich wrote: >> On 09/14/2015 04:06 PM, Phil Sutter wrote: >>> On Mon, Sep 14, 2015 at 02:21:10PM -0400, Vlad Yasevich wrote: On 09/11/2015 04:20 PM, Phil Sutter wrote: > On Fri, Sep 11, 2015 at

Re: [PATCH] net: smc91x: convert pxa dma to dmaengine

From: Robert Jarzmik Date: Thu, 10 Sep 2015 21:26:04 +0200 > Convert the dma transfers to be dmaengine based, now pxa has a dmaengine > slave driver. This makes this driver a bit more PXA agnostic. > > The driver was tested on pxa27x (mainstone) and pxa310 (zylonite), >

Re: [PATCH net] net/mlx4_en:

Arg, patch title was meant to be net/mlx4_en: really allow to change RSS key -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH net-next 2/2] bonding: use l4 hash if available

From: Eric Dumazet If skb carries a l4 hash, no need to perform a flow dissection. Performance is slightly better : lpaa5:~# ./super_netperf 200 -H lpaa6 -t TCP_RR -l 100 2.39012e+06 lpaa5:~# ./super_netperf 200 -H lpaa6 -t TCP_RR -l 100 2.39393e+06 lpaa5:~#

[PATCH net-next 1/2] tcp: provide skb->hash to synack packets

From: Eric Dumazet In commit b73c3d0e4f0e ("net: Save TX flow hash in sock and set in skbuf on xmit"), Tom provided a l4 hash to most outgoing TCP packets. We'd like to provide one as well for SYNACK packets, so that all packets of a given flow share same txhash, to later

Re: [PATCH net-next 2/2] bonding: use l4 hash if available

On Tue, 2015-09-15 at 15:54 -0700, Mahesh Bandewar wrote: > > + if (bond->params.xmit_policy == BOND_XMIT_POLICY_ENCAP34 && > > + skb->l4_hash) > if (ENCAP34 || LAYER34) && l4_hash) may be? Hmm, traditional BOND_XMIT_POLICY_LAYER34 did not a full flow bisection (tunnel awareness

[PATCH next 18/30] bridge: Introduce br_send_bpdu_finish

The function dev_queue_xmit_skb_sk is unncessary and very confusing. Introduce br_send_bpdu_finish to remove the need for dev_queue_xmit_skb_sk, and have br_send_bpdu_finish call dev_queue_xmit. Signed-off-by: "Eric W. Biederman" --- net/bridge/br_stp_bpdu.c | 7 ++-

[PATCH next 21/30] ipv6: Only compute net once in ip6_finish_output2

Signed-off-by: "Eric W. Biederman" --- net/ipv6/ip6_output.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index a80502c64523..12d0166a64cd 100644 --- a/net/ipv6/ip6_output.c +++

[PATCH net-next 1/2] cls_bpf: introduce integrated actions

From: Daniel Borkmann Often cls_bpf classifier is used with single action drop attached. Optimize this use case and let cls_bpf return both classid and action. For backwards compatibility reasons enable this feature under TCA_BPF_FLAG_ACT_DIRECT flag. Then more interesting

[PATCH net-next 2/2] bpf: add bpf_redirect() helper

Existing bpf_clone_redirect() helper clones skb before redirecting it to RX or TX of destination netdev. Introduce bpf_redirect() helper that does that without cloning. Benchmarked with two hosts using 10G ixgbe NICs. One host is doing line rate pktgen. Another host is configured as: $ tc qdisc

[PATCH net-next 0/2] bpf: performance improvements

At plumbers we discussed different options on how to get rid of skb_clone from bpf_clone_redirect(), the patch 2 implements the best option. Patch 1 adds 'integrated exts' to cls_bpf to improve performance by combining simple actions into bpf classifier. Alexei Starovoitov (1): bpf: add

Re: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

From: Robert Jarzmik Date: Sat, 12 Sep 2015 13:45:22 +0200 > Instead of using directly the OS timer through direct register access, > use the standard sched_clock(), which will end up in OSCR reading > anyway. > > This is a first step for direct access register removal

linux-next: build failure after merge of the tip tree

Hi all, After merging the next-20150915 version of the tip tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from drivers/usb/gadget/function/u_ether.h:20:0, from drivers/usb/gadget/function/f_ncm.c:26: include/linux/usb/cdc.h:23:8: error

[PATCH v2 net] net/mlx4_en: really allow to change RSS key

From: Eric Dumazet When changing rss key, we do not want to overwrite user provided key by the one provided by netdev_rss_key_fill(), which is the host random key generated at boot time. Fixes: 947cbb0ac242 ("net/mlx4_en: Support for configurable RSS hash function")

Re: IPv6 routing/fragmentation panic

David Woodhouse wrote: > I can repeatably crash my router with 'ping6 -s 2000' to an external > machine: > [ 61.741618] skbuff: skb_under_panic: text:c1277f1e len:1294 put:14 > head:dec98000 data:dec97ffc tail:0xdec9850a end:0xdec98f40 dev:br-lan > [ 61.754128]

Re: [PATCH net-next 1/2] tcp: provide skb->hash to synack packets

On Tue, Sep 15, 2015 at 3:24 PM, Eric Dumazet wrote: > From: Eric Dumazet > > In commit b73c3d0e4f0e ("net: Save TX flow hash in sock and set in skbuf > on xmit"), Tom provided a l4 hash to most outgoing TCP packets. > > We'd like to provide one as

Re: [PATCH net-next 2/2] bonding: use l4 hash if available

On Tue, Sep 15, 2015 at 5:03 PM, Eric Dumazet wrote: > On Tue, 2015-09-15 at 16:45 -0700, Tom Herbert wrote: >> > + if (bond->params.xmit_policy == BOND_XMIT_POLICY_ENCAP34 && >> > + skb->l4_hash) >> > + return skb->hash; >> > + >> >

[PATCH next 0/30] Passing net through the netfilter hooks

My primary goal with this patchset and it's follow ups is to cleanup the network routing paths so that we do not look at the output device to derive the network namespace. My plan is to pass the network namespace of the transmitting socket through the output path, to replace code that looks at

[PATCH next 11/30] ipv4: Only compute net once in ip_do_fragment

Signed-off-by: "Eric W. Biederman" --- net/ipv4/ip_output.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index 9ee622ad8dfa..85b72d450184 100644 --- a/net/ipv4/ip_output.c +++

[PATCH next 28/30] netfilter: Pass struct net into the netfilter hooks

Pass a network namespace parameter into the netfilter hooks. At the call site of the netfilter hooks the path a packet is taking through the network stack is well known which allows the network namespace to be easily and reliabily. This allows the replacement of magic code like

[PATCH next 30/30] netfilter: Pass net into okfn

This is immediately motivated by the bridge code that chains functions that call into netfilter. Without passing net into the okfns the bridge code would need to guess about the best expression for the network namespace to process packets in. As net is frequently one of the first things computed

[PATCH next 25/30] bridge: Pass net into br_nf_push_frag_xmit

When struct net starts being passed through the ipv4 and ipv6 fragment routines br_nf_push_frag_xmit will need to take a net parameter. Prepare br_nf_push_frag_xmit before that is needed and introduce br_nf_push_frag_xmit_sk for the call sites that still need the old calling conventions.

Re: [PATCH net-next 2/2] bonding: use l4 hash if available

On Tue, 2015-09-15 at 17:04 -0700, Mahesh Bandewar wrote: > On Tue, Sep 15, 2015 at 4:20 PM, Eric Dumazet wrote: > > On Tue, 2015-09-15 at 15:54 -0700, Mahesh Bandewar wrote: > > > >> > + if (bond->params.xmit_policy == BOND_XMIT_POLICY_ENCAP34 && > >> > +

[PATCH next 19/30] net: Remove dev_queue_xmit_sk

A function with weird arguments that it will never use to accomdate a netfilter callback prototype is absolutely in the core of the networking stack. Frankly it does not make sense and it causes a lot of confusion as to why arguments that are never used are being passed to the function. As I am

[PATCH next 23/30] ipv6: Compute net once in raw6_send_hdrinc

Signed-off-by: "Eric W. Biederman" --- net/ipv6/raw.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c index 1636537705f5..5aa461302716 100644 --- a/net/ipv6/raw.c +++ b/net/ipv6/raw.c @@ -614,6 +614,7 @@ static int

[PATCH next 26/30] bridge: Cache net in br_nf_pre_routing_finish

This is prep work for passing net to the netfilter hooks. Signed-off-by: "Eric W. Biederman" --- net/bridge/br_netfilter_hooks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/bridge/br_netfilter_hooks.c b/net/bridge/br_netfilter_hooks.c index

[PATCH next 24/30] bridge: Pass net into br_nf_ip_fragment

This is a prep work for passing struct net through ip_do_fragment and later the netfilter okfn. Doing this independently makes the later code changes clearer. Signed-off-by: "Eric W. Biederman" --- net/bridge/br_netfilter_hooks.c | 12 ++-- 1 file changed, 6

[PATCH next 20/30] ipv6: Don't recompute net in ip6_rcv

Avoid silly redundant code Signed-off-by: "Eric W. Biederman" --- net/ipv6/ip6_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c index adba03ac7ce9..c628dba477d4 100644 --- a/net/ipv6/ip6_input.c +++

[PATCH next 13/30] ipv4: Only compute net once in ip_finish_output2

Signed-off-by: "Eric W. Biederman" --- net/ipv4/ip_output.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index 095754c99061..fc550e97daac 100644 --- a/net/ipv4/ip_output.c +++ b/net/ipv4/ip_output.c @@

[PATCH next 22/30] ipv6: Cache net in ip6_output

Keep net in a local variable so I can use it in NF_HOOK_COND when I pass struct net to all of the netfilter hooks. Signed-off-by: "Eric W. Biederman" --- net/ipv6/ip6_output.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/ip6_output.c

[PATCH next 27/30] bridge: Add br_netif_receive_skb remove netif_receive_skb_sk

netif_receive_skb_sk is only called once in the bridge code, replace it with a bridge specific function that calls netif_receive_skb. Signed-off-by: "Eric W. Biederman" --- include/linux/netdevice.h | 6 +- net/bridge/br_input.c | 7 ++- net/core/dev.c

[PATCH next 16/30] ipv6: Only compute net once in ip6mr_forward2_finish

Signed-off-by: "Eric W. Biederman" --- net/ipv6/ip6mr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c index e95f6b6281de..3e3085b37a91 100644 --- a/net/ipv6/ip6mr.c +++ b/net/ipv6/ip6mr.c @@ -1987,9 +1987,10 @@

Re: [PATCH net-next 2/2] bonding: use l4 hash if available

On Tue, 2015-09-15 at 17:15 -0700, Tom Herbert wrote: > A more fundamental question is whether we can eliminate some of these > hashing types (I see five of them in if_bonding.h). Is there any > substantial difference between this and IPv4/v6 ECMP routing such that > they shouldn't all have the

[net-next:master 10/14] ERROR: "cdc_parse_cdc_header" [drivers/net/usb/cdc-phonet.ko] undefined!

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: d5566fd72ec1924958fcfd48b65c022c8f7eae64 commit: 7b6ee48d3f4d432bfa6c9c9662fbdbd97681240e [10/14] cdc-phonet: use common parser config: x86_64-randconfig-a0-09160932 (attached as .config) reproduce: git

Re: [PATCH for-next] cxgb4: add device ID for few T5 adapters

On Tue, Sep 15, 2015 at 11:55:19 -0700, David Miller wrote: > From: Hariprasad Shenai > Date: Tue, 15 Sep 2015 17:20:09 +0530 > > > Signed-off-by: Hariprasad Shenai > > Adding just some new device IDs is definitely 'net' material, mind > if I

[PATCH net v2] rtnetlink: catch -EOPNOTSUPP errors from ndo_bridge_getlink

From: Roopa Prabhu problem reported: kernel 4.1.3 # bridge vlan portvlan ids eth0 1 PVID Egress Untagged 90 91 92 93 94

Re: [PATCH 3/5] lan78xx: update to use phylib

From: Date: Thu, 10 Sep 2015 22:16:11 + > @@ -1287,42 +1074,30 @@ static int lan78xx_set_wol(struct net_device *netdev, > static int lan78xx_get_eee(struct net_device *net, struct ethtool_eee *edata) > { > struct lan78xx_net *dev = netdev_priv(net); > +

Re: [PATCH V4 1/2] pci: Add dev_flags bit to access VPD through function 0

> On Sep 15, 2015, at 2:17 PM, Alex Williamson > wrote: > > Also, rather than clearing the flag, can we move the tests done by > pci_vpd_f0_dev_check() into the > quirk setup function? It seems like function 0 should be sufficiently > configured by the time we're

Re: [PATCH] net: mvneta: fix DMA buffer unmapping in mvneta_rx()

From: Simon Guinot Date: Tue, 15 Sep 2015 22:41:21 +0200 > This patch fixes a regression introduced by the commit a84e32894191 > ("net: mvneta: fix refilling for Rx DMA buffers"). Due to this commit > the newly allocated Rx buffers are DMA-unmapped in place of those

Re: [PATCH v4 net 0/5] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

From: Martin KaFai Lau Date: Tue, 15 Sep 2015 14:30:04 -0700 > v4: > - Fix a compilation error in patch 5 when CONFIG_LOCKDEP is turned on and > re-test it > > v3: > - Merge a 'if else if' test in patch 4 > - Use rcu_dereference_protected in patch 5 to fix a sparse check when >

Re: [PATCH net v2] rtnetlink: catch -EOPNOTSUPP errors from ndo_bridge_getlink

From: Roopa Prabhu Date: Tue, 15 Sep 2015 14:44:29 -0700 > From: Roopa Prabhu ... > ndo_bridge_getlink can return -EOPNOTSUPP when an interfaces > ndo_bridge_getlink op is set to switchdev_port_bridge_getlink > and CONFIG_SWITCHDEV is not

Re: [PATCH v2] net: stmmac: Use msleep rather then udelay for reset delay

From: Sjoerd Simons Date: Fri, 11 Sep 2015 22:25:48 +0200 > The reset delays used for stmmac are in the order of 10ms to 1 second, > which is far too long for udelay usage, so switch to using msleep. > > Practically this fixes the PHY not being reliably detected

[PATCH] net: Fix vti use case with oif in dst lookups

Steffen reported that the recent change to add oif to dst lookups breaks the VTI use case. The problem is that with the oif set in the flow struct the comparison to the nh_oif is triggered. Fix by splitting the FLOWI_FLAG_VRFSRC into 2 flags -- one that triggers the vrf device cache bypass

Re: DSA: phy polling

> "Florian" == Florian Fainelli writes: Hi, >> Does the Marvell phy have such a register? Looking at the register >> dump and plugging/unplugging cables seems not to show a register >> reporting whether any particular interface has changed state, and >> I haven't

Re: [PATCH v7 1/3] can: Allwinner A10/A20 CAN Controller support - Devicetree bindings

Hi, On Tue, Sep 15, 2015 at 01:17:10AM +0200, Gerhard Bertelsmann wrote: > Devicetree bindings for Allwinner A10/A20 CAN > > Signed-off-by: Gerhard Bertelsmann > --- > > .../devicetree/bindings/net/can/sun4i_can.txt | 38 + > 1 file changed, 38 insertions(+)

Re: [PATCH v7 2/3] can: Allwinner A10/A20 CAN Controller support - Defconfigs

Hi, On Tue, Sep 15, 2015 at 01:17:11AM +0200, Gerhard Bertelsmann wrote: > Defconfigs for Allwinner A10/A20 CAN driver > > Signed-off-by: Gerhard Bertelsmann > --- > > arch/arm/configs/multi_v7_defconfig| 1 + > arch/arm/configs/sunxi_defconfig

Re: v2 of seccomp filter c/r patches

On Tue, Sep 15, 2015 at 9:07 AM, Tycho Andersen wrote: > Hi Andy, > > On Mon, Sep 14, 2015 at 10:52:46AM -0700, Andy Lutomirski wrote: >> >> I'm not sure I entirely like this solution... > > Ok. Since we also aren't going to do all the eBPF stuff now, how about >

  1   2   >