Re: netlink: Add barrier to netlink_connect for theoretical case

2015-09-24 Thread Linus Torvalds
On Thu, Sep 24, 2015 at 6:43 PM, Herbert Xu wrote: > On Thu, Sep 24, 2015 at 04:05:10PM -0400, Tejun Heo wrote: > > +static inline bool netlink_bound(struct netlink_sock *nlk) > +{ > + /* Ensure nlk is hashed and visible. */ > + if (nlk->bound) > +

Re: [PATCH net-next] net: dsa: Set a "dsa" device_type

2015-09-24 Thread Vivien Didelot
On Sep. Thursday 24 (39) 05:28 PM, Florian Fainelli wrote: > On 24/09/15 15:37, Vivien Didelot wrote: > > Hi Florian, > > > > On Sep. Wednesday 23 (39) 06:19 PM, Florian Fainelli wrote: > >> Provide a device_type information for slave network devices created by > >> DSA, this is useful for

Re: [patch net-next v3 02/10] switchdev: introduce transaction item queue for attr_set and obj_add

2015-09-24 Thread Vivien Didelot
Hi Jiri, On Sep. Thursday 24 (39) 10:02 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Now, the memory allocation in prepare/commit state is done separatelly > in each driver (rocker). Introduce the similar mechanism in generic > switchdev code, in form of queue. That can be

Re: [GIT PULL nf-next 00/84] Second Round of IPVS Updates for v4.4

2015-09-24 Thread Pablo Neira Ayuso
On Thu, Sep 24, 2015 at 09:51:45AM +0900, Simon Horman wrote: > Hi Pablo, > > please consider these bug fixes and extensive clean-ups of IPVS > from Eric Biederman for v4.4. Pulled, thanks Simon. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

RE: [PATCH net-next 2/4] switchdev: skip over ports returning -EOPNOTSUPP when recursing ports

2015-09-24 Thread Premkumar Jonnala
Acked-by: Premkumar Jonnala > -Original Message- > From: sfel...@gmail.com [mailto:sfel...@gmail.com] > Sent: Friday, September 25, 2015 2:29 AM > To: netdev@vger.kernel.org > Cc: j...@resnulli.us; siva.mannem@gmail.com; Premkumar Jonnala; > step...@networkplumber.org;

Re: [PATCH] ethtool: add new emac_regs struct from driver, add new chip types.

2015-09-24 Thread Ivan Mikhaylov
* add new version of emac_regs struct from driver structure perspective and passing size from actual struct size, not from memory area variable which set in dts file. * add three types of network chips for new struct : emac, emac4, emac4sync. * add emac4sync processing in print_emac_regs. *

Re: Glibc recvmsg from kernel netlink socket hangs forever

2015-09-24 Thread Guenter Roeck
Herbert, On 09/24/2015 09:58 PM, Herbert Xu wrote: On Thu, Sep 24, 2015 at 09:36:53PM -0700, Guenter Roeck wrote: http://comments.gmane.org/gmane.linux.network/363085 might explain your problem. I thought this was resolved in 4.1, but it looks like the problem still persists there. At least

RE: [RFC v2 net-next 05/10] qede: Add basic network device support

2015-09-24 Thread Yuval Mintz
> > > +#define QEDE_NAPI_WEIGHT (NAPI_POLL_WEIGHT) > > Why not just use existing constant rather than walpapering? No reason; We'll remove it. > > > +#define U64_LO(x)((u32)(((u64)(x)) & 0x)) > > > +#define U64_HI(x)((u32)(((u64)(x)) >>

Re: [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool

2015-09-24 Thread David Miller
From: Ivan Mikhaylov Date: Fri, 25 Sep 2015 08:07:52 +0400 > Ben proposed one, is it eligible? > Need I resubmit patch with sign and detailed description? If I genuinely need to answer that question, maybe you should sit back for a little while and think about it yourself, ok?

Re: [PATCH net-next 1/4] switchdev: add bridge attributes

2015-09-24 Thread David Miller
From: Premkumar Jonnala Date: Fri, 25 Sep 2015 04:32:16 + > Acked-by: Premkumar Jonnala This is not the correct way to ACK a patch. First of all, you should provide your full email address after your name in the Acked-by:, as I do, like this: "Acked-by: David S.

Re: [RFC v2 net-next 05/10] qede: Add basic network device support

2015-09-24 Thread David Miller
From: Yuval Mintz Date: Fri, 25 Sep 2015 05:43:06 + >> > +struct qede_rx_queue { >> > + __le16 *hw_cons_ptr; >> >> The __ variants of constants should be reserved for use in user visible API's > > Really? If so, this needs to be fixed not only here

Re: [patch net-next v3 02/10] switchdev: introduce transaction item queue for attr_set and obj_add

2015-09-24 Thread David Miller
From: Scott Feldman Date: Thu, 24 Sep 2015 22:29:43 -0700 > I'd rather keep 2-phase not optional, or at least make it some what of > a pain for drivers to opt-out of 2-phase. Forcing the driver to see > both phases means the driver needs to put some code to skip phase 1 >

Re: [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool

2015-09-24 Thread Ivan Mikhaylov
On Wed, 23 Sep 2015 11:05:49 -0700 (PDT) "David Miller" wrote: > From: Ivan Mikhaylov > Date: Wed, 23 Sep 2015 14:42:22 +0400 > > > Register dump out work preventing with > > old ethtool + new driver and new ethtool + old driver. > > First of all you

Re: [PATCH v3 2/2] [net] af_unix: return data from multiple SKBs on recv() with MSG_PEEK flag

2015-09-24 Thread David Miller
From: Aaron Conole Date: Mon, 21 Sep 2015 20:27:02 -0400 > + goto unlock; Sorry, I don't want to see goto's from one loop into a completely different one. The XXX comment is probably not appropriate either. -- To unsubscribe from this list: send the line

linux-next: manual merge of the net-next tree with the net tree

2015-09-24 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/ipv4/arp.c between commit: 63d008a4e9ee ("ipv4: send arp replies to the correct tunnel") from the net tree and commit: 0c4b51f0054c ("netfilter: Pass net into okfn") from the net-next tree. I fixed it up

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-24 Thread Stephen Hemminger
On Thu, 24 Sep 2015 20:25:01 -0700 Scott Feldman wrote: > On Thu, Sep 24, 2015 at 2:05 PM, Stephen Hemminger > wrote: > > On Thu, 24 Sep 2015 13:59:26 -0700 > > sfel...@gmail.com wrote: > > > >> From: Scott Feldman > >> > >>

RE: [PATCH net-next 1/4] switchdev: add bridge attributes

2015-09-24 Thread Premkumar Jonnala
Acked-by: Premkumar Jonnala > -Original Message- > From: sfel...@gmail.com [mailto:sfel...@gmail.com] > Sent: Friday, September 25, 2015 2:29 AM > To: netdev@vger.kernel.org > Cc: j...@resnulli.us; siva.mannem@gmail.com; Premkumar Jonnala; > step...@networkplumber.org;

Re: [PATCH net-next] net: dsa: Set a "dsa" device_type

2015-09-24 Thread Florian Fainelli
On 24/09/15 15:37, Vivien Didelot wrote: > Hi Florian, > > On Sep. Wednesday 23 (39) 06:19 PM, Florian Fainelli wrote: >> Provide a device_type information for slave network devices created by >> DSA, this is useful for user-space application to easily locate/search >> for devices of a specific

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-24 Thread Florian Fainelli
On 24/09/15 13:59, sfel...@gmail.com wrote: > From: Scott Feldman > > Push bridge-level attributes down to switchdev drivers. This patchset > adds the infrastructure and then pushes, as an example, ageing_time attribute > down from bridge to switchdev (rocker) driver. Add

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-24 Thread Andrew Lunn
> So, without a better device to hold that kind of information (in the > future it could be a global, switch-specific device holding that > information), I agree with your decision to take the bridge device to > hold that attribute, it still feels a bit uncomfortable to have >

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-24 Thread Scott Feldman
On Thu, Sep 24, 2015 at 2:05 PM, Stephen Hemminger wrote: > On Thu, 24 Sep 2015 13:59:26 -0700 > sfel...@gmail.com wrote: > >> From: Scott Feldman >> >> Push bridge-level attributes down to switchdev drivers. This patchset >> adds the

Re: netlink: Add barrier to netlink_connect for theoretical case

2015-09-24 Thread Herbert Xu
On Thu, Sep 24, 2015 at 08:24:56PM -0700, Linus Torvalds wrote: > > The above looks very suspicious. You're right Linus. I've added the READ_ONCE there. The reason I kept the conditional is because the helper is always called in a context where the result is used as part of an if statement.

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-24 Thread Scott Feldman
On Thu, Sep 24, 2015 at 6:23 PM, Florian Fainelli wrote: > On 24/09/15 13:59, sfel...@gmail.com wrote: >> From: Scott Feldman >> >> Push bridge-level attributes down to switchdev drivers. This patchset >> adds the infrastructure and then pushes, as an

Re: [PATCH net v2] skbuff: Fix skb checksum flag on skb pull

2015-09-24 Thread David Miller
From: Pravin B Shelar Date: Tue, 22 Sep 2015 12:57:53 -0700 > VXLAN device can receive skb with checksum partial. But the checksum > offset could be in outer header which is pulled on receive. This results > in negative checksum offset for the skb. Such skb can cause the

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread David Miller
From: Andrew Lunn Date: Thu, 24 Sep 2015 23:57:31 +0200 > I built the FEC driver as a module, and it won't unload: > > kernel:unregister_netdevice: waiting for eth1 to become free. Usage count = 1 > unregister_netdevice: waiting for eth1 to become free. Usage count = 1 > > i

Re: [PATCH] net: mdio-octeon: Add PCI driver binding.

2015-09-24 Thread David Miller
From: David Daney Date: Thu, 24 Sep 2015 15:12:03 -0700 > Sorry for the breakage, I will fix it and resubmit. Don't bother, I told you that using PCI probing is unacceptable. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: [PATCH v7 02/10] ss: created formatters for json and hr

2015-09-24 Thread Stephen Hemminger
On Thu, 24 Sep 2015 17:43:46 + Matthias Tafelmeier wrote: > > Maybe it is time to rewrite it in a better language ;-) > > I did not get that. Do you mean iproute2? I meant that the amount of formatting and string processing in ss is getting to be a

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread Russell King - ARM Linux
On Thu, Sep 24, 2015 at 11:57:31PM +0200, Andrew Lunn wrote: > Hi Russell > > I tested both of these with my board. It is a Freescale Vybrid, using > the FEC ethernet driver, and i have three switches attached, using > mdio-mux to give three mdio busses. > > No obvious regressions, my board

Re: [PATCH RESEND v3 5/9] of_mdio: fix MDIO phy device refcounting

2015-09-24 Thread Rob Herring
On Thu, Sep 24, 2015 at 2:36 PM, Russell King wrote: > bus_find_device() is defined as: > > * This is similar to the bus_for_each_dev() function above, but it > * returns a reference to a device that is 'found' for later use, as > * determined by the @match

Re: [PATCH net] fib_rules: fix fib rule dumps across multiple skbs

2015-09-24 Thread David Miller
From: Roopa Prabhu Date: Tue, 22 Sep 2015 21:40:22 -0700 > From: Wilson Kok > > dump_rules returns skb length and not error. > But when family == AF_UNSPEC, the caller of dump_rules > assumes that it returns an error. Hence, when family ==

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread David Miller
From: Andrew Lunn Date: Fri, 25 Sep 2015 00:26:54 +0200 > On Thu, Sep 24, 2015 at 03:15:54PM -0700, David Miller wrote: >> From: Andrew Lunn >> Date: Thu, 24 Sep 2015 23:57:31 +0200 >> >> > I built the FEC driver as a module, and it won't unload: >> > >> >

Re: [PATCH] ip: find correct route for socket which is not bound (v2)

2015-09-24 Thread Wengang Wang
Hi David, 在 2015年09月25日 05:22, David Miller 写道: From: Wengang Wang Date: Mon, 21 Sep 2015 16:00:09 +0800 This is the v2, comparing the v1, the changes is: * for loopback outbound device, it continue skipping cached route; for others, it goes through the cached

Re: Glibc recvmsg from kernel netlink socket hangs forever

2015-09-24 Thread Herbert Xu
On Thu, Sep 24, 2015 at 09:36:53PM -0700, Guenter Roeck wrote: > > http://comments.gmane.org/gmane.linux.network/363085 > > might explain your problem. > > I thought this was resolved in 4.1, but it looks like the problem still > persists > there. At least I have reports from my workplace that

Re: [patch net-next v3 02/10] switchdev: introduce transaction item queue for attr_set and obj_add

2015-09-24 Thread Scott Feldman
On Thu, Sep 24, 2015 at 9:36 PM, Vivien Didelot wrote: > Hi Jiri, > > On Sep. Thursday 24 (39) 10:02 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Now, the memory allocation in prepare/commit state is done separatelly >> in each driver

Re:Hallo

2015-09-24 Thread fcaveylel
Hallo Gute Nachrichten für Sie dj, Motorrad, gultar, Laptop, Kamera, TV ... Versand ist kostenlos iphone 6plus,280euro si te: poazzlo. com

<    1   2   3