[net-next:master 630/633] net/bridge/br_netlink.c:1110:1: warning: the frame size of 2160 bytes is larger than 2048 bytes

2015-10-04 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 3e087caa23ef36370bfb925d3bbca78e8302d3ce commit: 7e4df51eb35deedd3ba8d4db92a6c36fb7eff90a [630/633] bridge: netlink: add support for igmp's intervals config: x86_64-randconfig-s0-10051005 (attached as

[PATCH net-next 4/5] net: use sk_fullsock() in __netdev_pick_tx()

2015-10-04 Thread Eric Dumazet
SYN_RECV & TIMEWAIT sockets are not full blown, they do not have a sk_dst_cache pointer. Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets instead of listener") Signed-off-by: Eric Dumazet --- include/net/request_sock.h | 1 + net/core/dev.c

[PATCH net-next 3/5] ipv6: inet6_sk() should use sk_fullsock()

2015-10-04 Thread Eric Dumazet
SYN_RECV & TIMEWAIT sockets are not full blown, they do not have a pinet6 pointer. Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets instead of listener") Signed-off-by: Eric Dumazet --- include/linux/ipv6.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH net-next 5/5] tcp: avoid two atomic ops for syncookies

2015-10-04 Thread Eric Dumazet
inet_reqsk_alloc() is used to allocate a temporary request in order to generate a SYNACK with a cookie. Then later, syncookie validation also uses a temporary request. These paths already took a reference on listener refcount, we can avoid a couple of atomic operations. Signed-off-by: Eric

[PATCH net-next 0/5] tcp: lockless listener fixes and improvement

2015-10-04 Thread Eric Dumazet
This fixes issues with TCP FastOpen vs lockless listeners, and SYNACK being attached to request sockets. Then, last patch brings performance improvement for syncookies generation and validation. Tested under a 4.3 Mpps SYNFLOOD attack, new perf profile looks like : 12.11% [kernel] [k]

[PATCH net-next 2/5] inet: ip_skb_dst_mtu() should use sk_fullsock()

2015-10-04 Thread Eric Dumazet
SYN_RECV & TIMEWAIT sockets are not full blown, do not even try to call ip_sk_use_pmtu() on them. Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets instead of listener") Signed-off-by: Eric Dumazet --- include/net/ip.h | 9 ++--- 1 file changed, 6

Re: [PATCH net] ppp: don't override sk->sk_state in pppoe_flush_dev()

2015-10-04 Thread Matt Bennett
Hi, I am seeing this panic occur occasionally however I am unsure how to go about reproducing it. Is it enough to simply keep creating and tearing down the PPP interface? I can also test and/or investigate this issue if a suitable reproduction method is available. On Sun, 2015-10-04 at 19:08

[PATCH net-next 1/5] tcp: fix fastopen races vs lockless listener

2015-10-04 Thread Eric Dumazet
There are multiple races that need fixes : 1) skb_get() + queue skb + kfree_skb() is racy An accept() can be done on another cpu, data consumed immediately. tcp_recvmsg() uses __kfree_skb() as it is assumed all skb found in socket receive queue are private. Then the kfree_skb() in

[PATCH] mwifiex: fix a comment typo

2015-10-04 Thread Geliang Tang
Just fix a typo in the code comment. Signed-off-by: Geliang Tang --- drivers/net/wireless/mwifiex/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mwifiex/cfg80211.c b/drivers/net/wireless/mwifiex/cfg80211.c index

[PATCH net-next 06/20] bridge: netlink: export topology_change and topology_change_detected

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_TOPOLOGY_CHANGE and IFLA_BR_TOPOLOGY_CHANGE_DETECTED and export them via netlink. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h | 2 ++ net/bridge/br_netlink.c | 7

[PATCH net-next 14/20] bridge: netlink: add support for igmp's hash_elasticity

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_MCAST_HASH_ELASTICITY to allow setting/getting br->hash_elasticity via netlink. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c | 12

[PATCH net-next 20/20] bridge: netlink: add support for default_pvid

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_VLAN_DEFAULT_PVID to allow setting/getting bridge's default_pvid via netlink. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c | 13

[PATCH net-next 07/20] bridge: netlink: export all timers

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Export the following bridge timers (also exported via sysfs): IFLA_BR_HELLO_TIMER, IFLA_BR_TCN_TIMER, IFLA_BR_TOPOLOGY_CHANGE_TIMER, IFLA_BR_GC_TIMER via netlink. Signed-off-by: Nikolay Aleksandrov ---

[PATCH net-next 00/20] bridge: complete netlink support

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, This set completes the bridge device's netlink support and makes it possible to view and configure everything that can be configured via sysfs. I have tested all of these (setting and getting). There're a few longer line warnings about

[PATCH net-next 01/20] bridge: netlink: add group_fwd_mask support

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_GROUP_FWD_MASK attribute to allow setting and retrieving the group_fwd_mask via netlink. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c |

[PATCH net-next 17/20] bridge: netlink: add support for multicast_startup_query_count

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_MCAST_STARTUP_QUERY_CNT to allow setting/getting br->multicast_startup_query_count via netlink. Also align the ifla comments. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h |

[PATCH net-next 16/20] bridge: netlink: add support for multicast_last_member_count

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_MCAST_LAST_MEMBER_CNT to allow setting/getting br->multicast_last_member_count via netlink. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c

[PATCH net-next 18/20] bridge: netlink: add support for igmp's intervals

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add support to set/get all of the igmp's configurable intervals via netlink. These currently are: IFLA_BR_MCAST_LAST_MEMBER_INTVL IFLA_BR_MCAST_MEMBERSHIP_INTVL IFLA_BR_MCAST_QUERIER_INTVL IFLA_BR_MCAST_QUERY_INTVL

[PATCH net-next 15/20] bridge: netlink: add support for igmp's hash_max

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_MCAST_HASH_MAX to allow setting/getting br->hash_max via netlink. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c | 13 - 2

[PATCH net-next 19/20] bridge: netlink: add support for netfilter tables config

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add support to allow getting/setting netfilter tables settings. Currently these are IFLA_BR_NF_CALL_IPTABLES, IFLA_BR_NF_CALL_IP6TABLES and IFLA_BR_NF_CALL_ARPTABLES. Signed-off-by: Nikolay Aleksandrov ---

Re: [PATCH net-next] net/mlx4_core: Test interrupts fail if not all comp vectors called request_irq

2015-10-04 Thread Or Gerlitz
On 9/29/2015 9:38 PM, cls...@linux.vnet.ibm.com wrote: From: Carol L Soto Test interrupts fails if not all completion vectors called request_irq. This case can happen if only mlx4_en loads and we have more completion vectors than rx rings. good catch! is this a bug

[PATCH net-next 04/20] bridge: netlink: export root port

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_ROOT_PORT and export it via netlink. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c | 4 +++- 2 files changed, 4 insertions(+), 1

[PATCH net-next 02/20] bridge: netlink: export root id

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_ROOT_ID and export br->designated_root via netlink. For this purpose add struct ifla_bridge_id that would represent struct bridge_id. Signed-off-by: Nikolay Aleksandrov ---

[PATCH net-next 05/20] bridge: netlink: export root path cost

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_ROOT_PATH_COST and export it via netlink. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c | 4 +++- 2 files changed, 4 insertions(+), 1

[PATCH net-next 10/20] bridge: netlink: add support for multicast_router

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_MCAST_ROUTER to allow setting and retrieving br->multicast_router when igmp snooping is enabled. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c

[PATCH net-next 12/20] bridge: netlink: add support for multicast_query_use_ifaddr

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_MCAST_QUERY_USE_IFADDR to allow setting/getting br->multicast_query_use_ifaddr via netlink. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c

[PATCH net-next 11/20] bridge: netlink: add support for multicast_snooping

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_MCAST_SNOOPING to allow enabling/disabling multicast snooping via netlink. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c | 13

[PATCH net-next 03/20] bridge: netlink: export bridge id

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_BRIDGE_ID and export br->bridge_id via netlink. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c | 9 +++-- 2 files changed, 8

[PATCH net-next 08/20] bridge: netlink: add group_addr support

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_GROUP_ADDR attribute to allow setting and retrieving the group_addr via netlink. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c | 25

[PATCH net-next 09/20] bridge: netlink: add fdb flush

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Simple attribute that flushes the bridge's fdb. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c | 3 +++ 2 files changed, 4 insertions(+) diff --git

[PATCH net-next 13/20] bridge: netlink: add support for multicast_querier

2015-10-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add IFLA_BR_MCAST_QUERIER to allow setting/getting br->multicast_querier via netlink. Signed-off-by: Nikolay Aleksandrov --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c | 13 -

Re: [PATCH V5 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-10-04 Thread Greg Kroah-Hartman
On Sun, Sep 27, 2015 at 03:48:24PM +0200, Rafael J. Wysocki wrote: > On Sun, Sep 27, 2015 at 12:04 AM, Viresh Kumar > wrote: > > global_lock is defined as an unsigned long and accessing only its lower > > 32 bits from sysfs is incorrect, as we need to consider other 32

Re: [PATCH 15/15] dma: remove external references to dma_supported

2015-10-04 Thread Greg KH
On Sat, Oct 03, 2015 at 05:19:39PM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > Documentation/DMA-API.txt | 13 - > drivers/usb/host/ehci-hcd.c | 2 +- > drivers/usb/host/fotg210-hcd.c | 2 +- > drivers/usb/host/fusbh200-hcd.c |

Re: [PATCH] net/unix: fix logic about sk_peek_offset

2015-10-04 Thread Aaron Conole
Andrey Vagin writes: > From: Andrey Vagin > > Now send with MSG_PEEK can return data from multiple SKBs. > > Unfortunately we take into account the peek offset for each skb, > that is wrong. We need to apply the peek offset only once. > > In addition, the

Re: [patch - Nicholas's tree] netconsole: Missing unlock on error path

2015-10-04 Thread Christoph Hellwig
On Sat, Oct 03, 2015 at 10:05:24PM +0300, Dan Carpenter wrote: > We added new locking to this function but we missed one error path which > needs an unlock. > > Fixes: cdacad4993f4 ('netconsole: use per-attribute show and store methods') > Signed-off-by: Dan Carpenter >

[PATCH] cfg80211: drop unlikely behind WARN_ON()

2015-10-04 Thread Geliang Tang
WARN_ON() already contain an unlikely compiler flag. Drop it. Signed-off-by: Geliang Tang --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c

[PATCH net] netfilter: remove the nh_scope test in rpfilter_lookup_reverse of ipt_rpfilter

2015-10-04 Thread Xin Long
--accept-local option works for res.type == RTN_LOCAL, which should be from the local table, but there, the fib_info's nh->nh_scope = RT_SCOPE_NOWHERE ( > RT_SCOPE_HOST). in fib_create_info(). if (cfg->fc_scope == RT_SCOPE_HOST) { struct fib_nh *nh = fi->fib_nh;

Re: [PATCH net-next v2] net: Add support for filtering neigh dump by device index

2015-10-04 Thread Nikolay Aleksandrov
On 10/03/2015 08:43 PM, David Ahern wrote: > Add support for filtering neighbor dumps by device by adding the > NDA_IFINDEX attribute to the dump request. > > Signed-off-by: David Ahern > --- > v2 > - fix or on the index as noticed by Eagle-Eye Nikolay > >

[RFC PATCH] net: mvneta: add ethtool statistics

2015-10-04 Thread Russell King
Add support for the ethtool statistic interface, returning the full set of statistics which both the Armada 370 and Armada XP can support. Signed-off-by: Russell King --- Is there any standard terminology for the ethtool statistics? Are the names given here

Re: [PATCH v2 1/3] unix: fix use-after-free in unix_dgram_poll()

2015-10-04 Thread Rainer Weikusat
Rainer Weikusat writes: > Mathias Krause writes: >> On 2 October 2015 at 22:43, Jason Baron wrote: >>> The unix_dgram_poll() routine calls sock_poll_wait() not only for the wait >>> queue associated with the socket s

Re: [PATCH net] ppp: don't override sk->sk_state in pppoe_flush_dev()

2015-10-04 Thread Denys Fedoryshchenko
On 2015-10-02 20:54, Guillaume Nault wrote: On Fri, Oct 02, 2015 at 11:01:45AM +0300, Denys Fedoryshchenko wrote: Here is similar panic after patch applied (it might be different bug), got over netconsole: [126348.617115] CPU: 0 PID: 5254 Comm: accel-pppd Not tainted 4.2.2-build-0087 #2

Re: Slow ramp-up for single-stream TCP throughput on 4.2 kernel.

2015-10-04 Thread Ben Greear
On 10/03/2015 06:20 PM, Neal Cardwell wrote: On Sat, Oct 3, 2015 at 6:46 PM, Ben Greear wrote: On 10/03/2015 09:29 AM, Neal Cardwell wrote: On Fri, Oct 2, 2015 at 8:21 PM, Ben Greear wrote: Gah, seems 'cubic' related. That is the

Re: Slow ramp-up for single-stream TCP throughput on 4.2 kernel.

2015-10-04 Thread Eric Dumazet
On Sun, 2015-10-04 at 10:05 -0700, Ben Greear wrote: > I guess I'll just stop using Cubic. Any suggestions for another > congestion algorithm to use? I'd prefer something that worked well > in pretty much any network condition, of course, and it has to work with > ath10k. > > We can also run

Re: Slow ramp-up for single-stream TCP throughput on 4.2 kernel.

2015-10-04 Thread Yuchung Cheng
On Sun, Oct 4, 2015 at 10:28 AM, Eric Dumazet wrote: > On Sun, 2015-10-04 at 10:05 -0700, Ben Greear wrote: > >> I guess I'll just stop using Cubic. Any suggestions for another >> congestion algorithm to use? I'd prefer something that worked well >> in pretty much any

[patch net-next 05/14] rocker: implement set settings mode command

2015-10-04 Thread Jiri Pirko
From: Jiri Pirko Introduce a helper to ask HW for change of the port mode (world). Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker_main.c | 32 +++ 1 file changed, 32 insertions(+) diff --git

[patch net-next 06/14] rocker: introduce worlds infrastructure

2015-10-04 Thread Jiri Pirko
From: Jiri Pirko This is another step on the way to per-world clean cut. Introduce world ops hooks which each world can implement in world-specific way. Also introduce world infrastructure including function for port worlds change. Signed-off-by: Jiri Pirko

[patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

2015-10-04 Thread Jiri Pirko
From: Jiri Pirko Introduce a stub for allowing user to change rocker port world/mode. This is implemented using rtnl changelink op. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker_main.c | 56 +++

[patch net-next 10/14] rocker: pass "learning" value as a parameter to rocker_port_set_learning

2015-10-04 Thread Jiri Pirko
From: Jiri Pirko Be consistent with the rest of the setting functions, and pass "learning" as a bool function parameter. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker_main.c | 14 +- 1 file changed, 9 insertions(+), 5

[patch net-next 13/14] rocker: call rocker_cmd_exec function with "nowait" boolean instead of flags

2015-10-04 Thread Jiri Pirko
From: Jiri Pirko No need to push down rocker flags just to check if this is nowait or not. Let the caller handle that. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker_main.c | 38 +++ 1 file changed, 23

[patch net-next 08/14] rocker: set default world on port probe and clean world on remove

2015-10-04 Thread Jiri Pirko
From: Jiri Pirko Currently, there is only OF-DPA world supported in HW. So make this would the default one for newly created rocker ports. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker_main.c | 10 ++ 1 file changed, 10

[patch net-next 04/14] rocker: push tlv processing into separate files

2015-10-04 Thread Jiri Pirko
From: Jiri Pirko Carve out TLV processing helpers into separate files. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/Makefile | 2 +- drivers/net/ethernet/rocker/rocker.h | 27 drivers/net/ethernet/rocker/rocker_main.c | 222

[patch net-next 00/14] rocker: add support for multiple worlds

2015-10-04 Thread Jiri Pirko
From: Jiri Pirko This patchset allows new rocker worlds to be easily added in future (like eBPF based one I have been working on). The main part of the patchset is the OF-DPA carve-out. It resuts in OF-DPA specific file. Clean cut. The user is able to change rocker port

[patch net-next 01/14] rocker: remove unused rocker_port param from alloc funcs and shorten their names

2015-10-04 Thread Jiri Pirko
From: Jiri Pirko No need to pass rocker_port around to alloc/free rocker functions, since they now use switchdev_trans for memory management storage. With the param removal, shorten the name of the functions since they now has nothing to do with rocker port. Signed-off-by:

[patch net-next 12/14] rocker: remove trans parameter to rocker_cmd_exec function

2015-10-04 Thread Jiri Pirko
From: Jiri Pirko The only purpose of passing this parameter is to check for prepare phase. The only reason for a failure in that state is if TLVs don't fit into descriptor. That is highly unlikely and if that happens, it is a driver bug. So remove this parameter from

[patch net-next 02/14] rocker: rename rocker.h to rocker_hw.h

2015-10-04 Thread Jiri Pirko
From: Jiri Pirko Since "rocker.h" file is going to be used for different purpose, rename the hardware-specific header to "rocker_hw.h". Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker.c| 2 +- drivers/net/ethernet/rocker/rocker.h

[patch net-next 07/14] rocker: introduce OF-DPA world skeleton

2015-10-04 Thread Jiri Pirko
From: Jiri Pirko Introduce basis for OF-DPA world file. This is the place where all OF-DPA related code is going to be moved. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/Makefile | 2 +- drivers/net/ethernet/rocker/rocker.h | 2

Re: [PATCH] brcm80211:Fix locking region in the function brcmf_sdio_sendfromq

2015-10-04 Thread Arend van Spriel
On 10/03/2015 06:19 PM, Nicholas Krause wrote: This fixes the locking region in the function brcmf_sdio_sendfromq to properly lock around the call to the function brcmrf_sdio_txpkt in order to avoid concurrent access issues when calling this function as stated in the function's comments about

Re: [PATCH net] netfilter: remove the nh_scope test in rpfilter_lookup_reverse of ipt_rpfilter

2015-10-04 Thread Florian Westphal
Xin Long wrote: > it seems the test is bogus and can be removed to fix this issue. > > if (dev_match || flags & XT_RPFILTER_LOOSE) > return FIB_RES_NH(res).nh_scope <= RT_SCOPE_HOST; > > ipv6 does not have this issue. netfilter patches should be sent

Re: [PATCH net-next 0/4] bridge: vlan: cleanups & fixes (part 2)

2015-10-04 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 2 Oct 2015 15:05:09 +0200 > This is the second follow-up set with one fix (patch 01) and more cleanups > (patches 02,03 and 04). These are minor compared to the previous ones and > should be the last before taking on the optimization

Re: [PATCH net-next 00/20] bridge: complete netlink support

2015-10-04 Thread David Miller
From: Nikolay Aleksandrov Date: Sun, 4 Oct 2015 14:23:27 +0200 > This set completes the bridge device's netlink support and makes it > possible to view and configure everything that can be configured via > sysfs. I have tested all of these (setting and getting). There're a