Re: [PATCH net] net: try harder to not reuse ifindex when moving interfaces

Hi Thomas, On Thu, Oct 22, 2015, at 18:45, Thomas Graf wrote: > On 10/22/15 at 05:00pm, Jiri Benc wrote: > > On Thu, 22 Oct 2015 16:52:13 +0200, Nicolas Dichtel wrote: > > > With the proposed scenario: > > > 1. create netns 'new_netns' > > > 2. in root netns, move the interface with ifindex 2 to

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

Daniel Borkmann writes: > On 10/20/2015 08:56 PM, Eric W. Biederman wrote: > ... >> Just FYI: Using a device for this kind of interface is pretty >> much a non-starter as that quickly gets you into situations where >> things do not work in containers. If someone gets a

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

On Thu, Oct 22, 2015 at 11:55:42AM +0100, Alan Burlison wrote: > On 22/10/2015 05:21, Al Viro wrote: > > >>Most of the work on using a file descriptor is local to the thread. > > > >Using - sure, but what of cacheline dirtied every time you resolve a > >descriptor to file reference? > > Don't

[PATCH v2 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret". Return "0" on line 1733 Remove unneccesary variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/ath5k/eeprom.c | 5 ++--- 1

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

>On Thu, Oct 22, 2015 at 08:34:19AM +0200, casper@oracle.com wrote: >> >> >> >And I'm really curious about the things Solaris would do with dup2() there. >> >Does it take into account the possibility of new accept() coming just as >> >dup2() is trying to terminate the ongoing ones? Is

Re: [PATCH 3/8] net: consolidate memcg socket buffer tracking and accounting

On Thu, Oct 22, 2015 at 09:46:12PM +0300, Vladimir Davydov wrote: > On Thu, Oct 22, 2015 at 12:21:31AM -0400, Johannes Weiner wrote: > > The tcp memory controller has extensive provisions for future memory > > accounting interfaces that won't materialize after all. Cut the code > > base down to

[BUG] bnx2x_config_vlan_mac called a NULL function pointer

Hello netdev, I probably found a bug in kernel-4.3.0-0.rc5 (bnx2x driver). So I opened new bug report in our bugzilla [0]. Michal Schmidt told me the best way to solve an upstream bug is to contact you directly to netdev list.. so here I am :). Can somebody take a look at it? [0]

Re: [RFC v3 1/2] iwlwifi: pcie: allow to build an A-MSDU using TSO core

On 10/22/2015 05:27 AM, Eric Dumazet wrote: > On Thu, 2015-10-22 at 00:14 +, Grumbach, Emmanuel wrote: > >> >> Well. I guess I should at least check, but even with very small MSS, our >> device supports up to 20 pointers for the same 802.11 packet: 2 are for >> metadata. So basically, so

[PATCH 4/4] xfrm: Fix pmtu discovery for local generated packets.

Commit 044a832a777 ("xfrm: Fix local error reporting crash with interfamily tunnels") moved the setting of skb->protocol behind the last access of the inner mode family to fix an interfamily crash. Unfortunately now skb->protocol might not be set at all, so we fail dispatch to the inner address

[PATCH 3/4] xfrm: Fix state threshold configuration from userspace

From: Michael Rossberg Allow to change the replay threshold (XFRMA_REPLAY_THRESH) and expiry timer (XFRMA_ETIMER_THRESH) of a state without having to set other attributes like replay counter and byte lifetime. Changing these other values while traffic flows will

pull request (net): ipsec 2015-10-22

1) Fix IPsec pre-encap fragmentation for GSO packets. From Herbert Xu. 2) Fix some header checks in _decode_session6. We skip the header informations if the data pointer points already behind the header in question for some protocols. This is because we call pskb_may_pull with a

[PATCH 2/4] xfrm6: Fix ICMPv6 and MH header checks in _decode_session6

From: Mathias Krause Ensure there's enough data left prior calling pskb_may_pull(). If skb->data was already advanced, we'll call pskb_may_pull() with a negative value converted to unsigned int -- leading to a huge positive value. That won't matter in practice as

[PATCH 1/4] ipv6: Fix IPsec pre-encap fragmentation check

From: Herbert Xu The IPv6 IPsec pre-encap path performs fragmentation for tunnel-mode packets. That is, we perform fragmentation pre-encap rather than post-encap. A check was added later to ensure that proper MTU information is passed back for locally generated

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

From: Al Viro >Except that in this case "correctness" is the matter of rather obscure and >ill-documented areas in POSIX. Don't get me wrong - this semantics isn't >inherently bad, but it's nowhere near being an absolute requirement. It would more fruitful to have

RE: [PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite

Hi Marc, > -Original Message- > From: Marc Kleine-Budde [mailto:m...@pengutronix.de] > Sent: Thursday, October 22, 2015 1:52 PM > To: Arnd Bergmann; linux-arm-ker...@lists.infradead.org > Cc: Appana Durga Kedareswara Rao; Anirudha Sarangi; w...@grandegger.com; > Michal Simek; Soren

[PATCH 0/3] Refactor nested mdiobus read/write functions

In order to avoid locked signal false positive for nested mdiobus read/write calls, nested code was introduced in mv88e6xxx and mdio-mux. But mv88e6060 also needs such nested mdiobus read/write calls. For sake of refactoring, introduce nested variants of mdiobus read/write and make them used by

[PATCH 1/3] net: phy: Add nested variants of mdiobus read/write

Since nested variants of mdiobus_read/write are used in multiple drivers, add nested variants in the mdiobus core. Suggested-by: Andrew Lunn Signed-off-by: Neil Armstrong --- drivers/net/phy/mdio_bus.c | 55 ++

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

On Thu, Oct 22, 2015 at 05:44:58AM +0100, Al Viro wrote: > Except that in this case "correctness" is the matter of rather obscure and > ill-documented areas in POSIX. Don't get me wrong - this semantics isn't > inherently bad, but it's nowhere near being an absolute requirement. PS: in

Re: [PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper

On 10/21/15 10:31 PM, Wangnan (F) wrote: +if ((attr->type != PERF_TYPE_RAW && + !(attr->type == PERF_TYPE_SOFTWARE && + attr->config == PERF_COUNT_SW_BPF_OUTPUT) && + attr->type != PERF_TYPE_HARDWARE) || +attr->inherit) { This 'if' statement is so complex.

Re: [PATCH net-next RFC 1/2] vhost: introduce vhost_has_work()

On Thu, Oct 22, 2015 at 01:27:28AM -0400, Jason Wang wrote: > This path introduces a helper which can give a hint for whether or not > there's a work queued in the work list. > > Signed-off-by: Jason Wang > --- > drivers/vhost/vhost.c | 6 ++ > drivers/vhost/vhost.h | 1

Re: [PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite

On Thursday 22 October 2015 10:21:58 Marc Kleine-Budde wrote: > On 10/22/2015 10:14 AM, Arnd Bergmann wrote: > > On Thursday 22 October 2015 10:16:02 Kedareswara rao Appana wrote: > >> The driver only supports memory-mapped I/O [by ioremap()], > >> so readl/writel is actually the right thing to

Re: [PATCH v3 1/1] eventfd: implementation of EFD_MASK flag

Hello, > diff --git a/include/linux/eventfd.h b/include/linux/eventfd.h > index ff0b981..87de343 100644 > --- a/include/linux/eventfd.h > +++ b/include/linux/eventfd.h > > -/* > - * CAREFUL: Check include/uapi/asm-generic/fcntl.h when defining > - * new flags, since they might collide with O_*

Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

* Wangnan (F) wrote: > > > On 2015/10/22 0:57, Peter Zijlstra wrote: > >On Wed, Oct 21, 2015 at 11:06:47PM +0800, pi3orama wrote: > >>>So explain; how does this eBPF stuff work. > >>I think I get your point this time, and let me explain the eBPF stuff to > >>you. > >> >

Re: [PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper

On 2015/10/22 14:21, Alexei Starovoitov wrote: On 10/21/15 10:31 PM, Wangnan (F) wrote: +if ((attr->type != PERF_TYPE_RAW && + !(attr->type == PERF_TYPE_SOFTWARE && + attr->config == PERF_COUNT_SW_BPF_OUTPUT) && + attr->type != PERF_TYPE_HARDWARE) || +

Re: [PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite

On Thursday 22 October 2015 10:16:02 Kedareswara rao Appana wrote: > The driver only supports memory-mapped I/O [by ioremap()], > so readl/writel is actually the right thing to do, IMO. > During the validation of this driver or IP on ARM 64-bit processor > while sending lot of packets observed

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

>It's been said that the current mechanisms in Linux & some BSD variants >can be subject to races, and the behaviour exhibited doesn't conform to >POSIX, for example requiring the use of shutdown() on unconnected >sockets because close() doesn't kick off other threads accept()ing on >the same

Re: [PATCH] net: dsa: mv88e6060: Fix false positive lockdep splat

On 10/21/2015 06:14 PM, Andrew Lunn wrote: > On Wed, Oct 21, 2015 at 05:37:45PM +0200, Neil Armstrong wrote: >> Like the change made for mv88e6xxx, use mutex_lock_nested() to avoid >> lockdep to give false positives because of nested MDIO busses. > > Hi Neil > > We now have three instances of

Re: [PATCH] net: dsa: mv88e6060: Fix false positive lockdep splat

On 10/21/2015 06:14 PM, Andrew Lunn wrote: > On Wed, Oct 21, 2015 at 05:37:45PM +0200, Neil Armstrong wrote: >> Like the change made for mv88e6xxx, use mutex_lock_nested() to avoid >> lockdep to give false positives because of nested MDIO busses. > > Hi Neil > > We now have three instances of

RE: [PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite

Hi Arnd, > -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Thursday, October 22, 2015 1:45 PM > To: linux-arm-ker...@lists.infradead.org > Cc: Appana Durga Kedareswara Rao; Anirudha Sarangi; w...@grandegger.com; > m...@pengutronix.de; Michal Simek; Soren

[PATCH iproute2] ip-address: properly display zero IPv4 peer address

Kernel allows for zero IPv4 peer addresses (IFA_ADDRESS): ip address add 192.168.5.1 peer 0.0.0.0/24 dev dummy which is distinct from a usual address like: ip address add 192.168.5.1/24 dev dummy ip address add 192.168.5.1 peer 192.168.5.1/24 dev dummy For IPv4, a missing IFA_ADDRESS

Re: [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate

On Wed, Oct 21, 2015 at 10:07 PM, Punit Vara wrote: > Remove int ret suggested by kbuild test robot > > This patch is to the wlcore/acx.c file that fixes up warning > reported by coccicheck: > > WARNING: end returns can be simplified if negative or 0 value > > Prefer direct

Re: [PATCH] net: dsa: mv88e6060: Fix false positive lockdep splat

Hi Andrew, On 10/21/2015 06:14 PM, Andrew Lunn wrote: > On Wed, Oct 21, 2015 at 05:37:45PM +0200, Neil Armstrong wrote: >> Like the change made for mv88e6xxx, use mutex_lock_nested() to avoid >> lockdep to give false positives because of nested MDIO busses. > > Hi Neil > > We now have three

Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

On 2015/10/22 15:39, Ingo Molnar wrote: * Wangnan (F) wrote: [SNIP] In summary, your either-or logic doesn't hold in BPF world. A BPF program can only access perf event in a highly restricted way. We don't allow it calling perf_event_read_local() across core, so it

[PATCH v3 1/2] net: mvneta: add ethtool statistics

Add support for the ethtool statistic interface, returning the full set of statistics which both Armada 370, 38x and Armada XP can support. Tested-by: Andrew Lunn Signed-off-by: Russell King --- drivers/net/ethernet/marvell/mvneta.c | 108

[PATCH v3 0/2] mvneta ethtool statistics

Sorry for v3 - I forgot to update the commit message on patch 1 as requested by Marcin. This short series adds ethtool statistics reporting to mvneta. Having discussed with Andrew on IRC, we decided I'd pick up his patch into my series. My change for patch 1 compared to the previous RFC splits

[PATCH v3 2/2] net: mvneta: Fix clearing of MIB statistics

From: Andrew Lunn The existing function to clear the MIB statatistics was using the wrong address for the registers. Also, the counters would of been cleared when the interface was brought up, not during the probe. Fix both of these. Signed-off-by: Andrew Lunn

XFRM Policy lookup in flowcache

Hi All, I have a question regarding speeding up xfrm policy lookup in flow cache. We are working on a product where 3 policies (in,fwd and out) are setup per tunnel. Tunnels comes up and down all the time, so the policy data base will be keep changing. Looks like there is an impact in

Re: [PATCH 7/8] mm: vmscan: report vmpressure at the level of reclaim activity

On Thu, Oct 22, 2015 at 12:21:35AM -0400, Johannes Weiner wrote: ... > @@ -2437,6 +2439,10 @@ static bool shrink_zone(struct zone *zone, struct > scan_control *sc, > } > } > > + vmpressure(sc->gfp_mask, memcg, > +

[PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

Remove black line suggested by Sergei This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded variable ret created to return zero. Signed-off-by: Punit Vara ---

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

On Thu, Oct 22, 2015 at 12:21:33AM -0400, Johannes Weiner wrote: ... > @@ -5500,13 +5524,38 @@ void sock_release_memcg(struct sock *sk) > */ > bool mem_cgroup_charge_skmem(struct mem_cgroup *memcg, unsigned int nr_pages) > { > + unsigned int batch = max(CHARGE_BATCH, nr_pages); >

Re: [PATCH 3/3] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

David Miller writes: > From: Mans Rullgard > Date: Thu, 22 Oct 2015 15:02:38 +0100 > >> This adds a driver for the Aurora VLSI NB8800 Ethernet controller. >> It is an almost complete rewrite of a driver originally found in >> a Sigma Designs 2.6.22 tree. >>

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

On 22/10/2015 18:05, Al Viro wrote: Oh, for... Right in this thread an example of complete BS has been quoted from POSIX close(2). The part about closing a file when the last descriptor gets closed. _Nothing_ is POSIX-compliant in that respect (nor should it be). That's not exactly what it

Re: [PATCH 3/8] net: consolidate memcg socket buffer tracking and accounting

On Thu, Oct 22, 2015 at 12:21:31AM -0400, Johannes Weiner wrote: > The tcp memory controller has extensive provisions for future memory > accounting interfaces that won't materialize after all. Cut the code > base down to what's actually used, now and in the likely future. > > - There won't be

[PATCH net-next] net: encx24j600: Fix mask to update LED configuration

From: Jon Ringle This fixes the mask used to update the LED configuration so that it clears the necessary bits as well as setting the bits according to the mask. Also reverse the LED configuration to show the Link state + collisions in LEDA and the Link state + TX/RX

[PATCH v5 1/2] geneve: implement support for IPv6-based tunnels

NOTE: Link-local IPv6 addresses for remote endpoints are not supported, since the driver currently has no capacity for binding a geneve interface to a specific link. Signed-off-by: John W. Linville --- v5: - wrap declaration of sock6 in geneve_dev with

[PATCH v5 2/2] geneve: handle ipv6 priority like ipv4 tos

Signed-off-by: John W. Linville Reported-by: Jesse Gross Reviewed-by: Jesse Gross --- v5 -- same as previous revision drivers/net/geneve.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

>On Thu, Oct 22, 2015 at 08:24:51PM +0200, casper@oracle.com wrote: > >> The external behaviour atomic; you cannot distinguish the order >> between the closing of the original file (and waking up other threads >> waiting for a record lock) or changing the file referenced by that newfd. >> >>

Re: [PATCH 01/15] net: wireless: ath: use | instead of + for summing bitmasks

On Thu, Oct 22, 2015 at 3:13 AM, Sergei Shtylyov wrote: > Hello. > > On 10/21/2015 05:55 PM, Punit Vara wrote: > >> This patch is to the ath10k/pci.h file that fixes following warning > > >pci.c, you mean? > > >> reported by coccicheck: >> >> WARNING: sum

Re: [PATCH 15/15] net: wireless: ath: Remove unneeded variable ret returning 0

On Thu, Oct 22, 2015 at 3:16 AM, Sergei Shtylyov wrote: > On 10/21/2015 05:55 PM, Punit Vara wrote: > >> This patch is to the ath5k/eeprom.c that fixes up warning caught by >> coccicheck: >> >> Unneeded variable: "ret". Return "0" on line 980 >> >> Remove

[PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret". Return "0" on line 1733 Remove unneccesary variable ret created to return zero. Also removed empty line suggested by Sergei Signed-off-by: Punit Vara ---

Re: [PATCH 0/8] mm: memcontrol: account socket memory in unified hierarchy

Hi Johannes, On Thu, Oct 22, 2015 at 12:21:28AM -0400, Johannes Weiner wrote: ... > Patch #5 adds accounting and tracking of socket memory to the unified > hierarchy memory controller, as described above. It uses the existing > per-cpu charge caches and triggers high limit reclaim

Re: [PATCH net] net: try harder to not reuse ifindex when moving interfaces

On 10/22/15 at 07:21pm, Hannes Frederic Sowa wrote: > Hi Thomas, > > On Thu, Oct 22, 2015, at 18:45, Thomas Graf wrote: > > I understand the race but when does it occur? Whoever creates > > the original interface owns it and is responsible for its > > lifecycle. *Iff* for some reason multiple

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

On Thu, Oct 22, 2015 at 06:39:34PM +0100, Alan Burlison wrote: > On 22/10/2015 18:05, Al Viro wrote: > > >Oh, for... Right in this thread an example of complete BS has been quoted > >from POSIX close(2). The part about closing a file when the last descriptor > >gets closed. _Nothing_ is

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

On Thu, Oct 22, 2015 at 08:24:51PM +0200, casper@oracle.com wrote: > The external behaviour atomic; you cannot distinguish the order > between the closing of the original file (and waking up other threads > waiting for a record lock) or changing the file referenced by that newfd. > > But

CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map)

Hi Tom & David, I've queued-up a patch for the parisc architecture which reduces L1_CACHE_BYTES from 32 to 16: https://patchwork.kernel.org/patch/7399291/ But this change will break the kernel build like this: In file included from net/core/dev.c:92:0: net/core/dev.c: In function

Re: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

On Fri, Oct 23, 2015 at 12:05 AM, Sergei Shtylyov wrote: > Hello. > > On 10/22/2015 09:26 PM, Punit Vara wrote: > >> This patch is to the ath5k/eeprom.c that fixes up warning caught by >> coccicheck: >> >> -Unneeded variable: "ret". Return "0" on line 1733 >>

[PATCH v5 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

Remove empty line suggested by Sergei This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded variable ret created to return zero. Signed-off-by: Punit Vara ---

Re: [PATCH 8/8] mm: memcontrol: hook up vmpressure to socket pressure

On Thu, Oct 22, 2015 at 12:21:36AM -0400, Johannes Weiner wrote: ... > @@ -185,8 +183,29 @@ static void vmpressure_work_fn(struct work_struct *work) > vmpr->reclaimed = 0; > spin_unlock(>sr_lock); > > + level = vmpressure_calc_level(scanned, reclaimed); > + > + if (level >

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

On Thu, Oct 22, 2015 at 08:34:19AM +0200, casper@oracle.com wrote: > > > >And I'm really curious about the things Solaris would do with dup2() there. > >Does it take into account the possibility of new accept() coming just as > >dup2() is trying to terminate the ongoing ones? Is there a

Re: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

Hello. On 10/22/2015 09:26 PM, Punit Vara wrote: This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret". Return "0" on line 1733 Remove unneccesary variable ret created to return zero. Also removed empty line suggested by Sergei

Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

On 10/22/2015 09:47 PM, Punit Vara wrote: Remove black line suggested by Sergei Such kind of comments should be under the --- tear line. This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded

Re: [PATCH v2 1/2] devicetree: add binding for Aurora VLSI NB8800 Ethernet controller

On Thu, Oct 22, 2015 at 11:28 AM, Mans Rullgard wrote: > This adds a binding for the Aurora VLSI NB8800 Ethernet controller > using the "aurora,nb8800" compatible string. When used in Sigma > Designs chips a few additional control registers are available. > This variant is

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

From: Al Viro >On Thu, Oct 22, 2015 at 06:39:34PM +0100, Alan Burlison wrote: >> On 22/10/2015 18:05, Al Viro wrote: >> >> >Oh, for... Right in this thread an example of complete BS has been quoted >> >from POSIX close(2). The part about closing a file when the last

Re: of_mdiobus_register_phy() and deferred probe

Hello. On 10/22/2015 04:31 PM, Geert Uytterhoeven wrote: Due to a probe deferral of an interrupt controller[1], the Micrel Ethernet PHY on r8a7791/koelsch started failing to get its IRQ: no irq domain found for /interrupt-controller@e61c ! However, of_mdiobus_register_phy() uses

Re: [PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite

On 10/22/2015 10:14 AM, Arnd Bergmann wrote: > On Thursday 22 October 2015 10:16:02 Kedareswara rao Appana wrote: >> The driver only supports memory-mapped I/O [by ioremap()], >> so readl/writel is actually the right thing to do, IMO. >> During the validation of this driver or IP on ARM 64-bit

[PATCH 3/3] net: dsa: Make mv88e6060 use nested mdiobus read/write

Like mv88e6xxx and mdio-mux, to avoid lockdep give false positives because of nested MDIO busses, switch to previously introduced nested mdiobus_read/write variants. Signed-off-by: Neil Armstrong --- drivers/net/dsa/mv88e6060.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH 2/3] net: dsa: Make mv88e6xxx use nested mdiobus read/write

Make the mv88e6xxx driver use the previously introduced nested variants of mdiobus_read/write functions. Signed-off-by: Neil Armstrong --- drivers/net/dsa/mv88e6xxx.c | 46 + 1 file changed, 9 insertions(+), 37 deletions(-)

Re: [PATCH] net: dsa: mv88e6060: Fix false positive lockdep splat

> Well, mdio-mux also calls switch_fn inside the mdio_lock, clean refactoring > would introduce a separate lock and call the nested variants. > Is that ok ? Can someone test mdio-mux if I make the change ? Hi Neil I would not touch mdio-mux. As you said, it does more than lock, read, unlock. It

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

On 2015-10-22 13:31, Prarit Bhargava wrote: > > > On 10/21/2015 03:52 PM, Michal Marek wrote: >> Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): >>> On 10/15/2015 04:16 PM, Michal Marek wrote: Otherwise make tags can't parse them: ctags: Warning: arch/ia64/kernel/smp.c:60: null

pull request: bluetooth-next 2015-10-22

Hi Dave, Here's probably the last bluetooth-next pull request for 4.4. Among several other changes it contains the rest of the fixes & cleanups from the Bluetooth UnplugFest (that didn't need to be hurried to 4.3). - Refactoring & cleanups to 6lowpan code - New USB ids for two Atheros

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

On 10/21/2015 03:52 PM, Michal Marek wrote: > Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): >> On 10/15/2015 04:16 PM, Michal Marek wrote: >>> Otherwise make tags can't parse them: >>> >>> ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern >>> "\1" >>> ctags: Warning:

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

On 10/22/2015 08:06 AM, Michal Marek wrote: > On 2015-10-22 13:31, Prarit Bhargava wrote: >> >> >> On 10/21/2015 03:52 PM, Michal Marek wrote: >>> Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a): On 10/15/2015 04:16 PM, Michal Marek wrote: > Otherwise make tags can't parse them: >

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

On 22/10/2015 07:51, casper@oracle.com wrote: It would more fruitful to have such a discussion in one of the OpenGroup mailing lists; people gathered there have a lot of experience and it is also possible to fix the standard when it turns out that it indeed as vague as you claim it is (I

RE: [RFC v3 2/2] iwlwifi: mvm: send large SKBs to the transport

> > On Wed, 2015-10-21 at 21:34 +0300, Emmanuel Grumbach wrote: > > + > > + if (skb->protocol == htons(ETH_P_IP)) { > > + ip_hdr(tmp)->id = ip_hdr(skb)->id; > > Too late, you already called consume_skb(skb). > So this is a potential use after free. Ouch - thanks for

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

On 22/10/2015 05:21, Al Viro wrote: Most of the work on using a file descriptor is local to the thread. Using - sure, but what of cacheline dirtied every time you resolve a descriptor to file reference? Don't you have to do that anyway, to do anything useful with the file? How much does

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

On 22/10/2015 05:44, Al Viro wrote: It's been said that the current mechanisms in Linux & some BSD variants can be subject to races You do realize that it goes for the entire area? And the races found in this thread are in the BSD variant that tries to do something similar to what you guys

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

On Thu, 2015-10-22 at 08:15 +0200, casper@oracle.com wrote: > >It's been said that the current mechanisms in Linux & some BSD variants > >can be subject to races, and the behaviour exhibited doesn't conform to > >POSIX, for example requiring the use of shutdown() on unconnected > >sockets

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

On 22/10/2015 12:30, Eric Dumazet wrote: We absolutely do not _want_ to do this just so that linux becomes slower to the point Solaris can compete, or you guys can avoid some work. Sentiments such as that really have no place in a discussion that's been focussed primarily on the behaviour of

Re: [RFC v3 2/2] iwlwifi: mvm: send large SKBs to the transport

On Wed, 2015-10-21 at 21:34 +0300, Emmanuel Grumbach wrote: > + > + if (skb->protocol == htons(ETH_P_IP)) { > + ip_hdr(tmp)->id = ip_hdr(skb)->id; Too late, you already called consume_skb(skb). So this is a potential use after free. > +

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

On Thu, 2015-10-22 at 12:58 +0100, Alan Burlison wrote: > On 22/10/2015 12:30, Eric Dumazet wrote: > > > We absolutely do not _want_ to do this just so that linux becomes slower > > to the point Solaris can compete, or you guys can avoid some work. > > Sentiments such as that really have no

[PATCH net,stable] qmi_wwan: add Sierra Wireless MC74xx/EM74xx

New device IDs shamelessly lifted from the vendor driver. Signed-off-by: Bjørn Mork --- drivers/net/usb/qmi_wwan.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 355842b85ee9..2a7c1be23c4f 100644 ---

Re: igmp broadcast storm Red Hat EL7 3.1 Kernel

On 8/31/15, Jeffrey Merkey wrote: > I was able to reproduce it last night with 2.6.32 on Centos 6.3 so it > does not seem confined to just the 3.X tree. I think this is > something that's been lurking in the kernel for years and just has a > hard time showing up. Bugs

Re: sh_eth.c::sh_eth_rx(): mdp->rx_skbuff[entry] can be NULL

Hello. On 10/21/2015 10:26 AM, Yasushi SHOJI wrote: Thank your for your reply. Not at all, I'm virtually a maintainer for that driver now, so trying to filter out the related mails even if I don't have time to read thru all the netdev mail. On 10/19/2015 06:01 PM, Yasushi SHOJI

Re: [PATCH net v2] openvswitch: Fix egress tunnel info.

Hi Pravin, [auto build test WARNING on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Pravin-B-Shelar/openvswitch-Fix-egress-tunnel-info/20151023-053247 config:

Re: [PATCH 3/3] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

Hi Mans, [auto build test WARNING on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Mans-Rullgard/devicetree-add-vendor-prefix-for-Aurora-VLSI/20151022-220753 config: sparc64-allyesconfig

Re: [PATCH v6] can: xilinx: Convert to runtime_pm

Hi Kedar, On Thu, 2015-10-22 at 10:15AM +0530, Kedareswara rao Appana wrote: > Instead of enabling/disabling clocks at several locations in the driver, > Use the runtime_pm framework. This consolidates the actions for runtime PM > In the appropriate callbacks and makes the driver more readable

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

On 22/10/15 19:16, Al Viro wrote: Don't you have to do that anyway, to do anything useful with the file? Dirtying the cacheline that contains struct file itself is different, but that's not per-descriptor. Yes, true enough. Usually it's per-process, but any thread could ask for a private

[PATCH net v2] openvswitch: Fix egress tunnel info.

While transitioning to netdev based vport we broke OVS feature which allows user to retrieve tunnel packet egress information for lwtunnel devices. Following patch fixes it by introducing ndo operation to get the tunnel egress info. Same ndo operation can be used for lwtunnel devices and compat

Re: CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map)

On Thu, Oct 22, 2015 at 1:00 PM, Helge Deller wrote: > Hi Tom & David, > > I've queued-up a patch for the parisc architecture which reduces > L1_CACHE_BYTES from 32 to 16: > https://patchwork.kernel.org/patch/7399291/ > > But this change will break the kernel build like this: >

Re: CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map)

On Thu, 2015-10-22 at 22:00 +0200, Helge Deller wrote: > Hi Tom & David, > > I've queued-up a patch for the parisc architecture which reduces > L1_CACHE_BYTES from 32 to 16: > https://patchwork.kernel.org/patch/7399291/ > > But this change will break the kernel build like this: > > In file

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

On Thu, Oct 22, 2015 at 09:51:05PM +0200, casper@oracle.com wrote: > > >On Thu, Oct 22, 2015 at 08:24:51PM +0200, casper@oracle.com wrote: > > > >> The external behaviour atomic; you cannot distinguish the order > >> between the closing of the original file (and waking up other threads >

[PATCH net-next] net: dsa: mv88e6xxx: remove debugfs interface

It is preferable to have a common debugfs interface for DSA or switchdev instead of a driver specific one. Thus remove the mv88e6xxx debug code. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx.c | 291

[PATCH net-next v5 0/2] mpls: multipath support

From: Roopa Prabhu This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'. - struct mpls_nh represents a mpls nexthop label forwarding entry - Adds

[PATCH net-next v5 1/2] mpls: multipath route support

From: Roopa Prabhu This patch adds support for MPLS multipath routes. Includes following changes to support multipath: - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' - 'struct mpls_nh' represents a mpls nexthop label forwarding entry - moves

[PATCH net-next v5 2/2] mpls: flow-based multipath selection

From: Robert Shearman Change the selection of a multipath route to use a flow-based hash. This more suitable for traffic sensitive to reordering within a flow (e.g. TCP, L2VPN) and whilst still allowing a good distribution of traffic given enough flows. Selection of the

[PATCH 2/2] e1000e: Fix msi-x interrupt automask

Since the introduction of 82574 support in e1000e, the driver has worked on the assumption that msi-x interrupt generation is automatically disabled after each irq. As it turns out, this is not the case. Currently, rx interrupts can fire multiple times before and during napi processing. This can

[PATCH 1/2] e1000e: remove unreachable code

msi-x interrupts are not shared so there's no need to check if the interrupt was really from this adapter. Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/intel/e1000e/netdev.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper

Fix safety checks for bpf_perf_event_read(): - only non-inherited events can be added to perf_event_array map (do this check statically at map insertion time) - dynamically check that event is local and !pmu->count Otherwise buggy bpf program can cause kernel splat. Also fix error path after

[PATCH 1/1] xen-netfront: limit max queues number to online cpus

Should not allocate queues number more than online cpus. Signed-off-by: Joe Jin Cc: Boris Ostrovsky Cc: Konrad Rzeszutek Wilk Cc: David S. Miller --- drivers/net/xen-netfront.c |2 +- 1 files

[net 2/2] i40e: fix annoying message

From: Jesse Brandeburg The driver was printing a message about not being able to assign VMDq because of a lack of MSI-X vectors. This was because a line was missing that initialized a variable, simply a merge error. Signed-off-by: Jesse Brandeburg

  1   2   3   >