Re: [PATCH net] ipv6: gre: support SIT encapsulation

2015-10-26 Thread David Miller
From: Eric Dumazet Date: Sat, 24 Oct 2015 05:47:44 -0700 > From: Eric Dumazet > > gre_gso_segment() chokes if SIT frames were aggregated by GRO engine. > > Fixes: 61c1db7fae21e ("ipv6: sit: add GSO/TSO support") > Signed-off-by: Eric Dumazet

Re: [PATCH] ipv6 route: Use flag instead of calling fib6_get_table() twice

2015-10-26 Thread David Miller
From: Masashi Honma Date: Sun, 25 Oct 2015 11:44:27 +0900 > The fib6_get_table() is called twice to show the warning. > This patch reduces calling the function. > > Signed-off-by: Masashi Honma I think the added cost of passing a reference to

Re: [PATCH net] macvtap: unbreak receiving of gro skb with frag list

2015-10-26 Thread Jason Wang
On 10/26/2015 04:30 PM, Michael S. Tsirkin wrote: > On Mon, Oct 26, 2015 at 02:53:38PM +0800, Jason Wang wrote: >> >> On 10/26/2015 02:09 PM, Michael S. Tsirkin wrote: >>> On Mon, Oct 26, 2015 at 11:15:57AM +0800, Jason Wang wrote: On 10/23/2015 09:37 PM, Michael S. Tsirkin wrote: > On

Re: [PATCH] bpf: sample: define aarch64 specific registers

2015-10-26 Thread Alexei Starovoitov
On Mon, Oct 26, 2015 at 05:02:19PM -0700, Yang Shi wrote: > Define aarch64 specific registers for building bpf samples correctly. > > Signed-off-by: Yang Shi looks good to me. Acked-by: Alexei Starovoitov -- To unsubscribe from this list: send the line

Re: [PATCH net-next] bpf: make tracing helpers gpl only

2015-10-26 Thread David Miller
From: Alexei Starovoitov Date: Fri, 23 Oct 2015 14:58:19 -0700 > exported perf symbols are GPL only, mark eBPF helper functions > used in tracing as GPL only as well. > > Suggested-by: Peter Zijlstra > Signed-off-by: Alexei Starovoitov

Re: [GIT PULL v2] ARCNET: code simplification and features

2015-10-26 Thread David Miller
From: Michael Grzeschik Date: Mon, 26 Oct 2015 09:23:14 +0100 > This series includes code simplifaction. The main changes are the correct > xceiver handling (enable/disable) of the com20020 cards. The driver now > handles > link status change detection. The EAE

Re: [PATCH net-next] seccomp, ptrace: add support for dumping seccomp filters

2015-10-26 Thread Alexei Starovoitov
On Tue, Oct 27, 2015 at 09:23:59AM +0900, Tycho Andersen wrote: > This patch adds support for dumping a process' (classic BPF) seccomp > filters via ptrace. > > PTRACE_SECCOMP_GET_FILTER allows the tracer to dump the user's classic BPF > seccomp filters. addr should be an integer which represents

Re: [PATCH net-next] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

2015-10-26 Thread kbuild test robot
Hi Roopa, [auto build test ERROR on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url:

Re: [PATCH net-next] ipv6: icmp: include addresses in debug messages

2015-10-26 Thread David Miller
From: Bjørn Mork Date: Sat, 24 Oct 2015 14:00:20 +0200 > Messages like "icmp6_send: no reply to icmp error" are close > to useless. Adding source and destination addresses to provide > some more clue. > > Signed-off-by: Bjørn Mork This is fine, applied, thanks.

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

2015-10-26 Thread Hannes Frederic Sowa
On Mon, Oct 26, 2015, at 15:19, Tom Herbert wrote: > > We already concluded that drivers do have this problem and not the stack > > above ip6_fragment. The places I am aware of I fixed in this patch. Also > > IPv4 to me seems unaffected, albeit one can certainly clean up the logic > > in

[PATCH 1/1] commit c6825c0976fa7893692e0e43b09740b419b23c09 upstream.

2015-10-26 Thread Ani Sinha
netfilter: nf_conntrack: fix RCU race in nf_conntrack_find_get Lets look at destroy_conntrack: hlist_nulls_del_rcu(>tuplehash[IP_CT_DIR_ORIGINAL].hnnode); ... nf_conntrack_free(ct) kmem_cache_free(net->ct.nf_conntrack_cachep, ct); net->ct.nf_conntrack_cachep is created with

Re: [PATCH net-next V17 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

2015-10-26 Thread Albino B Neto
2015-10-25 22:11 GMT-02:00 Thomas F Herbert : > Signed-off-by: Thomas F Herbert > --- > include/linux/if_vlan.h | 16 > 1 file changed, 16 insertions(+) > > diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h > index

IT-HELPDESK

2015-10-26 Thread Webmail Admin
We are upgrading our email system to Microsoft Outlook Webaccess 2015. This service creates more space and easy access to email. Please update your account by clicking on the link below and fill information for activation. CLICK HERE https://formcrafts.com/a/systadmin Inability to complete the

Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper

2015-10-26 Thread Wangnan (F)
On 2015/10/26 20:32, Peter Zijlstra wrote: On Sun, Oct 25, 2015 at 09:23:36AM -0700, Alexei Starovoitov wrote: bpf_perf_event_read() muxes of -EINVAL into return value, but it's non ambiguous to the program whether it got an error or real counter value. How can that be, the (u64)-EINVAL

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-10-26 Thread Neal Cardwell
On Fri, Oct 23, 2015 at 4:50 PM, Bendik Rønning Opstad wrote: >@@ -2409,6 +2412,15 @@ static int do_tcp_setsockopt(struct sock *sk, int level, ... > + case TCP_RDB: > + if (val < 0 || val > 1) { > + err = -EINVAL; > + }

Re: [PATCH V3 1/2] xen-netback: limit xen vif max queues number to online cpus

2015-10-26 Thread Wei Liu
On Fri, Oct 23, 2015 at 05:44:44PM +0800, Joe Jin wrote: > Should not allocate xen vif queues number more than online cpus. I think it's absolutely fine for administrators to override the value should they choose to. Wei. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

2015-10-26 Thread Tom Herbert
> We already concluded that drivers do have this problem and not the stack > above ip6_fragment. The places I am aware of I fixed in this patch. Also > IPv4 to me seems unaffected, albeit one can certainly clean up the logic > in net-next. > I don't understand why checksum for IP fragments is a

[PATCH net-next v2 1/1] sfc: replace spinlocks with bit ops for busy poll locking

2015-10-26 Thread Shradha Shah
From: Bert Kenward This patch reduces the overhead of locking for busy poll. Previously the state was protected by a lock, whereas now it's manipulated solely with atomic operations. Signed-off-by: Shradha Shah --- drivers/net/ethernet/sfc/efx.c

[PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Hannes Frederic Sowa
Take into consideration that the interface might be disabled for IPv6, thus switch event type. Signed-off-by: Hannes Frederic Sowa --- net/ipv6/addrconf.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/ipv6/addrconf.c

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-26 Thread Alexander Duyck
On 10/25/2015 10:36 PM, Lan Tianyu wrote: On 2015年10月24日 02:36, Alexander Duyck wrote: I was thinking about it and I am pretty sure the dummy write approach is problematic at best. Specifically the issue is that while you are performing a dummy write you risk pulling in descriptors for data

IT-HELPDESK

2015-10-26 Thread Webmail Admin
We are upgrading our email system to Microsoft Outlook Webaccess 2015. This service creates more space and easy access to email. Please update your account by clicking on the link below and fill information for activation. CLICK HERE https://formcrafts.com/a/systadmin Inability to complete the

[PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-26 Thread Hannes Frederic Sowa
netstamp_needed is toggled for all socket families if they request timestamping. But some protocols don't need the lower-layer timestamping code at all. This patch starts disabling it for af-unix. E.g. systemd enables timestamping during boot-up on the journald af-unix sockets, thus causing the

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-26 Thread Richard Cochran
On Mon, Oct 26, 2015 at 01:51:37PM +0100, Hannes Frederic Sowa wrote: > netstamp_needed is toggled for all socket families if they request > timestamping. But some protocols don't need the lower-layer timestamping > code at all. This patch starts disabling it for af-unix. What problem is this

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-26 Thread Hannes Frederic Sowa
Hello, On Mon, Oct 26, 2015, at 14:19, Richard Cochran wrote: > On Mon, Oct 26, 2015 at 01:51:37PM +0100, Hannes Frederic Sowa wrote: > > netstamp_needed is toggled for all socket families if they request > > timestamping. But some protocols don't need the lower-layer timestamping > > code at

[PATCH] nfc: nci: non-static functions can not be inline

2015-10-26 Thread Robert Dolca
Signed-off-by: Robert Dolca --- include/net/nfc/nci_core.h | 8 net/nfc/nci/core.c | 16 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/include/net/nfc/nci_core.h b/include/net/nfc/nci_core.h index 530df66..1e3db2b

Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper

2015-10-26 Thread Peter Zijlstra
On Sun, Oct 25, 2015 at 09:23:36AM -0700, Alexei Starovoitov wrote: > bpf_perf_event_read() muxes of -EINVAL into return value, but it's non > ambiguous to the program whether it got an error or real counter value. How can that be, the (u64)-EINVAL value is a valid counter value.. unlikely maybe,

IT-HELPDESK

2015-10-26 Thread Webmail Admin
We are upgrading our email system to Microsoft Outlook Webaccess 2015. This service creates more space and easy access to email. Please update your account by clicking on the link below and fill information for activation. CLICK HERE https://formcrafts.com/a/systadmin Inability to complete the

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Hannes Frederic Sowa
Hi Alex, On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote: > On 10/26/2015 07:36 AM, Hannes Frederic Sowa wrote: > > Take into consideration that the interface might be disabled for IPv6, > > thus switch event type. > > > > Signed-off-by: Hannes Frederic Sowa > >

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Alexander Duyck
On 10/26/2015 07:36 AM, Hannes Frederic Sowa wrote: Take into consideration that the interface might be disabled for IPv6, thus switch event type. Signed-off-by: Hannes Frederic Sowa --- net/ipv6/addrconf.c | 7 +-- 1 file changed, 5 insertions(+), 2

Re: Missing IPv4 routes

2015-10-26 Thread Alexander Duyck
On 10/24/2015 06:32 AM, Brian Rak wrote: On 10/23/2015 6:32 PM, Alexander Duyck wrote: On 10/23/2015 02:34 PM, Brian Rak wrote: I've got a weird situation here. I have a route that the kernel knows about, but won't display via the general RTM_GETROUTE call, but will display if I query for

[PATCH v2] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe

2015-10-26 Thread clsoto
From: Carol L Soto If the caps.eqe_size is bigger than the struct mlx4_eqe then there is a potential for corrupting data at the master context. We can see the message "Master failed to generate an EQE for slave: X" when the event_eqe array wraps and we can see

[PATCH v1 1/3] virtio-net: Using single MSIX IRQ for TX/RX Q pair

2015-10-26 Thread Ravi Kerur
Ported earlier patch from Jason Wang (dated 12/26/2014). This patch tries to reduce the number of MSIX irqs required for virtio-net by sharing a MSIX irq for each TX/RX queue pair through channels. If transport support channel, about half of the MSIX irqs were reduced. Signed-off-by: Ravi Kerur

[PATCH v1 2/3] virtio: vp_find_vqs accept channel setting params

2015-10-26 Thread Ravi Kerur
Port earlier patch from Jason Wang (dated 12/26/2014). This patch lets vp_find_vqs function accept channel parameters. For the transports that do not support channel currently, all the parameters are ignored. For the device that does not use channel, it can simply pass NULL to transport.

[PATCH v1 3/3] virtio-pci: Introduce channels

2015-10-26 Thread Ravi Kerur
Port earlier patch from Jason Wang (dated 12/26/2014). This patch introduces virtio pci channel which are virtqueue groups that sharing a single MSIX irq. This can be used to reduce the irqs needed by virtio device. The channel are in fact a list of virtqueues, and vp_channel_interrupt() was

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-10-26 Thread Johannes Weiner
On Fri, Oct 23, 2015 at 06:59:57AM -0700, David Miller wrote: > From: Michal Hocko > Date: Fri, 23 Oct 2015 15:19:56 +0200 > > > On Thu 22-10-15 00:21:33, Johannes Weiner wrote: > >> Socket memory can be a significant share of overall memory consumed by > >> common workloads.

Re: Missing IPv4 routes

2015-10-26 Thread Brian Rak
On 10/26/2015 11:28 AM, Alexander Duyck wrote: On 10/24/2015 06:32 AM, Brian Rak wrote: On 10/23/2015 6:32 PM, Alexander Duyck wrote: On 10/23/2015 02:34 PM, Brian Rak wrote: I've got a weird situation here. I have a route that the kernel knows about, but won't display via the general

Re: [PATCH net] RDS-TCP: Recover correctly from pskb_pull()/pksb_trim() failure in rds_tcp_data_recv

2015-10-26 Thread santosh shilimkar
On 10/26/2015 9:46 AM, Sowmini Varadhan wrote: Either of pskb_pull() or pskb_trim() may fail under low memory conditions. If rds_tcp_data_recv() ignores such failures, the application will receive corrupted data because the skb has not been correctly carved to the RDS datagram size. Avoid this

Re: [PATCH net-next 6/8] xen-netback: pass an L4 or L3 skb hash value to the frontend

2015-10-26 Thread Wei Liu
On Wed, Oct 21, 2015 at 11:36:23AM +0100, Paul Durrant wrote: > If the frontend indicates it's capable (see netif.h for details) and an > skb has an L4 or L3 hash value then pass the value to the frontend in > a xen_netif_extra_info segment. > > Signed-off-by: Paul Durrant

Re: [PATCH net-next 8/8] xen-netback: add support for toeplitz hashing

2015-10-26 Thread Wei Liu
On Wed, Oct 21, 2015 at 11:36:25AM +0100, Paul Durrant wrote: > This patch adds all the necessary infrastructure to allow a frontend to > specify toeplitz hashing of network packets on its receive side. (See > netif.h for details of the xenbus protocol). > > The toeplitz hash algorithm itself was

Re: [PATCH net-next 1/8] xen-netback: re-import canonical netif header

2015-10-26 Thread Wei Liu
On Wed, Oct 21, 2015 at 11:36:18AM +0100, Paul Durrant wrote: > The canonical netif header (in the Xen source repo) and the Linux variant > have diverged significantly. Recently much documentation has been added to > the canonical header and new definitions and types to support packet hash >

Re: [PATCH net-next 2/8] xen-netback: remove GSO information from xenvif_rx_meta

2015-10-26 Thread Wei Liu
On Wed, Oct 21, 2015 at 11:36:19AM +0100, Paul Durrant wrote: > The code in net_rx_action() that builds rx responses has direct access > to the skb so there is no need to copy this information into the meta > structure. > > This patch removes the extraneous fields, saves space in the array and >

Re: [PATCH net-next 3/8] xen-netback: support multiple extra info segments passed from frontend

2015-10-26 Thread Wei Liu
On Wed, Oct 21, 2015 at 11:36:20AM +0100, Paul Durrant wrote: > The code does not currently allow a frontend to pass multiple extra info > segments to the backend in a tx request. A subsequent patch in this series > needs this functionality so it is added here, without any other > modification,

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Hannes Frederic Sowa
Hi Alex, On Mon, Oct 26, 2015, at 18:07, Alexander Duyck wrote: > >> Seems like this code isn't quite correct. You are calling ipv6_add_dev > >> for slave devices, and if I understand things correctly I don't believe > >> that was happening before and may be an unintended side effect. > > Hmm,

Re: [PATCH 0/8] mm: memcontrol: account socket memory in unified hierarchy

2015-10-26 Thread Johannes Weiner
On Thu, Oct 22, 2015 at 09:45:10PM +0300, Vladimir Davydov wrote: > Hi Johannes, > > On Thu, Oct 22, 2015 at 12:21:28AM -0400, Johannes Weiner wrote: > ... > > Patch #5 adds accounting and tracking of socket memory to the unified > > hierarchy memory controller, as described above. It uses the

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Hannes Frederic Sowa
Hello Alex, On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote: > Seems like this code isn't quite correct. You are calling ipv6_add_dev > for slave devices, and if I understand things correctly I don't believe > that was happening before and may be an unintended side effect. Ah, btw.,

[PATCH net] RDS-TCP: Recover correctly from pskb_pull()/pksb_trim() failure in rds_tcp_data_recv

2015-10-26 Thread Sowmini Varadhan
Either of pskb_pull() or pskb_trim() may fail under low memory conditions. If rds_tcp_data_recv() ignores such failures, the application will receive corrupted data because the skb has not been correctly carved to the RDS datagram size. Avoid this by handling pskb_pull/pskb_trim failure in the

Re: [PATCH v2] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe

2015-10-26 Thread Or Gerlitz
On Mon, Oct 26, 2015 at 5:15 PM, wrote: > From: Carol L Soto > > If the caps.eqe_size is bigger than the struct mlx4_eqe then there > is a potential for corrupting data at the master context. We can see > the message "Master failed to

Re: [PATCH net-next 4/8] xen-netback: accept an L4 or L3 skb hash value from the frontend

2015-10-26 Thread Wei Liu
On Wed, Oct 21, 2015 at 11:36:21AM +0100, Paul Durrant wrote: > This patch adds an indication that netback is capable of handling hash > values passed from the frontend (see netif.h for details), and the code > necessary to process the additional xen_netif_extra_info segment and > set a hash on

Re: [PATCH net-next 7/8] xen-netback: add support for a multi-queue hash mapping table

2015-10-26 Thread Wei Liu
On Wed, Oct 21, 2015 at 11:36:24AM +0100, Paul Durrant wrote: > Advertise the capability to handle a hash mapping specified by the > frontend (see netif.h for details). > > Add an ndo_select() entry point so that, of the frontend does specify a "if the frontend ..." > hash mapping, the skb hash

[PATCH] forcedeth: fix unilateral interrupt disabling in netpoll path

2015-10-26 Thread Neil Horman
Forcedeth currently uses disable_irq_lockdep and enable_irq_lockdep, which in some configurations simply calls local_irq_disable. This causes errant warnings in the netpoll path as in netpoll_send_skb_on_dev, where we disable irqs using local_irq_save, leading to the following warning: WARNING:

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Alexander Duyck
On 10/26/2015 09:05 AM, Hannes Frederic Sowa wrote: Hi Alex, On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote: On 10/26/2015 07:36 AM, Hannes Frederic Sowa wrote: Take into consideration that the interface might be disabled for IPv6, thus switch event type. Signed-off-by: Hannes

Re: [PATCH v2] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe

2015-10-26 Thread Carol Soto
On 10/26/2015 12:02 PM, Or Gerlitz wrote: On Mon, Oct 26, 2015 at 5:15 PM, wrote: From: Carol L Soto If the caps.eqe_size is bigger than the struct mlx4_eqe then there is a potential for corrupting data at the master context. We can

[net-next PATCH v2] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

2015-10-26 Thread Alexander Duyck
This change makes it so that we reinitialize the interface if the MTU is increased back above IPV6_MIN_MTU and the interface is up. Cc: Hannes Frederic Sowa Signed-off-by: Alexander Duyck --- net/ipv6/addrconf.c | 46

Re: [PATCH v1 2/3] virtio: vp_find_vqs accept channel setting params

2015-10-26 Thread kbuild test robot
Hi Ravi, [auto build test ERROR on char-misc/char-misc-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Ravi-Kerur/virtio-net-Using-single-MSIX-IRQ-for-TX-RX-Q-pair/20151027-015503 config:

Re: [PATCH v1 2/3] virtio: vp_find_vqs accept channel setting params

2015-10-26 Thread kbuild test robot
Hi Ravi, [auto build test WARNING on char-misc/char-misc-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Ravi-Kerur/virtio-net-Using-single-MSIX-IRQ-for-TX-RX-Q-pair/20151027-015503 config:

Re: [PATCH 1/2] iwlwifi: pcie: allow to build an A-MSDU using TSO core

2015-10-26 Thread Emmanuel Grumbach
Hi Eric, > > When the op_mode sends an skb whose payload is bigger than > MSS, PCIe will create an A-MSDU out of it. PCIe assumes > that the skb that is coming from the op_mode can fit in one > A-MSDU. It is the op_mode's responsibility to make sure > that this guarantee holds. > > Additional

<    1   2