[PATCH v2 3/6] net: dsa: cleanup resources upon module removal

2015-10-29 Thread Neil Armstrong
Make sure that we unassign the master_netdev dsa_ptr to make the packet processing go through the regulard Ethernet receive path. Suggested-by: Florian Fainelli Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 8 1 file changed, 8

Re: [PATCH v2 5/6] net: dsa: add missing calls in dsa_switch_destroy

2015-10-29 Thread Neil Armstrong
On 10/29/2015 03:00 PM, Andrew Lunn wrote: > On Thu, Oct 29, 2015 at 02:23:25PM +0100, Neil Armstrong wrote: >> >> +netif_carrier_off(ds->ports[port]); >> unregister_netdev(ds->ports[port]); >> +phy_disconnect(p->phy); >>

[PATCH v2 4/6] net: dsa: Add missing master netdev dev_put() calls

2015-10-29 Thread Neil Armstrong
Upon probe failure or unbinding, add missing dev_put() calls on master netdev. Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index b2f696c..597a462 100644 ---

[PATCH v2 6/6] net: dsa: move dsa slave destroy code to slave.c

2015-10-29 Thread Neil Armstrong
Move dsa slave dedicated code from dsa_switch_destroy to a new dsa_slave_destroy function in slave.c Signed-off-by: Frode Isaksen Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 5 + net/dsa/dsa_priv.h | 1 + net/dsa/slave.c| 10

[PATCH v2 5/6] net: dsa: add missing calls in dsa_switch_destroy

2015-10-29 Thread Neil Armstrong
Add missing netif_carrier_off and phy_disconnect calls to the dsa_switch_destroy function to make sure the netdev and phy ressources are clean before complete removal. Signed-off-by: Frode Isaksen Signed-off-by: Neil Armstrong --- net/dsa/dsa.c |

Re: [PATCHv2] xfrm: dst_entries_init() per-net dst_ops

2015-10-29 Thread Dan Streetman
/commits/Dan-Streetman/xfrm-dst_entries_init-per-net-dst_ops/20151029-193245 > config: x86_64-randconfig-x019-201543 (attached as .config) > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > All warnings (new ones prefixed by &g

[PATCH net-next v2 4/5] bpf: add support for persistent maps/progs

2015-10-29 Thread Daniel Borkmann
This work adds support for "persistent" eBPF maps/programs. The term "persistent" is to be understood that maps/programs have a facility that lets them survive process termination. This is desired by various eBPF subsystem users. Just to name one example: tc classifier/action. Whenever tc parses

[PATCH net-next v2 3/5] bpf: consolidate bpf_prog_put{,_rcu} dismantle paths

2015-10-29 Thread Daniel Borkmann
We currently have duplicated cleanup code in bpf_prog_put() and bpf_prog_put_rcu() cleanup paths. Back then we decided that it was not worth it to make it a common helper called by both, but with the recent addition of resource charging, we could have avoided the fix in commit ac00737f4e81 ("bpf:

[PATCH net-next v2 1/5] bpf: abstract anon_inode_getfd invocations

2015-10-29 Thread Daniel Borkmann
Since we're going to use anon_inode_getfd() invocations in more than just the current places, make a helper function for both, so that we only need to pass a map/prog pointer to the helper itself in order to get a fd. The new helpers are called bpf_map_new_fd() and bpf_prog_new_fd().

[PATCH net-next v2 0/5] BPF updates

2015-10-29 Thread Daniel Borkmann
This set adds support for persistent maps/progs. Please see individual patches for further details. A man-page update to bpf(2) will be sent later on, also a iproute2 patch for support in tc. Thanks! v1 -> v2: - Reworked most of patch 4 and 5 - Rebased to latest net-next Daniel Borkmann

[PATCH net-next v2 2/5] bpf: align and clean bpf_{map,prog}_get helpers

2015-10-29 Thread Daniel Borkmann
Add a bpf_map_get() function that we're going to use later on and align/clean the remaining helpers a bit so that we have them a bit more consistent: - __bpf_map_get() and __bpf_prog_get() that both work on the fd struct, check whether the descriptor is eBPF and return the pointer to

Re: [PATCH v2 5/6] net: dsa: add missing calls in dsa_switch_destroy

2015-10-29 Thread kbuild test robot
Hi Neil, [auto build test ERROR on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Neil-Armstrong/Further-fix-for-dsa-unbinding/20151029-212633 config: x86_64-randconfig-x010-201543 (attached

Re: [PATCH net 2/2] ipv6: protect mtu calculation of wrap-around and infinite loop by rounding issues

2015-10-29 Thread David Miller
From: Hannes Frederic Sowa Date: Wed, 28 Oct 2015 13:21:04 +0100 > Raw sockets with hdrincl enabled can insert ipv6 extension headers > right into the data stream. In case we need to fragment those packets, > we reparse the options header to find the place where we

Re: [PATCH net 1/2] Revert "Merge branch 'ipv6-overflow-arith'"

2015-10-29 Thread David Miller
From: Hannes Frederic Sowa Date: Wed, 28 Oct 2015 13:21:03 +0100 > Linus dislikes these changes. To not hold up the net-merge let's revert > it for now and fix the bug like Linus suggested. > > This reverts commit ec3661b42257d9a06cf0d318175623ac7a660113, reversing >

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Neil Armstrong
On 10/29/2015 02:51 PM, Andrew Lunn wrote: > On Thu, Oct 29, 2015 at 02:22:41PM +0100, Neil Armstrong wrote: > Hi Neil, Frode > > I assume you have see: > > http://permalink.gmane.org/gmane.linux.network/380777 > > which is now in net-next. > > The only driver making use of poll_link is

[iproute PATCH] Confirm success for each tc -batch command

2015-10-29 Thread Phil Sutter
If `tc -force -batch' is fed by a controlling program from a pipe, it's not possible to recognize when a command has been processes successfully. This patch adds an optional `-OK' option to the tc(8) tool, so `tc -force -OK -batch' will print "OK\n" to standard output on each successfully

Re: [PATCH v2 5/6] net: dsa: add missing calls in dsa_switch_destroy

2015-10-29 Thread Andrew Lunn
On Thu, Oct 29, 2015 at 02:23:25PM +0100, Neil Armstrong wrote: > Add missing netif_carrier_off and phy_disconnect calls to the > dsa_switch_destroy function to make sure the netdev and phy > ressources are clean before complete removal. > > Signed-off-by: Frode Isaksen >

[PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Neil Armstrong
Simplifies the code and avoids a crash when removing the module: dsa dsa ethmv2 (unregistering): Link is Down device eth1 left promiscuous mode Unable to handle kernel paging request at virtual address bacc5cf6 ... (run_timer_softirq) from [] (__do_softirq+0xcc/0x320) (__do_softirq) from []

[PATCHv2] xfrm: dst_entries_init() per-net dst_ops

2015-10-29 Thread Dan Streetman
Remove the dst_entries_init/destroy calls for xfrm4 and xfrm6 dst_ops templates; their dst_entries counters will never be used. Move the xfrm dst_ops initialization from the common xfrm/xfrm_policy.c to xfrm4/xfrm4_policy.c and xfrm6/xfrm6_policy.c, and call dst_entries_init and

Re: [PATCHv2] xfrm: dst_entries_init() per-net dst_ops

2015-10-29 Thread kbuild test robot
Hi Dan, [auto build test WARNING on ipsec/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Dan-Streetman/xfrm-dst_entries_init-per-net-dst_ops/20151029-193245 config: x86_64-randconfig-x019-201543

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread Eric Dumazet
On Thu, 2015-10-29 at 05:35 -0700, Eric Dumazet wrote: > Current kernel : > > 64.98% [kernel] [k] queued_spin_lock_slowpath > 14.88% opensock [.] memset// this part simulates user land > actual work ;) > 11.15% [kernel] [k]

[PATCH] VSOCK: define VSOCK_SS_LISTEN once only

2015-10-29 Thread Stefan Hajnoczi
The SS_LISTEN socket state is defined by both af_vsock.c and vmci_transport.c. This is risky since the value could be changed in one file and the other would be out of sync. Rename from SS_LISTEN to VSOCK_SS_LISTEN since the constant is not part of enum socket_state (SS_CONNECTED, ...). This

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread Eric Dumazet
On Thu, 2015-10-29 at 04:16 +, Al Viro wrote: > Have you tried to experiment with that in userland? I mean, emulate that > thing in normal userland code, count the cacheline accesses and drive it > with the use patterns collected from actual applications. Sure. > > I can sit down and play

[PATCH v2 0/6] Further fix for dsa unbinding

2015-10-29 Thread Neil Armstrong
This serie fixes further issues for DSA dynamic unbinding. Frode Isaksen's patches make usage of delayed work and fixes kernel crashes when dsa is unbind. The other patches are simple fixes to permit cleanup and avoid netdev related crashes. v2: remove phy fix and add missing calls in

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Andrew Lunn
On Thu, Oct 29, 2015 at 02:22:41PM +0100, Neil Armstrong wrote: > Simplifies the code and avoids a crash when removing the > module: > dsa dsa ethmv2 (unregistering): Link is Down > device eth1 left promiscuous mode > Unable to handle kernel paging request at virtual address bacc5cf6 > ... >

[PATCHv3] xfrm: dst_entries_init() per-net dst_ops

2015-10-29 Thread Dan Streetman
Remove the dst_entries_init/destroy calls for xfrm4 and xfrm6 dst_ops templates; their dst_entries counters will never be used. Move the xfrm dst_ops initialization from the common xfrm/xfrm_policy.c to xfrm4/xfrm4_policy.c and xfrm6/xfrm6_policy.c, and call dst_entries_init and

[PATCH net-next v2 5/5] bpf: add sample usages for persistent maps/progs

2015-10-29 Thread Daniel Borkmann
This patch adds a couple of stand-alone examples on how BPF_OBJ_PIN and BPF_OBJ_GET commands can be used. Example with maps: # ./fds_example -F /sys/fs/bpf/m -P -m -k 1 -v 42 bpf: map fd:3 (Success) bpf: pin ret:(0,Success) bpf: fd:3 u->(1:42) ret:(0,Success) # ./fds_example -F

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Eric Dumazet
On Wed, 2015-10-28 at 18:39 +0100, Paolo Abeni wrote: > This patch changes how the multipath hash is computed for locally > generated UDP or TCP flows: now the hash comprises also l4 information > (source and destination port). > > This allows better utilization of the available paths when the

[RFC PATCH v3 1/5] net: dsa: allow switch drivers to cleanup their resources

2015-10-29 Thread Neil Armstrong
Some switch drivers might request interrupts, remap register ranges, allow such drivers to implement a "remove" callback doing just that. Signed-off-by: Florian Fainelli Signed-off-by: Neil Armstrong --- include/net/dsa.h | 1 + net/dsa/dsa.c

[RFC PATCH v3 0/5] net: dsa: cleanup dsa driver

2015-10-29 Thread Neil Armstrong
Introduce a new remove callback to allow DSA drivers to cleanup their ressources. Then add a remove implementation for bcm_sf2 and mv88e6xxx. This patch was not tested due of a lack of hardware. v2: add remove callback patch to the serie v3: separate & fix ppu remove callback into a proper patch

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-10-29 Thread Michal Hocko
On Tue 27-10-15 09:42:27, Johannes Weiner wrote: > On Tue, Oct 27, 2015 at 05:15:54PM +0100, Michal Hocko wrote: > > On Tue 27-10-15 11:41:38, Johannes Weiner wrote: [...] > Or it could be exactly the other way around when you have a workload > that is heavy on filesystem metadata. I don't see why

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-29 Thread Alexander Duyck
On 10/29/2015 01:33 AM, Lan Tianyu wrote: On 2015年10月29日 14:58, Alexander Duyck wrote: Your code was having to do a bunch of shuffling in order to get things set up so that you could bring the interface back up. I would argue that it may actually be faster at least on the bring-up to just drop

[iproute PATCH] lib/utils: improve error messages of get_addr() and get_prefix()

2015-10-29 Thread Phil Sutter
Instead of statically complaining about illegal inet address, use get_family() to get the address family right. Based on a patch by Hangbin Liu to print "inet6" for AF_INET6 made more generic by me. Signed-off-by: Phil Sutter --- lib/utils.c | 6 -- 1 file changed, 4

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread Alan Burlison
On 29/10/2015 14:58, David Holland wrote: ISTM that the best way to do this is to post a signal to the thread so accept bails with EINTR, at which point it can check to see if it's supposed to be exiting. Yes, you could use pthread_kill, but that would require keeping a list of the tids of

Re: [RFC PATCH v3 2/5] net: dsa: bcm_sf2: cleanup resources in remove callback

2015-10-29 Thread Andrew Lunn
On Thu, Oct 29, 2015 at 03:45:30PM +0100, Neil Armstrong wrote: > Implement a remove callback allowing the switch driver to cleanup > resources it used: interrupts and remapped register ranges. > > Signed-off-by: Florian Fainelli > Signed-off-by: Neil Armstrong

Re: [V5, 2/6] fsl/fman: Add FMan support

2015-10-29 Thread Scott Wood
On Thu, 2015-10-29 at 10:22 -0500, Liberman Igal-B31950 wrote: > Regards, > Igal Liberman > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Wednesday, October 28, 2015 11:31 PM > > To: Liberman Igal-B31950 > > Cc: netdev@vger.kernel.org;

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread David Holland
On Thu, Oct 29, 2015 at 03:18:40PM +, Alan Burlison wrote: > On 29/10/2015 14:58, David Holland wrote: > >ISTM that the best way to do this is to post a signal to the thread so > >accept bails with EINTR, at which point it can check to see if it's > >supposed to be exiting. > > Yes, you

[RFC PATCH v3 2/5] net: dsa: bcm_sf2: cleanup resources in remove callback

2015-10-29 Thread Neil Armstrong
Implement a remove callback allowing the switch driver to cleanup resources it used: interrupts and remapped register ranges. Signed-off-by: Florian Fainelli Signed-off-by: Neil Armstrong --- drivers/net/dsa/bcm_sf2.c | 20 1

[RFC PATCH v3 5/5] net: dsa: add mv88e6xxx ppu remove function for mv88e6131

2015-10-29 Thread Neil Armstrong
The mv88e6131 also need to call remove for the ppu part of mv88e6xxx. Add the ppu remove function and add a mv88e6131 specific remove callback calling the ppu remove function. Signed-off-by: Neil Armstrong --- drivers/net/dsa/mv88e6131.c | 9 -

[RFC PATCH v3 4/5] net: dsa: make usage of mv88e6xxx common remove function

2015-10-29 Thread Neil Armstrong
Make usage of previously introduced mv88e6xxx common remove function in all mv88e6xxx drivers. Signed-off-by: Neil Armstrong --- drivers/net/dsa/mv88e6123_61_65.c | 1 + drivers/net/dsa/mv88e6131.c | 1 + drivers/net/dsa/mv88e6171.c | 1 +

[GIT] Networking

2015-10-29 Thread David Miller
This is the same as the previous pull request, with the ipv6 overflow fix redone. The merge conflict is therefore gone too. 1) Fix two regressions in ipv6 route lookups, particularly wrt. output interface specifications in the lookup key. From David Ahern. 2) Fix checks in ipv6 IPSEC

[PATCH net-next RFC] mpls: support for dead routes

2015-10-29 Thread Roopa Prabhu
From: Roopa Prabhu Adds support for both RTNH_F_DEAD and RTNH_F_LINKDOWN flags. This resembles ipv4 fib code. I also picked fib_rebalance from ipv4. Enabled weights support for nexthop, just because the infrastructure is already there. Signed-off-by: Roopa Prabhu

[RFC PATCH v3 3/5] net: dsa: mv88e6xxx: add common remove function

2015-10-29 Thread Neil Armstrong
With the previously introduced remove callback, add a mv88e6xxx common remove function to cleanup all resources. Signed-off-by: Neil Armstrong --- drivers/net/dsa/mv88e6xxx.c | 8 drivers/net/dsa/mv88e6xxx.h | 1 + 2 files changed, 9 insertions(+) diff --git

Re: [RFC PATCH v3 1/5] net: dsa: allow switch drivers to cleanup their resources

2015-10-29 Thread Neil Armstrong
On 10/29/2015 03:50 PM, Andrew Lunn wrote: > On Thu, Oct 29, 2015 at 03:45:24PM +0100, Neil Armstrong wrote: >> --- a/net/dsa/dsa.c >> +++ b/net/dsa/dsa.c >> @@ -459,6 +459,10 @@ static void dsa_switch_destroy(struct dsa_switch *ds) >> } >> >> mdiobus_unregister(ds->slave_mii_bus); >> +

RE: [V5, 2/6] fsl/fman: Add FMan support

2015-10-29 Thread Liberman Igal
Regards, Igal Liberman > -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, October 28, 2015 11:31 PM > To: Liberman Igal-B31950 > Cc: netdev@vger.kernel.org; linuxppc-...@lists.ozlabs.org; linux- > ker...@vger.kernel.org; Bucur

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-10-29 Thread Johannes Weiner
On Thu, Oct 29, 2015 at 04:25:46PM +0100, Michal Hocko wrote: > On Tue 27-10-15 09:42:27, Johannes Weiner wrote: > > On Tue, Oct 27, 2015 at 05:15:54PM +0100, Michal Hocko wrote: > > > On Tue 27-10-15 11:41:38, Johannes Weiner wrote: > > > > IMO that's an implementation detail and a historical

[PATCH net-next] net: dsa: use switchdev obj for VLAN add/del ops

2015-10-29 Thread Vivien Didelot
Simplify DSA by pushing the switchdev objects for VLAN add and delete operations down to its drivers. Currently only mv88e6xxx is affected. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6171.c | 2 +- drivers/net/dsa/mv88e6352.c | 2 +-

Re: BUG: fsl FEC ethernet tx checksum offloading doesn't work with RMII interface

2015-10-29 Thread Fabio Estevam
On Wed, Oct 28, 2015 at 10:36 AM, David Jander wrote: > I can search further down, but 4.1 is also broken. > Are there specific changes or versions you are suspicious of? I was just trying to understand if this was a regression or if it has always been broken. -- To

[BUG] Any-IP IPv6 support broken

2015-10-29 Thread Gilberto Bertin
Hello, testing Any-IP on my machine, I noticed that it's not working with IPv6 addresses. Tests are performed on a 4.1 kernel. Steps to reproduce the bug: 1- make sure Any-IP is working with IPv4 addresses: # ip -4 route add local 4.4.4.0/24 dev eth0 with this command every packets with an IP

RE: [V5, 2/6] fsl/fman: Add FMan support

2015-10-29 Thread Liberman Igal
Regards, Igal Liberman > -Original Message- > From: Wood Scott-B07421 > Sent: Thursday, October 29, 2015 5:25 PM > To: Liberman Igal-B31950 > Cc: netdev@vger.kernel.org; linuxppc-...@lists.ozlabs.org; linux- > ker...@vger.kernel.org; Bucur

Re: [RFC PATCH v3 1/5] net: dsa: allow switch drivers to cleanup their resources

2015-10-29 Thread Andrew Lunn
On Thu, Oct 29, 2015 at 03:45:24PM +0100, Neil Armstrong wrote: > Some switch drivers might request interrupts, remap register ranges, > allow such drivers to implement a "remove" callback doing just that. > > Signed-off-by: Florian Fainelli > Signed-off-by: Neil Armstrong

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread David Holland
On Tue, Oct 27, 2015 at 10:52:46AM +, Alan Burlison wrote: > >But in general, this is basically a problem with the application: the file > >descriptor space is shared between threads and having one thread sniping > >at open files, you do have a problem and whatever the kernel does in that

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Andrew Lunn
> Is 6060 supported by the 6352 family? It doesn't share any mv88e6xxx > code... It is a totally separate driver. Nothing shared at all.. It is an old device, and only does 10/100. It could be it is just too different to support via mv88e6xxx. Andrew -- To unsubscribe from this list: send

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread Alan Burlison
On 29/10/2015 16:01, David Holland wrote: Hardly; it moves the burden of doing stupid things to the application. If as you said the goal is to shut down all threads cleanly, then it doesn't need to keep track in detail anyway; it can just post SIGTERM to every thread, or SIGUSR1 if SIGTERM is

[iproute PATCH v2] lib/utils: improve error messages of get_addr() and get_prefix()

2015-10-29 Thread Phil Sutter
Instead of statically complaining about illegal inet address, use get_family() to get the address family right. Based on a patch by Hangbin Liu to print "inet6" for AF_INET6 made more generic by me. Signed-off-by: Phil Sutter --- Changes since v1: - Rebased this patch on top of

Re: [RFC] unix: fix use-after-free in unix_dgram_poll()

2015-10-29 Thread Rainer Weikusat
Jason Baron writes: > On 10/28/2015 12:46 PM, Rainer Weikusat wrote: >> Rainer Weikusat writes: >>> Jason Baron writes: [...] >> and the not-so-nice additional property that the connect and >> disconnect

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Andrew Lunn
> Thanks for the hint, I will test this, but while reviewing the datasheet, > the port 5 has no PHY, so must only be used as cpu port. Not necessarily. All that is needed is an external phy. Linux does not care what MDIO bus that phy hangs off. It could be the same MDIO bus as the switch, or some

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Paolo Abeni
On Thu, 2015-10-29 at 07:31 -0700, Eric Dumazet wrote: > On Wed, 2015-10-28 at 18:39 +0100, Paolo Abeni wrote: > > This patch changes how the multipath hash is computed for locally > > generated UDP or TCP flows: now the hash comprises also l4 information > > (source and destination port). > > >

Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-29 Thread Vivien Didelot
On Oct. Thursday 29 (44) 03:40 PM, Andrew Lunn wrote: > > Thanks for the hint, I will test this, but while reviewing the datasheet, > > the port 5 has no PHY, so must only be used as cpu port. > > Not necessarily. All that is needed is an external phy. Linux does not > care what MDIO bus that phy

dynamically set number of queues for 82598 devices

2015-10-29 Thread William Dauchy
Hello David, I faced the problem described in commit 7e3f5c8: ixgbe: fix bounds checking in ixgbe_setup_tc for 82598 This patch resolves an issue where users were not able to dynamically set number of queues for 82598 via ethtool -L I backported it for my v4.1.x build but I was wondering if

Re: [BUG] Any-IP IPv6 support broken

2015-10-29 Thread Eric Dumazet
On Thu, 2015-10-29 at 15:00 +, Gilberto Bertin wrote: > Hello, > testing Any-IP on my machine, I noticed that it's not working with IPv6 > addresses. > Tests are performed on a 4.1 kernel. > > Steps to reproduce the bug: > > 1- make sure Any-IP is working with IPv4 addresses: > > # ip -4

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Eric Dumazet
On Thu, 2015-10-29 at 16:00 +0100, Paolo Abeni wrote: > This patch do not add dissection code: it use the information provided > by the available flowi4 structure. Moreover the skb is not available on > the calling site (in __ip_route_output_key_hash) and pushing it all the > way will require a

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Tom Herbert
On Thu, Oct 29, 2015 at 8:00 AM, Paolo Abeni wrote: > On Thu, 2015-10-29 at 07:31 -0700, Eric Dumazet wrote: >> On Wed, 2015-10-28 at 18:39 +0100, Paolo Abeni wrote: >> > This patch changes how the multipath hash is computed for locally >> > generated UDP or TCP flows: now the

[PATCH v4] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-10-29 Thread Mans Rullgard
This adds a driver for the Aurora VLSI NB8800 Ethernet controller. It is an almost complete rewrite of a driver originally found in a Sigma Designs 2.6.22 tree. Signed-off-by: Mans Rullgard --- Changes: - Make ethtool_ops const - Fix race in tx path on smp systems - Use different

Re: [PATCH 0/8] mm: memcontrol: account socket memory in unified hierarchy

2015-10-29 Thread Johannes Weiner
On Thu, Oct 29, 2015 at 12:27:47PM +0300, Vladimir Davydov wrote: > On Wed, Oct 28, 2015 at 11:58:10AM -0700, Johannes Weiner wrote: > > Having the hard limit as a failsafe (or a minimum for other consumers) > > is one thing, and certainly something I'm open to for cgroupv2, should > > we have

Re: [PATCH net-next RFC] mpls: support for dead routes

2015-10-29 Thread Robert Shearman
On 29/10/15 15:49, Roopa Prabhu wrote: From: Roopa Prabhu Adds support for both RTNH_F_DEAD and RTNH_F_LINKDOWN flags. This resembles ipv4 fib code. I also picked fib_rebalance from ipv4. Enabled weights support for nexthop, just because the infrastructure is already

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread Alan Burlison
[off list] On 29/10/2015 17:07, Al Viro wrote: Could the esteemed sir possibly be ars^H^H^Hprevailed upon to quote the exact place in POSIX that requires such behaviour? If that's the way the conversation is going to go, sorry, no. -- Alan Burlison -- -- To unsubscribe from this list: send

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Paolo Abeni
On Thu, 2015-10-29 at 08:28 -0700, Eric Dumazet wrote: > On Thu, 2015-10-29 at 16:00 +0100, Paolo Abeni wrote: > > > This patch do not add dissection code: it use the information provided > > by the available flowi4 structure. Moreover the skb is not available on > > the calling site (in

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-29 Thread Al Viro
On Thu, Oct 29, 2015 at 04:15:33PM +, Alan Burlison wrote: > There was an attempt to interpret POSIX that way, with which I still > disagree. If a FD is closed or reassigned then any current pending > operations on it should be terminated. Could the esteemed sir possibly be

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Eric Dumazet
On Thu, 2015-10-29 at 17:52 +0100, Paolo Abeni wrote: > On Thu, 2015-10-29 at 08:28 -0700, Eric Dumazet wrote: > > On Thu, 2015-10-29 at 16:00 +0100, Paolo Abeni wrote: > > > > > This patch do not add dissection code: it use the information provided > > > by the available flowi4 structure.

Re: [BUG] Any-IP IPv6 support broken

2015-10-29 Thread Gilberto Bertin
> On 29 Oct 2015, at 18:39, Hannes Frederic Sowa > wrote: > > Try the loopback interface: > > ip -6 route add local abcd:abcd:abcd:abcd::/64 dev *lo* > > Otherwise packets should end up in neighbor subsystem and you don't want > that, still. ;) > Thanks for the

Re: [PATCH 0/2] sh_eth: RX buffer alignment fixes

2015-10-29 Thread Sergei Shtylyov
Hello. On 10/27/2015 04:32 AM, David Miller wrote: Here's a set of 2 patches against DaveM's 'net.git' repo which are the fixes to the RX buffer size calculation. [1/2] sh_eth: fix RX buffer size alignment [2/2] sh_eth: fix RX buffer size calculation Series applied, thanks. Will

pull-request: wireless-drivers-next 2015-10-29

2015-10-29 Thread Kalle Valo
Hi Dave, here's hopefully my last pull request for 4.4. ssb had a new Kconfig entry and that's why this touches arch/mips/bcm47xx/Kconfig. ssb also did some code shuffling and moved code from b43 to ssb subsystem. Otherwise should be business as usual. While writing this I noticed that Fengwei

Re: [BUG] Any-IP IPv6 support broken

2015-10-29 Thread Hannes Frederic Sowa
Hello, On Thu, Oct 29, 2015, at 16:00, Gilberto Bertin wrote: > 2- note that it's not actually working with IPv6 addresses: > > # ip -6 route add local abcd:abcd:abcd:abcd::/64 dev eth0 Try the loopback interface: ip -6 route add local abcd:abcd:abcd:abcd::/64 dev *lo* Otherwise packets

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2015-10-29 Thread Haiyang Zhang
> -Original Message- > From: Richard Weinberger [mailto:richard.weinber...@gmail.com] > Sent: Tuesday, October 27, 2015 6:36 PM > To: David Miller > Cc: Haiyang Zhang ; o...@aepfle.de; Greg Kroah- > Hartman ;

Re: [BUG] Any-IP IPv6 support broken

2015-10-29 Thread Hannes Frederic Sowa
On Thu, Oct 29, 2015, at 19:58, Gilberto Bertin wrote: > > > On 29 Oct 2015, at 18:39, Hannes Frederic Sowa > > wrote: > > > > Try the loopback interface: > > > > ip -6 route add local abcd:abcd:abcd:abcd::/64 dev *lo* > > > > Otherwise packets should end up in

Re: [PATCH net-next RFC] mpls: support for dead routes

2015-10-29 Thread roopa
On 10/29/15, 9:53 AM, Robert Shearman wrote: > On 29/10/15 15:49, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Adds support for both RTNH_F_DEAD and RTNH_F_LINKDOWN flags. >> This resembles ipv4 fib code. I also picked fib_rebalance from >> ipv4. Enabled weights

Re: [PATCH net-next] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Paolo Abeni
On Thu, 2015-10-29 at 11:43 -0700, Eric Dumazet wrote: > On Thu, 2015-10-29 at 17:52 +0100, Paolo Abeni wrote: > > On Thu, 2015-10-29 at 08:28 -0700, Eric Dumazet wrote: > > > On Thu, 2015-10-29 at 16:00 +0100, Paolo Abeni wrote: > > > > > > > This patch do not add dissection code: it use the

Re: [PATCHv2 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event

2015-10-29 Thread Julian Anastasov
Hello, On Tue, 27 Oct 2015, Andy Gospodarek wrote: > > Of course, we have a semantic problem when setting > > RTNH_F_LINKDOWN on last address removal, i.e. this event > > has nothing to do with the link state. But it works because > > RTNH_F_LINKDOWN is valid for lookups only when

[PATCH net-next v2] ipv4: use l4 hash for locally generated multipath flows

2015-10-29 Thread Paolo Abeni
This patch changes how the multipath hash is computed for locally generated flows: now the hash comprises l4 information. This allows better utilization of the available paths when the existing flows have the same source IP and the same destination IP: with l3 hash, even when multiple connections

[PATCH 1/2] sh_eth: fix uninitialized arrays in sh_eth_ring_init()

2015-10-29 Thread Sergei Shtylyov
sh_eth_ring_free() called in the sh_eth_ring_init()'s error path expects the arrays pointed by sh_eth_private::[rt]x_skbuff to be initialized with NULLs but they are allocated with just kmalloc_array() and so left filled with random data. Use kcalloc() instead. Signed-off-by: Sergei Shtylyov

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-10-29 Thread Bendik Rønning Opstad
On Monday, October 26, 2015 02:58:03 PM Yuchung Cheng wrote: > On Mon, Oct 26, 2015 at 2:35 PM, Andreas Petlund wrote: > > > On 26 Oct 2015, at 15:50, Neal Cardwell wrote: > > > > > > On Fri, Oct 23, 2015 at 4:50 PM, Bendik Rønning Opstad > > > > > >

Re: [patch] tcp: attach SYNACK messages to request sockets instead of listener

2015-10-29 Thread Haiyang Zhang
Hi Eric, I saw a panic in __dev_kfree_skb_any() when I ssh into some Ubuntu VM with latest Linux-next tree on Hyper-V host. With git bisecting, I found the patch below is the first commit with this issue. I also included the stack trace here. Do you have any idea about what the problem might be?

Re: [patch] tcp: attach SYNACK messages to request sockets instead of listener

2015-10-29 Thread Eric Dumazet
On Thu, 2015-10-29 at 21:49 +, Haiyang Zhang wrote: > Hi Eric, > > I saw a panic in __dev_kfree_skb_any() when I ssh into some > Ubuntu VM with latest Linux-next tree on Hyper-V host. > With git bisecting, I found the patch below is the first commit > with this issue. I also included the

[PATCH 0/2] sh_eth: fix bugs in sh_eth_ring_init()

2015-10-29 Thread Sergei Shtylyov
Hello. Here's a set of 2 patches against DaveM's 'net.git' repo which fix couple of bugs in the sh_eth_ring_init() function. [1/2] sh_eth: fix uninitialized arrays in sh_eth_ring_init() [2/2] sh_eth: fix WARNING in dma_free_coherent() MBR, Sergei -- To unsubscribe from this list: send the

[PATCH 2/2] sh_eth: fix WARNING in dma_free_coherent()

2015-10-29 Thread Sergei Shtylyov
Iff the first dma_alloc_coherent() call fails in sh_eth_ring_init(), the following is printed to the kernel console: WARNING: CPU: 0 PID: 1 at drivers/base/dma-mapping.c:334 dma_common_free_remap+0x48/0x6c() trying to free invalid coherent area: (null) Modules linked in: CPU: 0 PID: 1 Comm:

Re: [BUG] Any-IP IPv6 support broken

2015-10-29 Thread Maciej Żenczykowski
What are you trying to do? The intent of the patch is to be able to terminate connections from outside the machine that are reaching the machine (perhaps delivered inside a tunnel or via some other mechanism: static arp entries, routing via the machine, etc), that the kernel wouldn't normally

[PATCH net] net: bcmgenet: Software reset EPHY after power on

2015-10-29 Thread Florian Fainelli
The EPHY on GENET v1->v3 is extremely finicky, and will show occasional failures based on the timing and reset sequence, ranging from duplicate packets, to extremely high latencies. Perform an additional software reset, and re-configuration to make sure it is in a consistent and working state.

Re: [PATCH 2/2] sh_eth: fix WARNING in dma_free_coherent()

2015-10-29 Thread Sergei Shtylyov
On 10/30/2015 12:52 AM, Sergei Shtylyov wrote: Iff the first dma_alloc_coherent() call fails in sh_eth_ring_init(), the following is printed to the kernel console: WARNING: CPU: 0 PID: 1 at drivers/base/dma-mapping.c:334 dma_common_free_remap+0x48/0x6c() Oops, I got the function name

[PATCH net] i40e: Look up MAC address in Open Firmware or IDPROM

2015-10-29 Thread Sowmini Varadhan
This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC address in Open Firmware or IDPROM"). As with that fix, attempt to look up the MAC address in Open Firmware on systems that uspport it, and use IDPROM on SPARC if no OF address is found. Reviewed-by: Martin K. Petersen

Re: [PATCH net-next V18 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-29 Thread Thomas F Herbert
Pravin, please look at comment inline below: On 10/27/15 1:22 PM, Pravin Shelar wrote: On Tue, Oct 27, 2015 at 9:45 AM, Thomas F Herbert wrote: On 10/26/15 10:10 PM, Pravin Shelar wrote: Thanks for the review. On Sun, Oct 25, 2015 at 5:11 PM, Thomas F Herbert

Re: [PATCH v2 1/3] virtio_net: Stop doing DMA from the stack

2015-10-29 Thread Andy Lutomirski
On Wed, Oct 28, 2015 at 12:07 AM, Michael S. Tsirkin wrote: > How about this instead? Less code, more robust. > > Warning: untested. If you do like this approach, Tested-by would be > appreciated. I like it. Tested-by: Andy Lutomirski --Andy -- To

Re: [PATCH 1/1] commit c6825c0976fa7893692e0e43b09740b419b23c09 upstream.

2015-10-29 Thread Ani Sinha
On Wed, Oct 28, 2015 at 11:40 PM, Neal P. Murphy wrote: > On Wed, 28 Oct 2015 02:36:50 -0400 > "Neal P. Murphy" wrote: > >> On Mon, 26 Oct 2015 21:06:33 +0100 >> Pablo Neira Ayuso wrote: >> >> > Hi, >> > >> > On Mon,

Re: [PATCH net] i40e: Look up MAC address in Open Firmware or IDPROM

2015-10-29 Thread Andy Shevchenko
On Fri, Oct 30, 2015 at 1:34 AM, Sowmini Varadhan wrote: > > > This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC > address in Open Firmware or IDPROM"). > > As with that fix, attempt to look up the MAC address in Open Firmware > on systems that

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-29 Thread Lan Tianyu
On 2015年10月26日 23:03, Alexander Duyck wrote: > No. I think you are missing the fact that there are 256 descriptors per > page. As such if you dirty just 1 you will be pulling in 255 more, of > which you may or may not have pulled in the receive buffer for. > > So for example if you have the

[PATCH net-next v4 2/2] switchdev: fix: pass correct obj size when deferring obj add

2015-10-29 Thread sfeldma
From: Scott Feldman Fixes: 4d429c5dd ("switchdev: introduce possibility to defer obj_add/del") Signed-off-by: Scott Feldman Acked-by: Jiri Pirko --- v3->v4: rebase sync v2->v3: add Jiri's Acked-by v1->v2: use correct "Fixes" tag, use

[PATCH net-next v4 1/2] switchdev: fix: erasing too much of vlan obj when handling multiple vlan specs

2015-10-29 Thread sfeldma
From: Scott Feldman When adding vlans with multiple IFLA_BRIDGE_VLAN_INFO attrs set in AFSPEC, we would wipe the vlan obj struct after the first IFLA_BRIDGE_VLAN_INFO. Fix this by only clearing what's necessary on each IFLA_BRIDGE_VLAN_INFO iteration. Fixes: 9e8f4a54

Re: [PATCH 1/1] commit c6825c0976fa7893692e0e43b09740b419b23c09 upstream.

2015-10-29 Thread Neal P. Murphy
On Wed, 28 Oct 2015 02:36:50 -0400 "Neal P. Murphy" wrote: > On Mon, 26 Oct 2015 21:06:33 +0100 > Pablo Neira Ayuso wrote: > > > Hi, > > > > On Mon, Oct 26, 2015 at 11:55:39AM -0700, Ani Sinha wrote: > > > netfilter: nf_conntrack: fix RCU race

[PATCH v5] isdn: Use ktime_t instead of 'struct timeval'

2015-10-29 Thread Tina Ruchandani
'struct timeval' uses 32-bit representation for seconds which will overflow in year 2038 and beyond. mISDN/clock.c needs to compute and store elapsed time in intervals of 125 microseconds. This patch replaces the usage of 'struct timeval' with 64-bit ktime_t which is y2038 safe. The patch also

Re: [PATCH 02/25] IB/mthca, net/mlx4: remove counting semaphores

2015-10-29 Thread Jack Morgenstein
On Wed, 28 Oct 2015 03:45:50 +0100 Arnd Bergmann wrote: > As far as I can tell, there is a preexisting race condition > regarding the cmd->use_events flag, which is not protected > by any lock. When this flag is toggled while another command > is being started, that command gets

  1   2   >