On Tue, Nov 24, 2015 at 01:43:38AM +0200, Andy Shevchenko wrote:
> On Mon, Nov 23, 2015 at 2:32 PM, Sudip Mukherjee
> wrote:
> > We were dereferencing cmd first and checking for NULL later. Lets first
> > check for NULL.
>
> However the patch is valid due to reducing error prone part, the
> commi
On 11/23/2015 01:02 PM, Anjali Singhai Jain wrote:
The new function udp_offload_get_port replaces vxlan_get_rx_port().
This is a generic function that will help replay all udp tunnel ports
irrespective of tunnel type.
This way when new udp tunnels get added this function need not change.
Note: D
On 11/23/2015 01:02 PM, Anjali Singhai Jain wrote:
The new function udp_offload_get_port replaces vxlan_get_rx_port().
This is a generic function that will help replay all udp tunnel ports
irrespective of tunnel type.
This way when new udp tunnels get added this function need not change.
Note: D
Coverity says:
*** CID 1338065: Error handling issues (CHECKED_RETURN)
/net/tipc/udp_media.c: 162 in tipc_udp_send_msg()
156 struct udp_media_addr *dst = (struct udp_media_addr
*)&dest->value;
157 struct udp_media_addr *src = (struct udp_media_addr
*)&b->addr.value;
158
On Wed, Nov 11, 2015 at 05:48:29PM +0800, Herbert Xu wrote:
>
> BTW, the networking folks found this years ago and even added
> helpers to deal with this. See for example wq_has_sleeper in
> include/net/sock.h. It would be good if we can move some of
> those helpers into wait.h instead.
Here is
On 11/23/2015 01:02 PM, Anjali Singhai Jain wrote:
Replace add/del ndo ops for vxlan_port with tunnel_port so that all UDP
based tunnels can use the same ndo op. Add a parameter to pass tunnel
type to the ndo_op.
Change all drivers to use the generalized udp tunnel offload
Patch was compile tes
On 11/24/2015 12:35 PM, David Miller wrote:
> pskb_expand_head() returns negative error codes, therefore zero means
> success and therefore this "!err" check is reversed.
Thank you for pointing out such a stupid mistake I made.
I will send v2 to correct it.
Regards,
Ying
--
To unsubscribe from
From: Ying Xue
Date: Sun, 22 Nov 2015 15:46:05 +0800
> Even if we drain receive queue thoroughly in tipc_release() after tipc
> socket is removed from rhashtable, it is possible that some packets
> are in flight because some CPU runs receiver and did rhashtable lookup
> before we removed socket.
From: Ying Xue
Date: Sun, 22 Nov 2015 15:38:39 +0800
> @@ -158,8 +158,11 @@ static int tipc_udp_send_msg(struct net *net, struct
> sk_buff *skb,
> struct udp_media_addr *src = (struct udp_media_addr *)&b->addr.value;
> struct rtable *rt;
>
> - if (skb_headroom(skb) < UDP_MIN_HE
From: Aaro Koskinen
Date: Sun, 22 Nov 2015 01:08:54 +0200
> Commit fcb26ec5b18d ("broadcom: move all PHY_ID's to header")
> updated broadcom_tbl to use PHY_IDs, but incorrectly replaced 0x0143bca0
> with PHY_ID_BCM5482 (making a duplicate entry, and completely omitting
> the original). Fix that.
On Wed, Oct 21, 2015 at 09:01:26PM -0700, Don Fry wrote:
> On Mon, 2015-10-12 at 05:38 -0700, David Miller wrote:
> > From: Geliang Tang
> > Date: Fri, 9 Oct 2015 03:45:39 -0700
> >
> > > pcnet32 can't work on my machine recently. It says "architecture
> > > does not support 32bit PCI busmaster
On 11/23/15, 6:15 AM, Robert Shearman wrote:
> On 21/11/15 05:16, Roopa Prabhu wrote:
>> From: Roopa Prabhu
>>
>> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls
>> routes due to link events. Also adds code to ignore dead
>> routes during route selection.
>>
>> Unlike ip routes, mpl
Add Killer E2400 device ID in alx driver.
Signed-off-by: Owen Lin o...@rivetnetworks.com
diff -uprN alx_orig/main.c alx/main.c
--- alx_orig/main.c Mon Sep 7 13:00:58 2015
+++ alx/main.c Mon Sep 7 14:47:03 2015
On Mon, 23 Nov 2015 16:38:59 -0800
Tom Herbert wrote:
> >> >
> >> > Sorry, I still don't like this. Grant it least it gets rid of of VXLAN
> >> > specific ops, but the problem is there no such things as a common set
> >> > of encapsulations in the kernel (e.g. foo-over-udp adds a bunch of
> >> > e
Replace add/del ndo ops for vxlan_port with tunnel_port so that all UDP
based tunnels can use the same ndo op. Add a parameter to pass tunnel
type to the ndo_op.
Change all drivers to use the generalized udp tunnel offload
Patch was compile tested with x86_64_defconfig.
v2: fix compile for bnxt d
On Mon, Nov 23, 2015 at 4:32 PM, Singhai, Anjali
wrote:
>
>
>> -Original Message-
>> From: Jesse Gross [mailto:je...@kernel.org]
>> Sent: Monday, November 23, 2015 2:50 PM
>> To: Tom Herbert
>> Cc: Singhai, Anjali; Linux Kernel Network Developers; Patil, Kiran
>> Subject: Re: [PATCH v1 1/6
> -Original Message-
> From: Jesse Gross [mailto:je...@kernel.org]
> Sent: Monday, November 23, 2015 2:50 PM
> To: Tom Herbert
> Cc: Singhai, Anjali; Linux Kernel Network Developers; Patil, Kiran
> Subject: Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload
>
> On Mon, Nov 23, 2
On Sun, 8 Nov 2015 21:22:16 +0100
Phil Sutter wrote:
> The core issue here is that with promote_secondaries sysctl setting
> being turned off, removing the primary address implicitly removes all
> secondaries as well. Iproute is aware of this and therefore tries to
> remove all secondary address
On Thu, 12 Nov 2015 21:10:08 +
Konstantin Shemyak wrote:
> When creating an IP tunnel over IPv6, the address family must be passed in
> the option, e.g.
>
> ip -6 tunnel add mode ip6gre local 1::1 remote 2::2
>
> This makes it impossible to create both IPv4 and IPv6 tunnels in one batch.
>
On Thu, 24 Sep 2015 14:39:39 -0400
"John W. Linville" wrote:
> Signed-off-by: John W. Linville
> ---
> include/linux/if_link.h | 1 +
> ip/iplink_geneve.c | 20 +---
> 2 files changed, 14 insertions(+), 7 deletions(-)
Applied, the if_link.h change was already picked up.
On Wed, 4 Nov 2015 16:54:24 +0100
Phil Sutter wrote:
> On Tue, Nov 03, 2015 at 04:33:59PM -0800, Stephen Hemminger wrote:
> > On Thu, 29 Oct 2015 12:15:47 +0100
> > Phil Sutter wrote:
> >
> > > This patch is based upon an old Fedora bug[1] regarding the routing
> > > setup of PPP links. I'm not
Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
net/ipv4/ipmr.c
between commit:
0e615e9601a1 ("net: ipmr: fix static mfc/dev leaks on table destruction")
from the net tree and commit:
7ef8f65df976 ("net: ipmr: fix code and comment style")
from the net-next tree
On Fri, 13 Nov 2015 00:39:29 +0100
Daniel Borkmann wrote:
> This larger work addresses one of the bigger remaining issues on
> tc's eBPF frontend, that is, to allow for persistent file descriptors.
> Whenever tc parses the ELF object, extracts and loads maps into the
> kernel, these file descript
On Thu, 22 Oct 2015 10:34:28 +0200
Thomas Haller wrote:
> Kernel allows for zero IPv4 peer addresses (IFA_ADDRESS):
>
>ip address add 192.168.5.1 peer 0.0.0.0/24 dev dummy
>
> which is distinct from a usual address like:
>
>ip address add 192.168.5.1/24 dev dummy
>ip address add 19
On Fri, 13 Nov 2015 18:08:53 +0100
Phil Sutter wrote:
> In an effort to try and merge iptunnel and ip6tunnel support code, I found a
> few things worth changing, mainly by comparing the two files.
>
> Please note that I did not test functionality of all supported tunnel modes,
> but since the ch
On Thu, 5 Nov 2015 14:54:17 -0500
Neil Horman wrote:
> I found recently that, if I disabled address promotion in the kernel, that
> ip addr flush dev
>
> would fail with an EADDRNOTAVAIL errno (though the flush operation would in
> fact
> flush all addresses from an interface properly)
>
> W
On Wed, 18 Nov 2015 12:46:42 +0100
Phil Sutter wrote:
> Despite commit 45a82e5 ("iproute vxlan add support for fdb replace
> command"), the 'fdb replace' command was not mentioned in bridge.8.
>
> Signed-off-by: Phil Sutter
Applied this one.
--
To unsubscribe from this list: send the line "uns
On Wed, 18 Nov 2015 12:46:43 +0100
Phil Sutter wrote:
> - Replace commas at end of subsection with dots.
> - Remove whitespace at EOL.
> - Replace double whitespace by single one.
>
> Signed-off-by: Phil Sutter
Could you redo this patch. It crossed over with my changes
to scrub all the trailin
On Tue, 10 Nov 2015 13:54:09 +0100
Phil Sutter wrote:
> Technically, the range of possible hoplimit values are defined by IPv4
> and IPv6 header formats. Both define the field to be eight bits in size,
> which leads to a value range of [0;255]. Setting a packet's hoplimit
> field to 0 though make
On Sat, 7 Nov 2015 11:47:40 +0200
Ville Skyttä wrote:
> ---
> man/man8/bridge.8 | 2 +-
> man/man8/ifcfg.8 | 2 +-
> man/man8/lnstat.8 | 2 +-
> man/man8/tc-bpf.8 | 2 +-
> man/man8/tc-cbq-details.8 | 2 +-
> man/man8/tc-mqprio.8 | 2 +-
> man/man8/tc.8
On Mon, Nov 23, 2015 at 2:32 PM, Sudip Mukherjee
wrote:
> We were dereferencing cmd first and checking for NULL later. Lets first
> check for NULL.
However the patch is valid due to reducing error prone part, the
commit message seems wrong.
There is no dereferencing, it is a simple pointer arithm
On Mon, Nov 23, 2015 at 5:46 PM, Pavel Machek wrote:
>
>
> If aliases are not present in device tree, stmmac_platform.c will
> happily assign bus_id of 0 to all the ethernet interfaces, resulting
> in hard to debug problems.
>
> At least warn the user about the problem.
>
> Signed-off-by: Pavel Ma
On Tue, 17 Nov 2015 16:08:00 +0200
Aaro Koskinen wrote:
> Use PKG_CONFIG from Config - it works better when cross-compiling.
>
> Signed-off-by: Aaro Koskinen
Looks good, applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.ker
On Wed, 18 Nov 2015 11:03:20 -0800
David Ahern wrote:
> Add support for reading table id/name mappings from rt_tables.d
> directory.
>
> Signed-off-by: David Ahern
> ---
> lib/rt_names.c | 18 ++
> 1 file changed, 18 insertions(+)
This is a useful concept, and I am for incorpo
Rainer Weikusat writes:
> David Miller writes:
[...]
> I'm sorry for this 13th hour request/ suggestion but while thinking
> about a reply to Dmitry, it occurred to me that the restart_locked/
> sk_locked logic could be avoided by moving the test for this condition
> in front of all the others
From: Nikolay Aleksandrov
Date: Sat, 21 Nov 2015 19:46:19 +0100
> From: Nikolay Aleksandrov
>
> When vrf's ->newlink is called, if register_netdevice() fails then it
> does free_netdev(), but that's also done by rtnl_newlink() so a second
> free happens and memory gets corrupted, to reproduce e
On Mon, Nov 23, 2015 at 1:53 PM, Tom Herbert wrote:
>> diff --git a/include/net/udp_tunnel.h b/include/net/udp_tunnel.h
>> index cb2f89f..72415aa 100644
>> --- a/include/net/udp_tunnel.h
>> +++ b/include/net/udp_tunnel.h
>> @@ -9,6 +9,12 @@
>> #include
>> #endif
>>
>> +enum udp_tunnel_type {
>>
Eliminate the channel field in hv_netvsc_packet structure.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 22 ++
drivers/net/hyperv/netvsc.c | 19 ---
drivers/net/hyperv/netvsc_drv.c |5 +++--
Eliminate rndis_msg pointer from hv_netvsc_packet structure.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h |8 +++-
drivers/net/hyperv/netvsc.c | 10 ++
drivers/net/hyperv/netvsc_drv.c |7 +++
drivers/net/hyper
The rndis header is 116 bytes big and can be placed in the default
head room that will be available in the skb. Since the netvsc packet
is less than 48 bytes, we can use the skb control buffer
for the netvsc packet. With these changes we don't need to
ask for additional head room.
Signed-off-by: K
Eliminate send_completion from struct hv_netvsc_packet.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h |3 +--
drivers/net/hyperv/netvsc.c |6 +++---
drivers/net/hyperv/netvsc_drv.c |2 +-
drivers/net/hyperv/rndis_filter.c |
On (11/23/15 13:43), Dave Watson wrote:
>
> For kcm, opfd is the fd you would pass along in kcm_attach.
> For rds, it looks like you'd want to use opfd as the sock instead of
> the new one created by sock_create_kern in rds_tcp_conn_connect.
I see.
It's something to consider, and it would certai
From: Vitaly Kuznetsov
Packet scheduler guarantees there won't be multiple senders for the same
queue and as we use q_idx for multi_send_data the spinlock is redundant.
Signed-off-by: Vitaly Kuznetsov
Signed-off-by: K. Y. Srinivasan
---
drivers/net/hyperv/hyperv_net.h |1 -
drivers/net/hy
Eliminate send_completion_ctx from struct hv_netvsc_packet.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h |1 -
drivers/net/hyperv/netvsc.c |3 +--
drivers/net/hyperv/netvsc_drv.c |1 -
3 files changed, 1 insertions(+), 4 deletion
From: Vitaly Kuznetsov
Signed-off-by: Vitaly Kuznetsov
Signed-off-by: K. Y. Srinivasan
---
drivers/net/hyperv/hyperv_net.h | 15 ---
drivers/net/hyperv/netvsc.c |5 ++---
drivers/net/hyperv/netvsc_drv.c |3 +++
3 files changed, 5 insertions(+), 18 deletions(-)
diff -
Rearrange the elements of struct hv_negtvsc_packet for optimal layout -
eliminate unnecessary padding.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 18 ++
1 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/driver
As part of reducing the size of the hv_netvsc_packet, resize some of the
variables based on their usage.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/n
Eliminatte the data field from struct hv_netvsc_packet.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Haiyang Zhang
---
drivers/net/hyperv/hyperv_net.h |5 ++---
drivers/net/hyperv/netvsc.c |5 +++--
drivers/net/hyperv/netvsc_drv.c |3 ++-
drivers/net/hyperv/rndis_filter.c
In an attempt to avoid having to allocate memory on the send path, the netvsc
driver was requesting additional head room so that both rndis header and the
netvsc packet (the state that had to persist) could be placed in the skb.
Since the amount of head room requested was exceeding the default head
> diff --git a/include/net/udp_tunnel.h b/include/net/udp_tunnel.h
> index cb2f89f..72415aa 100644
> --- a/include/net/udp_tunnel.h
> +++ b/include/net/udp_tunnel.h
> @@ -9,6 +9,12 @@
> #include
> #endif
>
> +enum udp_tunnel_type {
> + UDP_TUNNEL_UNSPEC,
> + UDP_TUNNEL_VXLAN,
> +
On 11/23/15 02:27 PM, Sowmini Varadhan wrote:
> On (11/23/15 09:43), Dave Watson wrote:
> > Currently gcm(aes) represents ~80% of our SSL connections.
> >
> > Userspace interface:
> >
> > 1) A transform and op socket are created using the userspace crypto
> > interface
> > 2) Setsockopt ALG_SET_AU
David Miller writes:
> From: Rainer Weikusat
>> Rainer Weikusat writes:
>> An AF_UNIX datagram socket being the client in an n:1 association
[...]
> Applied and queued up for -stable,
I'm sorry for this 13th hour request/ suggestion but while thinking
about a reply to Dmitry, it occurred to m
Hi Anjali,
[auto build test ERROR on net/master]
[also build test ERROR on v4.4-rc2 next-20151123]
url:
https://github.com/0day-ci/linux/commits/Anjali-Singhai-Jain/Generalize-udp-based-tunnels-and-add-geneve-offload/20151124-044959
config: i386-randconfig-x006-11230317 (attached as .config
Hi Anjali,
[auto build test ERROR on net/master]
[also build test ERROR on v4.4-rc2 next-20151123]
url:
https://github.com/0day-ci/linux/commits/Anjali-Singhai-Jain/Generalize-udp-based-tunnels-and-add-geneve-offload/20151124-044959
config: x86_64-randconfig-x001-11230704 (attached as
On Mon, Nov 23, 2015 at 03:45:23PM -0500, David Miller wrote:
> > * Refreshed on top of Nina's net_cls dynamic config update fix patch.
> > I included the fix patch as part of this series to ease reviewing.
>
> I put this into the 'net' tree as it's a bug fix, so can you respin
> this after I ne
From: Julia Lawall
Date: Sat, 21 Nov 2015 18:39:17 +0100
> The vmci_transport_notify_ops structures are never modified, so declare
> them as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netde
From: Julia Lawall
Date: Sat, 21 Nov 2015 18:28:05 +0100
> The in_cache_ops and eg_cache_ops structures are never modified, so declare
> them as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall
Applied.
--
To unsubscribe from this list: send the line "unsubscribe n
Replace add/del ndo ops for vxlan_port with tunnel_port so that all UDP
based tunnels can use the same ndo op. Add a parameter to pass tunnel
type to the ndo_op.
Change all drivers to use the generalized udp tunnel offload
Patch was compile tested with x86_64_defconfig.
Signed-off-by: Kiran Pati
If the kernel flag CONFIG_VXLAN is true or CONFIG_VXLAN_MODULE is true,
enable VXLAN offload in the driver.
Signed-off-by: Kiran Patil
Signed-off-by: Anjali Singhai Jain
---
drivers/net/ethernet/intel/Kconfig | 11 ---
drivers/net/ethernet/intel/i40e/i40e_main.c | 14 --
The new function udp_offload_get_port replaces vxlan_get_rx_port().
This is a generic function that will help replay all udp tunnel ports
irrespective of tunnel type.
This way when new udp tunnels get added this function need not change.
Note: Drivers besides i40e are compile tested with this chan
This patch series generalizes the flow for udp_based tunnels for
offload hooks. So that much of the frame work can remain common
for any driver adding support for geneve or any other
udp_based tunnel in future.
This patch series also makes the driver calls to/from the stack
independent of the tunn
This patch generalizes the driver flow to make room for more than just
VXLAN tunnel by defining a common data structure with tunnel type.
Signed-off-by: Kiran Patil
Signed-off-by: Anjali Singhai Jain
---
drivers/net/ethernet/intel/i40e/i40e.h | 15
drivers/net/ethernet/intel/i40e/
This patch adds driver hooks to implement ndo_ops to add/del udp
port in the HW to identify GENEVE tunnels.
Also cleans up the features_check path now that we support
multiple udp based tunnels.
Signed-off-by: Anjali Singhai Jain
Signed-off-by: Kiran Patil
---
drivers/net/ethernet/intel/i40e/i
This patch moves the calls to ndo_add/del ops for vxlan tunnel
into udp_add/del_offload call. This way the ndo_add/del ops get called
for not only vxlan tunnels but for any udp based tunnel.
Signed-off-by: Kiran Patil
Signed-off-by: Anjali Singhai Jain
---
drivers/net/geneve.c | 18 +++---
From: Tejun Heo
Date: Sat, 21 Nov 2015 11:13:52 -0500
> * Refreshed on top of Nina's net_cls dynamic config update fix patch.
> I included the fix patch as part of this series to ease reviewing.
I put this into the 'net' tree as it's a bug fix, so can you respin
this after I next merge 'net' i
Hi!
> stmmac_main will happily try to create two directories with the same
> name.
>
> I guess something like
>
> static int id;
> char name[100];
>
> sprintf(name, STMMAC_RESOURCE_NAME "_%d", id++)
> ...
>
> might be suitable, but did not try that further.
Hmm. It seems this is fixed in v4.1
From: kbuild test robot
Date: Tue, 24 Nov 2015 01:34:51 +0800
> All error/warnings (new ones prefixed by >>):
>
>net/dsa/dsa.c: In function 'dsa_of_probe':
>>> net/dsa/dsa.c:783:16: error: implicit declaration of function
>>> 'gpio_to_desc' [-Werror=implicit-function-declaration]
>c
From: Nikolay Aleksandrov
Date: Sat, 21 Nov 2015 15:57:23 +0100
> Since I'll have to work with ipmr, I decided to clean it up and do some
> minor improvements. Functionally there're almost no changes except the
> SLAB_PANIC removal. Most of the patches just re-design some functions to
> be cleare
On 23/11/15 18:43, Eric Dumazet wrote:
> On Mon, 2015-11-23 at 17:26 +0100, Bendik Rønning Opstad wrote:
>
>> > +
>> > +tcp_rdb_max_skbs - INTEGER
>> > + Enable restriction on how many previous SKBs in the output queue
>> > + RDB may include data from. A value of 1 will restrict bundling to
>> >
Fixing kernel crash when doing ifconfig down and up in a loop,
[ 124.028237] Call trace:
[ 124.030670] [] memcpy+0x20/0x180
[ 124.035436] [] skb_clone+0x3c/0xa8
[ 124.040374] [] __skb_tstamp_tx+0xc0/0x118
[ 124.045918] [] skb_tstamp_tx+0x10/0x1c
[ 124.051203] [] xgene_enet_start_xmit+0x2e4/0x33c
[
On Mon, Nov 23, 2015 at 11:54 AM, David Miller wrote:
> From: Tom Herbert
> Date: Mon, 23 Nov 2015 09:33:44 -0800
>
>> The TCP PSH flag is not defined for message delineation (neither is
>> urgent pointer). We can't change that (many people have tried to add
>> message semantics to TCP protocol b
On Mon, Nov 23, 2015 at 7:23 PM, Alexander Duyck
wrote:
> On 11/23/2015 03:11 AM, Or Gerlitz wrote:
>>
>> From: Saeed Mahameed
>>
>> Each Vport/vNIC must notify underlying e-Switch layer
>> for UC/MC list and promisc mode updates, in-order to update
>> l2 tables and SR-IOV FDB tables.
>>
>> We do
Hello,
On Mon, Nov 23, 2015 at 10:53:46AM -0500, Tejun Heo wrote:
> > [ 11.594536] [ cut here ]
> > [ 11.595274] WARNING: CPU: 1 PID: 1 at kernel/cgroup_pids.c:97
> > pids_cancel.constprop.6+0x31/0x40()
> > [ 11.595958] Modules linked in:
> > [ 11.596199] CPU: 1 PI
From: Dan Carpenter
Date: Sat, 21 Nov 2015 13:34:12 +0300
> WARN_ON_ONCE() takes a condition, it doesn't take an error message. I
> have converted this to WARN() instead.
>
> Signed-off-by: Dan Carpenter
Applied, thanks Dan.
--
To unsubscribe from this list: send the line "unsubscribe netdev"
From: Tom Herbert
Date: Mon, 23 Nov 2015 09:33:44 -0800
> The TCP PSH flag is not defined for message delineation (neither is
> urgent pointer). We can't change that (many people have tried to add
> message semantics to TCP protocol but have always failed miserably).
Agreed.
My only gripe with
From: Emil Tantilov
If ixgbevf is loaded while the corresponding PF interface is down
and the driver assigns a random MAC address, that address can be
overwritten with the value of hw->mac.perm_addr, which would be 0 at
that point.
To avoid this case we init hw->mac.perm_addr to the randomly gen
From: Jacob Keller
It is possible that the PF has not yet assigned resources to the VF.
Although rare, this could result in the VF attempting to read queues it
does not own and result in FUM or THI faults in the PF. To prevent this,
check queue 0 before we continue in init_hw_vf.
Signed-off-by:
From: Alexander Duyck
This patch corrects an issue in which the polling routine would increase
the budget for Rx to at least 1 per queue if multiple queues were present.
This would result in Rx packets being processed when the budget was 0 which
is meant to indicate that no Rx can be handled.
Si
From: Emil Tantilov
replace some instances of memcpy for setting up the mac address with
ether_addr_copy()
Signed-off-by: Emil Tantilov
Tested-by: Darin Miller
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 14 ++
1 file changed, 6 insertions(
From: Jesse Brandeburg
Compiler complained of an unused variable, which the driver was just
using to store the result of a rd32 which is used to clear a register
unconditionally. Just drop the unused variable and re-use one.
Signed-off-by: Jesse Brandeburg
Tested-by: Andrew Bowers
Signed-off-
From: Mark Rustad
Testing has now shown that the diagnostic code used with the CS4227
is no longer needed, so remove it.
Signed-off-by: Mark Rustad
Tested-by: Darin Miller
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 80 ---
1 file c
From: Mark Rustad
Delete a redundant include of net/vxlan.h.
Signed-off-by: Mark Rustad
Tested-by: Darin Miller
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
b
From: Jean Sacren
The commit dfaf891dd3e1 ("ixgbe: Refactor the RSS configuration code")
introduced a few kernel-doc errors:
1) The function name is missing;
2) The format is wrong;
3) The short description is redundant.
Fix all the above for the correct execution of the kernel doc.
Signed-off
From: Julia Lawall
Remove unneeded NULL test.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@ expression x; @@
-if (x != NULL)
\(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
//
Signed-off-by: Julia Lawall
Tested-by: Darin Miller
From: Alexander Duyck
The ixgbe_intr and ixgbe/ixgbevf_msix_clean_rings functions run from hard
interrupt context or with interrupts already disabled in netpoll.
They can use napi_schedule_irqoff() instead of napi_schedule()
Signed-off-by: Alexander Duyck
Tested-by: Darin Miller
Signed-off-by
From: Alexander Duyck
This patch is the ixgbevf version of commit 8ac34f10a5ea4 "ixgbe: Limit
lowest interrupt rate for adaptive interrupt moderation to 12K"
The same logic applies here as well as the same results since a netperf
test will starve for memory in the time from one Tx interrupt to t
From: Alexander Duyck
This patch corrects an issue in which the polling routine would increase
the budget for Rx to at least 1 per queue if multiple queues were present.
This would result in Rx packets being processed when the budget was 0 which
is meant to indicate that no Rx can be handled.
Si
From: Jacob Keller
Based on hardware testing, the host interface supports up to 15368 bytes
as the maximum frame size. To determine the correct MTU, we subtract 8
for the internal switch tag, 14 for the L2 header, and 4 for the
appended FCS header, resulting in 15342 bytes of payload for our maxi
From: Mark Rustad
KR auto-neg mode is what we will be using going forward. The SW
interface for this mode is different that what was used for iXFI.
Signed-off-by: Mark Rustad
Tested-by: Phil Schmitt
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 85 ++
From: Rasmus Villemoes
This code is pretty confused. The variable name 'bytes_not_copied'
clearly indicates that the programmer knew the semantics of
copy_{to,from}_user, but then the return value is checked for being
negative and used as a -Exxx return value.
I'm not sure this is the proper fix
This series contains updates to ixgbe, ixgbevf, fm10k, i40e and i40evf.
Jacob fixes an issue where VF could attempt to read queues it does not own,
so prevent this we check queue 0 before we continue.
Matthew fixes the MTU for jumbo frames for fm10k.
Julia Lawall cleans up a unneeded NULL test i
Hi folks,
Any more comments on this patch (store immediate only)?
I need more time to add XADD (I'm supposed everyone agrees it is
equivalent to atomic_add). However, this one is irrelevant to XADD, so
we may be able to apply it first?
Thanks,
Yang
On 11/12/2015 7:45 PM, Z Lim wrote:
On T
Hello Tom,
On Mon, Nov 23, 2015, at 18:33, Tom Herbert wrote:
> > For me this still looks a little bit like messages could be delimited by
> > TCP PSH flag, where we might need to have some more fine grained control
> > over and besides that just adding better fanout semantics to TCP, no?
> >
> Th
On Mon, Nov 23, 2015 at 01:00:59PM +0300, Vladimir Davydov wrote:
> I've another question regarding this socket_work: its reclaim target
> always equals CHARGE_BATCH. Can't it result in a workload exceeding
> memory.high in case there are a lot of allocations coming from different
> cpus? In this c
On (11/23/15 09:43), Dave Watson wrote:
> Currently gcm(aes) represents ~80% of our SSL connections.
>
> Userspace interface:
>
> 1) A transform and op socket are created using the userspace crypto interface
> 2) Setsockopt ALG_SET_AUTHSIZE is called
> 3) Setsockopt ALG_SET_KEY is called twice, s
On Mon, Nov 23, 2015 at 7:30 PM, Alexander Duyck
wrote:
> On 11/23/2015 03:11 AM, Or Gerlitz wrote:
>>
>> From: Saeed Mahameed
>>
>> Each Vport/vNIC must notify underlying e-Switch layer
>> for vlan table changes in-order to update SR-IOV FDB tables.
>>
>> We do that at vlan_rx_add_vid and vlan_r
On 15-11-23 11:12 AM, Hannes Frederic Sowa wrote:
> On Mon, Nov 23, 2015, at 20:09, John Fastabend wrote:
>> On 15-11-23 10:03 AM, Alexei Starovoitov wrote:
>>> On Mon, Nov 23, 2015 at 05:11:58PM +0100, Hannes Frederic Sowa wrote:
Actually, that is the reason why I mentioned it, so *the a
On Mon, Nov 23, 2015, at 20:09, John Fastabend wrote:
> On 15-11-23 10:03 AM, Alexei Starovoitov wrote:
> > On Mon, Nov 23, 2015 at 05:11:58PM +0100, Hannes Frederic Sowa wrote:
> >>
> >> Actually, that is the reason why I mentioned it, so *the admin* can see
> >> something is going on. Do you want
Hello,
On Mon, Nov 23, 2015, at 18:42, Dave Watson wrote:
> An approach for a kernel TLS socket.
>
> Only the symmetric encryption / decryption is done in-kernel, as well
> as minimal framing handling. The handshake is kept in userspace, and
> the negotiated cipher / keys / IVs are then set on t
On 15-11-23 10:03 AM, Alexei Starovoitov wrote:
> On Mon, Nov 23, 2015 at 05:11:58PM +0100, Hannes Frederic Sowa wrote:
>>
>> Actually, that is the reason why I mentioned it, so *the admin* can see
>> something is going on. Do you want to protect ebpf from root? Skynet? ;)
>
> correct. To me both
1 - 100 of 199 matches
Mail list logo
