Re: [RFC PATCH net] Revert "ipv6: ndisc: inherit metadata dst when creating ndisc requests"

2015-12-01 Thread David Miller
From: Nicolas Dichtel Date: Fri, 27 Nov 2015 18:17:05 +0100 > This reverts commit ab450605b35caa768ca33e86db9403229bf42be4. > > In IPv6, we cannot inherit the dst of the original dst. ndisc packets > are IPv6 packets and may take another route than the original

Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

2015-12-01 Thread David Miller
From: Eric Dumazet Date: Mon, 30 Nov 2015 09:58:23 -0800 > On Sat, 2015-11-28 at 15:51 +0100, Pavel Machek wrote: >> atl1c driver is doing order-4 allocation with GFP_ATOMIC >> priority. That often breaks networking after resume. Switch to >> GFP_KERNEL. Still not ideal,

Re: [PATCH net-next v3 3/8] netfilter: Allow calling into nat helper without skb_dst.g

2015-12-01 Thread Pablo Neira Ayuso
On Wed, Nov 25, 2015 at 04:08:16PM -0800, Jarno Rajahalme wrote: > NAT checksum recalculation code assumes existence of skb_dst, which > becomes a problem for a later patch in the series ("openvswitch: > Interface with NAT."). Simplify this by removing the check on > skb_dst, as the checksum will

Re: [RFC] Stable interface index option

2015-12-01 Thread Sowmini Varadhan
On (12/01/15 15:57), David Miller wrote: > >> > Also current versions of SNMP provide more useful information about > >> > network interface slot information in ifDescription > >> > >> Well if they do provide strings, then that is probably a better way > >> forward than messing with the kernel.

Re: [PATCH (net-next.git)] stmmac: support Reg_9 to get HW level information

2015-12-01 Thread David Miller
From: Giuseppe Cavallaro Date: Mon, 30 Nov 2015 11:33:10 +0100 > For GMAC newer than 3.40a there is a new register (Reg_9) that provides the > status of all modules of the transmit and receive paths and FIFO status. > These can be exposed via ethtool. > > Signed-off-by:

Re: [PATCH net-next] hv_netvsc: rework link status change handling

2015-12-01 Thread David Miller
From: Vitaly Kuznetsov Date: Fri, 27 Nov 2015 11:39:55 +0100 > There are several issues in hv_netvsc driver with regards to link status > change handling: > - RNDIS_STATUS_NETWORK_CHANGE results in calling userspace helper doing > '/etc/init.d/network restart' and this is

Re: [PATCH] drivers: net: xgene: fix Tx flow control

2015-12-01 Thread David Miller
From: Iyappan Subramanian Date: Fri, 27 Nov 2015 19:22:31 -0800 > Currently the Tx flow control is based on reading the hardware state, > which is not accurate since it may not reflect the descriptors that > are not yet reached the memory. > > To accurately control the Tx

Re: [PATCH net-next V2 08/17] hv_netvsc: Don't ask for additional head room in the skb

2015-12-01 Thread David Miller
From: "K. Y. Srinivasan" Date: Sat, 28 Nov 2015 12:20:36 -0800 > +#elseif defined(CONFIG_WLAN) || IS_ENABLED(CONFIG_AX25) The correct CPP directive is "#elif". -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH v2 net-next 0/2] Basic support for Solarflare 8000 series NICs

2015-12-01 Thread David Miller
From: Bert Kenward Date: Mon, 30 Nov 2015 09:05:33 + > The upcoming Solarflare 8000 series 10G/40G network card supports a > similar interface to the current 7000 series cards. This patch series > provides basic support for these cards, making no use of any new >

Re: [PATCH net 1/2] net: rename SOCK_ASYNC_NOSPACE and SOCK_ASYNC_WAITDATA

2015-12-01 Thread David Miller
From: Eric Dumazet Date: Sun, 29 Nov 2015 20:03:10 -0800 > This patch is a cleanup to make following patch easier to > review. > > Goal is to move SOCK_ASYNC_NOSPACE and SOCK_ASYNC_WAITDATA > from (struct socket)->flags to a (struct socket_wq)->flags > to benefit from RCU

Re: [PATCH net 2/2] net: fix sock_wake_async() rcu protection

2015-12-01 Thread David Miller
From: Eric Dumazet Date: Sun, 29 Nov 2015 20:03:11 -0800 > Dmitry provided a syzkaller (http://github.com/google/syzkaller) > triggering a fault in sock_wake_async() when async IO is requested. > > Said program stressed af_unix sockets, but the issue is generic > and should

Re: "hw csum failure" error on skge driver with 4.3 kernel upon receiving ICMPv6 multicast listener discovery packets

2015-12-01 Thread Stefan Ring
On Sun, Nov 15, 2015 at 7:44 PM, David Madore wrote: > The skge driver in the 4.3 kernel reports hardware checksum errors > upon receiving (certain?) IPv6 multicast packets containing ICMPv6 > multicast listener discovery messages. This is a regression since 4.1 > (I believe

Re: [PATCH] isdn: remove spellcaster driver

2015-12-01 Thread David Miller
From: Arnd Bergmann Date: Mon, 30 Nov 2015 11:34:09 +0100 > The 'sc' ISDN driver relies on using readl() to access ISA I/O memory. > This has been deprecated and produced warnings since linux-2.3.23, > disabled by default since 2.4.10 and finally removed in 2.6.5. > > I found

Re: [RFC] Stable interface index option

2015-12-01 Thread Hannes Frederic Sowa
On Tue, Dec 1, 2015, at 22:44, Stephen Hemminger wrote: > On Tue, 01 Dec 2015 22:14:59 +0100 > Hannes Frederic Sowa wrote: > > I had several snmp installations with net-snmp and munin, cacti and so > > on and all had the interface name in ifDescription already some

Re: [PATCH] net: add support for netdev notifier error injection

2015-12-01 Thread David Miller
From: Nikolay Aleksandrov Date: Sat, 28 Nov 2015 13:45:28 +0100 > From: Nikolay Aleksandrov > > This module allows to insert errors in some of netdevice's notifier > events. All network drivers use these notifiers to signal various events > and

RE: [PATCH net-next V2 08/17] hv_netvsc: Don't ask for additional head room in the skb

2015-12-01 Thread KY Srinivasan
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, December 1, 2015 12:42 PM > To: KY Srinivasan > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; >

Re: [net-next v2 04/15] i40e: remove BUG_ON from feature string building

2015-12-01 Thread Joe Perches
On Wed, 2015-11-25 at 11:36 -0800, Joe Perches wrote: > On Wed, 2015-11-25 at 10:35 -0800, Jeff Kirsher wrote: > > On Wed, 2015-11-25 at 21:26 +0300, Sergei Shtylyov wrote: > > > On 11/25/2015 09:21 PM, Jeff Kirsher wrote: > > > > > > > From: Shannon Nelson > > > > > >

Re: [PATCH net-next 0/6] qede/qed: Implement various ethtool operations

2015-12-01 Thread David Miller
From: Yuval Mintz Date: Mon, 30 Nov 2015 12:25:00 +0200 > This series adds several new ethtool operations to qede: > - {get, set}_channels > - {get, set}_ringparam > - set_phys_id > - nway_reset > - {get, set}_pauseparam > As well as extending the qed APIs to

Re: [RFC] Stable interface index option

2015-12-01 Thread Stephen Hemminger
On Tue, 01 Dec 2015 22:14:59 +0100 Hannes Frederic Sowa wrote: > On Tue, Dec 1, 2015, at 21:57, David Miller wrote: > > From: Stephen Hemminger > > Date: Tue, 1 Dec 2015 12:20:38 -0800 > > > > > On Tue, 01 Dec 2015 14:28:47 -0500 (EST) >

Re: [RFC 1/4] net: support per queue tx_usecs in sysfs

2015-12-01 Thread Florian Fainelli
On 01/12/15 00:01, kan.li...@intel.com wrote: > From: Kan Liang > > Network devices usually have many queues. Each queue has its own > tx_usecs options. Currently, we can only set all the queues with same > value by ethtool. This patch expose the tx_usecs in sysfs. So the

Re: size overflow in function qdisc_tree_decrease_qlen net/sched/sch_api.c

2015-12-01 Thread Eric Dumazet
On Tue, 2015-12-01 at 12:06 -0800, Eric Dumazet wrote: > On Tue, 2015-12-01 at 11:17 -0800, Cong Wang wrote: > > On Tue, Dec 1, 2015 at 11:09 AM, Eric Dumazet > > wrote: > > > On Tue, 2015-12-01 at 10:43 -0800, Cong Wang wrote: > > > > > >> This smells hacky... Another

Re: xen-netfront crash when detaching network while some network activity

2015-12-01 Thread Marek Marczykowski-Górecki
On Tue, Dec 01, 2015 at 05:00:42PM -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Nov 17, 2015 at 03:45:15AM +0100, Marek Marczykowski-Górecki wrote: > > On Wed, Oct 21, 2015 at 08:57:34PM +0200, Marek Marczykowski-Górecki wrote: > > > On Wed, May 27, 2015 at 12:03:12AM +0200, Marek

Re: [RFC] Stable interface index option

2015-12-01 Thread Stephen Hemminger
On Tue, 01 Dec 2015 14:28:47 -0500 (EST) David Miller wrote: > From: Stephen Hemminger > Date: Tue, 1 Dec 2015 08:06:52 -0800 > > > On Tue, 01 Dec 2015 17:02:23 +0100 > > Hannes Frederic Sowa wrote: > > > >> On Tue,

Re: [PATCH] vmxnet3: fix checks for dma mapping errors

2015-12-01 Thread David Miller
From: Alexey Khoroshilov Date: Sat, 28 Nov 2015 01:29:30 +0300 > vmxnet3_drv does check dma_addr with dma_mapping_error() > after mapping dma memory. The patch adds the checks and > tries to handle failures. > > Found by Linux Driver Verification project

Re: [RFCv3 bluetooth-next 1/4] 6lowpan: add lowpan dev register helpers

2015-12-01 Thread Stefan Schmidt
Hello. On 29/11/15 12:34, Alexander Aring wrote: This patch introduces register and unregister functionality for lowpan interfaces. While register a lowpan interface there are several things which need to be initialize by the 6lowpan subsystem. Upcoming functionality need to register/unregister

Re: [RFC] Stable interface index option

2015-12-01 Thread David Miller
From: Stephen Hemminger Date: Tue, 1 Dec 2015 12:20:38 -0800 > On Tue, 01 Dec 2015 14:28:47 -0500 (EST) > David Miller wrote: > >> From: Stephen Hemminger >> Date: Tue, 1 Dec 2015 08:06:52 -0800 >> >> > On Tue, 01

[net-next PATCH] net: ipv6: restrict hop_limit sysctl setting to range [1;255]

2015-12-01 Thread Phil Sutter
Setting a value bigger than 255 resulted in using only the lower eight bits of that value as it is assigned to the u8 header field. To avoid this unexpected result, reject such values. Setting a value of zero is technically possible, but hosts receiving such a packet have to treat it like

Re: [RESEND PATCH] arm64: bpf: add 'store immediate' instruction

2015-12-01 Thread Shi, Yang
On 11/30/2015 2:24 PM, Yang Shi wrote: aarch64 doesn't have native store immediate instruction, such operation has to be implemented by the below instruction sequence: Load immediate to register Store register Signed-off-by: Yang Shi CC: Zi Shen Lim

Re: [RFC] Stable interface index option

2015-12-01 Thread Stephen Hemminger
On Tue, 01 Dec 2015 22:54:54 +0100 Hannes Frederic Sowa wrote: > > On Tue, Dec 1, 2015, at 22:44, Stephen Hemminger wrote: > > On Tue, 01 Dec 2015 22:14:59 +0100 > > Hannes Frederic Sowa wrote: > > > I had several snmp installations with

Re: [PATCH] wan/x25: Fix use-after-free in x25_asy_open_tty()

2015-12-01 Thread David Miller
From: Peter Hurley Date: Fri, 27 Nov 2015 14:18:39 -0500 > The N_X25 line discipline may access the previous line discipline's closed > and already-freed private data on open [1]. > > The tty->disc_data field _never_ refers to valid data on entry to the > line

Re: [RFC] Stable interface index option

2015-12-01 Thread Hannes Frederic Sowa
On Tue, Dec 1, 2015, at 20:27, David Miller wrote: > From: Hannes Frederic Sowa > Date: Tue, 01 Dec 2015 17:02:23 +0100 > > > On Tue, Dec 1, 2015, at 16:50, Maximilian Wilhelm wrote: > >> > I'm not sure I understand how this would work- are we going to > >> > pin

Re: [PATCH net v2] openvswitch: properly refcount vport-vxlan module

2015-12-01 Thread David Miller
From: Paolo Abeni Date: Mon, 30 Nov 2015 12:31:43 +0100 > After 614732eaa12d, no refcount is maintained for the vport-vxlan module. > This allows the userspace to remove such module while vport-vxlan > devices still exist, which leads to later oops. > > v1 -> v2: > - move

Re: [PATCH 00/13] mvneta Buffer Management and enhancements

2015-12-01 Thread Marcin Wojtas
Hi Gregory, Thanks for the log. I think it may be an overall problem with 4GB size representation in mvebu_mbus_dram_info structure? Maybe whole DRAM space is associated to CS0, and the 4GB size (0x1 ) does not fit u32 variable? Best regards, Marcin 2015-12-01 14:12 GMT+01:00 Gregory

Re: Increasing skb->mark size

2015-12-01 Thread Daniel Borkmann
On 12/01/2015 08:13 PM, Andi Kleen wrote: Lorenzo Colitti writes: On Wed, Nov 25, 2015 at 5:32 AM, Matt Bennett wrote: I'm emailing this list for feedback on the feasibility of increasing skb->mark or adding a new field for marking.

Re: size overflow in function qdisc_tree_decrease_qlen net/sched/sch_api.c

2015-12-01 Thread Eric Dumazet
On Tue, 2015-12-01 at 11:17 -0800, Cong Wang wrote: > On Tue, Dec 1, 2015 at 11:09 AM, Eric Dumazet wrote: > > On Tue, 2015-12-01 at 10:43 -0800, Cong Wang wrote: > > > >> This smells hacky... Another way to fix this is to hold the qdisc tree > >> lock in mq_dump(), since

Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

2015-12-01 Thread David Miller
From: Michal Hocko Date: Mon, 30 Nov 2015 14:21:29 +0100 > On Sat 28-11-15 15:51:13, Pavel Machek wrote: >> >> atl1c driver is doing order-4 allocation with GFP_ATOMIC >> priority. That often breaks networking after resume. Switch to >> GFP_KERNEL. Still not ideal, but

Re: [PATCH net-next v6] mpls: support for dead routes

2015-12-01 Thread David Miller
From: Roopa Prabhu Date: Sat, 28 Nov 2015 19:38:33 -0800 > Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls > routes due to link events. Also adds code to ignore dead > routes during route selection. I agree with Robert's feedback that we probably should

Re: [v8, 2/6] fsl/fman: Add FMan support

2015-12-01 Thread David Miller
From: Date: Mon, 30 Nov 2015 14:20:58 +0200 > +typedef irqreturn_t (fman_exceptions_cb)(struct fman *fman, > + enum fman_exceptions exception); Function and function pointer declarations and definitions should be indented such

forwarding of ipv4 link local addresses

2015-12-01 Thread David Ahern
RFC 3927 states that packets from/to IPv4 link-local addresses (169.254/16) should not be forwarded, yet the Linux networking stack happily forwards them. Before sending in a patch I wanted to inquire if this behavior is intentional. Thanks, David -- To unsubscribe from this list: send the

Re: [RFCv3 bluetooth-next 2/4] 6lowpan: add debugfs support

2015-12-01 Thread Stefan Schmidt
Hello. On 29/11/15 12:34, Alexander Aring wrote: This patch will introduce a 6lowpan entry into the debugfs if enabled. Inside this 6lowpan directory we create a subdirectories of all 6lowpan interfaces to offer a per interface debugfs support. Signed-off-by: Alexander Aring

Re: [RFC] Stable interface index option

2015-12-01 Thread Hannes Frederic Sowa
On Tue, Dec 1, 2015, at 21:57, David Miller wrote: > From: Stephen Hemminger > Date: Tue, 1 Dec 2015 12:20:38 -0800 > > > On Tue, 01 Dec 2015 14:28:47 -0500 (EST) > > David Miller wrote: > > > >> From: Stephen Hemminger

Re: "hw csum failure" error on skge driver with 4.3 kernel upon receiving ICMPv6 multicast listener discovery packets

2015-12-01 Thread Stephen Hemminger
On Tue, 1 Dec 2015 22:07:45 +0100 Stefan Ring wrote: > On Sun, Nov 15, 2015 at 7:44 PM, David Madore wrote: > > The skge driver in the 4.3 kernel reports hardware checksum errors > > upon receiving (certain?) IPv6 multicast packets containing ICMPv6 > >

[PATCH net-next V3 11/17] hv_netvsc: Eliminate page_buf from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate page_buf from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h |4 ++-- drivers/net/hyperv/netvsc.c | 25 ++---

Re: [RFC] Stable interface index option

2015-12-01 Thread Maximilian Wilhelm
Anno domini 2015 Hannes Frederic Sowa scripsit: > On Tue, Dec 1, 2015, at 20:27, David Miller wrote: > > From: Hannes Frederic Sowa > > Date: Tue, 01 Dec 2015 17:02:23 +0100 > > > > > On Tue, Dec 1, 2015, at 16:50, Maximilian Wilhelm wrote: > > >> > I'm not sure I

Re: size overflow in function qdisc_tree_decrease_qlen net/sched/sch_api.c

2015-12-01 Thread Eric Dumazet
On Tue, 2015-12-01 at 14:47 -0800, Cong Wang wrote: > On Tue, Dec 1, 2015 at 2:33 PM, Eric Dumazet wrote: > > Hmm... it looks like we have a much more serious bug : > > > > qdisc_lookup() calls qdisc_match_from_root(dev->qdisc, handle) without > > proper lock being held,

[PATCH net-next V3 01/17] hv_netvsc: Resize some of the variables in hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
As part of reducing the size of the hv_netvsc_packet, resize some of the variables based on their usage. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 14 +++--- 1 files changed, 7

Re: [RFC] Stable interface index option

2015-12-01 Thread Hannes Frederic Sowa
Hello, On Tue, Dec 1, 2015, at 23:43, Maximilian Wilhelm wrote: > Anno domini 2015 Hannes Frederic Sowa scripsit: > > > On Tue, Dec 1, 2015, at 20:27, David Miller wrote: > > > From: Hannes Frederic Sowa > > > Date: Tue, 01 Dec 2015 17:02:23 +0100 > > > > > > > On

Re: r8169 regression: UDP packets dropped intermittantly

2015-12-01 Thread Francois Romieu
Jonathan Woithe : [...] > Any thoughts or progress at this stage? Are there further tests you need me > to do ? Yes but you should expect two more days without signal. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: size overflow in function qdisc_tree_decrease_qlen net/sched/sch_api.c

2015-12-01 Thread Cong Wang
On Tue, Dec 1, 2015 at 2:33 PM, Eric Dumazet wrote: > Hmm... it looks like we have a much more serious bug : > > qdisc_lookup() calls qdisc_match_from_root(dev->qdisc, handle) without > proper lock being held, so we might actually crash the host, > if

[PATCH net-next V3 05/17] hv_netvsc: Eliminatte the data field from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminatte the data field from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h |5 ++--- drivers/net/hyperv/netvsc.c |5 +++-- drivers/net/hyperv/netvsc_drv.c |

[PATCH net-next V3 00/17] hv_netvsc: Eliminate the additional head room

2015-12-01 Thread K. Y. Srinivasan
In an attempt to avoid having to allocate memory on the send path, the netvsc driver was requesting additional head room so that both rndis header and the netvsc packet (the state that had to persist) could be placed in the skb. Since the amount of head room requested was exceeding the default

[PATCH net-next V3 10/17] hv_netvsc: remove locking in netvsc_send()

2015-12-01 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov Packet scheduler guarantees there won't be multiple senders for the same queue and as we use q_idx for multi_send_data the spinlock is redundant. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan

[PATCH net-next V3 08/17] hv_netvsc: Don't ask for additional head room in the skb

2015-12-01 Thread K. Y. Srinivasan
The rndis header is 116 bytes big and can be placed in the default head room that will be available in the skb. Since the netvsc packet is less than 48 bytes, we can use the skb control buffer for the netvsc packet. With these changes we don't need to ask for additional head room. Signed-off-by:

[PATCH net-next V3 04/17] hv_netvsc: Eliminate rndis_msg pointer from hv_netvsc_packet structure

2015-12-01 Thread K. Y. Srinivasan
Eliminate rndis_msg pointer from hv_netvsc_packet structure. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h |8 +++- drivers/net/hyperv/netvsc.c | 10 ++

Re: [PATCH 00/13] mvneta Buffer Management and enhancements

2015-12-01 Thread Marcin Wojtas
Gregory, Please apply below patch: http://pastebin.com/t42xyU3i It will confirm if there's an overflow for CS0 size in your setup. Please let know. So far the issue may have been not noticed, because in every IO driver using mvebu_mbus_dram_info for configuring MBUS windows, there's following

Re: [PATCH 1/2 net-next] ravb: Add fallback compatibility strings

2015-12-01 Thread Simon Horman
On Tue, Dec 01, 2015 at 09:42:52AM +0100, Geert Uytterhoeven wrote: > On Tue, Dec 1, 2015 at 8:43 AM, Simon Horman > wrote: > > Add fallback compatibility strings for R-Car Gen 2 & 3 SoC Families. > > This is in keeping with the fallback scheme being adopted wherever

Re: size overflow in function qdisc_tree_decrease_qlen net/sched/sch_api.c

2015-12-01 Thread Cong Wang
On Tue, Dec 1, 2015 at 12:06 PM, Eric Dumazet wrote: > On Tue, 2015-12-01 at 11:17 -0800, Cong Wang wrote: >> On Tue, Dec 1, 2015 at 11:09 AM, Eric Dumazet wrote: >> > On Tue, 2015-12-01 at 10:43 -0800, Cong Wang wrote: >> > >> >> This smells

[PATCH net-next v2 0/5] ila: Optimization to preserve value of early demux

2015-12-01 Thread Tom Herbert
In the current implementation of ILA, LWT is used to perform translation on both the input and output paths. This is functional, however there is a big performance hit in the receive path. Early demux occurs before the routing lookup (a hit actually obviates the route lookup). Therefore the stack

[PATCH net-next V3 07/17] hv_netvsc: Eliminate send_completion_ctx from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate send_completion_ctx from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h |1 - drivers/net/hyperv/netvsc.c |3 +-- drivers/net/hyperv/netvsc_drv.c |1 -

[PATCH net-next v2 2/5] rhashtable: add function to replace an element

2015-12-01 Thread Tom Herbert
Add the rhashtable_replace_fast function. This replaces one object in the table with another atomically. The hashes of the new and old objects must be equal. Signed-off-by: Tom Herbert --- include/linux/rhashtable.h | 82 ++ 1

[PATCH net-next V3 17/17] hv_netvsc: Eliminate vlan_tci from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate vlan_tci from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h |4 ++-- drivers/net/hyperv/netvsc_drv.c | 14 +++--- drivers/net/hyperv/rndis_filter.c |7 +++ 3 files changed, 12 insertions(+),

[PATCH net-next V3 13/17] hv_netvsc: Eliminate is_data_pkt from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate is_data_pkt from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h |1 - drivers/net/hyperv/netvsc.c | 14 -- drivers/net/hyperv/netvsc_drv.c |1 - drivers/net/hyperv/rndis_filter.c |1 -

[PATCH ney-next V3 12/17] hv_netvsc: Eliminate send_completion_tid from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate send_completion_tid from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h |8 ++-- drivers/net/hyperv/netvsc.c | 28 ++-- drivers/net/hyperv/netvsc_drv.c | 14 ++

[PATCH net-next V3 09/17] hv_netvsc: move subchannel existence check to netvsc_select_queue()

2015-12-01 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h | 15 --- drivers/net/hyperv/netvsc.c |5 ++--- drivers/net/hyperv/netvsc_drv.c |3

[PATCH net-next V3 14/17] hv_netvsc: Eliminate completion_func from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate completion_func from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h |1 - drivers/net/hyperv/netvsc_drv.c |3 --- drivers/net/hyperv/rndis_filter.c |1 - 3 files changed, 0 insertions(+), 5 deletions(-)

[PATCH net-next V3 02/17] hv_netvsc: Rearrange the hv_negtvsc_packet to be space efficient

2015-12-01 Thread K. Y. Srinivasan
Rearrange the elements of struct hv_negtvsc_packet for optimal layout - eliminate unnecessary padding. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 18 ++ 1 files changed, 10

[PATCH net-next V3 06/17] hv_netvsc: Eliminate send_completion from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate send_completion from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h |3 +-- drivers/net/hyperv/netvsc.c |6 +++--- drivers/net/hyperv/netvsc_drv.c |

[PATCH iproute2 -next] examples, bpf: further improve examples

2015-12-01 Thread Daniel Borkmann
Improve example files further and add a more generic set of possible helpers for them that can be used. Signed-off-by: Daniel Borkmann --- examples/bpf/bpf_cyclic.c | 38 examples/bpf/bpf_funcs.h| 76 --- examples/bpf/bpf_graft.c| 39

Re: [RFC 1/4] net: support per queue tx_usecs in sysfs

2015-12-01 Thread Jesse Brandeburg
On Tue, 1 Dec 2015 14:13:34 -0800 Florian Fainelli wrote: > On 01/12/15 00:01, kan.li...@intel.com wrote: > > From: Kan Liang > > > > Network devices usually have many queues. Each queue has its own > > tx_usecs options. Currently, we can only set all

Re: [PATCH 1/2 net-next] ravb: Add fallback compatibility strings

2015-12-01 Thread Simon Horman
On Tue, Dec 01, 2015 at 01:26:08PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/1/2015 10:43 AM, Simon Horman wrote: > > >Add fallback compatibility strings for R-Car Gen 2 & 3 SoC Families. > >This is in keeping with the fallback scheme being adopted wherever > >appropriate for drivers for

Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload

2015-12-01 Thread Singhai, Anjali
On 12/1/2015 8:08 AM, John W. Linville wrote: On Tue, Dec 01, 2015 at 04:49:28PM +0100, Hannes Frederic Sowa wrote: On Tue, Dec 1, 2015, at 16:44, John W. Linville wrote: On Mon, Nov 30, 2015 at 09:26:51PM -0800, Tom Herbert wrote: On Mon, Nov 30, 2015 at 5:28 PM, Jesse Gross

[PATCH net-next v2 4/5] ila: Add generic ILA translation facility

2015-12-01 Thread Tom Herbert
This patch implements an ILA tanslation table. This table can be configured with identifier to locator mappings, and can be be queried to resolve a mapping. Queries can be parameterized based on interface, direction (incoming or outoing), and matching locator. The table is implemented using

[PATCH net-next V3 16/17] hv_netvsc: Eliminate status from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate status from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h |1 - drivers/net/hyperv/netvsc.c |6 ++ drivers/net/hyperv/netvsc_drv.c |8 ++-- drivers/net/hyperv/rndis_filter.c | 20

[PATCH net-next v2 3/5] netlink: add a start callback for starting a netlink dump

2015-12-01 Thread Tom Herbert
The start callback allows the caller to set up a context for the dump callbacks. Presumably, the context can then be destroyed in the done callback. Signed-off-by: Tom Herbert --- include/linux/netlink.h | 2 ++ include/net/genetlink.h | 2 ++ net/netlink/af_netlink.c

[PATCH net-next v2 5/5] net: ILA iptables target

2015-12-01 Thread Tom Herbert
Add two target ILAIN and ILAOUT which hook into the ILA module. Signed-off-by: Tom Herbert --- net/netfilter/Kconfig | 12 net/netfilter/Makefile | 1 + net/netfilter/xt_ILA.c | 82 ++ 3 files changed, 95

[PATCH net-next v2 1/5] ila: Create net/ipv6/ila directory

2015-12-01 Thread Tom Herbert
Create ila directory in preparation for supporting other hooks in the kernel than LWT for doing ILA. This includes: - Moving ila.c to ila/ila_lwt.c - Splitting out some common functions into ila_common.c Signed-off-by: Tom Herbert --- net/ipv6/Makefile | 2 +-

[PATCH net-next V3 15/17] hv_netvsc: Eliminate xmit_more from struct hv_netvsc_packet

2015-12-01 Thread K. Y. Srinivasan
Eliminate xmit_more from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h |1 - drivers/net/hyperv/netvsc.c | 13 - drivers/net/hyperv/netvsc_drv.c |1 - drivers/net/hyperv/rndis_filter.c |2 --

Re: ipsec impact on performance

2015-12-01 Thread David Ahern
On 12/1/15 10:17 AM, Rick Jones wrote: On 12/01/2015 09:59 AM, Sowmini Varadhan wrote: But these are all still relatively small things - tweaking them doesnt get me significantly past the 3 Gbps limit. Any suggestions on how to make this budge (or design criticism of the patch) would be

Re: ipsec impact on performance

2015-12-01 Thread Sowmini Varadhan
On (12/01/15 16:56), David Ahern wrote: > > Using iperf3 and AH with NULL algorithm between 2 peers connected by > a 10G link. > I'm using esp-null, not AH, and iperf2, which I understand is quite different from, and more aggressive than, iperf3 (though I'm not sure that it matters for this

Re: [RFC] Stable interface index option

2015-12-01 Thread Andrew Lunn
> In general the ifindexes are designed to not be reused very fast. Some parts of multicast group management rely on this. You need to remove group memberships from a socket when an interface has disappeared, e.g. a VPN interface has gone away. You can pass the ifindex of the no longer existing

Re: [RFC 1/4] net: support per queue tx_usecs in sysfs

2015-12-01 Thread Alexander Duyck
On Tue, Dec 1, 2015 at 3:44 PM, Jesse Brandeburg wrote: > On Tue, 1 Dec 2015 14:13:34 -0800 > Florian Fainelli wrote: > >> On 01/12/15 00:01, kan.li...@intel.com wrote: >> > From: Kan Liang >> > >> > Network devices usually

Re: [PATCH net-next V3 00/17] hv_netvsc: Eliminate the additional head room

2015-12-01 Thread David Miller
From: "K. Y. Srinivasan" Date: Tue, 1 Dec 2015 16:42:58 -0800 > In an attempt to avoid having to allocate memory on the send path, the netvsc > driver was requesting additional head room so that both rndis header and the > netvsc packet (the state that had to persist) could

Re: Increasing skb->mark size

2015-12-01 Thread Andi Kleen
> >This would be be great. I've recently ran into some issues with > >the overhead of the Android firewall setup. > > > >So basically you need 4 extra bytes in sk_buff. How about: > > > >- shrinking skb->priority to 2 byte > > That wouldn't work, see SO_PRIORITY and such (4 bytes) ... But does

Re: [PATCH net] bpf, array: fix heap out-of-bounds access when updating elements

2015-12-01 Thread David Miller
From: Daniel Borkmann Date: Mon, 30 Nov 2015 13:02:55 +0100 > During own review but also reported by Dmitry's syzkaller [1] it has been > noticed that we trigger a heap out-of-bounds access on eBPF array maps > when updating elements. This happens with each map whose

Re: [PATCH v4 net 0/6] Marvell Armada XP/370/38X Neta fixes

2015-12-01 Thread David Miller
From: Marcin Wojtas Date: Mon, 30 Nov 2015 13:27:40 +0100 > I'm sending v4 with corrected commit log of the last patch, in order > to avoid possible conflicts between the branches as suggested by > Gregory Clement. Series applied, thanks. -- To unsubscribe from this list:

Re: [RFC 1/4] net: support per queue tx_usecs in sysfs

2015-12-01 Thread David Miller
From: Florian Fainelli Date: Tue, 01 Dec 2015 14:13:34 -0800 > The new interface you propose makes things inconsistent, since we have > two separate configuration paths (sysfs and ethtool), and it would seem > better to have per-queue awareness in ethtool, since there is a

Re: [PATCH net-next v3 03/17] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

2015-12-01 Thread David Miller
From: David Decotigny Date: Mon, 30 Nov 2015 14:05:41 -0800 > This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by > the new get_ksettings/set_ksettings callbacks. This API provides > support for most legacy ethtool_cmd fields, adds support for larger > link

[PATCH net 1/3] bnxt_en: Fixed incorrect implementation of ndo_set_mac_address

2015-12-01 Thread Michael Chan
From: Jeffrey Huang The existing ndo_set_mac_address only copies the new MAC addr and didn't set the new MAC addr to the HW. The correct way is to delete the existing default MAC filter from HW and add the new one. Because of RFS filters are also dependent on the default

Re: ipsec impact on performance

2015-12-01 Thread David Ahern
On 12/1/15 5:09 PM, Sowmini Varadhan wrote: The not-so-great news is that I see that just adding perf tracepoints (not even enabling them!) seems to make a small diff (3 Gbps vs 3.2 Gbps) to my numbers. Is that mere standard-deviation, or something one should be aware of, about perf? existence

Re: [RFC 1/4] net: support per queue tx_usecs in sysfs

2015-12-01 Thread David Miller
From: Jesse Brandeburg Date: Tue, 1 Dec 2015 15:44:54 -0800 > While I agree that ethtool provides a similar functionality, ethtool > was designed (particularly the ethtool -C/c commands) around one queue > NICs. We can't change the output or functionality of the user

[PATCH net 0/3] bnxt_en: set mac address and uc_list bug fixes.

2015-12-01 Thread Michael Chan
Fix ndo_set_mac_address() for PF and VF. Re-apply uc_list after chip reset. Michael Chan (3): bnxt_en: Fixed incorrect implemenation of ndo_set_mac_address bnxt_en: enforce properly storing of MAC address bnxt_en: Setup uc_list mac filters after resetting the chip.

[PATCH net 2/3] bnxt_en: enforce properly storing of MAC address

2015-12-01 Thread Michael Chan
From: Jeffrey Huang For PF, the bp->pf.mac_addr always holds the permanent MAC addr assigned by the HW. For VF, the bp->vf.mac_addr always holds the administrator assigned VF MAC addr. The random generated VF MAC addr should never get stored to bp->vf.mac_addr. This way,

[PATCH net 3/3] bnxt_en: Setup uc_list mac filters after resetting the chip.

2015-12-01 Thread Michael Chan
Call bnxt_cfg_rx_mode() in bnxt_init_chip() to setup uc_list and mc_list mac address filters. Before the patch, uc_list is not setup again after chip reset (such as ethtool ring size change) and macvlans don't work any more after that. Modify bnxt_cfg_rx_mode() to return error codes

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-12-01 Thread Alexander Duyck
On Tue, Dec 1, 2015 at 7:28 AM, Michael S. Tsirkin wrote: > On Tue, Dec 01, 2015 at 11:04:31PM +0800, Lan, Tianyu wrote: >> >> >> On 12/1/2015 12:07 AM, Alexander Duyck wrote: >> >They can only be corrected if the underlying assumptions are correct >> >and they aren't. Your

Re: IPv4 tunnels: why IP-IP and SIT enforce DF bit, but GRE does not?

2015-12-01 Thread David Miller
From: Hannes Frederic Sowa Date: Tue, 01 Dec 2015 14:30:55 +0100 > On Tue, Dec 1, 2015, at 14:20, Konstantin Shemyak wrote: >> My point was not to question its feasibility, but to make it similar >> across GRE, IP-IP and SIT tunnels. > > I would send a patch to add

[PATCH net] openvswitch: fix hangup on vxlan/gre/geneve device deletion

2015-12-01 Thread Paolo Abeni
Each openvswitch tunnel vport (vxlan,gre,geneve) holds a reference to the underlying tunnel device, but never released it when such device is deleted. Deleting the underlying device via the ip tool cause the kernel to hangup in the netdev_wait_allrefs() loop. This commit ensure that on device

Re: [patch net-next 00/26] bonding/team offload + mlxsw implementation

2015-12-01 Thread Jiri Pirko
Tue, Dec 01, 2015 at 05:35:43PM CET, gerlitz...@gmail.com wrote: >On Tue, Dec 1, 2015 at 5:12 PM, Jiri Pirko wrote: >> Tue, Dec 01, 2015 at 04:06:23PM CET, gerlitz...@gmail.com wrote: >>>On Tue, Dec 1, 2015 at 4:43 PM, Jiri Pirko wrote: Tue, Dec 01, 2015

[PATCH net-next] ravb: ptp: Add CONFIG mode support

2015-12-01 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi This patch makes PTP support active in CONFIG mode on R-Car Gen3. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko --- This patch is based on the master branch of

Re: [RFC PATCH] af_unix: fix entry locking in unix_dgram_recvmsg

2015-12-01 Thread Rainer Weikusat
Rainer Weikusat writes: [...] > Insofar I understand the comment in this code block correctly, > > err = mutex_lock_interruptible(>readlock); > if (unlikely(err)) { > /* recvmsg() in non blocking mode is supposed to

Re: BUG: soft lockup happened for ixgbevf

2015-12-01 Thread Alexander Duyck
On 11/30/2015 11:12 PM, Ding Tianhong wrote: Hi Everyone: I found this problem when using the Testgine to send package to the 82599 ethernet: 1.wait for the speed to 10G/bit, it's ok. 2.then down the eth and then up, loop for several times. 3.then the softlockup happened. [ 317.005148] IPv6:

  1   2   3   4   >