Re: [PATCH V2 3/3] vhost_net: basic polling support

2016-01-20 Thread Yang Zhang
On 2016/1/20 22:35, Michael S. Tsirkin wrote: On Tue, Dec 01, 2015 at 02:39:45PM +0800, Jason Wang wrote: This patch tries to poll for new added tx buffer or socket receive queue for a while at the end of tx/rx processing. The maximum time spent on polling were specified through a new kind of

Re: [PATCH net v2] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread David Miller
From: Jesse Gross Date: Wed, 20 Jan 2016 17:59:49 -0800 > GRO is currently not aware of tunnel metadata generated by lightweight > tunnels and stored in the dst. This leads to two possible problems: > * Incorrectly merging two frames that have different metadata. > * Leaking

Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Jesse Gross
On Wed, Jan 20, 2016 at 4:48 PM, Eric Dumazet wrote: > On Wed, 2016-01-20 at 16:27 -0800, Jesse Gross wrote: >> GRO is currently not aware of tunnel metadata generated by lightweight >> tunnels and stored in the dst. This leads to two possible problems: >> * Incorrectly

Re: [PATCH net-next 2/2] tg3: Fix for tg3 transmit queue 0 timed out when too many gso_segs.

2016-01-20 Thread Michael Chan
On Wed, 2016-01-20 at 20:36 -0800, Eric Dumazet wrote: > On Wed, 2016-01-20 at 17:16 +0530, skallam wrote: > > From: Siva Reddy Kallam > > > > There is an issue on the GSO path inside tg3_tso_bug() when we don't > > have sufficient descriptors available, we stop the

Re: [PATCH net-next 2/2] tg3: Fix for tg3 transmit queue 0 timed out when too many gso_segs.

2016-01-20 Thread Eric Dumazet
On Wed, 2016-01-20 at 17:16 +0530, skallam wrote: > From: Siva Reddy Kallam > > There is an issue on the GSO path inside tg3_tso_bug() when we don't > have sufficient descriptors available, we stop the queue. This queue > may never get started again as there are no Tx

Re: [PATCH] net: take care of bonding in build_skb_flow_key (v3)

2016-01-20 Thread Wengang Wang
在 2016年01月21日 12:05, Jay Vosburgh 写道: Wengang Wang wrote: [...] For ipip, yes seems update_pmtu is called in line for each call of queue_xmit. Do you know if it's a good configuration for ipip + bonding? Yes, it is. Other's comment and suggestion?

Re: [PATCH V2 3/3] vhost_net: basic polling support

2016-01-20 Thread Michael S. Tsirkin
On Thu, Jan 21, 2016 at 10:11:35AM +0800, Yang Zhang wrote: > On 2016/1/20 22:35, Michael S. Tsirkin wrote: > >On Tue, Dec 01, 2015 at 02:39:45PM +0800, Jason Wang wrote: > >>This patch tries to poll for new added tx buffer or socket receive > >>queue for a while at the end of tx/rx processing.

Re: question about samsung/sxgbe/sxgbe_xpcs.c

2016-01-20 Thread Jεan Sacren
From: David Miller Date: Tue, 19 Jan 2016 14:36:28 -0500 > > From: Julia Lawall > Date: Tue, 19 Jan 2016 19:54:20 +0100 (CET) [...] > > I just wondered. I was looking at dependencies between networking files. > > This one stands out because nothing

Re: [PATCH] net: take care of bonding in build_skb_flow_key (v3)

2016-01-20 Thread Wengang Wang
在 2016年01月20日 23:18, Sabrina Dubroca 写道: 2016-01-20, 13:32:13 +0800, Wengang Wang wrote: In a bonding setting, we determines fragment size according to MTU and PMTU associated to the bonding master. If the slave finds the fragment size is too big, it drops the fragment and calls

Re: [PATCH V2 3/3] vhost_net: basic polling support

2016-01-20 Thread Yang Zhang
On 2016/1/21 13:13, Michael S. Tsirkin wrote: On Thu, Jan 21, 2016 at 10:11:35AM +0800, Yang Zhang wrote: On 2016/1/20 22:35, Michael S. Tsirkin wrote: On Tue, Dec 01, 2015 at 02:39:45PM +0800, Jason Wang wrote: This patch tries to poll for new added tx buffer or socket receive queue for a

[PATCH net v2] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Jesse Gross
GRO is currently not aware of tunnel metadata generated by lightweight tunnels and stored in the dst. This leads to two possible problems: * Incorrectly merging two frames that have different metadata. * Leaking of allocated metadata from merged frames. This avoids those problems by comparing

Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Eric Dumazet
On Wed, 2016-01-20 at 17:47 -0800, Jesse Gross wrote: > Just to merge the two threads together, all of protocols that would be > affected by this also have "normal" GRO handlers that will run when > the packet is first received. There's no argument that that is > preferable if it is available.

Re: [PATCH] net: take care of bonding in build_skb_flow_key (v3)

2016-01-20 Thread Wengang Wang
在 2016年01月20日 17:56, zhuyj 写道: On 01/20/2016 05:47 PM, Wengang Wang wrote: 在 2016年01月20日 15:54, zhuyj 写道: On 01/20/2016 03:38 PM, Wengang Wang wrote: 在 2016年01月20日 14:24, zhuyj 写道: On 01/20/2016 01:32 PM, Wengang Wang wrote: In a bonding setting, we determines fragment size according

Re: [PATCH net] net: diag: support v4mapped sockets in inet_diag_find_one_icsk()

2016-01-20 Thread Lorenzo Colitti
On Wed, Jan 20, 2016 at 4:25 PM, Eric Dumazet wrote: > Lorenzo reported that we could not properly find v4mapped sockets > in inet_diag_find_one_icsk(). This patch fixes the issue. > > Reported-by: Lorenzo Colitti > Signed-off-by: Eric Dumazet

Re: [PATCH net 0/3] net: phy: Finally fix PHY_IGNORE_INTERRUPTS

2016-01-20 Thread David Miller
From: Date: Thu, 21 Jan 2016 00:59:42 + > > I'm experiencing misbehavior after restart system. >> Can you wait applying the patch? >> >> Sorry about it. >> Woojung > > Sorry for spam. Version mismatch happened. :( > It works as expected on USB-to-Ethernet point

Re: [PATCH net-next 0/2] tg3: update on maintainer and fix for tx timeout

2016-01-20 Thread David Miller
From: skallam Date: Wed, 20 Jan 2016 17:16:56 +0530 > From: Siva Reddy Kallam > > First patch: > This patch includes additional maintainer for tg3 > > Second patch: > Fix for tg3 transmit queue 0 timed out when too many gso_segs

Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Thomas Graf
On 01/20/16 at 05:47pm, Jesse Gross wrote: > Just to merge the two threads together, all of protocols that would be > affected by this also have "normal" GRO handlers that will run when > the packet is first received. There's no argument that that is > preferable if it is available. However, GRO

[PATCH iproute2] ip-link: remove warning message

2016-01-20 Thread Zhang Shengju
the warning was: iproute.c:301:12: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized] features &= ~RTAX_FEATURE_ECN; ^ iproute.c:575:10: note: 'val' was declared here __u32 val; ^ Signed-off-by: Zhang Shengju

Re: [PATCH 0/6] Netfilter fixes for net

2016-01-20 Thread David Miller
From: Pablo Neira Ayuso Date: Wed, 20 Jan 2016 18:03:58 +0100 > The following patchset contains Netfilter fixes for your net tree, they > are: > > 1) Fix accidental 3-times le/be conversion for 64-bits in nft_byteorder, >from Florian Westphal. > > 2) Get rid of

Re: [PATCH net] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Jesse Gross
On Wed, Jan 20, 2016 at 6:31 PM, Thomas Graf wrote: > On 01/20/16 at 05:47pm, Jesse Gross wrote: >> Just to merge the two threads together, all of protocols that would be >> affected by this also have "normal" GRO handlers that will run when >> the packet is first received. There's

Re: [PATCH net] net: change tcp_syn_retries documentation

2016-01-20 Thread David Miller
From: Xin Long Date: Wed, 20 Jan 2016 16:12:33 +0800 > Documentation should be kept consistent with the code: > > static int tcp_syn_retries_max = MAX_TCP_SYNCNT; > #define MAX_TCP_SYNCNT 127 > > Signed-off-by: Xin Long Applied.

[PATCH] net: take care of bonding in build_skb_flow_key (v4)

2016-01-20 Thread Wengang Wang
In a bonding setting, we determines fragment size according to MTU and PMTU associated to the bonding master. If the slave finds the fragment size is too big, it drops the fragment and calls ip_rt_update_pmtu(), passing _skb_ and _pmtu_, trying to update the path MTU. Problem is that the target

[PATCH] net:mac80211:mesh_plink: remove redundant sta_info check

2016-01-20 Thread Sunil Shahu
Remove unnecessory "if" statement and club it with previos "if" block. Signed-off-by: Sunil Shahu --- net/mac80211/mesh_plink.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/net/mac80211/mesh_plink.c b/net/mac80211/mesh_plink.c index

Re: Kernel memory leak in bnx2x driver with vxlan tunnel

2016-01-20 Thread Thomas Graf
On 01/20/16 at 04:34pm, Eric Dumazet wrote: > On Wed, 2016-01-20 at 16:19 -0800, Jesse Gross wrote: > > > I have a patch that implements the comparison between dsts. For > > packets without a dst, there isn't really a cost and if we do have a > > dst then GRO is still a benefit. So it seems like

Re: [PATCH] net: dp83640: Fix tx timestamp overflow handling.

2016-01-20 Thread David Miller
From: Richard Cochran Date: Wed, 20 Jan 2016 14:25:45 +0100 > On Wed, Jan 20, 2016 at 11:22:28AM +0100, Manfred Rudigier wrote: >> PHY status frames are not reliable, the PHY may not be able to send them >> during heavy receive traffic. This overflow condition is

Re: [PATCH RESEND v2] ixgbe: on recv increment rx.ring->stats.yields

2016-01-20 Thread Jeff Kirsher
On Wed, 2016-01-20 at 11:08 +0300, Pavel Tikhomirov wrote: > It seem to be non intentionaly changed to tx in > commit adc810900a70 ("ixgbe: Refactor busy poll socket code to > address > multiple issues") > > Lock is taken from ixgbe_low_latency_recv, and there under this > lock we use

Re: [PATCH net 0/3] net: phy: Finally fix PHY_IGNORE_INTERRUPTS

2016-01-20 Thread Florian Fainelli
On January 20, 2016 6:58:09 PM PST, David Miller wrote: >From: >Date: Thu, 21 Jan 2016 00:59:42 + > >> > I'm experiencing misbehavior after restart system. >>> Can you wait applying the patch? >>> >>> Sorry about it. >>> Woojung >> >> Sorry

Re: [PATCH net v2] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Thomas Graf
On 01/20/16 at 05:59pm, Jesse Gross wrote: > GRO is currently not aware of tunnel metadata generated by lightweight > tunnels and stored in the dst. This leads to two possible problems: > * Incorrectly merging two frames that have different metadata. > * Leaking of allocated metadata from merged

[PATCH] net/irda: bfin_sir: remove duplicate defines

2016-01-20 Thread Sudip Mukherjee
The defconfig build of blackfin is failing with the error: arch/blackfin/include/asm/bfin_serial.h:269:0: warning: "port_membase" redefined drivers/net/irda/bfin_sir.h:85:0: note: this is the location of the previous definition arch/blackfin/include/asm/bfin_serial.h:382:0: warning:

Re: [PATCH net] net: diag: support v4mapped sockets in inet_diag_find_one_icsk()

2016-01-20 Thread David Miller
From: Eric Dumazet Date: Wed, 20 Jan 2016 16:25:01 -0800 > From: Eric Dumazet > > Lorenzo reported that we could not properly find v4mapped sockets > in inet_diag_find_one_icsk(). This patch fixes the issue. > > Reported-by: Lorenzo Colitti

Re: [PATCH net v2] gro: Make GRO aware of lightweight tunnels.

2016-01-20 Thread Eric Dumazet
On Wed, 2016-01-20 at 17:59 -0800, Jesse Gross wrote: > GRO is currently not aware of tunnel metadata generated by lightweight > tunnels and stored in the dst. This leads to two possible problems: > * Incorrectly merging two frames that have different metadata. > * Leaking of allocated metadata

Re: [PATCH] net: take care of bonding in build_skb_flow_key (v3)

2016-01-20 Thread Jay Vosburgh
Wengang Wang wrote: [...] >For ipip, yes seems update_pmtu is called in line for each call of >queue_xmit. Do you know if it's a good configuration for ipip + bonding? Yes, it is. >Other's comment and suggestion? I agree with Sabrina Dubroca

Re: [PATCH v3 00/16] add Intel X722 iWARP driver

2016-01-20 Thread Or Gerlitz
On 1/21/2016 12:57 AM, Steve Wise wrote: I also asked you why the port mapper code has to be present in each iwarp driver and not part of the IB core stack, and you responded "i40iw iwarp driver registers with port mapper and uses its services. Beside that it is not the scope of the patch

RE: [PATCH net 0/3] net: phy: Finally fix PHY_IGNORE_INTERRUPTS

2016-01-20 Thread Woojung.Huh
> I'm experiencing misbehavior after restart system. > Can you wait applying the patch? > > Sorry about it. > Woojung Sorry for spam. Version mismatch happened. :( It works as expected on USB-to-Ethernet point of view. Woojung

Re: net: GPF in __netlink_ns_capable

2016-01-20 Thread Herbert Xu
On Wed, Jan 20, 2016 at 02:35:59PM +, Wan, Kaike wrote: > >From the code (netlink_dump() in net/netlink/af_netlink.c), it shows that a > >skb is allocated without initializing the skb->cb[] field, which will cause > >oops if netlink_capable() is called with the duplicate skb. This will

Re: [PATCH V3 5/5] net: can: ifi: Add IFI CANFD IP support

2016-01-20 Thread Marek Vasut
On Wednesday, January 20, 2016 at 03:46:58 PM, Marc Kleine-Budde wrote: > On 01/20/2016 03:41 PM, Marek Vasut wrote: > > On Wednesday, January 20, 2016 at 03:39:51 PM, Marc Kleine-Budde wrote: > >> On 01/20/2016 03:33 PM, Marek Vasut wrote: > >>> The patch adds support for IFI CAN/FD controller

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-20 Thread Jacob Siverskog
On Tue, Jan 5, 2016 at 3:39 PM, Eric Dumazet wrote: > On Tue, 2016-01-05 at 15:34 +0100, Jacob Siverskog wrote: >> On Tue, Jan 5, 2016 at 3:14 PM, Eric Dumazet wrote: > >> > >> > You might build a kernel with KASAN support to get maybe more chances

Re: ethtool NFC/ntuple API questions

2016-01-20 Thread Ben Hutchings
On Wed, 2016-01-20 at 09:53 -0800, Alexander Duyck wrote: > On Wed, Jan 20, 2016 at 9:10 AM, Edward Cree wrote: > > I'm looking into adding IPv6 support to the ethtool flow steering API.  But, > > I don't know "the unfortunate history of and subtle differences between the >

Re: [PATCH] net: take care of bonding in build_skb_flow_key (v3)

2016-01-20 Thread Sabrina Dubroca
2016-01-20, 13:32:13 +0800, Wengang Wang wrote: > In a bonding setting, we determines fragment size according to MTU and > PMTU associated to the bonding master. If the slave finds the fragment > size is too big, it drops the fragment and calls ip_rt_update_pmtu(), > passing _skb_ and _pmtu_,

Re: [PATCH v5 1/3] can: sja1000: of: add per-compatible init hook

2016-01-20 Thread Damien Riegel
Hi Marc, On Wed, Jan 20, 2016 at 11:23:49AM +0100, Marc Kleine-Budde wrote: > From: Damien Riegel > > This commit adds the capability to allocate and init private data > embedded in the sja1000_priv structure on a per-compatible basis. The > device node is

Re: mlx4 fails ("go bit not cleared") without MSI

2016-01-20 Thread Bjorn Helgaas
On Wed, Jan 20, 2016 at 3:42 AM, Yishai Hadas wrote: >> From: Bjorn Helgaas [mailto:bhelg...@google.com] >> I assume you're tried booting with "pci=nomsi" or "mlx_core.msi_x=0" >> and it works for you? Note that my board might be an internal design, >> not a Mellanox board,

Re: ethtool NFC/ntuple API questions

2016-01-20 Thread Alexander Duyck
On Wed, Jan 20, 2016 at 9:10 AM, Edward Cree wrote: > I'm looking into adding IPv6 support to the ethtool flow steering API. But, > I don't know "the unfortunate history of and subtle differences between the > RX n-tuple versus RX NFC commands". In particular, would I need

RE: net: GPF in __netlink_ns_capable

2016-01-20 Thread Wan, Kaike
The problem was caused by the RDMA_NL_LS_OP_RESOLVE request (not response) packet sent by the user application, which falls through the netlink_dump path and eventually calls ib_nl_handle_resp() with a new skb with uninitialized control block. Checking the NETLINK_CB(skb).sk before calling

Re: [PATCH V3 5/5] net: can: ifi: Add IFI CANFD IP support

2016-01-20 Thread Marc Kleine-Budde
On 01/20/2016 04:03 PM, Marek Vasut wrote: >> >> Doh! Right, let's try this: -#define IFI_CANFD_INTERRUPT_ERROR_WARNING BIT(1) +#define IFI_CANFD_INTERRUPT_ERROR_WARNING ((u32)BIT(1)) >>> >>> I'd be happy to be proven wrong though. >> >> /me too > > I think that will do the

Re: [PATCH v5 1/3] can: sja1000: of: add per-compatible init hook

2016-01-20 Thread Marc Kleine-Budde
On 01/20/2016 04:30 PM, Damien Riegel wrote: >> +static const struct of_device_id sp_of_table[] = { >> +{ /* sentinel */ }, >> +}; >> +MODULE_DEVICE_TABLE(of, sp_of_table); >> + > > I will give a try to this serie but it seems that > > {.compatible = "nxp,sja1000"}, > > has

[PATCH RT 1/2] net: provide a way to delegate processing a softirq to ksoftirqd

2016-01-20 Thread Sebastian Andrzej Siewior
If the NET_RX uses up all of his budget it moves the following NAPI invocations into the `ksoftirqd`. On -RT it does not do so. Instead it rises the NET_RX softirq in its current context again. In order to get closer to mainline's behaviour this patch provides __raise_softirq_irqoff_ksoft() which

Re: regression kernel 4.4: stops routing packets with a GRE-payload

2016-01-20 Thread Nicolas Dichtel
Le 20/01/2016 15:00, Wolfgang Walter a écrit : Hello, we tried 4.4 on our routers. We found one problem: 4.4 stops routing GRE packets (ipv4 in GRE/ipv4) here. 4.4.15 works fine. 4.4.15 does not exist. Is it 4.1.15?

[PATCH 2/6] netfilter: ipset: allow a 0 netmask with hash_netiface type

2016-01-20 Thread Pablo Neira Ayuso
From: Florian Westphal Jozsef says: The correct behaviour is that if we have ipset create test1 hash:net,iface ipset add test1 0.0.0.0/0,eth0 iptables -A INPUT -m set --match-set test1 src,src then the rule should match for any traffic coming in through eth0. This removes

[PATCH v6 2/3] can: sja1000: add documentation for Technologic Systems version

2016-01-20 Thread Marc Kleine-Budde
From: Damien Riegel This commit adds documentation for the Technologic Systems version of SJA1000. The difference with the NXP version is in the way the registers are accessed. Signed-off-by: Damien Riegel Signed-off-by:

[PATCH v6 3/3] can: sja1000: of: add compatibility with Technologic Systems version

2016-01-20 Thread Marc Kleine-Budde
From: Damien Riegel Technologic Systems provides an IP compatible with the SJA1000, instantiated in an FPGA. Because of some bus widths issue, access to registers is made through a "window" that works like this: base + 0x0: address to read/write base

Re: [PATCH V3 5/5] net: can: ifi: Add IFI CANFD IP support

2016-01-20 Thread Marek Vasut
On Wednesday, January 20, 2016 at 04:09:48 PM, Marc Kleine-Budde wrote: > On 01/20/2016 04:03 PM, Marek Vasut wrote: > >> Doh! Right, let's try this: > -#define IFI_CANFD_INTERRUPT_ERROR_WARNING BIT(1) > +#define IFI_CANFD_INTERRUPT_ERROR_WARNING ((u32)BIT(1)) > >>> > >>> I'd

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-20 Thread Eric Dumazet
On Wed, 2016-01-20 at 17:17 +0100, Jacob Siverskog wrote: > On Wed, Jan 20, 2016 at 4:48 PM, Eric Dumazet wrote: > > On Wed, 2016-01-20 at 16:06 +0100, Jacob Siverskog wrote: > >> On Tue, Jan 5, 2016 at 3:39 PM, Eric Dumazet > >> wrote: > >> > On

[PATCH 1/6] netfilter: nft_byteorder: avoid unneeded le/be conversion steps

2016-01-20 Thread Pablo Neira Ayuso
From: Florian Westphal David points out that we to three le/be conversions instead of just one. Doesn't matter on x86_64 w. gcc, but other architectures might be less lucky. Since it also simplifies code just follow his advice. Fixes: c0f3275f5cb ("nftables: byteorder: provide

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-20 Thread Peter Hurley
Hi Jacob, On 01/05/2016 06:34 AM, Jacob Siverskog wrote: > On Tue, Jan 5, 2016 at 3:14 PM, Eric Dumazet wrote: >> On Tue, 2016-01-05 at 12:07 +0100, Jacob Siverskog wrote: >>> On Mon, Jan 4, 2016 at 4:25 PM, Eric Dumazet wrote: On Mon,

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-20 Thread Eric Dumazet
On Wed, 2016-01-20 at 16:06 +0100, Jacob Siverskog wrote: > On Tue, Jan 5, 2016 at 3:39 PM, Eric Dumazet wrote: > > On Tue, 2016-01-05 at 15:34 +0100, Jacob Siverskog wrote: > >> On Tue, Jan 5, 2016 at 3:14 PM, Eric Dumazet > >> wrote: > > > >> >

ethtool NFC/ntuple API questions

2016-01-20 Thread Edward Cree
I'm looking into adding IPv6 support to the ethtool flow steering API. But, I don't know "the unfortunate history of and subtle differences between the RX n-tuple versus RX NFC commands". In particular, would I need to add IPv6 support to both of them, or only one? If one would be sufficient,

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-20 Thread Jacob Siverskog
On Wed, Jan 20, 2016 at 4:48 PM, Eric Dumazet wrote: > On Wed, 2016-01-20 at 16:06 +0100, Jacob Siverskog wrote: >> On Tue, Jan 5, 2016 at 3:39 PM, Eric Dumazet wrote: >> > On Tue, 2016-01-05 at 15:34 +0100, Jacob Siverskog wrote: >> >> On Tue, Jan

Re: [PATCH v3 4/4] net: mvneta: update clocks property and document additional clock-names

2016-01-20 Thread Rob Herring
On Wed, Jan 20, 2016 at 07:27:25PM +0800, Jisheng Zhang wrote: > Signed-off-by: Jisheng Zhang > --- > Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Acked-by: Rob Herring

[PATCH v3 14/16] i40iw: virtual channel handling files

2016-01-20 Thread Faisal Latif
i40iw_vf.[ch] and i40iw_virtchnl[ch] are used for virtual channel support for iWARP VF module. Changes since v2: code cleanup Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif

[PATCH v3 08/16] i40iw: add hw and utils files

2016-01-20 Thread Faisal Latif
i40iw_hw.c, i40iw_utils.c and i40iw_osdep.h are files to handle interrupts and processing. Changes since v1: Cleanup/removed some macros reported by Christoph Hellwig. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson

[PATCH v3 09/16] i40iw: add files for iwarp interface

2016-01-20 Thread Faisal Latif
i40iw_verbs.[ch] are to handle iwarp interface. Changes since v2: Made infiniband interface changes for 4.5 removed i40iw_reg_phys_mr() for 4.5 made changes as made by Christoph Hellwig made for nes in i40iw_get_dma_mr(). Changes since v1: Following

[PATCH v3 12/16] i40iw: add X722 register file

2016-01-20 Thread Faisal Latif
X722 Hardware registers defines for iWARP component. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_register.h | 1030

[PATCH v3 10/16] i40iw: add file to handle cqp calls

2016-01-20 Thread Faisal Latif
i40iw_ctrl.c provides for hardware wqe support and cqp. Changes since v2: cleanup coccinelle error reported by Julia Lawall Changes since v1: reported by Christoph Hellwig's review -remove unnecessary casts Acked-by: Anjali Singhai Jain

[PATCH v3 16/16] i40iw: changes for build of i40iw module

2016-01-20 Thread Faisal Latif
MAINTAINERS, Kconfig, and Makefile to build i40iw module Signed-off-by: Faisal Latif --- MAINTAINERS| 10 ++ drivers/infiniband/Kconfig | 1 + drivers/infiniband/hw/Makefile | 1 + 3 files changed, 12 insertions(+) diff --git

[PATCH v3 05/16] i40iw: add puda code

2016-01-20 Thread Faisal Latif
i40iw_puda.[ch] are files to handle iwarp connection packets as well as exception packets over multiple privilege mode uda queues. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif ---

[PATCH v3 03/16] i40iw: add main, hdr, status

2016-01-20 Thread Faisal Latif
i40iw_main.c contains routines for i40e <=> i40iw interface and setup. i40iw.h is header file for main device data structures. i40iw_status.h is for return status codes. Changes from v2: more cast improvement fixed timing issue during unload added paramater change call

[PATCH v3 15/16] i40iw: Kconfig and Makefile for iwarp module

2016-01-20 Thread Faisal Latif
Kconfig and Makefile needed to build iwarp module. Changes since v2: moved from Kbuild to Makefile Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/Kconfig | 7 +++ drivers/infiniband/hw/i40iw/Makefile | 9 + 2 files changed, 16

[PATCH v3 07/16] i40iw: add hmc resource files

2016-01-20 Thread Faisal Latif
i40iw_hmc.[ch] are to manage hmc for the device. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_hmc.c | 821

[PATCH v3 06/16] i40iw: add pble resource files

2016-01-20 Thread Faisal Latif
i40iw_pble.[ch] to manage pble resource for iwarp clients. Changes since v2: remove unnecessary casts Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif ---

[PATCH v3 11/16] i40iw: add hardware related header files

2016-01-20 Thread Faisal Latif
header files for hardware accesses Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_d.h| 1713 ++ drivers/infiniband/hw/i40iw/i40iw_p.h| 106 ++ drivers/infiniband/hw/i40iw/i40iw_type.h | 1312 +++

[PATCH v3 13/16] i40iw: user kernel shared files

2016-01-20 Thread Faisal Latif
i40iw_user.h and i40iw_uk.c are used by both user library as well as kernel requests. Acked-by: Anjali Singhai Jain Acked-by: Shannon Nelson Signed-off-by: Faisal Latif --- drivers/infiniband/hw/i40iw/i40iw_uk.c |

Re: ethtool NFC/ntuple API questions

2016-01-20 Thread Ben Hutchings
On Wed, 2016-01-20 at 19:12 +, Edward Cree wrote: > Thanks both, it's making more sense now. > One thing I'm still unclear about: why does struct ethtool_usrip4_spechave > the ip_ver field?  The struct can't be extended to cover ipv6, because the > address fields aren't big enough.  So what's

[PATCH v3 02/16] i40iw: add entry in rdma_netlink

2016-01-20 Thread Faisal Latif
Add entry for port mapper services. Changes since v2: moved this patch before being used Changes since v1: moved I40IW as last element Signed-off-by: Faisal Latif --- include/uapi/rdma/rdma_netlink.h | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v3 01/16] i40e: Add support for client interface for IWARP driver

2016-01-20 Thread Faisal Latif
From: Anjali Singhai Jain This patch adds a Client interface for i40iw driver support. Also expands the Virtchannel to support messages from i40evf driver on behalf of i40iwvf driver. This client API is used by the i40iw and i40iwvf driver to access the core driver

[PATCH v3 00/16] add Intel X722 iWARP driver

2016-01-20 Thread Faisal Latif
This driver provides iWARP RDMA functionality for the Intel(R) X722 Ethernet controller for PCI Physical Functions. It is in early product cycle and having the driver in the kernel will allow users to have hardware support when available for purchase. i40iw cooperates with the Intel(R) X722 base

[PATCH v3 04/16] i40iw: add connection management code

2016-01-20 Thread Faisal Latif
i40iw_cm.c i40iw_cm.h are used for connection management. changes since v2: Implemented interface changes as reg_phys_mr() is not part of inifiniband interface Done as Christoph Hellwig did for nes. Changes since v1: improved casts

Re: [PATCH net-next 6/8] net: gre: Implement LCO for GRE over IPv4

2016-01-20 Thread Tom Herbert
On Wed, Jan 20, 2016 at 11:35 AM, Alexander Duyck wrote: > On Wed, Jan 20, 2016 at 11:11 AM, Rustad, Mark D > wrote: >> Alexander Duyck wrote: >> >>> Actually you may want to go the other way on that. If they

Re: ethtool NFC/ntuple API questions

2016-01-20 Thread Edward Cree
Thanks both, it's making more sense now. One thing I'm still unclear about: why does struct ethtool_usrip4_spechave the ip_ver field? The struct can't be extended to cover ipv6, because the address fields aren't big enough. So what's it for? Also, would it be appropriate to use struct in6_addr

Re: [PATCH net-next 6/8] net: gre: Implement LCO for GRE over IPv4

2016-01-20 Thread Alexander Duyck
On Wed, Jan 20, 2016 at 11:11 AM, Rustad, Mark D wrote: > Alexander Duyck wrote: > >> Actually you may want to go the other way on that. If they weren't >> flipping the checksum value for GRE before why should we start doing >> that now? I'm

Re: [PATCH net-next 6/8] net: gre: Implement LCO for GRE over IPv4

2016-01-20 Thread Rustad, Mark D
Alexander Duyck wrote: Actually you may want to go the other way on that. If they weren't flipping the checksum value for GRE before why should we start doing that now? I'm pretty sure the checksum mangling is a very UDP centric thing. There is no need to

Re: [PATCH net-next 6/8] net: gre: Implement LCO for GRE over IPv4

2016-01-20 Thread Alexander Duyck
On Wed, Jan 20, 2016 at 11:58 AM, Tom Herbert wrote: > On Wed, Jan 20, 2016 at 11:35 AM, Alexander Duyck > wrote: >> On Wed, Jan 20, 2016 at 11:11 AM, Rustad, Mark D >> wrote: >>> Alexander Duyck

RE: [PATCH net 0/3] net: phy: Finally fix PHY_IGNORE_INTERRUPTS

2016-01-20 Thread Woojung.Huh
> > Targetting the "net" tree since these are bugfixes, but I would like > > Woojun and Andrew to take a look and test that on their respective > > HW setups as well. > > Ok I'll wait for Woojun and Andrew to give feedback. This patch fixes periodic phy read_status access when phy is configured

Re: [PATCH net 0/3] net: phy: Finally fix PHY_IGNORE_INTERRUPTS

2016-01-20 Thread Florian Fainelli
Le 20/01/2016 13:20, woojung@microchip.com a écrit : >>> Targetting the "net" tree since these are bugfixes, but I would like >>> Woojun and Andrew to take a look and test that on their respective >>> HW setups as well. >> >> Ok I'll wait for Woojun and Andrew to give feedback. > > This patch

RE: [PATCH v3 00/16] add Intel X722 iWARP driver

2016-01-20 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Or Gerlitz > Sent: Wednesday, January 20, 2016 4:25 PM > To: Faisal Latif > Cc: Doug Ledford; linux-r...@vger.kernel.org; Linux Netdev List; Jeff > Kirsher;

Re: Optimizing instruction-cache, more packets at each stage

2016-01-20 Thread Tom Herbert
On Wed, Jan 20, 2016 at 3:02 PM, Eric Dumazet wrote: > On Thu, 2016-01-21 at 00:20 +0200, Or Gerlitz wrote: > >> Dave, I assume you refer to the RSS hash result which is written by >> NIC HWs to the completion descriptor and then fed to the stack by the >> driver calling

Re: [PATCH net-next 6/8] net: gre: Implement LCO for GRE over IPv4

2016-01-20 Thread Rustad, Mark D
Alexander Duyck wrote: There isn't any need to add such an indication, nor do we need to start bitflipping the return value from csum_fold in all cases. I think there was just some confusion about UDP checksums vs GRE or TCP checksums. Yeah. I think I finally got

Re: [PATCH] net: i40e: avoid unused function warnings

2016-01-20 Thread Arnd Bergmann
On Wednesday 20 January 2016 14:44:45 Jeff Kirsher wrote: > Yeah, I have a fix for that as well. > > You can confirm by pulling my next-queue tree (dev-queue branch). > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git d > ev-queue > I checked out that branch, but still see

Re: Optimizing instruction-cache, more packets at each stage

2016-01-20 Thread Eric Dumazet
On Thu, 2016-01-21 at 00:20 +0200, Or Gerlitz wrote: > Dave, I assume you refer to the RSS hash result which is written by > NIC HWs to the completion descriptor and then fed to the stack by the > driver calling skb_set_hash(.)? Well, this can be taken even further. > > Suppose a the NIC can be

Re: out of bounds in pptp_connect.

2016-01-20 Thread Dave Jones
On Sun, Jan 17, 2016 at 12:06:58PM -0500, Dave Jones wrote: > I've managed to trigger this a few times the last few days, on Linus' tree. > > == > BUG: KASAN: slab-out-of-bounds in pptp_connect+0xb7b/0xc70 [pptp] at addr >

Re: [PATCH] net: i40e: avoid unused function warnings

2016-01-20 Thread Jeff Kirsher
On Wed, 2016-01-20 at 23:54 +0100, Arnd Bergmann wrote: > On Wednesday 20 January 2016 14:44:45 Jeff Kirsher wrote: > > Yeah, I have a fix for that as well. > >  > > You can confirm by pulling my next-queue tree (dev-queue branch). > > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next- >

[PATCH v6 0/3] can: sja1000: support for technologic version

2016-01-20 Thread Marc Kleine-Budde
This is Damien Riegel's series with minor changes. regards, Marc --- This patchset introduces support for the technologic version of the SJA1000. Access to IP's registers are proxied through a window, requiring two bus accesses to read or write a register. These accesses must be protected by a

[PATCH v6 1/3] can: sja1000: of: add per-compatible init hook

2016-01-20 Thread Marc Kleine-Budde
From: Damien Riegel This commit adds the capability to allocate and init private data embedded in the sja1000_priv structure on a per-compatible basis. The device node is passed as a parameter of the init callback to allow parsing of custom device tree

Re: [PATCH v2] can: c_can: add xceiver enable/disable support

2016-01-20 Thread Bjørn Mork
Michael Grzeschik writes: > @@ -1263,6 +1271,10 @@ int register_c_can_dev(struct net_device *dev) >*/ > pinctrl_pm_select_sleep_state(dev->dev.parent); > > + priv->reg_xceiver = devm_regulator_get(priv->device, "xceiver"); > + if

Re: [PATCH v2] can: c_can: add xceiver enable/disable support

2016-01-20 Thread Michael Grzeschik
Hi, On Wed, Jan 20, 2016 at 05:19:18PM +0100, Bjørn Mork wrote: > Michael Grzeschik writes: > > > @@ -1263,6 +1271,10 @@ int register_c_can_dev(struct net_device *dev) > > */ > > pinctrl_pm_select_sleep_state(dev->dev.parent); > > > > + priv->reg_xceiver

[PATCH 4/6] netfilter: xt_TCPMSS: handle CHECKSUM_COMPLETE in tcpmss_tg6()

2016-01-20 Thread Pablo Neira Ayuso
From: Eric Dumazet In case MSS option is added in TCP options, skb length increases by 4. IPv6 needs to update skb->csum if skb has CHECKSUM_COMPLETE, otherwise kernel complains loudly in netdev_rx_csum_fault() with a stack dump. Signed-off-by: Eric Dumazet

[PATCH 5/6] netfilter: nf_tables_netdev: fix error path in module initialization

2016-01-20 Thread Pablo Neira Ayuso
Unregister the chain type and return error, otherwise this leaks the subscription to the netdevice notifier call chain. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_netdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 0/6] Netfilter fixes for net

2016-01-20 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter fixes for your net tree, they are: 1) Fix accidental 3-times le/be conversion for 64-bits in nft_byteorder, from Florian Westphal. 2) Get rid of defensive cidr = 0 check in the ipset hash:netiface set type which doesn't allow valid

[PATCH 3/6] netfilter: nft_ct: keep counters away from CONFIG_NF_CONNTRACK_LABELS

2016-01-20 Thread Pablo Neira Ayuso
This is accidental, they don't depend on the label infrastructure. Fixes: 48f66c905a97 ("netfilter: nft_ct: add byte/packet counter support") Reported-by: Arnd Bergmann Signed-off-by: Pablo Neira Ayuso Acked-by: Florian Westphal ---

[PATCH 6/6] netfilter: nf_conntrack: use safer way to lock all buckets

2016-01-20 Thread Pablo Neira Ayuso
From: Sasha Levin When we need to lock all buckets in the connection hashtable we'd attempt to lock 1024 spinlocks, which is way more preemption levels than supported by the kernel. Furthermore, this behavior was hidden by checking if lockdep is enabled, and if it was -

Re: [PATCH v3 00/16] add Intel X722 iWARP driver

2016-01-20 Thread Or Gerlitz
On Wed, Jan 20, 2016 at 9:40 PM, Faisal Latif wrote: > Changes since v2: [...] > *move netlink patch up I also asked you why the port mapper code has to be present in each iwarp driver and not part of the IB core stack, and you responded "i40iw iwarp

  1   2   >