Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

On 16-02-23 10:34 AM, Daniel Borkmann wrote: On 02/23/2016 03:28 PM, Jamal Hadi Salim wrote: [..] These are basic metadata. The question to ask is what could one use skb->hash for. Today it is used to select a cpu to balance to. Right, but that happens before you decode that information

Re: net: netcp: regarding commit 899077: netcp: try to reduce type confusion in descriptors

On Monday 22 February 2016 18:09:45 Murali Karicheri wrote: > On 02/22/2016 05:13 PM, Arnd Bergmann wrote: > > On Monday 22 February 2016 16:48:14 Murali Karicheri wrote: > >> Keystone can have SoC configured to be in big endian mode for peripherals > >> and DSP. > > > > I'm not entirely sure

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

On 16-02-23 02:03 PM, John Fastabend wrote: In the initial implementation the only way to stop a rule from being inserted into the hardware table was via the device feature flag. However this doesn't work well when working on an end host system where packets are expect to hit both the hardware

Re: custom ioctl-based interface to control LED in networking (was Re: [PATCHv2 09/10] rfkill: Userspace control for airplane mode)

On Wed, 2016-02-24 at 13:14 +0100, Pavel Machek wrote: >  > Why would it need to? It could look at default triggers for the led > if it really wanted to. And then it needs to change them; if anything goes wrong error recovery is practically impossible since the trigger information is lost

Re: [PATCH net 0/7] Hi Dave,

Dave, I messed up the cover-letter title :) it should be "Mellanox 100G mlx5 driver fixes", do you need V1 with the title fix ? On Wed, Feb 24, 2016 at 1:18 PM, Saeed Mahameed wrote: > This series has few bug fixes for the mlx5 Ethernet driver. > > Eran fixed a locking

Re: [net-next PATCH v2 1/5] introduce IFE action

On 16-02-23 11:12 AM, Daniel Borkmann wrote: On 02/23/2016 03:39 PM, Jamal Hadi Salim wrote: My question was rather: should the kernel enforce the IDs and only allow what the kernel dictates (and not in/out of tree modules)? If yes, then there would be no need for a module parameter (and the

Re: [net-next PATCH 2/4] net: cls_u32: move TC offload feature bit into cls_u32 offload logic

On 16-02-23 02:02 PM, John Fastabend wrote: In the original series drivers would get offload requests for cls_u32 rules even if the feature bit is disabled. This meant the driver had to do a boiler plate check on the feature bit before adding/deleting the rule. This patch lifts the check into

[PATCH 2/3] forcedeth: Use setup_timer()

Convert a call to init_timer and accompanying intializations of the timer's data and function fields to a call to setup_timer. The Coccinelle semantic patch that fixes this problem is as follows: // @@ expression t,f,d; @@ -init_timer(); +setup_timer(,f,d); -t.data = d; -t.function = f; //

[PATCH 1/3] net: tulip: Use setup_timer()

Convert a call to init_timer and accompanying intializations of the timer's data and function fields to a call to setup_timer. The Coccinelle semantic patch that fixes this problem is as follows: // @@ expression t,f,d; @@ -init_timer(); +setup_timer(,f,d); -t.data = d; -t.function = f; //

[PATCH 3/3] 3c59x: Use setup_timer()

Convert a call to init_timer and accompanying intializations of the timer's data and function fields to a call to setup_timer. The Coccinelle semantic patch that fixes this problem is as follows: // @@ expression t,f,d; @@ -init_timer(); +setup_timer(,f,d); ... -t.data = d; -t.function = f;

Re: [Patch net-next v2 2/2] net_sched: add network namespace support for tc actions

On 16-02-23 05:23 PM, Cong Wang wrote: On Tue, Feb 23, 2016 at 5:14 AM, Jamal Hadi Salim wrote: It doesnt seem neccessary to have hinfo in tc_action. Quick scan: __tcf_hash_release() seems to be the only other place that uses it. And the callers to that appear capable of

Re: [net-next PATCH 1/4] net: sched: consolidate offload decision in cls_u32

On 16-02-23 02:02 PM, John Fastabend wrote: The offload decision was originally very basic and tied to if the dev implemented the appropriate ndo op hook. The next step is to allow the user to more flexibly define if any paticular rule should be offloaded or not. In order to have this logic in

[PATCH net 0/7] Hi Dave,

This series has few bug fixes for the mlx5 Ethernet driver. Eran fixed a locking issue with time-stamping that could cause a soft-lockup when time-stamping is enabled. Gal fixed the rx/tx packets/bytes counters returned by the driver to actually went through the network stack. Tariq removed a

[PATCH net 2/7] net/mlx5e: Fix LRO modify

From: Tariq Toukan Ethtool LRO enable/disable is broken, as of today we only modify TCP TIRs in order to apply the requested configuration. Hardware requires that all TIRs pointing to the same RQ should share the same LRO configuration. For that all other TIRs' LRO fields

[PATCH net 4/7] net/mlx5e: Fix ethtool RX hash func configuration change

From: Tariq Toukan We should modify TIRs explicitly to apply the new RSS configuration. The light ndo close/open calls do not "refresh" them. Fixes: 2d75b2bc8a8c ('net/mlx5e: Add ethtool RSS configuration options') Signed-off-by: Tariq Toukan

[PATCH net 6/7] net/mlx5e: Add rx/tx bytes software counters

From: Gal Pressman Sum up rx/tx bytes in software as we do for rx/tx packets, to be reported in upcoming statistics fix. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h|

[PATCH net 1/7] net/mlx5e: Remove wrong poll CQ optimization

From: Tariq Toukan With the MLX5E_CQ_HAS_CQES optimization flag, the following buggy flow might occur: - Suppose RX is always busy, TX has a single packet every second. - We poll a single TX cqe and clear its flag. - We never arm it again as RX is always busy. - TX CQ flag

[PATCH net 7/7] net/mlx5e: Provide correct packet/bytes statistics

From: Gal Pressman Using the HW VPort counters for traffic (rx/tx packets/bytes) statistics is wrong. This is because frames dropped due to steering or out of buffer will be counted as received. To fix that, we move to use the packet/bytes accounting done by the driver for

[PATCH net 5/7] net/mlx5e: Correctly handle RSS indirection table when changing number of channels

From: Tariq Toukan Upon changing num_channels, reset the RSS indirection table to match the new value. Fixes: 2d75b2bc8a8c ('net/mlx5e: Add ethtool RSS configuration options') Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed

[PATCH net 3/7] net/mlx5e: Fix soft lockup when HW Timestamping is enabled

From: Eran Ben Elisha Readers/Writers lock for SW timecounter was acquired without disabling interrupts on local CPU. The problematic scenario: * HW timestamping is enabled * Timestamp overflow periodic service task is running on local CPU and holding write_lock for SW

Re: custom ioctl-based interface to control LED in networking (was Re: [PATCHv2 09/10] rfkill: Userspace control for airplane mode)

On Wed 2016-02-24 12:01:37, Johannes Berg wrote: > On Wed, 2016-02-24 at 11:46 +0100, Pavel Machek wrote: > > > If you want different trigger, implement different trigger. If you > > want to indicate all but wifi, implement all but wifi, and then > > userspace can select it by writing trigger

Re: [net-next PATCH v2 1/5] introduce IFE action

On 16-02-24 12:46 AM, Simon Horman wrote: On Tue, Feb 23, 2016 at 05:12:34PM +0100, Daniel Borkmann wrote: From my point of view the test should be weather the encapsulation might reasonably be expected to be used outside of the context of tc. If so then it makes sense to use a netdev to

Re: [net-next PATCH v2 1/5] introduce IFE action

On 16-02-23 04:44 PM, Cong Wang wrote: On Tue, Feb 23, 2016 at 4:49 AM, Jamal Hadi Salim wrote: +#define MODULE_ALIAS_IFE_META(metan) MODULE_ALIAS("ifemeta" __stringify_1(metan)) + +int get_meta_u32(struct sk_buff *skb, struct tcf_meta_info *mi); +int

[PATCH] net: thunderx: Fix for Qset error due to CQ full

From: Sunil Goutham On Thunderx pass 1.x and pass2 due to a HW errata default CQ DROP_LEVEL of 0x80 is not sufficient to avoid CQ_WR_FULL Qset error when packets are being received at >20Mpps resulting in complete stall of packet reception. This patch will configure it to

Re: [Y2038] [PATCH 8/8] net: sunrpc: Replace CURRENT_TIME by current_fs_time()

On Monday 22 February 2016 10:34:31 Trond Myklebust wrote: > > diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c > > index 31789ef..bab3187 100644 > > --- a/net/sunrpc/rpc_pipe.c > > +++ b/net/sunrpc/rpc_pipe.c > > @@ -477,7 +477,9 @@ rpc_get_inode(struct super_block *sb, umode_t mode) >

[PATCH net-next 1/6] qede: Change pci DID for 10g device

The device ID for the 10g module has changed. Populate the pci_ids table accordingly. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next 2/6] qede: Linearize SKBs when needed

There's a corner-case in HW where an SKB queued for transmission that contains too many frags will cause FW to assert. This patch solves this by linearizing the SKB if necessary. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_main.c | 38

[PATCH net-next 3/6] qede: Don't report link change needlessly

There are several corner cases where driver might get a 2nd notification about the same link change. Don't log any additional changes if the physical carrier is already reported as it should. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_main.c |

[PATCH net-next 6/6] qed, qede: rebrand module description

Drop the `QL4xxx 40G/100G' and use `FastLinQ 4' instead. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_main.c | 6 +++--- drivers/net/ethernet/qlogic/qede/qede_main.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH net-next 5/6] qed: Prevent probe on previous error

Don't allow driver to probe on an adapter at a failed state; Gracefully block the probe instead. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_main.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

[PATCH net-next 4/6] qed: add MODULE_FIRMWARE()

Module is using a binary firmware file and so should be marked as such. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c

[PATCH net-next 0/6] qed*: Driver updates

Usually I try to provide a sensible description of the patch set even if it lacks a general 'motif', but this simply contains several small, unrelated and self-explenatory tweaks and additions. Dave, Please consider applying this series to `net-next'. Thanks, Yuval Yuval Mintz (6): qede:

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

From: David Laight Date: Wed, 24 Feb 2016 09:58:03 + > From: David Miller >> Sent: 23 February 2016 18:25 >> >> From: Jesse Gross >> Date: Tue, 23 Feb 2016 09:31:09 -0800 >> >> > Most OSs (including Linux with connected TCP sockets) use non-zero

[PATCH net-next 1/1] tipc: eliminate risk of finding to-be-deleted node instance

Although we have never seen it happen, we have identified the following problematic scenario when nodes are stopped and deleted: CPU0:CPU1: tipc_node_xxx() //ref == 1 tipc_node_put()//ref -> 0

[PATCH] netxen: Use kobj_to_dev()

Introduce the use of kobj_to_dev() helper function instead of open coding it with container_of() The Coccinelle semantic patch used to make this change is as follows: // @@ expression a; symbol kobj; @@ - container_of(a, struct device, kobj) + kobj_to_dev(a) // Signed-off-by: Amitoj Kaur Chawla

Re: [PATCH RFC 0/6] NCSI Support

From: Gavin Shan Date: Wed, 24 Feb 2016 13:59:50 +1100 > Hello David, did you get time to go through this series? It has been there > for a while. Looking forward to your comments and feedback :-) Sorry, I personally don't have the time to review it, hopefully one of

Re: [PATCH] ipv4: in new netns initialize sysctls in net.ipv4.conf.* with defaults

From: Konstantin Khlebnikov Date: Wed, 24 Feb 2016 08:16:59 +0300 > Major kernel upgrades always break something in weird setups. > This shouldn't block bug fixing. A bug for you is a feature for another person. I'm standing by my position, and will not apply this and break

Re: Tools for sampling ethtool --statistics

On Wed, Jan 20, 2016 at 11:13 AM, Jesper Dangaard Brouer wrote: > I wrote a small tool[1] to extract ethtool --statistics|-S, sample and > present it in a more human readable manor. You might also find this useful... [..] > The reason I wrote this script is that the mlx5

Printer Users List

Hi, Would you be interested in reaching out “Printer Users List" with opt-in verified contact information from USA? We also have data for Epson Printer, HP Printer, Lexmark Printer, Xerox Printer, Zebra Printer, Samsung Printer, scanner Printer, and many more… Each record in the list

Re: [net-next PATCH 4/5] flow_dissector: Use same pointer for IPv4 and IPv6 addresses

On Wed, Feb 24, 2016 at 9:29 AM, Alexander Duyck wrote: > The IPv6 parsing was using a local pointer when it could use the same > pointer as the IPv4 portion of the code since the key_addrs can support > both IPv4 and IPv6 as it is just a pointer. > > Signed-off-by: Alexander

Re: [net-next PATCH 3/5] flow_dissector: Correctly handle parsing FCoE

On Wed, Feb 24, 2016 at 9:29 AM, Alexander Duyck wrote: > The flow dissector bits handling FCoE didn't bother to actually validate > that the space there was enough for the FCoE header. So we need to update > things so that if there is room we add the header and report a

Re: [net-next PATCH 5/5] eth: Pull header from first fragment via eth_get_headlen

On Wed, Feb 24, 2016 at 9:30 AM, Alexander Duyck wrote: > We want to try and pull the L4 header in if it is available in the first > fragment. As such add the flag to indicate we want to pull the headers on > the first fragment in. > > Signed-off-by: Alexander Duyck

Re: [PATCH v2 net] nfc: use GFP_USER for user-controlled kmalloc

On Fri, Jan 29, 2016 at 11:24 AM, Cong Wang wrote: > These two functions are called in sendmsg path, and the > 'len' is passed from user-space, so we should not allow > malicious users to OOM kernel on purpose. > > Reported-by: Dmitry Vyukov > Cc:

Re: [PATCH v2 net] nfc: use GFP_USER for user-controlled kmalloc

From: Cong Wang Date: Wed, 24 Feb 2016 10:41:29 -0800 > On Fri, Jan 29, 2016 at 11:24 AM, Cong Wang wrote: >> These two functions are called in sendmsg path, and the >> 'len' is passed from user-space, so we should not allow >> malicious users

[v2, 0/3] Add PTP support for ls1021a platform

This patchset is to enable ptp support for ls1021a platform. The endianness issue in gianfar driver and gianfar ptp driver must be fixed, and a 1588 timer node must be added into dts. Changes for v2: - Modified commit message - Added more reviewers Yangbo Lu (3): ARM: dts:

RE: [PATCH 0/3] Patchset for gianfar ptp driver

> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Monday, February 22, 2016 4:33 PM > To: Yangbo Lu > Cc: netdev@vger.kernel.org; Claudiu Manoil > Subject: Re: [PATCH 0/3] Patchset for gianfar ptp driver > > On Mon, Feb 22, 2016 at 02:49:30PM +0800,

Re: Variable download speed

On Tue, 23 Feb 2016, Rick Jones wrote: On 02/23/2016 03:24 AM, s...@onet.eu wrote: Hi, I've got a problem with network on one of my embedded boards. I'm testing download speed of 256MB file from my PC to embedded board through 1Gbit ethernet link using ftp. The problem is that sometimes

Re: [PATCH 3/3] gianfar: fix endianness for hardware timestamp

Hi, Yangbo Lu wrote: >> -Original Message- >> From: Richard Cochran [mailto:richardcoch...@gmail.com] >> Sent: Monday, February 22, 2016 4:48 PM >> To: Yangbo Lu >> Cc: netdev@vger.kernel.org; Claudiu Manoil >> Subject: Re: [PATCH 3/3] gianfar: fix endianness for hardware timestamp >> >>

[PATCH v5 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

Redundant Data Bundling (RDB) is a mechanism for TCP aimed at reducing the latency for applications sending time-dependent data. Latency-sensitive applications or services, such as online games, remote control systems, and VoIP, produce traffic with thin-stream characteristics, characterized by

[PATCH v5 net-next 0/2] tcp: Redundant Data Bundling (RDB)

Redundant Data Bundling (RDB) is a mechanism for TCP aimed at reducing the latency for applications sending time-dependent data. Latency-sensitive applications or services, such as online games and remote desktop, produce traffic with thin-stream characteristics, characterized by small packets

[PATCH v5 net-next 1/2] tcp: Add DPIFL thin stream detection mechanism

The existing mechanism for detecting thin streams, tcp_stream_is_thin(), is based on a static limit of less than 4 packets in flight. This treats streams differently depending on the connection's RTT, such that a stream on a high RTT link may never be considered thin, whereas the same application

Re: [PATCH][net-next][v2] bridge: allow the maximum mtu to 64k

From: roy.qing...@gmail.com Date: Tue, 23 Feb 2016 09:00:56 +0800 > This is especially annoying for the virtualization case because the > KVM's tap driver will by default adopt the bridge's MTU on startup > making it impossible (without the workaround) to use a large MTU on the > guest VMs. So

Re: [PATCH net] bpf: fix csum setting for bpf_set_tunnel_key

From: Daniel Borkmann Date: Tue, 23 Feb 2016 02:05:26 +0100 > The fix in 35e2d1152b22 ("tunnels: Allow IPv6 UDP checksums to be correctly > controlled.") changed behavior for bpf_set_tunnel_key() when in use with > IPv6 and thus uncovered a bug that TUNNEL_CSUM needed to be

custom ioctl-based interface to control LED in networking (was Re: [PATCHv2 09/10] rfkill: Userspace control for airplane mode)

On Wed 2016-02-24 10:01:49, Johannes Berg wrote: > On Tue, 2016-02-23 at 22:45 +0100, Pavel Machek wrote: > > > Well "the airplane mode" is well defined. It means no intentional > > transmitting at radio frequencies. > > > > The fact that you are allowed to use WIFI on certain flights does not >

Re: [PATCH v8 1/8] time: Add cycles to nanoseconds translation

On Mon, 22 Feb 2016, Christopher S. Hall wrote: > The timekeeping code does not currently provide a way to translate > externally provided clocksource cycles to system time. The cycle count > is always provided by the result clocksource read() method internal to > the timekeeping code. The added

Re: [PATCH v8 3/8] time: Remove duplicated code in ktime_get_raw_and_real()

On Mon, 22 Feb 2016, Christopher S. Hall wrote: > --- a/kernel/time/timekeeping.c > +++ b/kernel/time/timekeeping.c > @@ -888,6 +888,8 @@ void ktime_get_snapshot(struct system_time_snapshot > *systime_snapshot) > s64 nsec_real; > cycle_t now; > > +

Re: [patch net-next 1/9] Introduce devlink infrastructure

Wed, Feb 24, 2016 at 08:02:32AM CET, yuval.mi...@qlogic.com wrote: >> + * An overall lock guarding every operation comming from userspace. >> + * If also guards devlink devices list and it is taken when >> + * driver registers/unregisters it. >Several typos in comment. Already fixed in v2. > >>

Re: [PATCH v8 2/8] time: Add timekeeping snapshot code capturing system time and counter

On Mon, 22 Feb 2016, Christopher S. Hall wrote: > In the current timekeeping code there isn't any interface to > atomically capture the current relationship between the system counter > and system time. ktime_get_snapshot() returns this triple (counter, > monotonic raw, realtime) in the

Re: [PATCH v8 4/8] time: Add driver cross timestamp interface for higher precision time synchronization

On Mon, 22 Feb 2016, Christopher S. Hall wrote: > +int get_device_system_crosststamp(int (*get_time_fn) > + (ktime_t *device_time, > +struct system_counterval_t *sys_counterval, > +void *ctx), > +

RE: [PATCH 2/3] gianfar_ptp: fix endianness in get_of_u32()

> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Monday, February 22, 2016 4:36 PM > To: Yangbo Lu > Cc: netdev@vger.kernel.org; Claudiu Manoil > Subject: Re: [PATCH 2/3] gianfar_ptp: fix endianness in get_of_u32() > > On Mon, Feb 22, 2016 at

Re: [PATCH v8 5/8] time: Add history to cross timestamp interface supporting slower devices

On Mon, 22 Feb 2016, Christopher S. Hall wrote: > +{ > + struct timekeeper *tk = _core.timekeeper; > + bool interp_forward; > + u64 corr_raw, corr_real; > + int ret; Once more: struct timekeeper *tk = _core.timekeeper; u64 corr_raw, corr_real; bool

Re: [PATCH v8 6/8] x86: tsc: Always Running Timer (ART) correlated clocksource

On Mon, 22 Feb 2016, Christopher S. Hall wrote: > On modern Intel systems TSC is derived from the new Always Running Timer > (ART). ART can be captured simultaneous to the capture of > audio and network device clocks, allowing a correlation between timebases > to be constructed. Upon capture, the

Re: custom ioctl-based interface to control LED in networking (was Re: [PATCHv2 09/10] rfkill: Userspace control for airplane mode)

On Wed, 2016-02-24 at 11:46 +0100, Pavel Machek wrote: > If you want different trigger, implement different trigger. If you > want to indicate all but wifi, implement all but wifi, and then > userspace can select it by writing trigger name. This is still mostly a strawman, since userspace

Re: [PATCH net 0/7] Hi Dave,

From: Saeed Mahameed Date: Wed, 24 Feb 2016 13:28:55 +0200 > I messed up the cover-letter title :) > > it should be "Mellanox 100G mlx5 driver fixes", do you need V1 with > the title fix ? No, I can fix it up. Thanks.

Re: [Patch net-next v2 2/2] net_sched: add network namespace support for tc actions

On Wed, Feb 24, 2016 at 5:19 AM, Jamal Hadi Salim wrote: > On 16-02-23 05:23 PM, Cong Wang wrote: >> >> On Tue, Feb 23, 2016 at 5:14 AM, Jamal Hadi Salim >> wrote: > > >>> It doesnt seem neccessary to have hinfo in tc_action. Quick scan: >>>

Re: [net-next PATCH v2 1/5] introduce IFE action

On Wed, Feb 24, 2016 at 5:09 AM, Jamal Hadi Salim wrote: > On 16-02-23 04:44 PM, Cong Wang wrote: >> >> On Tue, Feb 23, 2016 at 4:49 AM, Jamal Hadi Salim >> wrote: > > >>> +#define MODULE_ALIAS_IFE_META(metan) MODULE_ALIAS("ifemeta" >>>

[PATCH net-next 1/1] tipc: fix crash during node removal

When the TIPC module is unloaded, we have identified a race condition that allows a node reference counter to go to zero and the node instance being freed before the node timer is finished with accessing it. This leads to occasional crashes, especially in multi-namespace environments. The

Re: [patch net-next v2 1/9] Introduce devlink infrastructure

On Wed, Feb 24, 2016 at 08:19:58AM +0100, Jiri Pirko wrote: > Tue, Feb 23, 2016 at 10:19:48PM CET, ja...@redhat.com wrote: > >On Tue, Feb 23, 2016 at 04:51:26PM +0100, Jiri Pirko wrote: > >> From: Jiri Pirko > >> > >> Introduce devlink infrastructure for drivers to register

Re: [PATCH net] net/8021q: Check the correct vlan filter capability

From: Saeed Mahameed Date: Wed, 24 Feb 2016 18:39:19 +0200 > From: Gal Pressman > > Use dev->hw_features in vlan_hw_filter_capable instead of dev->features, > since dev->features can be turned on/off dynamically. > > Netdev features can be changed

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

On 02/24/2016 01:49 PM, Jamal Hadi Salim wrote: On 16-02-23 10:34 AM, Daniel Borkmann wrote: [...] My concern is we add 20 new modules like this that only do trivial things, where instead they could have been consolidated and reduce maintenance. Or is this hard module requirement related to

[PATCH net-next] net: Facility to report route quality of connected sockets

This patch add the SO_CNX_ADVICE socket option (setsockopt only). The purpose is to allow an application to give feedback to the kernel about the quality of the network path for a connected socket. The value argument indicates the type of quality report. For this initial patch the only supported

Re: [Patch net-next v2 2/2] net_sched: add network namespace support for tc actions

On Tue, Feb 23, 2016 at 5:14 AM, Jamal Hadi Salim wrote: >> - int (*walk)(struct sk_buff *, struct netlink_callback *, int, >> struct tc_action *); >> + int (*walk)(struct net *, struct sk_buff *, >> + struct netlink_callback *, int,

Re: [net-next PATCH 1/5] flow_dissector: Check for IP fragmentation even if not using IPv4 address

On Wed, Feb 24, 2016 at 9:29 AM, Alexander Duyck wrote: > This patch corrects the logic for the IPv4 parsing so that it is consistent > with how we handle IPv6. Specifically if we do not have the flow key > indicating we want the addresses we still may need to take a look at

Re: [net-next PATCH 2/5] flow_dissector: Fix fragment handling for header length computation

On Wed, Feb 24, 2016 at 9:29 AM, Alexander Duyck wrote: > It turns out that for IPv4 we were reporting the ip_proto of the fragment, > and for IPv6 we were not. This patch updates that behavior so that we > always report the IP protocol of the fragment. In addition it takes

Re: [PATCH net-next] soreuseport: fix merge conflict in tcp bind

From: Craig Gallek Date: Mon, 22 Feb 2016 10:45:29 -0500 > From: Craig Gallek > > One of the validation checks for the new array-based TCP SO_REUSEPORT > validation was unintentionally dropped in ea8add2b1903. This adds it back. > > Lack of this check

Re: [PATCH net-next V2 00/12] QoS and VxLAN offloads support for Mellanox 100G mlx5 driver

From: Saeed Mahameed Date: Mon, 22 Feb 2016 18:17:22 +0200 > This patch series introduces QoS IEEE dcbnl support for > PFC, ETS and max rate. Series applied, thanks.

Re: [PATCH v2 net] nfc: use GFP_USER for user-controlled kmalloc

On Wed, Feb 24, 2016 at 10:41:29AM -0800, Cong Wang wrote: > On Fri, Jan 29, 2016 at 11:24 AM, Cong Wang wrote: > > These two functions are called in sendmsg path, and the > > 'len' is passed from user-space, so we should not allow > > malicious users to OOM kernel on

Re: [PATCH v6] net: ethernet: nb8800: support fixed-link DT node

From: Mason Date: Mon, 22 Feb 2016 13:33:14 +0100 > From: Sebastian Frias > > Under some circumstances, e.g. when connecting to a switch, the ethernet > port will not be connected to a PHY. In that case a "fixed-link" DT node > can be used to replace it. >

[net-next PATCH 0/5] Flow dissector fixes and improvements

This patch series is meant to fix and/or improve a number of items within the flow dissector code. The main change out of all of this is that IPv4 and IPv6 fragmentation should now be handled better than it was. As a result we should see an improvement when handling things like IP fragment

[PATCH net-next v7] net: ipv6: Make address flushing on ifdown optional

Currently, all ipv6 addresses are flushed when the interface is configured down, including global, static addresses: $ ip -6 addr show dev eth1 3: eth1: mtu 1500 state UP qlen 1000 inet6 2100:1::2/120 scope global valid_lft forever

[PATCH net-next] tipc: fix null deref crash in compat config path

msg.dst_sk needs to be set up with a valid socket because some callbacks later derive the netns from it. Fixes: 263ea09084d172d ("Revert "genl: Add genlmsg_new_unicast() for unicast message allocation") Reported-by: Jon Maloy Bisected-by: Jon Maloy

[PATCH v17 7/9] bpf: Add __bpf_prog_run() to objtool whitelist

objtool reports the following false positive warnings: objtool: kernel/bpf/core.o: __bpf_prog_run()+0x5c: sibling call from callable instruction with changed frame pointer objtool: kernel/bpf/core.o: __bpf_prog_run()+0x60: function has unreachable instruction objtool: kernel/bpf/core.o:

Re: [net-next PATCH v2 1/5] introduce IFE action

On 02/23/2016 01:49 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim [...] +static const struct nla_policy ife_policy[TCA_IFE_MAX + 1] = { + [TCA_IFE_PARMS] = {.len = sizeof(struct tc_ife)}, + [TCA_IFE_DMAC] = {.type = NLA_BINARY,.len = ETH_ALEN}, +

Re: [PATCH net 0/7] Hi Dave,

>> I messed up the cover-letter title :) >> >> it should be "Mellanox 100G mlx5 driver fixes", do you need V1 with >> the title fix ? > > No, I can fix it up. Great, Thank you.

Re: [PATCH 00/33] Compile-time stack metadata validation

On Wed, Feb 24, 2016 at 08:40:54AM +0100, Ingo Molnar wrote: > > * Josh Poimboeuf wrote: > > > Hi Ingo, > > > > On Tue, Feb 23, 2016 at 09:14:06AM +0100, Ingo Molnar wrote: > > > So I tried out this latest stacktool series and it looks mostly good for > > > an > > >

[net-next PATCH 1/5] flow_dissector: Check for IP fragmentation even if not using IPv4 address

This patch corrects the logic for the IPv4 parsing so that it is consistent with how we handle IPv6. Specifically if we do not have the flow key indicating we want the addresses we still may need to take a look at the IP fragmentation bits and to see if we should stop after we have recognized the

[net-next PATCH 4/5] flow_dissector: Use same pointer for IPv4 and IPv6 addresses

The IPv6 parsing was using a local pointer when it could use the same pointer as the IPv4 portion of the code since the key_addrs can support both IPv4 and IPv6 as it is just a pointer. Signed-off-by: Alexander Duyck --- net/core/flow_dissector.c | 11 +-- 1 file

[net-next PATCH 3/5] flow_dissector: Correctly handle parsing FCoE

The flow dissector bits handling FCoE didn't bother to actually validate that the space there was enough for the FCoE header. So we need to update things so that if there is room we add the header and report a good result, otherwise we do not add the header, and report the bad result.

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

On 02/24/2016 01:49 PM, Jamal Hadi Salim wrote: On 16-02-23 10:34 AM, Daniel Borkmann wrote: On 02/23/2016 03:28 PM, Jamal Hadi Salim wrote: [..] These are basic metadata. The question to ask is what could one use skb->hash for. Today it is used to select a cpu to balance to. Right, but

[PATCH v17 0/9] Compile-time stack metadata validation

This is v17 of the compile-time stack metadata validation patch set. It's based on tip:x86/debug. However, note that when run against that branch it will give a lot of warnings: objtool: arch/x86/ia32/sys_ia32.o: __ex_table size not a multiple of 12 objtool: arch/x86/ia32/ia32_signal.o:

[PATCH net] net/8021q: Check the correct vlan filter capability

From: Gal Pressman Use dev->hw_features in vlan_hw_filter_capable instead of dev->features, since dev->features can be turned on/off dynamically. Netdev features can be changed dynamically to off after vlan_vid_add was called, thus vlan_vid_del will skip ndo_vlan_rx_kill_vid

[Patch] rose_route_frame() NULL pointer dereference kernel panic

[Patch] Null pointer in rose_route_frame() Bug appears when setting a second IP to ethernet device without adding a route and a gateway: /sbin/ifconfig enp4s0:1 44.168.19.22 netmask 255.255.255.240 If a route and a gateway are not added for subnet, and if ax25ipd configuration includes a

[net-next PATCH 5/5] eth: Pull header from first fragment via eth_get_headlen

We want to try and pull the L4 header in if it is available in the first fragment. As such add the flag to indicate we want to pull the headers on the first fragment in. Signed-off-by: Alexander Duyck --- net/ethernet/eth.c |3 ++- 1 file changed, 2 insertions(+), 1

[net-next PATCH 2/5] flow_dissector: Fix fragment handling for header length computation

It turns out that for IPv4 we were reporting the ip_proto of the fragment, and for IPv6 we were not. This patch updates that behavior so that we always report the IP protocol of the fragment. In addition it takes the steps of updating the payload offset code so that we will determine the start

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

On 24/02/16 00:53, Tom Herbert wrote: > That's an interesting idea. This should work in IPv6 now and nearly > all encapsulation protocols (GRE w/ csum doesn't work this way for > instance) You mean GRE with sequence numbers? csum should be fine, it'sjust the usual LCO setup (i.e. only depends on

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

Wed, Feb 24, 2016 at 09:04:40AM CET, a...@vadai.me wrote: >On Tue, Feb 23, 2016 at 11:03:21AM -0800, John Fastabend wrote: >> In the initial implementation the only way to stop a rule from being >> inserted into the hardware table was via the device feature flag. >> However this doesn't work well

Re: [PATCH net-next 2/5] bridge: notify ensabled devices of headroom changes

On Tue, 2016-02-23 at 11:20 -0800, pravin shelar wrote: > On Tue, Feb 23, 2016 at 4:53 AM, Paolo Abeni wrote: > > On bridge needed_headroom changes, the enslaved devices are > > notified via the ndo_set_rx_headroom method > > > > Signed-off-by: Paolo Abeni >

Re: [net-next PATCH 1/4] net: sched: consolidate offload decision in cls_u32

Tue, Feb 23, 2016 at 08:02:33PM CET, john.fastab...@gmail.com wrote: >The offload decision was originally very basic and tied to if the dev >implemented the appropriate ndo op hook. The next step is to allow >the user to more flexibly define if any paticular rule should be >offloaded or not. In

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

On 16-02-24 12:40 AM, Jiri Pirko wrote: > Wed, Feb 24, 2016 at 09:04:40AM CET, a...@vadai.me wrote: >> On Tue, Feb 23, 2016 at 11:03:21AM -0800, John Fastabend wrote: >>> In the initial implementation the only way to stop a rule from being >>> inserted into the hardware table was via the device

Re: pull-request: mac80211-next 2016-02-23

On Tue, 2016-02-23 at 15:45 +0100, Johannes Berg wrote: > Hi Dave, > > Here's a (first, even? I didn't have much until before the > conference...) pull request for net-next. > Hm, need to withdraw this, sorry about that. There appears to be some compilation issue that I'm not seeing and need to

  1   2   3   >