[PATCH net 2/3] net/mlx4_core: Check the correct limitation on VFs for HA mode

2016-03-02 Thread Or Gerlitz
From: Moni Shoua The limit of 63 is only for virtual functions while the actual enforcement was for VFs plus physical functions, fix that. Fixes: e57968a10bc1 ('net/mlx4_core: Support the HA mode for SRIOV VFs too') Signed-off-by: Moni Shoua ---

RE: [PATCH net 0/3] r8169:issues fix.

2016-03-02 Thread Hau
> I don't agree with changes #1 and #2. > > If you are going to go to a model where every single configuration operation > is recorded in software and performed at resume time, then really do it and > fix it in the whole driver. As currently coded you are leaving lots of known > bugs in the

[PATCH net-next] ipv4: properly apply change to ignore_routes_on_linkdown to all interfaces

2016-03-02 Thread Andy Gospodarek
Any change to sysctl net.ipv4.conf.all.ignore_routes_with_linkdown does not result in a change to all interfaces on the system. This means that any devices initialized before sysctl settings are applied on boot do not see a change if the sysctl setting is different than what the stack has as a

RE: [PATCH net-next V2 04/16] net: fec: reduce interrupts

2016-03-02 Thread Fugang Duan
From: Troy Kisky Sent: Thursday, February 25, 2016 8:37 AM > To: netdev@vger.kernel.org; da...@davemloft.net; b38...@freescale.com > Cc: fabio.este...@freescale.com; l.st...@pengutronix.de; and...@lunn.ch; > trem...@gmail.com; li...@arm.linux.org.uk; linux-arm- >

[PATCH 10/14] wireless: cw1200: use __maybe_unused to hide pm functions_

2016-03-02 Thread Arnd Bergmann
The cw1200 uses #ifdef to check for CONFIG_PM, but then uses SIMPLE_DEV_PM_OPS, which leaves the references out when CONFIG_PM_SLEEP is not defined, so we get a warning with PM=y && PM_SLEEP=n: drivers/net/wireless/st/cw1200/cw1200_spi.c:450:12: error: 'cw1200_spi_suspend' defined but not used

[PATCH 09/14] amd-xgbe: use __maybe_unused to hide pm functions

2016-03-02 Thread Arnd Bergmann
The amd-xgbe ethernet driver hides its suspend/resume functions in #ifdef CONFIG_PM, but uses SIMPLE_DEV_PM_OPS() to make the reference conditional on CONFIG_PM_SLEEP, which results in a warning when PM_SLEEP is not set but PM is: drivers/net/ethernet/amd/xgbe/xgbe-main.c:833:12: warning:

Re: [PATCH net-next V2 04/16] net: fec: reduce interrupts

2016-03-02 Thread Zhi Li
On Wed, Mar 2, 2016 at 10:12 AM, Troy Kisky wrote: > it is going to be delayed for a very long time. > Should it be moved to the napi routine? No! irq can generate. Compared irq enable is not controlled by EIMR, but TCSR. Original code is correct. best regards

Re: [iproute PATCH 03/20] iplink: fix help text syntax

2016-03-02 Thread Stephen Hemminger
On Wed, 24 Feb 2016 09:21:16 +0100 Phil Sutter wrote: > Get rid of extraneous closing brackets and while here, merge the double > netns parameter. > > Signed-off-by: Phil Sutter Patch does not apply to current git. Applying: iplink: fix help text syntax error: patch

Re: [PATCH/RFC v6 net-next] ravb: Add dma queue interrupt support

2016-03-02 Thread Yoshihiro Kaneko
2016-03-01 5:30 GMT+09:00 Sergei Shtylyov : > Hello. > > > On 02/28/2016 06:41 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple

Re: net_sched: dsmark: use qdisc_dequeue_peeked()

2016-03-02 Thread Cong Wang
On Tue, Mar 1, 2016 at 8:10 PM, Kyeong Yoo wrote: > This fix is for dsmark similar to 3557619f0f6f7496ed453d4825e24958ab1884e0, > and makes use of qdisc_dequeue_peeked() instead of direct dequeue() call. > > First time, wrr peeks dsmark, which will then peek into

[PATCH net-next 3/6] qed: Move statistics to L2 code

2016-03-02 Thread Yuval Mintz
Current statistics logic is meant for L2, not for all future protocols. Move this content to the proper designated file. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 244 +-- drivers/net/ethernet/qlogic/qed/qed_dev_api.h

[PATCH net-next 4/6] qed: Fix error flow on slowpath start

2016-03-02 Thread Yuval Mintz
In case of problems when initializing the chip, the error flows aren't being properly done. Specifically, it's possible that the chip would be left in a configuration allowing it [internally] to access the host memory, causing fatal problems in the device that would require power cycle to

[PATCH net-next 5/6] qed: Remove unused NVM vendor ID

2016-03-02 Thread Yuval Mintz
Remove 2 unused fields from driver code. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed.h | 3 --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 7 --- 2 files changed, 10 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed.h

[PATCH net-next 2/6] qed: Support B0 instead of A0

2016-03-02 Thread Yuval Mintz
BB_A0 is a development model that is will not reach actual clients. In fact, future firmware would simply fail to initialize such chip. This changes the configuration into B0 instead of A0, and adds a safeguard against the slim chance someone would actually try this with an A0 adapter in which

Re: [PATCH V2 01/12] net-next: mediatek: Document ralink/mediatek SoC ethernet binding

2016-03-02 Thread Rob Herring
On Fri, Feb 26, 2016 at 03:21:33PM +0100, John Crispin wrote: > Add three files. One describes the actual frame engine, the other two > describe fast ethernet and gigabit switches bindings. > > Signed-off-by: John Crispin > Signed-off-by: Felix Fietkau >

Re: [PATCH V2 2/4] net: can: ifi: Fix TX DLC configuration

2016-03-02 Thread Oliver Hartkopp
Hi Marek, sorry for picking this patch up again. After looking around in the original source I have one more comment: On 03/02/2016 11:42 AM, Marek Vasut wrote: > - if (priv->can.ctrlmode & (CAN_CTRLMODE_FD | CAN_CTRLMODE_FD_NON_ISO)) { > - if (can_is_canfd_skb(skb)) { > -

[iproute PATCH v2 4/4] tc/p_ip.c: Lint through checkpatch.pl

2016-03-02 Thread Phil Sutter
This diff was generated by using the fix-inplace option of checkpatch.pl and breaking the overlong lines of parse_ip() and parse_ip6() signatures. Signed-off-by: Phil Sutter --- tc/p_ip.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-)

Re: [PATCH net-next] ipv4: properly apply change to ignore_routes_on_linkdown to all interfaces

2016-03-02 Thread Andy Gospodarek
On Wed, Mar 02, 2016 at 10:36:18AM -0800, David Ahern wrote: > On 3/2/16 10:28 AM, Andy Gospodarek wrote: > >>This seems wrong -- changing the 'all' and 'default' settings for a sysctl > >>>should not require walking the interface list. > >Not if you want to actually apply the config to all the

Re: [PATCH] batman-adv: clarify CFG80211 dependency

2016-03-02 Thread David Miller
From: Antonio Quartulli Date: Wed, 2 Mar 2016 22:46:07 +0800 > On Wed, Mar 02, 2016 at 02:54:35PM +0100, Arnd Bergmann wrote: >> The driver calls cfg80211_get_station, which may be part of a >> module, so we must not enable BATMAN_ADV_BATMAN_V if >> BATMAN_ADV=y and CFG80211=m:

[PATCH 1/2] isdn: icn: remove a #warning

2016-03-02 Thread Arnd Bergmann
The icn driver currently produces an unconditional #warning whenever we build it, introduced by Karsten Keil back in 2003: #warning TODO test headroom or use skb->nb to flag ACK Karsten's original commit (from BitKeeper) contains this description: - here are lot of bugs left, so ISDN is

Re: RDS: Major clean-up with couple of new features for 4.6

2016-03-02 Thread David Miller
From: Santosh Shilimkar Date: Tue, 1 Mar 2016 15:20:41 -0800 > v3: > Re-generated the same series by omitting "-D" option from git format-patch > command. Since first patch has file removals, git apply/am can't deal > with it when formated with '-D' option. Yeah

Re: [net-next,v7] net: ipv6: Make address flushing on ifdown optional

2016-03-02 Thread Andrey Wagin
Hi David, We execute CRIU test on linux-next. On the current linux-next kernel they hangs on creating a network namespace. The kernel log contains many massages like this: [ 1036.122108] unregister_netdevice: waiting for lo to become free. Usage count = 2 [ 1046.165156] unregister_netdevice:

Re: [PATCH net 0/7] bnx2x: endianness fixes

2016-03-02 Thread David Miller
From: Michal Schmidt Date: Wed, 2 Mar 2016 13:47:04 +0100 > this fixes a VLAN crash and some SRIOV bugs in bnx2x observed on ppc64. Series applied, thanks.

Re: [PATCH net-next] ipv4: properly apply change to ignore_routes_on_linkdown to all interfaces

2016-03-02 Thread David Ahern
On 3/2/16 10:28 AM, Andy Gospodarek wrote: This seems wrong -- changing the 'all' and 'default' settings for a sysctl >should not require walking the interface list. Not if you want to actually apply the config to all the interfaces. If you notice this borrows heavily from the sysctl to

Re: pull-request: mac80211 2016-03-02

2016-03-02 Thread David Miller
From: Johannes Berg Date: Wed, 2 Mar 2016 14:48:02 +0100 > Here are a few more fixes for the current cycle; the MAINTAINERS patch > isn't really a fix for the tree, but helps the kbuild robot and clearly > can't be causing any regressions :) > > Let me know if

Re: [PATCH net-next 0/6] qed: update series

2016-03-02 Thread David Miller
From: Yuval Mintz Date: Wed, 2 Mar 2016 20:25:59 +0200 > This patch series tries to improve general configuration by changing > configuration to better suit B0 boards and allow more available > resources to each physical function. > In additition, it contains some small

Re: skb_under_panic in ip_tunnel_xmit

2016-03-02 Thread Eric Dumazet
On mer., 2016-03-02 at 09:11 -0800, Francesco Ruggeri wrote: > I can consistently get this panic on 4.4.1 as well as 3.18. > > [ 2076.264975] gre: GRE over IPv4 demultiplexor driver > [ 2076.269326] ip_gre: GRE over IPv4 tunneling driver > [ 2076.274464] conntrack: generic helper won't handle

[iproute PATCH v2 09/20] man: ip-link.8: minor font fix

2016-03-02 Thread Phil Sutter
We commonly use bold font for terminals and italic for non-terminals. Signed-off-by: Phil Sutter --- man/man8/ip-link.8.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index 221831e52bc9a..2376f1653a8f2 100644 ---

[iproute PATCH v2 16/20] man: ip-tunnel.8: Document missing 6rd action

2016-03-02 Thread Phil Sutter
Also drop the non-terminal 'TIME' description as it is not referenced anywhere. Signed-off-by: Phil Sutter --- man/man8/ip-tunnel.8 | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/man/man8/ip-tunnel.8 b/man/man8/ip-tunnel.8 index

[iproute PATCH v2 00/20] Sync man pages and help texts

2016-03-02 Thread Phil Sutter
This patch series aims at improving consistency of builtin help texts and related man pages (synopsis section at least). It was created by comparing the two and fixing up whatever occurred to be broken. Changes since v1: - rebased onto current master - resolved merge conflict in ip-link.8.in due

[iproute PATCH v2 11/20] man: ip-neighbour: Fix for missing NUD_STATE description

2016-03-02 Thread Phil Sutter
Signed-off-by: Phil Sutter --- man/man8/ip-neighbour.8 | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/man/man8/ip-neighbour.8 b/man/man8/ip-neighbour.8 index c9b0256e12207..19c6d9d8bf605 100644 --- a/man/man8/ip-neighbour.8 +++

[iproute PATCH v2 20/20] man: ip-*.8: drop any reference to generic ip options

2016-03-02 Thread Phil Sutter
Listing generic 'ip' options in subcommand man pages is redundant and error-prone, as they won't be kept in sync anyway. Since many other man pages don't list them either, drop references to them in the remaining ones. Signed-off-by: Phil Sutter --- man/man8/ip-addrlabel.8 | 14

[iproute PATCH v2 01/20] ip: align help text with manpage

2016-03-02 Thread Phil Sutter
Although the ip command accepts both "neighbor" and "neighbour" as subcommand, I assume it's sufficient to list it in help text as just "neigh" like ip.8 does. Signed-off-by: Phil Sutter --- ip/ip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ip.c

[iproute PATCH v2 05/20] ipntable: Fix typo in help text

2016-03-02 Thread Phil Sutter
Signed-off-by: Phil Sutter --- ip/ipntable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ipntable.c b/ip/ipntable.c index 6eb84e797b263..2763570ae34d7 100644 --- a/ip/ipntable.c +++ b/ip/ipntable.c @@ -52,7 +52,7 @@ static void usage(void)

[iproute PATCH v2 15/20] man: ip-token.8: Review synopsis section

2016-03-02 Thread Phil Sutter
Drop unnecessary curly braces around single action keywords, point out that 'dev' parameter to 'ip token get' is optional and clarify that 'ip token' defaults to 'list' action. Signed-off-by: Phil Sutter --- man/man8/ip-token.8 | 12 ++-- 1 file changed, 6 insertions(+), 6

[iproute PATCH v2 03/20] iplink: fix help text syntax

2016-03-02 Thread Phil Sutter
Get rid of extraneous closing brackets and while here, merge the double netns parameter. Signed-off-by: Phil Sutter --- ip/iplink.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/ip/iplink.c b/ip/iplink.c index 69f50572633b1..33d7c0ad0e827 100644 ---

[iproute PATCH v2 19/20] man: ip-l2tp.8: Fix BNF syntax

2016-03-02 Thread Phil Sutter
The 'ADDR' part of 'local' and 'remote' parameters is not optional, but may also consist of the word 'any'. While at it, add missing whitespace and fix fonts. Signed-off-by: Phil Sutter --- man/man8/ip-l2tp.8 | 24 +--- 1 file changed, 9 insertions(+), 15

[iproute PATCH v2 07/20] iprule: add missing nat keyword to help text

2016-03-02 Thread Phil Sutter
Signed-off-by: Phil Sutter --- ip/iprule.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ip/iprule.c b/ip/iprule.c index 33b71976e7b5c..7e3b38b64c6e1 100644 --- a/ip/iprule.c +++ b/ip/iprule.c @@ -39,6 +39,7 @@ static void usage(void) fprintf(stderr, "SELECTOR := [ not

[iproute PATCH v2 14/20] man: ip-rule.8: Review synopsis section

2016-03-02 Thread Phil Sutter
Clarify that 'ip rule' defaults to action 'list', that 'flush' and 'save' actions don't accept additional parameters, add missing 'not' and 'goto' keywords and finally fix fonts used in 'fwmark' and 'realms' parameters. Signed-off-by: Phil Sutter --- man/man8/ip-rule.8 | 19

Re: [PATCH] wan: lmc: Switch to using managed resources

2016-03-02 Thread David Miller
From: Amitoj Kaur Chawla Date: Wed, 2 Mar 2016 19:52:42 +0530 > Specifically, pcim_release contains the following code: How incredibly unintuitive that PCI helper functions magically become managed just because a driver invoked pcim_enable_device(). Well, if that's what

Re: [PATCH V2 01/12] net-next: mediatek: Document ralink/mediatek SoC ethernet binding

2016-03-02 Thread John Crispin
On 02/03/2016 19:46, Rob Herring wrote: > On Fri, Feb 26, 2016 at 03:21:33PM +0100, John Crispin wrote: >> Add three files. One describes the actual frame engine, the other two >> describe fast ethernet and gigabit switches bindings. >> >> Signed-off-by: John Crispin >>

Re: [PATCH] iproute2: Fix musl compatibility

2016-03-02 Thread Stephen Hemminger
On Mon, 22 Feb 2016 03:34:48 -0800 Loganaden Velvindron wrote: > diff --git a/include/linux/netfilter.h b/include/linux/netfilter.h > index b71b4c9..3e4e6ae 100644 > --- a/include/linux/netfilter.h > +++ b/include/linux/netfilter.h > @@ -4,8 +4,6 @@ > #include > > #include

Re: skb_under_panic in ip_tunnel_xmit

2016-03-02 Thread Francesco Ruggeri
> I am not sure we want to support ~64K of headers. > > Is this something real, or just another root-exploit > linux-bug-of-the-day trick ? > > When I want to reboot my host I usually type 'reboot', as it looks nicer > to me ;) > Thanks Eric. My point was that an accidental route

Re: [net-next,v7] net: ipv6: Make address flushing on ifdown optional

2016-03-02 Thread David Ahern
On 3/2/16 10:01 AM, Andrey Wagin wrote: Hi David, We execute CRIU test on linux-next. On the current linux-next kernel they hangs on creating a network namespace. The kernel log contains many massages like this: [ 1036.122108] unregister_netdevice: waiting for lo to become free. Usage count =

Re: [PATCH net-next] ipv4: properly apply change to ignore_routes_on_linkdown to all interfaces

2016-03-02 Thread Andy Gospodarek
On Wed, Mar 02, 2016 at 10:17:19AM -0800, David Ahern wrote: > On 3/2/16 8:43 AM, Andy Gospodarek wrote: > > > >+/* called with RTNL locked */ > >+static void inet_ignore_routes_change(struct net *net) > >+{ > >+struct net_device *dev; > >+int on = IPV4_DEVCONF_ALL(net,

Re: [PATCH for-next 01/10] net/core: Add support for configuring VF GUIDs

2016-03-02 Thread Or Gerlitz
On Wed, Mar 2, 2016 at 6:50 PM, Doug Ledford wrote: > Exactly *what* provisioning system tries to set the VF_MAC on an IPoIB > interface and expects it to set the GUID of an underlying IB device? The provisioning system need not be fully aware in all their components this

[iproute PATCH v2 3/4] tc: pedit: Fix retain value for ihl adjustments

2016-03-02 Thread Phil Sutter
Since the IP Header Length field is just half a byte, adjust retain to only match these bits so the Version field is not overwritten by accident. The whole concept is actually broken due to dependency on endianness which pedit ignores. Signed-off-by: Phil Sutter --- tc/p_ip.c | 2

[iproute PATCH v2 1/4] tc: pedit: Fix layered op parsing

2016-03-02 Thread Phil Sutter
After lookup of the layered op submodule, pedit would pass argv and argc including the layered op identifier at first position which confused the submodule parser. Fix this by calling NEXT_ARG() before calling the parse_peopt() callback. Signed-off-by: Phil Sutter --- tc/m_pedit.c

[iproute PATCH v2 2/4] tc: pedit: Fix parse_cmd()

2016-03-02 Thread Phil Sutter
This was horribly broken: * pack_key8() and pack_key16() ... * missed to invert retain value when applying it to the mask, * did not sanitize val by ANDing it with retain, * and ignored the mask which is necessary for 'invert' command. * pack_key16() did not convert mask to network byte

Re: [PATCH/RFC v6 net-next] ravb: Add dma queue interrupt support

2016-03-02 Thread Sergei Shtylyov
On 03/02/2016 09:16 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (timestamp, error, gPTP) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx, network

Re: [PATCH] iproute2: Fix musl compatibility

2016-03-02 Thread Stephen Hemminger
On Mon, 22 Feb 2016 03:34:48 -0800 Loganaden Velvindron wrote: > Don't redefine in6_addr due to including linux/in6.h and also fix > the case of MAXPATHLEN constant not found. > > (Original patch from VoidLinux) > > Signed-off-by: Loganaden Velvindron I

[PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2016-03-02 Thread Arnd Bergmann
The icn, act2000 and pcbit drivers are all for very old hardware, and it is highly unlikely that anyone is actually still using them on modern kernels, if at all. All three drivers apparently are for hardware that predates PCI being the common connector, as they are ISA-only and active PCI ISDN

Re: [PATCH] net: sh_eth: avoid NULL pointer dereference in ring setup

2016-03-02 Thread Sergei Shtylyov
On 03/02/2016 08:11 PM, Wolfram Sang wrote: Reported-by: coverity (CID 1056464) Signed-off-by: Wolfram Sang Will you respin or should I? Please go ahead. You have more knowledge about this driver, so you will be faster. Not necessarily -- I have

Re: [iproute PATCH 3/3] tc: pedit: Fix retain value for ihl adjustments

2016-03-02 Thread Stephen Hemminger
On Wed, 2 Mar 2016 11:20:31 + Phil Sutter wrote: > + res = parse_cmd(, , 1, TU32,0x0f,sel,tkey); > goto done; Please add whitespace after ,

Re: [PATCH net-next] ipv4: properly apply change to ignore_routes_on_linkdown to all interfaces

2016-03-02 Thread David Ahern
On 3/2/16 8:43 AM, Andy Gospodarek wrote: +/* called with RTNL locked */ +static void inet_ignore_routes_change(struct net *net) +{ + struct net_device *dev; + int on = IPV4_DEVCONF_ALL(net, IGNORE_ROUTES_WITH_LINKDOWN); + + IPV4_DEVCONF_DFLT(net, IGNORE_ROUTES_WITH_LINKDOWN)

[iproute PATCH v2 17/20] man: ip-xfrm.8: Document missing parameters

2016-03-02 Thread Phil Sutter
Namely, 'extra-flag' of 'ip xfrm state' and 'flag' of 'ip xfrm policy'. Signed-off-by: Phil Sutter --- man/man8/ip-xfrm.8 | 11 +++ 1 file changed, 11 insertions(+) diff --git a/man/man8/ip-xfrm.8 b/man/man8/ip-xfrm.8 index dae0728811b2e..11f710470377f 100644 ---

[iproute PATCH v2 10/20] man: ip-link.8: Fix and improve synopsis

2016-03-02 Thread Phil Sutter
Reflect that it is possible to pass multiple parameters at the same time, also use the same trick the help text uses to emphasize vf specific parameters. Signed-off-by: Phil Sutter --- man/man8/ip-link.8.in | 100 +++--- 1 file changed,

[iproute PATCH v2 18/20] man: ip.8: Add missing flags and token subcommand description

2016-03-02 Thread Phil Sutter
Signed-off-by: Phil Sutter --- man/man8/ip.8 | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/man/man8/ip.8 b/man/man8/ip.8 index b1f6907367275..aa2bc68c81ab6 100644 --- a/man/man8/ip.8 +++ b/man/man8/ip.8 @@ -21,7 +21,7 @@ ip \- show

[iproute PATCH v2 08/20] man: ip-address.8: Minor syntax fixes

2016-03-02 Thread Phil Sutter
Clarify that the optional '-' prefix of the 'tentative', 'deprecated' and 'dadfailed' keywords has to be put right in front of them, no whitespace is allowed in between. In addition to that, clarify that it is valid to pass both 'valid_lft' and 'preferred_lft' at the same time to 'ip address'.

[iproute PATCH v2 02/20] ipaddrlabel: Improve help text precision

2016-03-02 Thread Phil Sutter
Neither 'list' nor 'flush' actions accept parameters, and with given prefix the action keyword is not optional anymore. Signed-off-by: Phil Sutter --- ip/ipaddrlabel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ip/ipaddrlabel.c b/ip/ipaddrlabel.c index

[iproute PATCH v2 04/20] ipneigh: add missing proxy keyword to help text

2016-03-02 Thread Phil Sutter
And while we're at it, add whitespace around braces and pipe symbol. Signed-off-by: Phil Sutter --- ip/ipneigh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ipneigh.c b/ip/ipneigh.c index 92b7cd6f2a75b..9b1499b08b060 100644 --- a/ip/ipneigh.c +++

[iproute PATCH v2 12/20] man: ip-netns.8: Clarify synopsis a bit

2016-03-02 Thread Phil Sutter
Use brackets to show that 'ip netns' defaults to action 'list', drop superfluous curly braces around 'set' action keyword. Signed-off-by: Phil Sutter --- man/man8/ip-netns.8 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/man8/ip-netns.8

[iproute PATCH v2 13/20] man: ip-ntable.8: Review synopsis section

2016-03-02 Thread Phil Sutter
The first line contained a c'n'p error, incorrectly listing 'ip address' syntax. Since PARAMS is used just once and there are not many other parameters to 'ip ntable change', state them inline and in addition to that clarify the possibility to pass multiple parameters at once. Signed-off-by: Phil

[iproute PATCH v2 06/20] iproute: TYPE keyword is not optional, fix help text accordingly

2016-03-02 Thread Phil Sutter
This is a bit pedantic, but brackets ([]) show optional values and since TYPE must not become empty, they're not suited to surround the type keyword choices. Use curly braces instead. Also add some missing whitespace to the parameter list above. Signed-off-by: Phil Sutter ---

Re: [PATCH] iproute2: Fix musl compatibility

2016-03-02 Thread Loganaden Velvindron
ping stephen.

Re: [PATCH/RFC v5 net-next] ravb: Add dma queue interrupt support

2016-03-02 Thread Sergei Shtylyov
Hello. On 03/02/2016 09:32 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (error, gPTP) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx, network

[iproute PATCH v2 0/4] tc: pedit fixes

2016-03-02 Thread Phil Sutter
While implementing an implementation example for a pedit man page, I noticed several issues with the current code. The following patch series addreses them. In order to validate my changes, I implemented a simple unit tester. It requires the following hack:

Re: [iproute PATCH v2 0/4] tc: pedit fixes

2016-03-02 Thread Stephen Hemminger
On Wed, 2 Mar 2016 19:45:39 +0100 Phil Sutter wrote: > While implementing an implementation example for a pedit man page, I > noticed several issues with the current code. The following patch > series addreses them. Jamal wrote pedit, does he have any comments on this?

[PATCH net-next 0/6] qed: update series

2016-03-02 Thread Yuval Mintz
This patch series tries to improve general configuration by changing configuration to better suit B0 boards and allow more available resources to each physical function. In additition, it contains some small fixes and semantic changes. Dave, Please consider applying this series to `net-next'.

[PATCH net-next 1/6] qed: Correct BAR sizes for older MFW

2016-03-02 Thread Yuval Mintz
From: Ram Amrani Driver learns the inner bar sized from a register configured by management firmware, but older versions are not setting this register. But since we know which values were configured back then, use them instead. Signed-off-by: Ram Amrani

[PATCH v2] net: ezchip: adapt driver to little endian architecture

2016-03-02 Thread Lada Trimasova
Since ezchip network driver is written with big endian EZChip platform it is necessary to add support for little endian architecture. The first issue is that the order of the bits in a bit field is implementation specific. So all the bit fields are removed. Named constants are used to access

Re: [PATCH/RFC v5 net-next] ravb: Add dma queue interrupt support

2016-03-02 Thread Yoshihiro Kaneko
2016-03-01 5:55 GMT+09:00 Sergei Shtylyov : > On 02/28/2016 05:13 PM, Yoshihiro Kaneko wrote: > From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (error,

Re: [PATCH v3 2/4] Documentation: Bindings: Add STM32 DWMAC glue

2016-03-02 Thread Rob Herring
On Fri, Feb 26, 2016 at 11:51:50AM +0100, Alexandre TORGUE wrote: > Signed-off-by: Alexandre TORGUE > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt > b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > new file mode 100644 > index

Re: [PATCH net v2] r8169: Enable RX_MULTI_EN for RTL_GIGA_MAC_VER_41~48

2016-03-02 Thread David Miller
From: Chunhao Lin Date: Thu, 3 Mar 2016 00:59:15 +0800 > For RTL8168G/RTL8168H/RTL8411B/RTL8107E, enable this flag to eliminate > message "AMD-Vi: Event logged [IO_PAGE_FAULT device=01:00.0 domain=0x0002 > address=0x3000 flags=0x0050] in dmesg. > > Signed-off-by:

Re: RDS: Major clean-up with couple of new features for 4.6

2016-03-02 Thread santosh shilimkar
On 3/2/2016 11:13 AM, David Miller wrote: From: Santosh Shilimkar Date: Tue, 1 Mar 2016 15:20:41 -0800 v3: Re-generated the same series by omitting "-D" option from git format-patch command. Since first patch has file removals, git apply/am can't deal with it

[PATCH] ipv6: Fix the pmtu path for connected UDP socket

2016-03-02 Thread Wei Wang
From: Wei Wang When ICMPV6_PKT_TOOBIG message is received by a connected UDP socket, the new mtu value is not properly updated in the dst_entry associated with the socket. This leads to the issue that the mtu value returned by getsockopt(sockfd, IPPROTO_IPV6, IPV6_MTU, ...) is

RE: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-03-02 Thread Fugang Duan
From: Troy Kisky Sent: Thursday, February 25, 2016 8:37 AM > To: netdev@vger.kernel.org; da...@davemloft.net; b38...@freescale.com > Cc: fabio.este...@freescale.com; l.st...@pengutronix.de; and...@lunn.ch; > trem...@gmail.com; li...@arm.linux.org.uk; linux-arm- >

[PATCH net-next] net: sched: use pfifo_fast for non real queues

2016-03-02 Thread Eric Dumazet
Some devices declare a high number of TX queues, then set a much lower real_num_tx_queues This cause setups using fq_codel, sfq or fq as the default qdisc to consume more memory than really needed. Signed-off-by: Eric Dumazet --- include/net/sch_generic.h | 6 ++

[PATCH net v2] r8169: Enable RX_MULTI_EN for RTL_GIGA_MAC_VER_41~48

2016-03-02 Thread Chunhao Lin
For RTL8168G/RTL8168H/RTL8411B/RTL8107E, enable this flag to eliminate message "AMD-Vi: Event logged [IO_PAGE_FAULT device=01:00.0 domain=0x0002 address=0x3000 flags=0x0050] in dmesg. Signed-off-by: Chunhao Lin --- drivers/net/ethernet/realtek/r8169.c | 4 1

Re: [PATCH net-next 1/8] net/flower: Introduce hardware offload support

2016-03-02 Thread John Fastabend
On 16-03-02 05:22 AM, Jiri Pirko wrote: > Wed, Mar 02, 2016 at 12:14:39PM CET, gerlitz...@gmail.com wrote: >> On Tue, Mar 1, 2016 at 7:01 PM, Jiri Pirko wrote: >>> Tue, Mar 01, 2016 at 05:49:27PM CET, a...@vadai.me wrote: On Tue, Mar 01, 2016 at 03:47:19PM +0100, Jiri Pirko

skb_under_panic in ip_tunnel_xmit

2016-03-02 Thread Francesco Ruggeri
I can consistently get this panic on 4.4.1 as well as 3.18. [ 2076.264975] gre: GRE over IPv4 demultiplexor driver [ 2076.269326] ip_gre: GRE over IPv4 tunneling driver [ 2076.274464] conntrack: generic helper won't handle protocol 47. Please consider loading the specific helper module. [

Re: [PATCH] net: sh_eth: avoid NULL pointer dereference in ring setup

2016-03-02 Thread Wolfram Sang
> >Reported-by: coverity (CID 1056464) > >Signed-off-by: Wolfram Sang > >Will you respin or should I? Please go ahead. You have more knowledge about this driver, so you will be faster. Reported-by: Wolfram Sang

[iproute PATCH] ifstat, nstat: fix daemon mode

2016-03-02 Thread Phil Sutter
Since the relevant code (and it's bugs) is identical in both files, fix them in one go. This patch fixes multiple issues: * Using 'int' for the 'tdiff' variable does not suffice on 64bit systems, the assigned initial time difference makes it wrap and contain a negative value afterwards.

Re: [PATCH net-next 6/8] net/mlx5e: Introduce tc offload support

2016-03-02 Thread Jiri Pirko
Wed, Mar 02, 2016 at 04:53:37PM CET, a...@vadai.me wrote: >On Tue, Mar 01, 2016 at 09:13:25AM -0800, John Fastabend wrote: >> On 16-03-01 09:00 AM, Amir Vadai wrote: >> > On Tue, Mar 01, 2016 at 03:52:08PM +0100, Jiri Pirko wrote: >> >> Tue, Mar 01, 2016 at 03:24:48PM CET, a...@vadai.me wrote: >>

Re: [PATCH net-next V2 04/16] net: fec: reduce interrupts

2016-03-02 Thread Zhi Li
On Wed, Mar 2, 2016 at 10:12 AM, Troy Kisky wrote: > On 3/2/2016 8:13 AM, Fugang Duan wrote: >> From: Troy Kisky Sent: Thursday, February >> 25, 2016 8:37 AM >>> To: netdev@vger.kernel.org; da...@davemloft.net; b38...@freescale.com

RE: [PATCH] fsl/fman: remove dTSEC-A003 Errata workaround

2016-03-02 Thread Igal Liberman
> -Original Message- > From: Scott Wood [mailto:scott.w...@nxp.com] > Sent: Tuesday, March 01, 2016 1:31 AM > To: igal.liber...@freescale.com; netdev@vger.kernel.org > Cc: scottw...@freescale.com; madalin.bu...@freescale.com > Subject: Re: [PATCH] fsl/fman: remove dTSEC-A003 Errata

[PATCH 00/14] drivers: use __maybe_unused to hide pm functions

2016-03-02 Thread Arnd Bergmann
I found many variations of the bug in these device drivers (and some USB drivers I already send patches for in a separate series). In each case, the power management operations structure conditionally references suspend/resume functions, but the functions are hidden in an incorrect #ifdef or not

Re: [PATCH] net: sh_eth: avoid NULL pointer dereference in ring setup

2016-03-02 Thread Sergei Shtylyov
Hello. On 03/02/2016 06:26 PM, Wolfram Sang wrote: From: Wolfram Sang When allocating an skb fails, rxdesc is still NULL (or the previous ring index on further iterations of the loop). However, this pointer is dereferenced after the loop. This is

[PATCH net 1/3] net/mlx4_core: Fix lockdep warning in handling of mac/vlan tables

2016-03-02 Thread Or Gerlitz
From: Jack Morgenstein In the mac and vlan register/unregister/replace functions, the driver locks the mac table mutex (or vlan table mutex) on both ports. We move to use mutex_lock_nested() to prevent warnings, such as the one below. [ 101.828445]

[PATCH net 3/3] net/mlx4_core: Allow resetting VF admin mac to zero

2016-03-02 Thread Or Gerlitz
From: Jack Morgenstein The VF administrative mac addresses (stored in the PF driver) are initialized to zero when the PF driver starts up. These addresses may be modified in the PF driver through ndo calls initiated by iproute2 or libvirt. While we allow the PF/host

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

2016-03-02 Thread Tejun Heo
Hello, Jiri. On Fri, Feb 19, 2016 at 01:10:00PM +0100, Jiri Slaby wrote: > > 1. didn't help, the problem persists. So I haven't applied the patch from 2. > > FWIW I dumped more info about the wq: > wq->name='hci0' pwq=8800390d7600 wq->dfl_pwq=8800390d5200 > pwq->refcnt=2 pwq->nr_active=0

Re: [PATCH net-next 6/8] net/mlx5e: Introduce tc offload support

2016-03-02 Thread Amir Vadai
On Tue, Mar 01, 2016 at 09:13:25AM -0800, John Fastabend wrote: > On 16-03-01 09:00 AM, Amir Vadai wrote: > > On Tue, Mar 01, 2016 at 03:52:08PM +0100, Jiri Pirko wrote: > >> Tue, Mar 01, 2016 at 03:24:48PM CET, a...@vadai.me wrote: > >>> Extend ndo_setup_tc() to support ingress tc offloading.

Re: [PATCH for-next 01/10] net/core: Add support for configuring VF GUIDs

2016-03-02 Thread Doug Ledford
On 3/1/2016 4:08 PM, Or Gerlitz wrote: > On Tue, Mar 1, 2016 at 8:25 PM, Jason Gunthorpe > wrote: >> On Tue, Mar 01, 2016 at 07:49:51PM +0200, Eli Cohen wrote: >>> On Tue, Mar 01, 2016 at 10:37:51AM -0700, Jason Gunthorpe wrote: > + return

Re: [PATCH iproute2 v2] iplink: Support VF Trust

2016-03-02 Thread Stephen Hemminger
On Fri, 26 Feb 2016 02:40:18 + Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto > > Add IFLA_VF_TRUST message to trust the VF. > PF can accept some privileged operation from the trusted VF. > For example, ixgbe PF doesn't allow to

[PATCH net 0/3] Mellanox 10/40G mlx4 driver fixes for 4.5-rc6

2016-03-02 Thread Or Gerlitz
Hi Dave, This series contains two fixes for the SRIOV HW LAG that was introduced in 4.5-rc1 and one fix that allows to revoke the administrative MAC that was assigned to VF through the PF. The VF mac fix needs to go for stable too. Or. Jack Morgenstein (2): net/mlx4_core: Fix lockdep

Re: [PATCH iproute2 net-next] bridge: mdb: add user-space support for extended attributes

2016-03-02 Thread Stephen Hemminger
On Mon, 22 Feb 2016 15:00:21 +0100 Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > Recently support was added to the kernel to be able to add more per-mdb > entry attributes via standard netlink attributes of type MDBA_MDB_EATTR_. >

Re: [iproute PATCH] ipl2tp: Print help even on systems without l2tp support

2016-03-02 Thread Stephen Hemminger
On Wed, 24 Feb 2016 09:12:47 +0100 Phil Sutter wrote: > Signed-off-by: Phil Sutter Applied

[PATCH] net: sh_eth: avoid NULL pointer dereference in ring setup

2016-03-02 Thread Wolfram Sang
From: Wolfram Sang When allocating an skb fails, rxdesc is still NULL (or the previous ring index on further iterations of the loop). However, this pointer is dereferenced after the loop. So, make sure rxdesc is updated immediately at the beginning of the loop.

Re: [PATCH net-next V2 04/16] net: fec: reduce interrupts

2016-03-02 Thread Troy Kisky
On 3/2/2016 8:13 AM, Fugang Duan wrote: > From: Troy Kisky Sent: Thursday, February > 25, 2016 8:37 AM >> To: netdev@vger.kernel.org; da...@davemloft.net; b38...@freescale.com >> Cc: fabio.este...@freescale.com; l.st...@pengutronix.de; and...@lunn.ch; >>

Re: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-03-02 Thread Troy Kisky
On 3/2/2016 8:16 AM, Fugang Duan wrote: > From: Troy Kisky Sent: Thursday, February > 25, 2016 8:37 AM >> To: netdev@vger.kernel.org; da...@davemloft.net; b38...@freescale.com >> Cc: fabio.este...@freescale.com; l.st...@pengutronix.de; and...@lunn.ch; >>

  1   2   3   >