Re: [net PATCH v2 2/2] ipv4/GRO: Make GRO conform to RFC 6864

2016-04-06 Thread Tom Herbert
On Wed, Apr 6, 2016 at 12:43 PM, David Miller wrote: > From: Tom Herbert > Date: Wed, 6 Apr 2016 10:53:52 -0300 > >> Packets that are forwarded really should not be GRO'ed in the first >> place because of the loss of information and added latency. > >

Re: brcmfmac: sdio: remove unused variable retry_limit

2016-04-06 Thread Kalle Valo
> From: Colin Ian King > > retry_limit has never been used during the life of this driver, so > we may as well remove it as it is redundant. > > Signed-off-by: Colin Ian King > Reviewed-by: Julian Calaby Thanks,

Re: [v2] mwifiex: advertise low priority scan feature

2016-04-06 Thread Kalle Valo
> From: Amitkumar Karwar > > Low priority scan handling code which delays or aborts scan > operation based on Tx traffic is removed recently. The reason > is firmware already takes care of it in our new feature scan > channel gap. Hence we should advertise low priority scan

Re: [RFC PATCH 5/5] Add sample for adding simple drop program to link

2016-04-06 Thread Jesper Dangaard Brouer
I'm testing with this program and these patches, after getting past the challenge of compiling the samples/bpf files ;-) On Fri, 1 Apr 2016 18:21:58 -0700 Brenden Blanco wrote: > Add a sample program that only drops packets at the > BPF_PROG_TYPE_PHYS_DEV hook of a

Re: af_packet: tone down the Tx-ring unsupported spew.

2016-04-06 Thread David Miller
From: Dave Jones Date: Mon, 4 Apr 2016 15:11:50 -0400 > Trinity and other fuzzers can hit this WARN on far too easily, > resulting in a tainted kernel that hinders automated fuzzing. > > Replace it with a rate-limited printk. > > Signed-off-by: Dave Jones

[PATCH v2] sctp: avoid refreshing heartbeat timer too often

2016-04-06 Thread Marcelo Ricardo Leitner
Currently on high rate SCTP streams the heartbeat timer refresh can consume quite a lot of resources as timer updates are costly and it contains a random factor, which a) is also costly and b) invalidates mod_timer() optimization for not editing a timer to the same value. It may even cause the

Re: [PATCH net-next 1/3] net: bcmgenet: cleanup for bcmgenet_xmit()

2016-04-06 Thread Petri Gynther
On Wed, Apr 6, 2016 at 1:57 AM, David Laight wrote: > From: Petri Gynther >> Sent: 05 April 2016 01:10 > ... >> 2. Readability: Add parentheses around nr_frags + 1. > ... >> - if (ring->free_bds <= nr_frags + 1) { > ... >> + if (ring->free_bds <= (nr_frags + 1)) {

Re: [RFC PATCH 5/5] Add sample for adding simple drop program to link

2016-04-06 Thread Daniel Borkmann
On 04/06/2016 09:48 PM, Jesper Dangaard Brouer wrote: I'm testing with this program and these patches, after getting past the challenge of compiling the samples/bpf files ;-) On Fri, 1 Apr 2016 18:21:58 -0700 Brenden Blanco wrote: Add a sample program that only drops

Re: [Patch net] net_sched: fix a memory leak in tc action

2016-04-06 Thread David Miller
From: Cong Wang Date: Mon, 4 Apr 2016 10:32:48 -0700 > Fixes: ddf97ccdd7cb ("net_sched: add network namespace support for tc > actions") > Reported-by: Dmitry Vyukov > Tested-by: Dmitry Vyukov > Cc: Jamal Hadi Salim

Re: [RFC PATCH net 3/4] ipv6: datagram: Update dst cache of a connected datagram sk during pmtu update

2016-04-06 Thread Cong Wang
On Tue, Apr 5, 2016 at 5:11 PM, Martin KaFai Lau wrote: > On Mon, Apr 04, 2016 at 01:45:02PM -0700, Cong Wang wrote: >> I see your point, but calling __ip6_datagram_connect() seems overkill >> here, we don't need to update so many things in the pmtu update context, >> at least IPv4

Re: [RFC PATCH 0/2] selinux: avoid nf hooks overhead when not needed

2016-04-06 Thread David Miller
From: Paul Moore Date: Wed, 6 Apr 2016 10:07:27 -0400 > "While marking the LSM hook structure doesn't directly affect the > SELinux netfilter hooks, once we remove the ability to deregister the > LSM hooks we will have no need to support deregistering netfilter > hooks and I

RE: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

2016-04-06 Thread Machani, Yaniv
On Wed, Apr 06, 2016 at 22:07:39, Kalle Valo wrote: > > > More than that, wl1251 family is not officially supported via the > > mainline Linux. > > I guess you mean not officially supported by TI? Because wl1251 driver > has been in mainline for ages and reportedly working. > Correct.

Re: [PATCH v2 1/2] sctp: compress bit-wide flags to a bitfield on sctp_sock

2016-04-06 Thread David Miller
From: Joe Perches Date: Wed, 06 Apr 2016 12:53:24 -0700 > On Wed, 2016-04-06 at 14:53 -0300, Marcelo Ricardo Leitner wrote: >> It wastes space and gets worse as we add new flags, so convert bit-wide >> flags to a bitfield. >> >> Currently it already saves 4 bytes in sctp_sock,

[PATCH v2 0/2] sctp: delay calls to sk_data_ready() as much as possible

2016-04-06 Thread Marcelo Ricardo Leitner
1st patch is a preparation for the 2nd. The idea is to not call ->sk_data_ready() for every data chunk processed while processing packets but only once before releasing the socket. v2: patchset re-checked, small changelog fixes Marcelo Ricardo Leitner (2): sctp: compress bit-wide flags to a

[PATCH v2 2/2] sctp: delay calls to sk_data_ready() as much as possible

2016-04-06 Thread Marcelo Ricardo Leitner
Currently, the processing of multiple chunks in a single SCTP packet leads to multiple calls to sk_data_ready, causing multiple wake up signals which are costly and doesn't make it wake up any faster. With this patch it will notice that the wake up is pending and will do it before leaving the

[PATCH v2 1/2] sctp: compress bit-wide flags to a bitfield on sctp_sock

2016-04-06 Thread Marcelo Ricardo Leitner
It wastes space and gets worse as we add new flags, so convert bit-wide flags to a bitfield. Currently it already saves 4 bytes in sctp_sock, which are left as holes in it for now. The whole struct needs packing, which should be done in another patch. Note that do_auto_asconf cannot be merged,

Re: [PATCH] packet: uses kfree_skb() for drop.

2016-04-06 Thread Weongyo Jeong
On Wed, Apr 06, 2016 at 01:27:11PM -0400, Willem de Bruijn wrote: > On Wed, Apr 6, 2016 at 12:54 PM, Weongyo Jeong > wrote: > > consume_skb() isn't for drop or error cases. kfree_skb() is more proper > > one. > > Signed-off-by: Weongyo Jeong >

Re: [RFC PATCH 0/2] selinux: avoid nf hooks overhead when not needed

2016-04-06 Thread David Miller
From: Paul Moore Date: Wed, 6 Apr 2016 14:36:43 -0400 > On Wed, Apr 6, 2016 at 2:23 PM, David Miller wrote: >> From: Paul Moore >> Date: Wed, 6 Apr 2016 10:07:27 -0400 >> >>> "While marking the LSM hook structure doesn't directly

Re: [PATCHv2 net 2/3] samples/bpf: Use llc in PATH, rather than a hardcoded value

2016-04-06 Thread David Miller
From: "Naveen N. Rao" Date: Mon, 4 Apr 2016 22:31:33 +0530 > While at it, remove the generation of .s files and fix some typos in the > related comment. > > Cc: Alexei Starovoitov > Cc: David S. Miller > Cc: Daniel Borkmann

Re: [PATCHv2 net 3/3] samples/bpf: Enable powerpc support

2016-04-06 Thread David Miller
From: "Naveen N. Rao" Date: Mon, 4 Apr 2016 22:31:34 +0530 > Add the necessary definitions for building bpf samples on ppc. > > Since ppc doesn't store function return address on the stack, modify how > PT_REGS_RET() and PT_REGS_FP() work. > > Also, introduce

Re: [PATCHv2 net 1/3] samples/bpf: Fix build breakage with map_perf_test_user.c

2016-04-06 Thread David Miller
From: "Naveen N. Rao" Date: Mon, 4 Apr 2016 22:31:32 +0530 > Building BPF samples is failing with the below error: ... > Fix this by including the necessary header file. > > Cc: Alexei Starovoitov > Cc: Daniel Borkmann >

Re: [PATCHv2 net-next] cxgb4/cxgb4vf: Deprecate module parameter dflt_msg_enable

2016-04-06 Thread David Miller
From: Hariprasad Shenai Date: Tue, 5 Apr 2016 09:52:21 +0530 > Message level can be set through ethtool, so deprecate module parameter > which is used to set the same. > > Signed-off-by: Hariprasad Shenai Applied, thank you.

Re: [PATCH] neigh: remove duplicated log msg

2016-04-06 Thread David Miller
From: Abdelmajid Mlayeh Date: Wed, 6 Apr 2016 14:42:06 +0200 > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the

Re: [RFC PATCH 0/2] selinux: avoid nf hooks overhead when not needed

2016-04-06 Thread Paul Moore
On Wed, Apr 6, 2016 at 2:23 PM, David Miller wrote: > From: Paul Moore > Date: Wed, 6 Apr 2016 10:07:27 -0400 > >> "While marking the LSM hook structure doesn't directly affect the >> SELinux netfilter hooks, once we remove the ability to deregister the

Re: [PATCH] packet: uses kfree_skb() for drop.

2016-04-06 Thread Willem de Bruijn
On Wed, Apr 6, 2016 at 12:54 PM, Weongyo Jeong wrote: > consume_skb() isn't for drop or error cases. kfree_skb() is more proper > one. > Signed-off-by: Weongyo Jeong > --- > net/packet/af_packet.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: rtlwifi: btcoexist: Convert BTC_PRINTK to btc__dbg

2016-04-06 Thread Kalle Valo
> Use a more common logging style. > > Miscellanea: > > o Add specific logging macros for ALGORITHM and INTERFACE types > o Output the messages at KERN_DEBUG > o Coalesce formats > o Align arguments > o Whitespace style adjustments for only these changes > > Signed-off-by: Joe Perches

Re: [RFC PATCH net 3/4] ipv6: datagram: Update dst cache of a connected datagram sk during pmtu update

2016-04-06 Thread Martin KaFai Lau
On Wed, Apr 06, 2016 at 10:58:23AM -0700, Cong Wang wrote: > On Tue, Apr 5, 2016 at 5:11 PM, Martin KaFai Lau wrote: > > On Mon, Apr 04, 2016 at 01:45:02PM -0700, Cong Wang wrote: > >> I see your point, but calling __ip6_datagram_connect() seems overkill > >> here, we don't need to

Re: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

2016-04-06 Thread Kalle Valo
"Machani, Yaniv" writes: > More than that, wl1251 family is not officially supported via the > mainline Linux. I guess you mean not officially supported by TI? Because wl1251 driver has been in mainline for ages and reportedly working. -- Kalle Valo

Re: [net PATCH v2 2/2] ipv4/GRO: Make GRO conform to RFC 6864

2016-04-06 Thread David Miller
From: Tom Herbert Date: Wed, 6 Apr 2016 14:42:26 -0300 > On Wed, Apr 6, 2016 at 12:43 PM, David Miller wrote: >> From: Tom Herbert >> Date: Wed, 6 Apr 2016 10:53:52 -0300 >> >>> Packets that are forwarded really should not be

Re: [PATCH net] net: sched: do not requeue a NULL skb

2016-04-06 Thread Cong Wang
On Wed, Apr 6, 2016 at 6:10 AM, Lars Persson wrote: > A failure in validate_xmit_skb_list() triggered an unconditional call > to dev_requeue_skb with skb=NULL. This slowly grows the queue > discipline's qlen count until all traffic through the queue stops. > Sounds

Re: wl12xx: remove redundant null check on wl->scan.ssid

2016-04-06 Thread Kalle Valo
> From: Colin Ian King > > ssid is an array of u8, so it can never be null, so the null check on > wl->scan.ssid is redundant and can be removed. > > Signed-off-by: Colin Ian King Thanks, applied to wireless-drivers-next.git. Kalle Valo

Re: [PATCH net] cxgb4: Add pci device id for chelsio t520-cr adapter

2016-04-06 Thread David Miller
From: Hariprasad Shenai Date: Mon, 4 Apr 2016 09:54:53 +0530 > Signed-off-by: Hariprasad Shenai Applied, thank you.

Re: [PATCH v2 1/2] sctp: compress bit-wide flags to a bitfield on sctp_sock

2016-04-06 Thread Joe Perches
On Wed, 2016-04-06 at 14:53 -0300, Marcelo Ricardo Leitner wrote: > It wastes space and gets worse as we add new flags, so convert bit-wide > flags to a bitfield. > > Currently it already saves 4 bytes in sctp_sock, which are left as holes > in it for now. The whole struct needs packing, which

Re: [RFC PATCH 5/5] Add sample for adding simple drop program to link

2016-04-06 Thread Jesper Dangaard Brouer
On Wed, 6 Apr 2016 21:48:48 +0200 Jesper Dangaard Brouer wrote: > I'm testing with this program and these patches, after getting past the > challenge of compiling the samples/bpf files ;-) > > > On Fri, 1 Apr 2016 18:21:58 -0700 Brenden Blanco >

[PATCH 1/3] bonding: do not allow rlb updates to invalid mac

2016-04-06 Thread Debabrata Banerjee
Make sure multicast, broadcast, and zero mac's cannot be the output of rlb updates, which should all be directed arps. Receive load balancing will be collapsed if any of these happen, as the switch will broadcast. Signed-off-by: Debabrata Banerjee diff --git

[PATCH 2/3] bonding: don't request extraneous rlb updates

2016-04-06 Thread Debabrata Banerjee
Don't attempt to send rlb updates for incomplete entries, which can't be sent anyway. Signed-off-by: Debabrata Banerjee diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c index 1b45378..b7c7027 100644 --- a/drivers/net/bonding/bond_alb.c +++

[PATCH 3/3] bonding: use common broadcast addr checks

2016-04-06 Thread Debabrata Banerjee
Replace homegrown broadcast checks with faster defs from etherdevice.h Signed-off-by: Debabrata Banerjee diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c index b7c7027..27238f3 100644 --- a/drivers/net/bonding/bond_alb.c +++

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-06 Thread Florian Fainelli
2016-04-05 17:50 GMT-07:00 Petri Gynther : > Add Byte Queue Limits (BQL) support to bcmgenet driver. > > Signed-off-by: Petri Gynther Signed-off-by: Florian Fainelli Thanks! -- Florian

Re: [PATCH net] MAINTAINERS: intel-wired-lan list is moderated

2016-04-06 Thread David Miller
From: Jiri Benc Date: Tue, 5 Apr 2016 16:39:37 +0200 > I got the following message: > >> Your mail to 'Intel-wired-lan' with the subject >> >> [PATCH net-next] net: intel: remove dead links >> >> Is being held until the list moderator can review it for approval. >> >> The

Re: [PATCH net-next] net: intel: remove dead links

2016-04-06 Thread Jeff Kirsher
On Wed, 2016-04-06 at 16:54 -0400, David Miller wrote: > From: Jiri Benc > Date: Tue,  5 Apr 2016 16:25:07 +0200 > > > > > The Kconfig for Intel NICs references two different URLs for the > > "Adapter > > & Driver ID Guide". Neither of those two links works. The current > >

Re: [PATCH net-next v3 0/4] vxlan: implement Generic Protocol Extension (GPE)

2016-04-06 Thread David Miller
From: Jiri Benc Date: Tue, 5 Apr 2016 14:47:09 +0200 > v3: just rebased on top of the current net-next, no changes > > This patchset implements VXLAN-GPE. It follows the same model as the tun/tap > driver: depending on the chosen mode, the vxlan interface is created either >

Re: [PATCH net 3/4] lib/test_bpf: Add test to check for result of 32-bit add that overflows

2016-04-06 Thread David Miller
From: "Naveen N. Rao" Date: Tue, 5 Apr 2016 15:32:55 +0530 > BPF_ALU32 and BPF_ALU64 tests for adding two 32-bit values that results in > 32-bit overflow. > > Cc: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: "David S.

Re: [PATCH net 4/4] lib/test_bpf: Add additional BPF_ADD tests

2016-04-06 Thread David Miller
From: "Naveen N. Rao" Date: Tue, 5 Apr 2016 15:32:56 +0530 > Some of these tests proved useful with the powerpc eBPF JIT port due to > sign-extended 16-bit immediate loads. Though some of these aspects get > covered in other tests, it is better to have explicit

Re: [PATCH net 1/4] lib/test_bpf: Fix JMP_JSET tests

2016-04-06 Thread David Miller
From: "Naveen N. Rao" Date: Tue, 5 Apr 2016 15:32:53 +0530 > JMP_JSET tests incorrectly used BPF_JNE. Fix the same. > > Cc: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: "David S. Miller" > Cc: Ananth

Re: [PATCH net 2/4] lib/test_bpf: Add tests for unsigned BPF_JGT

2016-04-06 Thread David Miller
From: "Naveen N. Rao" Date: Tue, 5 Apr 2016 15:32:54 +0530 > Unsigned Jump-if-Greater-Than. > > Cc: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: "David S. Miller" > Cc: Ananth N Mavinakayanahalli

Re: [PATCH v2 1/2] sctp: compress bit-wide flags to a bitfield on sctp_sock

2016-04-06 Thread marcelo . leitner
On Wed, Apr 06, 2016 at 03:57:35PM -0400, David Miller wrote: > From: Joe Perches > Date: Wed, 06 Apr 2016 12:53:24 -0700 > > > On Wed, 2016-04-06 at 14:53 -0300, Marcelo Ricardo Leitner wrote: > >> It wastes space and gets worse as we add new flags, so convert bit-wide > >>

Re: [PATCH] macvlan: Support interface operstate properly

2016-04-06 Thread Banerjee, Debabrata
On 4/6/16, 5:03 PM, "Nikolay Aleksandrov" wrote: >On 04/06/2016 10:30 PM, Debabrata Banerjee wrote: >> Set appropriate macvlan interface status based on lower device and our >> status. Can be up, down, or lowerlayerdown. >> >> Signed-off-by: Debabrata Banerjee

Re: [RFC PATCH 2/2] selinux: implement support for dynamic net hook [de-]registration

2016-04-06 Thread Casey Schaufler
On 4/6/2016 2:51 AM, Paolo Abeni wrote: > This patch leverage the netlbl_changed() hook to perform on demand > registration and deregistration of the netfilter hooks and the > socket_sock_rcv_skb hook. > > With default policy and empty netfilter/netlabel configuration, the > above hooks are not

Re: [PATCHv2 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge_parm

2016-04-06 Thread David Miller
From: Toshiaki Makita Date: Tue, 5 Apr 2016 14:08:13 +0900 > On 2016/04/05 12:32, Xin Long wrote: >> There are some repetitive codes in stp_state_store, we can remove >> them by calling store_bridge_parm. >> >> Signed-off-by: Xin Long >> ---

Re: [PATCH net-next 0/7] sctp: support sctp_diag in kernel

2016-04-06 Thread David Miller
From: Xin Long Date: Tue, 5 Apr 2016 12:06:25 +0800 > This patchset will add sctp_diag module to implement diag interface on > sctp in kernel. ... This series looks generally fine to me, but I'd like to see some review from SCTP experts before I apply this series.

Re: [PATCH (net.git)] stmmac: fix adjust link call in case of a switch is attached

2016-04-06 Thread David Miller
From: Giuseppe Cavallaro Date: Tue, 5 Apr 2016 08:46:57 +0200 > While initializing the phy, the stmmac driver sets the > PHY_IGNORE_INTERRUPT so the PAL won't call the adjust hook > that is needed, on some platforms, e.g. STi, to invoke the glue. > > The patch allows the

Re: [PATCH net-next] net: intel: remove dead links

2016-04-06 Thread David Miller
From: Jiri Benc Date: Tue, 5 Apr 2016 16:25:07 +0200 > The Kconfig for Intel NICs references two different URLs for the "Adapter > & Driver ID Guide". Neither of those two links works. The current URL seems > to be >

Re: [net-next 00/14][pull request] 40GbE Intel Wired LAN Driver Updates 2016-04-05

2016-04-06 Thread David Miller
From: Jeff Kirsher Date: Tue, 5 Apr 2016 20:35:55 -0700 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff.

Re: [PATCH] macvlan: Support interface operstate properly

2016-04-06 Thread Nikolay Aleksandrov
On 04/06/2016 10:30 PM, Debabrata Banerjee wrote: > Set appropriate macvlan interface status based on lower device and our > status. Can be up, down, or lowerlayerdown. > > Signed-off-by: Debabrata Banerjee > May I ask what is exactly that you're fixing here ? I recently

Re: [PATCH net-next 2/3] net: bcmgenet: cleanup for bcmgenet_xmit_frag()

2016-04-06 Thread David Miller
From: Petri Gynther Date: Mon, 4 Apr 2016 17:10:00 -0700 > Add frag_size = skb_frag_size(frag) and use it when needed. > > Signed-off-by: Petri Gynther Applied.

Re: [PATCH net-next 1/3] net: bcmgenet: cleanup for bcmgenet_xmit()

2016-04-06 Thread David Miller
From: Petri Gynther Date: Mon, 4 Apr 2016 17:09:59 -0700 > 1. Readability: Move nr_frags assignment a few lines down in order >to bundle index -> ring -> txq calculations together. > 2. Readability: Add parentheses around nr_frags + 1. > 3. Minor fix: Stop the Tx queue

Re: [PATCH net-next 3/3] net: bcmgenet: fix dmadesc_set()

2016-04-06 Thread David Miller
From: Petri Gynther Date: Mon, 4 Apr 2016 17:10:01 -0700 > dmadesc_set() is used for setting the Tx buffer DMA address, length, > and status bits on a Tx ring descriptor when a frame is being Tx'ed. > > Always set the Tx buffer DMA address first, before updating the length

Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops

2016-04-06 Thread Florian Fainelli
2016-04-06 8:55 GMT-07:00 Vivien Didelot : > Neither the DSA layer nor the bridge code (see br_set_state) really care > about eventual errors from STP state setters, so make it void. > > The DSA layer separates the prepare and commit phases of switchdev in >

Re: [PATCH net-next V3 00/16] net: fec: cleanup and fixes

2016-04-06 Thread David Miller
This is a way too large patch series. Please split it up into smaller, more logical, pieces. Thanks.

Re: [PATCH net-next V3 05/16] net: fec: reduce interrupts

2016-04-06 Thread David Miller
From: Troy Kisky Date: Tue, 5 Apr 2016 19:25:51 -0700 > By clearing the NAPI interrupts in the NAPI routine > and not in the interrupt handler, we can reduce the > number of interrupts. We also don't need any status > variables as the registers are still valid. >

Re: [RFC PATCH 0/2] selinux: avoid nf hooks overhead when not needed

2016-04-06 Thread Paul Moore
On Wed, Apr 6, 2016 at 5:37 PM, Casey Schaufler wrote: > On 4/6/2016 2:51 AM, Paolo Abeni wrote: >> Currently, selinux always registers iptables POSTROUTING hooks regarless of >> the running policy needs for any action to be performed by them. >> >> Even the

Re: [RFC PATCH 0/2] selinux: avoid nf hooks overhead when not needed

2016-04-06 Thread Florian Westphal
Paul Moore wrote: > On Wed, Apr 6, 2016 at 5:51 AM, Paolo Abeni wrote: > > Currently, selinux always registers iptables POSTROUTING hooks regarless of > > the running policy needs for any action to be performed by them. > > > > Even the

[PATCH net-next v2] macvlan: Support interface operstate properly

2016-04-06 Thread Debabrata Banerjee
Set appropriate macvlan interface status based on lower device and our status. Can be up, down, or lowerlayerdown. de7d244d0 improved operstate by setting it from unknown to up, however it did not handle transferring down or lowerlayerdown. Signed-off-by: Debabrata Banerjee

Re: [RFC PATCH 0/2] selinux: avoid nf hooks overhead when not needed

2016-04-06 Thread Paul Moore
On Wed, Apr 6, 2016 at 3:39 PM, David Miller wrote: > From: Paul Moore > Date: Wed, 6 Apr 2016 14:36:43 -0400 > >> On Wed, Apr 6, 2016 at 2:23 PM, David Miller wrote: >>> From: Paul Moore >>> Date: Wed, 6 Apr

[PATCH] macvlan: Support interface operstate properly

2016-04-06 Thread Debabrata Banerjee
Set appropriate macvlan interface status based on lower device and our status. Can be up, down, or lowerlayerdown. Signed-off-by: Debabrata Banerjee diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 2bcf1f3..0f4b000 100644 --- a/drivers/net/macvlan.c +++

[PATCH v2] packet: uses kfree_skb() for drops or errors.

2016-04-06 Thread Weongyo Jeong
consume_skb() isn't for drop or error cases that kfree_skb() is more proper one. At this patch, it fixed tpacket_rcv() and packet_rcv() to be consistent for error or non-error cases letting perf trace its event properly. Signed-off-by: Weongyo Jeong ---

Re: [patch net-next 00/17] mlxsw: Introduce support for Data Center Bridging

2016-04-06 Thread David Miller
From: Jiri Pirko Date: Wed, 6 Apr 2016 17:09:59 +0200 > From: Jiri Pirko > > Ido says: > > This patchset introduces support for Quality of Service (QoS) as part of the > IEEE Data Center Bridiging (DCB) standards. > > Patches 1-9 do the required device

Re: [PATCH] macvlan: Support interface operstate properly

2016-04-06 Thread Nikolay Aleksandrov
On 04/06/2016 11:03 PM, Nikolay Aleksandrov wrote: > On 04/06/2016 10:30 PM, Debabrata Banerjee wrote: >> Set appropriate macvlan interface status based on lower device and our >> status. Can be up, down, or lowerlayerdown. >> >> Signed-off-by: Debabrata Banerjee >> > > May

Re: [RFC PATCH 0/2] selinux: avoid nf hooks overhead when not needed

2016-04-06 Thread Casey Schaufler
On 4/6/2016 2:51 AM, Paolo Abeni wrote: > Currently, selinux always registers iptables POSTROUTING hooks regarless of > the running policy needs for any action to be performed by them. > > Even the socket_sock_rcv_skb() is always registered, but it can result in a > no-op > depending on the

Re: [PATCH net-next 0/7] sctp: support sctp_diag in kernel

2016-04-06 Thread marcelo . leitner
On Wed, Apr 06, 2016 at 04:13:12PM -0400, David Miller wrote: > From: Xin Long > Date: Tue, 5 Apr 2016 12:06:25 +0800 > > > This patchset will add sctp_diag module to implement diag interface on > > sctp in kernel. > ... > > This series looks generally fine to me, but

Re: [RFC PATCH 0/2] selinux: avoid nf hooks overhead when not needed

2016-04-06 Thread Casey Schaufler
On 4/6/2016 2:51 AM, Paolo Abeni wrote: > Currently, selinux always registers iptables POSTROUTING hooks regarless of > the running policy needs for any action to be performed by them. > > Even the socket_sock_rcv_skb() is always registered, but it can result in a > no-op > depending on the

Re: [PATCH net-next] net: add the AF_KCM entries to family name tables

2016-04-06 Thread David Miller
From: Dexuan Cui Date: Tue, 5 Apr 2016 07:41:11 -0700 > This is for the recent kcm driver, which introduces AF_KCM(41) in > b7ac4eb(kcm: Kernel Connection Multiplexor module). > > Signed-off-by: Dexuan Cui > Cc: Signed-off-by: Tom Herbert

Re: [PATCH] macvlan: Support interface operstate properly

2016-04-06 Thread Nikolay Aleksandrov
On 04/06/2016 11:26 PM, Banerjee, Debabrata wrote: > On 4/6/16, 5:03 PM, "Nikolay Aleksandrov" wrote: > > >> On 04/06/2016 10:30 PM, Debabrata Banerjee wrote: >>> Set appropriate macvlan interface status based on lower device and our >>> status. Can be up, down, or

[PATCH v2 24/30] ethernet: use parity8 in sun/niu.c

2016-04-06 Thread zengzhaoxiu
From: Zhaoxiu Zeng Signed-off-by: Zhaoxiu Zeng --- drivers/net/ethernet/sun/niu.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c index

Re: [RFC PATCH 6/6] ppp: add rtnetlink device creation support

2016-04-06 Thread walter harms
Am 05.04.2016 23:22, schrieb Guillaume Nault: > On Tue, Apr 05, 2016 at 07:18:14PM +0200, walter harms wrote: >> >> >> Am 05.04.2016 02:56, schrieb Guillaume Nault: >>> @@ -1043,12 +1048,39 @@ static int ppp_dev_configure(struct net *src_net, >>> struct net_device *dev, >>>

RE: [PATCH net-next V3 02/16] net: fec: remove unused interrupt FEC_ENET_TS_TIMER

2016-04-06 Thread Fugang Duan
From: Troy Kisky Sent: Wednesday, April 06, 2016 10:26 AM > To: netdev@vger.kernel.org; da...@davemloft.net; Fugang Duan > ; lzn...@gmail.com > Cc: Fabio Estevam ; l.st...@pengutronix.de; > and...@lunn.ch;

RE: [PATCH net-next V3 05/16] net: fec: reduce interrupts

2016-04-06 Thread Fugang Duan
From: Troy Kisky Sent: Wednesday, April 06, 2016 10:26 AM > To: netdev@vger.kernel.org; da...@davemloft.net; Fugang Duan > ; lzn...@gmail.com > Cc: Fabio Estevam ; l.st...@pengutronix.de; > and...@lunn.ch;

[PATCH v2 30/30] ethernet: use parity8 in broadcom/tg3.c

2016-04-06 Thread zengzhaoxiu
From: Zhaoxiu Zeng Signed-off-by: Zhaoxiu Zeng --- drivers/net/ethernet/broadcom/tg3.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index

RE: [PATCH net-next] net: add the AF_KCM entries to family name tables

2016-04-06 Thread Dexuan Cui
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Dexuan Cui > Sent: Tuesday, April 5, 2016 22:41 > To: da...@davemloft.net; netdev@vger.kernel.org > Subject: [PATCH net-next] net: add the AF_KCM entries to family name tables > > This is for the recent kcm

Re: [net PATCH v2 2/2] ipv4/GRO: Make GRO conform to RFC 6864

2016-04-06 Thread Edward Cree
On 06/04/16 00:45, David Miller wrote: > From: Edward Cree > Date: Tue, 5 Apr 2016 16:07:49 +0100 > >> On the gripping hand, I feel like GRO+TSO is the wrong model for >> speeding up forwarding/routing workloads. Instead we should be >> looking into having lists of SKBs

RE: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

2016-04-06 Thread Machani, Yaniv
On Mon, Apr 04, 2016 at 15:39:44, Pali Rohár wrote: > > In linux-firmware repository [1] is missing AP firmware for TI > > wl1251 chip. There is only STA firmware wl1251-fw.bin which supports > > managed and ad-hoc modes. > > > > For other TI wilink chips there are -ap.bin firmware files > >

[PATCH v2 11/30] sunrpc: use parity8

2016-04-06 Thread zengzhaoxiu
From: Zhaoxiu Zeng Signed-off-by: Zhaoxiu Zeng --- net/sunrpc/auth_gss/gss_krb5_keys.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/sunrpc/auth_gss/gss_krb5_keys.c b/net/sunrpc/auth_gss/gss_krb5_keys.c index

[RFC PATCH 1/2] security: add hook for netlabel status change notification

2016-04-06 Thread Paolo Abeni
This patch adds a new LSM hook called every time the netlbl usage count is changed. This allows an LSM to register a set of hooks on demand according to the netlabel status. Signed-off-by: Paolo Abeni --- include/linux/lsm_hooks.h | 6 ++ include/linux/security.h

[RFC PATCH 2/2] selinux: implement support for dynamic net hook [de-]registration

2016-04-06 Thread Paolo Abeni
This patch leverage the netlbl_changed() hook to perform on demand registration and deregistration of the netfilter hooks and the socket_sock_rcv_skb hook. With default policy and empty netfilter/netlabel configuration, the above hooks are not registered and this allows avoiding nf_hook_slow in

[RFC PATCH 0/2] selinux: avoid nf hooks overhead when not needed

2016-04-06 Thread Paolo Abeni
Currently, selinux always registers iptables POSTROUTING hooks regarless of the running policy needs for any action to be performed by them. Even the socket_sock_rcv_skb() is always registered, but it can result in a no-op depending on the current policy configuration. The above invocations in

RE: [PATCH net-next V3 08/16] net: fec: set cbd_sc without relying on previous value

2016-04-06 Thread Fugang Duan
From: Troy Kisky Sent: Wednesday, April 06, 2016 10:26 AM > To: netdev@vger.kernel.org; da...@davemloft.net; Fugang Duan > ; lzn...@gmail.com > Cc: Fabio Estevam ; l.st...@pengutronix.de; > and...@lunn.ch;

[PATCH v2 net-next 03/10] perf: split perf_trace_buf_prepare into alloc and update parts

2016-04-06 Thread Alexei Starovoitov
split allows to move expensive update of 'struct trace_entry' to later phase. Repurpose unused 1st argument of perf_tp_event() to indicate event type. While splitting use temp variable 'rctx' instead of '*rctx' to avoid unnecessary loads done by the compiler due to -fno-strict-aliasing

[PATCH v2 net-next 07/10] bpf: sanitize bpf tracepoint access

2016-04-06 Thread Alexei Starovoitov
during bpf program loading remember the last byte of ctx access and at the time of attaching the program to tracepoint check that the program doesn't access bytes beyond defined in tracepoint fields This also disallows access to __dynamic_array fields, but can be relaxed in the future.

[PATCH v2 net-next 05/10] bpf: register BPF_PROG_TYPE_TRACEPOINT program type

2016-04-06 Thread Alexei Starovoitov
register tracepoint bpf program type and let it call the same set of helper functions as BPF_PROG_TYPE_KPROBE Signed-off-by: Alexei Starovoitov --- kernel/trace/bpf_trace.c | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions(-)

[PATCH v2 net-next 10/10] samples/bpf: add tracepoint vs kprobe performance tests

2016-04-06 Thread Alexei Starovoitov
the first microbenchmark does fd=open("/proc/self/comm"); for() { write(fd, "test"); } and on 4 cpus in parallel: writes per sec base (no tracepoints, no kprobes) 930k with kprobe at __set_task_comm() 420k with tracepoint at task:task_rename

[PATCH v2 net-next 08/10] samples/bpf: add tracepoint support to bpf loader

2016-04-06 Thread Alexei Starovoitov
Recognize "tracepoint/" section name prefix and attach the program to that tracepoint. Signed-off-by: Alexei Starovoitov --- samples/bpf/bpf_load.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/samples/bpf/bpf_load.c

Re: Boot failure when using NFS on OMAP based evms

2016-04-06 Thread Willem de Bruijn
On Wed, Apr 6, 2016 at 7:12 PM, Franklin S Cooper Jr. wrote: > Hi All, > > Currently linux-next is failing to boot via NFS on my AM335x GP evm, > AM437x GP evm and Beagle X15. I bisected the problem down to the commit > "udp: remove headers from UDP packets before queueing". > > I

Boot failure when using NFS on OMAP based evms

2016-04-06 Thread Franklin S Cooper Jr.
Hi All, Currently linux-next is failing to boot via NFS on my AM335x GP evm, AM437x GP evm and Beagle X15. I bisected the problem down to the commit "udp: remove headers from UDP packets before queueing". I had to revert the following three commits to get things working again:

Re: [PATCH net-next V3 05/16] net: fec: reduce interrupts

2016-04-06 Thread Troy Kisky
On 4/6/2016 2:20 PM, David Miller wrote: > From: Troy Kisky > Date: Tue, 5 Apr 2016 19:25:51 -0700 > >> By clearing the NAPI interrupts in the NAPI routine >> and not in the interrupt handler, we can reduce the >> number of interrupts. We also don't need any

RE: [PATCH net-next V3 00/16] net: fec: cleanup and fixes

2016-04-06 Thread Fugang Duan
From: Troy Kisky Sent: Thursday, April 07, 2016 12:43 AM > To: Fugang Duan ; netdev@vger.kernel.org; > da...@davemloft.net; lzn...@gmail.com > Cc: Fabio Estevam ; l.st...@pengutronix.de; > and...@lunn.ch;

[PATCH v2 net-next 00/10] allow bpf attach to tracepoints

2016-04-06 Thread Alexei Starovoitov
Hi Steven, Peter, v1->v2: addressed Peter's comments: - fixed wording in patch 1, added ack - refactored 2nd patch into 3: 2/10 remove unused __perf_addr macro which frees up an argument in perf_trace_buf_submit 3/10 split perf_trace_buf_prepare into alloc and update parts, so that bpf programs

[PATCH v2 net-next 01/10] perf: optimize perf_fetch_caller_regs

2016-04-06 Thread Alexei Starovoitov
avoid memset in perf_fetch_caller_regs, since it's the critical path of all tracepoints. It's called from perf_sw_event_sched, perf_event_task_sched_in and all of perf_trace_##call with this_cpu_ptr(&__perf_regs[..]) which are zero initialized by perpcu init logic and subsequent call to

RE: [PATCH net-next] net: add the AF_KCM entries to family name tables

2016-04-06 Thread Dexuan Cui
> From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, April 7, 2016 5:00 > To: Dexuan Cui > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH net-next] net: add the AF_KCM entries to family name > tables > > From: Dexuan Cui > Date: Tue, 5

Re: [RFC PATCH 5/5] Add sample for adding simple drop program to link

2016-04-06 Thread Alexei Starovoitov
On Wed, Apr 06, 2016 at 10:01:00PM +0200, Jesper Dangaard Brouer wrote: > On Wed, 6 Apr 2016 21:48:48 +0200 > Jesper Dangaard Brouer wrote: > > If I do multiple flows, via ./pktgen_sample05_flow_per_thread.sh > > then I hit this strange 14.5Mpps limit (proto 17: 14505558

RE: [PATCH net-next] net: intel: remove dead links

2016-04-06 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Jiri Benc > Sent: Tuesday, April 5, 2016 7:25 AM > To: netdev@vger.kernel.org > Cc: Kirsher, Jeffrey T ; Brandeburg, Jesse > ; Nelson, Shannon >

  1   2   3   >