[PATCH v4 2/2] RDS: fix congestion map corruption for PAGE_SIZE > 4k

When PAGE_SIZE > 4k single page can contain 2 RDS fragments. If 'rds_ib_cong_recv' ignore the RDS fragment offset in to the page it then read the data fragment as far congestion map update and lead to corruption of the RDS connection far congestion map. Signed-off-by: Shamir Rabinovitch

[PATCH v4 1/2] RDS: memory allocated must be align to 8

Fix issue in 'rds_ib_cong_recv' when accessing unaligned memory allocated by 'rds_page_remainder_alloc' using uint64_t pointer. Signed-off-by: Shamir Rabinovitch --- net/rds/page.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] net: mark DECnet as broken

On Thu, 7 Apr 2016 09:22:43 +0200 Vegard Nossum wrote: > There are NULL pointer dereference bugs in DECnet which can be triggered > by unprivileged users and have been reported multiple times to LKML, > however nobody seems confident enough in the proposed fixes to

Re: optimizations to sk_buff handling in rds_tcp_data_ready

On Thu, 2016-04-07 at 09:11 -0400, Sowmini Varadhan wrote: > I was going back to Alexei's comment here: > http://permalink.gmane.org/gmane.linux.network/387806 > In rds-stress profiling, we are indeed seeing the pksb_pull > (from rds_tcp_data_recv) show up in the perf profile. > > At least

[PATCH 1/2] drivers: net: cpsw: fix port_mask parameters in ale calls

ALE APIs expect to receive port masks as input values for arguments port_mask, untag, reg_mcast, unreg_mcast. But there are few places in code where port masks are passed left-shifted by cpsw_priv->host_port, like below: cpsw_ale_add_vlan(priv->ale, priv->data.default_vlan,

[PATCH 2/2] drivers: net: cpsw: drop host_port field from struct cpsw_priv

The host_port field is constantly assigned to 0 and this value has never changed (since time when cpsw driver was introduced. More over, if this field will be assigned to non 0 value it will break current driver functionality. Hence, there are no reasons to continue maintaining this host_port

[PATCH 0/2] drivers: net: cpsw: fix ale calls and drop host_port field from cpsw_priv

This clean up series intended to: - fix port_mask parameters in ale calls and drop unnecessary shifts - drop host_port field from struct cpsw_priv Nothing critical. Tested on am437x-idk-evm in dual mac and switch modes. Grygorii Strashko (2): drivers: net: cpsw: fix port_mask parameters in

Re: [PATCH] wlcore: spi: add wl18xx support

"Reizer, Eyal" writes: > Ping on this patch > >> -Original Message- >> From: Eyal Reizer [mailto:eyalrei...@gmail.com] >> Sent: Wednesday, March 30, 2016 4:07 PM >> To: kv...@codeaurora.org; linux-wirel...@vger.kernel.org; >> netdev@vger.kernel.org;

optimizations to sk_buff handling in rds_tcp_data_ready

I was going back to Alexei's comment here: http://permalink.gmane.org/gmane.linux.network/387806 In rds-stress profiling, we are indeed seeing the pksb_pull (from rds_tcp_data_recv) show up in the perf profile. At least for rds-tcp, we cannot re-use the skb even if it is not shared, because

Re: [PATCH] wlcore: spi: add wl18xx support

"Reizer, Eyal" writes: >> > static const struct of_device_id wlcore_spi_of_match_table[] = { >> > - { .compatible = "ti,wl1271" }, >> > + { .compatible = "ti,wl1271", .data = _data}, >> > + { .compatible = "ti,wl1273", .data = _data}, >> > + { .compatible = "ti,wl1281", .data

Re: Boot failure when using NFS on OMAP based evms

On Thu, Apr 7, 2016 at 10:36 AM, Franklin S Cooper Jr. wrote: > > > On 04/06/2016 09:22 PM, Willem de Bruijn wrote: >> On Wed, Apr 6, 2016 at 7:12 PM, Franklin S Cooper Jr. wrote: >>> Hi All, >>> >>> Currently linux-next is failing to boot via NFS on my AM335x GP

Re: Backport Security Fix for CVE-2015-8787 to v4.1

On Thu, Apr 07, 2016 at 03:40:30PM +0900, Yuki Machida wrote: > Hi David, > > I conformed that a patch of CVE-2015-8787 not applied at v4.1.21. > Could you please apply a patch for 4.1-stable ? > > CVE-2015-8787 > Upstream commit 94f9cd81436c85d8c3a318ba92e236ede73752fc I'll request again, this

Re: [PATCH RFC] net: decrease the length of backlog queue immediately after it's detached from sk

On Thu, 2016-04-07 at 03:21 -0700, Eric Dumazet wrote: > Please do not send patches before really understanding the issue you > have. > > Having a backlog of 12506206 bytes is ridiculous. Dropping packets is > absolutely fine if this ever happens. > > Something is really wrong on your host, or

[PATCH net] vxlan: synchronously and race-free destruction of vxlan sockets

Due to the fact that the udp socket is destructed asynchronously in a work queue, we have some nondeterministic behavior during shutdown of vxlan tunnels and creating new ones. Fix this by keeping the destruction process synchronous in regards to the user space process so IFF_UP can be reliably

Re: veth regression with "don’t modify ip_summed; doing so treats packets with bad checksums as good."

On Fri, Mar 25, 2016 at 7:46 PM, Ben Greear wrote: > A real NIC can either do hardware checksums, or it cannot. If it > cannot, then the host must do it on the CPU for both transmit and > receive. > > Veth is not a real NIC, and it cannot do hardware checksum offloading.

[PATCH net-next 0/2] fix udp pull header breakage

From: Willem de Bruijn Commit e6afc8ace6dd ("udp: remove headers from UDP packets before queueing") modified udp receive processing to pull headers before enqueue and to not expect them on dequeue. The patch missed protocols on top of udp with in-kernel implementations that

[PATCH net-next 1/2] sunrpc: do not pull udp headers on receive

From: Willem de Bruijn Commit e6afc8ace6dd modified the udp receive path by pulling the udp header before queuing an skbuff onto the receive queue. Sunrpc also calls skb_recv_datagram to dequeue an skb from a udp socket. Modify this receive path to also no longer expect udp

Re: [PATCH net-next V3 05/16] net: fec: reduce interrupts

On 4/6/2016 8:57 PM, David Miller wrote: > From: Troy Kisky > Date: Wed, 6 Apr 2016 17:42:47 -0700 > >> Sure, that's an easy change. But if a TX int is what caused the >> interrupt and masks them, and then a RX packet happens before napi >> runs, do you want the

Re: Boot failure when using NFS on OMAP based evms

Currently linux-next is failing to boot via NFS on my AM335x GP evm, AM437x GP evm and Beagle X15. I bisected the problem down to the commit "udp: remove headers from UDP packets before queueing". >>> >>> Thanks for the report, and apologies for breaking your configuration. >>> I

Re: Boot failure when using NFS on OMAP based evms

On 04/06/2016 09:22 PM, Willem de Bruijn wrote: > On Wed, Apr 6, 2016 at 7:12 PM, Franklin S Cooper Jr. wrote: >> Hi All, >> >> Currently linux-next is failing to boot via NFS on my AM335x GP evm, >> AM437x GP evm and Beagle X15. I bisected the problem down to the commit >>

[PATCH net 0/2] tipc: name distributor pernet queue

Commit #1 fixes a potential issue with deferred binding table updates being pushed to the wrong namespace. Commit #2 solves a problem with deferred binding table updates remaining in the the defer queue after the issuing node has gone down. Erik Hugne (2): tipc: make dist queue pernet tipc:

[PATCH net 1/2] tipc: make dist queue pernet

From: Erik Hugne Nametable updates received from the network that cannot be applied immediately are placed on a defer queue. This queue is global to the TIPC module, which might cause problems when using TIPC in containers. To prevent nametable updates from escaping into

[PATCH net 2/2] tipc: purge deferred updates from dead nodes

From: Erik Hugne If a peer node becomes unavailable, in addition to removing the nametable entries from this node we also need to purge all deferred updates associated with this node. Signed-off-by: Erik Hugne Signed-off-by: Jon Maloy

Re: [PATCH net-next V3 00/16] net: fec: cleanup and fixes

On 4/6/2016 8:58 PM, David Miller wrote: > From: Troy Kisky > Date: Wed, 6 Apr 2016 18:09:17 -0700 > >> On 4/6/2016 2:20 PM, David Miller wrote: >>> >>> This is a way too large patch series. >>> >>> Please split it up into smaller, more logical, pieces. >>> >>>

[PATCH net-next 2/2] rxrpc: do not pull udp headers on receive

From: Willem de Bruijn Commit e6afc8ace6dd modified the udp receive path by pulling the udp header before queuing an skbuff onto the receive queue. Rxrpc also calls skb_recv_datagram to dequeue an skb from a udp socket. Modify this receive path to also no longer expect udp

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

> On Apr 7, 2016, at 7:38 AM, Christoph Hellwig wrote: > > This is also very interesting for storage targets, which face the same > issue. SCST has a mode where it caches some fully constructed SGLs, > which is probably very similar to what NICs want to do. +1 for NFS

Re: [LSF/MM TOPIC] Generic page-pool recycle facility?

On Thu, 2016-04-07 at 16:17 +0200, Jesper Dangaard Brouer wrote: > (Topic proposal for MM-summit) > > Network Interface Cards (NIC) drivers, and increasing speeds stress > the page-allocator (and DMA APIs). A number of driver specific > open-coded approaches exists that work-around these

Re: [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

This is also very interesting for storage targets, which face the same issue. SCST has a mode where it caches some fully constructed SGLs, which is probably very similar to what NICs want to do.

Re: [net-next 0/8][pull request] 1GbE Intel Wired LAN Driver Updates 2016-04-06

From: Jeff Kirsher Date: Wed, 6 Apr 2016 21:37:25 -0700 > This series contains updates to e1000, e1000e, igb and Kconfig. All looks sane, pulled, thanks Jeff.

Re: [PATCH] ieee802154/adf7242: fix memory leak of firmware

On 04/07/2016 01:16 PM, Sudip Mukherjee wrote: If the firmware upload or the firmware verification fails then we printed the error message and exited but we missed releasing the firmware. Signed-off-by: Sudip Mukherjee Acked-by: Michael Hennerich

[PATCH iproute2 3/4] ip-link.8: document "external" flag for vxlan

Signed-off-by: Jiri Benc --- man/man8/ip-link.8.in | 8 1 file changed, 8 insertions(+) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index 805511423ef2..f677f8c55365 100644 --- a/man/man8/ip-link.8.in +++ b/man/man8/ip-link.8.in @@ -422,6 +422,8 @@ the

[PATCH iproute2 2/4] vxlan: 'external' implies 'nolearning'

It doesn't make sense to use external control plane and fill internal FDB at the same time. It's even an illegal combination for VXLAN-GPE. Just switch off learning when 'external' is specified. Signed-off-by: Jiri Benc --- ip/iplink_vxlan.c | 1 + 1 file changed, 1

[PATCH iproute2 4/4] vxlan: add support for VXLAN-GPE

Adds support to create a VXLAN-GPE interface. Signed-off-by: Jiri Benc --- ip/iplink_vxlan.c | 13 +++-- man/man8/ip-link.8.in | 9 + 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c index

[PATCH iproute2 0/4] vxlan: add VXLAN-GPE support

This patchset adds a couple of refinements to the 'external' keyword and adds support for configuring VXLAN-GPE interfaces. The VXLAN-GPE support was recently merged to net-next. The first patch is not intended to be applied directly but I still include it in order for this patchset to be

[PATCH iproute2 1/4] if_link.h: rebase to the kernel

Not intended to be applied directly. Instead, I assume Stephen will rebase all headers to net-next as usual. Signed-off-by: Jiri Benc --- include/linux/if_link.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/if_link.h b/include/linux/if_link.h index

Re: [PATCH net-next] tcp/dccp: fix inet_reuseport_add_sock()

On 4/6/16 11:07 PM, Eric Dumazet wrote: From: Eric Dumazet David Ahern reported panics in __inet_hash() caused by my recent commit. The reason is inet_reuseport_add_sock() was still using sk_nulls_for_each_rcu() instead of sk_for_each_rcu(). SO_REUSEPORT enabled listeners

Re: [PATCH] wlcore: spi: add wl18xx support

Eyal Reizer writes: > Add support for using with both wl12xx and wl18xx. > > - all wilink family needs special init command for entering wspi mode. > extra clock cycles should be sent after the spi init command while the > cs pin is high. > - switch to controling the cs

[LSF/MM TOPIC] Generic page-pool recycle facility?

(Topic proposal for MM-summit) Network Interface Cards (NIC) drivers, and increasing speeds stress the page-allocator (and DMA APIs). A number of driver specific open-coded approaches exists that work-around these bottlenecks in the page allocator and DMA APIs. E.g. open-coded recycle

RE: [PATCH v7 net-next 1/1] hv_sock: introduce Hyper-V Sockets

> From: Joe Perches [mailto:j...@perches.com] > Sent: Thursday, April 7, 2016 19:30 > To: Dexuan Cui ; gre...@linuxfoundation.org; > da...@davemloft.net; netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; >

RE: [PATCH] wlcore: spi: add wl18xx support

> -Original Message- > From: Kalle Valo [mailto:kv...@codeaurora.org] > Sent: Thursday, April 07, 2016 3:25 PM > To: Eyal Reizer > Cc: linux-wirel...@vger.kernel.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Reizer, Eyal; devicet...@vger.kernel.org > Subject: Re: [PATCH]

Re: [PATCH net-next 5/7] sctp: reuse the some transport traversal functions in proc

On Tue, Apr 05, 2016 at 12:06:30PM +0800, Xin Long wrote: > There are some transport traversal functions for sctp_diag, we can also > use it for sctp_proc. cause they have the similar situation to traversal > transport. > > Signed-off-by: Xin Long > --- > net/sctp/proc.c |

[PATCH net-next v3 2/2] tipc: stricter filtering of packets in bearer layer

Resetting a bearer/interface, with the consequence of resetting all its pertaining links, is not an atomic action. This becomes particularly evident in very large clusters, where a lot of traffic may happen on the remaining links while we are busy shutting them down. In extreme cases, we may even

[PATCH net-next v3 0/2] tipc: some small fixes

When fix a minor buffer leak, and ensure that bearers filter packets correctly while they are being shut down. v2: Corrected typos in commit #3, as per feedback from S. Shtylyov v3: Removed commit #3 from the series. Improved version will be re-submitted later. Jon Maloy (2): tipc:

Re: [PATCH v2 2/2] sctp: delay calls to sk_data_ready() as much as possible

On Thu, Apr 07, 2016 at 10:05:32AM +0200, Jakub Sitnicki wrote: > On Wed, Apr 06, 2016 at 07:53 PM CEST, Marcelo Ricardo Leitner > wrote: > > Currently, the processing of multiple chunks in a single SCTP packet > > leads to multiple calls to sk_data_ready, causing

[PATCH net-next v3 1/2] tipc: eliminate buffer leak in bearer layer

When enabling a bearer we create a 'neigbor discoverer' instance by calling the function tipc_disc_create() before the bearer is actually registered in the list of enabled bearers. Because of this, the very first discovery broadcast message, created by the mentioned function, is lost, since it

[PATCH v6 net-next] net: ipv4: Consider failed nexthops in multipath routes

Multipath route lookups should consider knowledge about next hops and not select a hop that is known to be failed. Example: [h2] [h3] 15.0.0.5 | | 3| 3|

[PATCH v7 net-next 1/1] hv_sock: introduce Hyper-V Sockets

Hyper-V Sockets (hv_sock) supplies a byte-stream based communication mechanism between the host and the guest. It's somewhat like TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V Sockets, applications between the host and the guest can talk to each other

[PATCH] ieee802154/adf7242: fix memory leak of firmware

If the firmware upload or the firmware verification fails then we printed the error message and exited but we missed releasing the firmware. Signed-off-by: Sudip Mukherjee --- drivers/net/ieee802154/adf7242.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v7 net-next 1/1] hv_sock: introduce Hyper-V Sockets

On Thu, 2016-04-07 at 05:50 -0700, Dexuan Cui wrote: > Hyper-V Sockets (hv_sock) supplies a byte-stream based communication > mechanism between the host and the guest. It's somewhat like TCP over > VMBus, but the transportation layer (VMBus) is much simpler than IP. style trivia: > diff --git

Re: [PATCH V2 5/8] net: mediatek: fix mtk_pending_work

Hi John, [auto build test ERROR on net-next/master] [also build test ERROR on v4.6-rc2 next-20160407] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/John-Crispin/net-mediatek-make-the-driver

Re: [net-next:master 194/196] include/net/sock.h:1367:9: error: implicit declaration of function 'lockdep_is_held'

On Thu, Apr 7, 2016, at 23:09, David Miller wrote: > From: kbuild test robot > Date: Fri, 8 Apr 2016 05:00:42 +0800 > > >include/net/sock.h: In function 'lockdep_sock_is_held': > >>> include/net/sock.h:1367:9: error: implicit declaration of function > >>>

[PATCH net-next 1/2] udp: do not expect udp headers on ioctl SIOCINQ

From: Willem de Bruijn On udp sockets, ioctl SIOCINQ returns the payload size of the first packet. Since commit e6afc8ace6dd pulled the headers, the result is incorrect when subtracting header length. Remove that operation. Fixes: e6afc8ace6dd ("udp: remove headers from UDP

[PATCH net-next 0/2] fix two more udp pull header issues

From: Willem de Bruijn Follow up patches to the fixes to RxRPC and SunRPC. A scan of the code showed two other interfaces that expect UDP packets to have a udphdr when queued: read packet length with ioctl SIOCINQ and receive payload checksum with socket option IP_CHECKSUM.

[RFC PATCH 00/11] GSO partial and TSO FIXEDID support

This patch series represents my respun version of the GSO partial work. The major changes from the first version is that we are no longer making the decision to mangle IP IDs transparently at the device. Instead it is now pushed up to the tunnel layer itself so that the tunnel is not responsible

Re: [PATCH net-next] sock: make lockdep_sock_is_held static inline

On Thu, 2016-04-07 at 23:53 +0200, Hannes Frederic Sowa wrote: > I forgot to add inline to lockdep_sock_is_held, so it generated all > kinds of build warnings if not build with lockdep support. > > Reported-by: kbuild test robot > Signed-off-by: Hannes Frederic Sowa

[RFC PATCH 05/11] GSO: Support partial segmentation offload

This patch adds support for something I am referring to as GSO partial. The basic idea is that we can support a broader range of devices for segmentation if we use fixed outer headers and have the hardware only really deal with segmenting the inner header. The idea behind the naming is due to the

[RFC PATCH 04/11] GRO: Add support for TCP with fixed IPv4 ID field, limit tunnel IP ID values

This patch does two things. First it allows TCP to aggregate TCP frames with a fixed IPv4 ID field. As a result we should now be able to aggregate flows that were converted from IPv6 to IPv4. In addition this allows us more flexibility for future implementations of segmentation as we may be

[RFC PATCH 08/11] Documentation: Add documentation for TSO and GSO features

This document is a starting point for defining the TSO and GSO features. The whole thing is starting to get a bit messy so I wanted to make sure we have notes somwhere to start describing what does and doesn't work. Signed-off-by: Alexander Duyck ---

[RFC PATCH 10/11] ixgbe/ixgbevf: Add support for GSO partial

This patch adds support for partial GSO segmentation in the case of encapsulated frames. Specifically with this change the driver can perform segmentation as long as the type is either SKB_GSO_TCP_FIXEDID or SKB_GSO_TCPV6. If neither of these gso types are specified then tunnel segmentation is

[RFC PATCH 03/11] GSO: Add GSO type for fixed IPv4 ID

This patch adds support for TSO using IPv4 headers with a fixed IP ID field. This is meant to allow us to do a lossless GRO in the case of TCP flows that use a fixed IP ID such as those that convert IPv6 header to IPv4 headers. Signed-off-by: Alexander Duyck ---

[RFC PATCH 06/11] VXLAN: Add option to mangle IP IDs on inner headers when using TSO

This patch adds support for a feature I am calling IP ID mangling. It is basically just another way of saying the IP IDs that are transmitted by the tunnel may not match up with what would normally be expected. Specifically what will happen is in the case of TSO the IP IDs on the headers will be

Re: [PATCH net-next] sock: make lockdep_sock_is_held static inline

On Thu, 2016-04-07 at 15:30 -0700, Eric Dumazet wrote: > But... this wont solve the compiler error ? > > include/net/sock.h: In function 'lockdep_sock_is_held': > include/net/sock.h:1367:2: error: implicit declaration of function > 'lockdep_is_held' [-Werror=implicit-function-declaration] > In

[net-next:master 207/208] net/tipc/bearer.c:560:48: sparse: incompatible types in comparison expression (different base types)

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 889750bd2e08a94d52a116056d462b3a8e5616a7 commit: 5b7066c3dd24c7d538e5ee402eb24bb182c16dab [207/208] tipc: stricter filtering of packets in bearer layer reproduce: # apt-get install sparse

[PATCH net-next 2/2] udp: do not expect udp headers in recv cmsg IP_CMSG_CHECKSUM

From: Willem de Bruijn On udp sockets, recv cmsg IP_CMSG_CHECKSUM returns a checksum over the packet payload. Since commit e6afc8ace6dd pulled the headers, taking skb->data as the start of transport header is incorrect. Use the transport header pointer. Also, when peeking at

[RFC PATCH 02/11] ethtool: Add support for toggling any of the GSO offloads

The strings were missing for several of the GSO offloads that are available. This patch provides the missing strings so that we can toggle or query any of them via the ethtool command. Signed-off-by: Alexander Duyck --- net/core/ethtool.c |2 ++ 1 file changed, 2

[RFC PATCH 07/11] GENEVE: Add option to mangle IP IDs on inner headers when using TSO

This patch adds support for a feature I am calling IP ID mangling. It is basically just another way of saying the IP IDs that are transmitted by the tunnel may not match up with what would normally be expected. Specifically what will happen is in the case of TSO the IP IDs on the headers will be

[RFC PATCH 11/11] igb/igbvf: Add support for GSO partial

This patch adds support for partial GSO segmentation in the case of encapsulated frames. Specifically with this change the driver can perform segmentation as long as the type is either SKB_GSO_TCP_FIXEDID or SKB_GSO_TCPV6. If neither of these gso types are specified then tunnel segmentation is

[RFC PATCH 01/11] GRE: Disable segmentation offloads w/ CSUM and we are encapsulated via FOU

This patch fixes an issue I found in which we were dropping frames if we had enabled checksums on GRE headers that were encapsulated by either FOU or GUE. Without this patch I was barely able to get 1 Gb/s of throughput. With this patch applied I am now at least getting around 6 Gb/s. The issue

[RFC PATCH 09/11] i40e/i40evf: Add support for GSO partial with UDP_TUNNEL_CSUM and GRE_CSUM

This patch makes it so that i40e and i40evf can use GSO_PARTIAL to support segmentation for frames with checksums enabled in outer headers. As a result we can now send data over these types of tunnels at over 20Gb/s versus the 12Gb/s that was previously possible on my system. The advantage with

Re: [PATCH] net: mark DECnet as broken

From: One Thousand Gnomes Date: Thu, 7 Apr 2016 15:01:20 +0100 > On Thu, 7 Apr 2016 09:22:43 +0200 > Vegard Nossum wrote: > >> There are NULL pointer dereference bugs in DECnet which can be triggered >> by unprivileged users and have been

[PATCH] net: vrf: Fix dst reference counting

Vivek reported a kernel exception deleting a VRF with an active connection through it. The root cause is that the socket has a cached reference to a dst that is destroyed. Converting the dst_destroy to dst_release and letting proper reference counting kick in does not work as the dst has a

[PATCH] net: vrf: Fix dev refcnt leak due to IPv6 prefix route

ifupdown2 found a kernel bug with IPv6 routes and movement from the main table to the VRF table. Sequence of events: Create the interface and add addresses: ip link add dev eth4.105 link eth4 type vlan id 105 ip addr add dev eth4.105 8.105.105.10/24 ip -6 addr add dev eth4.105

Re: veth regression with "don’t modify ip_summed; doing so treats packets with bad checksums as good."

On 04/07/2016 08:11 AM, Vijay Pandurangan wrote: On Fri, Mar 25, 2016 at 7:46 PM, Ben Greear wrote: A real NIC can either do hardware checksums, or it cannot. If it cannot, then the host must do it on the CPU for both transmit and receive. Veth is not a real NIC, and

Re: [RFC PATCH net 3/4] ipv6: datagram: Update dst cache of a connected datagram sk during pmtu update

On Wed, Apr 6, 2016 at 11:49 AM, Martin KaFai Lau wrote: > On Wed, Apr 06, 2016 at 10:58:23AM -0700, Cong Wang wrote: >> On Tue, Apr 5, 2016 at 5:11 PM, Martin KaFai Lau wrote: >> > On Mon, Apr 04, 2016 at 01:45:02PM -0700, Cong Wang wrote: >> >> I see your point, but

Re: [PATCH 1/9] net: mediatek: update the IRQ part of the binding document

Every patch series must begin with a postings labelled "[PATCH 0/9] ..." which explains what the series is doing, how it is implementing that, and why it is implemented that way.

Re: [RFC PATCH 0/2] selinux: avoid nf hooks overhead when not needed

On Thursday, April 07, 2016 01:45:32 AM Florian Westphal wrote: > Paul Moore wrote: > > On Wed, Apr 6, 2016 at 6:14 PM, Florian Westphal wrote: > > > netfilter hooks are per namespace -- so there is hook unregister when > > > netns is destroyed. > > > >

Re: [RFC PATCH net 3/4] ipv6: datagram: Update dst cache of a connected datagram sk during pmtu update

On Thu, Apr 07, 2016 at 11:37:10AM -0700, Cong Wang wrote: > You are lost in discussion Indeed. :( > > I still think it is okay without the lock, because even if you take the lock, > the pmtu update could still happen after you release it, so there is no > essential difference here. The only

[PATCH 7/9] net: mediatek: fix TX locking

Inside the TX path there is a lock inside the tx_map function. This is however too late. The patch moves the lock to the start of the xmit function right before the free count check of the DMA ring happens. If we do not do this, the code becomes racy leading to TX stalls and dropped packets. This

[PATCH 1/9] net: mediatek: update the IRQ part of the binding document

The current binding document only describes a single interrupt. Update the document by adding the 2 other interrupts. The driver currently only uses a single interrupt. The HW is however able to using IRQ grouping to split TX and RX onto separate GIC irqs. Signed-off-by: John Crispin

[PATCH net-next] net: ipv6: Use passed in table for nexthop lookups

Similar to 3bfd847203c6 ("net: Use passed in table for nexthop lookups") for IPv4, if the route spec contains a table id use that to lookup the next hop first and fall back to a full lookup if it fails (per the fix 4c9bcd117918b ("net: Fix nexthop lookups")). Example: root@kenny:~# ip -6 ro

Re: [PATCH net-next 5/7] sctp: reuse the some transport traversal functions in proc

On Thu, Apr 07, 2016 at 09:09:30AM -0400, Neil Horman wrote: > On Tue, Apr 05, 2016 at 12:06:30PM +0800, Xin Long wrote: > > There are some transport traversal functions for sctp_diag, we can also > > use it for sctp_proc. cause they have the similar situation to traversal > > transport. > > > >

[PATCH 3/9] net: mediatek: mtk_cal_txd_req() returns bad value

The code used to also support the PDMA engine, which had 2 packet pointers per descriptor. Because of this we had to divide the result by 2 and round it up. This is no longer needed as the code only supports QDMA. Signed-off-by: John Crispin ---

Re: [PATCH RFC 1/5] net: phy: sun8i-h3-ephy: Add bindings for Allwinner H3 Ethernet PHY

On Tue, Apr 05, 2016 at 12:22:30AM +0800, Chen-Yu Tsai wrote: > The Allwinner H3 SoC incorporates an Ethernet PHY. This is enabled and > configured through a memory mapped hardware register. > > This same register also configures the MAC interface mode and TX clock > source. Also covered by the

Re: [PATCH net-next 3/7] sctp: export some functions for sctp_diag in inet_diag

On Tue, Apr 05, 2016 at 12:06:28PM +0800, Xin Long wrote: > inet_diag_msg_common_fill is used to fill the diag msg common info, > we need to use it in sctp_diag as well, so export it. > > We also add inet_diag_get_handler() to access inet_diag_table in sctp > diag. > > Signed-off-by: Xin Long

[PATCH v5 net-next 02/15] nfp: move link state interrupt request/free calls

We need to be able to disable the link state interrupt when the device is brought down. We used to just free the IRQ at the beginning of .ndo_stop(). As we now move towards more ordered .ndo_open()/.ndo_stop() paths LSC allocation should be placed in the "allocate resource" section. Since the

[PATCH v5 net-next 00/15] MTU/buffer reconfig changes

Hi! I re-discussed MPLS/MTU internally, dropped it from the patch 1, re-tested everything, found out I forgot about debugfs pointers, fixed that as well. v5: - don't reserve space in RX buffers for MPLS label stack (patch 1); - fix debugfs pointers to ring structures (patch 5). v4: - cut

[PATCH v5 net-next 04/15] nfp: make *x_ring_init do all the init

nfp_net_[rt]x_ring_init functions used to be called from probe path only and some of their functionality was spilled to the call site. In order to reuse them for ring reconfiguration we need them to do all the init. Signed-off-by: Jakub Kicinski ---

[PATCH v5 net-next 08/15] nfp: preallocate RX buffers early in .ndo_open

We want the .ndo_open() to have following structure: - allocate resources; - configure HW/FW; - enable the device from stack perspective. Therefore filling RX rings needs to be moved to the beginning of .ndo_open(). Signed-off-by: Jakub Kicinski ---

[PATCH 2/9] net: mediatek: watchdog_timeo was not set

The original commit failed to set watchdog_timeo. This patch sets watchdog_timeo to HZ. Signed-off-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth_soc.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c

[PATCH 6/9] net: mediatek: fix mtk_pending_work

The driver supports 2 MACs. Both run on the same DMA ring. If we hit a TX timeout we need to stop both netdevs before restarting them again. If we don't do this, mtk_stop() wont shutdown DMA and the consecutive call to mtk_open() wont restart DMA and enable IRQs. Signed-off-by: John Crispin

[PATCH 4/9] net: mediatek: remove superfluous reset call

HW reset is triggered in the mtk_hw_init() function. There is no need to also reset the core during probe. Signed-off-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth_soc.c |4 1 file changed, 4 deletions(-) diff --git

[PATCH 8/9] net: mediatek: move the pending_work struct to the device generic struct

The worker always touches both netdevs. It is ethernet core and not MAC specific. We only need one worker, which belongs into the ethernets core struct. Signed-off-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 10 --

[PATCH 5/9] net: mediatek: fix stop and wakeup of queue

The driver supports 2 MACs. Both run on the same DMA ring. If we go above/below the TX rings threshold value, we always need to wake/stop the queue of both devices. Not doing to can cause TX stalls and packet drops on one of the devices. Signed-off-by: John Crispin ---

[PATCH 9/9] net: mediatek: do not set the QID field in the TX DMA descriptors

The QID field gets set to the mac id. This made the DMA linked list queue the traffic of each MAC on a different internal queue. However during long term testing we found that this will cause traffic stalls as the multi queue setup requires a more complete initialisation which is not part of the

[PATCH] net-next: mediatek: add support for IRQ grouping

The ethernet core has 3 IRQs. Using the IRQ grouping registers we are able to separate TX and RX IRQs, which allows us to service them on separate cores. This patch splits the IRQ handler into 2 separate functions, one for TX and another for RX. The TX housekeeping is split out of the NAPI

Re: How to get creatior PID information for the local tcp connection

On Thu, 2016-04-07 at 23:01 +0530, Vishnu Pratap Singh wrote: > Hi, > > > Issue - How to get PID information for the local tcp connection > > > > i want to get the creator PID for each socket in user space for local > tcp connection, i see in kernel there is support for returing PID with >

Re: How to get creatior PID information for the local tcp connection

On Thu, 2016-04-07 at 11:26 -0700, Eric Dumazet wrote: > On Thu, 2016-04-07 at 23:01 +0530, Vishnu Pratap Singh wrote: > > Hi, > > > > > > Issue - How to get PID information for the local tcp connection > > > > > > > > i want to get the creator PID for each socket in user space for local > >

Re: [PATCH net-next 0/7] sctp: support sctp_diag in kernel

On Tue, Apr 05, 2016 at 12:06:25PM +0800, Xin Long wrote: > This patchset will add sctp_diag module to implement diag interface on > sctp in kernel. ... Other than the const thing and the point noticed by Neil which need to be fixed, patchset looks good to me. Marcelo

[PATCH v5 net-next 12/15] nfp: propagate list buffer size in struct rx_ring

Free list buffer size needs to be propagated to few functions as a parameter and added to struct nfp_net_rx_ring since soon some of the functions will be reused to manage rings with buffers of size different than nn->fl_bufsz. Signed-off-by: Jakub Kicinski ---

[PATCH v5 net-next 01/15] nfp: correct RX buffer length calculation

When calculating the RX buffer length we need to account for up to 2 VLAN tags. Rounding up to 1k is an relic of a distant past and can be removed. While at it also remove trivial print statement. Signed-off-by: Jakub Kicinski ---

  1   2   3   >